RFR (XXS) 8183238 Obsolete CheckEndorsedAndExtDirs and remove checks for lib/endorsed and lib/ext

mandy chung mandy.chung at oracle.com
Fri Mar 30 00:15:01 UTC 2018

On 3/30/18 7:24 AM, David Holmes wrote:
> On 30/03/2018 4:16 AM, Ioi Lam wrote:
>> Hi Alan,
>> Thanks for the reminder of the other files. I checked all the files 
>> in the open and closed repos with 'grep -r CheckEndorsedAndExtDirs'. 
>> I found only 3 man pages in the open repo that contained references 
>> to CheckEndorsedAndExtDirs. No test cases or any other files refer to 
>> this option.
>> Here's an updated webrev that added the changes to the mage pages. It 
>> also removes the dead code in arguments.cpppointed out by Mandy and 
>> David.
>> http://cr.openjdk.java.net/~iklam/jdk11/8183238-obsolete-CheckEndorsedAndExtDirs.v02/ 

Looks fine.

Can you file a docs issue to update the java tool reference guide [1] to 
take out the option?

> Seems okay, though I thought the man page sources were "dead" anyway. 
> Surprised to still see them there.

These out-of-date man pages are for OpenJDK build and they were 
generated by the docs team and dropped in the repo.

Jon and I have discussed to include the man pages in our source in 
markdown and the build can generate the man pages in proper formats and 
include in the docs bundle.   Developers will update them for any change 
to CLI options and the man pages will always be up-to-date.  I think 
that's a good improvement and hope to happen some time.

[1] https://docs.oracle.com/javase/10/tools/java.htm#JSWOR624

More information about the hotspot-dev mailing list