RFR (XL) 8081519 Split globals.hpp to factor out the Flag class

coleen.phillimore at oracle.com coleen.phillimore at oracle.com
Fri Mar 30 19:08:31 UTC 2018


Is CounterSetting unused?   Are these <type>FlagSetting used?   
SizeTFlagSetting ?

Can you make plain FlagSetting inherit from public StackObj.   The same 
with FlagGuard (and remove comment and new/delete operators) but this 
class appears unused as well.  Can you remove the unused classes?  If 
they're ever needed, they can be added again in the model of 
FlagSetting, which is used.

This will make jvmFlag.hpp have less in it, which is good because it 
needs to be included in more places.


On 3/30/18 1:27 PM, Gerard Ziemski wrote:
> Hi all,
> Please review this large and tedious (sorry), but simple fix that accomplishes the following:
> #1 factor out the command option flag related APIs out of globals.hpp/.cpp into its own dedicated files, i.e. jvmFlag.hpp/.cpp
> #2 moved all jvmFlag* files into its own dedicated folder (i.e. src/hotspot/share/runtime/jvmFlag/)
> #3 merge Flag (too generic name) and CommandLineFlag classes and rename them as JVMFlag
> #4 cleanup globals.hpp includes originally added by the JEP-245
> Note: the renamed file retain their history, but one needs to add “follow” flag, ex. “hg log -f file”
> https://bugs.openjdk.java.net/browse/JDK-8081519
> http://cr.openjdk.java.net/~gziemski/8081519_rev2
> Passes Mach5 hs_tier1-tier5, jtreg/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges tests.
> cheers

More information about the hotspot-dev mailing list