RFR: JDK-8213480: update internal ASM version to 7.0

Vicente Romero vicente.romero at oracle.com
Thu Nov 8 02:26:20 UTC 2018

Hi Igor,

On 11/7/18 2:33 PM, Igor Ignatyev wrote:
> Hi Vicente,
> I recall an (internal?) discussion about updating ASM somewhen in JDK 
> 11TF, and AFAIR it was decided not to update ASM b/c nothing in JDK 
> needs that, has it been changed? put somewhat differently, why are we 
> doing this?

we need the support ASM 7 has of condy, many amber projects depend on this

> in any case, I don't like the changes in mlvm tests. I understand 
> that ClassWriter has been significantly changed in ASM 7.0, 
> so ClassWriterExt can't disable CP entries caching (at least not in 
> the way it used to), but removing setCache* calls from the tests 
> changed them and in some cases made them invalid as they don't test 
> that they supposed to. therefore I'd prefer to leave all calls 
> setCache* as-is, change setCache* implementation to throw an exception 
> (similarly to the fix in JDK-8194826 
> <https://bugs.openjdk.java.net/browse/JDK-8194826>) and mark all tests 
> which throw this exception w/ '@ignore 8194951' jtreg tag.

sounds good, I will do this

> Thanks,
> -- Igor


>> On Nov 7, 2018, at 7:56 AM, Vicente Romero <vicente.romero at oracle.com 
>> <mailto:vicente.romero at oracle.com>> wrote:
>> Hi,
>> Version 7.0 of ASM has been released. This version supports condy, 
>> yay!, and we want to include it in JDK 12. Please review [1] which 
>> includes:
>> - the new version perse substituting the preview ASM internal version 
>> in the JDK
>> - changes to additional files in particular some tests, mostly 
>> hotspot tests.
>> Thanks,
>> Vicente
>> [1] http://cr.openjdk.java.net/~vromero/8213480/webrev.00/

More information about the hotspot-dev mailing list