RFR: JDK-8213480: update internal ASM version to 7.0
igor.ignatyev at oracle.com
Fri Nov 9 16:25:49 UTC 2018
back when we 1st bumped into this problem w/ ClassWriterExt (about 1y ago), it was my AI to discuss it w/ Remi. I sent him an email, didn't get a replay, and as it usually goes, had to switch to something else, completely forgot about that and didn't follow up.
> On Nov 8, 2018, at 8:40 AM, Vicente Romero <vicente.romero at oracle.com> wrote:
> On 11/8/18 8:14 AM, Alan Bateman wrote:
>> On 07/11/2018 19:33, Igor Ignatyev wrote:
>>> Hi Vicente,
>>> I recall an (internal?) discussion about updating ASM somewhen in JDK 11TF, and AFAIR it was decided not to update ASM b/c nothing in JDK needs that, has it been changed? put somewhat differently, why are we doing this?
>>> in any case, I don't like the changes in mlvm tests. I understand that ClassWriter has been significantly changed in ASM 7.0, so ClassWriterExt can't disable CP entries caching (at least not in the way it used to), but removing setCache* calls from the tests changed them and in some cases made them invalid as they don't test that they supposed to. therefore I'd prefer to leave all calls setCache* as-is, change setCache* implementation to throw an exception (similarly to the fix in JDK-8194826 <https://bugs.openjdk.java.net/browse/JDK-8194826>) and mark all tests which throw this exception w/ '@ignore 8194951' jtreg tag.
>> ClassWriterExt the MLVM tests have come in previous upgrades too. Has there been any discussion Remi or others on ASM to make it easier for the JDK to upgrade?
> I'm not aware of any such discussions.
More information about the hotspot-dev