RFR: JDK-8213480: update internal ASM version to 7.0
vicente.romero at oracle.com
Wed Nov 14 03:31:25 UTC 2018
Thanks for your comment. I have already applied in my local copy.
On 11/13/18 8:30 PM, Igor Ignatyev wrote:
> Hi Vicente,
> you need to replace "@ignore 8194951: some mlvm tests fail w/ ASMv7" w/ "@ignore 8194951" in all the occurrences, as we have monitoring tools which expect @ignore to be followed by a space-separated list of bug ids. the rest looks good to me.
> -- Igor
>> On Nov 13, 2018, at 5:11 PM, Vicente Romero <vicente.romero at oracle.com> wrote:
>> Hi Alan,
>> On 11/13/18 9:18 AM, Alan Bateman wrote:
>>> On 13/11/2018 14:00, Vicente Romero wrote:
>>>> any other comment after the last iteration? we are in a bit of a hurry to push this before the JDK 12 train departs :(
>>> The original patch updated all the use sites (and tests) to specify ASM7 for the API version. I just checked the webrev again now and it seems to be just the ASM refresh now. Assuming all the tests are passing and you've sorted out the mvlm test issues with Igor then I suggest go ahead with this push and we can update the sites, as needed, at a later time.
>> in the last update I sent links to two patches  is the ASM7 only changes and  is the changes to the use sites. My plan is to push both together, but I split them to ease the review process. But still I will get your go and push it as good ;)
>>  http://cr.openjdk.java.net/~vromero/8213480/webrev.asm.7.only.00/
>>  http://cr.openjdk.java.net/~vromero/8213480/webrev.asm.7.additional.changes.00/
More information about the hotspot-dev