RFR(T): 8214206: Fix for JDK-8213419 is broken on 32-bit

Doerr, Martin martin.doerr at sap.com
Thu Nov 22 15:21:40 UTC 2018


I guess we only need to use log2_jint in c1_LIRGenerator_s390.cpp to fix build on your new companies most expensive platform ��

Best regards,

-----Original Message-----
From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of Aleksey Shipilev
Sent: Donnerstag, 22. November 2018 16:00
To: Roland Westrelin <rwestrel at redhat.com>; hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>
Subject: Re: RFR(T): 8214206: Fix for JDK-8213419 is broken on 32-bit

On 11/22/18 3:14 PM, Roland Westrelin wrote:
> http://cr.openjdk.java.net/~roland/8214206/webrev.00/
> The log2_intptr(int x) and log2_intptr(intptr_t x) conflict on 32 bit.

I don't think conditional compilation is the answer here. It seems better to have declarations that
are guaranteed not to clash. For example:

This builds on x86_32 and x86_64 without problems. STATIC_ASSERTS help to find the jlong downcast
issue Goetz mentioned in his note, and I believe the answer is "unsigned long long". Roland, feel
free to use this patch either partially or in full.


More information about the hotspot-dev mailing list