RFR : [XXS] 8214297: testbug : missing fclose in jvmti_aod.cpp
jcbeyler at google.com
Tue Nov 27 03:27:53 UTC 2018
Looks good to me as well, in a similar style of bug for the same method; it
seems we are leaking classBytes if we go down two of the error paths.
Different bug and different fix of course :)
On Mon, Nov 26, 2018 at 6:29 AM <coleen.phillimore at oracle.com> wrote:
> I agree. Looks good and trivial to push now.
> On 11/26/18 8:15 AM, Thomas Stüfe wrote:
> > Looks fine Matthias.
> > ..Thomas
> > On Mon, Nov 26, 2018 at 2:12 PM Baesken, Matthias
> > <matthias.baesken at sap.com> wrote:
> >> Please review this small test fix.
> >> It adds an fclose in an early return case to function
> nsk_jvmti_aod_redefineClass .
> >> Bug/webrev :
> >> https://bugs.openjdk.java.net/browse/JDK-8214297
> >> http://cr.openjdk.java.net/~mbaesken/webrevs/8214297.0/
> >> Thanks ,Matthias
More information about the hotspot-dev