RFR : [XS] 8214373: adjust usage of ReleaseLongArrayElements in MacosxDebuggerLocal

Baesken, Matthias matthias.baesken at sap.com
Wed Nov 28 08:18:19 UTC 2018

Hi Thomas and JC , thanks for the  reviews !

Best regards, Matthias

From: JC Beyler <jcbeyler at google.com>
Sent: Dienstag, 27. November 2018 16:48
To: Baesken, Matthias <matthias.baesken at sap.com>
Cc: hotspot-dev Source Developers <hotspot-dev at openjdk.java.net>; serviceability-dev at openjdk.java.net
Subject: Re: RFR : [XS] 8214373: adjust usage of ReleaseLongArrayElements in MacosxDebuggerLocal

Hi Matthias,

Not a reviewer but looks good to me :). I checked if other releases were not in the right place and they all seemed good as well.

On Tue, Nov 27, 2018 at 7:09 AM Baesken, Matthias <matthias.baesken at sap.com<mailto:matthias.baesken at sap.com>> wrote:
Hello, please review this small fix .

In  MacosxDebuggerLocal.m ,  at a few places  the  functions   GetLongArrayElements  and  ReleaseLongArrayElements  are used.

However  there is one place  where in an early return  the ReleaseLongArrayElements call has been forgotten .

Additionally at another place  ReleaseLongArrayElements   is at the wrong place (although this is probably not a big issue  currently).




Thanks, Matthias



More information about the hotspot-dev mailing list