RFR(S): 8210381: Obsolete EmitSync
mikael.vidstedt at oracle.com
Tue Sep 4 20:04:33 UTC 2018
My tier1 build & test job passed. I’ll also try to spend a few minutes seeing if I can verify that the resulting code actually ends up being the same.
> On Sep 4, 2018, at 12:53 PM, Vladimir Kozlov <vladimir.kozlov at oracle.com> wrote:
> Looks good.
> What testing you did?
> On 9/4/18 12:36 PM, Mikael Vidstedt wrote:
>> Please review this change which obsoletes the EmitSync flag. In particular, I could use some help from ppc, aarch64, and s390 maintainers to verify that the change actually builds and (still) works.
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210381 <https://bugs.openjdk.java.net/browse/JDK-8210381>
>> Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8210381/webrev.00/open/webrev/ <http://cr.openjdk.java.net/~mikael/webrevs/8210381/webrev.00/open/webrev/>
>> * Background (from bug)
>> The experimental EmitSync flag can in theory be used to select which implementation of the synchronization primitives to use. The flag was convenient when the various implementations were compared a long time ago.
>> In practice the only implementation that is used and tested today is the default one. The EmitSync flag no longer serves the purpose it used to, and is "Unsafe, Unstable" (the documentation of the flag says so explicitly). It should be obsoleted and later removed.
More information about the hotspot-dev