RFR: 8165440: Add zero support for x86_64-linux-gnux32 target
John Paul Adrian Glaubitz
glaubitz at physik.fu-berlin.de
Wed Sep 5 07:23:02 UTC 2018
You’re right, sorry. I haven’t been around OpenJDK for some weeks and forgot about posting to build-dev when posting.
I will push in around 2-3 hours, currently on a train.
> On Sep 5, 2018, at 9:05 AM, Magnus Ihse Bursie <magnus.ihse.bursie at oracle.com> wrote:
>> On 2018-09-04 23:29, David Holmes wrote:
>> Hi Adrian,
>> All changes that touch the build system must be reviewed by build-dev - now cc'd.
> This has been discussed at some length in build-dev. But I agree, it's good that also the actual RFR is cc:ed here.
> The patch, unsurprisingly, LGTM.
>> These changes seem reasonable, though I don't like adding changes in source code for such an obscure (and unsupported!) platform.
>>> On 5/09/2018 3:45 AM, John Paul Adrian Glaubitz wrote:
>>> This rather small change adds build support for the x86_64-linux-gnux32
>>> target. x32 is a variant of the x86_64 ABI with 64-bit registers and amd64
>>> instruction set but 32-bit pointers .
>>> One of the Linux distributions supporting x32 is Debian, see . The
>>> port is not official, but the large majority of packages build fine
>>> and the toolchain is in good shape. Another distribution supporting
>>> x32 is Gentoo.
>>> Please review the change in . I have changed the original patch
>>> a bit that Debian uses downstream to make the changes more consistent
>>> and cleaner.
>>>>  https://en.wikipedia.org/wiki/X32_ABI
>>>>  http://debian-x32.org/
>>>>  http://cr.openjdk.java.net/~glaubitz/8165440/webrev.00/
More information about the hotspot-dev