What's the point of test/hotspot/jtreg/runtime/jsig?
david.holmes at oracle.com
Sun Sep 23 14:53:26 UTC 2018
On 23/09/2018 10:33 AM, Thomas Matthijs wrote:
> Maybe this one ? apologies if incorrect
You're absolutely correct - thanks! I checked July and June manually but
didn't go back to May (wow that was a long delay between review and push!).
The Testjsig.java file indeed seems to have been omitted from the
commit. I can fix that today.
> On Sun, 23 Sep 2018 at 15:53, David Holmes <david.holmes at oracle.com
> <mailto:david.holmes at oracle.com>> wrote:
> This was done by:
> "8144279: [TESTBUG] hotspot/runtime/jsig/Test8017498.sh should use
> native library build support"
> I would have to guess the main test file was not hg added for the
> commit. But I can't find the code review for it.
> I've filed:
> On 21/09/2018 6:48 PM, David Holmes wrote:
> > Hi Severin,
> > I would have to guess that this was intended to be converted to a
> > test and either the main test file was not hg added, or else ...
> > I can't find the changeset that removed the sh file to try and
> see what
> > happened. Between file renames and repo reorgs hg log doesn't
> seem to be
> > able to track this.
> > David
> > On 21/09/2018 11:22 AM, Severin Gehwolf wrote:
> >> Hi,
> >> test/hotspot/jtreg/runtime/jsig seems to have come in with
> >> However, corresponding Test8017498.sh seems to have been removed
> >> and nothing exercises this code as far as I can see. I wonder what's
> >> the point of it?
> >> There are two options as I see it:
> >> 1)
> >> Remove dead code in test/hotspot/jtreg/runtime/jsig
> >> 2)
> >> Rework old Test8017498.sh so that it actually uses
> >> in test/hotspot/jtreg/runtime/jsig.
> >> Which one should it be? I can work on a webrev once it's known
> what do
> >> do.
> >> Thanks,
> >> Severin
> >> 
More information about the hotspot-dev