RFR : 8211213: fix aix build after 8196341: Add JFR events for parallel phases of G1
leo.korinth at oracle.com
Thu Sep 27 19:25:13 UTC 2018
This is no review.
I did something similar
(http://cr.openjdk.java.net/~lkorinth/8211213/00/) to you Aleksey before
I noticed your solution.
I prefer your version to my own as your version makes the JFR disabled
class closer to the JFR enabled one (with regards to templates). I was
more conservative (and did it a bit different). I do not know the reason
for this template difference, nor the difference with regards to the
protected constructor and non-argument commit that also differ and is
public in the JFR disabled class.
I guess these differences are by mistake, but maybe it would be good if
it was confirmed by the JFR people.
On 27/09/18 20:03, Aleksey Shipilev wrote:
> On 09/27/2018 04:39 PM, Baesken, Matthias wrote:
>> Hi Thomas, do you know some fast and helpful person who can bring the INCLUDE_JFR and ! INCLUDE_JFR cases in sync ?
>> (or maybe there was a reason to have these differences we observe ? )
> I am not a JFR person, but I think this should do it -- I copied printCommitMethod into
> printEmptyEvent and gutted it:
> This fixes x86_64 Zero build.
More information about the hotspot-dev