RFR(M): 8233787: Break cycle in vm_version* includes

Schmidt, Lutz lutz.schmidt at sap.com
Mon Nov 18 12:05:10 UTC 2019

Hi Martin,
thank you for going through all these "simple" modifications. And thanks for the review!
I'll send the stuff through jdk/submit and then push it. 

On 18.11.19, 13:02, "Doerr, Martin" <martin.doerr at sap.com> wrote:

    Hi Lutz,
    I've looked over the complete webrev .03 and it looks good to me.
    I appreciate having the abstract version in separate files and the regular vm_version basically include the platform stuff.
    Best regards,
    > -----Original Message-----
    > From: hotspot-dev <hotspot-dev-bounces at openjdk.java.net> On Behalf Of
    > Kim Barrett
    > Sent: Samstag, 16. November 2019 00:00
    > To: Schmidt, Lutz <lutz.schmidt at sap.com>
    > Cc: hotspot-dev at openjdk.java.net
    > Subject: Re: RFR(M): 8233787: Break cycle in vm_version* includes
    > > On Nov 15, 2019, at 7:19 AM, Schmidt, Lutz <lutz.schmidt at sap.com> wrote:
    > >
    > > Hi Kim,
    > >
    > > thanks for reviewing - I understand your comments that way. One more
    > review to go. :-)
    > >
    > > I made abstract_vm_version.cpp #include vm_version.hpp, and I updated
    > the copyrights. See the webrev#03:
    > >  http://cr.openjdk.java.net/~lucy/webrevs/8233787.03/
    > >
    > > I ran the initial webrev iteration through dev-submit and had it active SAP-
    > internally. The current webrev is active since last night SAP-internally. All
    > builds are green. The test show only unrelated issues (some JIT compiler
    > asserts). Of course I will run the final webrev through dev-submit.
    > >
    > > Re test coverage: we do not cover 32-bit platforms. And we do not have
    > zero or minimal builds.
    > Looks good.

More information about the hotspot-dev mailing list