RFR (S): 8233702: Introduce helper function to clamp value to range
thomas.schatzl at oracle.com
Fri Nov 22 09:03:06 UTC 2019
On 21.11.19 15:38, Stefan Johansson wrote:
> Hi Thomas,
> On 2019-11-15 10:02, Thomas Schatzl wrote:
>> Hi Kim,
>> On 14.11.19 23:52, Kim Barrett wrote:
>>>> On Nov 14, 2019, at 10:58 AM, Thomas Schatzl
>>>> <thomas.schatzl at oracle.com> wrote:
>>>> New webrevs:
>>>> http://cr.openjdk.java.net/~tschatzl/8233702/webrev.1_to_2/ (diff)
>>>> http://cr.openjdk.java.net/~tschatzl/8233702/webrev.2/ (full)
>>>> Passed hs-tier1-5.
>>> Looks good.
> Looks good, I really like this change.
> One nit, I would like the comment where we can't use clamp in
> threadLocalAllocBuffer.cpp to be a bit more specific saying that we will
> assert if using it. Now I could not figure out what would be different
> without looking at the impl of clamp.
> No need for an extra review though, push at will.
Done. Thanks for your review.
More information about the hotspot-dev