RFR: 8234741: enhance os::get_core_path on macOS
david.holmes at oracle.com
Tue Nov 26 09:32:51 UTC 2019
On 26/11/2019 6:36 pm, Baesken, Matthias wrote:
> OK I'll do a separate change .
> Are you fine with the rest of the patch ?
Sorry not an area I'm familiar with. Hoping one of our mac fans can
chime in on this one. I agree in principle but don't know the details.
Probably going to be a slow week for reviews due to US Thanksgiving
> Best regards, Matthias
>> On 25/11/2019 11:44 pm, Baesken, Matthias wrote:
>>> Currently the macOS implementation of os::get_core_path just displays
>> the default core file location.
>>> However it does not handle/show other locations set by the sysctl
>> parameter "kern.corefile" . This is enhanced by this change .
>>> I also take care of handling %P which is used a lot for the pid-placeholder
>> on macOS in the "kern.corefile" parameter .
>>> ( additionally the change contains a one-liner adjustment in
>> src/java.desktop/macosx/native/libawt_lwawt/awt/AWTView.h to be able
>> to compile again on older macOs versions)
>> That issue is being discussed elsewhere by the client folk and should
>> not be part of this change.
>>> Bug / webrev :
>>> Thanks, Matthias
More information about the hotspot-dev