RFR: 8234748: Clean up atomic and orderAccess includes
thomas.schatzl at oracle.com
Wed Nov 27 10:20:18 UTC 2019
thanks for tackling this.
On 26.11.19 12:11, Stefan Karlsson wrote:
> Hi all,
> Please review this trivial, but large, patch to cleanup the includes of
> atomic.hpp and orderAccess.hpp.
I did the following bash-fu to find missing/superfluous includes:
grep "Atomic::" `find . -name '*.?pp'` | sed 's/\(.*pp\):.*/\1/' |
uniq | sort > users.txt
$ grep "atomic.hpp" `find . -name '*.?pp'` | sed 's/\(.*\):.*/\1/' |
uniq | sort > includers.txt
$ diff users.txt includers.txt > diff.txt
diff.txt then contained the differences, with some false positives, all
about containing the keywords in comments. Otherwise I think this should
The same has been done with "OrderAccess::" and "orderAccess.hpp".
Here are the results:
Improvements to orderAccess.hpp includes:
- gc/shenandoah/shenandoahVerifier.cpp misses it
- the #include from gc/z/zLiveMap.inline.hpp should maybe be moved to
Improvements to atomic.hpp includes:
In the following files the include of atomic.hpp should be removed as it
The following need a #include atomic.hpp:
Looks good otherwise.
More information about the hotspot-dev