Code Review Request: 6819085 G1: use larger and/or user settable region size

Jon Masamitsu Jon.Masamitsu at Sun.COM
Tue Aug 4 14:08:04 PDT 2009


g1CollectedHeap.hpp

Does this deserve a comment on what it is or
what it is used for?

173   static size_t _very_large_in_words;

Ok, having read down a little further, how about
just changing the variable to _humungous_region_threshold.

arguments.cpp


1281 // Maximum region size; we don't go higher than that
1282 #define MAX_REGION_SIZE  ( 32 * 1024 * 1024 )

A comment on why there is a max would be nice.


heapRegion.hpp

Just because set_heap_region_size() looks like an
accessor function, a comment that it is doing more
than just setting a field would be helpful.

  306   static void set_heap_region_size(uintx heap_region_size_bytes,
  307                                    uintx heap_region_size_log);


Otherwise, looks good.


On 07/30/09 14:21, Tony Printezis wrote:
> http://cr.openjdk.java.net/~tonyp/6819085/webrev.0/
> 
> The idea is to allow the user to set the region size with a parameter 
> (-XX:G1HeapRegionSize=N).
> 
> Tony
> 



More information about the hotspot-gc-dev mailing list