review request (M?) 6845368 large objects

John Coomes John.Coomes at sun.com
Tue Aug 11 22:27:56 PDT 2009


I (John.Coomes at sun.com) wrote:
> John Coomes (John.Coomes at Sun.COM) wrote:
> > I'd appreciate reviews for
> > 
> > 	6845368 large objects cause a crash or unexpected exception
> > 
> > http://cr.openjdk.java.net/~jcoomes/6845368-large-obj/
> > 
> > The hotspot code changes are fairly small (60 lines, 3 files), mostly
> > changing int to unsigned.  The test case is 64K lines but still
> > simple; most of it is a class w/more than 65000 fields.
> 
> Sigh, sent this a few minutes too early.  There are some
> 'signed/unsigned comparison' errors when compiling on one platform, so
> I'll have to fix and regenerate the webrev.  Please hold off reviewing
> this for now.

It now compiles everywhere, so I've updated the webrev at

	http://cr.openjdk.java.net/~jcoomes/6845368-large-obj/

More files were touched, but most are trivial--just a few lines each.

-John




More information about the hotspot-gc-dev mailing list