From john.coomes at sun.com  Thu Jul  2 22:24:44 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 03 Jul 2009 05:24:44 +0000
Subject: hg: jdk7/hotspot-gc: Added tag jdk7-b63 for changeset 57f7e028c7ad
Message-ID: <20090703052444.914D3EA1B@hg.openjdk.java.net>

Changeset: 9849536536d2
Author:    xdono
Date:      2009-07-02 11:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/9849536536d2

Added tag jdk7-b63 for changeset 57f7e028c7ad

! .hgtags



From john.coomes at sun.com  Thu Jul  2 22:29:35 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 03 Jul 2009 05:29:35 +0000
Subject: hg: jdk7/hotspot-gc/corba: Added tag jdk7-b63 for changeset
	d20e45cd539f
Message-ID: <20090703052937.A5773EA26@hg.openjdk.java.net>

Changeset: b3ad991d9534
Author:    xdono
Date:      2009-07-02 11:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/b3ad991d9534

Added tag jdk7-b63 for changeset d20e45cd539f

! .hgtags



From john.coomes at sun.com  Thu Jul  2 22:41:05 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 03 Jul 2009 05:41:05 +0000
Subject: hg: jdk7/hotspot-gc/jaxp: Added tag jdk7-b63 for changeset
	ae449e9c04c1
Message-ID: <20090703054107.E385FEA2E@hg.openjdk.java.net>

Changeset: a10eec7a1edf
Author:    xdono
Date:      2009-07-02 11:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/a10eec7a1edf

Added tag jdk7-b63 for changeset ae449e9c04c1

! .hgtags



From john.coomes at sun.com  Thu Jul  2 22:45:55 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 03 Jul 2009 05:45:55 +0000
Subject: hg: jdk7/hotspot-gc/jaxws: Added tag jdk7-b63 for changeset
	b8a6e883c0a6
Message-ID: <20090703054558.205B8EA33@hg.openjdk.java.net>

Changeset: aaa25dfd3de6
Author:    xdono
Date:      2009-07-02 11:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/aaa25dfd3de6

Added tag jdk7-b63 for changeset b8a6e883c0a6

! .hgtags



From john.coomes at sun.com  Thu Jul  2 22:51:39 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 03 Jul 2009 05:51:39 +0000
Subject: hg: jdk7/hotspot-gc/jdk: 15 new changesets
Message-ID: <20090703055649.0A94DEA38@hg.openjdk.java.net>

Changeset: 9cf4ef04d9a7
Author:    prr
Date:      2009-05-06 14:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9cf4ef04d9a7

6806822: Font.getFontName() is slow in Java5 and 6
Reviewed-by: igor, jgodinez

! src/share/classes/sun/font/TrueTypeFont.java

Changeset: ec0a8acd4737
Author:    jgodinez
Date:      2009-05-14 09:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ec0a8acd4737

Merge


Changeset: fb03586d68b6
Author:    jgodinez
Date:      2009-05-21 09:56 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fb03586d68b6

6829659: Circle is rendered in C shape
Reviewed-by: campbell, flar
Contributed-by: Google <yamauchi at google.com>

! src/share/classes/sun/java2d/pisces/PiscesCache.java
+ test/sun/pisces/ScaleTest.java

Changeset: 907324eb3e64
Author:    bae
Date:      2009-05-23 08:35 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/907324eb3e64

4893408: JPEGReader throws IllegalArgException when setting the destination to BYTE_GRAY
Reviewed-by: igor, prr

! src/share/classes/com/sun/imageio/plugins/jpeg/JPEG.java
! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java
! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageWriter.java
! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGMetadata.java
! src/share/classes/java/awt/color/ICC_Profile.java
! src/share/native/sun/awt/image/jpeg/imageioJPEG.c
+ test/javax/imageio/plugins/jpeg/ReadAsGrayTest.java

Changeset: b92e3fbbcb63
Author:    jgodinez
Date:      2009-06-08 13:56 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b92e3fbbcb63

Merge


Changeset: 378feb59435b
Author:    bae
Date:      2009-06-11 13:47 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/378feb59435b

6296893: BMP Writer handles TopDown property incorrectly for some of the compression types
Reviewed-by: igor, prr

! src/share/classes/com/sun/imageio/plugins/bmp/BMPImageWriter.java
+ test/javax/imageio/plugins/bmp/TopDownTest.java

Changeset: e138ae33b128
Author:    bae
Date:      2009-06-11 14:22 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e138ae33b128

5101862: WBMP Image reader tries to load Quicktime MOV files
Reviewed-by: igor, prr

! src/share/classes/com/sun/imageio/plugins/common/ReaderUtil.java
! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageReader.java
! src/share/classes/com/sun/imageio/plugins/wbmp/WBMPImageReaderSpi.java
+ test/javax/imageio/plugins/wbmp/CanDecodeTest.java

Changeset: 0ce29cbeb6a9
Author:    bae
Date:      2009-06-15 14:49 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0ce29cbeb6a9

6829549: JVM crash on certain images
Reviewed-by: igor, prr

! src/share/classes/com/sun/imageio/plugins/jpeg/JPEGImageReader.java

Changeset: 5896dcd01fe3
Author:    bae
Date:      2009-06-15 17:19 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5896dcd01fe3

6684104: Applets fails to launch using ImageIO if .java.policy with File permissions present on the system
Reviewed-by: igor, prr

! src/share/classes/javax/imageio/ImageIO.java
+ test/javax/imageio/CachePremissionsTest/CachePermissionsTest.java
+ test/javax/imageio/CachePremissionsTest/rw.policy
+ test/javax/imageio/CachePremissionsTest/rwd.policy
+ test/javax/imageio/CachePremissionsTest/w.policy

Changeset: 956715ded919
Author:    jgodinez
Date:      2009-06-15 09:59 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/956715ded919

Merge


Changeset: 70903e2c39e3
Author:    jgodinez
Date:      2009-06-22 09:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/70903e2c39e3

6850398: Allow GraphicsEnvironment to be loaded by system classloader  (edit)
Reviewed-by: campbell, prr

! src/share/classes/java/awt/GraphicsEnvironment.java

Changeset: fafa991c27ac
Author:    prr
Date:      2009-06-22 14:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fafa991c27ac

6853617: race condition in java.awt.Font.getAttributes() (private method)
Reviewed-by: igor, jgodinez

! src/share/classes/java/awt/Font.java

Changeset: 2886eb650801
Author:    jgodinez
Date:      2009-06-24 11:49 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2886eb650801

Merge

- src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/IBM1381.java
- src/share/classes/sun/nio/cs/ext/IBM1383.java
- src/share/classes/sun/nio/cs/ext/IBM930.java
- src/share/classes/sun/nio/cs/ext/IBM933.java
- src/share/classes/sun/nio/cs/ext/IBM935.java
- src/share/classes/sun/nio/cs/ext/IBM937.java
- src/share/classes/sun/nio/cs/ext/IBM939.java
- src/share/classes/sun/nio/cs/ext/IBM942.java
- src/share/classes/sun/nio/cs/ext/IBM943.java
- src/share/classes/sun/nio/cs/ext/IBM948.java
- src/share/classes/sun/nio/cs/ext/IBM949.java
- src/share/classes/sun/nio/cs/ext/IBM950.java
- src/share/classes/sun/nio/cs/ext/IBM970.java
- src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java
- src/share/native/sun/font/bidi/cmemory.h
- src/share/native/sun/font/bidi/jbidi.c
- src/share/native/sun/font/bidi/jbidi.h
- src/share/native/sun/font/bidi/ubidi.c
- src/share/native/sun/font/bidi/ubidi.h
- src/share/native/sun/font/bidi/ubidiimp.h
- src/share/native/sun/font/bidi/ubidiln.c
- src/share/native/sun/font/bidi/uchardir.c
- src/share/native/sun/font/bidi/uchardir.h
- src/share/native/sun/font/bidi/utypes.h

Changeset: 2ed6ed6b5bfc
Author:    jgodinez
Date:      2009-06-29 14:42 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2ed6ed6b5bfc

Merge


Changeset: 120df7f49509
Author:    xdono
Date:      2009-07-02 11:11 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/120df7f49509

Added tag jdk7-b63 for changeset 2ed6ed6b5bfc

! .hgtags



From john.coomes at sun.com  Thu Jul  2 23:11:36 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 03 Jul 2009 06:11:36 +0000
Subject: hg: jdk7/hotspot-gc/langtools: Added tag jdk7-b63 for changeset
	5c2c81120555
Message-ID: <20090703061140.B2C04EA3D@hg.openjdk.java.net>

Changeset: 619c768ad104
Author:    xdono
Date:      2009-07-02 11:11 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/619c768ad104

Added tag jdk7-b63 for changeset 5c2c81120555

! .hgtags



From jon.masamitsu at sun.com  Fri Jul  3 06:01:17 2009
From: jon.masamitsu at sun.com (jon.masamitsu at sun.com)
Date: Fri, 03 Jul 2009 13:01:17 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 16 new changesets
Message-ID: <20090703130157.DF4CFEA80@hg.openjdk.java.net>

Changeset: a88386380bda
Author:    xdono
Date:      2009-06-18 13:05 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a88386380bda

Added tag jdk7-b61 for changeset 27b728fd1281

! .hgtags

Changeset: 8754a3c37762
Author:    xdono
Date:      2009-06-25 12:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8754a3c37762

Added tag jdk7-b62 for changeset a88386380bda

! .hgtags

Changeset: f9c95d5dc41f
Author:    trims
Date:      2009-06-25 22:01 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f9c95d5dc41f

Merge


Changeset: 32c83fb84370
Author:    trims
Date:      2009-06-30 10:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/32c83fb84370

6856257: Bump the HS16 build number to 05
Summary: Update the HS16 build number to 05
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: b109e761e927
Author:    kvn
Date:      2009-06-09 16:19 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b109e761e927

6837472: com/sun/jdi/MonitorFrameInfo.java fails with AggressiveOpts in 6u14
Summary: Disable escape analysis when jvmti/debugger is used. Add support for EA ibto SA.
Reviewed-by: never

! agent/src/share/classes/sun/jvm/hotspot/code/DebugInfoReadStream.java
! agent/src/share/classes/sun/jvm/hotspot/code/MonitorValue.java
+ agent/src/share/classes/sun/jvm/hotspot/code/ObjectValue.java
! agent/src/share/classes/sun/jvm/hotspot/code/ScopeDesc.java
! agent/src/share/classes/sun/jvm/hotspot/code/ScopeValue.java
! agent/src/share/classes/sun/jvm/hotspot/jdi/ObjectReferenceImpl.java
! agent/src/share/classes/sun/jvm/hotspot/jdi/ThreadReferenceImpl.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/InterpretedVFrame.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/MonitorInfo.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/StackValue.java
! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaThread.java
! src/share/vm/opto/c2compiler.cpp
! src/share/vm/prims/jvmtiEnvBase.cpp
! src/share/vm/runtime/biasedLocking.cpp
! src/share/vm/runtime/deoptimization.cpp
! src/share/vm/runtime/stackValue.cpp
! src/share/vm/runtime/stackValue.hpp
! src/share/vm/runtime/vframe.cpp
! src/share/vm/runtime/vframe.hpp
! src/share/vm/runtime/vframeArray.cpp
! src/share/vm/runtime/vframe_hp.cpp

Changeset: c6386080541b
Author:    never
Date:      2009-06-10 12:19 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c6386080541b

6849574: VM crash using NonBlockingHashMap (high_scale_lib)
Reviewed-by: kvn

! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp
! src/share/vm/c1/c1_LIRGenerator.cpp
+ test/compiler/6849574/Test.java

Changeset: 915cc9c5ebc6
Author:    kvn
Date:      2009-06-23 17:52 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/915cc9c5ebc6

6837094: False positive for "meet not symmetric" failure
Summary: Have the meet not symmetric check recursively do the interface-vs-oop check on array subtypes.
Reviewed-by: jrose
Contributed-by: rasbold at google.com

! src/share/vm/opto/type.cpp
! src/share/vm/opto/type.hpp
+ test/compiler/6837094/Test.java

Changeset: d1fe2c2fbdac
Author:    twisti
Date:      2009-06-17 09:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d1fe2c2fbdac

6851829: solaris build fails with 5.8 compilers
Summary: Solaris builds with the CC 5.8 compilers (used for jdk6 update builds) fail while compiling adlc.
Reviewed-by: never

! make/solaris/makefiles/adlc.make

Changeset: e306d7c7222c
Author:    twisti
Date:      2009-06-24 02:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e306d7c7222c

Merge


Changeset: 14367225a853
Author:    kvn
Date:      2009-06-24 12:00 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/14367225a853

6841800: Incorrect boundary values behavior for option -XX:MaxLabelRootDepth=0-6 leads to jvm crash
Summary: MaxLabelRootDepth value less then 10 is invalid.
Reviewed-by: never

! src/share/vm/opto/matcher.cpp

Changeset: 18a08a7e16b5
Author:    twisti
Date:      2009-06-26 07:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/18a08a7e16b5

5057225: Remove useless I2L conversions
Summary: The optimizer should be told to normalize (AndL (ConvI2L x) 0xFF) to (ConvI2L (AndI x 0xFF)), and then the existing matcher rule will work for free.
Reviewed-by: kvn

! src/cpu/sparc/vm/sparc.ad
! src/cpu/x86/vm/x86_32.ad
! src/cpu/x86/vm/x86_64.ad
! src/share/vm/opto/mulnode.cpp
+ test/compiler/5057225/Test5057225.java

Changeset: 8f5825e0aeaa
Author:    never
Date:      2009-06-26 13:03 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8f5825e0aeaa

6818666: G1: Type lost in g1 pre-barrier
Reviewed-by: kvn

! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/graphKit.hpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/parse2.cpp
! src/share/vm/opto/parse3.cpp

Changeset: 3f06f139ef53
Author:    never
Date:      2009-06-26 16:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3f06f139ef53

6851908: interpreter null check profiling broken causing extra compilation invalidation
Reviewed-by: kvn

! src/cpu/x86/vm/interp_masm_x86_32.cpp
! src/cpu/x86/vm/interp_masm_x86_64.cpp

Changeset: bf3489cc0aa0
Author:    never
Date:      2009-07-01 12:22 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/bf3489cc0aa0

6856025: assert(_base >= OopPtr && _base <= KlassPtr,"Not a Java pointer")
Reviewed-by: kvn

! src/share/vm/adlc/output_h.cpp
! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/parse2.cpp
! src/share/vm/opto/parse3.cpp
! src/share/vm/opto/type.cpp
! src/share/vm/opto/type.hpp

Changeset: b64314863098
Author:    kvn
Date:      2009-07-01 15:06 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b64314863098

Merge


Changeset: e7d5557ad624
Author:    jmasa
Date:      2009-07-02 16:28 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e7d5557ad624

Merge




From Antonios.Printezis at sun.com  Mon Jul  6 14:56:02 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Mon, 06 Jul 2009 17:56:02 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
Message-ID: <4A5272F2.5030200@sun.com>

http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/

The CR has more information on the new format:

Tony

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From John.Coomes at sun.com  Mon Jul  6 15:43:57 2009
From: John.Coomes at sun.com (John Coomes)
Date: Mon, 6 Jul 2009 15:43:57 -0700
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <4A5272F2.5030200@sun.com>
References: <4A5272F2.5030200@sun.com>
Message-ID: <19026.32301.779423.310185@sun.com>

Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
> 
> The CR has more information on the new format:

Haven't reviewed the code yet (sorry), but have some questions.

Does G1 have reasonably accurate occupancy info when this info is
printed?  If so, it would be nice to have a breakdown of the amount or
percentage used in young regions, survivor regions & old regions.
That would be closer to the info you get for the other collectors.

If not, then I would combine the "region size" line with the one that
follows it.  Best shown by example:

Change this:

 garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
  region size 1024K
  young regions 16 / 16384K  survivor regions 0 / 0K


To something like this:

 garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
  region size 1024K, 16 young (16384K), 1 survivor (1024K)

-John



From kirk at kodewerk.com  Mon Jul  6 22:13:12 2009
From: kirk at kodewerk.com (kirk)
Date: Tue, 07 Jul 2009 07:13:12 +0200
Subject: Code review request: 6855834: G1: minimize the output
	when	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <19026.32301.779423.310185@sun.com>
References: <4A5272F2.5030200@sun.com> <19026.32301.779423.310185@sun.com>
Message-ID: <4A52D968.8020708@kodewerk.com>

Hi All,

can we take this opportunity to come up with a normalized machine 
readable format? Something that we can start down the road with?

G1 total 24576K used 16950K [0xf2400000, 0xf3c00000, 0xf5400000) region size 1024K, 16 young (16384K), 1 survivor (1024K)

16384+1024=16408 meaning 24576-16408=8168 for old and perm? 8192 would 
be 8 old regions.

Regards,
Kirk

John Coomes wrote:
> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>   
>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>>
>> The CR has more information on the new format:
>>     
>
> Haven't reviewed the code yet (sorry), but have some questions.
>
> Does G1 have reasonably accurate occupancy info when this info is
> printed?  If so, it would be nice to have a breakdown of the amount or
> percentage used in young regions, survivor regions & old regions.
> That would be closer to the info you get for the other collectors.
>
> If not, then I would combine the "region size" line with the one that
> follows it.  Best shown by example:
>
> Change this:
>
>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
>   region size 1024K
>   young regions 16 / 16384K  survivor regions 0 / 0K
>
>
> To something like this:
>
>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
>   region size 1024K, 16 young (16384K), 1 survivor (1024K)
>
> -John
>
>
>   



From Antonios.Printezis at sun.com  Tue Jul  7 07:57:34 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Tue, 07 Jul 2009 10:57:34 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <4A5272F2.5030200@sun.com>
References: <4A5272F2.5030200@sun.com>
Message-ID: <4A53625E.9060801@sun.com>

Thanks to Ramki for the speedy code review. I applied a couple of minor 
changes, here's the second attempt:

http://cr.openjdk.java.net/~tonyp/6855834/webrev.1/

Tony

Tony Printezis wrote:
> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>
> The CR has more information on the new format:
>
> Tony
>

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From Antonios.Printezis at sun.com  Tue Jul  7 08:41:43 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Tue, 07 Jul 2009 11:41:43 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <19026.32301.779423.310185@sun.com>
References: <4A5272F2.5030200@sun.com> <19026.32301.779423.310185@sun.com>
Message-ID: <4A536CB7.2050305@sun.com>

John,

John Coomes wrote:
> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>   
>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>>
>> The CR has more information on the new format:
>>     
>
> Haven't reviewed the code yet (sorry), but have some questions.
>
> Does G1 have reasonably accurate occupancy info when this info is
> printed?
So-and-so (and that's a good question). We do maintain how much used 
space there is in the whole heap (i.e., the sum of used() for all heap 
regions). However, we do _not_ maintain that for the young / survivor 
regions. Iterating over them just to report I think it'd be a 
performance issue.
> If so, it would be nice to have a breakdown of the amount or
> percentage used in young regions, survivor regions & old regions.
> That would be closer to the info you get for the other collectors.
>   
Yes, you are right. I have to point out, however, that most of the time 
the young / survivor regions will be mostly full anyway (apart from the 
last survivor region!). So, region_num * region_size is a reasonably 
accurate upper bound on how much used space there is in them. But, yes, 
the more accurate version might be able potentially pathological cases 
(space being wasted in regions due to large-ish objects creating 
fragmentation). So, we should also maintain the total used space for the 
survivors and young regions (and from that deduce the used space in the 
old regions).

How about this? How about I leave this as is (i.e., with the slightly 
inaccurate information) to get it off my plate and improve the current 
-XX:+PrintHeapAtGC output (as, right now, it's overly verbose) and open 
a new CR to make it more accurate?
> If not, then I would combine the "region size" line with the one that
> follows it.  Best shown by example:
>
> Change this:
>
>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
>   region size 1024K
>   young regions 16 / 16384K  survivor regions 0 / 0K
>
>
> To something like this:
>
>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
>   region size 1024K, 16 young (16384K), 1 survivor (1024K)
>   
I did consider putting them on one line and I decided against it as that 
line might get a bit long. But, you're right, the -XX:+PrintHeapAtGC 
output is not concise enough to stay within, say, 80 chars (especially 
when 64-bit addresses are involved). So, I'll use the format you're 
recommending, thanks.

Tony

-- 
---------------------------------------------------------------------
| Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
|                                  | MS UBUR02-311                  |
| e-mail: tony.printezis at sun.com   | 35 Network Drive               |
| office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
---------------------------------------------------------------------
e-mail client: Thunderbird (Linux)




From Antonios.Printezis at sun.com  Tue Jul  7 08:46:05 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Tue, 07 Jul 2009 11:46:05 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <4A52D968.8020708@kodewerk.com>
References: <4A5272F2.5030200@sun.com> <19026.32301.779423.310185@sun.com>
	<4A52D968.8020708@kodewerk.com>
Message-ID: <4A536DBD.4040500@sun.com>

We'll consider it!

kirk wrote:
> Hi All,
>
> can we take this opportunity to come up with a normalized machine 
> readable format? Something that we can start down the road with?
>
> G1 total 24576K used 16950K [0xf2400000, 0xf3c00000, 0xf5400000) 
> region size 1024K, 16 young (16384K), 1 survivor (1024K)
>
> 16384+1024=16408 meaning 24576-16408=8168 for old and perm? 8192 would 
> be 8 old regions.
>
> Regards,
> Kirk
>
> John Coomes wrote:
>> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>>  
>>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>>>
>>> The CR has more information on the new format:
>>>     
>>
>> Haven't reviewed the code yet (sorry), but have some questions.
>>
>> Does G1 have reasonably accurate occupancy info when this info is
>> printed?  If so, it would be nice to have a breakdown of the amount or
>> percentage used in young regions, survivor regions & old regions.
>> That would be closer to the info you get for the other collectors.
>>
>> If not, then I would combine the "region size" line with the one that
>> follows it.  Best shown by example:
>>
>> Change this:
>>
>>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 
>> 0xf3c00000, 0xf5400000)
>>   region size 1024K
>>   young regions 16 / 16384K  survivor regions 0 / 0K
>>
>>
>> To something like this:
>>
>>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 
>> 0xf3c00000, 0xf5400000)
>>   region size 1024K, 16 young (16384K), 1 survivor (1024K)
>>
>> -John
>>
>>
>>   
>

-- 
---------------------------------------------------------------------
| Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
|                                  | MS UBUR02-311                  |
| e-mail: tony.printezis at sun.com   | 35 Network Drive               |
| office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
---------------------------------------------------------------------
e-mail client: Thunderbird (Linux)




From Antonios.Printezis at sun.com  Tue Jul  7 10:53:11 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Tue, 07 Jul 2009 13:53:11 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <19026.32301.779423.310185@sun.com>
References: <4A5272F2.5030200@sun.com> <19026.32301.779423.310185@sun.com>
Message-ID: <4A538B87.4060104@sun.com>

John,

New output below. Looks good?

Tony

--------------

{Heap before GC invocations=12 (full 3):
 garbage-first heap   total 26624K, used 22004K [0xf2400000, 0xf3e00000, 
0xf5400000)
  region size 1024K, 16 young (16384K), 2 survivors (2048K),
 compacting perm gen  total 16384K, used 3070K [0xf5400000, 0xf6400000, 
0xf9400000)
   the space 16384K,  18% used [0xf5400000, 0xf56ffa68, 0xf56ffc00, 
0xf6400000)
No shared spaces configured.
15.982: [GC pause (young) 21M->9990K(28M), 0.1216863 secs]
Heap after GC invocations=13 (full 3):
 garbage-first heap   total 28672K, used 9990K [0xf2400000, 0xf4000000, 
0xf5400000)
  region size 1024K, 4 young (4096K), 4 survivors (4096K),
 compacting perm gen  total 16384K, used 3070K [0xf5400000, 0xf6400000, 
0xf9400000)
   the space 16384K,  18% used [0xf5400000, 0xf56ffa68, 0xf56ffc00, 
0xf6400000)
No shared spaces configured.
}
{Heap before GC invocations=13 (full 3):
 garbage-first heap   total 28672K, used 21584K [0xf2400000, 0xf4000000, 
0xf5400000)
  region size 1024K, 16 young (16384K), 4 survivors (4096K),
 compacting perm gen  total 16384K, used 3077K [0xf5400000, 0xf6400000, 
0xf9400000)
   the space 16384K,  18% used [0xf5400000, 0xf57016b8, 0xf5701800, 
0xf6400000)
No shared spaces configured.
16.570: [Full GC (System.gc()) 21M->566K(24M), 0.1898490 secs]
Heap after GC invocations=14 (full 4):
 garbage-first heap   total 24576K, used 566K [0xf2400000, 0xf3c00000, 
0xf5400000)
  region size 1024K, 0 young (0K), 0 survivors (0K),
 compacting perm gen  total 16384K, used 3075K [0xf5400000, 0xf6400000, 
0xf9400000)
   the space 16384K,  18% used [0xf5400000, 0xf5700dd0, 0xf5700e00, 
0xf6400000)
No shared spaces configured.
}


John Coomes wrote:
> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>   
>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>>
>> The CR has more information on the new format:
>>     
>
> Haven't reviewed the code yet (sorry), but have some questions.
>
> Does G1 have reasonably accurate occupancy info when this info is
> printed?  If so, it would be nice to have a breakdown of the amount or
> percentage used in young regions, survivor regions & old regions.
> That would be closer to the info you get for the other collectors.
>
> If not, then I would combine the "region size" line with the one that
> follows it.  Best shown by example:
>
> Change this:
>
>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
>   region size 1024K
>   young regions 16 / 16384K  survivor regions 0 / 0K
>
>
> To something like this:
>
>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
>   region size 1024K, 16 young (16384K), 1 survivor (1024K)
>
> -John
>
>   

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From John.Coomes at sun.com  Tue Jul  7 11:19:48 2009
From: John.Coomes at sun.com (John Coomes)
Date: Tue, 7 Jul 2009 11:19:48 -0700
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <4A538B87.4060104@sun.com>
References: <4A5272F2.5030200@sun.com> <19026.32301.779423.310185@sun.com>
	<4A538B87.4060104@sun.com>
Message-ID: <19027.37316.435240.868086@sun.com>

Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
> John,
> 
> New output below. Looks good?

Yes, I like it.  One nit, though:  I would remove the trailing comma
after the survivors size.

-John

> --------------
> 
> {Heap before GC invocations=12 (full 3):
>  garbage-first heap   total 26624K, used 22004K [0xf2400000, 0xf3e00000, 
> 0xf5400000)
>   region size 1024K, 16 young (16384K), 2 survivors (2048K),
>  compacting perm gen  total 16384K, used 3070K [0xf5400000, 0xf6400000, 
> 0xf9400000)
>    the space 16384K,  18% used [0xf5400000, 0xf56ffa68, 0xf56ffc00, 
> 0xf6400000)
> No shared spaces configured.
> 15.982: [GC pause (young) 21M->9990K(28M), 0.1216863 secs]
> Heap after GC invocations=13 (full 3):
>  garbage-first heap   total 28672K, used 9990K [0xf2400000, 0xf4000000, 
> 0xf5400000)
>   region size 1024K, 4 young (4096K), 4 survivors (4096K),
>  compacting perm gen  total 16384K, used 3070K [0xf5400000, 0xf6400000, 
> 0xf9400000)
>    the space 16384K,  18% used [0xf5400000, 0xf56ffa68, 0xf56ffc00, 
> 0xf6400000)
> No shared spaces configured.
> }
> {Heap before GC invocations=13 (full 3):
>  garbage-first heap   total 28672K, used 21584K [0xf2400000, 0xf4000000, 
> 0xf5400000)
>   region size 1024K, 16 young (16384K), 4 survivors (4096K),
>  compacting perm gen  total 16384K, used 3077K [0xf5400000, 0xf6400000, 
> 0xf9400000)
>    the space 16384K,  18% used [0xf5400000, 0xf57016b8, 0xf5701800, 
> 0xf6400000)
> No shared spaces configured.
> 16.570: [Full GC (System.gc()) 21M->566K(24M), 0.1898490 secs]
> Heap after GC invocations=14 (full 4):
>  garbage-first heap   total 24576K, used 566K [0xf2400000, 0xf3c00000, 
> 0xf5400000)
>   region size 1024K, 0 young (0K), 0 survivors (0K),
>  compacting perm gen  total 16384K, used 3075K [0xf5400000, 0xf6400000, 
> 0xf9400000)
>    the space 16384K,  18% used [0xf5400000, 0xf5700dd0, 0xf5700e00, 
> 0xf6400000)
> No shared spaces configured.
> }
> 
> 
> John Coomes wrote:
> > Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
> >   
> >> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
> >>
> >> The CR has more information on the new format:
> >>     
> >
> > Haven't reviewed the code yet (sorry), but have some questions.
> >
> > Does G1 have reasonably accurate occupancy info when this info is
> > printed?  If so, it would be nice to have a breakdown of the amount or
> > percentage used in young regions, survivor regions & old regions.
> > That would be closer to the info you get for the other collectors.
> >
> > If not, then I would combine the "region size" line with the one that
> > follows it.  Best shown by example:
> >
> > Change this:
> >
> >  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
> >   region size 1024K
> >   young regions 16 / 16384K  survivor regions 0 / 0K
> >
> >
> > To something like this:
> >
> >  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
> >   region size 1024K, 16 young (16384K), 1 survivor (1024K)
> >
> > -John
> >
> >   
> 
> -- 
> ----------------------------------------------------------------------
> | Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
> |                                   | MS BUR02-311                   |
> | e-mail: tony.printezis at sun.com    | 35 Network Drive               |
> | office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
> ----------------------------------------------------------------------
> e-mail client: Thunderbird (Solaris)
> 
> 



From Antonios.Printezis at sun.com  Tue Jul  7 11:23:28 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Tue, 07 Jul 2009 14:23:28 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <19027.37316.435240.868086@sun.com>
References: <4A5272F2.5030200@sun.com> <19026.32301.779423.310185@sun.com>
	<4A538B87.4060104@sun.com> <19027.37316.435240.868086@sun.com>
Message-ID: <4A5392A0.7070203@sun.com>

John Coomes wrote:
> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>   
>> John,
>>
>> New output below. Looks good?
>>     
>
> Yes, I like it.
Cool.
>   One nit, though:  I would remove the trailing comma
> after the survivors size.
>   
Good catch, bad cut-and-paste! THanks.

Tony
>> --------------
>>
>> {Heap before GC invocations=12 (full 3):
>>  garbage-first heap   total 26624K, used 22004K [0xf2400000, 0xf3e00000, 
>> 0xf5400000)
>>   region size 1024K, 16 young (16384K), 2 survivors (2048K),
>>  compacting perm gen  total 16384K, used 3070K [0xf5400000, 0xf6400000, 
>> 0xf9400000)
>>    the space 16384K,  18% used [0xf5400000, 0xf56ffa68, 0xf56ffc00, 
>> 0xf6400000)
>> No shared spaces configured.
>> 15.982: [GC pause (young) 21M->9990K(28M), 0.1216863 secs]
>> Heap after GC invocations=13 (full 3):
>>  garbage-first heap   total 28672K, used 9990K [0xf2400000, 0xf4000000, 
>> 0xf5400000)
>>   region size 1024K, 4 young (4096K), 4 survivors (4096K),
>>  compacting perm gen  total 16384K, used 3070K [0xf5400000, 0xf6400000, 
>> 0xf9400000)
>>    the space 16384K,  18% used [0xf5400000, 0xf56ffa68, 0xf56ffc00, 
>> 0xf6400000)
>> No shared spaces configured.
>> }
>> {Heap before GC invocations=13 (full 3):
>>  garbage-first heap   total 28672K, used 21584K [0xf2400000, 0xf4000000, 
>> 0xf5400000)
>>   region size 1024K, 16 young (16384K), 4 survivors (4096K),
>>  compacting perm gen  total 16384K, used 3077K [0xf5400000, 0xf6400000, 
>> 0xf9400000)
>>    the space 16384K,  18% used [0xf5400000, 0xf57016b8, 0xf5701800, 
>> 0xf6400000)
>> No shared spaces configured.
>> 16.570: [Full GC (System.gc()) 21M->566K(24M), 0.1898490 secs]
>> Heap after GC invocations=14 (full 4):
>>  garbage-first heap   total 24576K, used 566K [0xf2400000, 0xf3c00000, 
>> 0xf5400000)
>>   region size 1024K, 0 young (0K), 0 survivors (0K),
>>  compacting perm gen  total 16384K, used 3075K [0xf5400000, 0xf6400000, 
>> 0xf9400000)
>>    the space 16384K,  18% used [0xf5400000, 0xf5700dd0, 0xf5700e00, 
>> 0xf6400000)
>> No shared spaces configured.
>> }
>>
>>
>> John Coomes wrote:
>>     
>>> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>>>   
>>>       
>>>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>>>>
>>>> The CR has more information on the new format:
>>>>     
>>>>         
>>> Haven't reviewed the code yet (sorry), but have some questions.
>>>
>>> Does G1 have reasonably accurate occupancy info when this info is
>>> printed?  If so, it would be nice to have a breakdown of the amount or
>>> percentage used in young regions, survivor regions & old regions.
>>> That would be closer to the info you get for the other collectors.
>>>
>>> If not, then I would combine the "region size" line with the one that
>>> follows it.  Best shown by example:
>>>
>>> Change this:
>>>
>>>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
>>>   region size 1024K
>>>   young regions 16 / 16384K  survivor regions 0 / 0K
>>>
>>>
>>> To something like this:
>>>
>>>  garbage-first heap   total 24576K, used 16950K [0xf2400000, 0xf3c00000, 0xf5400000)
>>>   region size 1024K, 16 young (16384K), 1 survivor (1024K)
>>>
>>> -John
>>>
>>>   
>>>       
>> -- 
>> ----------------------------------------------------------------------
>> | Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
>> |                                   | MS BUR02-311                   |
>> | e-mail: tony.printezis at sun.com    | 35 Network Drive               |
>> | office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
>> ----------------------------------------------------------------------
>> e-mail client: Thunderbird (Solaris)
>>
>>
>>     
>
>   

-- 
---------------------------------------------------------------------
| Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
|                                  | MS UBUR02-311                  |
| e-mail: tony.printezis at sun.com   | 35 Network Drive               |
| office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
---------------------------------------------------------------------
e-mail client: Thunderbird (Linux)




From Antonios.Printezis at sun.com  Tue Jul  7 11:53:16 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Tue, 07 Jul 2009 14:53:16 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <4A53625E.9060801@sun.com>
References: <4A5272F2.5030200@sun.com> <4A53625E.9060801@sun.com>
Message-ID: <4A53999C.8020709@sun.com>

One more spin:

http://cr.openjdk.java.net/~tonyp/6855834/webrev.2/

All the recent changes are in g1CollectedHeap.cpp, in the print_on() 
method (which reflect the updated output that John Coomes suggested). 
One more review and I'll push it...

Tony

Tony Printezis wrote:
> Thanks to Ramki for the speedy code review. I applied a couple of 
> minor changes, here's the second attempt:
>
> http://cr.openjdk.java.net/~tonyp/6855834/webrev.1/
>
> Tony
>
> Tony Printezis wrote:
>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>>
>> The CR has more information on the new format:
>>
>> Tony
>>
>

-- 
---------------------------------------------------------------------
| Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
|                                  | MS UBUR02-311                  |
| e-mail: tony.printezis at sun.com   | 35 Network Drive               |
| office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
---------------------------------------------------------------------
e-mail client: Thunderbird (Linux)




From Antonios.Printezis at sun.com  Tue Jul  7 12:00:57 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Tue, 07 Jul 2009 15:00:57 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <4A53999C.8020709@sun.com>
References: <4A5272F2.5030200@sun.com> <4A53625E.9060801@sun.com>
	<4A53999C.8020709@sun.com>
Message-ID: <4A539B69.5060601@sun.com>

All set thanks to Ramki, thanks!

Tony Printezis wrote:
> One more spin:
>
> http://cr.openjdk.java.net/~tonyp/6855834/webrev.2/
>
> All the recent changes are in g1CollectedHeap.cpp, in the print_on() 
> method (which reflect the updated output that John Coomes suggested). 
> One more review and I'll push it...
>
> Tony
>
> Tony Printezis wrote:
>> Thanks to Ramki for the speedy code review. I applied a couple of 
>> minor changes, here's the second attempt:
>>
>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.1/
>>
>> Tony
>>
>> Tony Printezis wrote:
>>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>>>
>>> The CR has more information on the new format:
>>>
>>> Tony
>>>
>>
>

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From John.Coomes at sun.com  Tue Jul  7 13:43:58 2009
From: John.Coomes at sun.com (John Coomes)
Date: Tue, 7 Jul 2009 13:43:58 -0700
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <4A53999C.8020709@sun.com>
References: <4A5272F2.5030200@sun.com> <4A53625E.9060801@sun.com>
	<4A53999C.8020709@sun.com>
Message-ID: <19027.45966.609243.457200@sun.com>

Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
> One more spin:
> 
> http://cr.openjdk.java.net/~tonyp/6855834/webrev.2/
> 
> All the recent changes are in g1CollectedHeap.cpp, in the print_on() 
> method (which reflect the updated output that John Coomes suggested). 
> One more review and I'll push it...

Looks good ... except for some whitespace nits in g1CollectedHeap.cpp
(sorry):

1.  if (PrintHeapAtGC){    <---- no space before the '{' 

	This occurs 4 times (I think).

2.  No blank line between methods print(), print_on(outputStream*) and
print_on(outputStream*, bool) (lines 2336, 2339).

3.  No space between the double quote and INTPTR_FORMAT or
SIZE_FORMAT in the new print_on() code.  AFAICT, most of hotspot uses
this:

	print("count = " SIZE_FORMAT "K", count);

instead of

	print("count = "SIZE_FORMAT"K", count);

I find the latter harder to parse.  I see some existing examples of
the latter in the same file, but haven't seen it outside of G1.

-John

> Tony Printezis wrote:
> > Thanks to Ramki for the speedy code review. I applied a couple of 
> > minor changes, here's the second attempt:
> >
> > http://cr.openjdk.java.net/~tonyp/6855834/webrev.1/
> >
> > Tony
> >
> > Tony Printezis wrote:
> >> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
> >>
> >> The CR has more information on the new format:
> >>
> >> Tony
> >>
> >
> 
> -- 
> ---------------------------------------------------------------------
> | Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
> |                                  | MS UBUR02-311                  |
> | e-mail: tony.printezis at sun.com   | 35 Network Drive               |
> | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
> ---------------------------------------------------------------------
> e-mail client: Thunderbird (Linux)
> 
> 



From Antonios.Printezis at sun.com  Tue Jul  7 14:42:18 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Tue, 07 Jul 2009 17:42:18 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <19027.45966.609243.457200@sun.com>
References: <4A5272F2.5030200@sun.com> <4A53625E.9060801@sun.com>
	<4A53999C.8020709@sun.com> <19027.45966.609243.457200@sun.com>
Message-ID: <4A53C13A.1000002@sun.com>

John,

Thanks, see inline.

John Coomes wrote:
> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>   
>> One more spin:
>>
>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.2/
>>
>> All the recent changes are in g1CollectedHeap.cpp, in the print_on() 
>> method (which reflect the updated output that John Coomes suggested). 
>> One more review and I'll push it...
>>     
>
> Looks good ... except for some whitespace nits in g1CollectedHeap.cpp
> (sorry):
>   
No need to apologize! :-)
> 1.  if (PrintHeapAtGC){    <---- no space before the '{' 
>
> 	This occurs 4 times (I think).
>   
Yep, again bad cut-and-paste.
> 2.  No blank line between methods print(), print_on(outputStream*) and
> print_on(outputStream*, bool) (lines 2336, 2339).
>   
I'll add them, but it's the same in genCollectedHeap.cpp:

void GenCollectedHeap::print() const { print_on(tty); }
void GenCollectedHeap::print_on(outputStream* st) const {
  for (int i = 0; i < _n_gens; i++) {
    _gens[i]->print_on(st);
  }
  perm_gen()->print_on(st);
}
> 3.  No space between the double quote and INTPTR_FORMAT or
> SIZE_FORMAT in the new print_on() code.  AFAICT, most of hotspot uses
> this:
>
> 	print("count = " SIZE_FORMAT "K", count);
>
> instead of
>
> 	print("count = "SIZE_FORMAT"K", count);
>
> I find the latter harder to parse.  I see some existing examples of
> the latter in the same file, but haven't seen it outside of G1.
>   
I personally find the second version easier to parse, given that it's a 
bit clearer where there's white space and where there's not. I'll change 
it in an attempt to be consistent though.

Tony
>> Tony Printezis wrote:
>>     
>>> Thanks to Ramki for the speedy code review. I applied a couple of 
>>> minor changes, here's the second attempt:
>>>
>>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.1/
>>>
>>> Tony
>>>
>>> Tony Printezis wrote:
>>>       
>>>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
>>>>
>>>> The CR has more information on the new format:
>>>>
>>>> Tony
>>>>
>>>>         
>> -- 
>> ---------------------------------------------------------------------
>> | Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
>> |                                  | MS UBUR02-311                  |
>> | e-mail: tony.printezis at sun.com   | 35 Network Drive               |
>> | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
>> ---------------------------------------------------------------------
>> e-mail client: Thunderbird (Linux)
>>
>>
>>     
>
>   

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From John.Coomes at sun.com  Tue Jul  7 15:23:15 2009
From: John.Coomes at sun.com (John Coomes)
Date: Tue, 7 Jul 2009 15:23:15 -0700
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <4A53C13A.1000002@sun.com>
References: <4A5272F2.5030200@sun.com> <4A53625E.9060801@sun.com>
	<4A53999C.8020709@sun.com> <19027.45966.609243.457200@sun.com>
	<4A53C13A.1000002@sun.com>
Message-ID: <19027.51923.450498.197562@sun.com>

Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
> John,
> 
> Thanks, see inline.
> 
> John Coomes wrote:
> > Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
> >   
> >> One more spin:
> >>
> >> http://cr.openjdk.java.net/~tonyp/6855834/webrev.2/
> >>
> >> All the recent changes are in g1CollectedHeap.cpp, in the print_on() 
> >> method (which reflect the updated output that John Coomes suggested). 
> >> One more review and I'll push it...
> >>     
> >
> > Looks good ... except for some whitespace nits in g1CollectedHeap.cpp
> > (sorry):
> >   
> No need to apologize! :-)
> > 1.  if (PrintHeapAtGC){    <---- no space before the '{' 
> >
> > 	This occurs 4 times (I think).
> >   
> Yep, again bad cut-and-paste.

Sure, I guessed as much.

> > 2.  No blank line between methods print(), print_on(outputStream*) and
> > print_on(outputStream*, bool) (lines 2336, 2339).
> >   
> I'll add them, but it's the same in genCollectedHeap.cpp:
> 
> void GenCollectedHeap::print() const { print_on(tty); }
> void GenCollectedHeap::print_on(outputStream* st) const {
>   for (int i = 0; i < _n_gens; i++) {
>     _gens[i]->print_on(st);
>   }
>   perm_gen()->print_on(st);
> }

Thanks.  I think it's easier to read with the blank line.

> > 3.  No space between the double quote and INTPTR_FORMAT or
> > SIZE_FORMAT in the new print_on() code.  AFAICT, most of hotspot uses
> > this:
> >
> > 	print("count = " SIZE_FORMAT "K", count);
> >
> > instead of
> >
> > 	print("count = "SIZE_FORMAT"K", count);
> >
> > I find the latter harder to parse.  I see some existing examples of
> > the latter in the same file, but haven't seen it outside of G1.
> >   
> I personally find the second version easier to parse, given that it's a 
> bit clearer where there's white space and where there's not. I'll change 
> it in an attempt to be consistent though.

Strange how we see things.  The "SIZE_FORMAT" in the latter is what I
notice at first glance, which makes me think the wrong thing is
quoted.

-John

> >> Tony Printezis wrote:
> >>     
> >>> Thanks to Ramki for the speedy code review. I applied a couple of 
> >>> minor changes, here's the second attempt:
> >>>
> >>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.1/
> >>>
> >>> Tony
> >>>
> >>> Tony Printezis wrote:
> >>>       
> >>>> http://cr.openjdk.java.net/~tonyp/6855834/webrev.0/
> >>>>
> >>>> The CR has more information on the new format:
> >>>>
> >>>> Tony
> >>>>
> >>>>         
> >> -- 
> >> ---------------------------------------------------------------------
> >> | Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
> >> |                                  | MS UBUR02-311                  |
> >> | e-mail: tony.printezis at sun.com   | 35 Network Drive               |
> >> | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
> >> ---------------------------------------------------------------------
> >> e-mail client: Thunderbird (Linux)
> >>
> >>
> >>     
> >
> >   
> 
> -- 
> ----------------------------------------------------------------------
> | Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
> |                                   | MS BUR02-311                   |
> | e-mail: tony.printezis at sun.com    | 35 Network Drive               |
> | office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
> ----------------------------------------------------------------------
> e-mail client: Thunderbird (Solaris)
> 
> 



From antonios.printezis at sun.com  Tue Jul  7 17:23:41 2009
From: antonios.printezis at sun.com (antonios.printezis at sun.com)
Date: Wed, 08 Jul 2009 00:23:41 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set
Message-ID: <20090708002353.0715DECE9@hg.openjdk.java.net>

Changeset: 0316eac49d5a
Author:    tonyp
Date:      2009-07-07 14:23 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0316eac49d5a

6855834: G1: minimize the output when -XX:+PrintHeapAtGC is set
Summary: Changing the behavior of -XX:+PrintHeapAtGC for G1 from printing lengthy, per-region information to instead printing a concise summary.
Reviewed-by: ysr, apetrusenko, jcoomes

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp
! src/share/vm/runtime/globals.hpp



From Antonios.Printezis at sun.com  Wed Jul  8 07:49:53 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Wed, 08 Jul 2009 10:49:53 -0400
Subject: Code review request: 6855834: G1: minimize the output when
	-XX:+PrintHeapAtGC is set (S)
In-Reply-To: <19027.51923.450498.197562@sun.com>
References: <4A5272F2.5030200@sun.com> <4A53625E.9060801@sun.com>
	<4A53999C.8020709@sun.com> <19027.45966.609243.457200@sun.com>
	<4A53C13A.1000002@sun.com> <19027.51923.450498.197562@sun.com>
Message-ID: <4A54B211.4040907@sun.com>

John,

Hi.

John Coomes wrote:
> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>   
>>> 1.  if (PrintHeapAtGC){    <---- no space before the '{' 
>>>
>>> 	This occurs 4 times (I think).
>>>   
>>>       
>> Yep, again bad cut-and-paste.
>>     
> Sure, I guessed as much.
>   
:-( Thanks again for spotting it.
>>> 2.  No blank line between methods print(), print_on(outputStream*) and
>>> print_on(outputStream*, bool) (lines 2336, 2339).
>>>   
>>>       
>> I'll add them, but it's the same in genCollectedHeap.cpp:
>>
>> void GenCollectedHeap::print() const { print_on(tty); }
>> void GenCollectedHeap::print_on(outputStream* st) const {
>>   for (int i = 0; i < _n_gens; i++) {
>>     _gens[i]->print_on(st);
>>   }
>>   perm_gen()->print_on(st);
>> }
>>     
>
> Thanks.  I think it's easier to read with the blank line.
>   
I agree, and it's consistent with the code base...
>>> 3.  No space between the double quote and INTPTR_FORMAT or
>>> SIZE_FORMAT in the new print_on() code.  AFAICT, most of hotspot uses
>>> this:
>>>
>>> 	print("count = " SIZE_FORMAT "K", count);
>>>
>>> instead of
>>>
>>> 	print("count = "SIZE_FORMAT"K", count);
>>>
>>> I find the latter harder to parse.  I see some existing examples of
>>> the latter in the same file, but haven't seen it outside of G1.
>>>   
>>>       
>> I personally find the second version easier to parse, given that it's a 
>> bit clearer where there's white space and where there's not. I'll change 
>> it in an attempt to be consistent though.
>>     
>
> Strange how we see things.  The "SIZE_FORMAT" in the latter is what I
> notice at first glance, which makes me think the wrong thing is
> quoted.
>   
Different people have different approaches I suppose!

Tony



From y.s.ramakrishna at sun.com  Sat Jul 11 04:45:30 2009
From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com)
Date: Sat, 11 Jul 2009 11:45:30 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6 new changesets
Message-ID: <20090711114547.A304AEE9B@hg.openjdk.java.net>

Changeset: acba6af809c8
Author:    kvn
Date:      2009-07-01 20:22 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/acba6af809c8

6840775: Multiple JVM crashes seen with 1.6.0_10 through 1.6.0_14
Summary: Put missed reference to allocated array in copyOf() intrinsic into OopMap for the call slow_arraycopy().
Reviewed-by: never

! agent/src/share/classes/sun/jvm/hotspot/ui/tree/OopTreeNodeAdapter.java
! make/solaris/makefiles/optimized.make
! src/share/vm/opto/block.cpp
! src/share/vm/opto/block.hpp
! src/share/vm/opto/buildOopMap.cpp
! src/share/vm/opto/gcm.cpp
! src/share/vm/opto/library_call.cpp

Changeset: 0f2d888530e7
Author:    cfang
Date:      2009-07-02 16:18 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0f2d888530e7

6855164: SIGSEGV during compilation of method involving loop over CharSequence.
Summary: Don not split a block if it contains a FastLockNode with a PhiNode input.
Reviewed-by: kvn, never

! src/share/vm/opto/loopopts.cpp

Changeset: 73dac61fe300
Author:    cfang
Date:      2009-07-06 12:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/73dac61fe300

6857707: Add missing test case for CR 6855164 from its bug description.
Summary: Add missing test case for CR 6855164 from its bug description.
Reviewed-by: never

+ test/compiler/6855164/Test.java

Changeset: 4325cdaa78ad
Author:    kvn
Date:      2009-07-06 15:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/4325cdaa78ad

6857661: 64-bit server VM: assert(is_Initialize(),"invalid node class")
Summary: Move the secondary raw memory barrier to the correct place in generate_arraycopy().
Reviewed-by: never

! src/share/vm/opto/library_call.cpp

Changeset: f0bd02f95856
Author:    kvn
Date:      2009-07-07 09:54 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f0bd02f95856

Merge


Changeset: bb18957ad21e
Author:    ysr
Date:      2009-07-10 16:01 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/bb18957ad21e

Merge




From y.s.ramakrishna at sun.com  Tue Jul 14 19:58:52 2009
From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com)
Date: Wed, 15 Jul 2009 02:58:52 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6700789: G1: Enable use of compressed
	oops with G1 heaps
Message-ID: <20090715025859.DDD94E0DD@hg.openjdk.java.net>

Changeset: df6caf649ff7
Author:    ysr
Date:      2009-07-14 15:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/df6caf649ff7

6700789: G1: Enable use of compressed oops with G1 heaps
Summary: Modifications to G1 so as to allow the use of compressed oops.
Reviewed-by: apetrusenko, coleenp, jmasa, kvn, never, phh, tonyp

! src/cpu/sparc/vm/assembler_sparc.cpp
! src/cpu/x86/vm/assembler_x86.cpp
! src/cpu/x86/vm/methodHandles_x86.cpp
! src/cpu/x86/vm/stubGenerator_x86_32.cpp
! src/cpu/x86/vm/stubGenerator_x86_64.cpp
! src/share/vm/gc_implementation/g1/bufferingOopClosure.hpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMark.hpp
! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.cpp
! src/share/vm/gc_implementation/g1/g1BlockOffsetTable.inline.hpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp
! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp
! src/share/vm/gc_implementation/g1/g1OopClosures.hpp
! src/share/vm/gc_implementation/g1/g1OopClosures.inline.hpp
! src/share/vm/gc_implementation/g1/g1RemSet.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.hpp
! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp
! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.cpp
! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp
! src/share/vm/gc_implementation/g1/g1_globals.hpp
! src/share/vm/gc_implementation/g1/g1_specialized_oop_closures.hpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.cpp
! src/share/vm/gc_implementation/g1/heapRegionRemSet.hpp
! src/share/vm/gc_implementation/g1/satbQueue.cpp
! src/share/vm/gc_implementation/g1/satbQueue.hpp
! src/share/vm/gc_implementation/includeDB_gc_g1
! src/share/vm/gc_implementation/parNew/parCardTableModRefBS.cpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp
! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp
! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.inline.hpp
! src/share/vm/gc_interface/collectedHeap.hpp
! src/share/vm/includeDB_core
! src/share/vm/includeDB_features
! src/share/vm/memory/barrierSet.cpp
! src/share/vm/memory/barrierSet.hpp
! src/share/vm/memory/barrierSet.inline.hpp
! src/share/vm/memory/cardTableModRefBS.hpp
! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/memory/genCollectedHeap.hpp
! src/share/vm/memory/genOopClosures.hpp
! src/share/vm/memory/genOopClosures.inline.hpp
! src/share/vm/memory/referenceProcessor.cpp
! src/share/vm/memory/space.hpp
! src/share/vm/memory/universe.cpp
! src/share/vm/memory/universe.hpp
! src/share/vm/oops/instanceRefKlass.cpp
! src/share/vm/oops/objArrayKlass.cpp
! src/share/vm/oops/oop.inline.hpp
! src/share/vm/oops/oopsHierarchy.hpp
! src/share/vm/opto/cfgnode.cpp
! src/share/vm/prims/unsafe.cpp
! src/share/vm/runtime/arguments.cpp
! src/share/vm/runtime/safepoint.cpp
! src/share/vm/runtime/sharedRuntime.cpp
! src/share/vm/utilities/taskqueue.cpp
! src/share/vm/utilities/taskqueue.hpp



From antonios.printezis at sun.com  Wed Jul 15 13:01:31 2009
From: antonios.printezis at sun.com (antonios.printezis at sun.com)
Date: Wed, 15 Jul 2009 20:01:31 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6859911: G1: assert(Heap_lock->owner() =
	NULL, "Should be owned on this thread's behalf")
Message-ID: <20090715200138.C5823E1D1@hg.openjdk.java.net>

Changeset: 42d84bbbecf4
Author:    tonyp
Date:      2009-07-15 12:22 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/42d84bbbecf4

6859911: G1: assert(Heap_lock->owner() = NULL, "Should be owned on this thread's behalf")
Summary: The used() method assumes that the heap lock is held when it is called. However, when used() is called from print_on(), this is not the case.
Reviewed-by: ysr, jmasa

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp



From john.coomes at sun.com  Wed Jul 15 14:29:09 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Wed, 15 Jul 2009 21:29:09 +0000
Subject: hg: jdk7/hotspot-gc: 11 new changesets
Message-ID: <20090715212909.C8D7AE211@hg.openjdk.java.net>

Changeset: c50469cf63cd
Author:    herrick
Date:      2009-06-11 15:15 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/c50469cf63cd

6797688: Umbrella: Merge all JDK 6u4 - 6u12 deployment code into JDK7
6845973: Update JDK7 with deployment changes in 6u13, 6u14
4802695: Support 64-bit Java Plug-in and Java webstart on Windows/Linux on AMD64
6825019: DownloadManager should not be loaded and referenced for full JRE
6738770: REGRESSION:JSException throws when use LiveConnect javascript facility
6772884: plugin2 : java.lang.OutOfMemoryError or crash
6707535: Crossing domain hole affecting multiple sites/domains using plug-in
6728071: Non-verification of Update files may allow unintended updates
6704154: Code loaded from local filesystem should not get access to localhost
6727081: Web Start security restrictions bypass using special extension jnlp
6727079: Java Web Start Socket() restriction bypass
6727071: Cache location/user name information disclosure in SingleInstanceImpl.
6716217: AppletClassLoader adds permissions based on codebase regardless of CS
6694892: Java Webstart inclusion via system properties override [CVE-2008-2086]
6704074: localhost socket access due to cache location exposed
6703909: Java webstart arbitrary file creation using nativelib
6665315: browser crashes when deployment.properties has more slashes ( / )
6660121: Encoding values in JNLP files can cause buffer overflow
6606110: URLConnection.setProxiedHost for resources that are loaded via proxy
6581221: SSV(VISTA): Redirection FAILS to work if user does a downgrade install
6609756: Buffer Overflow in Java ActiveX component
6608712: Bypassing the same origin policy in Java with crafted names
6534630: "gnumake clobber" doesn't
6849953: JDK7 - replacement of bufferoverflowU.lib on amd64 breaks build
6849029: Need some JDK7 merge clean-up after comments on the webrev
6847582: Build problem on JDK7 with isSecureProperty in merge
6827935: JDK 7 deployment merging - problem in Compiler-msvm.gmk
6823215: latest merge fixes from 6u12 -> JDK7
6816153: further mergers for JDK7 deployment integration
6807074: Fix Java Kernel and JQS in initial JDK7 builds
Summary: Initial changeset for implementing 6uX Deployment Features into JDK7
Reviewed-by: dgu, billyh

! make/deploy-rules.gmk

Changeset: c7c4850f1478
Author:    herrick
Date:      2009-06-15 13:07 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/c7c4850f1478

Merge


Changeset: d28a8c422df1
Author:    herrick
Date:      2009-06-22 09:14 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/d28a8c422df1

Merge


Changeset: 528e4cc7541b
Author:    herrick
Date:      2009-06-29 12:00 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/528e4cc7541b

Merge


Changeset: 9f4fc871bf4d
Author:    herrick
Date:      2009-07-06 15:02 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/9f4fc871bf4d

Merge


Changeset: 03119516abbc
Author:    herrick
Date:      2009-07-06 14:01 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/03119516abbc

Merge


Changeset: 633840bd4c5b
Author:    jqzuo
Date:      2009-07-07 10:14 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/633840bd4c5b

Merge


Changeset: 46c0f8989eb2
Author:    herrick
Date:      2009-07-06 17:12 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/46c0f8989eb2

Merge


Changeset: 3e781aa606d4
Author:    ohair
Date:      2009-07-06 22:37 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/3e781aa606d4

6857805: Fix openjdk builds to avoid building deploy repository
Reviewed-by: xdono

! make/Defs-internal.gmk
! make/deploy-rules.gmk

Changeset: 269c1ec4435d
Author:    jqzuo
Date:      2009-07-07 10:20 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/269c1ec4435d

Merge


Changeset: d92b13b3c138
Author:    xdono
Date:      2009-07-13 14:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/d92b13b3c138

Added tag jdk7-b64 for changeset 269c1ec4435d

! .hgtags



From john.coomes at sun.com  Wed Jul 15 14:35:53 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Wed, 15 Jul 2009 21:35:53 +0000
Subject: hg: jdk7/hotspot-gc/corba: 8 new changesets
Message-ID: <20090715213600.D8070E216@hg.openjdk.java.net>

Changeset: ffb590b42ed1
Author:    herrick
Date:      2009-06-11 15:16 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/ffb590b42ed1

6797688: Umbrella: Merge all JDK 6u4 - 6u12 deployment code into JDK7
6845973: Update JDK7 with deployment changes in 6u13, 6u14
4802695: Support 64-bit Java Plug-in and Java webstart on Windows/Linux on AMD64
6825019: DownloadManager should not be loaded and referenced for full JRE
6738770: REGRESSION:JSException throws when use LiveConnect javascript facility
6772884: plugin2 : java.lang.OutOfMemoryError or crash
6707535: Crossing domain hole affecting multiple sites/domains using plug-in
6728071: Non-verification of Update files may allow unintended updates
6704154: Code loaded from local filesystem should not get access to localhost
6727081: Web Start security restrictions bypass using special extension jnlp
6727079: Java Web Start Socket() restriction bypass
6727071: Cache location/user name information disclosure in SingleInstanceImpl.
6716217: AppletClassLoader adds permissions based on codebase regardless of CS
6694892: Java Webstart inclusion via system properties override [CVE-2008-2086]
6704074: localhost socket access due to cache location exposed
6703909: Java webstart arbitrary file creation using nativelib
6665315: browser crashes when deployment.properties has more slashes ( / )
6660121: Encoding values in JNLP files can cause buffer overflow
6606110: URLConnection.setProxiedHost for resources that are loaded via proxy
6581221: SSV(VISTA): Redirection FAILS to work if user does a downgrade install
6609756: Buffer Overflow in Java ActiveX component
6608712: Bypassing the same origin policy in Java with crafted names
6534630: "gnumake clobber" doesn't
6849953: JDK7 - replacement of bufferoverflowU.lib on amd64 breaks build
6849029: Need some JDK7 merge clean-up after comments on the webrev
6847582: Build problem on JDK7 with isSecureProperty in merge
6827935: JDK 7 deployment merging - problem in Compiler-msvm.gmk
6823215: latest merge fixes from 6u12 -> JDK7
6816153: further mergers for JDK7 deployment integration
6807074: Fix Java Kernel and JQS in initial JDK7 builds
Summary: Initial changeset for implementing 6uX Deployment Features into JDK7
Reviewed-by: dgu, billyh

! make/common/Defs-windows.gmk
! make/common/Library.gmk
! make/org/omg/idl/Makefile
! src/windows/resource/version.rc

Changeset: 79d8fd9e74b9
Author:    herrick
Date:      2009-06-15 13:07 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/79d8fd9e74b9

Merge

- make/README

Changeset: 1b3e9fdc4fc5
Author:    herrick
Date:      2009-06-22 09:14 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/1b3e9fdc4fc5

Merge


Changeset: 27f41fcf3d6a
Author:    herrick
Date:      2009-06-29 12:00 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/27f41fcf3d6a

Merge


Changeset: f982791bb7d4
Author:    herrick
Date:      2009-07-06 15:04 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/f982791bb7d4

Merge


Changeset: 863559dbbced
Author:    herrick
Date:      2009-07-06 14:02 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/863559dbbced

Merge


Changeset: 047dd27fddb6
Author:    herrick
Date:      2009-07-06 17:11 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/047dd27fddb6

Merge


Changeset: 97fd9b42f5c2
Author:    xdono
Date:      2009-07-13 14:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/97fd9b42f5c2

Added tag jdk7-b64 for changeset 047dd27fddb6

! .hgtags



From john.coomes at sun.com  Wed Jul 15 15:21:07 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Wed, 15 Jul 2009 22:21:07 +0000
Subject: hg: jdk7/hotspot-gc/jaxp: Added tag jdk7-b64 for changeset
	a10eec7a1edf
Message-ID: <20090715222110.2682AE244@hg.openjdk.java.net>

Changeset: 008c662e0ee9
Author:    xdono
Date:      2009-07-13 14:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/008c662e0ee9

Added tag jdk7-b64 for changeset a10eec7a1edf

! .hgtags



From john.coomes at sun.com  Wed Jul 15 15:26:51 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Wed, 15 Jul 2009 22:26:51 +0000
Subject: hg: jdk7/hotspot-gc/jaxws: Added tag jdk7-b64 for changeset
	aaa25dfd3de6
Message-ID: <20090715222653.30936E249@hg.openjdk.java.net>

Changeset: aa22a1be5866
Author:    xdono
Date:      2009-07-13 14:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/aa22a1be5866

Added tag jdk7-b64 for changeset aaa25dfd3de6

! .hgtags



From john.coomes at sun.com  Wed Jul 15 15:36:01 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Wed, 15 Jul 2009 22:36:01 +0000
Subject: hg: jdk7/hotspot-gc/jdk: 78 new changesets
Message-ID: <20090715225248.3BC05E250@hg.openjdk.java.net>

Changeset: 1299804aa6e7
Author:    xuelei
Date:      2009-06-16 20:46 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1299804aa6e7

6850783: InvalidityDateExtension returns reference to internal mutable state
Summary: return cloned instead of referenced object
Reviewed-by: weijun

! src/share/classes/sun/security/x509/CertificateVersion.java
! src/share/classes/sun/security/x509/InvalidityDateExtension.java

Changeset: bc2c9dbdcc70
Author:    weijun
Date:      2009-06-17 15:26 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bc2c9dbdcc70

6849275: enhance krb5 reg tests
Reviewed-by: xuelei

! test/sun/security/krb5/auto/CrossRealm.java
! test/sun/security/krb5/auto/HttpNegotiateServer.java
! test/sun/security/krb5/auto/KDC.java
! test/sun/security/krb5/auto/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor
! test/sun/security/krb5/auto/OneKDC.java
! test/sun/security/krb5/auto/basic.sh

Changeset: 863351d5d244
Author:    weijun
Date:      2009-06-18 11:12 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/863351d5d244

6712755: jarsigner fails to sign itextasian.jar since 1.5.0_b14, it works with 1.5.0_13
Reviewed-by: mullan

! src/share/classes/sun/security/tools/JarSigner.java
+ test/sun/security/tools/jarsigner/emptymanifest.sh

Changeset: e387bb1367a7
Author:    mullan
Date:      2009-06-18 09:04 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e387bb1367a7

6833839: RFE: improve ManifestDigester by instantiating StringBuilder constructor w/ initial value
Reviewed-by: weijun

! src/share/classes/sun/security/util/ManifestDigester.java

Changeset: 81c176909720
Author:    mullan
Date:      2009-06-18 10:38 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/81c176909720

Merge


Changeset: 37ed72fe7561
Author:    weijun
Date:      2009-06-19 18:03 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/37ed72fe7561

6851973: ignore incoming channel binding if acceptor does not set one
Reviewed-by: valeriep

! src/share/classes/sun/security/jgss/krb5/InitialToken.java
+ test/sun/security/krb5/auto/IgnoreChannelBinding.java

Changeset: ed38f9e6ad9a
Author:    jccollet
Date:      2009-06-19 14:12 +0200
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ed38f9e6ad9a

6852108: Remove Preferences dependance from SocksSocketImpl
Summary: Removed Preferences API use and fixed a few findbugs gotchas
Reviewed-by: alanb

! src/share/classes/java/net/SocksSocketImpl.java

Changeset: 77367060d119
Author:    sherman
Date:      2009-06-19 14:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/77367060d119

6299219: euro sign failed to be printed in Console on Localized Windows platform with GBK encoding
4891024: EUC-KR and JOHAB converters need to be updated to include two new characters
4287467: Character converter generator tool
Summary: Migrated some of the doublebyte charsets to the new implementation.
Reviewed-by: okutsu

! make/sun/nio/FILES_java.gmk
! make/sun/nio/Makefile
+ make/tools/CharsetMapping/EUC_CN.map
+ make/tools/CharsetMapping/EUC_KR.map
+ make/tools/CharsetMapping/GBK.map
+ make/tools/CharsetMapping/Johab.map
+ make/tools/CharsetMapping/MS932.c2b
+ make/tools/CharsetMapping/MS932.map
+ make/tools/CharsetMapping/MS932.nr
+ make/tools/CharsetMapping/MS936.map
+ make/tools/CharsetMapping/MS949.map
+ make/tools/CharsetMapping/MS950.map
+ make/tools/CharsetMapping/MS950.nr
! make/tools/CharsetMapping/dbcs
! make/tools/src/build/tools/charsetmapping/GenerateDBCS.java
! src/share/classes/sun/io/ByteToCharEUC_CN.java
! src/share/classes/sun/io/ByteToCharEUC_KR.java
! src/share/classes/sun/io/ByteToCharGBK.java
! src/share/classes/sun/io/ByteToCharJohab.java
! src/share/classes/sun/io/ByteToCharMS932.java
- src/share/classes/sun/io/ByteToCharMS932DB.java
! src/share/classes/sun/io/ByteToCharMS936.java
! src/share/classes/sun/io/ByteToCharMS949.java
! src/share/classes/sun/io/ByteToCharMS950.java
! src/share/classes/sun/io/ByteToCharMS950_HKSCS.java
! src/share/classes/sun/io/CharToByteEUC_CN.java
! src/share/classes/sun/io/CharToByteEUC_KR.java
! src/share/classes/sun/io/CharToByteGBK.java
! src/share/classes/sun/io/CharToByteJohab.java
! src/share/classes/sun/io/CharToByteMS932.java
- src/share/classes/sun/io/CharToByteMS932DB.java
! src/share/classes/sun/io/CharToByteMS936.java
! src/share/classes/sun/io/CharToByteMS949.java
! src/share/classes/sun/io/CharToByteMS950.java
! src/share/classes/sun/io/CharToByteMS950_HKSCS.java
! src/share/classes/sun/nio/cs/ext/DoubleByte.java
- src/share/classes/sun/nio/cs/ext/EUC_CN.java
- src/share/classes/sun/nio/cs/ext/EUC_KR.java
- src/share/classes/sun/nio/cs/ext/GBK.java
! src/share/classes/sun/nio/cs/ext/ISO2022_CN.java
- src/share/classes/sun/nio/cs/ext/Johab.java
- src/share/classes/sun/nio/cs/ext/MS932.java
- src/share/classes/sun/nio/cs/ext/MS932DB.java
! src/share/classes/sun/nio/cs/ext/MS932_0213.java
- src/share/classes/sun/nio/cs/ext/MS936.java
- src/share/classes/sun/nio/cs/ext/MS949.java
- src/share/classes/sun/nio/cs/ext/MS950.java
! src/share/classes/sun/nio/cs/ext/MS950_HKSCS.java
! src/solaris/classes/sun/awt/motif/X11GB2312.java
! src/solaris/classes/sun/awt/motif/X11GBK.java
! src/solaris/classes/sun/awt/motif/X11KSC5601.java
+ test/sun/nio/cs/OLD/DoubleByteDecoder.java
+ test/sun/nio/cs/OLD/DoubleByteEncoder.java
+ test/sun/nio/cs/OLD/EUC_CN_OLD.java
+ test/sun/nio/cs/OLD/EUC_KR_OLD.java
+ test/sun/nio/cs/OLD/GBK_OLD.java
+ test/sun/nio/cs/OLD/Johab_OLD.java
+ test/sun/nio/cs/OLD/MS932DB.java
+ test/sun/nio/cs/OLD/MS932_OLD.java
+ test/sun/nio/cs/OLD/MS936_OLD.java
+ test/sun/nio/cs/OLD/MS949_OLD.java
+ test/sun/nio/cs/OLD/MS950_OLD.java
! test/sun/nio/cs/OLD/TestIBMDB.java
+ test/sun/nio/cs/OLD/TestX11CS.java
+ test/sun/nio/cs/OLD/X11GB2312_OLD.java
+ test/sun/nio/cs/OLD/X11GBK_OLD.java
+ test/sun/nio/cs/OLD/X11KSC5601_OLD.java

Changeset: 28d4c9f5c9e9
Author:    xlu
Date:      2009-06-20 13:34 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/28d4c9f5c9e9

6850606: Regression from JDK 1.6.0_12
Summary: The returned result from multiply should be constructed by using valueOf to take care of the INFLATED case.
Reviewed-by: darcy

! src/share/classes/java/math/BigDecimal.java
! test/java/math/BigDecimal/MultiplyTests.java

Changeset: b0b249933c37
Author:    martin
Date:      2009-06-22 16:41 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b0b249933c37

6851653: (launcher) Make every java process 20 bytes smaller
Summary: Carefully keep track of every byte
Reviewed-by: ksrini, xlu

! src/share/bin/java.c

Changeset: 7704895771b5
Author:    sherman
Date:      2009-06-22 19:22 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7704895771b5

6847092: (cs) CharsetEncoder.isLegalReplacement of US_ASCII behaves differently since
Summary: Updated the US_ASCII and ISO-8859-1 to fix the failure.
Reviewed-by: alanb, martin

! src/share/classes/sun/nio/cs/ISO_8859_1.java
! src/share/classes/sun/nio/cs/US_ASCII.java
+ test/sun/nio/cs/FindASCIIReplBugs.java

Changeset: ce55eb6668d9
Author:    martin
Date:      2009-06-22 20:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ce55eb6668d9

6834805: Improve jar -C performance
Summary: Store "-C" directories in a HashSet, not List, to remove duplicates
Reviewed-by: sherman
Contributed-by: jeremymanson at google.com

! src/share/classes/sun/tools/jar/Main.java

Changeset: ff32c270102a
Author:    martin
Date:      2009-06-22 21:07 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ff32c270102a

6853806: Prefer (cd $dir && jar) to jar -C for performance reasons
Summary: Eliminate (most) uses of jar -C
Reviewed-by: ohair

! make/common/Release.gmk

Changeset: b3444a42fd40
Author:    tbell
Date:      2009-06-23 22:07 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b3444a42fd40

Merge

- src/share/classes/sun/io/ByteToCharMS932DB.java
- src/share/classes/sun/io/CharToByteMS932DB.java
- src/share/classes/sun/nio/cs/ext/EUC_CN.java
- src/share/classes/sun/nio/cs/ext/EUC_KR.java
- src/share/classes/sun/nio/cs/ext/GBK.java
- src/share/classes/sun/nio/cs/ext/Johab.java
- src/share/classes/sun/nio/cs/ext/MS932.java
- src/share/classes/sun/nio/cs/ext/MS932DB.java
- src/share/classes/sun/nio/cs/ext/MS936.java
- src/share/classes/sun/nio/cs/ext/MS949.java
- src/share/classes/sun/nio/cs/ext/MS950.java

Changeset: 70c0a927e21a
Author:    jccollet
Date:      2009-06-25 18:56 +0200
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/70c0a927e21a

6811297: Add more logging to HTTP protocol handler
Summary: Added extra logging to HttpURLConnection and HttpClient. Added a capture tool.
Reviewed-by: chegar

! make/sun/net/FILES_java.gmk
+ src/share/classes/sun/net/www/http/HttpCapture.java
+ src/share/classes/sun/net/www/http/HttpCaptureInputStream.java
+ src/share/classes/sun/net/www/http/HttpCaptureOutputStream.java
! src/share/classes/sun/net/www/http/HttpClient.java
+ src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

Changeset: 5a3a5388756c
Author:    langel
Date:      2009-06-25 17:01 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5a3a5388756c

6852607: MessageUtils JVM crash
Summary: Fixes crash by checking null field
Reviewed-by: alanb

! src/share/native/sun/misc/MessageUtils.c

Changeset: 0b6571d4b4b5
Author:    jccollet
Date:      2009-06-26 16:50 +0200
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0b6571d4b4b5

6855297: Windows build breaks after 6811297
Summary: re-introduced the mistakenly taken out authObj member
Reviewed-by: chegar

! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

Changeset: 9f243df213fa
Author:    tbell
Date:      2009-06-26 10:25 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9f243df213fa

Merge

- src/share/classes/sun/io/ByteToCharMS932DB.java
- src/share/classes/sun/io/CharToByteMS932DB.java
- src/share/classes/sun/nio/cs/ext/EUC_CN.java
- src/share/classes/sun/nio/cs/ext/EUC_KR.java
- src/share/classes/sun/nio/cs/ext/GBK.java
- src/share/classes/sun/nio/cs/ext/Johab.java
- src/share/classes/sun/nio/cs/ext/MS932.java
- src/share/classes/sun/nio/cs/ext/MS932DB.java
- src/share/classes/sun/nio/cs/ext/MS936.java
- src/share/classes/sun/nio/cs/ext/MS949.java
- src/share/classes/sun/nio/cs/ext/MS950.java

Changeset: a5f7d97c3f82
Author:    jjg
Date:      2009-06-26 18:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a5f7d97c3f82

6843077: JSR 308: Annotations on types
Reviewed-by: jjg, mcimadamore, darcy
Contributed-by: mernst at cs.washington.edu, mali at csail.mit.edu, mpapi at csail.mit.edu

! src/share/classes/java/lang/annotation/ElementType.java

Changeset: bd4f0613dd92
Author:    tbell
Date:      2009-06-28 00:00 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bd4f0613dd92

Merge


Changeset: 5208d0c90d73
Author:    alanb
Date:      2009-06-27 21:46 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5208d0c90d73

6838333: New I/O: Update file system API to jsr203/nio2-b101
6844313: New I/O: File timestamps should be represented by a FileTime rather than a long+TimeUnit
Reviewed-by: sherman

! make/java/java/FILES_java.gmk
! make/java/nio/FILES_java.gmk
! make/java/nio/mapfile-linux
! make/java/nio/mapfile-solaris
! src/share/classes/java/io/File.java
+ src/share/classes/java/io/TempFileHelper.java
! src/share/classes/java/nio/channels/SeekableByteChannel.java
! src/share/classes/java/nio/file/AccessMode.java
! src/share/classes/java/nio/file/DirectoryStream.java
- src/share/classes/java/nio/file/DirectoryStreamFilters.java
- src/share/classes/java/nio/file/FileAction.java
! src/share/classes/java/nio/file/FileRef.java
! src/share/classes/java/nio/file/FileStore.java
! src/share/classes/java/nio/file/FileTreeWalker.java
! src/share/classes/java/nio/file/FileVisitor.java
! src/share/classes/java/nio/file/Files.java
! src/share/classes/java/nio/file/LinkPermission.java
! src/share/classes/java/nio/file/OpenOption.java
! src/share/classes/java/nio/file/Path.java
! src/share/classes/java/nio/file/Paths.java
! src/share/classes/java/nio/file/SecureDirectoryStream.java
! src/share/classes/java/nio/file/SimpleFileVisitor.java
! src/share/classes/java/nio/file/StandardWatchEventKind.java
! src/share/classes/java/nio/file/WatchKey.java
! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java
! src/share/classes/java/nio/file/attribute/AttributeView.java
! src/share/classes/java/nio/file/attribute/Attributes.java
! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java
! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java
! src/share/classes/java/nio/file/attribute/DosFileAttributeView.java
! src/share/classes/java/nio/file/attribute/FileAttributeView.java
! src/share/classes/java/nio/file/attribute/FileOwnerAttributeView.java
! src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java
+ src/share/classes/java/nio/file/attribute/FileTime.java
! src/share/classes/java/nio/file/attribute/PosixFileAttributeView.java
! src/share/classes/java/nio/file/attribute/PosixFilePermissions.java
! src/share/classes/java/nio/file/attribute/UserDefinedFileAttributeView.java
! src/share/classes/java/nio/file/attribute/UserPrincipalLookupService.java
- src/share/classes/java/nio/file/spi/AbstractPath.java
! src/share/classes/java/nio/file/spi/FileSystemProvider.java
! src/share/classes/java/util/Scanner.java
! src/share/classes/sun/nio/fs/AbstractAclFileAttributeView.java
! src/share/classes/sun/nio/fs/AbstractBasicFileAttributeView.java
- src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java
! src/share/classes/sun/nio/fs/AbstractFileTypeDetector.java
+ src/share/classes/sun/nio/fs/AbstractPath.java
! src/share/classes/sun/nio/fs/AbstractUserDefinedFileAttributeView.java
+ src/share/classes/sun/nio/fs/DynamicFileAttributeView.java
! src/share/classes/sun/nio/fs/FileOwnerAttributeViewImpl.java
- src/share/classes/sun/nio/fs/MimeType.java
! src/share/classes/sun/nio/fs/PollingWatchService.java
+ src/share/classes/sun/nio/fs/Util.java
! src/share/sample/nio/file/Copy.java
! src/share/sample/nio/file/Xdd.java
! src/solaris/classes/sun/nio/fs/LinuxDosFileAttributeView.java
! src/solaris/classes/sun/nio/fs/LinuxFileStore.java
! src/solaris/classes/sun/nio/fs/LinuxFileSystem.java
! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java
! src/solaris/classes/sun/nio/fs/SolarisFileStore.java
! src/solaris/classes/sun/nio/fs/SolarisFileSystem.java
! src/solaris/classes/sun/nio/fs/UnixChannelFactory.java
! src/solaris/classes/sun/nio/fs/UnixCopyFile.java
! src/solaris/classes/sun/nio/fs/UnixDirectoryStream.java
! src/solaris/classes/sun/nio/fs/UnixFileAttributeViews.java
! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java
! src/solaris/classes/sun/nio/fs/UnixFileKey.java
! src/solaris/classes/sun/nio/fs/UnixFileModeAttribute.java
! src/solaris/classes/sun/nio/fs/UnixFileStore.java
! src/solaris/classes/sun/nio/fs/UnixFileSystem.java
! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java
! src/solaris/classes/sun/nio/fs/UnixMountEntry.java
! src/solaris/classes/sun/nio/fs/UnixNativeDispatcher.java
! src/solaris/classes/sun/nio/fs/UnixPath.java
! src/solaris/classes/sun/nio/fs/UnixSecureDirectoryStream.java
! src/solaris/classes/sun/nio/fs/UnixUserPrincipals.java
! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c
! src/solaris/native/sun/nio/fs/genUnixConstants.c
! src/windows/classes/sun/nio/fs/WindowsConstants.java
! src/windows/classes/sun/nio/fs/WindowsDirectoryStream.java
! src/windows/classes/sun/nio/fs/WindowsFileAttributeViews.java
! src/windows/classes/sun/nio/fs/WindowsFileAttributes.java
! src/windows/classes/sun/nio/fs/WindowsFileStore.java
! src/windows/classes/sun/nio/fs/WindowsFileSystem.java
! src/windows/classes/sun/nio/fs/WindowsLinkSupport.java
! src/windows/classes/sun/nio/fs/WindowsNativeDispatcher.java
! src/windows/classes/sun/nio/fs/WindowsPath.java
! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c
! test/java/nio/file/DirectoryStream/Basic.java
- test/java/nio/file/DirectoryStream/Filters.java
! test/java/nio/file/DirectoryStream/SecureDS.java
! test/java/nio/file/FileSystem/Basic.java
! test/java/nio/file/Files/ContentType.java
! test/java/nio/file/Files/Misc.java
- test/java/nio/file/Files/content_type.sh
! test/java/nio/file/Path/CopyAndMove.java
+ test/java/nio/file/Path/FileAttributes.java
! test/java/nio/file/Path/Links.java
! test/java/nio/file/Path/Misc.java
! test/java/nio/file/Path/PathOps.java
! test/java/nio/file/Path/TemporaryFiles.java
- test/java/nio/file/Path/temporary_files.sh
! test/java/nio/file/TestUtil.java
! test/java/nio/file/WatchService/Basic.java
! test/java/nio/file/WatchService/FileTreeModifier.java
! test/java/nio/file/attribute/AclFileAttributeView/Basic.java
- test/java/nio/file/attribute/Attributes/Basic.java
! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java
! test/java/nio/file/attribute/DosFileAttributeView/Basic.java
! test/java/nio/file/attribute/FileStoreAttributeView/Basic.java
+ test/java/nio/file/attribute/FileTime/Basic.java
! test/java/nio/file/attribute/PosixFileAttributeView/Basic.java
! test/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java

Changeset: 77dd50ba670b
Author:    alanb
Date:      2009-06-27 21:49 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/77dd50ba670b

6844054: (bf) Eliminate dependency on javax.management.ObjectName
Reviewed-by: mchung

! src/share/classes/java/lang/management/PlatformComponent.java
! src/share/classes/java/nio/Bits.java
! src/share/classes/java/nio/Direct-X-Buffer.java
! src/share/classes/sun/management/ManagementFactoryHelper.java
! src/share/classes/sun/misc/JavaNioAccess.java
! src/share/classes/sun/nio/ch/FileChannelImpl.java

Changeset: dd20c662d463
Author:    ohair
Date:      2009-06-26 21:52 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dd20c662d463

6855180: Fix classfile version check in java_crw_demo
Reviewed-by: jjg

! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c
! src/share/javavm/export/classfile_constants.h

Changeset: cbb5964d97ef
Author:    ohair
Date:      2009-06-28 11:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cbb5964d97ef

Merge

- src/share/classes/java/nio/file/DirectoryStreamFilters.java
- src/share/classes/java/nio/file/FileAction.java
- src/share/classes/java/nio/file/spi/AbstractPath.java
- src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java
- src/share/classes/sun/nio/fs/MimeType.java
- test/java/nio/file/DirectoryStream/Filters.java
- test/java/nio/file/Files/content_type.sh
- test/java/nio/file/Path/temporary_files.sh
- test/java/nio/file/attribute/Attributes/Basic.java

Changeset: 35b19adcb215
Author:    tbell
Date:      2009-06-28 23:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/35b19adcb215

Merge

- src/share/classes/java/nio/file/DirectoryStreamFilters.java
- src/share/classes/java/nio/file/FileAction.java
- src/share/classes/java/nio/file/spi/AbstractPath.java
- src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java
- src/share/classes/sun/nio/fs/MimeType.java
- test/java/nio/file/DirectoryStream/Filters.java
- test/java/nio/file/Files/content_type.sh
- test/java/nio/file/Path/temporary_files.sh
- test/java/nio/file/attribute/Attributes/Basic.java

Changeset: 806c5e4d1265
Author:    michaelm
Date:      2009-06-29 13:10 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/806c5e4d1265

6513803: httpserver regression test Test13 failing and causing NullPointerException
Summary: check for NPEs
Reviewed-by: chegar

! test/com/sun/net/httpserver/Test1.java
! test/com/sun/net/httpserver/Test12.java
! test/com/sun/net/httpserver/Test13.java
! test/com/sun/net/httpserver/Test3.java
! test/com/sun/net/httpserver/Test4.java
! test/com/sun/net/httpserver/Test5.java
! test/com/sun/net/httpserver/Test9.java
! test/com/sun/net/httpserver/Test9a.java
! test/com/sun/net/httpserver/TestLogging.java

Changeset: b6721df9ae0a
Author:    michaelm
Date:      2009-06-29 13:29 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b6721df9ae0a

Merge


Changeset: a44009aba19f
Author:    chegar
Date:      2009-06-29 14:53 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a44009aba19f

6855335: Several changes in the SCTP implementation.
Reviewed-by: michaelm

! make/com/sun/nio/sctp/mapfile-vers
! src/solaris/classes/sun/nio/ch/SctpChannelImpl.java
! src/solaris/classes/sun/nio/ch/SctpMultiChannelImpl.java
! src/solaris/classes/sun/nio/ch/SctpNet.java
! src/solaris/classes/sun/nio/ch/SctpResultContainer.java
! src/solaris/classes/sun/nio/ch/SctpServerChannelImpl.java
! src/solaris/native/sun/nio/ch/Sctp.h
! src/solaris/native/sun/nio/ch/SctpChannelImpl.c
! src/solaris/native/sun/nio/ch/SctpNet.c
! test/com/sun/nio/sctp/SctpChannel/Connect.java
! test/com/sun/nio/sctp/SctpChannel/Shutdown.java
! test/com/sun/nio/sctp/SctpChannel/SocketOptionTests.java
+ test/com/sun/nio/sctp/SctpMultiChannel/Branch.java
+ test/com/sun/nio/sctp/SctpMultiChannel/SocketOptionTests.java

Changeset: 89b14d3740dc
Author:    michaelm
Date:      2009-06-29 15:05 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/89b14d3740dc

6827999: 6827999: URLClassLoader.addURL(URL) adds URLs to closed class loader
Reviewed-by: chegar

! src/share/classes/sun/misc/URLClassPath.java
+ test/java/net/URLClassLoader/B6827999.java

Changeset: 424420bf5917
Author:    michaelm
Date:      2009-06-29 15:08 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/424420bf5917

Merge

- src/share/classes/java/nio/file/DirectoryStreamFilters.java
- src/share/classes/java/nio/file/FileAction.java
- src/share/classes/java/nio/file/spi/AbstractPath.java
- src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java
- src/share/classes/sun/nio/fs/MimeType.java
- test/java/nio/file/DirectoryStream/Filters.java
- test/java/nio/file/Files/content_type.sh
- test/java/nio/file/Path/temporary_files.sh
- test/java/nio/file/attribute/Attributes/Basic.java

Changeset: d926534a1c17
Author:    jjg
Date:      2009-06-29 16:28 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d926534a1c17

6855069: rmic should support v51 class files.
Reviewed-by: jrose

! src/share/classes/sun/tools/java/RuntimeConstants.java

Changeset: cb20a8a1f22f
Author:    tbell
Date:      2009-06-29 17:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cb20a8a1f22f

Merge


Changeset: 605d3fa6764e
Author:    weijun
Date:      2009-06-30 11:55 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/605d3fa6764e

6855671: DerOutputStream encodes negative integer incorrectly
Reviewed-by: xuelei

! src/share/classes/sun/security/util/DerOutputStream.java
+ test/sun/security/util/DerValue/NegInt.java

Changeset: 1cc9eb0c952e
Author:    sherman
Date:      2009-06-29 19:57 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1cc9eb0c952e

6707281: Adler32.update() JavaDoc is wrong
6553961: java.util.zip.{CRC32,Adler32}.update(int) doc errors
6646605: Missing method ZipFile.getComment()
6841232: ZipFile should implement Closeable
4985614: Failure on calls to ZipFile constructor
5032358: "java.util.zip.ZipException: The system cannot find the file specified"
6846616: java/util/zip/ZipFile/ReadAfterClose.java failed after fix for 6735255
Summary: some misc bug/rfe fixes for zipfile
Reviewed-by: alanb

! make/java/java/mapfile-vers
! make/java/zip/mapfile-vers
! src/share/classes/java/util/zip/Adler32.java
! src/share/classes/java/util/zip/CRC32.java
! src/share/classes/java/util/zip/ZipFile.java
! src/share/native/java/util/zip/ZipFile.c
! src/share/native/java/util/zip/zip_util.c
! src/share/native/java/util/zip/zip_util.h
! test/java/util/zip/ZipFile/ReadAfterClose.java
! test/java/util/zip/ZipFile/ReadZip.java

Changeset: b144685f6694
Author:    sherman
Date:      2009-06-29 21:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b144685f6694

Merge


Changeset: 861f23119072
Author:    tbell
Date:      2009-06-29 23:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/861f23119072

Merge


Changeset: 4e4ff42f3140
Author:    tbell
Date:      2009-07-03 09:15 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4e4ff42f3140

Merge


Changeset: 49e7d22262a9
Author:    ant
Date:      2009-06-18 11:28 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/49e7d22262a9

4788402: SortingFocusTraversalPolicy: prob with non-focusable focus Cycle Root as first
Reviewed-by: dcherepanov

! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java
! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java
! test/java/awt/Focus/FocusTraversalPolicy/DefaultFTPTest.java
! test/java/awt/Focus/FocusTraversalPolicy/LayoutFTPTest.java

Changeset: 06f35d090a5e
Author:    langel
Date:      2009-06-19 16:49 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/06f35d090a5e

6721086: Toolkit beep does not work consistently
Summary: Flush out after bell is sounded
Reviewed-by: anthony

! src/solaris/classes/sun/awt/X11/XToolkit.java

Changeset: d1bdaf29e531
Author:    dcherepanov
Date:      2009-06-23 13:35 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d1bdaf29e531

6824169: Need to remove some AWT class dependencies
Reviewed-by: art, anthony, igor, alexp

! src/share/classes/java/awt/AWTEvent.java
! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/Dialog.java
! src/share/classes/java/awt/EventQueue.java
! src/share/classes/java/awt/MenuComponent.java
! src/share/classes/java/awt/PopupMenu.java
! src/share/classes/java/awt/Window.java
! src/share/classes/javax/swing/BufferStrategyPaintManager.java
! src/share/classes/javax/swing/JLayeredPane.java
! src/share/classes/javax/swing/LayoutFocusTraversalPolicy.java
! src/share/classes/javax/swing/LookAndFeel.java
! src/share/classes/javax/swing/TransferHandler.java
! src/share/classes/javax/swing/UIManager.java
! src/share/classes/javax/swing/text/JTextComponent.java
! src/share/classes/sun/awt/AWTAccessor.java
! src/share/classes/sun/awt/SunToolkit.java
! src/share/classes/sun/awt/shell/ShellFolder.java
- src/share/classes/sun/swing/AccessibleMethod.java
+ src/share/classes/sun/swing/SwingAccessor.java
! src/solaris/classes/sun/awt/X11/XToolkit.java
! src/windows/classes/sun/awt/windows/WComponentPeer.java
! src/windows/classes/sun/awt/windows/WEmbeddedFrame.java
! src/windows/classes/sun/awt/windows/WFileDialogPeer.java
! src/windows/classes/sun/awt/windows/WPopupMenuPeer.java
! src/windows/classes/sun/awt/windows/WPrintDialogPeer.java
! src/windows/classes/sun/java2d/windows/GDIWindowSurfaceData.java

Changeset: 61e25d428bfe
Author:    dcherepanov
Date:      2009-06-23 15:10 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/61e25d428bfe

6736247: Component.printAll Invalid local JNI handle
Reviewed-by: anthony

! src/windows/native/sun/windows/awt_Component.cpp
+ test/java/awt/Component/PrintAllXcheckJNI/PrintAllXcheckJNI.java

Changeset: e279dd2c5a2c
Author:    ant
Date:      2009-06-23 15:53 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e279dd2c5a2c

6821291: assertion failure in awt_Frame.h
Reviewed-by: dcherepanov, art

! src/windows/native/sun/windows/awt_Frame.cpp
! src/windows/native/sun/windows/awt_Frame.h

Changeset: 51e452ff726a
Author:    anthony
Date:      2009-06-23 16:10 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/51e452ff726a

6851646: test/closed/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java can fail
Summary: Added realSync() call. Made the test public.
Reviewed-by: dcherepanov

+ test/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.html
+ test/java/awt/GridBagLayout/GridBagLayoutIpadXYTest/GridBagLayoutIpadXYTest.java

Changeset: 5e880ea33ddc
Author:    yan
Date:      2009-06-26 11:48 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5e880ea33ddc

6711676: Numpad keys trigger more than one KeyEvent.
Summary: Introduce a new sniffer based on server keymap.
Reviewed-by: art

! make/sun/xawt/mapfile-vers
! src/solaris/classes/sun/awt/X11/XKeysym.java
! src/solaris/classes/sun/awt/X11/XToolkit.java
! src/solaris/classes/sun/awt/X11/XlibWrapper.java
! src/solaris/classes/sun/awt/X11/keysym2ucs.h
! src/solaris/native/sun/xawt/XlibWrapper.c

Changeset: 60290477fe73
Author:    dav
Date:      2009-06-26 19:50 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/60290477fe73

6848458: java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java fails
Summary: consider gap between the component edge and container borders instead of just getX() and getY()
Reviewed-by: dav
Contributed-by: mwong at redhat.com

! test/java/awt/GridLayout/LayoutExtraGaps/LayoutExtraGaps.java

Changeset: 2df0d81c4201
Author:    ant
Date:      2009-06-30 12:55 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2df0d81c4201

6855713: jdk7: debug build failure in awt_Frame.cpp
Reviewed-by: dcherepanov, yan

! src/windows/native/sun/windows/awt_Frame.cpp

Changeset: 75497b840ed0
Author:    yan
Date:      2009-06-30 02:48 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/75497b840ed0

Merge

- src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/IBM1381.java
- src/share/classes/sun/nio/cs/ext/IBM1383.java
- src/share/classes/sun/nio/cs/ext/IBM930.java
- src/share/classes/sun/nio/cs/ext/IBM933.java
- src/share/classes/sun/nio/cs/ext/IBM935.java
- src/share/classes/sun/nio/cs/ext/IBM937.java
- src/share/classes/sun/nio/cs/ext/IBM939.java
- src/share/classes/sun/nio/cs/ext/IBM942.java
- src/share/classes/sun/nio/cs/ext/IBM943.java
- src/share/classes/sun/nio/cs/ext/IBM948.java
- src/share/classes/sun/nio/cs/ext/IBM949.java
- src/share/classes/sun/nio/cs/ext/IBM950.java
- src/share/classes/sun/nio/cs/ext/IBM970.java
- src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java
- src/share/native/sun/font/bidi/cmemory.h
- src/share/native/sun/font/bidi/jbidi.c
- src/share/native/sun/font/bidi/jbidi.h
- src/share/native/sun/font/bidi/ubidi.c
- src/share/native/sun/font/bidi/ubidi.h
- src/share/native/sun/font/bidi/ubidiimp.h
- src/share/native/sun/font/bidi/ubidiln.c
- src/share/native/sun/font/bidi/uchardir.c
- src/share/native/sun/font/bidi/uchardir.h
- src/share/native/sun/font/bidi/utypes.h

Changeset: 4d7e08935d95
Author:    yan
Date:      2009-07-01 00:17 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4d7e08935d95

Merge

- src/share/classes/sun/swing/AccessibleMethod.java

Changeset: 743021a4938c
Author:    peterz
Date:      2009-06-22 18:08 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/743021a4938c

6849277: Nimbus L&F: lots of painter classes were added to JDK7 as public
Reviewed-by: malenkov

! src/share/classes/javax/swing/plaf/nimbus/Defaults.template
! src/share/classes/javax/swing/plaf/nimbus/PainterImpl.template

Changeset: ce347002bbd9
Author:    peterz
Date:      2009-06-23 12:24 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ce347002bbd9

6844273: jdk/make/docs/CORE_PKGS.gmk does not list Nimbus
Reviewed-by: prr

! make/docs/CORE_PKGS.gmk
! src/share/classes/javax/swing/plaf/nimbus/package.html

Changeset: b75fc6019d5f
Author:    malenkov
Date:      2009-06-24 13:59 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b75fc6019d5f

6852574: EnumPersistenceDelegate fails to persist instances with blocks
Reviewed-by: peterz

! src/share/classes/java/beans/MetaData.java
+ test/java/beans/XMLEncoder/Test6852574.java

Changeset: 404a13b063f9
Author:    malenkov
Date:      2009-06-24 17:45 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/404a13b063f9

6737700: api/javax_swing/table/DefaultTableCellRenderer/index.html#getset:DefaultTableCellRenderer
Reviewed-by: alexp

! src/share/classes/javax/swing/table/DefaultTableCellRenderer.java

Changeset: e006119341de
Author:    peytoia
Date:      2009-06-25 07:38 +0900
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e006119341de

6853792: test/java/text/Bidi/Bug6850113.java compilation error
Reviewed-by: okutsu

! test/java/text/Bidi/Bug6850113.java

Changeset: d6f2dd2bd8d0
Author:    peytoia
Date:      2009-06-25 17:37 +0900
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d6f2dd2bd8d0

6609750: [Fmt-De] SimpleDateFormat.format() doesn't handle pattern "y" correctly
Reviewed-by: okutsu

! src/share/classes/java/text/SimpleDateFormat.java
+ test/java/text/Format/DateFormat/Bug6609750.java

Changeset: d086e324775c
Author:    yan
Date:      2009-06-25 00:18 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d086e324775c

Merge

- src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/IBM1381.java
- src/share/classes/sun/nio/cs/ext/IBM1383.java
- src/share/classes/sun/nio/cs/ext/IBM930.java
- src/share/classes/sun/nio/cs/ext/IBM933.java
- src/share/classes/sun/nio/cs/ext/IBM935.java
- src/share/classes/sun/nio/cs/ext/IBM937.java
- src/share/classes/sun/nio/cs/ext/IBM939.java
- src/share/classes/sun/nio/cs/ext/IBM942.java
- src/share/classes/sun/nio/cs/ext/IBM943.java
- src/share/classes/sun/nio/cs/ext/IBM948.java
- src/share/classes/sun/nio/cs/ext/IBM949.java
- src/share/classes/sun/nio/cs/ext/IBM950.java
- src/share/classes/sun/nio/cs/ext/IBM970.java
- src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java

Changeset: 4d54d6e7bcef
Author:    yan
Date:      2009-06-25 02:42 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4d54d6e7bcef

Merge


Changeset: e0707baa1593
Author:    peytoia
Date:      2009-06-25 21:55 +0900
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e0707baa1593

6792400: Avoid loading of Normalizer resources for simple uses
Reviewed-by: okutsu

! src/share/classes/sun/text/normalizer/NormalizerBase.java

Changeset: ae9e74a17059
Author:    malenkov
Date:      2009-06-25 18:50 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ae9e74a17059

6848364: javax/swing/border/Test4856008.java regression test fails due to BorderedComponent package not found
Reviewed-by: alexp

! test/javax/swing/border/Test4856008.java

Changeset: f1f9d228800e
Author:    peterz
Date:      2009-06-26 08:09 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f1f9d228800e

6827032: NIMBUS: Drag and drop throws a NPE in SwingSet2 ColorChooser
Reviewed-by: malenkov

! src/share/classes/javax/swing/plaf/synth/SynthColorChooserUI.java

Changeset: e60d3354ab9f
Author:    malenkov
Date:      2009-06-26 16:30 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e60d3354ab9f

6557223: Resize cursor stays after fast outline-resize of JInternalFrame with JScrollPane
Reviewed-by: peterz

! src/share/classes/javax/swing/plaf/basic/BasicInternalFrameUI.java

Changeset: 1b40ddc3688c
Author:    malenkov
Date:      2009-06-26 16:58 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1b40ddc3688c

6679840: provide a way to choose v-synced BufferStrategy
Reviewed-by: peterz

! src/share/classes/com/sun/java/swing/SwingUtilities3.java
! src/share/classes/javax/swing/BufferStrategyPaintManager.java

Changeset: 800082d9b8df
Author:    malenkov
Date:      2009-06-26 17:15 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/800082d9b8df

6742850: Antialiasing for GTK L&F should be turned on by default if there is no embedded bitmap.
Reviewed-by: peterz

! src/share/classes/com/sun/java/swing/plaf/gtk/GTKLookAndFeel.java

Changeset: 95f3fb73cf60
Author:    peterz
Date:      2009-06-26 21:43 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/95f3fb73cf60

6849805: Nimbus L&F: NimbusLookAndFeel.getDerivedColor() not always returns color2 for 1.0 midPoint
Summary: Different rounding mode used for float->int conversion
Reviewed-by: malenkov

! src/share/classes/javax/swing/plaf/nimbus/AbstractRegionPainter.java
! src/share/classes/javax/swing/plaf/nimbus/NimbusLookAndFeel.java
+ test/javax/swing/plaf/nimbus/Test6849805.java

Changeset: 0bc2fa2d1938
Author:    peytoia
Date:      2009-06-30 09:38 +0900
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0bc2fa2d1938

6855715: Font2Dtest demo needs to be updated to support Unicode 5.1.0.
Reviewed-by: okutsu

! src/share/demo/jfc/Font2DTest/RangeMenu.java

Changeset: 9be953f877a8
Author:    yan
Date:      2009-07-01 00:23 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9be953f877a8

Merge

! src/share/classes/javax/swing/BufferStrategyPaintManager.java

Changeset: 1a52b17a18d2
Author:    yan
Date:      2009-07-07 23:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1a52b17a18d2

Merge

- src/share/classes/sun/swing/AccessibleMethod.java

Changeset: 9053bcc8eef0
Author:    herrick
Date:      2009-06-12 14:56 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9053bcc8eef0

6797688: Umbrella: Merge all JDK 6u4 - 6u12 deployment code into JDK7
6845973: Update JDK7 with deployment changes in 6u13, 6u14
4802695: Support 64-bit Java Plug-in and Java webstart on Windows/Linux on AMD64
6825019: DownloadManager should not be loaded and referenced for full JRE
6738770: REGRESSION:JSException throws when use LiveConnect javascript facility
6772884: plugin2 : java.lang.OutOfMemoryError or crash
6707535: Crossing domain hole affecting multiple sites/domains using plug-in
6728071: Non-verification of Update files may allow unintended updates
6704154: Code loaded from local filesystem should not get access to localhost
6727081: Web Start security restrictions bypass using special extension jnlp
6727079: Java Web Start Socket() restriction bypass
6727071: Cache location/user name information disclosure in SingleInstanceImpl.
6716217: AppletClassLoader adds permissions based on codebase regardless of CS
6694892: Java Webstart inclusion via system properties override [CVE-2008-2086]
6704074: localhost socket access due to cache location exposed
6703909: Java webstart arbitrary file creation using nativelib
6665315: browser crashes when deployment.properties has more slashes ( / )
6660121: Encoding values in JNLP files can cause buffer overflow
6606110: URLConnection.setProxiedHost for resources that are loaded via proxy
6581221: SSV(VISTA): Redirection FAILS to work if user does a downgrade install
6609756: Buffer Overflow in Java ActiveX component
6608712: Bypassing the same origin policy in Java with crafted names
6534630: "gnumake clobber" doesn't
6849953: JDK7 - replacement of bufferoverflowU.lib on amd64 breaks build
6849029: Need some JDK7 merge clean-up after comments on the webrev
6847582: Build problem on JDK7 with isSecureProperty in merge
6827935: JDK 7 deployment merging - problem in Compiler-msvm.gmk
6823215: latest merge fixes from 6u12 -> JDK7
6816153: further mergers for JDK7 deployment integration
6807074: Fix Java Kernel and JQS in initial JDK7 builds
Summary: Initial changeset for implementing 6uX Deployment Features into JDK7
Reviewed-by: dgu, billyh

! make/com/sun/java/pack/Makefile
! make/common/Defs-windows.gmk
! make/common/Library.gmk
! make/common/Program.gmk
! make/common/Release.gmk
! make/common/shared/Compiler-msvc.gmk
! make/common/shared/Defs-utils.gmk
! make/common/shared/Defs-windows.gmk
! make/common/shared/Defs.gmk
! make/common/shared/Sanity.gmk
! make/java/java/FILES_c.gmk
! make/java/redist/Makefile
! make/jpda/tty/Makefile
! make/sun/Makefile
! make/sun/applet/Makefile
! make/sun/jar/Makefile
! make/sun/javazic/tzdata_jdk/jdk11_full_backward
! make/sun/jconsole/Makefile
+ make/sun/jkernel/FILES_c_windows.gmk
+ make/sun/jkernel/FILES_java.gmk
+ make/sun/jkernel/Makefile
! make/sun/native2ascii/Makefile
! make/sun/rmi/rmic/Makefile
! make/sun/serialver/Makefile
! src/share/classes/java/awt/color/ICC_Profile.java
! src/share/classes/java/lang/ClassLoader.java
! src/share/classes/java/lang/System.java
! src/share/classes/java/util/zip/ZipEntry.java
! src/share/classes/sun/applet/AppletClassLoader.java
! src/share/classes/sun/applet/AppletPanel.java
+ src/share/classes/sun/jkernel/BackgroundDownloader.java
+ src/share/classes/sun/jkernel/Bundle.java
+ src/share/classes/sun/jkernel/BundleCheck.java
+ src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java
+ src/share/classes/sun/jkernel/DigestOutputStream.java
+ src/share/classes/sun/jkernel/DownloadManager.java
+ src/share/classes/sun/jkernel/KernelError.java
+ src/share/classes/sun/jkernel/Mutex.java
+ src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java
+ src/share/classes/sun/jkernel/StandaloneMessageDigest.java
+ src/share/classes/sun/jkernel/StandaloneSHA.java
! src/share/classes/sun/management/OperatingSystemImpl.java
! src/share/classes/sun/management/ThreadImpl.java
! src/share/classes/sun/misc/Launcher.java
! src/share/classes/sun/misc/PerformanceLogger.java
! src/share/classes/sun/misc/VM.java
! src/share/native/common/jni_util.c
! src/share/native/common/jni_util.h
! src/share/native/sun/misc/VM.c
+ src/solaris/native/common/jni_util_md.c
! src/windows/bin/java_md.c
+ src/windows/native/common/jni_util_md.c
+ src/windows/native/sun/jkernel/DownloadDialog.cpp
+ src/windows/native/sun/jkernel/DownloadDialog.h
+ src/windows/native/sun/jkernel/DownloadHelper.cpp
+ src/windows/native/sun/jkernel/DownloadHelper.h
+ src/windows/native/sun/jkernel/graphics/bullet.bmp
+ src/windows/native/sun/jkernel/graphics/cautionshield32.bmp
+ src/windows/native/sun/jkernel/graphics/java-icon.ico
+ src/windows/native/sun/jkernel/graphics/masthead.bmp
+ src/windows/native/sun/jkernel/graphics/warningmasthead.bmp
+ src/windows/native/sun/jkernel/kernel.cpp
+ src/windows/native/sun/jkernel/kernel.def
+ src/windows/native/sun/jkernel/kernel.h
+ src/windows/native/sun/jkernel/kernel.rc
+ src/windows/native/sun/jkernel/kernel_de.rc
+ src/windows/native/sun/jkernel/kernel_en.rc
+ src/windows/native/sun/jkernel/kernel_es.rc
+ src/windows/native/sun/jkernel/kernel_fr.rc
+ src/windows/native/sun/jkernel/kernel_it.rc
+ src/windows/native/sun/jkernel/kernel_ja.rc
+ src/windows/native/sun/jkernel/kernel_ko.rc
+ src/windows/native/sun/jkernel/kernel_sv.rc
+ src/windows/native/sun/jkernel/kernel_zh.rc
+ src/windows/native/sun/jkernel/kernel_zh_TW.rc
+ src/windows/native/sun/jkernel/resource.h
+ src/windows/native/sun/jkernel/stdafx.cpp
+ src/windows/native/sun/jkernel/stdafx.h
+ src/windows/native/sun/jkernel/version.rc
! src/windows/native/sun/windows/awt.rc
+ src/windows/resource/unpack200_proto.exe.manifest
! src/windows/resource/version.rc
! test/java/awt/Focus/NonFocusableWindowTest/NoEventsTest.java
! test/java/awt/Focus/RestoreFocusOnDisabledComponentTest/RestoreFocusOnDisabledComponentTest.java
! test/java/awt/font/Rotate/TranslatedOutlineTest.java
! test/java/awt/font/Threads/FontThread.java
! test/java/security/AccessControlContext/FailureDebugOption.java
! test/javax/swing/JPopupMenu/6691503/bug6691503.java
! test/sun/security/pkcs11/Cipher/TestRSACipherWrap.java
! test/sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLSocketImpl/AsyncSSLSocketClose.java
! test/sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/CloseKeepAliveCached.java

Changeset: ea7620b05a58
Author:    herrick
Date:      2009-06-15 13:08 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ea7620b05a58

Merge

! make/common/shared/Defs-windows.gmk
! make/common/shared/Defs.gmk
! make/common/shared/Sanity.gmk

Changeset: 4f207797e185
Author:    herrick
Date:      2009-06-19 11:46 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4f207797e185

6852646: JDK 7 cannot build w/o ALT_HOTSPOT_KERNEL_PATH set.
Summary: This problem was discovered testing initial changeset for implementing 6uX Deployment Features into JDK7
Reviewed-by: dgu, billyh

! make/common/shared/Defs-windows.gmk
! make/common/shared/Sanity.gmk

Changeset: 23c7d780c1b3
Author:    herrick
Date:      2009-06-19 15:04 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/23c7d780c1b3

6853152: JDK 7 cannot build w/o ALT_HOTSPOT_KERNEL_PATH set. - still broken
Summary: This problem was discovered testing initial changeset for implementing 6uX Deployment Features into JDK7
Reviewed-by: dgu, billyh

! make/common/shared/Defs-windows.gmk
! make/java/redist/Makefile

Changeset: f509fe92a102
Author:    herrick
Date:      2009-06-22 09:16 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f509fe92a102

Merge


Changeset: 9362d0114c3a
Author:    herrick
Date:      2009-06-24 14:49 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9362d0114c3a

6633813: Add standard hotspot import path for Kernel VM
Summary: This problem was discovered testing initial changeset for implementing 6uX Deployment Features into JDK7
Reviewed-by: dgu, billyh

! make/common/shared/Defs-windows.gmk
! make/java/redist/Makefile

Changeset: dd0371861841
Author:    herrick
Date:      2009-06-29 12:06 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dd0371861841

Merge

! make/common/Release.gmk
! make/sun/Makefile
! src/share/classes/java/lang/System.java
- src/share/classes/sun/nio/cs/ext/DBCSDecoderMapping.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_ASCII_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_IBM_EBCDIC_Encoder.java
- src/share/classes/sun/nio/cs/ext/DBCS_ONLY_IBM_EBCDIC_Decoder.java
- src/share/classes/sun/nio/cs/ext/IBM1381.java
- src/share/classes/sun/nio/cs/ext/IBM1383.java
- src/share/classes/sun/nio/cs/ext/IBM930.java
- src/share/classes/sun/nio/cs/ext/IBM933.java
- src/share/classes/sun/nio/cs/ext/IBM935.java
- src/share/classes/sun/nio/cs/ext/IBM937.java
- src/share/classes/sun/nio/cs/ext/IBM939.java
- src/share/classes/sun/nio/cs/ext/IBM942.java
- src/share/classes/sun/nio/cs/ext/IBM943.java
- src/share/classes/sun/nio/cs/ext/IBM948.java
- src/share/classes/sun/nio/cs/ext/IBM949.java
- src/share/classes/sun/nio/cs/ext/IBM950.java
- src/share/classes/sun/nio/cs/ext/IBM970.java
- src/share/classes/sun/nio/cs/ext/SimpleEUCDecoder.java
- src/share/native/sun/font/bidi/cmemory.h
- src/share/native/sun/font/bidi/jbidi.c
- src/share/native/sun/font/bidi/jbidi.h
- src/share/native/sun/font/bidi/ubidi.c
- src/share/native/sun/font/bidi/ubidi.h
- src/share/native/sun/font/bidi/ubidiimp.h
- src/share/native/sun/font/bidi/ubidiln.c
- src/share/native/sun/font/bidi/uchardir.c
- src/share/native/sun/font/bidi/uchardir.h
- src/share/native/sun/font/bidi/utypes.h

Changeset: 4caa574b3993
Author:    herrick
Date:      2009-06-29 17:34 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4caa574b3993

6855953: JDK7 - merger error of deployment changes with b62 -in jdk/make/sun/Makefile
Summary: This problem was discovered testing initial changeset for implementing 6uX Deployment Features into JDK7
Reviewed-by: dgu, billyh

! make/sun/Makefile

Changeset: 9710ed723163
Author:    herrick
Date:      2009-07-01 10:18 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9710ed723163

Merge

! src/share/classes/java/awt/color/ICC_Profile.java

Changeset: c51ead46c547
Author:    herrick
Date:      2009-07-06 14:10 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c51ead46c547

Merge

! make/common/Release.gmk
- src/share/classes/java/nio/file/DirectoryStreamFilters.java
- src/share/classes/java/nio/file/FileAction.java
- src/share/classes/java/nio/file/spi/AbstractPath.java
- src/share/classes/sun/io/ByteToCharMS932DB.java
- src/share/classes/sun/io/CharToByteMS932DB.java
- src/share/classes/sun/nio/cs/ext/EUC_CN.java
- src/share/classes/sun/nio/cs/ext/EUC_KR.java
- src/share/classes/sun/nio/cs/ext/GBK.java
- src/share/classes/sun/nio/cs/ext/Johab.java
- src/share/classes/sun/nio/cs/ext/MS932.java
- src/share/classes/sun/nio/cs/ext/MS932DB.java
- src/share/classes/sun/nio/cs/ext/MS936.java
- src/share/classes/sun/nio/cs/ext/MS949.java
- src/share/classes/sun/nio/cs/ext/MS950.java
- src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java
- src/share/classes/sun/nio/fs/MimeType.java
- test/java/nio/file/DirectoryStream/Filters.java
- test/java/nio/file/Files/content_type.sh
- test/java/nio/file/Path/temporary_files.sh
- test/java/nio/file/attribute/Attributes/Basic.java

Changeset: a50217eb3ee1
Author:    jqzuo
Date:      2009-07-09 13:53 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a50217eb3ee1

Merge

- src/share/classes/sun/swing/AccessibleMethod.java

Changeset: 382a27aa78d3
Author:    xdono
Date:      2009-07-13 14:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/382a27aa78d3

Added tag jdk7-b64 for changeset a50217eb3ee1

! .hgtags



From john.coomes at sun.com  Wed Jul 15 16:14:00 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Wed, 15 Jul 2009 23:14:00 +0000
Subject: hg: jdk7/hotspot-gc/langtools: 25 new changesets
Message-ID: <20090715231441.7845EE255@hg.openjdk.java.net>

Changeset: a9c04a57a39f
Author:    mcimadamore
Date:      2009-06-16 10:45 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/a9c04a57a39f

6845686: basic and raw formatters do not display captured var id properly when javac runs in -XDoldDiags mode
Summary: Basic and raw formatters do not override Printer methods properly
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java
! test/tools/javac/Diagnostics/6799605/T6799605.java
! test/tools/javac/Diagnostics/6799605/T6799605.out

Changeset: 3d539f4123b8
Author:    mcimadamore
Date:      2009-06-16 10:45 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3d539f4123b8

6835430: javac does not generate signature attributes for classes extending parameterized inner classes
Summary: ClassWriter does not consider outer params of an inner class when emitting signature attributes
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
+ test/tools/javac/6835430/A.java
+ test/tools/javac/6835430/T6835430.java

Changeset: 3ac205ad1f05
Author:    mcimadamore
Date:      2009-06-16 10:46 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3ac205ad1f05

6835428: regression: return-type inference rejects valid code
Summary: Redundant subtyping test during type-inference ends up in rejecting legal code
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Infer.java
+ test/tools/javac/generics/inference/T6835428.java

Changeset: 22872b24d38c
Author:    mcimadamore
Date:      2009-06-16 10:46 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/22872b24d38c

6638712: Inference with wildcard types causes selection of inapplicable method
Summary: Added global sanity check in order to make sure that return type inference does not violate bounds constraints
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Type.java
! src/share/classes/com/sun/tools/javac/code/Types.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/Infer.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! test/tools/javac/generics/inference/6302954/T6476073.java
+ test/tools/javac/generics/inference/6638712/T6638712a.java
+ test/tools/javac/generics/inference/6638712/T6638712a.out
+ test/tools/javac/generics/inference/6638712/T6638712b.java
+ test/tools/javac/generics/inference/6638712/T6638712b.out
+ test/tools/javac/generics/inference/6638712/T6638712c.java
+ test/tools/javac/generics/inference/6638712/T6638712c.out
+ test/tools/javac/generics/inference/6638712/T6638712d.java
+ test/tools/javac/generics/inference/6638712/T6638712d.out
+ test/tools/javac/generics/inference/6638712/T6638712e.java
+ test/tools/javac/generics/inference/6638712/T6638712e.out

Changeset: ed989c347b3c
Author:    jjg
Date:      2009-06-19 11:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ed989c347b3c

6852856: javap changes to facilitate subclassing javap for variants
Reviewed-by: mcimadamore

! src/share/classes/com/sun/tools/classfile/AccessFlags.java
! src/share/classes/com/sun/tools/classfile/ConstantPool.java
! src/share/classes/com/sun/tools/javap/AttributeWriter.java
! src/share/classes/com/sun/tools/javap/ClassWriter.java
! src/share/classes/com/sun/tools/javap/ConstantWriter.java
! src/share/classes/com/sun/tools/javap/JavapTask.java
! src/share/classes/com/sun/tools/javap/SourceWriter.java

Changeset: fe077c71cd47
Author:    tbell
Date:      2009-06-23 22:09 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/fe077c71cd47

Merge


Changeset: 18e0269f25e3
Author:    mcimadamore
Date:      2009-06-24 10:50 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/18e0269f25e3

6822637: ResolveError hierarchy needs to be refactored
Summary: Break ResolveError class into a hierarchy representing different kinds of resolution errors
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/code/Kinds.java
! src/share/classes/com/sun/tools/javac/comp/Resolve.java
! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java

Changeset: 8ec37cf2b37e
Author:    mcimadamore
Date:      2009-06-24 10:50 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/8ec37cf2b37e

6852595: Accessing scope using JSR199 API on erroneous tree causes Illegal Argument Exception
Summary: Fixed problem with empty DiagnosticSource objects causing IAE in the JCDiagnostic constructor
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/util/AbstractLog.java
! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java
+ test/tools/javac/api/6852595/T6852595.java

Changeset: 1d9e61e0a075
Author:    mcimadamore
Date:      2009-06-24 10:51 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/1d9e61e0a075

6852649: The Rich formatter printer should be an explicit class to facilitate overriding
Summary: Improve reusabiliy of the rich formatter by removing anonymous inner classes/changing visibility of fields
Reviewed-by: jjg

! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java
! src/share/classes/com/sun/tools/javac/util/RichDiagnosticFormatter.java

Changeset: 812d5486a023
Author:    tbell
Date:      2009-06-24 17:34 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/812d5486a023

Merge


Changeset: e71fd3fcebf5
Author:    tbell
Date:      2009-06-26 10:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/e71fd3fcebf5

Merge


Changeset: ca063536e4a6
Author:    darcy
Date:      2009-06-26 12:22 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ca063536e4a6

6593082: MirroredTypeException constructor does not throw NPE when type is null
Reviewed-by: jjg

! src/share/classes/javax/lang/model/type/MirroredTypeException.java
+ test/tools/javac/processing/model/type/MirroredTypeEx/NpeTest.java

Changeset: 03944ee4fac4
Author:    jjg
Date:      2009-06-26 18:51 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/03944ee4fac4

6843077: JSR 308: Annotations on types
Reviewed-by: jjg, mcimadamore, darcy
Contributed-by: mernst at cs.washington.edu, mali at csail.mit.edu, mpapi at csail.mit.edu

! src/share/bin/launcher.sh-template
! src/share/classes/com/sun/source/tree/MethodTree.java
! src/share/classes/com/sun/source/tree/Tree.java
! src/share/classes/com/sun/source/tree/TreeVisitor.java
! src/share/classes/com/sun/source/tree/TypeParameterTree.java
! src/share/classes/com/sun/source/util/SimpleTreeVisitor.java
! src/share/classes/com/sun/source/util/TreePath.java
! src/share/classes/com/sun/source/util/TreeScanner.java
! src/share/classes/com/sun/source/util/Trees.java
! src/share/classes/com/sun/tools/classfile/Attribute.java
! src/share/classes/com/sun/tools/classfile/ClassWriter.java
! src/share/classes/com/sun/tools/javac/api/JavacTaskImpl.java
! src/share/classes/com/sun/tools/javac/api/JavacTrees.java
! src/share/classes/com/sun/tools/javac/code/Attribute.java
! src/share/classes/com/sun/tools/javac/code/Source.java
! src/share/classes/com/sun/tools/javac/code/Symbol.java
! src/share/classes/com/sun/tools/javac/comp/Attr.java
! src/share/classes/com/sun/tools/javac/comp/Check.java
! src/share/classes/com/sun/tools/javac/comp/Flow.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java
! src/share/classes/com/sun/tools/javac/comp/TransTypes.java
! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java
! src/share/classes/com/sun/tools/javac/resources/compiler.properties
! src/share/classes/com/sun/tools/javac/tree/JCTree.java
! src/share/classes/com/sun/tools/javac/tree/Pretty.java
! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java
! src/share/classes/com/sun/tools/javac/tree/TreeInfo.java
! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java
! src/share/classes/com/sun/tools/javac/tree/TreeScanner.java
! src/share/classes/com/sun/tools/javac/tree/TreeTranslator.java
! src/share/classes/com/sun/tools/javac/util/Names.java
! src/share/classes/com/sun/tools/javap/AnnotationWriter.java
! src/share/classes/com/sun/tools/javap/AttributeWriter.java
! test/tools/javac/6341866/T6341866.java
! test/tools/javac/processing/6348499/T6348499.java
! test/tools/javac/processing/6414633/T6414633.java
! test/tools/javac/processing/6430209/T6430209.java
! test/tools/javac/processing/T6439826.java

Changeset: 664edca41e34
Author:    jjg
Date:      2009-06-26 19:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/664edca41e34

6855544: add missing files
Reviewed-by: jjg, mcimadamore, darcy
Contributed-by: mernst at cs.washington.edu, mali at csail.mit.edu, mpapi at csail.mit.edu

+ src/share/classes/com/sun/source/tree/AnnotatedTypeTree.java
+ src/share/classes/com/sun/source/util/AbstractTypeProcessor.java
+ src/share/classes/com/sun/tools/classfile/ExtendedAnnotation.java
+ src/share/classes/com/sun/tools/classfile/RuntimeInvisibleTypeAnnotations_attribute.java
+ src/share/classes/com/sun/tools/classfile/RuntimeTypeAnnotations_attribute.java
+ src/share/classes/com/sun/tools/classfile/RuntimeVisibleTypeAnnotations_attribute.java
+ src/share/classes/com/sun/tools/javac/code/TargetType.java
+ src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java
+ test/tools/javac/api/TestTreePath.java
+ test/tools/javac/meth/InvokeMH_BAD68.java
+ test/tools/javac/meth/InvokeMH_BAD72.java
+ test/tools/javac/quid/QuotedIdent_BAD61.java
+ test/tools/javac/quid/QuotedIdent_BAD62.java
+ test/tools/javac/quid/QuotedIdent_BAD63.java
+ test/tools/javac/typeAnnotations/InnerClass.java
+ test/tools/javac/typeAnnotations/MultipleTargets.java
+ test/tools/javac/typeAnnotations/TypeParameterTarget.java
+ test/tools/javac/typeAnnotations/TypeUseTarget.java
+ test/tools/javac/typeAnnotations/attribution/Scopes.java
+ test/tools/javac/typeAnnotations/failures/AnnotationVersion.java
+ test/tools/javac/typeAnnotations/failures/AnnotationVersion.out
+ test/tools/javac/typeAnnotations/failures/IncompleteArray.java
+ test/tools/javac/typeAnnotations/failures/IncompleteArray.out
+ test/tools/javac/typeAnnotations/failures/IncompleteVararg.java
+ test/tools/javac/typeAnnotations/failures/IncompleteVararg.out
+ test/tools/javac/typeAnnotations/failures/IndexArray.java
+ test/tools/javac/typeAnnotations/failures/IndexArray.out
+ test/tools/javac/typeAnnotations/failures/LintCast.java
+ test/tools/javac/typeAnnotations/failures/LintCast.out
+ test/tools/javac/typeAnnotations/failures/OldArray.java
+ test/tools/javac/typeAnnotations/failures/OldArray.out
+ test/tools/javac/typeAnnotations/failures/Scopes.java
+ test/tools/javac/typeAnnotations/failures/Scopes.out
+ test/tools/javac/typeAnnotations/failures/StaticFields.java
+ test/tools/javac/typeAnnotations/failures/StaticFields.out
+ test/tools/javac/typeAnnotations/failures/StaticMethods.java
+ test/tools/javac/typeAnnotations/failures/StaticMethods.out
+ test/tools/javac/typeAnnotations/failures/VoidGenericMethod.java
+ test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/arrayclass/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/arrayclass/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/arrayclass/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/arrays/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/arrays/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/arrays/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/innertypeparams/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/innertypeparams/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/innertypeparams/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/newarray/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/newarray/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/newarray/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/newarray/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/newarray/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/parambounds/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/parambounds/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/parambounds/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/parambounds/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/receiver/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/receiver/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/receiver/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/receiver/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/receiver/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/rest/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/rest/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/rest/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/rest/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/rest/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/rest/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/typeArgs/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/typeArgs/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/typeArgs/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/typeArgs/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/typeparams/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/typeparams/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/typeparams/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/typeparams/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.java
+ test/tools/javac/typeAnnotations/failures/common/wildcards/DuplicateTypeAnnotation.out
+ test/tools/javac/typeAnnotations/failures/common/wildcards/InvalidLocation.java
+ test/tools/javac/typeAnnotations/failures/common/wildcards/InvalidLocation.out
+ test/tools/javac/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.java
+ test/tools/javac/typeAnnotations/failures/common/wildcards/MissingAnnotationValue.out
+ test/tools/javac/typeAnnotations/failures/target/Constructor.java
+ test/tools/javac/typeAnnotations/failures/target/Constructor.out
+ test/tools/javac/typeAnnotations/failures/target/IncompleteArray.java
+ test/tools/javac/typeAnnotations/failures/target/IncompleteArray.out
+ test/tools/javac/typeAnnotations/failures/target/NotTypeParameter.java
+ test/tools/javac/typeAnnotations/failures/target/NotTypeParameter.out
+ test/tools/javac/typeAnnotations/failures/target/NotTypeUse.java
+ test/tools/javac/typeAnnotations/failures/target/NotTypeUse.out
+ test/tools/javac/typeAnnotations/failures/target/VoidMethod.java
+ test/tools/javac/typeAnnotations/failures/target/VoidMethod.out
+ test/tools/javac/typeAnnotations/newlocations/BasicTest.java
+ test/tools/javac/typeAnnotations/newlocations/ClassExtends.java
+ test/tools/javac/typeAnnotations/newlocations/ClassLiterals.java
+ test/tools/javac/typeAnnotations/newlocations/ClassParameters.java
+ test/tools/javac/typeAnnotations/newlocations/ConstructorTypeArgs.java
+ test/tools/javac/typeAnnotations/newlocations/Expressions.java
+ test/tools/javac/typeAnnotations/newlocations/Fields.java
+ test/tools/javac/typeAnnotations/newlocations/LocalVariables.java
+ test/tools/javac/typeAnnotations/newlocations/MethodReturnType.java
+ test/tools/javac/typeAnnotations/newlocations/MethodTypeArgs.java
+ test/tools/javac/typeAnnotations/newlocations/MethodTypeParameters.java
+ test/tools/javac/typeAnnotations/newlocations/Parameters.java
+ test/tools/javac/typeAnnotations/newlocations/Receivers.java
+ test/tools/javac/typeAnnotations/newlocations/Throws.java
+ test/tools/javac/typeAnnotations/newlocations/TypeCasts.java
+ test/tools/javac/typeAnnotations/newlocations/TypeParameters.java
+ test/tools/javac/typeAnnotations/newlocations/Wildcards.java
+ test/tools/javap/typeAnnotations/ClassLiterals.java
+ test/tools/javap/typeAnnotations/JSR175Annotations.java
+ test/tools/javap/typeAnnotations/NewArray.java
+ test/tools/javap/typeAnnotations/Presence.java
+ test/tools/javap/typeAnnotations/PresenceInner.java
+ test/tools/javap/typeAnnotations/Visibility.java

Changeset: 7c154fdc3547
Author:    jjg
Date:      2009-06-26 19:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7c154fdc3547

6854796: update JSR308 impl with latest code from type-annotations repo
Reviewed-by: jjg, mcimadamore, darcy
Contributed-by: mernst at cs.washington.edu, mali at csail.mit.edu, mpapi at csail.mit.edu

! src/share/classes/com/sun/tools/javac/code/TargetType.java
! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java
! src/share/classes/com/sun/tools/javac/parser/JavacParser.java
! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/share/classes/com/sun/tools/javac/processing/JavacRoundEnvironment.java

Changeset: 464d58654324
Author:    jjg
Date:      2009-06-27 12:04 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/464d58654324

6855563: test broken after merge with latest parser
Reviewed-by: jjg
Contributed-by: mali at csail.mit.edu

! test/tools/javac/typeAnnotations/failures/OldArray.java
- test/tools/javac/typeAnnotations/failures/OldArray.out

Changeset: c391a167ac57
Author:    tbell
Date:      2009-06-28 00:01 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/c391a167ac57

Merge


Changeset: 7913e72a24b0
Author:    jjg
Date:      2009-06-29 17:45 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7913e72a24b0

6855993: fix comments in langtools launcher script
Reviewed-by: ohair

! src/share/bin/launcher.sh-template

Changeset: ec1acd3af057
Author:    tbell
Date:      2009-06-29 23:08 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ec1acd3af057

Merge


Changeset: 24374861f91e
Author:    tbell
Date:      2009-07-03 09:16 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/24374861f91e

Merge


Changeset: e4a1c76c1abb
Author:    peterz
Date:      2009-06-23 12:24 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/e4a1c76c1abb

6844273: jdk/make/docs/CORE_PKGS.gmk does not list Nimbus
Reviewed-by: prr

! src/share/classes/com/sun/tools/javac/resources/legacy.properties

Changeset: ddef2ef424d8
Author:    yan
Date:      2009-06-25 00:20 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ddef2ef424d8

Merge

- make/README
- src/share/classes/sun/tools/javap/AttrData.java
- src/share/classes/sun/tools/javap/CPX.java
- src/share/classes/sun/tools/javap/CPX2.java
- src/share/classes/sun/tools/javap/ClassData.java
- src/share/classes/sun/tools/javap/Constants.java
- src/share/classes/sun/tools/javap/FieldData.java
- src/share/classes/sun/tools/javap/InnerClassData.java
- src/share/classes/sun/tools/javap/JavapEnvironment.java
- src/share/classes/sun/tools/javap/JavapPrinter.java
- src/share/classes/sun/tools/javap/LineNumData.java
- src/share/classes/sun/tools/javap/LocVarData.java
- src/share/classes/sun/tools/javap/Main.java
- src/share/classes/sun/tools/javap/MethodData.java
- src/share/classes/sun/tools/javap/RuntimeConstants.java
- src/share/classes/sun/tools/javap/StackMapData.java
- src/share/classes/sun/tools/javap/StackMapTableData.java
- src/share/classes/sun/tools/javap/Tables.java
- src/share/classes/sun/tools/javap/TrapData.java
- src/share/classes/sun/tools/javap/TypeSignature.java
- test/tools/javac/code/ArrayClone.sh
- test/tools/javap/ListTest.java
- test/tools/javap/OptionTest.java

Changeset: 09dc14c713f0
Author:    yan
Date:      2009-07-01 00:24 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/09dc14c713f0

Merge


Changeset: d8f23a81d46f
Author:    yan
Date:      2009-07-07 23:13 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/d8f23a81d46f

Merge


Changeset: 7e0056ded28c
Author:    xdono
Date:      2009-07-13 14:48 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7e0056ded28c

Added tag jdk7-b64 for changeset d8f23a81d46f

! .hgtags



From john.coomes at sun.com  Fri Jul 17 01:39:47 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 17 Jul 2009 08:39:47 +0000
Subject: hg: jdk7/hotspot-gc: 5 new changesets
Message-ID: <20090717083947.6A7C3E56A@hg.openjdk.java.net>

Changeset: 8ca3d95b1ea3
Author:    xdono
Date:      2009-06-22 10:13 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/8ca3d95b1ea3

6853596: Update Build README-build.html with new info regarding update for Solaris 10u2 and BOOTDIR update
Reviewed-by: tbell, ohair

! README-builds.html

Changeset: 38c6ee1015aa
Author:    xdono
Date:      2009-06-29 22:13 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/38c6ee1015aa

Merge

! README-builds.html

Changeset: 9ed059501673
Author:    xdono
Date:      2009-07-08 10:34 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/9ed059501673

Merge


Changeset: e01380cd1de4
Author:    xdono
Date:      2009-07-14 14:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/e01380cd1de4

Merge


Changeset: 6bad5e3fe503
Author:    xdono
Date:      2009-07-16 10:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/6bad5e3fe503

Added tag jdk7-b65 for changeset e01380cd1de4

! .hgtags



From john.coomes at sun.com  Fri Jul 17 01:44:52 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 17 Jul 2009 08:44:52 +0000
Subject: hg: jdk7/hotspot-gc/corba: Added tag jdk7-b65 for changeset
	97fd9b42f5c2
Message-ID: <20090717084453.EB67AE571@hg.openjdk.java.net>

Changeset: a821e059a961
Author:    xdono
Date:      2009-07-16 10:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/a821e059a961

Added tag jdk7-b65 for changeset 97fd9b42f5c2

! .hgtags



From john.coomes at sun.com  Fri Jul 17 01:59:26 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 17 Jul 2009 08:59:26 +0000
Subject: hg: jdk7/hotspot-gc/jaxp: Added tag jdk7-b65 for changeset
	008c662e0ee9
Message-ID: <20090717085928.7A4A2E576@hg.openjdk.java.net>

Changeset: 22f9d5d5b5fe
Author:    xdono
Date:      2009-07-16 10:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/22f9d5d5b5fe

Added tag jdk7-b65 for changeset 008c662e0ee9

! .hgtags



From john.coomes at sun.com  Fri Jul 17 02:04:44 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 17 Jul 2009 09:04:44 +0000
Subject: hg: jdk7/hotspot-gc/jaxws: Added tag jdk7-b65 for changeset
	aa22a1be5866
Message-ID: <20090717090446.D9190E57B@hg.openjdk.java.net>

Changeset: fa8712c099ed
Author:    xdono
Date:      2009-07-16 10:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/fa8712c099ed

Added tag jdk7-b65 for changeset aa22a1be5866

! .hgtags



From john.coomes at sun.com  Fri Jul 17 02:09:51 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 17 Jul 2009 09:09:51 +0000
Subject: hg: jdk7/hotspot-gc/jdk: Added tag jdk7-b65 for changeset 382a27aa78d3
Message-ID: <20090717091033.3403FE580@hg.openjdk.java.net>

Changeset: 6ec0174d4f36
Author:    xdono
Date:      2009-07-16 10:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6ec0174d4f36

Added tag jdk7-b65 for changeset 382a27aa78d3

! .hgtags



From john.coomes at sun.com  Fri Jul 17 02:28:42 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 17 Jul 2009 09:28:42 +0000
Subject: hg: jdk7/hotspot-gc/langtools: Added tag jdk7-b65 for changeset
	7e0056ded28c
Message-ID: <20090717092846.603F0E585@hg.openjdk.java.net>

Changeset: 634f519d6f9a
Author:    xdono
Date:      2009-07-16 10:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/634f519d6f9a

Added tag jdk7-b65 for changeset 7e0056ded28c

! .hgtags



From y.s.ramakrishna at sun.com  Fri Jul 17 10:36:53 2009
From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com)
Date: Fri, 17 Jul 2009 17:36:53 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6 new changesets
Message-ID: <20090717173709.EFEA9E696@hg.openjdk.java.net>

Changeset: ba36394eb84b
Author:    xdono
Date:      2009-07-02 11:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ba36394eb84b

Added tag jdk7-b63 for changeset 32c83fb84370

! .hgtags

Changeset: 45c4b1fe45e4
Author:    trims
Date:      2009-07-10 19:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/45c4b1fe45e4

6859411: Bump the HS16 build number to 06
Summary: Update the HS16 build number to 06
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 218f6b67f9c5
Author:    trims
Date:      2009-07-11 03:18 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/218f6b67f9c5

Merge


Changeset: 92b5fbbe8477
Author:    xdono
Date:      2009-07-13 14:47 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/92b5fbbe8477

Added tag jdk7-b64 for changeset ba36394eb84b

! .hgtags

Changeset: ba313800759b
Author:    trims
Date:      2009-07-14 19:43 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ba313800759b

Merge


Changeset: f0a1cbbaf3c0
Author:    ysr
Date:      2009-07-16 12:38 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f0a1cbbaf3c0

Merge




From martinrb at google.com  Sat Jul 18 07:31:36 2009
From: martinrb at google.com (Martin Buchholz)
Date: Sat, 18 Jul 2009 07:31:36 -0700
Subject: Fwd: [concurrency-interest] Atomicity of clearing of WeakReferences
In-Reply-To: <4A5E001D.5060109@cytetech.com>
References: <NFBBKALFDCPFIDBNKAPCAEJGICAA.davidcholmes@aapt.net.au>
	<4A5D14B1.5040001@xemaps.com>
	<a74683f90907141646m1b555656ma133dbe112f1a4b7@mail.gmail.com>
	<aa067ea10907141706u1d4fdfd4j1139558132117dd6@mail.gmail.com>
	<001301ca0513$93b683d0$bb238b70$@hu>
	<a74683f90907142324v4faf3ecdpdb84a7ded04eb576@mail.gmail.com>
	<002101ca0516$4c090780$e41b1680$@hu>
	<a74683f90907142338w5de6c829u4b01e6721c483cdc@mail.gmail.com>
	<003501ca0518$43efbf60$cbcf3e20$@hu> <4A5E001D.5060109@cytetech.com>
Message-ID: <1ccfd1c10907180731j5fcb9ce0o65596daaf0a725d9@mail.gmail.com>

I'm forwarding this message from concurrency-interest.
Lots of stuff on that mailing list for those interested in
reclamation of weak references.

Martin

---------- Forwarded message ----------
From: Gregg Wonderly <gregg at cytetech.com>
Date: 2009/7/15
Subject: Re: [concurrency-interest] Atomicity of clearing of WeakReferences
To: Karnok D?vid <karnok at sztaki.hu>
Cc: concurrency-interest at cs.oswego.edu


If you need to cleanup after something is unreferenced,
PhantomReference may be a good choice. ?I used it to construct my
ReferenceTracker class ( see
<http://cs.oswego.edu/pipermail/concurrency-interest/2008-December/005724.html>)

The one warning I will give, is that after doing this, I found that I
just could not use it in all the places I wanted, because of the Sun
JVM "bug" that nominates objects for finalization, before ALL
references are out of scope.

This causes the objects to be posted to the ReferenceQueue before they
are actually "dead". ?This means that any state you change, which is
referenced by that object, in finalization, can be seen by the object
before all references to the object have been used and gone out of
scope. ?Hans went into a lot of detail about this issue in many
contexts it seems (see
<http://gceclub.sun.com.cn/java_one_online/2005/TS-3281/ts-3281.pdf>)as
follow up to the long trail of posts comming from Doug Lea's post at

<http://cs.oswego.edu/pipermail/concurrency-interest/2009-January/005743.html>

which is the fences API discussion. ?Without Fences, or some other
mechanics in the JIT to automatically manage this issue, it's not much
of a real solution because you have to always think about scoping to
make sure that refences last longer than the JIT currently documents
them to exist as visible by the GC. ?And PhantomReference would really
help developers to not have to worry so much about scoping...

This is a tricky issue I discovered and I'd say that the way it works
now is wrong, if not an out right bug. ?Finalization should not be
invoked (directly or indirectly through PhantomReference queues etc)
until there are no more references to the value in registers, on the
stack, or in scoped variables etc.

This misbehavior really makes automated reference tracking for limited
resources nearly impossible when they are used by short lived bits of
code that are prime for optimization and registerization that appears
to hide references from the GC.

Gregg Wonderly


From John.Rose at Sun.COM  Wed Jul 22 01:53:36 2009
From: John.Rose at Sun.COM (John Rose)
Date: Wed, 22 Jul 2009 01:53:36 -0700
Subject: for review (M): 6863023: need non-perm oops in code cache for JSR 292
Message-ID: <01A90166-7F50-4218-B38A-345C7CA7ABF7@sun.com>

In order to inline method handles at invokedynamic instructions, it is  
necessary to manipulate MethodHandle and CallSite constants from  
generated code.  Since these objects are created by ordinary user code  
and subject to usual GC, they are not preallocated in the perm gen.

Currently compiled code requires that any oop embedded as an  
instruction constant or any other nmethod part must be  
OopDesc::is_perm.  For example, internal method objects and classes  
and interned strings are permanent so that they can be manipulated  
from compiled code.

This restriction is a bug for JSR 292.  Luckily, there is a simple fix.

http://cr.openjdk.java.net/~jrose/6862576/webrev.00/



From andrey.petrusenko at sun.com  Wed Jul 22 12:02:18 2009
From: andrey.petrusenko at sun.com (andrey.petrusenko at sun.com)
Date: Wed, 22 Jul 2009 19:02:18 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6862661: G1: _gc_alloc_region_counts is
	not updated properly after 6604422
Message-ID: <20090722190225.252EAEC22@hg.openjdk.java.net>

Changeset: 45d97a99715b
Author:    apetrusenko
Date:      2009-07-22 02:46 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/45d97a99715b

6862661: G1: _gc_alloc_region_counts is not updated properly after 6604422
Summary: Implementation of RFE 6604422 (G1: re-use half-promoted regions) introduced incorrect _gc_alloc_region_counts updates which effectively disabled survivor spaces.
Reviewed-by: johnc, jmasa, tonyp

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp



From Vladimir.Kozlov at Sun.COM  Wed Jul 22 12:35:28 2009
From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov)
Date: Wed, 22 Jul 2009 12:35:28 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
Message-ID: <4A676A00.7070606@sun.com>


http://cr.openjdk.java.net/~kvn/6826736/webrev.01

Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops

Problem:
Compiled code may produce decoded oop = narrow_oop_base
when a narrow oop implicit null check is used.
The narrow_oop_base could be NULL or be the address
of the page below heap depending on the used mode of
compressed oops. Such decoded oop could live across
a safepoint and as result referenced in oopMap and debug info.
The implicit NULL exception code checks for such oop value
but deoptimization code and GC does not. And this cause
the problem.

Solution:
Fix deoptimization code and GC to check for such oops values.
During deoptimization convert them to NULL.
And ignore them for GC (like NULL values are ignored).

Added the regression test which shows the problem.

Reviewed by:

Fix verified (y/n): y, regression test

Other testing:
JPRT, CTW with/without UseCompressedOops and +/- ScavengeALot



From Paul.Hohensee at Sun.COM  Wed Jul 22 12:51:14 2009
From: Paul.Hohensee at Sun.COM (Paul Hohensee)
Date: Wed, 22 Jul 2009 15:51:14 -0400
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <4A676A00.7070606@sun.com>
References: <4A676A00.7070606@sun.com>
Message-ID: <4A676DB2.9080700@sun.com>

You've got 4 uses of this expression

Universe::narrow_oop_base() == (address)(void*)(*foo)

You might write a new method in Universe to factor it out, vis

bool is_narrow_oop_base(void* addr) {
  return narrow_oop_base() == (address)addr);
}

Paul

Vladimir Kozlov wrote:
>
> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
>
> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
>
> Problem:
> Compiled code may produce decoded oop = narrow_oop_base
> when a narrow oop implicit null check is used.
> The narrow_oop_base could be NULL or be the address
> of the page below heap depending on the used mode of
> compressed oops. Such decoded oop could live across
> a safepoint and as result referenced in oopMap and debug info.
> The implicit NULL exception code checks for such oop value
> but deoptimization code and GC does not. And this cause
> the problem.
>
> Solution:
> Fix deoptimization code and GC to check for such oops values.
> During deoptimization convert them to NULL.
> And ignore them for GC (like NULL values are ignored).
>
> Added the regression test which shows the problem.
>
> Reviewed by:
>
> Fix verified (y/n): y, regression test
>
> Other testing:
> JPRT, CTW with/without UseCompressedOops and +/- ScavengeALot
>


From Vladimir.Kozlov at Sun.COM  Wed Jul 22 13:33:14 2009
From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov)
Date: Wed, 22 Jul 2009 13:33:14 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <4A676DB2.9080700@sun.com>
References: <4A676A00.7070606@sun.com> <4A676DB2.9080700@sun.com>
Message-ID: <4A67778A.40107@sun.com>

Thanks, Paul

I will do that.

Thanks,
Vladimir


Paul Hohensee wrote:
> You've got 4 uses of this expression
> 
> Universe::narrow_oop_base() == (address)(void*)(*foo)
> 
> You might write a new method in Universe to factor it out, vis
> 
> bool is_narrow_oop_base(void* addr) {
>  return narrow_oop_base() == (address)addr);
> }
> 
> Paul
> 
> Vladimir Kozlov wrote:
>>
>> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
>>
>> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
>>
>> Problem:
>> Compiled code may produce decoded oop = narrow_oop_base
>> when a narrow oop implicit null check is used.
>> The narrow_oop_base could be NULL or be the address
>> of the page below heap depending on the used mode of
>> compressed oops. Such decoded oop could live across
>> a safepoint and as result referenced in oopMap and debug info.
>> The implicit NULL exception code checks for such oop value
>> but deoptimization code and GC does not. And this cause
>> the problem.
>>
>> Solution:
>> Fix deoptimization code and GC to check for such oops values.
>> During deoptimization convert them to NULL.
>> And ignore them for GC (like NULL values are ignored).
>>
>> Added the regression test which shows the problem.
>>
>> Reviewed by:
>>
>> Fix verified (y/n): y, regression test
>>
>> Other testing:
>> JPRT, CTW with/without UseCompressedOops and +/- ScavengeALot
>>


From John.Coomes at sun.com  Wed Jul 22 13:44:50 2009
From: John.Coomes at sun.com (John Coomes)
Date: Wed, 22 Jul 2009 13:44:50 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <4A676A00.7070606@sun.com>
References: <4A676A00.7070606@sun.com>
Message-ID: <19047.31298.280175.604186@sun.com>

Vladimir Kozlov (Vladimir.Kozlov at Sun.COM) wrote:
> 
> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
> 
> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
> 
> Problem:
> Compiled code may produce decoded oop = narrow_oop_base
> when a narrow oop implicit null check is used.
> ...
> Solution:
> Fix deoptimization code and GC to check for such oops values.
> During deoptimization convert them to NULL.
> And ignore them for GC (like NULL values are ignored).

Looks reasonable to me, but I don't know this code.  Spotted a couple
of typos:

412              // is interesting in NULL.

Change to interesting to interested.



432           assert((*loc) == (oop)NULL || Universe::narrow_oop_base() != (address)(void*)(*loc),
433                  "found non valid value pointer");

Change "non valid" to invalid.

FWIW, I also like Paul's suggestion of is_narrow_oop_base(void*).

-John



From Vladimir.Kozlov at Sun.COM  Wed Jul 22 13:42:39 2009
From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov)
Date: Wed, 22 Jul 2009 13:42:39 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <19047.31298.280175.604186@sun.com>
References: <4A676A00.7070606@sun.com> <19047.31298.280175.604186@sun.com>
Message-ID: <4A6779BF.7090009@sun.com>

Thank you, John

I will fix comments.

Vladimir

John Coomes wrote:
> Vladimir Kozlov (Vladimir.Kozlov at Sun.COM) wrote:
>> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
>>
>> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
>>
>> Problem:
>> Compiled code may produce decoded oop = narrow_oop_base
>> when a narrow oop implicit null check is used.
>> ...
>> Solution:
>> Fix deoptimization code and GC to check for such oops values.
>> During deoptimization convert them to NULL.
>> And ignore them for GC (like NULL values are ignored).
> 
> Looks reasonable to me, but I don't know this code.  Spotted a couple
> of typos:
> 
> 412              // is interesting in NULL.
> 
> Change to interesting to interested.
> 
> 
> 
> 432           assert((*loc) == (oop)NULL || Universe::narrow_oop_base() != (address)(void*)(*loc),
> 433                  "found non valid value pointer");
> 
> Change "non valid" to invalid.
> 
> FWIW, I also like Paul's suggestion of is_narrow_oop_base(void*).
> 
> -John
> 


From Y.S.Ramakrishna at Sun.COM  Wed Jul 22 14:02:41 2009
From: Y.S.Ramakrishna at Sun.COM (Y.S.Ramakrishna at Sun.COM)
Date: Wed, 22 Jul 2009 14:02:41 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <4A676DB2.9080700@sun.com>
References: <4A676A00.7070606@sun.com> <4A676DB2.9080700@sun.com>
Message-ID: <4A677E71.2090805@Sun.COM>

Hi Vladimir -- i am fine with the fix. I worry just a little bit
about the decision to filter/suppress these "null-equivalent" oop locations
by the oop-map code for some future use case where we want to
apply a closure to all oop-holding locations irrespective of
whether the value is null; i do not however have a ready use case
in mind at the moment. Would it be beneficial, for the future and/or the
unwary, to add appropriate documentation about this filtering
in the header file where the all_do() and oops_do() methods
are declared?

Rest looks good; thanks!
-- ramki

On 07/22/09 12:51, Paul Hohensee wrote:
> You've got 4 uses of this expression
> 
> Universe::narrow_oop_base() == (address)(void*)(*foo)
> 
> You might write a new method in Universe to factor it out, vis
> 
> bool is_narrow_oop_base(void* addr) {
>  return narrow_oop_base() == (address)addr);
> }
> 
> Paul
> 
> Vladimir Kozlov wrote:
>>
>> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
>>
>> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
>>
>> Problem:
>> Compiled code may produce decoded oop = narrow_oop_base
>> when a narrow oop implicit null check is used.
>> The narrow_oop_base could be NULL or be the address
>> of the page below heap depending on the used mode of
>> compressed oops. Such decoded oop could live across
>> a safepoint and as result referenced in oopMap and debug info.
>> The implicit NULL exception code checks for such oop value
>> but deoptimization code and GC does not. And this cause
>> the problem.
>>
>> Solution:
>> Fix deoptimization code and GC to check for such oops values.
>> During deoptimization convert them to NULL.
>> And ignore them for GC (like NULL values are ignored).
>>
>> Added the regression test which shows the problem.
>>
>> Reviewed by:
>>
>> Fix verified (y/n): y, regression test
>>
>> Other testing:
>> JPRT, CTW with/without UseCompressedOops and +/- ScavengeALot
>>



From Thomas.Rodriguez at Sun.COM  Wed Jul 22 14:06:37 2009
From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez)
Date: Wed, 22 Jul 2009 14:06:37 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <4A676A00.7070606@sun.com>
References: <4A676A00.7070606@sun.com>
Message-ID: <11960083-634A-4BC6-880C-FF153247A328@sun.com>

Looks good.

tom

On Jul 22, 2009, at 12:35 PM, Vladimir Kozlov wrote:

>
> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
>
> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
>
> Problem:
> Compiled code may produce decoded oop = narrow_oop_base
> when a narrow oop implicit null check is used.
> The narrow_oop_base could be NULL or be the address
> of the page below heap depending on the used mode of
> compressed oops. Such decoded oop could live across
> a safepoint and as result referenced in oopMap and debug info.
> The implicit NULL exception code checks for such oop value
> but deoptimization code and GC does not. And this cause
> the problem.
>
> Solution:
> Fix deoptimization code and GC to check for such oops values.
> During deoptimization convert them to NULL.
> And ignore them for GC (like NULL values are ignored).
>
> Added the regression test which shows the problem.
>
> Reviewed by:
>
> Fix verified (y/n): y, regression test
>
> Other testing:
> JPRT, CTW with/without UseCompressedOops and +/- ScavengeALot
>



From Y.S.Ramakrishna at Sun.COM  Wed Jul 22 14:12:55 2009
From: Y.S.Ramakrishna at Sun.COM (Y.S.Ramakrishna at Sun.COM)
Date: Wed, 22 Jul 2009 14:12:55 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <4A677E71.2090805@Sun.COM>
References: <4A676A00.7070606@sun.com> <4A676DB2.9080700@sun.com>
	<4A677E71.2090805@Sun.COM>
Message-ID: <4A6780D7.5090901@Sun.COM>

Never mind. I realized that the old code already
filters null-holding locations, so my fears about new
behaviours this introduces are ill-founded.

Sorry for the noise.
-- ramki

On 07/22/09 14:02, Y.S.Ramakrishna at Sun.COM wrote:
> Hi Vladimir -- i am fine with the fix. I worry just a little bit
> about the decision to filter/suppress these "null-equivalent" oop locations
> by the oop-map code for some future use case where we want to
> apply a closure to all oop-holding locations irrespective of
> whether the value is null; i do not however have a ready use case
> in mind at the moment. Would it be beneficial, for the future and/or the
> unwary, to add appropriate documentation about this filtering
> in the header file where the all_do() and oops_do() methods
> are declared?
> 
> Rest looks good; thanks!
> -- ramki
> 
> On 07/22/09 12:51, Paul Hohensee wrote:
>> You've got 4 uses of this expression
>>
>> Universe::narrow_oop_base() == (address)(void*)(*foo)
>>
>> You might write a new method in Universe to factor it out, vis
>>
>> bool is_narrow_oop_base(void* addr) {
>>  return narrow_oop_base() == (address)addr);
>> }
>>
>> Paul
>>
>> Vladimir Kozlov wrote:
>>>
>>> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
>>>
>>> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
>>>
>>> Problem:
>>> Compiled code may produce decoded oop = narrow_oop_base
>>> when a narrow oop implicit null check is used.
>>> The narrow_oop_base could be NULL or be the address
>>> of the page below heap depending on the used mode of
>>> compressed oops. Such decoded oop could live across
>>> a safepoint and as result referenced in oopMap and debug info.
>>> The implicit NULL exception code checks for such oop value
>>> but deoptimization code and GC does not. And this cause
>>> the problem.
>>>
>>> Solution:
>>> Fix deoptimization code and GC to check for such oops values.
>>> During deoptimization convert them to NULL.
>>> And ignore them for GC (like NULL values are ignored).
>>>
>>> Added the regression test which shows the problem.
>>>
>>> Reviewed by:
>>>
>>> Fix verified (y/n): y, regression test
>>>
>>> Other testing:
>>> JPRT, CTW with/without UseCompressedOops and +/- ScavengeALot
>>>
> 
> 



From Vladimir.Kozlov at Sun.COM  Wed Jul 22 14:16:36 2009
From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov)
Date: Wed, 22 Jul 2009 14:16:36 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <4A677E71.2090805@Sun.COM>
References: <4A676A00.7070606@sun.com> <4A676DB2.9080700@sun.com>
	<4A677E71.2090805@Sun.COM>
Message-ID: <4A6781B4.2080209@sun.com>

Thanks, Ramki

There is oops verification code in OopMapSet::all_do()
before the call closure->do_oop() which the bug fail.
This is why I used filter before oops verification.

I will add a comment into oopMap.hpp.

Thanks,
Vladimir

Y.S.Ramakrishna at Sun.COM wrote:
> Hi Vladimir -- i am fine with the fix. I worry just a little bit
> about the decision to filter/suppress these "null-equivalent" oop locations
> by the oop-map code for some future use case where we want to
> apply a closure to all oop-holding locations irrespective of
> whether the value is null; i do not however have a ready use case
> in mind at the moment. Would it be beneficial, for the future and/or the
> unwary, to add appropriate documentation about this filtering
> in the header file where the all_do() and oops_do() methods
> are declared?
> 
> Rest looks good; thanks!
> -- ramki
> 
> On 07/22/09 12:51, Paul Hohensee wrote:
>> You've got 4 uses of this expression
>>
>> Universe::narrow_oop_base() == (address)(void*)(*foo)
>>
>> You might write a new method in Universe to factor it out, vis
>>
>> bool is_narrow_oop_base(void* addr) {
>>  return narrow_oop_base() == (address)addr);
>> }
>>
>> Paul
>>
>> Vladimir Kozlov wrote:
>>>
>>> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
>>>
>>> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
>>>
>>> Problem:
>>> Compiled code may produce decoded oop = narrow_oop_base
>>> when a narrow oop implicit null check is used.
>>> The narrow_oop_base could be NULL or be the address
>>> of the page below heap depending on the used mode of
>>> compressed oops. Such decoded oop could live across
>>> a safepoint and as result referenced in oopMap and debug info.
>>> The implicit NULL exception code checks for such oop value
>>> but deoptimization code and GC does not. And this cause
>>> the problem.
>>>
>>> Solution:
>>> Fix deoptimization code and GC to check for such oops values.
>>> During deoptimization convert them to NULL.
>>> And ignore them for GC (like NULL values are ignored).
>>>
>>> Added the regression test which shows the problem.
>>>
>>> Reviewed by:
>>>
>>> Fix verified (y/n): y, regression test
>>>
>>> Other testing:
>>> JPRT, CTW with/without UseCompressedOops and +/- ScavengeALot
>>>
> 


From Thomas.Rodriguez at Sun.COM  Wed Jul 22 14:24:15 2009
From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez)
Date: Wed, 22 Jul 2009 14:24:15 -0700
Subject: Request for reviews (S): 6826736: CMS: core dump with
	-XX:+UseCompressedOops
In-Reply-To: <4A677E71.2090805@Sun.COM>
References: <4A676A00.7070606@sun.com> <4A676DB2.9080700@sun.com>
	<4A677E71.2090805@Sun.COM>
Message-ID: <33CBCCEF-ED4B-4EA0-AD3B-5621E156F392@sun.com>

If we do that then I think we should suppress NULL uniformly instead  
of only under certain conditions.

tom

On Jul 22, 2009, at 2:02 PM, Y.S.Ramakrishna at Sun.COM wrote:

> Hi Vladimir -- i am fine with the fix. I worry just a little bit
> about the decision to filter/suppress these "null-equivalent" oop  
> locations
> by the oop-map code for some future use case where we want to
> apply a closure to all oop-holding locations irrespective of
> whether the value is null; i do not however have a ready use case
> in mind at the moment. Would it be beneficial, for the future and/or  
> the
> unwary, to add appropriate documentation about this filtering
> in the header file where the all_do() and oops_do() methods
> are declared?
>
> Rest looks good; thanks!
> -- ramki
>
> On 07/22/09 12:51, Paul Hohensee wrote:
>> You've got 4 uses of this expression
>> Universe::narrow_oop_base() == (address)(void*)(*foo)
>> You might write a new method in Universe to factor it out, vis
>> bool is_narrow_oop_base(void* addr) {
>> return narrow_oop_base() == (address)addr);
>> }
>> Paul
>> Vladimir Kozlov wrote:
>>>
>>> http://cr.openjdk.java.net/~kvn/6826736/webrev.01
>>>
>>> Fixed 6826736: CMS: core dump with -XX:+UseCompressedOops
>>>
>>> Problem:
>>> Compiled code may produce decoded oop = narrow_oop_base
>>> when a narrow oop implicit null check is used.
>>> The narrow_oop_base could be NULL or be the address
>>> of the page below heap depending on the used mode of
>>> compressed oops. Such decoded oop could live across
>>> a safepoint and as result referenced in oopMap and debug info.
>>> The implicit NULL exception code checks for such oop value
>>> but deoptimization code and GC does not. And this cause
>>> the problem.
>>>
>>> Solution:
>>> Fix deoptimization code and GC to check for such oops values.
>>> During deoptimization convert them to NULL.
>>> And ignore them for GC (like NULL values are ignored).
>>>
>>> Added the regression test which shows the problem.
>>>
>>> Reviewed by:
>>>
>>> Fix verified (y/n): y, regression test
>>>
>>> Other testing:
>>> JPRT, CTW with/without UseCompressedOops and +/- ScavengeALot
>>>
>



From y.s.ramakrishna at sun.com  Thu Jul 23 01:18:13 2009
From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com)
Date: Thu, 23 Jul 2009 08:18:13 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6863216: Clean up debugging debris
	inadvertently pushed with 6700789
Message-ID: <20090723081822.577C5EC82@hg.openjdk.java.net>

Changeset: 36b5611220a7
Author:    ysr
Date:      2009-07-22 18:25 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/36b5611220a7

6863216: Clean up debugging debris inadvertently pushed with 6700789
Summary: Anti-delta for debugging debris that was inadvertently pushed.
Reviewed-by: kvn, tonyp

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/opto/cfgnode.cpp



From john.coomes at sun.com  Sat Jul 25 05:23:17 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Sat, 25 Jul 2009 12:23:17 +0000
Subject: hg: jdk7/hotspot-gc: Added tag jdk7-b66 for changeset 6bad5e3fe503
Message-ID: <20090725122317.B11BCE702@hg.openjdk.java.net>

Changeset: 5dc862ec024e
Author:    xdono
Date:      2009-07-24 13:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/5dc862ec024e

Added tag jdk7-b66 for changeset 6bad5e3fe503

! .hgtags



From john.coomes at sun.com  Sat Jul 25 05:28:30 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Sat, 25 Jul 2009 12:28:30 +0000
Subject: hg: jdk7/hotspot-gc/corba: Added tag jdk7-b66 for changeset
	a821e059a961
Message-ID: <20090725122832.8E93BE707@hg.openjdk.java.net>

Changeset: d5e36cb83d8c
Author:    xdono
Date:      2009-07-24 13:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/d5e36cb83d8c

Added tag jdk7-b66 for changeset a821e059a961

! .hgtags



From john.coomes at sun.com  Sat Jul 25 05:40:16 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Sat, 25 Jul 2009 12:40:16 +0000
Subject: hg: jdk7/hotspot-gc/jaxp: Added tag jdk7-b66 for changeset
	22f9d5d5b5fe
Message-ID: <20090725124019.3CAA4E70C@hg.openjdk.java.net>

Changeset: f8f9c0186d87
Author:    xdono
Date:      2009-07-24 13:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/f8f9c0186d87

Added tag jdk7-b66 for changeset 22f9d5d5b5fe

! .hgtags



From john.coomes at sun.com  Sat Jul 25 05:45:30 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Sat, 25 Jul 2009 12:45:30 +0000
Subject: hg: jdk7/hotspot-gc/jaxws: Added tag jdk7-b66 for changeset
	fa8712c099ed
Message-ID: <20090725124533.02A88E711@hg.openjdk.java.net>

Changeset: 58f51e3cc0fa
Author:    xdono
Date:      2009-07-24 13:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/58f51e3cc0fa

Added tag jdk7-b66 for changeset fa8712c099ed

! .hgtags



From john.coomes at sun.com  Sat Jul 25 05:52:49 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Sat, 25 Jul 2009 12:52:49 +0000
Subject: hg: jdk7/hotspot-gc/jdk: 36 new changesets
Message-ID: <20090725130425.6649EE716@hg.openjdk.java.net>

Changeset: b22f9e823be7
Author:    alanb
Date:      2009-06-30 11:11 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b22f9e823be7

6843003: Windows Server 2008 R2 system recognition
Reviewed-by: ohair, sherman

! src/windows/native/java/lang/java_props_md.c

Changeset: d57c10cf07c5
Author:    alanb
Date:      2009-06-30 11:13 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d57c10cf07c5

Merge


Changeset: c2baa2f0415e
Author:    xuelei
Date:      2009-07-03 11:13 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c2baa2f0415e

6853793: OutOfMemoryError in sun.security.provider.certpath.OCSPChecker.check
Summary: allocate memory dynamically, keep reading until EOF.
Reviewed-by: weijun

! src/share/classes/sun/security/provider/certpath/OCSPChecker.java
! src/share/classes/sun/security/timestamp/HttpTimestamper.java

Changeset: 803db6c94a3b
Author:    martin
Date:      2009-07-03 07:24 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/803db6c94a3b

6857287: (file) Clarifications for symbolic link related javadoc
Summary: Fix up jsr203 file javadoc related to symbolic links
Reviewed-by: alanb

! src/share/classes/java/nio/file/LinkPermission.java
! src/share/classes/java/nio/file/NotLinkException.java
! src/share/classes/java/nio/file/Path.java
! src/share/classes/java/nio/file/SecureDirectoryStream.java
! src/share/classes/java/nio/file/attribute/Attributes.java
! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java

Changeset: 75459b125461
Author:    tbell
Date:      2009-07-03 16:26 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/75459b125461

Merge


Changeset: fa488e4ff685
Author:    jccollet
Date:      2009-07-06 15:13 +0200
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fa488e4ff685

6856856: NPE in HTTP protocol handler logging
Summary: Fixed the NPE and Moved the java.util.logging dependency to a single class and used reflection to make it a soft one.
Reviewed-by: chegar

! src/share/classes/sun/net/www/http/HttpCapture.java
! src/share/classes/sun/net/www/http/HttpClient.java
! src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java
! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java

Changeset: 0cabe1192c8b
Author:    martin
Date:      2009-07-06 11:30 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0cabe1192c8b

6854795: Miscellaneous improvements to "jar"
Summary: cleanup of jar/Main.java (Initial patch by tobyr at google.com, additional review by jeremymanson at google.com, ulf.zibis at gmx.de)
Reviewed-by: sherman, alanb

! src/share/classes/sun/tools/jar/Main.java
! test/tools/jar/index/MetaInf.java

Changeset: 0a294c066e7a
Author:    darcy
Date:      2009-07-07 16:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0a294c066e7a

6857803: Missing links to exceptions in javadoc for Class.getGeneric{Superclass, Interfaces}
Reviewed-by: chegar

! src/share/classes/java/lang/Class.java

Changeset: 1175f872a968
Author:    weijun
Date:      2009-07-08 12:07 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1175f872a968

6857802: GSS getRemainingInitLifetime method returns milliseconds not seconds
Reviewed-by: xuelei

! src/share/classes/sun/security/jgss/krb5/Krb5InitCredential.java
+ test/sun/security/krb5/auto/LifeTimeInSeconds.java

Changeset: 1df67a3ecce8
Author:    weijun
Date:      2009-07-08 12:07 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1df67a3ecce8

6857795: krb5.conf ignored if system properties on realm and kdc are provided
Reviewed-by: xuelei

! src/share/classes/sun/security/krb5/Config.java
+ test/sun/security/krb5/ConfPlusProp.java
+ test/sun/security/krb5/confplusprop.conf
+ test/sun/security/krb5/confplusprop2.conf

Changeset: d133d4052378
Author:    ohair
Date:      2009-07-08 09:11 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d133d4052378

6858127: Missing -DNDEBUG on Linux and Windows native code compiles
Reviewed-by: tbell, dcubed

! make/common/Defs-linux.gmk
! make/common/Defs-windows.gmk

Changeset: d3a08f8c3c86
Author:    ohair
Date:      2009-07-08 09:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d3a08f8c3c86

6855551: java -Xrunhprof crashes when running with classes compiled with targed=7
Reviewed-by: tbell, dcubed

! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c
! test/demo/jvmti/hprof/HelloWorld.java
! test/demo/jvmti/hprof/StackMapTableTest.java

Changeset: ae60bb671e54
Author:    darcy
Date:      2009-07-09 12:31 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ae60bb671e54

6628737: Specification of wrapper class valueOf static factories should require caching
Reviewed-by: mr

! src/share/classes/java/lang/Byte.java
! src/share/classes/java/lang/Character.java
! src/share/classes/java/lang/Integer.java
! src/share/classes/java/lang/Long.java
! src/share/classes/java/lang/Short.java

Changeset: 6f26e2e5f4f3
Author:    xuelei
Date:      2009-07-10 17:27 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6f26e2e5f4f3

6852744: PIT b61: PKI test suite fails because self signed certificates are beingrejected
Summary: make the builder aware of SKID/AKID, break the internal circular dependences
Reviewed-by: mullan

! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java
! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java
+ test/java/security/cert/CertPathBuilder/selfIssued/DisableRevocation.java
+ test/java/security/cert/CertPathBuilder/selfIssued/KeyUsageMatters.java
+ test/java/security/cert/CertPathBuilder/selfIssued/README
+ test/java/security/cert/CertPathBuilder/selfIssued/StatusLoopDependency.java
+ test/java/security/cert/CertPathBuilder/selfIssued/generate.sh
+ test/java/security/cert/CertPathBuilder/selfIssued/openssl.cnf

Changeset: 880896883a47
Author:    andrew
Date:      2009-07-11 16:43 +0100
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/880896883a47

6562614: Compiler warnings for gettimeofday in Inet4/Inet6AddressImpl.c
Summary: Add missing header to remove compiler warnings.
Reviewed-by: martin
Contributed-by: Matthew Flaschen <matthew.flaschen at gatech.edu>

! src/solaris/native/java/net/Inet4AddressImpl.c
! src/solaris/native/java/net/Inet6AddressImpl.c

Changeset: d0ce095004b2
Author:    xuelei
Date:      2009-07-13 23:01 +0800
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d0ce095004b2

6453837: PartialCompositeContext.allEmpty is buggy
Reviewed-by: weijun

! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java

Changeset: beb5e5cad3ae
Author:    valeriep
Date:      2009-07-13 15:14 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/beb5e5cad3ae

6832540: IllegalArgumentException in ClassLoader.definePackage when classes are loaded in parallel
Summary: Modified to handle race condition for parallel-capable classloaders by re-trying/re-verifying package
Reviewed-by: alanb

! src/share/classes/java/net/URLClassLoader.java

Changeset: 53b27ac4f706
Author:    tbell
Date:      2009-07-13 23:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/53b27ac4f706

Merge

! make/common/Defs-windows.gmk

Changeset: 51ccb32e6d14
Author:    tbell
Date:      2009-07-16 18:07 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/51ccb32e6d14

Merge


Changeset: 043c7100a752
Author:    anthony
Date:      2009-07-07 17:05 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/043c7100a752

6853916: java.awt.Window.setBackground(null) throws NullPointerException
Summary: Window.setBackground() should check for null.
Reviewed-by: art, dcherepanov

! src/share/classes/java/awt/Window.java
+ test/java/awt/Window/SetBackgroundNPE/SetBackgroundNPE.java

Changeset: 99cdc0268e4b
Author:    dcherepanov
Date:      2009-07-09 15:15 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/99cdc0268e4b

6855323: Robot(GraphicsDevice) constructor initializes LEGAL_BUTTON_MASK variable improperly
Reviewed-by: art

! src/share/classes/java/awt/Robot.java
+ test/java/awt/Robot/CtorTest/CtorTest.java

Changeset: 9b1e640af25e
Author:    dcherepanov
Date:      2009-07-09 15:18 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9b1e640af25e

6759726: TrayIcon constructor throws NPE instead of documented IAE
Reviewed-by: art

! src/share/classes/java/awt/TrayIcon.java
+ test/java/awt/TrayIcon/CtorTest/CtorTest.java

Changeset: df34ec9f3e26
Author:    dcherepanov
Date:      2009-07-09 15:23 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/df34ec9f3e26

6847958: MouseWheel event is getting triggered for the disabled Textarea in jdk7 b60 pit build.
Reviewed-by: art

! src/solaris/classes/sun/awt/X11/XBaseWindow.java
+ test/java/awt/event/MouseWheelEvent/DisabledComponent/DisabledComponent.java

Changeset: c27d7c1d1918
Author:    dcherepanov
Date:      2009-07-09 15:53 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c27d7c1d1918

6847149: test/java/awt/Window/OwnedWindowsLeak/OwnedWindowsLeak.java fails
Reviewed-by: art

! test/java/awt/Window/OwnedWindowsLeak/OwnedWindowsLeak.java

Changeset: 6d92ce5fe15b
Author:    yan
Date:      2009-07-12 23:20 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6d92ce5fe15b

Merge

- src/share/classes/java/nio/file/DirectoryStreamFilters.java
- src/share/classes/java/nio/file/FileAction.java
- src/share/classes/java/nio/file/spi/AbstractPath.java
- src/share/classes/sun/io/ByteToCharMS932DB.java
- src/share/classes/sun/io/CharToByteMS932DB.java
- src/share/classes/sun/nio/cs/ext/EUC_CN.java
- src/share/classes/sun/nio/cs/ext/EUC_KR.java
- src/share/classes/sun/nio/cs/ext/GBK.java
- src/share/classes/sun/nio/cs/ext/Johab.java
- src/share/classes/sun/nio/cs/ext/MS932.java
- src/share/classes/sun/nio/cs/ext/MS932DB.java
- src/share/classes/sun/nio/cs/ext/MS936.java
- src/share/classes/sun/nio/cs/ext/MS949.java
- src/share/classes/sun/nio/cs/ext/MS950.java
- src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java
- src/share/classes/sun/nio/fs/MimeType.java
- test/java/nio/file/DirectoryStream/Filters.java
- test/java/nio/file/Files/content_type.sh
- test/java/nio/file/Path/temporary_files.sh
- test/java/nio/file/attribute/Attributes/Basic.java

Changeset: 4cd623432e7d
Author:    anthony
Date:      2009-07-14 14:08 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4cd623432e7d

6837446: Introduce Window.isOpaque() method
Reviewed-by: art, alexp

! src/share/classes/com/sun/awt/AWTUtilities.java
! src/share/classes/java/awt/Component.java
! src/share/classes/java/awt/GraphicsDevice.java
! src/share/classes/java/awt/Window.java
! src/share/classes/javax/swing/DefaultDesktopManager.java
! src/share/classes/javax/swing/RepaintManager.java
! src/share/classes/sun/awt/AWTAccessor.java
! src/share/classes/sun/awt/SunToolkit.java
! src/windows/classes/sun/awt/windows/WWindowPeer.java

Changeset: fc869bc0cd63
Author:    yan
Date:      2009-07-14 22:13 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fc869bc0cd63

Merge


Changeset: bccc4d5e8d6a
Author:    malenkov
Date:      2009-07-02 19:48 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bccc4d5e8d6a

6380849: RFE: Automatic discovery of PersistanceDelegates
Reviewed-by: rupashka, alexp

+ src/share/classes/com/sun/beans/finder/BeanInfoFinder.java
+ src/share/classes/com/sun/beans/finder/InstanceFinder.java
+ src/share/classes/com/sun/beans/finder/PersistenceDelegateFinder.java
+ src/share/classes/com/sun/beans/finder/PropertyEditorFinder.java
! src/share/classes/java/beans/Encoder.java
! src/share/classes/java/beans/Introspector.java
! src/share/classes/java/beans/PropertyEditorManager.java
+ test/java/beans/Introspector/6380849/TestBeanInfo.java
+ test/java/beans/Introspector/6380849/beans/FirstBean.java
+ test/java/beans/Introspector/6380849/beans/FirstBeanBeanInfo.java
+ test/java/beans/Introspector/6380849/beans/SecondBean.java
+ test/java/beans/Introspector/6380849/beans/ThirdBean.java
+ test/java/beans/Introspector/6380849/infos/SecondBeanBeanInfo.java
+ test/java/beans/Introspector/6380849/infos/ThirdBeanBeanInfo.java
+ test/java/beans/PropertyEditor/6380849/FirstBean.java
+ test/java/beans/PropertyEditor/6380849/FirstBeanEditor.java
+ test/java/beans/PropertyEditor/6380849/SecondBean.java
+ test/java/beans/PropertyEditor/6380849/TestPropertyEditor.java
+ test/java/beans/PropertyEditor/6380849/ThirdBean.java
+ test/java/beans/PropertyEditor/6380849/editors/SecondBeanEditor.java
+ test/java/beans/PropertyEditor/6380849/editors/ThirdBeanEditor.java
+ test/java/beans/XMLEncoder/6380849/Bean.java
+ test/java/beans/XMLEncoder/6380849/BeanPersistenceDelegate.java
+ test/java/beans/XMLEncoder/6380849/TestPersistenceDelegate.java

Changeset: 7720d6c079ca
Author:    malenkov
Date:      2009-07-03 16:56 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7720d6c079ca

6329581: RFE: LTP: java.beans.XMLEncoder does not manage ClassLoader.
Reviewed-by: rupashka, alexp

! src/share/classes/java/beans/Encoder.java
! src/share/classes/java/beans/MetaData.java
! src/share/classes/java/beans/Statement.java
+ test/java/beans/XMLEncoder/6329581/Test6329581.java

Changeset: ef20a15b3569
Author:    malenkov
Date:      2009-07-06 14:32 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ef20a15b3569

6723447: Introspector doesn't check return type for indexed property setters
Reviewed-by: rupashka

! src/share/classes/java/beans/IndexedPropertyDescriptor.java
! src/share/classes/java/beans/Introspector.java
! src/share/classes/java/beans/PropertyDescriptor.java
+ test/java/beans/Introspector/Test6723447.java

Changeset: 0407df5a768e
Author:    rupashka
Date:      2009-07-07 14:11 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0407df5a768e

6489447: Apply the more robust fix for 6449933 to dolphin and 6ux
Reviewed-by: malenkov

! src/windows/native/sun/windows/ShellFolder2.cpp

Changeset: 913ad033bb37
Author:    yan
Date:      2009-07-12 06:07 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/913ad033bb37

Merge

- src/share/classes/java/nio/file/DirectoryStreamFilters.java
- src/share/classes/java/nio/file/FileAction.java
- src/share/classes/java/nio/file/spi/AbstractPath.java
- src/share/classes/sun/io/ByteToCharMS932DB.java
- src/share/classes/sun/io/CharToByteMS932DB.java
- src/share/classes/sun/nio/cs/ext/EUC_CN.java
- src/share/classes/sun/nio/cs/ext/EUC_KR.java
- src/share/classes/sun/nio/cs/ext/GBK.java
- src/share/classes/sun/nio/cs/ext/Johab.java
- src/share/classes/sun/nio/cs/ext/MS932.java
- src/share/classes/sun/nio/cs/ext/MS932DB.java
- src/share/classes/sun/nio/cs/ext/MS936.java
- src/share/classes/sun/nio/cs/ext/MS949.java
- src/share/classes/sun/nio/cs/ext/MS950.java
- src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java
- src/share/classes/sun/nio/fs/MimeType.java
- src/share/classes/sun/swing/AccessibleMethod.java
- test/java/nio/file/DirectoryStream/Filters.java
- test/java/nio/file/Files/content_type.sh
- test/java/nio/file/Path/temporary_files.sh
- test/java/nio/file/attribute/Attributes/Basic.java

Changeset: c8da3750c7ca
Author:    yan
Date:      2009-07-14 22:15 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c8da3750c7ca

Merge


Changeset: f88379effbcf
Author:    yan
Date:      2009-07-21 23:23 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f88379effbcf

Merge


Changeset: bd31b30a5b21
Author:    dcherepanov
Date:      2009-07-23 11:30 +0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bd31b30a5b21

6857870: Regression tests are failing with ExceptionInInitializerError
Reviewed-by: art

! src/windows/classes/sun/awt/windows/WToolkit.java

Changeset: 11a8f0936228
Author:    xdono
Date:      2009-07-24 13:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/11a8f0936228

Added tag jdk7-b66 for changeset bd31b30a5b21

! .hgtags



From john.coomes at sun.com  Sat Jul 25 06:15:26 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Sat, 25 Jul 2009 13:15:26 +0000
Subject: hg: jdk7/hotspot-gc/langtools: Added tag jdk7-b66 for changeset
	634f519d6f9a
Message-ID: <20090725131530.BEDD2E71B@hg.openjdk.java.net>

Changeset: 0695e8ebae88
Author:    xdono
Date:      2009-07-24 13:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/0695e8ebae88

Added tag jdk7-b66 for changeset 634f519d6f9a

! .hgtags



From y.s.ramakrishna at sun.com  Sun Jul 26 19:41:37 2009
From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com)
Date: Mon, 27 Jul 2009 02:41:37 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 14 new changesets
Message-ID: <20090727024208.A9DAFE79D@hg.openjdk.java.net>

Changeset: fe95187e8882
Author:    never
Date:      2009-07-13 14:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fe95187e8882

6859338: amd64 native unverified entry point pushes values before implicit null check
Reviewed-by: kvn, twisti

! src/cpu/x86/vm/sharedRuntime_x86_64.cpp
+ test/compiler/6859338/Test6859338.java

Changeset: 83906a156fc0
Author:    never
Date:      2009-07-13 15:00 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/83906a156fc0

Merge


Changeset: fd50a67f97d1
Author:    never
Date:      2009-07-15 13:37 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fd50a67f97d1

6860469: remix_address_expressions sets incorrect control causing crash in split_if_with_block_post
Reviewed-by: never, kvn
Contributed-by: yamauchi at google.com, rasbold at google.com

! src/share/vm/opto/loopopts.cpp
+ test/compiler/6860469/Test.java

Changeset: fc4be448891f
Author:    kvn
Date:      2009-07-16 14:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fc4be448891f

6851742: (EA) allocation elimination doesn't work with UseG1GC
Summary: Fix eliminate_card_mark() to eliminate G1 pre/post barriers.
Reviewed-by: never

! src/share/vm/opto/escape.cpp
! src/share/vm/opto/graphKit.cpp
! src/share/vm/opto/graphKit.hpp
! src/share/vm/opto/idealKit.cpp
! src/share/vm/opto/idealKit.hpp
! src/share/vm/opto/ifnode.cpp
! src/share/vm/opto/library_call.cpp
! src/share/vm/opto/machnode.cpp
! src/share/vm/opto/macro.cpp
! src/share/vm/opto/matcher.cpp
! src/share/vm/opto/phaseX.hpp
! src/share/vm/opto/type.hpp

Changeset: 84770322b304
Author:    never
Date:      2009-07-16 17:59 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/84770322b304

6861513: correct copyright attribution in test for 6837094 and 6860469
Reviewed-by: rasbold

! test/compiler/6837094/Test.java
! test/compiler/6860469/Test.java

Changeset: 64219d2a6493
Author:    kvn
Date:      2009-07-16 16:29 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/64219d2a6493

6851282: JIT miscompilation results in null entry in array when using CompressedOops
Summary: Get type for new Phi from non dead path.
Reviewed-by: never

! src/share/vm/opto/cfgnode.cpp
+ test/compiler/6851282/Test.java

Changeset: 606c988ff684
Author:    kvn
Date:      2009-07-17 00:50 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/606c988ff684

Merge


Changeset: f9094a5e1c8a
Author:    never
Date:      2009-07-21 16:42 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f9094a5e1c8a

6857159: local schedule failed with checkcast of Thread.currentThread()
Reviewed-by: kvn

! src/share/vm/adlc/formssel.cpp
! src/share/vm/adlc/formssel.hpp
+ test/compiler/6857159/Test6857159.java
+ test/compiler/6857159/Test6857159.sh

Changeset: 75596850f863
Author:    jrose
Date:      2009-07-21 16:56 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/75596850f863

6862576: vmIntrinsics needs cleanup in order to support JSR 292 intrinsics
Summary: remove useless lazy evaluation of intrinsics; add LAST_COMPILER_INLINE to help categorize them
Reviewed-by: kvn

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/vmSymbols.hpp
! src/share/vm/interpreter/rewriter.cpp
! src/share/vm/oops/methodKlass.cpp
! src/share/vm/oops/methodOop.cpp
! src/share/vm/oops/methodOop.hpp
! src/share/vm/opto/compile.cpp
! src/share/vm/opto/library_call.cpp

Changeset: 17173cb6e48d
Author:    jrose
Date:      2009-07-21 21:33 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/17173cb6e48d

Merge


Changeset: 5314d85ffd54
Author:    kvn
Date:      2009-07-22 15:48 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5314d85ffd54

6826736: CMS: core dump with -XX:+UseCompressedOops
Summary: Fix deoptimization code and OopMapSet::all_do() to check for oop = narrow_oop_base.
Reviewed-by: jcoomes, phh, ysr, never

! src/share/vm/compiler/oopMap.cpp
! src/share/vm/compiler/oopMap.hpp
! src/share/vm/memory/universe.hpp
! src/share/vm/runtime/stackValue.cpp
+ test/compiler/6826736/Test.java

Changeset: ea3f9723b5cf
Author:    kvn
Date:      2009-07-23 14:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ea3f9723b5cf

6860599: nodes limit could be reached during Output phase
Summary: Bailout compilation if nodes limit could be reached during Output phase.
Reviewed-by: never, twisti

! src/share/vm/opto/compile.cpp
! src/share/vm/opto/compile.hpp
! src/share/vm/opto/output.cpp

Changeset: 433f394ab509
Author:    kvn
Date:      2009-07-24 09:01 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/433f394ab509

Merge

! src/share/vm/memory/universe.hpp
! src/share/vm/opto/cfgnode.cpp

Changeset: 0a83664f978b
Author:    ysr
Date:      2009-07-24 12:49 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0a83664f978b

Merge

! src/share/vm/opto/cfgnode.cpp



From Christian.Thalinger at Sun.COM  Mon Jul 27 04:10:53 2009
From: Christian.Thalinger at Sun.COM (Christian Thalinger)
Date: Mon, 27 Jul 2009 13:10:53 +0200
Subject: for review (M): 6863023: need non-perm oops in code cache for JSR
	292
In-Reply-To: <01A90166-7F50-4218-B38A-345C7CA7ABF7@sun.com>
References: <01A90166-7F50-4218-B38A-345C7CA7ABF7@sun.com>
Message-ID: <4A6D8B3D.6060704@Sun.COM>

John Rose wrote:
> In order to inline method handles at invokedynamic instructions, it is  
> necessary to manipulate MethodHandle and CallSite constants from  
> generated code.  Since these objects are created by ordinary user code  
> and subject to usual GC, they are not preallocated in the perm gen.
> 
> Currently compiled code requires that any oop embedded as an  
> instruction constant or any other nmethod part must be  
> OopDesc::is_perm.  For example, internal method objects and classes  
> and interned strings are permanent so that they can be manipulated  
> from compiled code.
> 
> This restriction is a bug for JSR 292.  Luckily, there is a simple fix.
> 
> http://cr.openjdk.java.net/~jrose/6862576/webrev.00/
> 

It seems there is a problem with returns:

+bool nmethod::detect_non_perm_oops() {
+  DetectNonPerm detect_non_perm;
+  if (PrintRelocations)  NOT_PRODUCT(detect_non_perm._print_nm = this);
+  oops_do(&detect_non_perm);
+  return detect_non_perm.detected_non_perm();
+    return false;
+  return true;
+}

Shouldn't the compiler complain about that?

-- Christian


From Jon.Masamitsu at Sun.COM  Mon Jul 27 15:59:47 2009
From: Jon.Masamitsu at Sun.COM (Jon Masamitsu)
Date: Mon, 27 Jul 2009 15:59:47 -0700
Subject: Request for review (s) - CR 6862534
Message-ID: <4A6E3163.8030301@sun.com>

6862534: -XX:NewRatio completely ignored when combined with
-XX:+UseConcMarkSweepGC

With regard to the sizing of the young generation, restrict the cms
ergonomic setting (more tightly) to the case where neither NewRatio^?
<http://j2se.sfbay.sun.com/web/bin/edit/HotspotGC/NewRatio?topicparent=HotspotGC.JonCR6862534>
nor MaxNewSize^?
<http://j2se.sfbay.sun.com/web/bin/edit/HotspotGC/MaxNewSize?topicparent=HotspotGC.JonCR6862534>
has been set on the command line. Also, if NewSize^?
<http://j2se.sfbay.sun.com/web/bin/edit/HotspotGC/NewSize?topicparent=HotspotGC.JonCR6862534>
has been set on the command line, use it.

Guards in set_cms_and_parnew_gc_flags() that were
FLAG_IS_DEFAULT(MaxNewSize^?
<http://j2se.sfbay.sun.com/web/bin/edit/HotspotGC/MaxNewSize?topicparent=HotspotGC.JonCR6862534>)
or FLAG_IS_DEFAULT(NewRatio^?
<http://j2se.sfbay.sun.com/web/bin/edit/HotspotGC/NewRatio?topicparent=HotspotGC.JonCR6862534>)
were changed to check both.

http://cr.openjdk.java.net/~jmasa/6862534
<http://cr.openjdk.java.net/%7Ejmasa/6862534>



From Jon.Masamitsu at Sun.COM  Mon Jul 27 16:26:06 2009
From: Jon.Masamitsu at Sun.COM (Jon Masamitsu)
Date: Mon, 27 Jul 2009 16:26:06 -0700
Subject: Request for review (s) - CR 6862534
In-Reply-To: <4A6E3163.8030301@sun.com>
References: <4A6E3163.8030301@sun.com>
Message-ID: <4A6E378E.3090103@sun.com>

Ok.  That cut-and-paste didn't come out well at all.  Here's
the cleaned up/readable version.


Jon Masamitsu wrote On 07/27/09 15:59,:

>6862534: -XX:NewRatio completely ignored when combined with
>-XX:+UseConcMarkSweepGC
>
>With regard to the sizing of the young generation, restrict the cms
>ergonomic setting (more tightly) to the case where neither NewRatio
>nor MaxNewSize has been set on the command line. Also, if NewSize
>has been set on the command line, use it.
>
>Guards in set_cms_and_parnew_gc_flags() that were
>FLAG_IS_DEFAULT(MaxNewSize) or FLAG_IS_DEFAULT(NewRatio)
>were changed to check both.
>
>http://cr.openjdk.java.net/~jmasa/6862534
>
>  
>



From John.Coomes at sun.com  Mon Jul 27 23:16:58 2009
From: John.Coomes at sun.com (John Coomes)
Date: Mon, 27 Jul 2009 23:16:58 -0700
Subject: review request (S) - 6821693: TaskQueue capacity
Message-ID: <19054.38874.928893.897457@sun.com>

I'd appreciate some reviews of 

http://cr.openjdk.java.net/~jcoomes/6821693-taskqueue64/

	6821693 64-bit TaskQueue capacity still too small
	6821507 Alignment problem in GC taskqueue

Those w/good memories may recall an earlier review request, but enough
code has changed and time has passed to require new reviews.

A micro-test that pushes/pops items on/off the queue is ~10% faster
w/the new code on intel, but there's no noticeable effect on
real-world apps.

-John



From Jon.Masamitsu at Sun.COM  Tue Jul 28 06:47:58 2009
From: Jon.Masamitsu at Sun.COM (Jon Masamitsu)
Date: Tue, 28 Jul 2009 06:47:58 -0700
Subject: review request (S) - 6821693: TaskQueue capacity
In-Reply-To: <19054.38874.928893.897457@sun.com>
References: <19054.38874.928893.897457@sun.com>
Message-ID: <4A6F018E.5020409@Sun.COM>



On 07/27/09 23:16, John Coomes wrote:
> I'd appreciate some reviews of 
> 
> http://cr.openjdk.java.net/~jcoomes/6821693-taskqueue64/
> 
> 	6821693 64-bit TaskQueue capacity still too small
> 	6821507 Alignment problem in GC taskqueue
> 
> Those w/good memories may recall an earlier review request, but enough
> code has changed and time has passed to require new reviews.
> 
> A micro-test that pushes/pops items on/off the queue is ~10% faster

Is that 10% faster than the code in the previous webrev?

> w/the new code on intel, but there's no noticeable effect on
> real-world apps.
> 
> -John
> 


From John.Coomes at sun.com  Tue Jul 28 09:23:58 2009
From: John.Coomes at sun.com (John Coomes)
Date: Tue, 28 Jul 2009 09:23:58 -0700
Subject: review request (S) - 6821693: TaskQueue capacity
In-Reply-To: <4A6F018E.5020409@Sun.COM>
References: <19054.38874.928893.897457@sun.com>
	<4A6F018E.5020409@Sun.COM>
Message-ID: <19055.9758.225531.958404@sun.com>

Jon Masamitsu (Jon.Masamitsu at Sun.COM) wrote:
> On 07/27/09 23:16, John Coomes wrote:
> > I'd appreciate some reviews of 
> > 
> > http://cr.openjdk.java.net/~jcoomes/6821693-taskqueue64/
> > 
> > 	6821693 64-bit TaskQueue capacity still too small
> > 	6821507 Alignment problem in GC taskqueue
> > 
> > Those w/good memories may recall an earlier review request, but enough
> > code has changed and time has passed to require new reviews.
> > 
> > A micro-test that pushes/pops items on/off the queue is ~10% faster
> 
> Is that 10% faster than the code in the previous webrev?

No, it's relative to an unmodified repo.

-John

> > w/the new code on intel, but there's no noticeable effect on
> > real-world apps.
> > 
> > -John
> > 



From John.Rose at Sun.COM  Tue Jul 28 19:08:07 2009
From: John.Rose at Sun.COM (John Rose)
Date: Tue, 28 Jul 2009 19:08:07 -0700
Subject: for review (M): 6863023: need non-perm oops in code cache for JSR
	292
In-Reply-To: <4A6D8B3D.6060704@Sun.COM>
References: <01A90166-7F50-4218-B38A-345C7CA7ABF7@sun.com>
	<4A6D8B3D.6060704@Sun.COM>
Message-ID: <A65EAC45-9173-4614-94D2-E9BBF8FCABE6@Sun.COM>

On Jul 27, 2009, at 4:10 AM, Christian Thalinger wrote:

> It seems there is a problem with returns:

Right; it was an incomplete code change.  Thanks.  -- John


From John.Rose at Sun.COM  Tue Jul 28 19:26:19 2009
From: John.Rose at Sun.COM (John Rose)
Date: Tue, 28 Jul 2009 19:26:19 -0700
Subject: for review (M): 6863023: need non-perm oops in code cache for JSR
	292
In-Reply-To: <A65EAC45-9173-4614-94D2-E9BBF8FCABE6@Sun.COM>
References: <01A90166-7F50-4218-B38A-345C7CA7ABF7@sun.com>
	<4A6D8B3D.6060704@Sun.COM>
	<A65EAC45-9173-4614-94D2-E9BBF8FCABE6@Sun.COM>
Message-ID: <A5E5CBED-3D90-47C7-BDE4-52FC4AD3CB9A@sun.com>

I have updated the webrev slightly, and fixed the URL:
   http://cr.openjdk.java.net/~jrose/6863023/webrev.01/

Someone observed that the pruning logic might not be exercised, since  
non-perms do not become perm.  But it does get exercised when nmethods  
are deallocated.  (And that caused a bug I had to fix...)

-- John

On Jul 28, 2009, at 7:08 PM, John Rose wrote:

> On Jul 27, 2009, at 4:10 AM, Christian Thalinger wrote:
>
>> It seems there is a problem with returns:
>
> Right; it was an incomplete code change.  Thanks.  -- John



From dragonken at gmail.com  Wed Jul 29 07:26:58 2009
From: dragonken at gmail.com (Ken--@newsgroupstats.hk)
Date: Wed, 29 Jul 2009 07:26:58 -0700 (PDT)
Subject: JVM 32bits Xmx limitation
Message-ID: <24719844.post@talk.nabble.com>


Hi All,

I have an old java application running on old 32bits windows 2000 server, 2G
Ram with JDK5. Originally I can startup my apps with -Xmx1412M. It's work
for a year. One day, I restart windows but fail to start my app. It said
'Could not reserve enough space for object heap'. I have to decrease the Xmx
to 1200M to make it work. Please advise.

The server reboots everyday. No windows updates (and no software newly
installed) for 3 months.

I increase the physical memory to 4GB, it didn't help.

Any workaround?

Regards,
Ken
-- 
View this message in context: http://www.nabble.com/JVM-32bits-Xmx-limitation-tp24719844p24719844.html
Sent from the OpenJDK Hotspot Garbage Collection mailing list archive at Nabble.com.



From John.Coomes at sun.com  Wed Jul 29 09:57:42 2009
From: John.Coomes at sun.com (John Coomes)
Date: Wed, 29 Jul 2009 09:57:42 -0700
Subject: JVM 32bits Xmx limitation
In-Reply-To: <24719844.post@talk.nabble.com>
References: <24719844.post@talk.nabble.com>
Message-ID: <19056.32646.674850.439624@sun.com>

Ken-- at newsgroupstats.hk (dragonken at gmail.com) wrote:
> 
> Hi All,
> 
> I have an old java application running on old 32bits windows 2000 server, 2G
> Ram with JDK5. Originally I can startup my apps with -Xmx1412M. It's work
> for a year. One day, I restart windows but fail to start my app. It said
> 'Could not reserve enough space for object heap'. I have to decrease the Xmx
> to 1200M to make it work. Please advise.
> 
> The server reboots everyday. No windows updates (and no software newly
> installed) for 3 months.

This is most likely because the JVM can't get a contiguous range of
virtual addresses for the java heap.  32-bit windows reserves half for
its own use, so everything else has to live in 2G.

Something changed to reduce the size of the largest available range of
addresses.  Most often it's a windows update, but we've also seen some
correlation with virus scanner updates--there's a current thread on
the java forums discussing a similar problem when running Sophos AV.

> I increase the physical memory to 4GB, it didn't help.
> 
> Any workaround?

There used to be a utility on sysinternals.com that would print out
what address ranges were in use and what was using them.  I can't find
it now, but process explorer might give you that info.  You might be
able to see what's taking up the space and use the 'rebase' utility to
relocate things (including the JDK itself).

-John



From antonios.printezis at sun.com  Wed Jul 29 11:54:30 2009
From: antonios.printezis at sun.com (antonios.printezis at sun.com)
Date: Wed, 29 Jul 2009 18:54:30 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6864886: G1: rename -XX parameters
	related to update buffers
Message-ID: <20090729185437.14EE2EBA2@hg.openjdk.java.net>

Changeset: 27f6a9b9c311
Author:    tonyp
Date:      2009-07-29 11:01 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/27f6a9b9c311

6864886: G1: rename -XX parameters related to update buffers
Summary: renaming a couple of update buffer-related parameters to make them more understandable and consistent.
Reviewed-by: iveresov, ysr

! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp
! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp
! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1_globals.hpp
! src/share/vm/runtime/globals.hpp



From Antonios.Printezis at sun.com  Thu Jul 30 08:15:24 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Thu, 30 Jul 2009 11:15:24 -0400
Subject: Code review request: 6866591: G1: print update buffer processing stats
	more often (XXS)
Message-ID: <4A71B90C.6070506@sun.com>

Hi,

Could I get a couple of review for this one? Basically, I add 
-XX:G1SummarizeRSetStatsPeriod=N which will generate update buffer 
processing information more often. The web also includes two tiny 
formatting changes in g1_globals.hpp.

http://cr.openjdk.java.net/~tonyp/6866591/webrev.0/

It's a trivial change.

Tony

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From Jon.Masamitsu at Sun.COM  Thu Jul 30 08:45:57 2009
From: Jon.Masamitsu at Sun.COM (Jon Masamitsu)
Date: Thu, 30 Jul 2009 08:45:57 -0700
Subject: Request for review (vs) - 6843292
Message-ID: <4A71C035.1060105@Sun.COM>


6843292: "Expect to be beyond new region unless impacting another 
region" assertion too strong"

Relax the assertion for the case where the new region extends into the 
guard page.

http://cr.openjdk.java.net/~jmasa/6843292


From Antonios.Printezis at sun.com  Thu Jul 30 09:06:58 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Thu, 30 Jul 2009 12:06:58 -0400
Subject: Code review request: 6866591: G1: print update buffer processing
	stats more often (XXS)
In-Reply-To: <4A71B90C.6070506@sun.com>
References: <4A71B90C.6070506@sun.com>
Message-ID: <4A71C522.1040902@sun.com>

I have one review (thanks Jon!). Jon actually pointed out that the tiny 
formatting changes are not shown on the webrev, which is because webrev 
ignores white space differences. Here they are, in case you're wondering 
(just re-aligning a couple of backslashes):

@@ -34,7 +34,7 @@
   product(intx, G1ConfidencePercent, 
50,                                    \
           "Confidence level for MMU/pause 
predictions")                     \
                                                                             
\
-  develop(intx, G1MarkingOverheadPercent, 
0,                                   \
+  develop(intx, G1MarkingOverheadPercent, 
0,                                \
           "Overhead of concurrent 
marking")                                 \
                                                                             
\
   develop(bool, G1AccountConcurrentOverhead, 
false,                         \
@@ -47,7 +47,7 @@
   develop(bool, G1Gen, 
true,                                                \
           "If true, it will enable the generational 
G1")                    \
                                                                             
\
-  develop(intx, G1GCPercent, 
10,                                                \
+  develop(intx, G1GCPercent, 
10,                                            \
           "The desired percent time spent on 
GC")                           \
                                                                             
\
   develop(intx, G1PolicyVerbose, 
0,                                         \

Tony

Tony Printezis wrote:
> Hi,
>
> Could I get a couple of review for this one? Basically, I add 
> -XX:G1SummarizeRSetStatsPeriod=N which will generate update buffer 
> processing information more often. The web also includes two tiny 
> formatting changes in g1_globals.hpp.
>
> http://cr.openjdk.java.net/~tonyp/6866591/webrev.0/
>
> It's a trivial change.
>
> Tony
>

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From John.Coomes at sun.com  Thu Jul 30 09:43:16 2009
From: John.Coomes at sun.com (John Coomes)
Date: Thu, 30 Jul 2009 09:43:16 -0700
Subject: Code review request: 6866591: G1: print update buffer processing
	stats more often (XXS)
In-Reply-To: <4A71B90C.6070506@sun.com>
References: <4A71B90C.6070506@sun.com>
Message-ID: <19057.52644.204248.338585@sun.com>

Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
> Hi,
> 
> Could I get a couple of review for this one? Basically, I add 
> -XX:G1SummarizeRSetStatsPeriod=N which will generate update buffer 
> processing information more often. The web also includes two tiny 
> formatting changes in g1_globals.hpp.
> 
> http://cr.openjdk.java.net/~tonyp/6866591/webrev.0/

Looks good to me.

-John



From Antonios.Printezis at sun.com  Thu Jul 30 09:54:27 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Thu, 30 Jul 2009 12:54:27 -0400
Subject: Code review request: 6866591: G1: print update buffer processing
	stats more often (XXS)
In-Reply-To: <4A71C522.1040902@sun.com>
References: <4A71B90C.6070506@sun.com> <4A71C522.1040902@sun.com>
Message-ID: <4A71D043.7040609@sun.com>

All set thanks to Jon Masa, John Coomes, and Ramki!

Tony Printezis wrote:
> I have one review (thanks Jon!). Jon actually pointed out that the 
> tiny formatting changes are not shown on the webrev, which is because 
> webrev ignores white space differences. Here they are, in case you're 
> wondering (just re-aligning a couple of backslashes):
>
> @@ -34,7 +34,7 @@
>   product(intx, G1ConfidencePercent, 
> 50,                                    \
>           "Confidence level for MMU/pause 
> predictions")                     \
>                                                                             
> \
> -  develop(intx, G1MarkingOverheadPercent, 
> 0,                                   \
> +  develop(intx, G1MarkingOverheadPercent, 
> 0,                                \
>           "Overhead of concurrent 
> marking")                                 \
>                                                                             
> \
>   develop(bool, G1AccountConcurrentOverhead, 
> false,                         \
> @@ -47,7 +47,7 @@
>   develop(bool, G1Gen, 
> true,                                                \
>           "If true, it will enable the generational 
> G1")                    \
>                                                                             
> \
> -  develop(intx, G1GCPercent, 
> 10,                                                \
> +  develop(intx, G1GCPercent, 
> 10,                                            \
>           "The desired percent time spent on 
> GC")                           \
>                                                                             
> \
>   develop(intx, G1PolicyVerbose, 
> 0,                                         \
>
> Tony
>
> Tony Printezis wrote:
>> Hi,
>>
>> Could I get a couple of review for this one? Basically, I add 
>> -XX:G1SummarizeRSetStatsPeriod=N which will generate update buffer 
>> processing information more often. The web also includes two tiny 
>> formatting changes in g1_globals.hpp.
>>
>> http://cr.openjdk.java.net/~tonyp/6866591/webrev.0/
>>
>> It's a trivial change.
>>
>> Tony
>>
>

-- 
---------------------------------------------------------------------
| Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
|                                  | MS UBUR02-311                  |
| e-mail: tony.printezis at sun.com   | 35 Network Drive               |
| office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
---------------------------------------------------------------------
e-mail client: Thunderbird (Linux)




From John.Coomes at sun.com  Thu Jul 30 10:06:56 2009
From: John.Coomes at sun.com (John Coomes)
Date: Thu, 30 Jul 2009 10:06:56 -0700
Subject: Request for review (vs) - 6843292
In-Reply-To: <4A71C035.1060105@Sun.COM>
References: <4A71C035.1060105@Sun.COM>
Message-ID: <19057.54064.199007.420958@sun.com>

Jon Masamitsu (Jon.Masamitsu at Sun.COM) wrote:
> 
> 6843292: "Expect to be beyond new region unless impacting another 
> region" assertion too strong"
> 
> Relax the assertion for the case where the new region extends into the 
> guard page.
> 
> http://cr.openjdk.java.net/~jmasa/6843292

Looks fine.  You could change this:

 259     HeapWord* new_end_for_commit = new_end_aligned;
 260 
 261     debug_only(bool guarded = false;)
 262     if (new_end_for_commit > _guard_region.start()) {
 263       new_end_for_commit = _guard_region.start();
 264       debug_only(guarded = true;)
 265     }

to this:

    DEBUG_ONLY(const bool guarded = new_end_aligned > _guard_region.start());
    HeapWord* new_end_for_commit = MIN2(new_end_aligned, _guard_region.start());

which is easier to read (IMHO, of course).

-John



From Antonios.Printezis at sun.com  Thu Jul 30 11:07:42 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Thu, 30 Jul 2009 14:07:42 -0400
Subject: Request for review (vs) - 6843292
In-Reply-To: <19057.54064.199007.420958@sun.com>
References: <4A71C035.1060105@Sun.COM> <19057.54064.199007.420958@sun.com>
Message-ID: <4A71E16E.4080904@sun.com>

BTW, the conversation I had with Jon was whether bool guarded = ... 
should really be debug_only() or the equivalent of assert_only() (which 
we can only do with #ifdef ASSERT right now), given that guarded is only 
used in an assert. Is there a policy to use debug_only() for anything 
that's only used in asserts?

Tony

John Coomes wrote:
> Jon Masamitsu (Jon.Masamitsu at Sun.COM) wrote:
>   
>> 6843292: "Expect to be beyond new region unless impacting another 
>> region" assertion too strong"
>>
>> Relax the assertion for the case where the new region extends into the 
>> guard page.
>>
>> http://cr.openjdk.java.net/~jmasa/6843292
>>     
>
> Looks fine.  You could change this:
>
>  259     HeapWord* new_end_for_commit = new_end_aligned;
>  260 
>  261     debug_only(bool guarded = false;)
>  262     if (new_end_for_commit > _guard_region.start()) {
>  263       new_end_for_commit = _guard_region.start();
>  264       debug_only(guarded = true;)
>  265     }
>
> to this:
>
>     DEBUG_ONLY(const bool guarded = new_end_aligned > _guard_region.start());
>     HeapWord* new_end_for_commit = MIN2(new_end_aligned, _guard_region.start());
>
> which is easier to read (IMHO, of course).
>
> -John
>
>   

-- 
---------------------------------------------------------------------
| Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
|                                  | MS UBUR02-311                  |
| e-mail: tony.printezis at sun.com   | 35 Network Drive               |
| office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
---------------------------------------------------------------------
e-mail client: Thunderbird (Linux)




From John.Coomes at sun.com  Thu Jul 30 11:27:35 2009
From: John.Coomes at sun.com (John Coomes)
Date: Thu, 30 Jul 2009 11:27:35 -0700
Subject: Request for review (vs) - 6843292
In-Reply-To: <4A71E16E.4080904@sun.com>
References: <4A71C035.1060105@Sun.COM> <19057.54064.199007.420958@sun.com>
	<4A71E16E.4080904@sun.com>
Message-ID: <19057.58903.124803.736288@sun.com>

Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
> BTW, the conversation I had with Jon was whether bool guarded = ... 
> should really be debug_only() or the equivalent of assert_only() (which 
> we can only do with #ifdef ASSERT right now), given that guarded is only 
> used in an assert. Is there a policy to use debug_only() for anything 
> that's only used in asserts?

Despite the name, DEBUG_ONLY(), and the deprecated debug_only(), are
controlled by #ifdef ASSERT; see macros.hpp.  So they're intended for
stuff that's only used in asserts.

-John

> John Coomes wrote:
> > Jon Masamitsu (Jon.Masamitsu at Sun.COM) wrote:
> >   
> >> 6843292: "Expect to be beyond new region unless impacting another 
> >> region" assertion too strong"
> >>
> >> Relax the assertion for the case where the new region extends into the 
> >> guard page.
> >>
> >> http://cr.openjdk.java.net/~jmasa/6843292
> >>     
> >
> > Looks fine.  You could change this:
> >
> >  259     HeapWord* new_end_for_commit = new_end_aligned;
> >  260 
> >  261     debug_only(bool guarded = false;)
> >  262     if (new_end_for_commit > _guard_region.start()) {
> >  263       new_end_for_commit = _guard_region.start();
> >  264       debug_only(guarded = true;)
> >  265     }
> >
> > to this:
> >
> >     DEBUG_ONLY(const bool guarded = new_end_aligned > _guard_region.start());
> >     HeapWord* new_end_for_commit = MIN2(new_end_aligned, _guard_region.start());
> >
> > which is easier to read (IMHO, of course).
> >
> > -John
> >
> >   
> 
> -- 
> ---------------------------------------------------------------------
> | Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
> |                                  | MS UBUR02-311                  |
> | e-mail: tony.printezis at sun.com   | 35 Network Drive               |
> | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
> ---------------------------------------------------------------------
> e-mail client: Thunderbird (Linux)
> 
> 



From Antonios.Printezis at sun.com  Thu Jul 30 14:01:53 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Thu, 30 Jul 2009 17:01:53 -0400
Subject: Request for review (vs) - 6843292
In-Reply-To: <19057.58903.124803.736288@sun.com>
References: <4A71C035.1060105@Sun.COM> <19057.54064.199007.420958@sun.com>
	<4A71E16E.4080904@sun.com> <19057.58903.124803.736288@sun.com>
Message-ID: <4A720A41.1090509@sun.com>

Thanks John, I hadn't realized that... I thought debug and assert were 
separate... OK, I'll keep my mouth shut now. :-)

Tony

John Coomes wrote:
> Tony Printezis (Antonios.Printezis at Sun.COM) wrote:
>   
>> BTW, the conversation I had with Jon was whether bool guarded = ... 
>> should really be debug_only() or the equivalent of assert_only() (which 
>> we can only do with #ifdef ASSERT right now), given that guarded is only 
>> used in an assert. Is there a policy to use debug_only() for anything 
>> that's only used in asserts?
>>     
>
> Despite the name, DEBUG_ONLY(), and the deprecated debug_only(), are
> controlled by #ifdef ASSERT; see macros.hpp.  So they're intended for
> stuff that's only used in asserts.
>
> -John
>
>   
>> John Coomes wrote:
>>     
>>> Jon Masamitsu (Jon.Masamitsu at Sun.COM) wrote:
>>>   
>>>       
>>>> 6843292: "Expect to be beyond new region unless impacting another 
>>>> region" assertion too strong"
>>>>
>>>> Relax the assertion for the case where the new region extends into the 
>>>> guard page.
>>>>
>>>> http://cr.openjdk.java.net/~jmasa/6843292
>>>>     
>>>>         
>>> Looks fine.  You could change this:
>>>
>>>  259     HeapWord* new_end_for_commit = new_end_aligned;
>>>  260 
>>>  261     debug_only(bool guarded = false;)
>>>  262     if (new_end_for_commit > _guard_region.start()) {
>>>  263       new_end_for_commit = _guard_region.start();
>>>  264       debug_only(guarded = true;)
>>>  265     }
>>>
>>> to this:
>>>
>>>     DEBUG_ONLY(const bool guarded = new_end_aligned > _guard_region.start());
>>>     HeapWord* new_end_for_commit = MIN2(new_end_aligned, _guard_region.start());
>>>
>>> which is easier to read (IMHO, of course).
>>>
>>> -John
>>>
>>>   
>>>       
>> -- 
>> ---------------------------------------------------------------------
>> | Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
>> |                                  | MS UBUR02-311                  |
>> | e-mail: tony.printezis at sun.com   | 35 Network Drive               |
>> | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
>> ---------------------------------------------------------------------
>> e-mail client: Thunderbird (Linux)
>>
>>
>>     
>
>   

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From Antonios.Printezis at sun.com  Thu Jul 30 14:21:38 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Thu, 30 Jul 2009 17:21:38 -0400
Subject: Code Review Request: 6819085 	 G1: use larger and/or user settable
	region size
Message-ID: <4A720EE2.90404@sun.com>

http://cr.openjdk.java.net/~tonyp/6819085/webrev.0/

The idea is to allow the user to set the region size with a parameter 
(-XX:G1HeapRegionSize=N).

Tony

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)




From antonios.printezis at sun.com  Thu Jul 30 17:30:09 2009
From: antonios.printezis at sun.com (antonios.printezis at sun.com)
Date: Fri, 31 Jul 2009 00:30:09 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 6866591: G1: print update buffer
	processing stats more often
Message-ID: <20090731003020.18295ED3F@hg.openjdk.java.net>

Changeset: 83b687ce3090
Author:    tonyp
Date:      2009-07-30 14:50 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/83b687ce3090

6866591: G1: print update buffer processing stats more often
Summary: It adds parameter -XX:+G1SummarizeRSetStatsPeriod that causes update buffer processing information to be printed periodically. It also includes two small formatting changes.
Reviewed-by: jmasa, jcoomes, ysr

! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp
! src/share/vm/gc_implementation/g1/g1_globals.hpp



From vikram.account at gmail.com  Thu Jul 30 20:12:50 2009
From: vikram.account at gmail.com (Vikram A)
Date: Fri, 31 Jul 2009 08:42:50 +0530
Subject: Code Review Request: 6819085 G1: use larger and/or user settable 
	region size
In-Reply-To: <4A720EE2.90404@sun.com>
References: <4A720EE2.90404@sun.com>
Message-ID: <10ffa8f60907302012u628325a7q682995927644d077@mail.gmail.com>

hi Tony,

Just thinking out loud here.

You had once outlined  that we get most benefit with 1MB regions based
on your testing.

 in arguments.cpp

+   uintx region_size = G1HeapRegionSize;
+   if (FLAG_IS_DEFAULT(G1HeapRegionSize)) {
+     // We base the automatic calculation on the min heap size. This
+     // can be problematic if the spread between min and max is quite
+     // wide, imagine -Xms128m -Xmx32g. But, if we decided it based on
+     // the max size, the region size might be way too small for the
+     // min size. Either way, some users might have to set the region
+     // size manually for some -Xms / -Xmx combos.
+     region_size = min_heap_size() / TARGET_REGION_NUMBER;
+   }

with this for many small application it seems to me that the region
size is disturbed.

eg. in the above doc. you mention
-Xms128, consider the heap to be  and TARGET_REGION_NUMBER is defined as 2048.
So, total heap will be
128 * 1024(K) = 131072K
now dividing 131072K/2048 = 64K for each region.

If this inpterpretation is right and there is a reason for doing it
this way, aren't we losing the adv we gained with 1024K region.
this seems like a very small region size and would induce frequent GC,
although could be with small pause time.

I would assume that many enterprise would run their java with larger
heaps than this, but considering this is also for every one, should
the 1024K region size be useful to keep by default while allowing this
fix to modify it for advanced user.

Like I said just my thoughts.

regards,
Vikram.

On Fri, Jul 31, 2009 at 2:51 AM, Tony Printezis
<Antonios.Printezis at sun.com> wrote:
>
> http://cr.openjdk.java.net/~tonyp/6819085/webrev.0/
>
> The idea is to allow the user to set the region size with a parameter (-XX:G1HeapRegionSize=N).
>
> Tony
>
> --
> ----------------------------------------------------------------------
> | Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
> |                                   | MS BUR02-311                   |
> | e-mail: tony.printezis at sun.com    | 35 Network Drive               |
> | office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
> ----------------------------------------------------------------------
> e-mail client: Thunderbird (Solaris)
>
>


From john.coomes at sun.com  Thu Jul 30 22:21:39 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 31 Jul 2009 05:21:39 +0000
Subject: hg: jdk7/hotspot-gc: 2 new changesets
Message-ID: <20090731052140.016BEEDCC@hg.openjdk.java.net>

Changeset: c4523c6f8204
Author:    xdono
Date:      2009-07-28 12:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/c4523c6f8204

6862919: Update copyright year
Summary: Update copyright for files that have been modified in 2009, up to 07/09
Reviewed-by: tbell, ohair

! make/deploy-rules.gmk
! make/jprt.properties
! make/sanity-rules.gmk

Changeset: cab520b37e9a
Author:    xdono
Date:      2009-07-30 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/cab520b37e9a

Added tag jdk7-b67 for changeset c4523c6f8204

! .hgtags



From john.coomes at sun.com  Thu Jul 30 22:27:04 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 31 Jul 2009 05:27:04 +0000
Subject: hg: jdk7/hotspot-gc/corba: 2 new changesets
Message-ID: <20090731052707.03D9BEDD1@hg.openjdk.java.net>

Changeset: a12ea7c7b497
Author:    xdono
Date:      2009-07-28 12:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/a12ea7c7b497

6862919: Update copyright year
Summary: Update copyright for files that have been modified in 2009, up to 07/09
Reviewed-by: tbell, ohair

! make/Makefile
! make/common/Library.gmk
! make/common/Rules.gmk
! make/common/shared/Compiler-gcc.gmk
! make/common/shared/Defs-java.gmk
! make/common/shared/Defs-windows.gmk
! make/common/shared/Platform.gmk
! make/jprt.properties
! make/org/omg/idl/Makefile
! make/tools/logutil/Makefile
! src/share/classes/com/sun/corba/se/impl/encoding/BufferManagerReadStream.java
! src/share/classes/com/sun/corba/se/impl/io/ObjectStreamClass.java
! src/share/classes/com/sun/corba/se/impl/oa/poa/POAFactory.java
! src/share/classes/com/sun/corba/se/impl/orb/ORBImpl.java
! src/share/classes/com/sun/corba/se/impl/orb/ORBSingleton.java
! src/share/classes/com/sun/corba/se/impl/orbutil/ORBUtility.java
! src/share/classes/com/sun/corba/se/impl/presentation/rmi/IDLNameTranslatorImpl.java
! src/share/classes/com/sun/corba/se/impl/resolver/INSURLOperationImpl.java
! src/share/classes/com/sun/corba/se/impl/transport/SocketOrChannelConnectionImpl.java
! src/share/classes/com/sun/corba/se/spi/logging/data/ORBUtil.mc
! src/share/classes/com/sun/tools/corba/se/idl/Parser.java
! src/share/classes/com/sun/tools/corba/se/idl/first.set
! src/share/classes/com/sun/tools/corba/se/idl/follow.set
! src/share/classes/com/sun/tools/corba/se/idl/grammar.idl
! src/share/classes/com/sun/tools/corba/se/idl/grammar3.idl
! src/share/classes/com/sun/tools/corba/se/idl/idl.prp
! src/share/classes/com/sun/tools/corba/se/idl/idl_ja.prp
! src/share/classes/com/sun/tools/corba/se/idl/idl_zh_CN.prp
! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable.prp
! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_ja.prp
! src/share/classes/com/sun/tools/corba/se/idl/toJavaPortable/toJavaPortable_zh_CN.prp
! src/share/classes/com/sun/tools/corba/se/logutil/Input.java
! src/share/classes/com/sun/tools/corba/se/logutil/InputCode.java
! src/share/classes/com/sun/tools/corba/se/logutil/InputException.java
! src/share/classes/com/sun/tools/corba/se/logutil/MC.java
! src/share/classes/org/omg/CORBA/ORB.java
! src/windows/resource/version.rc

Changeset: ec55ebb18a61
Author:    xdono
Date:      2009-07-30 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/ec55ebb18a61

Added tag jdk7-b67 for changeset a12ea7c7b497

! .hgtags



From john.coomes at sun.com  Thu Jul 30 22:36:11 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 31 Jul 2009 05:36:11 +0000
Subject: hg: jdk7/hotspot-gc/jaxp: 2 new changesets
Message-ID: <20090731053615.3A576EDD6@hg.openjdk.java.net>

Changeset: a033af8d824a
Author:    xdono
Date:      2009-07-28 12:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/a033af8d824a

6862919: Update copyright year
Summary: Update copyright for files that have been modified in 2009, up to 07/09
Reviewed-by: tbell, ohair

! make/build.properties
! make/build.xml
! make/jprt.properties
! src/share/classes/com/sun/org/apache/xerces/internal/impl/PropertyManager.java
! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentFragmentScannerImpl.java
! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLDocumentScannerImpl.java
! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLStreamFilterImpl.java
! src/share/classes/com/sun/xml/internal/stream/events/XMLEventAllocatorImpl.java

Changeset: c77f6ec0bd9b
Author:    xdono
Date:      2009-07-30 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/c77f6ec0bd9b

Added tag jdk7-b67 for changeset a033af8d824a

! .hgtags



From john.coomes at sun.com  Thu Jul 30 22:41:35 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 31 Jul 2009 05:41:35 +0000
Subject: hg: jdk7/hotspot-gc/jaxws: 2 new changesets
Message-ID: <20090731054139.97267EDDB@hg.openjdk.java.net>

Changeset: faa13cd4d6cd
Author:    xdono
Date:      2009-07-28 12:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/faa13cd4d6cd

6862919: Update copyright year
Summary: Update copyright for files that have been modified in 2009, up to 07/09
Reviewed-by: tbell, ohair

! make/Makefile
! make/build.properties
! make/build.xml

Changeset: b70ce5b02bbc
Author:    xdono
Date:      2009-07-30 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/b70ce5b02bbc

Added tag jdk7-b67 for changeset faa13cd4d6cd

! .hgtags



From john.coomes at sun.com  Thu Jul 30 22:47:09 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 31 Jul 2009 05:47:09 +0000
Subject: hg: jdk7/hotspot-gc/jdk: 4 new changesets
Message-ID: <20090731054819.5488CEDE0@hg.openjdk.java.net>

Changeset: 8eddead6a701
Author:    yhuang
Date:      2009-07-02 20:17 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8eddead6a701

6606396: Notepad and Stylepad demos don't run in Japanese locale.
Reviewed-by: peytoia, ogino

! src/share/demo/jfc/Notepad/resources/Notepad_ja.properties

Changeset: d8ff2f23a8fc
Author:    yhuang
Date:      2009-07-26 19:51 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d8ff2f23a8fc

Merge


Changeset: a952aafd5181
Author:    xdono
Date:      2009-07-28 12:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a952aafd5181

6862919: Update copyright year
Summary: Update copyright for files that have been modified in 2009, up to 07/09
Reviewed-by: tbell, ohair

! make/common/Defs-linux.gmk
! make/common/Release.gmk
! make/common/shared/Defs-windows.gmk
! make/common/shared/Defs.gmk
! make/common/shared/Sanity.gmk
! make/java/redist/Makefile
! make/sun/Makefile
! src/share/classes/com/sun/jndi/toolkit/ctx/PartialCompositeContext.java
! src/share/classes/java/awt/Robot.java
! src/share/classes/java/awt/TrayIcon.java
! src/share/classes/java/awt/color/ICC_Profile.java
! src/share/classes/java/lang/Byte.java
! src/share/classes/java/lang/Integer.java
! src/share/classes/java/lang/Long.java
! src/share/classes/java/lang/Short.java
! src/share/classes/java/lang/System.java
! src/share/classes/javax/swing/DefaultDesktopManager.java
! src/share/classes/sun/net/www/http/HttpClient.java
! src/share/classes/sun/tools/jar/Main.java
! src/share/demo/jvmti/java_crw_demo/java_crw_demo.c
! src/solaris/classes/sun/awt/X11/XBaseWindow.java
! src/solaris/native/java/net/Inet4AddressImpl.c
! src/solaris/native/java/net/Inet6AddressImpl.c
! src/windows/native/java/lang/java_props_md.c
! test/demo/jvmti/hprof/HelloWorld.java
! test/demo/jvmti/hprof/StackMapTableTest.java
! test/java/awt/Window/OwnedWindowsLeak/OwnedWindowsLeak.java
! test/tools/jar/index/MetaInf.java

Changeset: 5c52dcbde260
Author:    xdono
Date:      2009-07-30 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5c52dcbde260

Added tag jdk7-b67 for changeset a952aafd5181

! .hgtags



From john.coomes at sun.com  Thu Jul 30 22:59:06 2009
From: john.coomes at sun.com (john.coomes at sun.com)
Date: Fri, 31 Jul 2009 05:59:06 +0000
Subject: hg: jdk7/hotspot-gc/langtools: 2 new changesets
Message-ID: <20090731055911.5EA35EDE5@hg.openjdk.java.net>

Changeset: 14b1a8ede954
Author:    xdono
Date:      2009-07-28 12:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/14b1a8ede954

6862919: Update copyright year
Summary: Update copyright for files that have been modified in 2009, up to 07/09
Reviewed-by: tbell, ohair

! src/share/classes/com/sun/tools/javac/code/TypeAnnotationPosition.java
! src/share/classes/com/sun/tools/javac/comp/Lower.java
! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java
! src/share/classes/com/sun/tools/javac/jvm/Code.java
! src/share/classes/com/sun/tools/javac/jvm/Gen.java
! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java
! src/share/classes/com/sun/tools/javac/resources/legacy.properties
! test/tools/javac/typeAnnotations/failures/OldArray.java

Changeset: 689bec60a482
Author:    xdono
Date:      2009-07-30 10:58 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/689bec60a482

Added tag jdk7-b67 for changeset 14b1a8ede954

! .hgtags



From Antonios.Printezis at sun.com  Fri Jul 31 09:04:54 2009
From: Antonios.Printezis at sun.com (Tony Printezis)
Date: Fri, 31 Jul 2009 12:04:54 -0400
Subject: Code Review Request: 6819085 G1: use larger and/or user settable
	region size
In-Reply-To: <10ffa8f60907302012u628325a7q682995927644d077@mail.gmail.com>
References: <4A720EE2.90404@sun.com>
	<10ffa8f60907302012u628325a7q682995927644d077@mail.gmail.com>
Message-ID: <4A731626.6050106@sun.com>

Vikram,

Hi. With testing we have done so far with 1G-4G heaps, 1m region size 
seemed to work well. However, We have been recently experimenting with 
24g-32g heaps and for that we've seen that larger region sizes are 
beneficial (in order to cut down the number of regions). Which is one of 
the reasons why I worked on this CR. Also note that, after the region 
size calculation you showed, I do bound the region size by 
MIN_REGION_SIZE and MAX_REGION_SIZE. So, the minimum region size, 
currently, will be 1m and in some cases ,we might use a larger one (up 
to currently 32m).

Tony

Vikram A wrote:
> hi Tony,
>
> Just thinking out loud here.
>
> You had once outlined  that we get most benefit with 1MB regions based
> on your testing.
>
>  in arguments.cpp
>
> +   uintx region_size = G1HeapRegionSize;
> +   if (FLAG_IS_DEFAULT(G1HeapRegionSize)) {
> +     // We base the automatic calculation on the min heap size. This
> +     // can be problematic if the spread between min and max is quite
> +     // wide, imagine -Xms128m -Xmx32g. But, if we decided it based on
> +     // the max size, the region size might be way too small for the
> +     // min size. Either way, some users might have to set the region
> +     // size manually for some -Xms / -Xmx combos.
> +     region_size = min_heap_size() / TARGET_REGION_NUMBER;
> +   }
>
> with this for many small application it seems to me that the region
> size is disturbed.
>
> eg. in the above doc. you mention
> -Xms128, consider the heap to be  and TARGET_REGION_NUMBER is defined as 2048.
> So, total heap will be
> 128 * 1024(K) = 131072K
> now dividing 131072K/2048 = 64K for each region.
>
> If this inpterpretation is right and there is a reason for doing it
> this way, aren't we losing the adv we gained with 1024K region.
> this seems like a very small region size and would induce frequent GC,
> although could be with small pause time.
>
> I would assume that many enterprise would run their java with larger
> heaps than this, but considering this is also for every one, should
> the 1024K region size be useful to keep by default while allowing this
> fix to modify it for advanced user.
>
> Like I said just my thoughts.
>
> regards,
> Vikram.
>
> On Fri, Jul 31, 2009 at 2:51 AM, Tony Printezis
> <Antonios.Printezis at sun.com> wrote:
>   
>> http://cr.openjdk.java.net/~tonyp/6819085/webrev.0/
>>
>> The idea is to allow the user to set the region size with a parameter (-XX:G1HeapRegionSize=N).
>>
>> Tony
>>
>> --
>> ----------------------------------------------------------------------
>> | Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
>> |                                   | MS BUR02-311                   |
>> | e-mail: tony.printezis at sun.com    | 35 Network Drive               |
>> | office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
>> ----------------------------------------------------------------------
>> e-mail client: Thunderbird (Solaris)
>>
>>
>>     

-- 
---------------------------------------------------------------------
| Tony Printezis, Staff Engineer   | Sun Microsystems Inc.          |
|                                  | MS UBUR02-311                  |
| e-mail: tony.printezis at sun.com   | 35 Network Drive               |
| office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA |
---------------------------------------------------------------------
e-mail client: Thunderbird (Linux)




From Vladimir.Kozlov at Sun.COM  Fri Jul 31 09:58:07 2009
From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov)
Date: Fri, 31 Jul 2009 09:58:07 -0700
Subject: for review (M): 6863023: need non-perm oops in code cache for JSR
	292
In-Reply-To: <A5E5CBED-3D90-47C7-BDE4-52FC4AD3CB9A@sun.com>
References: <01A90166-7F50-4218-B38A-345C7CA7ABF7@sun.com>
	<4A6D8B3D.6060704@Sun.COM>
	<A65EAC45-9173-4614-94D2-E9BBF8FCABE6@Sun.COM>
	<A5E5CBED-3D90-47C7-BDE4-52FC4AD3CB9A@sun.com>
Message-ID: <4A73229F.9090903@sun.com>

John,

I did not find anything alarming.

Could you rename non_perm_state_clean() to non_perm_not_marked()
or something otherwise the next code looks strange since
the non_perm_state is also used to flag "on list" state:

+     debug_only(cur->clear_non_perm_marked());
+     assert(cur->non_perm_state_clean(), "");
+     assert(cur->on_non_perm_list(), "else shouldn't be on this list");

In nmethod.hpp could you move enum above its usage and use it in
on_non_perm_list()?

Can you change the comment in parse3.cpp to next?:

     // cases:
     //   should_be_constant = (oop == null || oop in perm space || NonPermCodeRefs >= 2)
     //   has_encoding       = (should_be_constant || NonPermCodeRefs == 1)
     //

In globals.hpp it would be better to have "1: allow" on a separate line.

Thanks,
Vladimir

John Rose wrote:
> I have updated the webrev slightly, and fixed the URL:
>   http://cr.openjdk.java.net/~jrose/6863023/webrev.01/
> 
> Someone observed that the pruning logic might not be exercised, since 
> non-perms do not become perm.  But it does get exercised when nmethods 
> are deallocated.  (And that caused a bug I had to fix...)
> 
> -- John
> 
> On Jul 28, 2009, at 7:08 PM, John Rose wrote:
> 
>> On Jul 27, 2009, at 4:10 AM, Christian Thalinger wrote:
>>
>>> It seems there is a problem with returns:
>>
>> Right; it was an incomplete code change.  Thanks.  -- John
> 


From John.Coomes at sun.com  Fri Jul 31 12:08:31 2009
From: John.Coomes at sun.com (John Coomes)
Date: Fri, 31 Jul 2009 12:08:31 -0700
Subject: Request for review (s) - CR 6862534
In-Reply-To: <4A6E378E.3090103@sun.com>
References: <4A6E3163.8030301@sun.com>
	<4A6E378E.3090103@sun.com>
Message-ID: <19059.16687.729975.223046@sun.com>

Jon Masamitsu (Jon.Masamitsu at Sun.COM) wrote:
> Ok.  That cut-and-paste didn't come out well at all.  Here's
> the cleaned up/readable version.
> 
> 
> Jon Masamitsu wrote On 07/27/09 15:59,:
> 
> >6862534: -XX:NewRatio completely ignored when combined with
> >-XX:+UseConcMarkSweepGC
> >
> >With regard to the sizing of the young generation, restrict the cms
> >ergonomic setting (more tightly) to the case where neither NewRatio
> >nor MaxNewSize has been set on the command line. Also, if NewSize
> >has been set on the command line, use it.
> >
> >Guards in set_cms_and_parnew_gc_flags() that were
> >FLAG_IS_DEFAULT(MaxNewSize) or FLAG_IS_DEFAULT(NewRatio)
> >were changed to check both.
> >
> >http://cr.openjdk.java.net/~jmasa/6862534

Looks good, except for a couple of comment nits:

1062     // Sets MaxNewSize
1063 
1064     // Set MaxNewSize to our calculated ...

1087     // Sets NewRatio.  Potentially sets NewSize and OldSize
1088 
1089     FLAG_SET_ERGO(intx, NewRatio, MAX2(NewRatio, new_ratio));

1062 isn't needed.  1087 is confusing; how does setting NewRatio set
NewSize and/or Oldsize?

-John



From y.s.ramakrishna at sun.com  Fri Jul 31 15:37:01 2009
From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com)
Date: Fri, 31 Jul 2009 22:37:01 +0000
Subject: hg: jdk7/hotspot-gc/hotspot: 15 new changesets
Message-ID: <20090731223733.5A4DBEEAC@hg.openjdk.java.net>

Changeset: 57c71ad0341b
Author:    xdono
Date:      2009-07-16 10:53 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/57c71ad0341b

Added tag jdk7-b65 for changeset ba313800759b

! .hgtags

Changeset: 1c2487639400
Author:    trims
Date:      2009-07-24 16:40 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1c2487639400

Merge


Changeset: 3c0f72981560
Author:    trims
Date:      2009-07-24 16:41 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3c0f72981560

6864901: Bump the HS16 build number to 07
Summary: Update the HS16 build number to 07
Reviewed-by: jcoomes

! make/hotspot_version

Changeset: 96e4ccadd5f6
Author:    xdono
Date:      2009-07-24 13:39 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/96e4ccadd5f6

Added tag jdk7-b66 for changeset 57c71ad0341b

! .hgtags

Changeset: bd02caa94611
Author:    xdono
Date:      2009-07-28 12:12 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/bd02caa94611

6862919: Update copyright year
Summary: Update copyright for files that have been modified in 2009, up to 07/09
Reviewed-by: tbell, ohair

! agent/src/os/linux/Makefile
! agent/src/share/classes/sun/jvm/hotspot/HotSpotTypeDataBase.java
! agent/src/share/classes/sun/jvm/hotspot/code/DebugInfoReadStream.java
! agent/src/share/classes/sun/jvm/hotspot/code/MonitorValue.java
! agent/src/share/classes/sun/jvm/hotspot/code/ScopeDesc.java
! agent/src/share/classes/sun/jvm/hotspot/code/ScopeValue.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/Debugger.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/DebuggerBase.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/JVMDebugger.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebugger.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerClient.java
! agent/src/share/classes/sun/jvm/hotspot/debugger/remote/RemoteDebuggerServer.java
! agent/src/share/classes/sun/jvm/hotspot/jdi/ObjectReferenceImpl.java
! agent/src/share/classes/sun/jvm/hotspot/jdi/ThreadReferenceImpl.java
! agent/src/share/classes/sun/jvm/hotspot/memory/Universe.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/ClassConstants.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/CompiledVFrame.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/InterpretedVFrame.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/JavaThread.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/MonitorInfo.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/StackValue.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/StubRoutines.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/Thread.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/Threads.java
! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java
! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ByteCodeRewriter.java
! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassDump.java
! agent/src/share/classes/sun/jvm/hotspot/tools/jcore/ClassWriter.java
! agent/src/share/classes/sun/jvm/hotspot/ui/tree/OopTreeNodeAdapter.java
! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/JSJavaThread.java
! make/jprt.properties
! make/linux/makefiles/jsig.make
! make/linux/makefiles/saproc.make
! make/solaris/makefiles/optimized.make
! make/solaris/makefiles/sparcWorks.make
! make/windows/build_vm_def.sh
! make/windows/create.bat
! make/windows/get_msc_ver.sh
! make/windows/makefiles/adlc.make
! make/windows/makefiles/compile.make
! make/windows/makefiles/makedeps.make
! make/windows/makefiles/rules.make
! make/windows/makefiles/sa.make
! make/windows/makefiles/sanity.make
! make/windows/makefiles/vm.make
! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp
! src/cpu/sparc/vm/frame_sparc.inline.hpp
! src/cpu/sparc/vm/globals_sparc.hpp
! src/cpu/x86/vm/c1_MacroAssembler_x86.cpp
! src/cpu/x86/vm/frame_x86.cpp
! src/cpu/x86/vm/globals_x86.hpp
! src/cpu/x86/vm/interpreterRT_x86_64.cpp
! src/cpu/x86/vm/templateTable_x86_32.hpp
! src/cpu/x86/vm/templateTable_x86_64.cpp
! src/cpu/x86/vm/vtableStubs_x86_32.cpp
! src/cpu/x86/vm/vtableStubs_x86_64.cpp
! src/os/linux/vm/os_linux.hpp
! src/os/solaris/dtrace/generateJvmOffsets.cpp
! src/os/solaris/dtrace/jhelper.d
! src/os/solaris/dtrace/libjvm_db.c
! src/os_cpu/linux_sparc/vm/globals_linux_sparc.hpp
! src/os_cpu/linux_sparc/vm/os_linux_sparc.hpp
! src/os_cpu/linux_x86/vm/globals_linux_x86.hpp
! src/os_cpu/linux_x86/vm/orderAccess_linux_x86.inline.hpp
! src/os_cpu/solaris_sparc/vm/globals_solaris_sparc.hpp
! src/os_cpu/solaris_sparc/vm/orderAccess_solaris_sparc.inline.hpp
! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.cpp
! src/os_cpu/solaris_sparc/vm/os_solaris_sparc.hpp
! src/os_cpu/solaris_x86/vm/globals_solaris_x86.hpp
! src/os_cpu/solaris_x86/vm/orderAccess_solaris_x86.inline.hpp
! src/os_cpu/windows_x86/vm/globals_windows_x86.hpp
! src/os_cpu/windows_x86/vm/orderAccess_windows_x86.inline.hpp
! src/os_cpu/windows_x86/vm/os_windows_x86.cpp
! src/os_cpu/windows_x86/vm/os_windows_x86.hpp
! src/os_cpu/windows_x86/vm/unwind_windows_x86.hpp
! src/share/tools/MakeDeps/BuildConfig.java
! src/share/tools/MakeDeps/WinGammaPlatformVC7.java
! src/share/tools/MakeDeps/WinGammaPlatformVC8.java
! src/share/tools/MakeDeps/WinGammaPlatformVC9.java
! src/share/tools/hsdis/Makefile
! src/share/tools/hsdis/hsdis-demo.c
! src/share/tools/hsdis/hsdis.c
! src/share/vm/adlc/adlc.hpp
! src/share/vm/asm/assembler.cpp
! src/share/vm/c1/c1_Compilation.cpp
! src/share/vm/c1/c1_GraphBuilder.cpp
! src/share/vm/c1/c1_LinearScan.cpp
! src/share/vm/ci/bcEscapeAnalyzer.cpp
! src/share/vm/ci/ciEnv.cpp
! src/share/vm/ci/ciEnv.hpp
! src/share/vm/ci/ciMethodBlocks.cpp
! src/share/vm/ci/ciStreams.cpp
! src/share/vm/ci/ciStreams.hpp
! src/share/vm/ci/ciTypeFlow.cpp
! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/verifier.cpp
! src/share/vm/code/vtableStubs.cpp
! src/share/vm/compiler/compileBroker.cpp
! src/share/vm/gc_implementation/g1/collectionSetChooser.cpp
! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp
! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp
! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp
! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp
! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp
! src/share/vm/gc_implementation/g1/concurrentZFThread.hpp
! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp
! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp
! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp
! src/share/vm/gc_implementation/g1/ptrQueue.cpp
! src/share/vm/gc_implementation/g1/sparsePRT.cpp
! src/share/vm/gc_implementation/g1/vm_operations_g1.cpp
! src/share/vm/gc_implementation/g1/vm_operations_g1.hpp
! src/share/vm/gc_implementation/parNew/parGCAllocBuffer.hpp
! src/share/vm/gc_implementation/parallelScavenge/parMarkBitMap.hpp
! src/share/vm/gc_implementation/shared/concurrentGCThread.cpp
! src/share/vm/gc_implementation/shared/concurrentGCThread.hpp
! src/share/vm/gc_interface/gcCause.hpp
! src/share/vm/includeDB_compiler1
! src/share/vm/includeDB_jvmti
! src/share/vm/interpreter/bytecode.cpp
! src/share/vm/interpreter/bytecode.hpp
! src/share/vm/interpreter/bytecodeStream.hpp
! src/share/vm/interpreter/bytecodeTracer.cpp
! src/share/vm/interpreter/bytecodes.cpp
! src/share/vm/interpreter/bytecodes.hpp
! src/share/vm/interpreter/invocationCounter.cpp
! src/share/vm/interpreter/rewriter.hpp
! src/share/vm/interpreter/templateTable.cpp
! src/share/vm/interpreter/templateTable.hpp
! src/share/vm/memory/blockOffsetTable.hpp
! src/share/vm/memory/cardTableRS.cpp
! src/share/vm/memory/gcLocker.hpp
! src/share/vm/memory/heap.cpp
! src/share/vm/oops/cpCacheOop.cpp
! src/share/vm/oops/generateOopMap.cpp
! src/share/vm/oops/methodDataOop.cpp
! src/share/vm/opto/addnode.cpp
! src/share/vm/opto/block.hpp
! src/share/vm/opto/buildOopMap.cpp
! src/share/vm/opto/bytecodeInfo.cpp
! src/share/vm/opto/c2compiler.cpp
! src/share/vm/opto/callnode.cpp
! src/share/vm/opto/callnode.hpp
! src/share/vm/opto/coalesce.cpp
! src/share/vm/opto/connode.cpp
! src/share/vm/opto/doCall.cpp
! src/share/vm/opto/escape.cpp
! src/share/vm/opto/loopTransform.cpp
! src/share/vm/opto/loopopts.cpp
! src/share/vm/opto/machnode.cpp
! src/share/vm/opto/matcher.hpp
! src/share/vm/opto/output.cpp
! src/share/vm/opto/parse.hpp
! src/share/vm/opto/parse1.cpp
! src/share/vm/opto/parse2.cpp
! src/share/vm/opto/parse3.cpp
! src/share/vm/opto/parseHelper.cpp
! src/share/vm/opto/subnode.cpp
! src/share/vm/opto/superword.hpp
! src/share/vm/prims/jvm_misc.hpp
! src/share/vm/prims/jvmtiClassFileReconstituter.cpp
! src/share/vm/prims/jvmtiEnvBase.cpp
! src/share/vm/prims/methodComparator.cpp
! src/share/vm/runtime/biasedLocking.cpp
! src/share/vm/runtime/deoptimization.cpp
! src/share/vm/runtime/dtraceJSDT.cpp
! src/share/vm/runtime/frame.hpp
! src/share/vm/runtime/hpi.hpp
! src/share/vm/runtime/interfaceSupport.cpp
! src/share/vm/runtime/mutexLocker.cpp
! src/share/vm/runtime/mutexLocker.hpp
! src/share/vm/runtime/orderAccess.cpp
! src/share/vm/runtime/orderAccess.hpp
! src/share/vm/runtime/stackValue.cpp
! src/share/vm/runtime/stackValue.hpp
! src/share/vm/runtime/thread.cpp
! src/share/vm/runtime/thread.hpp
! src/share/vm/runtime/vframe.cpp
! src/share/vm/runtime/vframe.hpp
! src/share/vm/runtime/vframeArray.cpp
! src/share/vm/runtime/vframe_hp.cpp
! src/share/vm/runtime/virtualspace.cpp
! src/share/vm/runtime/virtualspace.hpp
! src/share/vm/runtime/vmStructs.cpp
! src/share/vm/runtime/vmThread.cpp
! src/share/vm/runtime/vm_operations.hpp
! src/share/vm/runtime/vm_version.cpp
! src/share/vm/utilities/bitMap.cpp
! src/share/vm/utilities/bitMap.hpp
! src/share/vm/utilities/bitMap.inline.hpp
! src/share/vm/utilities/exceptions.hpp
! src/share/vm/utilities/globalDefinitions_visCPP.hpp
! src/share/vm/utilities/macros.hpp
! test/compiler/6772683/InterruptedTest.java
! test/compiler/6832293/Test.java
! test/runtime/6819213/TestBootNativeLibraryPath.java

Changeset: 18f526145aea
Author:    trims
Date:      2009-07-29 16:00 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/18f526145aea

Merge

! src/share/vm/gc_implementation/g1/concurrentMark.cpp
! src/share/vm/gc_implementation/g1/g1RemSet.inline.hpp
! src/share/vm/gc_implementation/g1/heapRegion.cpp
! src/share/vm/opto/escape.cpp
! src/share/vm/opto/loopopts.cpp
! src/share/vm/opto/machnode.cpp
! src/share/vm/opto/output.cpp
! src/share/vm/runtime/stackValue.cpp

Changeset: 6a93908f268f
Author:    mchung
Date:      2009-07-10 11:10 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6a93908f268f

6857194: Add hotspot perf counters to aid class loading performance measurement
Summary: Add new jvmstat counters to measure detailed class loading time
Reviewed-by: acorn, kamg

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/classfile/classFileParser.hpp
! src/share/vm/classfile/classLoader.cpp
! src/share/vm/classfile/classLoader.hpp
! src/share/vm/classfile/systemDictionary.cpp
! src/share/vm/includeDB_core
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/prims/jvm.cpp
! src/share/vm/runtime/perfData.hpp
! src/share/vm/services/threadService.cpp
! src/share/vm/services/threadService.hpp

Changeset: 1413494da700
Author:    martin
Date:      2009-06-29 14:42 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1413494da700

6850957: Honor -XX:OnOutOfMemoryError when array size exceeds VM limit
Summary: call report_java_out_of_memory("Requested array size exceeds VM limit")
Reviewed-by: tbell, dholmes, alanb, ysr
Contributed-by: jeremymanson at google.com

! src/share/vm/oops/arrayKlass.cpp
! src/share/vm/oops/instanceKlass.cpp
! src/share/vm/oops/objArrayKlass.cpp
! src/share/vm/oops/typeArrayKlass.cpp

Changeset: 8c79517a9300
Author:    poonam
Date:      2009-07-16 18:21 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8c79517a9300

6840305: Discrepancy in system memory details (when 4G or greater) reported by JVM and Windows OS
Summary: GlobalMemoryStatus() does not report correct memory usage when the system has more than 4gb of RAM. GlobalMemoryStatusEx() should be used in place of GlobalMemoryStatus().
Reviewed-by: kamg, coleenp

! src/os/windows/vm/os_windows.cpp

Changeset: abe076e3636f
Author:    mchung
Date:      2009-07-27 09:06 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/abe076e3636f

6864003: Modify JVM_FindClassFromBootLoader to return null if class not found
Summary: JVM_FindClassFromBootLoader returns null if class not found
Reviewed-by: acorn, alanb, dholmes

! src/share/vm/prims/jvm.cpp
! src/share/vm/prims/jvm.h

Changeset: 494244ae0171
Author:    coleenp
Date:      2009-07-27 17:23 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/494244ae0171

Merge

! src/share/vm/classfile/classFileParser.cpp
! src/share/vm/includeDB_core
! src/share/vm/oops/objArrayKlass.cpp

Changeset: 2b4230d1e589
Author:    dcubed
Date:      2009-07-28 13:35 -0600
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/2b4230d1e589

6862295: JDWP threadid changes during debugging session (leading to ingored breakpoints)
Summary: Correctly count full GC operations for framework collectors. Add ForceFullGCJVMTIEpilogues as a future work around if needed.
Reviewed-by: jcoomes, alanb, ysr

! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/prims/jvmtiExport.cpp
! src/share/vm/runtime/globals.hpp

Changeset: 16c930df1e9b
Author:    dcubed
Date:      2009-07-28 13:50 -0600
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/16c930df1e9b

Merge

! src/share/vm/memory/genCollectedHeap.cpp
! src/share/vm/prims/jvmtiExport.cpp
! src/share/vm/runtime/globals.hpp

Changeset: 66b0f834a440
Author:    coleenp
Date:      2009-07-30 15:06 -0400
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/66b0f834a440

Merge

! src/share/vm/classfile/classLoader.cpp

Changeset: 7f807f55161a
Author:    ysr
Date:      2009-07-31 10:41 -0700
URL:       http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/7f807f55161a

Merge

! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp
! src/share/vm/gc_implementation/g1/dirtyCardQueue.cpp
! src/share/vm/runtime/globals.hpp