Code review request: 6866591: G1: print update buffer processing stats more often (XXS)

Tony Printezis Antonios.Printezis at sun.com
Thu Jul 30 09:06:58 PDT 2009


I have one review (thanks Jon!). Jon actually pointed out that the tiny 
formatting changes are not shown on the webrev, which is because webrev 
ignores white space differences. Here they are, in case you're wondering 
(just re-aligning a couple of backslashes):

@@ -34,7 +34,7 @@
   product(intx, G1ConfidencePercent, 
50,                                    \
           "Confidence level for MMU/pause 
predictions")                     \
                                                                             
\
-  develop(intx, G1MarkingOverheadPercent, 
0,                                   \
+  develop(intx, G1MarkingOverheadPercent, 
0,                                \
           "Overhead of concurrent 
marking")                                 \
                                                                             
\
   develop(bool, G1AccountConcurrentOverhead, 
false,                         \
@@ -47,7 +47,7 @@
   develop(bool, G1Gen, 
true,                                                \
           "If true, it will enable the generational 
G1")                    \
                                                                             
\
-  develop(intx, G1GCPercent, 
10,                                                \
+  develop(intx, G1GCPercent, 
10,                                            \
           "The desired percent time spent on 
GC")                           \
                                                                             
\
   develop(intx, G1PolicyVerbose, 
0,                                         \

Tony

Tony Printezis wrote:
> Hi,
>
> Could I get a couple of review for this one? Basically, I add 
> -XX:G1SummarizeRSetStatsPeriod=N which will generate update buffer 
> processing information more often. The web also includes two tiny 
> formatting changes in g1_globals.hpp.
>
> http://cr.openjdk.java.net/~tonyp/6866591/webrev.0/
>
> It's a trivial change.
>
> Tony
>

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)





More information about the hotspot-gc-dev mailing list