Request for review (s) - CR 6862534

John Coomes John.Coomes at sun.com
Fri Jul 31 12:08:31 PDT 2009


Jon Masamitsu (Jon.Masamitsu at Sun.COM) wrote:
> Ok.  That cut-and-paste didn't come out well at all.  Here's
> the cleaned up/readable version.
> 
> 
> Jon Masamitsu wrote On 07/27/09 15:59,:
> 
> >6862534: -XX:NewRatio completely ignored when combined with
> >-XX:+UseConcMarkSweepGC
> >
> >With regard to the sizing of the young generation, restrict the cms
> >ergonomic setting (more tightly) to the case where neither NewRatio
> >nor MaxNewSize has been set on the command line. Also, if NewSize
> >has been set on the command line, use it.
> >
> >Guards in set_cms_and_parnew_gc_flags() that were
> >FLAG_IS_DEFAULT(MaxNewSize) or FLAG_IS_DEFAULT(NewRatio)
> >were changed to check both.
> >
> >http://cr.openjdk.java.net/~jmasa/6862534

Looks good, except for a couple of comment nits:

1062     // Sets MaxNewSize
1063 
1064     // Set MaxNewSize to our calculated ...

1087     // Sets NewRatio.  Potentially sets NewSize and OldSize
1088 
1089     FLAG_SET_ERGO(intx, NewRatio, MAX2(NewRatio, new_ratio));

1062 isn't needed.  1087 is confusing; how does setting NewRatio set
NewSize and/or Oldsize?

-John




More information about the hotspot-gc-dev mailing list