Code Review Request: 6814467: G1: small fixes related to concurrent marking verboseness (XXXS)

Tony Printezis Antonios.Printezis at sun.com
Fri Mar 6 13:29:01 PST 2009


Hi,

Three tiny fixes that I packaged up together. Webrev is here:

http://cr.openjdk.java.net/~tonyp/6814467/webrev.00/

 From the CR:

This CR covers three very small fixes all of which cause some strangeness to the verbose GC output:

a) there's one occurence in concurrentMarkThread.cpp where tty is used, instead of gclog_or_tty, when printing verbose GC output

b) doConcurrentMark() was, for some reason, incorrectly called from checkConcurrentMark (this was causing the marking phase to be incorrectly woken up after a Full GC; no marking actually happened, but marking related verbose GC information was printed which was confusing)

c) some fields of ConcurrentMark (_has_aborted, _restart_for_overflow, _concurrent_marking_in_progress, and _should_gray_objects) were not initialised. In some cases, and in conjuction with b), this was causing the marking thread to output "[GC ocnurrent-mark-restart-for-overflow]" several times a second and was bloating the GC log.

Thanks,

Tony

-- 
----------------------------------------------------------------------
| Tony Printezis, Staff Engineer    | Sun Microsystems Inc.          |
|                                   | MS BUR02-311                   |
| e-mail: tony.printezis at sun.com    | 35 Network Drive               |
| office: +1 781 442 0998 (x20998)  | Burlington, MA01803-0902, USA  |
----------------------------------------------------------------------
e-mail client: Thunderbird (Solaris)





More information about the hotspot-gc-dev mailing list