From John.Cuthbertson at Sun.COM Thu Oct 1 11:29:34 2009 From: John.Cuthbertson at Sun.COM (john cuthbertson - Sun Microsystems) Date: Thu, 01 Oct 2009 11:29:34 -0700 Subject: Please Review (XXXS): Fix for 6887186: G1: Incorrect code generated for G1 pre-barrier by C1 on SPARC Message-ID: <4AC4F50E.4030100@sun.com> Hi Everyone, Can I have a couple of volunteers review the changes for this CR? The webrev can be found at http://cr.openjdk.java.net/~johnc/6887186/webrev.0/. The issue is that the wrong C1 operand was passed to the generator of the G1 pre-barrier code for the Unsafe.CompareAndSwap intrinsic. The old code was passing the operand representing the base object rather than that representing the address of the object.field that was passed to the CAS. This caused the G1 pre-barrier code to store a mark word in the SATB buffer rather than the previous contents of object.field. Thanks, JohnC From Thomas.Rodriguez at Sun.COM Thu Oct 1 12:31:43 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Thu, 01 Oct 2009 12:31:43 -0700 Subject: Please Review (XXXS): Fix for 6887186: G1: Incorrect code generated for G1 pre-barrier by C1 on SPARC In-Reply-To: <4AC4F50E.4030100@sun.com> References: <4AC4F50E.4030100@sun.com> Message-ID: That looks good. tom On Oct 1, 2009, at 11:29 AM, john cuthbertson - Sun Microsystems wrote: > Hi Everyone, > > Can I have a couple of volunteers review the changes for this CR? > The webrev can be found at http://cr.openjdk.java.net/~johnc/6887186/webrev.0/ > . > > The issue is that the wrong C1 operand was passed to the generator > of the G1 pre-barrier code for the Unsafe.CompareAndSwap intrinsic. > The old code was passing the operand representing the base object > rather than that representing the address of the object.field that > was passed to the CAS. This caused the G1 pre-barrier code to store > a mark word in the SATB buffer rather than the previous contents of > object.field. > > Thanks, > > JohnC From john.cuthbertson at sun.com Thu Oct 1 21:47:56 2009 From: john.cuthbertson at sun.com (john.cuthbertson at sun.com) Date: Fri, 02 Oct 2009 04:47:56 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6887186: G1: Incorrect code generated for G1 pre-barrier by C1 on SPARC Message-ID: <20091002044802.12E0A4181F@hg.openjdk.java.net> Changeset: a0107ba3bc53 Author: johnc Date: 2009-10-01 15:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a0107ba3bc53 6887186: G1: Incorrect code generated for G1 pre-barrier by C1 on SPARC Summary: Modify operand passed to C1 pre-barrier to be the operand representing the address of the object field that is being stored. Reviewed-by: never ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp From Jon.Masamitsu at Sun.COM Fri Oct 2 10:19:50 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Fri, 02 Oct 2009 10:19:50 -0700 Subject: Default performance on Sun T5440 In-Reply-To: <0FCC438D62A5E643AA3F57D3417B220D0AABB213@TORMAIL.algorithmics.com> References: <0FCC438D62A5E643AA3F57D3417B220D0AABB213@TORMAIL.algorithmics.com> Message-ID: <4AC63636.5080609@sun.com> Jeff, The default number of GC threads was changed to be fewer in jdk6u14 (same change in jdk7). I'm guessing you're using an older jdk? The number of GC threads depends on the number of cores on the platform. I think on the T5440 the number will be about 3/16 * 256 or 48. Jon jeff.lloyd at algorithmics.com wrote On 10/02/09 08:23,: > Hi, > > I just ran my application on a new box from Sun and found immediate > debilitating java performance by default. > > System Configuration: Sun Microsystems sun4v T5440 > > Memory size: 65248 Megabytes > > ================================ Virtual CPUs > ================================ > > CPU ID Frequency Implementation Status > > ------ --------- ---------------------- ------- > > 0 1164 MHz SUNW,UltraSPARC-T2+ on-line > > 1 1164 MHz SUNW,UltraSPARC-T2+ on-line > > ? > > 254 1164 MHz SUNW,UltraSPARC-T2+ on-line > > 255 1164 MHz SUNW,UltraSPARC-T2+ on-line > > four UltraSPARC T2 Plus processors per system, 256 threads; 1.2 GHz > > The default java behaviour is to use all 256 virtual processors for > garbage collection, and even for small ParNew collections the system > was being hammered. The cpu load reported by prstat was 150 during > too-frequent and long-running YG garbage collections. I had to specify > -XX:ParallelGCThreads=8 to bring the gc under control. > > I just wanted to let you know that the default gc behaviour for Sun?s > JVM on Sun?s hardware produces undesirable results. I don?t think most > people will know how to diagnose or fix this problem. > > Jeff > > ------------------------------------------------------------------------ > This email and any files transmitted with it are confidential and > proprietary to Algorithmics Incorporated and its affiliates > ("Algorithmics"). If received in error, use is prohibited. Please > destroy, and notify sender. Sender does not waive confidentiality or > privilege. Internet communications cannot be guaranteed to be timely, > secure, error or virus-free. Algorithmics does not accept liability > for any errors or omissions. Any commitment intended to bind > Algorithmics must be reduced to writing and signed by an authorized > signatory. > ------------------------------------------------------------------------ > >------------------------------------------------------------------------ > >_______________________________________________ >hotspot-gc-use mailing list >hotspot-gc-use at openjdk.java.net >http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use > > _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From Jon.Masamitsu at Sun.COM Fri Oct 2 10:40:03 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Fri, 02 Oct 2009 10:40:03 -0700 Subject: Default performance on Sun T5440 In-Reply-To: <4AC63636.5080609@sun.com> References: <0FCC438D62A5E643AA3F57D3417B220D0AABB213@TORMAIL.algorithmics.com> <4AC63636.5080609@sun.com> Message-ID: <4AC63AF3.6050100@sun.com> Jon Masamitsu wrote On 10/02/09 10:19,: >Jeff, > >The default number of GC threads was changed to be fewer in >jdk6u14 (same change in jdk7). I'm guessing you're using >an older jdk? The number of GC threads depends on the >number of cores on the platform. I think on the T5440 the > > ^^^^^^^^^^^^ cores should be strands >number will be about 3/16 * 256 or 48. > > This is still correct. _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From Jon.Masamitsu at Sun.COM Fri Oct 2 11:14:11 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Fri, 02 Oct 2009 11:14:11 -0700 Subject: Default performance on Sun T5440 In-Reply-To: <0FCC438D62A5E643AA3F57D3417B220D0AABB3B0@TORMAIL.algorithmics.com> References: <0FCC438D62A5E643AA3F57D3417B220D0AABB213@TORMAIL.algorithmics.com> <4AC63636.5080609@sun.com> <4AC63AF3.6050100@sun.com> <0FCC438D62A5E643AA3F57D3417B220D0AABB3B0@TORMAIL.algorithmics.com> Message-ID: <4AC642F3.2020402@sun.com> Jeff, This might be something different. First what jdk are you using? What's you command line? If you are using CMS, can you try a run with -XX:-UseParNewGC? If not using CMS, can you try -XX:+UseSerialGC (assuming you're using jdk5 or later). Jon jeff.lloyd at algorithmics.com wrote On 10/02/09 10:56,: >Hi John, > >Thanks for responding. However I just want to show you a simple gc >without manually setting the number of gc cpus: > >178.427: [GC 178.427: [ParNew: 471872K->52416K(471872K), 18.8885468 >secs] 1054705K->756342K(12530496K), 18.8895357 secs] [Times: user=740.49 >sys=15.54, real=18.89 secs] > >Compared to a similar gc when I set the max parallel cpus to 8: > >170.531: [GC 170.532: [ParNew: 118014K->13056K(118016K), 0.1646787 secs] >863713K->771012K(12569856K), 0.1651373 secs] [Times: user=0.76 sys=0.05, >real=0.17 secs] > >I apologize it isn't totally apples-to-apples because I reduced the YG >from 512M to 128M, but look at the difference in "user" time. After >5-10 minutes of uptime my application was reporting 135 minutes of cpu >time with the default settings. > >I'm not sure if this is helpful to you or the appropriate place to >provide feedback, but this is what people are going to be seeing if they >don't understand gc details. > >Jeff > >-----Original Message----- >From: Jon.Masamitsu at Sun.COM [mailto:Jon.Masamitsu at Sun.COM] >Sent: Friday, October 02, 2009 1:40 PM >To: Jon Masamitsu >Cc: Jeff Lloyd; hotspot-gc-use at openjdk.java.net >Subject: Re: Default performance on Sun T5440 > >Jon Masamitsu wrote On 10/02/09 10:19,: > > > >>Jeff, >> >>The default number of GC threads was changed to be fewer in >>jdk6u14 (same change in jdk7). I'm guessing you're using >>an older jdk? The number of GC threads depends on the >>number of cores on the platform. I think on the T5440 the >> >> >> >> >^^^^^^^^^^^^ cores should be strands > > > >>number will be about 3/16 * 256 or 48. >> >> >> >> > >This is still correct. > > > >-------------------------------------------------------------------------- >This email and any files transmitted with it are confidential and proprietary to Algorithmics Incorporated and its affiliates ("Algorithmics"). If received in error, use is prohibited. Please destroy, and notify sender. Sender does not waive confidentiality or privilege. Internet communications cannot be guaranteed to be timely, secure, error or virus-free. Algorithmics does not accept liability for any errors or omissions. Any commitment intended to bind Algorithmics must be reduced to writing and signed by an authorized signatory. >-------------------------------------------------------------------------- > > _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From Jon.Masamitsu at Sun.COM Fri Oct 2 12:28:27 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Fri, 02 Oct 2009 12:28:27 -0700 Subject: Default performance on Sun T5440 In-Reply-To: <0FCC438D62A5E643AA3F57D3417B220D0AABB40D@TORMAIL.algorithmics.com> References: <0FCC438D62A5E643AA3F57D3417B220D0AABB213@TORMAIL.algorithmics.com> <4AC63636.5080609@sun.com> <4AC63AF3.6050100@sun.com> <0FCC438D62A5E643AA3F57D3417B220D0AABB3B0@TORMAIL.algorithmics.com> <4AC642F3.2020402@sun.com> <0FCC438D62A5E643AA3F57D3417B220D0AABB40D@TORMAIL.algorithmics.com> Message-ID: <4AC6545B.4050103@sun.com> Jeff, When I can get access to a T5440 I'll do some experiments. Do you have a benchmark you can give us? Jon jeff.lloyd at algorithmics.com wrote On 10/02/09 11:37,: >Hi Jon, > >I'm using 1.6.0_16. I can solve it by reducing the number of parallel >threads for ParNew or using serial new collection - that's ok. > >I just wanted to raise this as a usability issue because I'm a developer >and this issue came to me from the field. I'm concerned that few people >in the field understand java/gc enough to fix or even recognize such an >issue. And this is the default jvm behaviour on the new multithreaded >servers (though the default is pure parallel gc instead of cms OG - >probably the same problem). > >So, I don't have a problem right now, but I may have more in the future >because our app is supported on many platforms and now the default >number of gc threads won't work well for clients running the Sun JVM on >particular Sun servers. Maybe 3/16 is too high? > >Jeff > >-----Original Message----- >From: Jon.Masamitsu at Sun.COM [mailto:Jon.Masamitsu at Sun.COM] >Sent: Friday, October 02, 2009 2:14 PM >To: Jeff Lloyd >Cc: hotspot-gc-use at openjdk.java.net >Subject: Re: Default performance on Sun T5440 > >Jeff, > >This might be something different. First what jdk are you using? >What's you command line? If you are using CMS, can you >try a run with -XX:-UseParNewGC? If not using CMS, can >you try -XX:+UseSerialGC (assuming you're using jdk5 or >later). > >Jon > >jeff.lloyd at algorithmics.com wrote On 10/02/09 10:56,: > > > >>Hi John, >> >>Thanks for responding. However I just want to show you a simple gc >>without manually setting the number of gc cpus: >> >>178.427: [GC 178.427: [ParNew: 471872K->52416K(471872K), 18.8885468 >>secs] 1054705K->756342K(12530496K), 18.8895357 secs] [Times: >> >> >user=740.49 > > >>sys=15.54, real=18.89 secs] >> >>Compared to a similar gc when I set the max parallel cpus to 8: >> >>170.531: [GC 170.532: [ParNew: 118014K->13056K(118016K), 0.1646787 >> >> >secs] > > >>863713K->771012K(12569856K), 0.1651373 secs] [Times: user=0.76 >> >> >sys=0.05, > > >>real=0.17 secs] >> >>I apologize it isn't totally apples-to-apples because I reduced the YG >> >> >>from 512M to 128M, but look at the difference in "user" time. After > > >>5-10 minutes of uptime my application was reporting 135 minutes of cpu >>time with the default settings. >> >>I'm not sure if this is helpful to you or the appropriate place to >>provide feedback, but this is what people are going to be seeing if >> >> >they > > >>don't understand gc details. >> >>Jeff >> >>-----Original Message----- >>From: Jon.Masamitsu at Sun.COM [mailto:Jon.Masamitsu at Sun.COM] >>Sent: Friday, October 02, 2009 1:40 PM >>To: Jon Masamitsu >>Cc: Jeff Lloyd; hotspot-gc-use at openjdk.java.net >>Subject: Re: Default performance on Sun T5440 >> >>Jon Masamitsu wrote On 10/02/09 10:19,: >> >> >> >> >> >>>Jeff, >>> >>>The default number of GC threads was changed to be fewer in >>>jdk6u14 (same change in jdk7). I'm guessing you're using >>>an older jdk? The number of GC threads depends on the >>>number of cores on the platform. I think on the T5440 the >>> >>> >>> >>> >>> >>> >>^^^^^^^^^^^^ cores should be strands >> >> >> >> >> >>>number will be about 3/16 * 256 or 48. >>> >>> >>> >>> >>> >>> >>This is still correct. >> >> >> >>----------------------------------------------------------------------- >> >> >--- > > >>This email and any files transmitted with it are confidential and >> >> >proprietary to Algorithmics Incorporated and its affiliates >("Algorithmics"). If received in error, use is prohibited. Please >destroy, and notify sender. Sender does not waive confidentiality or >privilege. Internet communications cannot be guaranteed to be timely, >secure, error or virus-free. Algorithmics does not accept liability for >any errors or omissions. Any commitment intended to bind Algorithmics >must be reduced to writing and signed by an authorized signatory. > > >>----------------------------------------------------------------------- >> >> >--- > > >> >> >> >> > > > >-------------------------------------------------------------------------- >This email and any files transmitted with it are confidential and proprietary to Algorithmics Incorporated and its affiliates ("Algorithmics"). If received in error, use is prohibited. Please destroy, and notify sender. Sender does not waive confidentiality or privilege. Internet communications cannot be guaranteed to be timely, secure, error or virus-free. Algorithmics does not accept liability for any errors or omissions. Any commitment intended to bind Algorithmics must be reduced to writing and signed by an authorized signatory. >-------------------------------------------------------------------------- > > _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From Jon.Masamitsu at Sun.COM Fri Oct 2 13:32:36 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Fri, 02 Oct 2009 13:32:36 -0700 Subject: Default performance on Sun T5440 In-Reply-To: <4AC6545B.4050103@sun.com> References: <0FCC438D62A5E643AA3F57D3417B220D0AABB213@TORMAIL.algorithmics.com> <4AC63636.5080609@sun.com> <4AC63AF3.6050100@sun.com> <0FCC438D62A5E643AA3F57D3417B220D0AABB3B0@TORMAIL.algorithmics.com> <4AC642F3.2020402@sun.com> <0FCC438D62A5E643AA3F57D3417B220D0AABB40D@TORMAIL.algorithmics.com> <4AC6545B.4050103@sun.com> Message-ID: <4AC66364.7090000@sun.com> Jeff, This is what I see running one of our benchmarks with a 1g heap on a T5440. UseSerialGC 81.908: [GC 81.908: [DefNew: 279616K->34943K(314560K), 1.6078835 secs] 464333K->241833K(1013632K), 1.6080676 secs] [Times: user=1.61 sys=0.00, real=1.61 secs] UseParNewGC with default number of GC threads (85). My appologies but I had the wrong fraction in my earlier mail. Not 3/16 but 5/16. Default number of GC threads is approximately number of strands * 5/16. 49.001: [GC 49.001: [ParNew: 314558K->34942K(314560K), 0.1807405 secs] 601002K->350442K(1013632K), 0.1809190 secs] [Times: user=14.67 sys=0.02, real=0.18 secs] UseParNewGC with 8 GC threads 51.140: [GC 51.141: [ParNew: 279616K->34943K(314560K), 0.3261322 secs] 464428K->242091K(1013632K), 0.3262756 secs] [Times: user=2.60 sys=0.00, real=0.33 secs] I arbitrarily took the last minor collection in each run. Yes, between 85 GC threads and 8 GC threads we're doing lots more work (user time) for not that much gain in GC pause (less than a factor of two). We're addressing that problem with CR 6593758 which will be smarter about the number of GC threads (use factors such as heap size and Java threads to figure out a better number of GC threads). But I don't see the egregious increase in pause times that you're seeing. 18.8885468 (default number of GC threads) secs vs. 0.1646787 (with 8 GC threads) So something more is in play. Jon Jon Masamitsu wrote On 10/02/09 12:28,: >Jeff, > >When I can get access to a T5440 I'll do some experiments. >Do you have a benchmark you can give us? > >Jon > >jeff.lloyd at algorithmics.com wrote On 10/02/09 11:37,: > > > >>Hi Jon, >> >>I'm using 1.6.0_16. I can solve it by reducing the number of parallel >>threads for ParNew or using serial new collection - that's ok. >> >>I just wanted to raise this as a usability issue because I'm a developer >>and this issue came to me from the field. I'm concerned that few people >>in the field understand java/gc enough to fix or even recognize such an >>issue. And this is the default jvm behaviour on the new multithreaded >>servers (though the default is pure parallel gc instead of cms OG - >>probably the same problem). >> >>So, I don't have a problem right now, but I may have more in the future >>because our app is supported on many platforms and now the default >>number of gc threads won't work well for clients running the Sun JVM on >>particular Sun servers. Maybe 3/16 is too high? >> >>Jeff >> >>-----Original Message----- >>From: Jon.Masamitsu at Sun.COM [mailto:Jon.Masamitsu at Sun.COM] >>Sent: Friday, October 02, 2009 2:14 PM >>To: Jeff Lloyd >>Cc: hotspot-gc-use at openjdk.java.net >>Subject: Re: Default performance on Sun T5440 >> >>Jeff, >> >>This might be something different. First what jdk are you using? >>What's you command line? If you are using CMS, can you >>try a run with -XX:-UseParNewGC? If not using CMS, can >>you try -XX:+UseSerialGC (assuming you're using jdk5 or >>later). >> >>Jon >> >>jeff.lloyd at algorithmics.com wrote On 10/02/09 10:56,: >> >> >> >> >> >>>Hi John, >>> >>>Thanks for responding. However I just want to show you a simple gc >>>without manually setting the number of gc cpus: >>> >>>178.427: [GC 178.427: [ParNew: 471872K->52416K(471872K), 18.8885468 >>>secs] 1054705K->756342K(12530496K), 18.8895357 secs] [Times: >>> >>> >>> >>> >>user=740.49 >> >> >> >> >>>sys=15.54, real=18.89 secs] >>> >>>Compared to a similar gc when I set the max parallel cpus to 8: >>> >>>170.531: [GC 170.532: [ParNew: 118014K->13056K(118016K), 0.1646787 >>> >>> >>> >>> >>secs] >> >> >> >> >>>863713K->771012K(12569856K), 0.1651373 secs] [Times: user=0.76 >>> >>> >>> >>> >>sys=0.05, >> >> >> >> >>>real=0.17 secs] >>> >>>I apologize it isn't totally apples-to-apples because I reduced the YG >>> >>> >>> >>> >>>from 512M to 128M, but look at the difference in "user" time. After >> >> >> >> >>>5-10 minutes of uptime my application was reporting 135 minutes of cpu >>>time with the default settings. >>> >>>I'm not sure if this is helpful to you or the appropriate place to >>>provide feedback, but this is what people are going to be seeing if >>> >>> >>> >>> >>they >> >> >> >> >>>don't understand gc details. >>> >>>Jeff >>> >>>-----Original Message----- >>>From: Jon.Masamitsu at Sun.COM [mailto:Jon.Masamitsu at Sun.COM] >>>Sent: Friday, October 02, 2009 1:40 PM >>>To: Jon Masamitsu >>>Cc: Jeff Lloyd; hotspot-gc-use at openjdk.java.net >>>Subject: Re: Default performance on Sun T5440 >>> >>>Jon Masamitsu wrote On 10/02/09 10:19,: >>> >>> >>> >>> >>> >>> >>> >>>>Jeff, >>>> >>>>The default number of GC threads was changed to be fewer in >>>>jdk6u14 (same change in jdk7). I'm guessing you're using >>>>an older jdk? The number of GC threads depends on the >>>>number of cores on the platform. I think on the T5440 the >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>^^^^^^^^^^^^ cores should be strands >>> >>> >>> >>> >>> >>> >>> >>>>number will be about 3/16 * 256 or 48. >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>This is still correct. >>> >>> >>> >>>----------------------------------------------------------------------- >>> >>> >>> >>> >>--- >> >> >> >> >>>This email and any files transmitted with it are confidential and >>> >>> >>> >>> >>proprietary to Algorithmics Incorporated and its affiliates >>("Algorithmics"). If received in error, use is prohibited. Please >>destroy, and notify sender. Sender does not waive confidentiality or >>privilege. Internet communications cannot be guaranteed to be timely, >>secure, error or virus-free. Algorithmics does not accept liability for >>any errors or omissions. Any commitment intended to bind Algorithmics >>must be reduced to writing and signed by an authorized signatory. >> >> >> >> >>>----------------------------------------------------------------------- >>> >>> >>> >>> >>--- >> >> >> >> >>> >>> >>> >>> >> >>-------------------------------------------------------------------------- >>This email and any files transmitted with it are confidential and proprietary to Algorithmics Incorporated and its affiliates ("Algorithmics"). If received in error, use is prohibited. Please destroy, and notify sender. Sender does not waive confidentiality or privilege. Internet communications cannot be guaranteed to be timely, secure, error or virus-free. Algorithmics does not accept liability for any errors or omissions. Any commitment intended to bind Algorithmics must be reduced to writing and signed by an authorized signatory. >>-------------------------------------------------------------------------- >> >> >> >> > >_______________________________________________ >hotspot-gc-use mailing list >hotspot-gc-use at openjdk.java.net >http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use > > _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From tony.printezis at sun.com Fri Oct 2 13:57:51 2009 From: tony.printezis at sun.com (Tony Printezis) Date: Fri, 02 Oct 2009 16:57:51 -0400 Subject: CRR: 6882730: G1: parallel heap verification messes up region dump In-Reply-To: <4ABCFDC0.8080207@sun.com> References: <4ABCFDC0.8080207@sun.com> Message-ID: <4AC6694F.8020100@sun.com> Thanks to John Cuthbertson for the code review. I have a new webrev that includes a small fix that John recommended: http://cr.openjdk.java.net/~tonyp/6882730/webrev.1/ I'd like one more code review if possible. Thanks! Tony Tony Printezis wrote: > The webrev is here: > > http://cr.openjdk.java.net/~tonyp/6882730/webrev.0/ > > In the fix, I just propagate the fact that heap verification failed > all the way to the top-level ::verify call and dump the heap there, > where it is guaranteed to be single-threaded. I also added a couple of > cosmetic changes to the heap dump. > > Tony > -- --------------------------------------------------------------------- | Tony Printezis, Staff Engineer | Sun Microsystems Inc. | | | MS UBUR02-311 | | e-mail: tony.printezis at sun.com | 35 Network Drive | | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA | --------------------------------------------------------------------- e-mail client: Thunderbird (Linux) From John.Coomes at sun.com Sat Oct 3 00:06:19 2009 From: John.Coomes at sun.com (John Coomes) Date: Sat, 3 Oct 2009 00:06:19 -0700 Subject: review request (XXS) - 6887948 bigobj.java timeout Message-ID: <19142.63467.784848.388135@sun.com> 6887948: test/gc/6845368/bigobj.java fails due to timeout The test times out on slow machines because javac can take a 6+ minutes to compile it; add a timeout to the test. I also filed a low priority perf bug against javac. diff -r 1af62b6ca0f9 -r 947b1de8e798 test/gc/6845368/bigobj.java --- a/test/gc/6845368/bigobj.java Fri Sep 25 04:39:54 2009 -0700 +++ b/test/gc/6845368/bigobj.java Thu Oct 01 18:58:42 2009 -0700 @@ -3,7 +3,7 @@ @bug 6845368 @summary ensure gc updates references > 64K bytes from the start of the obj @author John Coomes - @run main/othervm -Xmx64m bigobj + @run main/othervm/timeout=720 -Xmx64m bigobj */ // Allocate an object with a block of reference fields that starts more -John From tony.printezis at sun.com Sat Oct 3 07:10:43 2009 From: tony.printezis at sun.com (Tony Printezis) Date: Sat, 03 Oct 2009 10:10:43 -0400 Subject: CRR: 6847956: G1: crash in oopDesc*G1ParCopyHelper::copy_to_survivor_space(oopDesc*) Message-ID: <4AC75B63.1090204@sun.com> The CR has a detailed explanation of why marking can be incomplete when survivor spaces are enabled. The fix is straightforward: http://cr.openjdk.java.net/~tonyp/6847956/webrev.0/ The test case that would fail within 30-40 mins, ran for over 12 hours. I'll do more testing just in case, but I thought I'd open this for code review to get it ready for push asap. Tony From atilla.demirel at turkcell.com.tr Sat Oct 3 12:40:41 2009 From: atilla.demirel at turkcell.com.tr (atilla.demirel at turkcell.com.tr) Date: Sat, 3 Oct 2009 22:40:41 +0300 Subject: very very slow starting up on Solaris T5240 Message-ID: <069B728771D6134C9ECEB525D929B07C0338B5FF1B@EXVMBX2.turkcell.entp.tgc> Hi everybody, i send a first mail to group, we have a start-up problem. we have huge number of Solaris Servers. Sun v490&890 is normal for staring up . New generation Sun T5240 is extremly good for CPU& MEM. - but our WeblogicServer application server is very very slow starting up on Solaris T5240. ~1hour. Why could it be ? Regards from Turkey, We are using these args: 24575: /turkcell/extusr/jdk519/bin/java -Dweblogic.Name=EXT-WLS10-PROD-MAN1-M1-3 -serv argv[0]: /turkcell/extusr/jdk519/bin/java argv[1]: -Dweblogic.Name=EXT-WLS10-PROD-MAN1-M1-3 argv[2]: -server argv[3]: -Xms1792m argv[4]: -Xmx1792m argv[5]: -Xss128k argv[6]: -Xmn510m argv[7]: -XX:SurvivorRatio=4 argv[8]: -XX:+UseParNewGC argv[9]: -XX:+UseConcMarkSweepGC argv[10]: -XX:+CMSClassUnloadingEnabled argv[11]: -XX:PermSize=512m argv[12]: -XX:MaxPermSize=512m argv[13]: -verbosegc argv[14]: -XX:+PrintGCTimeStamps argv[15]: -XX:+PrintGCDetails argv[16]: -XX:+PrintTenuringDistribution argv[17]: -XX:+PrintHeapAtGC argv[18]: -Xloggc:/turkcell/extusr/wlserver10/wlserver_10.0/domains/EXT-WLS10-PROD-DMN/logs/MAN1-3gc.logs argv[19]: -Xcheck:jni argv[20]: -Djavax.net.ssl.trustStore=/usr/jdk/jdk160_05/jre/lib/security/cacerts argv[21]: -Dweblogic.configuration.schemaValidationEnabled=false argv[22]: -DPosnetLogDir=/data/beawllog argv[23]: -Dweblogic.management.username=**** argv[24]: -Dweblogic.management.password=*** argv[25]: -Dweblogic.management.server=https://***:** argv[26]: -Dweblogic.security.SSL.ignoreHostnameVerification=true argv[27]: -Djava.security.policy=/turkcell/extusr/wlserver10/wlserver_10.0/server/lib/weblogic.policy argv[28]: -DEnv=PROD argv[29]: -DHostName_WLSName=trafalgar-MAN1-M1-3 argv[30]: -Dweblogic.webservice.i18n.charset=ISO-8859-9 argv[31]: -Dfile.encoding=ISO-8859-9 argv[32]: -Dorg.apache.xerces.xni.parser.XMLParserConfiguration=org.apache.xerces.parsers.XIncludeAwareParserConfiguration argv[33]: weblogic.Server little begin- Gc out 156.793: [GC {Heap before gc invocations=0: par new generation total 435200K, used 348160K [0x63c00000, 0x83a00000, 0x83a00000) eden space 348160K, 100% used [0x63c00000, 0x79000000, 0x79000000) from space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) to space 87040K, 0% used [0x7e500000, 0x7e500000, 0x83a00000) concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, 0xd3c00000, 0xd3c00000) concurrent-mark-sweep perm gen total 524288K, used 24076K [0xd3c00000, 0xf3c00000, 0xf3c00000) 156.794: [ParNew Desired survivor size 44564480 bytes, new threshold 15 (max 15) - age 1: 15784840 bytes, 15784840 total - age 2: 10944 bytes, 15795784 total : 348160K->15709K(435200K), 0.2141873 secs] 348160K->15709K(1747968K)Heap after gc invocations=1: par new generation total 435200K, used 15709K [0x63c00000, 0x83a00000, 0x83a00000) eden space 348160K, 0% used [0x63c00000, 0x63c00000, 0x79000000) from space 87040K, 18% used [0x7e500000, 0x7f4577a8, 0x83a00000) to space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, 0xd3c00000, 0xd3c00000) concurrent-mark-sweep perm gen total 524288K, used 24076K [0xd3c00000, 0xf3c00000, 0xf3c00000) } , 0.2152029 secs] 189.791: [GC {Heap before gc invocations=1: par new generation total 435200K, used 363869K [0x63c00000, 0x83a00000, 0x83a00000) eden space 348160K, 100% used [0x63c00000, 0x79000000, 0x79000000) from space 87040K, 18% used [0x7e500000, 0x7f4577a8, 0x83a00000) to space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, 0xd3c00000, 0xd3c00000) ************************************************************************ Bu elektronik posta ve onunla iletilen butun dosyalar sadece gondericisi tarafindan almasi amaclanan yetkili gercek ya da tuzel kisinin kullanimi icindir. Eger soz konusu yetkili alici degilseniz bu elektronik postanin icerigini aciklamaniz, kopyalamaniz, yonlendirmeniz ve kullanmaniz kesinlikle yasaktir ve bu elektronik postayi derhal silmeniz gerekmektedir. TURKCELL bu mesajin icerdigi bilgilerin dogrulugu veya eksiksiz oldugu konusunda herhangi bir garanti vermemektedir. Bu nedenle bu bilgilerin ne sekilde olursa olsun iceriginden, iletilmesinden, alinmasindan ve saklanmasindan sorumlu degildir. Bu mesajdaki gorusler yalnizca gonderen kisiye aittir ve TURKCELLin goruslerini yansitmayabilir Bu e-posta bilinen butun bilgisayar viruslerine karsi taranmistir. ************************************************************************ This e-mail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient you are hereby notified that any dissemination, forwarding, copying or use of any of the information is strictly prohibited, and the e-mail should immediately be deleted. TURKCELL makes no warranty as to the accuracy or completeness of any information contained in this message and hereby excludes any liability of any kind for the information contained therein or for the information transmission, reception, storage or use of such in any way whatsoever. The opinions expressed in this message belong to sender alone and may not necessarily reflect the opinions of TURKCELL. This e-mail has been scanned for all known computer viruses. ************************************************************************ -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20091003/d000ab3c/attachment-0001.html -------------- next part -------------- A non-text attachment was scrubbed... Name: Tcelldis.gif Type: image/gif Size: 16397 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20091003/d000ab3c/attachment-0001.gif From danhicks at ieee.org Sat Oct 3 14:05:53 2009 From: danhicks at ieee.org (Dan Hicks) Date: Sat, 03 Oct 2009 16:05:53 -0500 Subject: very very slow starting up on Solaris T5240 In-Reply-To: References: Message-ID: <4AC7BCB1.5060108@ieee.org> > Message: 1 > Date: Sat, 3 Oct 2009 22:40:41 +0300 > From: > Subject: very very slow starting up on Solaris T5240 > To: > Message-ID: > <069B728771D6134C9ECEB525D929B07C0338B5FF1B at EXVMBX2.turkcell.entp.tgc> > Content-Type: text/plain; charset="us-ascii" > > Hi everybody, > > > i send a first mail to group, we have a start-up problem. > > we have huge number of Solaris Servers. Sun v490&890 is normal for staring up . New generation Sun T5240 is extremly good for CPU& MEM. - > > but our WeblogicServer application server is very very slow starting up on Solaris T5240. > ~1hour. > > Why could it be ? > > Regards from Turkey, > > > > We are using these args: > > 24575: /turkcell/extusr/jdk519/bin/java -Dweblogic.Name=EXT-WLS10-PROD-MAN1-M1-3 -serv > argv[0]: /turkcell/extusr/jdk519/bin/java > argv[1]: -Dweblogic.Name=EXT-WLS10-PROD-MAN1-M1-3 > argv[2]: -server > argv[3]: -Xms1792m > argv[4]: -Xmx1792m > argv[5]: -Xss128k > argv[6]: -Xmn510m > argv[7]: -XX:SurvivorRatio=4 > argv[8]: -XX:+UseParNewGC > argv[9]: -XX:+UseConcMarkSweepGC > argv[10]: -XX:+CMSClassUnloadingEnabled > argv[11]: -XX:PermSize=512m > argv[12]: -XX:MaxPermSize=512m > argv[13]: -verbosegc > argv[14]: -XX:+PrintGCTimeStamps > argv[15]: -XX:+PrintGCDetails > argv[16]: -XX:+PrintTenuringDistribution > argv[17]: -XX:+PrintHeapAtGC > argv[18]: -Xloggc:/turkcell/extusr/wlserver10/wlserver_10.0/domains/EXT-WLS10-PROD-DMN/logs/MAN1-3gc.logs > argv[19]: -Xcheck:jni > argv[20]: -Djavax.net.ssl.trustStore=/usr/jdk/jdk160_05/jre/lib/security/cacerts > argv[21]: -Dweblogic.configuration.schemaValidationEnabled=false > argv[22]: -DPosnetLogDir=/data/beawllog > argv[23]: -Dweblogic.management.username=**** > argv[24]: -Dweblogic.management.password=*** > argv[25]: -Dweblogic.management.server=https://***:** > argv[26]: -Dweblogic.security.SSL.ignoreHostnameVerification=true > argv[27]: -Djava.security.policy=/turkcell/extusr/wlserver10/wlserver_10.0/server/lib/weblogic.policy > argv[28]: -DEnv=PROD > argv[29]: -DHostName_WLSName=trafalgar-MAN1-M1-3 > argv[30]: -Dweblogic.webservice.i18n.charset=ISO-8859-9 > argv[31]: -Dfile.encoding=ISO-8859-9 > argv[32]: -Dorg.apache.xerces.xni.parser.XMLParserConfiguration=org.apache.xerces.parsers.XIncludeAwareParserConfiguration > argv[33]: weblogic.Server > > > > > little begin- Gc out > > 156.793: [GC {Heap before gc invocations=0: > par new generation total 435200K, used 348160K [0x63c00000, 0x83a00000, 0x83a00000) > eden space 348160K, 100% used [0x63c00000, 0x79000000, 0x79000000) > from space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) > to space 87040K, 0% used [0x7e500000, 0x7e500000, 0x83a00000) > concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, 0xd3c00000, 0xd3c00000) > concurrent-mark-sweep perm gen total 524288K, used 24076K [0xd3c00000, 0xf3c00000, 0xf3c00000) > 156.794: [ParNew > Desired survivor size 44564480 bytes, new threshold 15 (max 15) > - age 1: 15784840 bytes, 15784840 total > - age 2: 10944 bytes, 15795784 total > : 348160K->15709K(435200K), 0.2141873 secs] 348160K->15709K(1747968K)Heap after gc invocations=1: > par new generation total 435200K, used 15709K [0x63c00000, 0x83a00000, 0x83a00000) > eden space 348160K, 0% used [0x63c00000, 0x63c00000, 0x79000000) > from space 87040K, 18% used [0x7e500000, 0x7f4577a8, 0x83a00000) > to space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) > concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, 0xd3c00000, 0xd3c00000) > concurrent-mark-sweep perm gen total 524288K, used 24076K [0xd3c00000, 0xf3c00000, 0xf3c00000) > } > , 0.2152029 secs] > 189.791: [GC {Heap before gc invocations=1: > par new generation total 435200K, used 363869K [0x63c00000, 0x83a00000, 0x83a00000) > eden space 348160K, 100% used [0x63c00000, 0x79000000, 0x79000000) > from space 87040K, 18% used [0x7e500000, 0x7f4577a8, 0x83a00000) > to space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) > concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, 0xd3c00000, 0xd3c00000) > > > ************************************************************************ > Bu elektronik posta ve onunla iletilen butun dosyalar sadece gondericisi tarafindan almasi amaclanan yetkili gercek ya da tuzel kisinin kullanimi icindir. Eger soz konusu yetkili alici degilseniz bu elektronik postanin icerigini aciklamaniz, kopyalamaniz, yonlendirmeniz ve kullanmaniz kesinlikle yasaktir ve bu elektronik postayi derhal silmeniz gerekmektedir. > TURKCELL bu mesajin icerdigi bilgilerin dogrulugu veya eksiksiz oldugu konusunda herhangi bir garanti vermemektedir. Bu nedenle bu bilgilerin ne sekilde olursa olsun iceriginden, iletilmesinden, alinmasindan ve saklanmasindan sorumlu degildir. Bu mesajdaki gorusler yalnizca gonderen kisiye aittir ve TURKCELLin goruslerini yansitmayabilir > Bu e-posta bilinen butun bilgisayar viruslerine karsi taranmistir. > ************************************************************************ > This e-mail and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you are not the intended recipient you are hereby notified that any dissemination, forwarding, copying or use of any of the information is strictly prohibited, and the e-mail should immediately be deleted. > TURKCELL makes no warranty as to the accuracy or completeness of any information contained in this message and hereby excludes any liability of any kind for the information contained therein or for the information transmission, reception, storage or use of such in any way whatsoever. The opinions expressed in this message belong to sender alone and may not necessarily reflect the opinions of TURKCELL. > This e-mail has been scanned for all known computer viruses. > ************************************************************************ My experience has been that slow startup is usually due to class loading and verification, and is not typically limited by GC. If the same application is behaving differently on different platforms, I'd first look for differences in configuration and class libraries, then consider whether disk access is slower on the problem system. -- Dan Hicks Music was invented to confirm human loneliness. --Lawrence Durrell From antonios.printezis at sun.com Sat Oct 3 16:20:13 2009 From: antonios.printezis at sun.com (antonios.printezis at sun.com) Date: Sat, 03 Oct 2009 23:20:13 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 14 new changesets Message-ID: <20091003232100.6443041AF0@hg.openjdk.java.net> Changeset: 685e959d09ea Author: cfang Date: 2009-09-14 09:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/685e959d09ea 6877254: Server vm crashes with no branches off of store slice" when run with CMS and UseSuperWord(default) Summary: design StoreCMNode::Ideal to promote its oopStore input if the input is a MergeMem node Reviewed-by: kvn, never ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp ! src/share/vm/opto/superword.cpp + test/compiler/6877254/Test.java Changeset: 62001a362ce9 Author: kvn Date: 2009-09-14 12:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/62001a362ce9 6827605: new String intrinsics may prevent EA scalar replacement 6875866: Intrinsic for String.indexOf() is broken on x86 with SSE4.2 Summary: Modify String intrinsic methods to pass char[] pointers instead of string oops. Reviewed-by: never ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/adlc/formssel.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/matcher.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/memnode.hpp + test/compiler/6875866/Test.java Changeset: 00977607da34 Author: cfang Date: 2009-09-15 11:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/00977607da34 6879921: CTW failure jdk6_18/hotspot/src/share/vm/utilities/globalDefinitions.cpp:268 Summary: filter out non-primitives before deciding whether two ops can be packed Reviewed-by: kvn, never ! src/share/vm/opto/superword.cpp Changeset: 7e309ecb83ce Author: kvn Date: 2009-09-15 19:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/7e309ecb83ce 6879362: assert(!klass_is_exact(),"only non-exact klass") Summary: Do nothing for AddP node which has type not related to the type of allocated object. Reviewed-by: never ! src/share/vm/opto/escape.cpp Changeset: 148e5441d916 Author: jrose Date: 2009-09-15 21:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/148e5441d916 6863023: need non-perm oops in code cache for JSR 292 Summary: Make a special root-list for those few nmethods which might contain non-perm oops. Reviewed-by: twisti, kvn, never, jmasa, ysr ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_InstructionPrinter.cpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_ValueType.cpp ! src/share/vm/ci/ciEnv.cpp ! src/share/vm/ci/ciEnv.hpp ! src/share/vm/ci/ciObject.cpp ! src/share/vm/ci/ciObject.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/code/codeBlob.hpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/debugInfoRec.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.hpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/defNewGeneration.cpp ! src/share/vm/memory/genCollectedHeap.cpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/memory/sharedHeap.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline2.hpp ! src/share/vm/opto/output.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/frame.cpp ! src/share/vm/runtime/frame.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/runtime/vmThread.cpp ! src/share/vm/runtime/vmThread.hpp ! src/share/vm/utilities/debug.cpp Changeset: be094e0c089a Author: jrose Date: 2009-09-15 22:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/be094e0c089a Merge Changeset: 3a2aa26bdc58 Author: never Date: 2009-09-16 11:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3a2aa26bdc58 6854812: 6.0_14-b08 crashes with a SIGSEGV Reviewed-by: kvn, twisti ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethod.hpp ! src/share/vm/ci/ciTypeFlow.cpp ! src/share/vm/opto/parse1.cpp Changeset: 6a8ccac44f41 Author: kvn Date: 2009-09-18 09:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6a8ccac44f41 6820514: meet not symmetric failure in ctw Summary: Add missing instance_id meet. Reviewed-by: never ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp Changeset: 54b3b351d6f9 Author: jrose Date: 2009-09-23 23:56 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/54b3b351d6f9 Merge ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/code/dependencies.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/includeDB_gc_parallelScavenge ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.hpp - src/share/vm/gc_implementation/shared/coTracker.cpp - src/share/vm/gc_implementation/shared/coTracker.hpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.cpp - src/share/vm/gc_implementation/shared/gcOverheadReporter.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: 753cf9794df9 Author: jrose Date: 2009-09-23 23:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/753cf9794df9 6885169: merge of 4957990 and 6863023 causes conflict on do_nmethods Summary: After mechanically merging changes, some by-hand adjustments are needed. Reviewed-by: ysr ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/cmsOopClosures.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp Changeset: ddd6f1182ae3 Author: kvn Date: 2009-09-25 13:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ddd6f1182ae3 6883468: C2 compiler enters infinite loop in PhaseIterGVN::transform Summary: Avoid ideal transformation ping-pong between AddPNode::Ideal() and CastX2PNode::Ideal(). Reviewed-by: cfang ! src/share/vm/opto/connode.cpp Changeset: d6b9fd78f389 Author: cfang Date: 2009-09-28 17:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d6b9fd78f389 6886353: For DeoptimizeALot, JTreg tests should "IgnoreUnrecognizedVMOptions on a product build Summary: Add IgnoreUnrecognizedVMOptions for JTreg tests (on a product build) to pass with DeoptimizeALot Reviewed-by: kvn ! test/compiler/6823453/Test.java ! test/compiler/6833129/Test.java Changeset: 46b819ba120b Author: jrose Date: 2009-09-30 13:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/46b819ba120b Merge ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp Changeset: 708275a44e4a Author: tonyp Date: 2009-10-03 10:53 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/708275a44e4a Merge ! src/cpu/sparc/vm/c1_LIRGenerator_sparc.cpp From Y.S.Ramakrishna at Sun.COM Sun Oct 4 16:33:15 2009 From: Y.S.Ramakrishna at Sun.COM (Y. Srinivas Ramakrishna) Date: Sun, 04 Oct 2009 16:33:15 -0700 Subject: very very slow starting up on Solaris T5240 In-Reply-To: <4AC7BCB1.5060108@ieee.org> References: <4AC7BCB1.5060108@ieee.org> Message-ID: <4AC930BB.5090907@sun.com> Hi Attila -- Start from first principals and try prstat, vmstat/mpstat, jstack/pstack to see what the process is doing, and wher it's spending most of its time. Check the version of JDK you are using (it seems to be 5u19; try 6u16 instead to see if it made any difference.) However, given that you sent your email on this alias, it's likely you have already done some investigation and suspect GC as being a root cause? If so, perhaps elaborate on what you found different about GC. It is possible that the default # gc threads that you are getting is too large (in which case try tuning down that # so as to use no more than 2 GC worker threads per core). The small snippet of GC you provided below does not, by itself, say anything is wrong -- you spent 0.215 s in GC per every 33 s of mutator execution, less than 1% GC overhead. It is quite possible that your slowdown is on account of something else, at least going on just the snippet of GC you provided. -- ramki Dan Hicks wrote: > >> Message: 1 >> Date: Sat, 3 Oct 2009 22:40:41 +0300 >> From: >> Subject: very very slow starting up on Solaris T5240 >> To: >> Message-ID: >> <069B728771D6134C9ECEB525D929B07C0338B5FF1B at EXVMBX2.turkcell.entp.tgc> >> >> Content-Type: text/plain; charset="us-ascii" >> >> Hi everybody, >> >> >> i send a first mail to group, we have a start-up problem. >> >> we have huge number of Solaris Servers. Sun v490&890 is normal for >> staring up . New generation Sun T5240 is extremly good for CPU& MEM. - >> >> but our WeblogicServer application server is very very slow starting >> up on Solaris T5240. >> ~1hour. >> >> Why could it be ? >> >> Regards from Turkey, >> >> >> >> We are using these args: >> >> 24575: /turkcell/extusr/jdk519/bin/java >> -Dweblogic.Name=EXT-WLS10-PROD-MAN1-M1-3 -serv >> argv[0]: /turkcell/extusr/jdk519/bin/java >> argv[1]: -Dweblogic.Name=EXT-WLS10-PROD-MAN1-M1-3 >> argv[2]: -server >> argv[3]: -Xms1792m >> argv[4]: -Xmx1792m >> argv[5]: -Xss128k >> argv[6]: -Xmn510m >> argv[7]: -XX:SurvivorRatio=4 >> argv[8]: -XX:+UseParNewGC >> argv[9]: -XX:+UseConcMarkSweepGC >> argv[10]: -XX:+CMSClassUnloadingEnabled >> argv[11]: -XX:PermSize=512m >> argv[12]: -XX:MaxPermSize=512m >> argv[13]: -verbosegc >> argv[14]: -XX:+PrintGCTimeStamps >> argv[15]: -XX:+PrintGCDetails >> argv[16]: -XX:+PrintTenuringDistribution >> argv[17]: -XX:+PrintHeapAtGC >> argv[18]: >> -Xloggc:/turkcell/extusr/wlserver10/wlserver_10.0/domains/EXT-WLS10-PROD-DMN/logs/MAN1-3gc.logs >> >> argv[19]: -Xcheck:jni >> argv[20]: >> -Djavax.net.ssl.trustStore=/usr/jdk/jdk160_05/jre/lib/security/cacerts >> argv[21]: -Dweblogic.configuration.schemaValidationEnabled=false >> argv[22]: -DPosnetLogDir=/data/beawllog >> argv[23]: -Dweblogic.management.username=**** >> argv[24]: -Dweblogic.management.password=*** >> argv[25]: -Dweblogic.management.server=https://***:** >> argv[26]: -Dweblogic.security.SSL.ignoreHostnameVerification=true >> argv[27]: >> -Djava.security.policy=/turkcell/extusr/wlserver10/wlserver_10.0/server/lib/weblogic.policy >> >> argv[28]: -DEnv=PROD >> argv[29]: -DHostName_WLSName=trafalgar-MAN1-M1-3 >> argv[30]: -Dweblogic.webservice.i18n.charset=ISO-8859-9 >> argv[31]: -Dfile.encoding=ISO-8859-9 >> argv[32]: >> -Dorg.apache.xerces.xni.parser.XMLParserConfiguration=org.apache.xerces.parsers.XIncludeAwareParserConfiguration >> >> argv[33]: weblogic.Server >> >> >> >> >> little begin- Gc out >> >> 156.793: [GC {Heap before gc invocations=0: >> par new generation total 435200K, used 348160K [0x63c00000, >> 0x83a00000, 0x83a00000) >> eden space 348160K, 100% used [0x63c00000, 0x79000000, 0x79000000) >> from space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) >> to space 87040K, 0% used [0x7e500000, 0x7e500000, 0x83a00000) >> concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, >> 0xd3c00000, 0xd3c00000) >> concurrent-mark-sweep perm gen total 524288K, used 24076K >> [0xd3c00000, 0xf3c00000, 0xf3c00000) >> 156.794: [ParNew >> Desired survivor size 44564480 bytes, new threshold 15 (max 15) >> - age 1: 15784840 bytes, 15784840 total >> - age 2: 10944 bytes, 15795784 total >> : 348160K->15709K(435200K), 0.2141873 secs] >> 348160K->15709K(1747968K)Heap after gc invocations=1: >> par new generation total 435200K, used 15709K [0x63c00000, >> 0x83a00000, 0x83a00000) >> eden space 348160K, 0% used [0x63c00000, 0x63c00000, 0x79000000) >> from space 87040K, 18% used [0x7e500000, 0x7f4577a8, 0x83a00000) >> to space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) >> concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, >> 0xd3c00000, 0xd3c00000) >> concurrent-mark-sweep perm gen total 524288K, used 24076K >> [0xd3c00000, 0xf3c00000, 0xf3c00000) >> } >> , 0.2152029 secs] >> 189.791: [GC {Heap before gc invocations=1: >> par new generation total 435200K, used 363869K [0x63c00000, >> 0x83a00000, 0x83a00000) >> eden space 348160K, 100% used [0x63c00000, 0x79000000, 0x79000000) >> from space 87040K, 18% used [0x7e500000, 0x7f4577a8, 0x83a00000) >> to space 87040K, 0% used [0x79000000, 0x79000000, 0x7e500000) >> concurrent mark-sweep generation total 1312768K, used 0K [0x83a00000, >> 0xd3c00000, 0xd3c00000) >> >> >> ************************************************************************ >> Bu elektronik posta ve onunla iletilen butun dosyalar sadece >> gondericisi tarafindan almasi amaclanan yetkili gercek ya da tuzel >> kisinin kullanimi icindir. Eger soz konusu yetkili alici degilseniz >> bu elektronik postanin icerigini aciklamaniz, kopyalamaniz, >> yonlendirmeniz ve kullanmaniz kesinlikle yasaktir ve bu elektronik >> postayi derhal silmeniz gerekmektedir. >> TURKCELL bu mesajin icerdigi bilgilerin dogrulugu veya eksiksiz oldugu >> konusunda herhangi bir garanti vermemektedir. Bu nedenle bu >> bilgilerin ne sekilde olursa olsun iceriginden, iletilmesinden, >> alinmasindan ve saklanmasindan sorumlu degildir. Bu mesajdaki gorusler >> yalnizca gonderen kisiye aittir ve TURKCELLin goruslerini yansitmayabilir >> Bu e-posta bilinen butun bilgisayar viruslerine karsi taranmistir. >> ************************************************************************ >> This e-mail and any files transmitted with it are confidential and >> intended solely for the use of the individual or entity to whom they >> are addressed. If you are not the intended recipient you are hereby >> notified that any dissemination, forwarding, copying or use of any of >> the information is strictly prohibited, and the e-mail should >> immediately be deleted. >> TURKCELL makes no warranty as to the accuracy or completeness of any >> information contained in this message and hereby excludes any >> liability of any kind for the information contained therein or for the >> information transmission, reception, storage or use of such in any way >> whatsoever. The opinions expressed in this message belong to sender >> alone and may not necessarily reflect the opinions of TURKCELL. >> This e-mail has been scanned for all known computer viruses. >> ************************************************************************ > My experience has been that slow startup is usually due to class loading > and verification, and is not typically limited by GC. If the same > application is behaving differently on different platforms, I'd first > look for differences in configuration and class libraries, then consider > whether disk access is slower on the problem system. > From john.coomes at sun.com Mon Oct 5 08:07:22 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Mon, 05 Oct 2009 15:07:22 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6887948: test/gc/6845368/bigobj.java fails due to timeout Message-ID: <20091005150732.8C31B41D79@hg.openjdk.java.net> Changeset: 8afee153274a Author: jcoomes Date: 2009-10-05 05:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8afee153274a 6887948: test/gc/6845368/bigobj.java fails due to timeout Reviewed-by: iveresov ! test/gc/6845368/bigobj.java From antonios.printezis at sun.com Mon Oct 5 14:50:18 2009 From: antonios.printezis at sun.com (antonios.printezis at sun.com) Date: Mon, 05 Oct 2009 21:50:18 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <20091005215025.0CFA041DEA@hg.openjdk.java.net> Changeset: 035d2e036a9b Author: tonyp Date: 2009-10-02 16:12 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/035d2e036a9b 6885041: G1: inconsistent thread dump Summary: When G1 is enabled, thread dumps are inconsistent as the info for some of the G1 threads is not formatted properly. Reviewed-by: ysr, johnc ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.cpp ! src/share/vm/gc_implementation/g1/concurrentG1RefineThread.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.hpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.cpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp Changeset: ff2402f6a50b Author: tonyp Date: 2009-10-02 16:20 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ff2402f6a50b 6882730: G1: parallel heap verification messes up region dump Summary: It tidies up the G1 heap verification a bit. In particular, when the verification is done in parallel and there is a failure, this is propagated to the top level and the heap is dumped at the end, not by every thread that encounters a failure. Reviewed-by: johnc, jmasa ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp From John.Coomes at sun.com Tue Oct 6 11:01:47 2009 From: John.Coomes at sun.com (John Coomes) Date: Tue, 6 Oct 2009 11:01:47 -0700 Subject: review request (L) - 6423256 GC stacks In-Reply-To: <19127.45893.964149.754611@sun.com> References: <19127.45893.964149.754611@sun.com> Message-ID: <19147.34315.675132.955543@sun.com> John Coomes (John.Coomes at sun.com) wrote: > I'd appreciate reviews of > > 6423256: GC stacks should use a better data structure > > http://cr.openjdk.java.net/~jcoomes/6423256-gc-stacks/ > > See the comments at the top of the webrev and in file stack.hpp for > some hints/details. I've updated the webrev at the url above after some good review feedback from Andrey (thanks!) and syncing with current hotspot-gc. The changes are mostly syntactic, differences from the previous round are summarized the top of the webrev. Testing is clean. -John From antonios.printezis at sun.com Tue Oct 6 11:10:51 2009 From: antonios.printezis at sun.com (antonios.printezis at sun.com) Date: Tue, 06 Oct 2009 18:10:51 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6847956: G1: crash in oopDesc*G1ParCopyHelper::copy_to_survivor_space(oopDesc*) Message-ID: <20091006181055.387C541F3B@hg.openjdk.java.net> Changeset: 1f19207eefc2 Author: tonyp Date: 2009-10-05 12:05 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1f19207eefc2 6847956: G1: crash in oopDesc*G1ParCopyHelper::copy_to_survivor_space(oopDesc*) Summary: When we copy objects to survivors during marking, we incorrectly set NTAMS to bottom, which causes marking to miss visiting some of those objects. Reviewed-by: apetrusenko, iveresov ! src/share/vm/gc_implementation/g1/heapRegion.hpp From scott.marlow.opensource at gmail.com Tue Oct 6 11:49:02 2009 From: scott.marlow.opensource at gmail.com (Scott Marlow) Date: Tue, 06 Oct 2009 14:49:02 -0400 Subject: review request (L) - 6423256 GC stacks In-Reply-To: <19127.45893.964149.754611@sun.com> References: <19127.45893.964149.754611@sun.com> Message-ID: <4ACB911E.30908@gmail.com> John, A few comments. First, thank you for bringing this change out for review. 1. If anyone on the list happens to have any performance jdk tests handy, it would be interesting to see before/after results of applying this change (so that any regressions can be addressed and improvements shared :-). If there is no noticeable impact, that is worth sharing too. I no longer have access to the torture test that I once had (a four node cluster that reproduced a production environment that experienced bug # 6423256). If no one has performance tests to run, that shouldn't block applying this patch (would just be nice to have). 2. I like the idea expressed in stack.hpp about possibly caching segments in thread local storage. At least, that is the optimization that I assume is meant by saving the thread id. Or are you just talking about using it for debugging purposes (for tracking which thread allocated each segment)? I have worked on heap sub-allocators for other virtual machines but haven't learned about the Java native allocators yet. I would think that having a per thread segment cache, could have some impact on the native memory pool (potentially causing fragmentation depending on how many threads are in use). Although, the pressure on the native heap should be much lower than what growableArray must of done to the heap. This isn't a serious concern, since its just a comment but thought it was worth raising. 3. What is the meaning of "const size_t limit = size_t(-1) - (seg_size - 1)" in stack.inline.hpp (adjust_max_size)? It looks like you are trying to determine the largest possible size but I wanted to make sure as I'm not familiar with how "size_t(-1)" works. Could there be problems with that expression on some of the exotic machine architectures that Java is running on (e.g. 1s complement cpu running j2me). Scott On 09/21/2009 01:09 PM, John Coomes wrote: > I'd appreciate reviews of > > 6423256: GC stacks should use a better data structure > > http://cr.openjdk.java.net/~jcoomes/6423256-gc-stacks/ > > See the comments at the top of the webrev and in file stack.hpp for > some hints/details. > > -John > > > From Jon.Masamitsu at Sun.COM Tue Oct 6 14:27:11 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Tue, 06 Oct 2009 14:27:11 -0700 Subject: Default performance on Sun T5440 In-Reply-To: <0FCC438D62A5E643AA3F57D3417B220D0AB35B74@TORMAIL.algorithmics.com> References: <0FCC438D62A5E643AA3F57D3417B220D0AABB213@TORMAIL.algorithmics.com> <4AC63636.5080609@sun.com> <4AC63AF3.6050100@sun.com> <0FCC438D62A5E643AA3F57D3417B220D0AABB3B0@TORMAIL.algorithmics.com> <4AC642F3.2020402@sun.com> <0FCC438D62A5E643AA3F57D3417B220D0AABB40D@TORMAIL.algorithmics.com> <4AC6545B.4050103@sun.com> <4AC66364.7090000@sun.com> <0FCC438D62A5E643AA3F57D3417B220D0AB35B74@TORMAIL.algorithmics.com> Message-ID: <4ACBB62F.2070303@Sun.COM> Jeff, It's a little faster. This is a Sun T5440, 4 1.4Ghz Niagara2(T2+) CPUs I'm guessing that there is something about your application that is hitting a weak spot in the collector. If you can share the benchmark, that would help. In the past we've seen performance problems with very large objects, but there isn't any problem that we're aware of in the latest jdk6 release. Jon On 10/06/09 14:02, jeff.lloyd at algorithmics.com wrote: > Hi Jon, > > Sorry for the delay - I took a long weekend. > > Is it possible you are testing on a faster box than me? Here is mine: > > The sparcv9 processor operates at 1164 MHz, > and has a sparcv9 floating point processor. > > Jeff > > -----Original Message----- > From: hotspot-gc-use-bounces at openjdk.java.net > [mailto:hotspot-gc-use-bounces at openjdk.java.net] On Behalf Of Jon > Masamitsu > Sent: Friday, October 02, 2009 4:33 PM > To: Jeff Lloyd > Cc: hotspot-gc-use at openjdk.java.net > Subject: Re: Default performance on Sun T5440 > > Jeff, > > This is what I see running one of our benchmarks with a > 1g heap on a T5440. > > UseSerialGC > > 81.908: [GC 81.908: [DefNew: 279616K->34943K(314560K), 1.6078835 secs] > 464333K->241833K(1013632K), 1.6080676 secs] [Times: user=1.61 sys=0.00, > real=1.61 secs] > > UseParNewGC with default number of GC threads (85). My appologies but I > had > the wrong fraction in my earlier mail. Not 3/16 but 5/16. Default > number of GC > threads is approximately number of strands * 5/16. > > 49.001: [GC 49.001: [ParNew: 314558K->34942K(314560K), 0.1807405 secs] > 601002K->350442K(1013632K), 0.1809190 secs] [Times: user=14.67 sys=0.02, > real=0.18 secs] > > UseParNewGC with 8 GC threads > > 51.140: [GC 51.141: [ParNew: 279616K->34943K(314560K), 0.3261322 secs] > 464428K->242091K(1013632K), 0.3262756 secs] [Times: user=2.60 sys=0.00, > real=0.33 secs] > > I arbitrarily took the last minor collection in each run. > > Yes, between 85 GC threads and 8 GC threads we're doing lots more work > (user time) > for not that much gain in GC pause (less than a factor of two). We're > addressing that > problem with CR 6593758 which will be smarter about the number of GC > threads > (use factors such as heap size and Java threads to figure out a better > number of GC > threads). > > But I don't see the egregious increase in pause times that you're > seeing. > > 18.8885468 (default number of GC threads) secs vs. 0.1646787 (with 8 GC > threads) > > So something more is in play. > > Jon > > > Jon Masamitsu wrote On 10/02/09 12:28,: > >> Jeff, >> >> When I can get access to a T5440 I'll do some experiments. >> Do you have a benchmark you can give us? >> >> Jon >> >> jeff.lloyd at algorithmics.com wrote On 10/02/09 11:37,: >> >> >> >>> Hi Jon, >>> >>> I'm using 1.6.0_16. I can solve it by reducing the number of parallel >>> threads for ParNew or using serial new collection - that's ok. >>> >>> I just wanted to raise this as a usability issue because I'm a > developer >>> and this issue came to me from the field. I'm concerned that few > people >>> in the field understand java/gc enough to fix or even recognize such > an >>> issue. And this is the default jvm behaviour on the new multithreaded >>> servers (though the default is pure parallel gc instead of cms OG - >>> probably the same problem). >>> >>> So, I don't have a problem right now, but I may have more in the > future >>> because our app is supported on many platforms and now the default >>> number of gc threads won't work well for clients running the Sun JVM > on >>> particular Sun servers. Maybe 3/16 is too high? >>> >>> Jeff >>> >>> -----Original Message----- >>> From: Jon.Masamitsu at Sun.COM [mailto:Jon.Masamitsu at Sun.COM] >>> Sent: Friday, October 02, 2009 2:14 PM >>> To: Jeff Lloyd >>> Cc: hotspot-gc-use at openjdk.java.net >>> Subject: Re: Default performance on Sun T5440 >>> >>> Jeff, >>> >>> This might be something different. First what jdk are you using? >>> What's you command line? If you are using CMS, can you >>> try a run with -XX:-UseParNewGC? If not using CMS, can >>> you try -XX:+UseSerialGC (assuming you're using jdk5 or >>> later). >>> >>> Jon >>> >>> jeff.lloyd at algorithmics.com wrote On 10/02/09 10:56,: >>> >>> >>> >>> >>> >>>> Hi John, >>>> >>>> Thanks for responding. However I just want to show you a simple gc >>>> without manually setting the number of gc cpus: >>>> >>>> 178.427: [GC 178.427: [ParNew: 471872K->52416K(471872K), 18.8885468 >>>> secs] 1054705K->756342K(12530496K), 18.8895357 secs] [Times: >>>> >>>> >>>> >>>> >>> user=740.49 >>> >>> >>> >>> >>>> sys=15.54, real=18.89 secs] >>>> >>>> Compared to a similar gc when I set the max parallel cpus to 8: >>>> >>>> 170.531: [GC 170.532: [ParNew: 118014K->13056K(118016K), 0.1646787 >>>> >>>> >>>> >>>> >>> secs] >>> >>> >>> >>> >>>> 863713K->771012K(12569856K), 0.1651373 secs] [Times: user=0.76 >>>> >>>> >>>> >>>> >>> sys=0.05, >>> >>> >>> >>> >>>> real=0.17 secs] >>>> >>>> I apologize it isn't totally apples-to-apples because I reduced the > YG >>>> >>>> >>>> >>>> >>> >from 512M to 128M, but look at the difference in "user" time. After >>> >>> >>> >>> >>>> 5-10 minutes of uptime my application was reporting 135 minutes of > cpu >>>> time with the default settings. >>>> >>>> I'm not sure if this is helpful to you or the appropriate place to >>>> provide feedback, but this is what people are going to be seeing if >>>> >>>> >>>> >>>> >>> they >>> >>> >>> >>> >>>> don't understand gc details. >>>> >>>> Jeff >>>> >>>> -----Original Message----- >>>> From: Jon.Masamitsu at Sun.COM [mailto:Jon.Masamitsu at Sun.COM] >>>> Sent: Friday, October 02, 2009 1:40 PM >>>> To: Jon Masamitsu >>>> Cc: Jeff Lloyd; hotspot-gc-use at openjdk.java.net >>>> Subject: Re: Default performance on Sun T5440 >>>> >>>> Jon Masamitsu wrote On 10/02/09 10:19,: >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>>> Jeff, >>>>> >>>>> The default number of GC threads was changed to be fewer in >>>>> jdk6u14 (same change in jdk7). I'm guessing you're using >>>>> an older jdk? The number of GC threads depends on the >>>>> number of cores on the platform. I think on the T5440 the >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>> ^^^^^^^^^^^^ cores should be strands >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>>> number will be about 3/16 * 256 or 48. >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> >>>> This is still correct. >>>> >>>> >>>> >>>> --------------------------------------------------------------------- > -- >>>> >>>> >>>> >>>> >>> --- >>> >>> >>> >>> >>>> This email and any files transmitted with it are confidential and >>>> >>>> >>>> >>>> >>> proprietary to Algorithmics Incorporated and its affiliates >>> ("Algorithmics"). If received in error, use is prohibited. Please >>> destroy, and notify sender. Sender does not waive confidentiality or >>> privilege. Internet communications cannot be guaranteed to be timely, >>> secure, error or virus-free. Algorithmics does not accept liability > for >>> any errors or omissions. Any commitment intended to bind Algorithmics >>> must be reduced to writing and signed by an authorized signatory. >>> >>> >>> >>> >>>> --------------------------------------------------------------------- > -- >>>> >>>> >>>> >>>> >>> --- >>> >>> >>> >>> >>>> >>>> >>>> >>>> >>> ---------------------------------------------------------------------- > ---- >>> This email and any files transmitted with it are confidential and > proprietary to Algorithmics Incorporated and its affiliates > ("Algorithmics"). If received in error, use is prohibited. Please > destroy, and notify sender. Sender does not waive confidentiality or > privilege. Internet communications cannot be guaranteed to be timely, > secure, error or virus-free. Algorithmics does not accept liability for > any errors or omissions. Any commitment intended to bind Algorithmics > must be reduced to writing and signed by an authorized signatory. >>> ---------------------------------------------------------------------- > ---- >>> >>> >>> >> _______________________________________________ >> hotspot-gc-use mailing list >> hotspot-gc-use at openjdk.java.net >> http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use >> >> > > _______________________________________________ > hotspot-gc-use mailing list > hotspot-gc-use at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use > > > -------------------------------------------------------------------------- > This email and any files transmitted with it are confidential and proprietary to Algorithmics Incorporated and its affiliates ("Algorithmics"). If received in error, use is prohibited. Please destroy, and notify sender. Sender does not waive confidentiality or privilege. Internet communications cannot be guaranteed to be timely, secure, error or virus-free. Algorithmics does not accept liability for any errors or omissions. Any commitment intended to bind Algorithmics must be reduced to writing and signed by an authorized signatory. > -------------------------------------------------------------------------- > _______________________________________________ > hotspot-gc-use mailing list > hotspot-gc-use at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From tony.printezis at sun.com Tue Oct 6 14:31:30 2009 From: tony.printezis at sun.com (Tony Printezis) Date: Tue, 06 Oct 2009 17:31:30 -0400 Subject: CRR: 6888316 and 6888619 (remove guarantees / change guarantees to asserts in concurrent mark) (S) Message-ID: <4ACBB732.9000403@sun.com> Hi all, Could I please get a couple of code reviews for this one? http://cr.openjdk.java.net/~tonyp/6888316/webrev.0/ The important (and very small) change is the removal of a guarantee that is incorrect. Please have a look at the Evaluation notes on CR 6888316 for details. The less important (but larger) change is the change of many guarantees in the G1 concurrent marking code into asserts (as we should not have that overhead in the product build). I also took this opportunity to split some of the asserts and tidy up formatting. There are about 150 lines changed, but the changes are straightforward, even though somewhat tedious to review. Thanks, Tony -- --------------------------------------------------------------------- | Tony Printezis, Staff Engineer | Sun Microsystems Inc. | | | MS UBUR02-311 | | e-mail: tony.printezis at sun.com | 35 Network Drive | | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA | --------------------------------------------------------------------- e-mail client: Thunderbird (Linux) From tony.printezis at sun.com Tue Oct 6 14:37:54 2009 From: tony.printezis at sun.com (Tony Printezis) Date: Tue, 06 Oct 2009 17:37:54 -0400 Subject: CRR: 6888847: Add release_stores to task queues for the correct operation on non-TSO machines (XXXS) Message-ID: <4ACBB8B2.5000709@sun.com> The title says it all. :-) Webrev here: http://cr.openjdk.java.net/~tonyp/6888847/webrev.0/ Thanks, Tony -- --------------------------------------------------------------------- | Tony Printezis, Staff Engineer | Sun Microsystems Inc. | | | MS UBUR02-311 | | e-mail: tony.printezis at sun.com | 35 Network Drive | | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA | --------------------------------------------------------------------- e-mail client: Thunderbird (Linux) From John.Coomes at sun.com Tue Oct 6 19:19:56 2009 From: John.Coomes at sun.com (John Coomes) Date: Tue, 6 Oct 2009 19:19:56 -0700 Subject: CRR: 6888847: Add release_stores to task queues for the correct operation on non-TSO machines (XXXS) In-Reply-To: <4ACBB8B2.5000709@sun.com> References: <4ACBB8B2.5000709@sun.com> Message-ID: <19147.64204.291521.271045@sun.com> Tony Printezis (tony.printezis at sun.com) wrote: > The title says it all. :-) Webrev here: > > http://cr.openjdk.java.net/~tonyp/6888847/webrev.0/ Yes, looks good. -John From John.Coomes at sun.com Tue Oct 6 20:13:51 2009 From: John.Coomes at sun.com (John Coomes) Date: Tue, 6 Oct 2009 20:13:51 -0700 Subject: review request (L) - 6423256 GC stacks In-Reply-To: <4ACB911E.30908@gmail.com> References: <19127.45893.964149.754611@sun.com> <4ACB911E.30908@gmail.com> Message-ID: <19148.1903.108972.846943@sun.com> Scott Marlow (scott.marlow.opensource at gmail.com) wrote: > John, > > A few comments. First, thank you for bringing this change out for review. Hi Scott, Many thanks for taking a look. > 1. If anyone on the list happens to have any performance jdk tests > handy, it would be interesting to see before/after results of applying > this change (so that any regressions can be addressed and improvements > shared :-). If there is no noticeable impact, that is worth sharing > too. I no longer have access to the torture test that I once had (a > four node cluster that reproduced a production environment that > experienced bug # 6423256). If no one has performance tests to run, > that shouldn't block applying this patch (would just be nice to have). I didn't mention it, but I've run our standard performance benchmarks (specjbb2005, specjvm98, etc.) on a few architectures & operating systems. It's standard procedure for most changes, so many of us who've been doing it for years don't bother to mention it anymore. As expected there's no statistically significant change in either overall performance or GC performance. This code isn't on a super hot path, and the common case operations are basically identical to the GrowableArray code it replaces. > 2. I like the idea expressed in stack.hpp about possibly caching > segments in thread local storage. At least, that is the optimization > that I assume is meant by saving the thread id. Or are you just talking > about using it for debugging purposes (for tracking which thread > allocated each segment)? I have worked on heap sub-allocators for other > virtual machines but haven't learned about the Java native allocators > yet. I would think that having a per thread segment cache, could have > some impact on the native memory pool (potentially causing fragmentation > depending on how many threads are in use). Although, the pressure on > the native heap should be much lower than what growableArray must of > done to the heap. This isn't a serious concern, since its just a > comment but thought it was worth raising. It's a good question. The comment refers to the fact that the alloc() and free() methods for a ResourceStack need to use the HotSpot Thread object, so caching it instead of looking it up each time would save a a modest number of cycles each time you alloc/free a segment. Right now there are no uses of ResourceStack, so it's mostly just a note for the future. > 3. What is the meaning of "const size_t limit = size_t(-1) - (seg_size > - 1)" in stack.inline.hpp (adjust_max_size)? It looks like you are > trying to determine the largest possible size but I wanted to make sure > as I'm not familiar with how "size_t(-1)" works. Could there be > problems with that expression on some of the exotic machine > architectures that Java is running on (e.g. 1s complement cpu running > j2me). Right, I'm using size_t(-1) to get the largest size_t; it's an alternate syntax for the cast (size_t)-1 that makes it look like you're "constructing" a size_t. And it's not precise on a 1s-complement box--it would be one less than the max size_t. This code would still work, but it's not very clean. Turns out HotSpot has a global constant max_uintx; I'll use that instead. Thanks again! -John > On 09/21/2009 01:09 PM, John Coomes wrote: > > I'd appreciate reviews of > > > > 6423256: GC stacks should use a better data structure > > > > http://cr.openjdk.java.net/~jcoomes/6423256-gc-stacks/ > > > > See the comments at the top of the webrev and in file stack.hpp for > > some hints/details. > > > > -John > > > > > > > From Igor.Veresov at Sun.COM Tue Oct 6 20:42:22 2009 From: Igor.Veresov at Sun.COM (Igor Veresov) Date: Tue, 06 Oct 2009 20:42:22 -0700 Subject: CRR: 6888316 and 6888619 (remove guarantees / change guarantees to asserts in concurrent mark) (S) In-Reply-To: <4ACBB732.9000403@sun.com> References: <4ACBB732.9000403@sun.com> Message-ID: <4ACC0E1E.3030702@sun.com> Looks good. igor On 10/6/09 2:31 PM, Tony Printezis wrote: > Hi all, > > Could I please get a couple of code reviews for this one? > > http://cr.openjdk.java.net/~tonyp/6888316/webrev.0/ > > The important (and very small) change is the removal of a guarantee that > is incorrect. Please have a look at the Evaluation notes on CR 6888316 > for details. > > The less important (but larger) change is the change of many guarantees > in the G1 concurrent marking code into asserts (as we should not have > that overhead in the product build). I also took this opportunity to > split some of the asserts and tidy up formatting. > > There are about 150 lines changed, but the changes are straightforward, > even though somewhat tedious to review. > > Thanks, > > Tony > From Igor.Veresov at Sun.COM Tue Oct 6 20:45:09 2009 From: Igor.Veresov at Sun.COM (Igor Veresov) Date: Tue, 06 Oct 2009 20:45:09 -0700 Subject: CRR: 6888847: Add release_stores to task queues for the correct operation on non-TSO machines (XXXS) In-Reply-To: <19147.64204.291521.271045@sun.com> References: <4ACBB8B2.5000709@sun.com> <19147.64204.291521.271045@sun.com> Message-ID: <4ACC0EC5.9020806@sun.com> I agree. :) On 10/6/09 7:19 PM, John Coomes wrote: > Tony Printezis (tony.printezis at sun.com) wrote: >> The title says it all. :-) Webrev here: >> >> http://cr.openjdk.java.net/~tonyp/6888847/webrev.0/ > > Yes, looks good. > > -John > From Andrey.Petrusenko at Sun.COM Wed Oct 7 02:26:21 2009 From: Andrey.Petrusenko at Sun.COM (Andrey Petrusenko) Date: Wed, 07 Oct 2009 13:26:21 +0400 Subject: CRR: 6888316 and 6888619 (remove guarantees / change guarantees to asserts in concurrent mark) (S) In-Reply-To: <4ACBB732.9000403@sun.com> References: <4ACBB732.9000403@sun.com> Message-ID: <200910071326.21313.Andrey.Petrusenko@sun.com> Hello Tony, Looks good, one minor syntactic thing: concurrentMark.cpp: 1922 if (ParallelGCThreads > 0) { ... 1937 SATBMarkQueueSet& satb_mq_set = JavaThread::satb_mark_queue_set(); 1938 guarantee(satb_mq_set.completed_buffers_num() == 0, "invariant"); 1939 } else { ... 1951 SATBMarkQueueSet& satb_mq_set = JavaThread::satb_mark_queue_set(); 1952 guarantee(satb_mq_set.completed_buffers_num() == 0, "invariant"); 1953 } I would move the guarantee out of the 'if' statement just to reduce the amount of debugging code: guarantee(JavaThread::satb_mark_queue_set().completed_buffers_num() == 0, "invariant"); Andrey On Wednesday 07 October 2009 01:31:30 Tony Printezis wrote: > Hi all, > > Could I please get a couple of code reviews for this one? > > http://cr.openjdk.java.net/~tonyp/6888316/webrev.0/ > > The important (and very small) change is the removal of a guarantee that > is incorrect. Please have a look at the Evaluation notes on CR 6888316 > for details. > > The less important (but larger) change is the change of many guarantees > in the G1 concurrent marking code into asserts (as we should not have > that overhead in the product build). I also took this opportunity to > split some of the asserts and tidy up formatting. > > There are about 150 lines changed, but the changes are straightforward, > even though somewhat tedious to review. > > Thanks, > > Tony > > From tony.printezis at sun.com Wed Oct 7 06:45:03 2009 From: tony.printezis at sun.com (Tony Printezis) Date: Wed, 07 Oct 2009 09:45:03 -0400 Subject: CRR: 6888847: Add release_stores to task queues for the correct operation on non-TSO machines (XXXS) In-Reply-To: <4ACC0EC5.9020806@sun.com> References: <4ACBB8B2.5000709@sun.com> <19147.64204.291521.271045@sun.com> <4ACC0EC5.9020806@sun.com> Message-ID: <4ACC9B5F.7000300@sun.com> Thanks John and Igor! Igor Veresov wrote: > I agree. :) > > On 10/6/09 7:19 PM, John Coomes wrote: >> Tony Printezis (tony.printezis at sun.com) wrote: >>> The title says it all. :-) Webrev here: >>> >>> http://cr.openjdk.java.net/~tonyp/6888847/webrev.0/ >> >> Yes, looks good. >> >> -John >> > -- --------------------------------------------------------------------- | Tony Printezis, Staff Engineer | Sun Microsystems Inc. | | | MS UBUR02-311 | | e-mail: tony.printezis at sun.com | 35 Network Drive | | office: +1 781 442 0998 (x20998) | Burlington, MA 01803-2756, USA | --------------------------------------------------------------------- e-mail client: Thunderbird (Linux) From antonios.printezis at sun.com Wed Oct 7 09:25:45 2009 From: antonios.printezis at sun.com (antonios.printezis at sun.com) Date: Wed, 07 Oct 2009 16:25:45 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <20091007162552.2C09A413F7@hg.openjdk.java.net> Changeset: 4c3458a31e17 Author: tonyp Date: 2009-10-07 09:42 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/4c3458a31e17 6888316: G1: has_aborted() || _cm->region_stack_empty() fails Summary: Remove incorrect guarantee. Reviewed-by: apetrusenko, iveresov ! src/share/vm/gc_implementation/g1/concurrentMark.cpp Changeset: 11d4857fe5e1 Author: tonyp Date: 2009-10-07 10:09 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/11d4857fe5e1 6888619: G1: too many guarantees in concurrent marking Summary: change more guarantees in concurrent marking into asserts. Reviewed-by: apetrusenko, iveresov ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp From antonios.printezis at sun.com Wed Oct 7 20:28:30 2009 From: antonios.printezis at sun.com (antonios.printezis at sun.com) Date: Thu, 08 Oct 2009 03:28:30 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <20091008032837.2EE5D414B2@hg.openjdk.java.net> Changeset: 2c03ce058f55 Author: bobv Date: 2009-10-07 09:48 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/2c03ce058f55 6888847: TaskQueue needs release_store() for correctness on RMO machines Summary: See title. Reviewed-by: jmasa, ysr, jcoomes, iveresov, tonyp ! src/share/vm/utilities/taskqueue.hpp Changeset: 1ee412f7fec9 Author: tonyp Date: 2009-10-07 19:01 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1ee412f7fec9 6866190: Remove SIMPLE_STACK code from TaskQueue Summary: What the title says. We don't use SIMPLE_STACK any more. Reviewed-by: ysr ! src/share/vm/utilities/taskqueue.hpp From Vladimir.Kozlov at Sun.COM Thu Oct 8 12:31:02 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 08 Oct 2009 12:31:02 -0700 Subject: Request for reviews (XS): 6722084: JPRT make file doesn't create required symbolic link to libjvm.so Message-ID: <4ACE3DF6.7020004@sun.com> Resending to groups aliases since I did not get this mail from hotspot-dev at openjdk.java.net Sorry for spam if you got it already. Vladimir -------- Original Message -------- Subject: Request for reviews (XS): 6722084: JPRT make file doesn't create required symbolic link to libjvm.so Date: Thu, 08 Oct 2009 11:28:56 -0700 From: Vladimir Kozlov To: hotspot-dev http://cr.openjdk.java.net/~kvn/6722084/webrev.01 Fixed 6722084: JPRT make file doesn't create required symbolic link to libjvm.so Problem: There are several annoying Nightly testing failures which nobody fixing for years. Caused by hotspot JPRT build bundles have normal .so libraries instead of symbolic links as in JDK. Solution: The fix suggested by Kelly very simple: use -y zip option to preserve symbolic links. I also fixed incorrect installation of libjsig.so in JPRT build bundles which put it into client/server subdirectories. Reviewed by: Fix verified (y/n): y, JPRT From John.Coomes at sun.com Thu Oct 8 16:58:35 2009 From: John.Coomes at sun.com (John Coomes) Date: Thu, 8 Oct 2009 16:58:35 -0700 Subject: Request for reviews (XS): 6722084: JPRT make file doesn't create required symbolic link to libjvm.so In-Reply-To: <4ACE3DF6.7020004@sun.com> References: <4ACE3DF6.7020004@sun.com> Message-ID: <19150.31915.381931.831508@sun.com> Vladimir Kozlov (Vladimir.Kozlov at Sun.COM) wrote: > ... > > http://cr.openjdk.java.net/~kvn/6722084/webrev.01 > > Fixed 6722084: JPRT make file doesn't create required symbolic link to libjvm.so > > Problem: > There are several annoying Nightly testing failures which > nobody fixing for years. Caused by hotspot JPRT build bundles > have normal .so libraries instead of symbolic links as in JDK. > > Solution: > The fix suggested by Kelly very simple: use -y zip option > to preserve symbolic links. > I also fixed incorrect installation of libjsig.so > in JPRT build bundles which put it into client/server > subdirectories. Looks good to me. -John From Thomas.Rodriguez at Sun.COM Thu Oct 8 17:15:14 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Thu, 08 Oct 2009 17:15:14 -0700 Subject: Request for reviews (XS): 6722084: JPRT make file doesn't create required symbolic link to libjvm.so In-Reply-To: <4ACE3DF6.7020004@sun.com> References: <4ACE3DF6.7020004@sun.com> Message-ID: <04242EB7-DD97-4D0E-8F53-C682450511D9@sun.com> Looks good. tom On Oct 8, 2009, at 12:31 PM, Vladimir Kozlov wrote: > Resending to groups aliases since I did not get this mail from hotspot-dev at openjdk.java.net > > Sorry for spam if you got it already. > > Vladimir > > -------- Original Message -------- > Subject: Request for reviews (XS): 6722084: JPRT make file doesn't > create required symbolic link to libjvm.so > Date: Thu, 08 Oct 2009 11:28:56 -0700 > From: Vladimir Kozlov > To: hotspot-dev > > http://cr.openjdk.java.net/~kvn/6722084/webrev.01 > > Fixed 6722084: JPRT make file doesn't create required symbolic link > to libjvm.so > > Problem: > There are several annoying Nightly testing failures which > nobody fixing for years. Caused by hotspot JPRT build bundles > have normal .so libraries instead of symbolic links as in JDK. > > Solution: > The fix suggested by Kelly very simple: use -y zip option > to preserve symbolic links. > I also fixed incorrect installation of libjsig.so > in JPRT build bundles which put it into client/server > subdirectories. > > Reviewed by: > > Fix verified (y/n): y, JPRT > > From John.Coomes at sun.com Fri Oct 9 16:48:01 2009 From: John.Coomes at sun.com (John Coomes) Date: Fri, 9 Oct 2009 16:48:01 -0700 Subject: review request (L) - 6423256 GC stacks In-Reply-To: <19147.34315.675132.955543@sun.com> References: <19127.45893.964149.754611@sun.com> <19147.34315.675132.955543@sun.com> Message-ID: <19151.52145.833369.201861@sun.com> I (John.Coomes at sun.com) wrote: > John Coomes (John.Coomes at sun.com) wrote: > > I'd appreciate reviews of > > > > 6423256: GC stacks should use a better data structure > > > > http://cr.openjdk.java.net/~jcoomes/6423256-gc-stacks/ > > > > See the comments at the top of the webrev and in file stack.hpp for > > some hints/details. > > I've updated the webrev at the url above after some good review > feedback from Andrey (thanks!) and syncing with current hotspot-gc. > The changes are mostly syntactic, differences from the previous round > are summarized the top of the webrev. I've updated the above url again. A list of the changes from the previous versions and links to the earlier webrevs are on the main page. > Testing is clean. Still true. -John From Y.S.Ramakrishna at Sun.COM Mon Oct 12 08:23:51 2009 From: Y.S.Ramakrishna at Sun.COM (Y.S.Ramakrishna at Sun.COM) Date: Mon, 12 Oct 2009 08:23:51 -0700 Subject: CMS GC Log In-Reply-To: <19B27FD5AF2EAA49A66F787911CF519596D084@CTSINCHNSXUU.cts.com> References: <19B27FD5AF2EAA49A66F787911CF519596D084@CTSINCHNSXUU.cts.com> Message-ID: <4AD34A07.8050007@Sun.COM> On 10/11/09 17:58, Sujit.Das at cognizant.com wrote: > Trying to understand CMS-IM and CMS-RM log messages. > > *1. CMS Initial Mark* > 7465.472: [GC [1 CMS-initial-mark: 1370720K(2739200K)] 1384764K(3058176K), 0.0995109 secs] > In above log snippet, CMS IM was triggered at the old gen occupancy of > 1370720 K with total size of old gen size as 2739200 K. What does Right. > 1384764 K and 3058176 K represent? Current total heap occupancy and current total heap capacity. (excluding perm gen). > *2. CMS Remark* > 7475.403: [weak refs processing, 0.0024767 secs] [1 CMS-remark: > 1401865K(2739200K)] 1582866K(3058176K), 0.1290017 secs] > > Similarly in above log snippet, CMS RM was triggered at the old gen > occupancy of 1401865 K with total size of old gen size as 2739200 K. > What does 1582866 K and 3058176 K represent? Same as what i wrote above for CMS-IM. > > Also, in GC output is there any way we can determine heap space used > before and after a CMS collection? This is printed for minor collection > but not sure if this is printed for CMS collection. The above is basically all you get. Typically the free space peaks towards the end of the CMS-sweep and reaches its minimum typically around or just after the start of the sweep (i.e. around the CMS-remark phase). -- ramki > > Thanks, > Sujit > > This e-mail and any files transmitted with it are for the sole use of > the intended recipient(s) and may contain confidential and privileged > information. > If you are not the intended recipient, please contact the sender by > reply e-mail and destroy all copies of the original message. > Any unauthorized review, use, disclosure, dissemination, forwarding, > printing or copying of this email or any action taken in reliance on > this e-mail is strictly prohibited and may be unlawful. > > > ------------------------------------------------------------------------ > > _______________________________________________ > hotspot-gc-use mailing list > hotspot-gc-use at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From rainer.jung at kippdata.de Tue Oct 13 15:46:36 2009 From: rainer.jung at kippdata.de (Rainer Jung) Date: Wed, 14 Oct 2009 00:46:36 +0200 Subject: DGC and UseParallelOldGC Message-ID: <4AD5034C.7090703@kippdata.de> Hi all, if I activate the parallel stop the world collector using -XX:+UseParallelOldGC and DGC kicks in: will it run with multiple threads in parallel, or will it only run single-threaded? I know that in case I use CMS, there are ExplicitGCInvokesConcurrent and ExplicitGCInvokesConcurrentAndUnloadsClasses which also influence DGC, but I didn't find any info about the situation using parallel old GC. TIA! Regards, Rainer _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From Jon.Masamitsu at Sun.COM Tue Oct 13 16:35:34 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Tue, 13 Oct 2009 16:35:34 -0700 Subject: DGC and UseParallelOldGC In-Reply-To: <4AD5034C.7090703@kippdata.de> References: <4AD5034C.7090703@kippdata.de> Message-ID: <4AD50EC6.1020504@sun.com> Rainer Jung wrote On 10/13/09 15:46,: >Hi all, > >if I activate the parallel stop the world collector using >-XX:+UseParallelOldGC and DGC kicks in: will it run with multiple >threads in parallel, or will it only run single-threaded? > > I'm assuming you mean that you are using the throughput collector (UseParallelGC/UseParallelOldGC) in which case turning on UseParallelOldGC will use multiple threads for an explicit GC. (System.gc()). >I know that in case I use CMS, there are ExplicitGCInvokesConcurrent and >ExplicitGCInvokesConcurrentAndUnloadsClasses which also influence DGC, >but I didn't find any info about the situation using parallel old GC. > >TIA! > >Regards, > >Rainer > >_______________________________________________ >hotspot-gc-use mailing list >hotspot-gc-use at openjdk.java.net >http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use > > _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From rainer.jung at kippdata.de Tue Oct 13 18:10:08 2009 From: rainer.jung at kippdata.de (Rainer Jung) Date: Wed, 14 Oct 2009 03:10:08 +0200 Subject: DGC and UseParallelOldGC In-Reply-To: <4AD50EC6.1020504@sun.com> References: <4AD5034C.7090703@kippdata.de> <4AD50EC6.1020504@sun.com> Message-ID: <4AD524F0.4050905@kippdata.de> On 14.10.2009 01:35, Jon Masamitsu wrote: > Rainer Jung wrote On 10/13/09 15:46,: > >> Hi all, >> >> if I activate the parallel stop the world collector using >> -XX:+UseParallelOldGC and DGC kicks in: will it run with multiple >> threads in parallel, or will it only run single-threaded? > > I'm assuming you mean that you are using the throughput collector > (UseParallelGC/UseParallelOldGC) in which case turning on > UseParallelOldGC will use multiple threads for an explicit GC. > (System.gc()). Yes that was the question, but also especially for the distributed GC triggered by RMI. When using CMS you have to explicitely set flags to let DGC also use the CMS. So since UseParallelOldGC is not the default I wasn't sure, whether you need to set something in analogy to let the distributed GC also use it. Regards, Rainer _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From Jon.Masamitsu at Sun.COM Wed Oct 14 06:40:29 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Wed, 14 Oct 2009 06:40:29 -0700 Subject: DGC and UseParallelOldGC In-Reply-To: <4AD524F0.4050905@kippdata.de> References: <4AD5034C.7090703@kippdata.de> <4AD50EC6.1020504@sun.com> <4AD524F0.4050905@kippdata.de> Message-ID: <4AD5D4CD.6040501@Sun.COM> On 10/13/09 18:10, Rainer Jung wrote: > On 14.10.2009 01:35, Jon Masamitsu wrote: >> Rainer Jung wrote On 10/13/09 15:46,: >> >>> Hi all, >>> >>> if I activate the parallel stop the world collector using >>> -XX:+UseParallelOldGC and DGC kicks in: will it run with multiple >>> threads in parallel, or will it only run single-threaded? >> I'm assuming you mean that you are using the throughput collector >> (UseParallelGC/UseParallelOldGC) in which case turning on >> UseParallelOldGC will use multiple threads for an explicit GC. >> (System.gc()). > > Yes that was the question, but also especially for the distributed GC > triggered by RMI. When using CMS you have to explicitely set flags to > let DGC also use the CMS. So since UseParallelOldGC is not the default I > wasn't sure, whether you need to set something in analogy to let the > distributed GC also use it. > Yes for the distributed GC case multiple GC threads will be used. A GC triggered by RMI (for distributed GC purposes) is the same as a explicit GC (no special treatment). Similarly, when you use CMS and ExplicitGCInvokesConcurrent and/or ExplicitGCInvokesConcurrentAndUnloadsClasses all the explicit GC's are affected. _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From Y.S.Ramakrishna at Sun.COM Thu Oct 15 15:20:07 2009 From: Y.S.Ramakrishna at Sun.COM (Y.S.Ramakrishna at Sun.COM) Date: Thu, 15 Oct 2009 15:20:07 -0700 Subject: Excessive concurrent-abortable-preclean wall time? In-Reply-To: References: Message-ID: <4AD7A017.5070100@Sun.COM> Hi Jacob -- On 10/15/09 13:43, Eagle Kessler wrote: ... > Looking at the logs, it seemed that each young generation caught > around 1MB of live transient data and promoted it, and those > promotions eventually caused enough fragmentation to force a > compacting collection. The old generation was definitely not growing > between collections or anything like that, but fragmentation as the > cause is a guess on my part. From yr description I would tend to agree that that looks like a likely explanation. > > We asked ops to add -XX:MaxTenuringThreshold=2 and > -XX:SurvivorRatio=128, in the hopes that the addition of the tenuring > threshold would prevent the live transient data from being promoted. Of course, you sized SurvivorRatio so that all of that transient data (and then some) fitted in the survivor spaces (as your tenuring distribution data below showed). > When that change was applied, though, we began seeing constant, and > extremely poorly-performing, CMS collections: > > 778.842: [GC [1 CMS-initial-mark: 1403910K(2097152K)] > 1955787K(3137664K), 0.3734370 secs] The occupancy of the old gen is here ~67%, which is quite close to the occupancy of the old gen following a collection (i.e. yr program's "footprint"). For some reason CMS seems to have decided that 67% is the right level at which to initiate a CMS cycle, so you started seeing these back to back cycles. I am not sure why CMS ergonomics decided that that was the right triggering level (clearly you have managed to run successfully at a higher manually set initiating occupancy fraction of 85%, so perhaps the ergonomic trigger is being overly conserrvative). My guess is that for some reason the CMS ergonomics is perhaps doing the wrong thing here. Roughly speaking, at a high level, here's how it works -- it looks at (1) how much space is free in the old gen at the end of each scavenge (2) it tracks roughly how much our recent promotion rate (3) based on these two numbers, it calculates roughly how long we are likely to last before we run out of space in the old gen (plus possibly some safety factor) (4) it compares that with how long our recent CMS cycles have lasted and kicks off a CMS collection at the appropriate time or if it finds that CMSinitiatingOccupancyFraction setting has been exceeded. (I believe that number for 5u14 is by default 92%; so i must conclude that it is not the CMSInitiatingOccupancyFraction but the ergonomic triggering logic described above that is causing collections to kick off too early.) The workaround you used, of explictly setting CMSInitiatingOccupancyFraction and asking to use that and only that as the trigger for CMS collection via -XX:+UseCMSInitiatingOccupancyOnly (thus short-circuiting the ergonomic trigger) was indeed the right thing to do here. Unless someone else on this list knows the reason for this behaviour or has other suggestions, I'd suggest the following: (a) try the latest 5uXX (5u21 i believe), although it's unlikely its behaviour will be any different. (Aside: Note that 5uXX is approaching EOSL end of this month, so make sure to check with http://www.sun.com/software/javaforbusiness/support.jsp re support of that product going forward.) (b) try the latest 6uXX (6u16), and latest HotSpot hs17 to see if the behaviour is similar. If the behaviour w/hs17 etc is good we are all happy. If not, report the bug below. (c) file a bug if this behaviour is reproducible with (b) above, or with (1) if you have appropriate formal support. As regards :- > 2) Why did CMS-concurrent-abortable-preclean begin taking so much wall > time when CMS was running constantly? a measure of the efficacy of that phase is whether it succeeds in its objective of placing the CMS remark pause roughly mid-way between scavenges -- this reduces the occurrence of possibly back-to-back STW pauses and also tends to maximally work-balance the CMS remark. The remark pauses all seem to do a pretty good job of scheduling when the young gen is roughly 50% full. The long abortable-preclean phase is just a measure of the long inter-scavenge durations seen in this log. As the following indicates:- > 2409.982: [CMS-concurrent-abortable-preclean: 13.555/159.013 secs] CMS precleaning runs at a duty cycle of less than 10%, so it's something that you can basically ignore. (I am curious though by what you meant when stating that the new settings made the long abortable preclean go away; but the real test of the efficacy of that cycle is how it spaces apart the STW pauses and whether it's able to keep the CMS-remark pauses under control.) all the best! -- ramki _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From Y.S.Ramakrishna at Sun.COM Thu Oct 15 15:28:38 2009 From: Y.S.Ramakrishna at Sun.COM (Y.S.Ramakrishna at Sun.COM) Date: Thu, 15 Oct 2009 15:28:38 -0700 Subject: Excessive concurrent-abortable-preclean wall time? In-Reply-To: <4AD7A017.5070100@Sun.COM> References: <4AD7A017.5070100@Sun.COM> Message-ID: <4AD7A216.3030402@Sun.COM> >> >> We asked ops to add -XX:MaxTenuringThreshold=2 and >> -XX:SurvivorRatio=128, in the hopes that the addition of the tenuring >> threshold would prevent the live transient data from being promoted. This was also exactly the right thing to do to arrest possible fragmentation and, in any case, to reduce pressure on the concurrent collector. -- ramki > Of course, you sized SurvivorRatio so that all of that transient data > (and then some) fitted in the survivor spaces (as your tenuring > distribution > data below showed). _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From John.Coomes at sun.com Thu Oct 15 16:26:05 2009 From: John.Coomes at sun.com (John Coomes) Date: Thu, 15 Oct 2009 16:26:05 -0700 Subject: request for review (m) - 6858496 In-Reply-To: <4A8EE000.2060401@sun.com> References: <4A8EE000.2060401@sun.com> Message-ID: <19159.44941.633348.884255@sun.com> Jon Masamitsu (Jon.Masamitsu at Sun.COM) wrote: > Fixed 6858496: Clear all SoftReferences before an out-of-memory due to > GC overhead limit. > > Also did some tuning of the policy for out-of-memory due to GC overhead to > make it more restrictive. A successful scavenge will reset the count > on consecutive GC's needed to exceed the GC overhead limit. +1 on that change :-). > This is intended for HSX17. > > http://cr.openjdk.java.net/~jmasa/6858496/webrev.00/ The soft ref clearing changes still leave a window where softrefs may not be cleared. The clearing is done on gc N, but the OOME is thrown after gc N+1. The problem is that the decision to throw OOME because of gc overhead is made before the GC, and once made, the GC is not actually done--it simply returns NULL which ends up throwing OOME. The decision has to be made after a GC in which all softrefs were cleared. Since clearing softrefs is a language requirement, I think we need a contract between the policy and the collectors regarding softrefs. Imagine the size policy has two fields: _should_clear_all_softrefs - set to true when policy wants softrefs cleared; set to false by gc after it clears all softrefs. _all_softrefs_clear - whether the just-completed gc cleared all softrefs. This is set to true whenever a gc clears all softrefs, and set to false each time gc returns to the mutator. For example, in the ParallelScavengeHeap case the latter would be done toward the end of mem_allocate() where it returns op.result(). Each full gc would check policy->should_clear_all_softrefs() and if true, clear them. Otherwise, it would use the existing means of deciding whether to clear all softrefs. Whenever a collector clears all soft refs, it calls something like policy->cleared_all_softrefs() to record that fact. cleared_all_softrefs() is trivial: cleared_all_softrefs() { _should_clear_all_softrefs = false; _all_softrefs_clear = true; } After a gc, the decision whether to throw OOME because of the overhead limit would have to check that softrefs had been cleared. This omits some details, but ... if (op.result() != NULL) { if (gc exceeded overhead limits) { if (policy->all_softrefs_clear()) { ... reset overhead limit fields ... ... turn op.result() into a filler object ... return NULL; // Cause an OOME. } else { // clear softrefs on next full gc policy->set_should_clear_all_softrefs(true); } } } else { ... reset overhead limit fields ... } -John From john.coomes at sun.com Fri Oct 16 03:08:43 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 16 Oct 2009 10:08:43 +0000 Subject: hg: jdk7/hotspot-gc: 7 new changesets Message-ID: <20091016100843.6151F418A3@hg.openjdk.java.net> Changeset: e76b72562a98 Author: ohair Date: 2009-09-03 17:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/e76b72562a98 6855174: Improve log output when builds transition from one workspace to another Reviewed-by: jjg ! make/Defs-internal.gmk ! make/corba-rules.gmk ! make/deploy-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/jaxp-rules.gmk ! make/jaxws-rules.gmk ! make/jdk-rules.gmk ! make/langtools-rules.gmk ! make/sponsors-rules.gmk Changeset: 931f7f7501da Author: ohair Date: 2009-09-17 13:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/931f7f7501da Merge Changeset: 76f6380ac0b4 Author: xdono Date: 2009-09-18 09:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/76f6380ac0b4 Merge Changeset: d70b157f6407 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/d70b157f6407 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! make/corba-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/jaxp-rules.gmk ! make/jaxws-rules.gmk ! make/langtools-rules.gmk ! make/sponsors-rules.gmk Changeset: 3ac6dcf78232 Author: robilad Date: 2009-09-23 20:06 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/3ac6dcf78232 6872735: Further update build readme for new platforms 6641691: Bring build readme's up-to-date Summary: Added build instructions for Debian, Ubuntu 8.04, 8.10, 9.04, Fedora 10, 11, OpenSolaris 2009.06, OpenSUSE and Mandriva Reviewed-by: ohair, andrew ! README-builds.html Changeset: 2c88089b6e1c Author: xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/2c88089b6e1c Added tag jdk7-b73 for changeset 3ac6dcf78232 ! .hgtags Changeset: d1516b9f2395 Author: xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/d1516b9f2395 Added tag jdk7-b74 for changeset 2c88089b6e1c ! .hgtags From john.coomes at sun.com Fri Oct 16 03:08:48 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 16 Oct 2009 10:08:48 +0000 Subject: hg: jdk7/hotspot-gc/corba: 8 new changesets Message-ID: <20091016100856.EA628418A4@hg.openjdk.java.net> Changeset: 1c130e7b7a2e Author: ohair Date: 2009-09-02 09:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/1c130e7b7a2e 6875240: Reduce Makefile build time by limiting repeated exec's (mostly for cygwin building) Reviewed-by: jjg, iris ! make/Makefile ! make/common/BuildToolJar.gmk ! make/common/CancelImplicits.gmk ! make/common/Defs.gmk ! make/common/Rules.gmk ! make/common/shared/Compiler-msvc.gmk ! make/common/shared/Defs-utils.gmk ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Platform.gmk ! make/jprt.properties Changeset: 085333867e39 Author: xdono Date: 2009-09-14 10:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/085333867e39 Merge Changeset: 546970b224ca Author: xdono Date: 2009-09-18 09:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/546970b224ca Merge Changeset: 31ce3cac3cc1 Author: ohair Date: 2009-09-18 16:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/31ce3cac3cc1 6883790: corba build problem related to wildcard and vpath, regression Reviewed-by: tbell ! make/common/Rules.gmk Changeset: 2aa5665d86a5 Author: ohair Date: 2009-09-18 17:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/2aa5665d86a5 6883816: corba fix for missing javax/transaction/xa classes (the real fix) Reviewed-by: tbell ! make/common/Rules.gmk Changeset: b751c528c555 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/b751c528c555 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! make/common/CancelImplicits.gmk Changeset: 5d0cf59a3203 Author: xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/5d0cf59a3203 Added tag jdk7-b73 for changeset b751c528c555 ! .hgtags Changeset: 0fb137085952 Author: xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/0fb137085952 Added tag jdk7-b74 for changeset 5d0cf59a3203 ! .hgtags From john.coomes at sun.com Fri Oct 16 03:13:17 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 16 Oct 2009 10:13:17 +0000 Subject: hg: jdk7/hotspot-gc/jaxp: 6 new changesets Message-ID: <20091016101329.135BA418A6@hg.openjdk.java.net> Changeset: 534e23823a1b Author: ohair Date: 2009-09-21 13:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/534e23823a1b 6856630: Restructure jaxp/jaxws repositories Reviewed-by: darcy, tbell ! .hgignore ! README + build-defs.xml + build-drop-template.xml + build.properties + build.xml + jaxp.properties ! make/Makefile - make/build.properties - make/build.xml ! make/jprt.properties - make/tools/StripProperties/StripProperties.java - make/tools/StripProperties/StripPropertiesTask.java + nbproject/findbugs.settings + nbproject/project.xml + nbproject/sqe.properties + patches/jaxp_src/README Changeset: 0748962aa825 Author: ohair Date: 2009-09-21 17:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/0748962aa825 6884220: Have drop sources ignore the output.dir property Reviewed-by: xdono ! build.properties Changeset: ee9c7578aca5 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/ee9c7578aca5 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! src/share/classes/com/sun/org/apache/xerces/internal/impl/XMLScanner.java Changeset: feb05980f9f2 Author: ohair Date: 2009-09-28 19:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/feb05980f9f2 6886359: Missing jaxws property files and missing changes in jaxp/jaxws drop bundles Reviewed-by: jjg, tbell ! build-defs.xml ! jaxp.properties Changeset: ea7b88c676dd Author: xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/ea7b88c676dd Added tag jdk7-b73 for changeset feb05980f9f2 ! .hgtags Changeset: 555fb78ee4ce Author: xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/555fb78ee4ce Added tag jdk7-b74 for changeset ea7b88c676dd ! .hgtags From john.coomes at sun.com Fri Oct 16 03:13:33 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 16 Oct 2009 10:13:33 +0000 Subject: hg: jdk7/hotspot-gc/jaxws: 5 new changesets Message-ID: <20091016101342.60CF2418A7@hg.openjdk.java.net> Changeset: ae2bec597586 Author: ohair Date: 2009-09-21 13:57 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/ae2bec597586 6856630: Restructure jaxp/jaxws repositories Reviewed-by: darcy, tbell ! .hgignore ! README + build-defs.xml + build-drop-template.xml + build.properties + build.xml + jaxws.properties ! make/Makefile - make/build.properties - make/build.xml ! make/jprt.properties - make/tools/StripProperties/StripProperties.java - make/tools/StripProperties/StripPropertiesTask.java + nbproject/findbugs.settings + nbproject/project.xml + nbproject/sqe.properties + patches/jaxws_src/README Changeset: 77708e68db52 Author: ohair Date: 2009-09-21 17:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/77708e68db52 6884220: Have drop sources ignore the output.dir property Reviewed-by: xdono ! build.properties Changeset: 558985e26fe1 Author: ohair Date: 2009-09-28 19:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/558985e26fe1 6886359: Missing jaxws property files and missing changes in jaxp/jaxws drop bundles Reviewed-by: jjg, tbell ! build-defs.xml ! jaxws.properties Changeset: f4466e1b6080 Author: xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/f4466e1b6080 Added tag jdk7-b73 for changeset 558985e26fe1 ! .hgtags Changeset: fcf2b8b5d606 Author: xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/fcf2b8b5d606 Added tag jdk7-b74 for changeset f4466e1b6080 ! .hgtags From john.coomes at sun.com Fri Oct 16 03:17:25 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 16 Oct 2009 10:17:25 +0000 Subject: hg: jdk7/hotspot-gc/jdk: 101 new changesets Message-ID: <20091016103907.3A4BD418AF@hg.openjdk.java.net> Changeset: fdf11ce72e8e Author: mchung Date: 2009-08-06 11:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fdf11ce72e8e 4917309: (cl) Reduce internal usage of ClassNotFoundExceptions during class-loading Summary: Change findBootstrapClass to return null instead of throwing CNFE if class not found Reviewed-by: alanb, dholmes, iris ! src/share/classes/java/lang/ClassLoader.java ! src/share/javavm/export/jvm.h ! src/share/native/java/lang/ClassLoader.c Changeset: 3323e6c925f9 Author: mchung Date: 2009-08-06 16:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3323e6c925f9 6864028: Update the java launcher to use the new entry point JVM_FindClassFromBootLoader Summary: Update the java launcher to use the new entry point JVM_FindClassFromBootLoader Reviewed-by: ksrini ! src/share/bin/java.h ! src/solaris/bin/java_md.c ! src/windows/bin/java_md.c Changeset: 1f1c824e6244 Author: mchung Date: 2009-08-24 10:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1f1c824e6244 Merge - src/share/classes/com/sun/crypto/provider/JarVerifier.java - src/share/classes/javax/swing/plaf/basic/DesktopIconMover.java - src/share/classes/sun/nio/ch/AbstractFuture.java - src/share/classes/sun/security/pkcs11/JarVerifier.java - src/windows/classes/sun/security/mscapi/JarVerifier.java Changeset: 799731b1cd03 Author: mchung Date: 2009-08-27 12:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/799731b1cd03 Merge - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: dfb5cf81d8cd Author: mchung Date: 2009-09-03 16:09 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dfb5cf81d8cd Merge Changeset: b9b7f56bdfa3 Author: mchung Date: 2009-09-04 15:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b9b7f56bdfa3 Merge Changeset: 466915134131 Author: mchung Date: 2009-09-08 12:59 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/466915134131 Merge Changeset: 0d50d40a4a39 Author: martin Date: 2009-09-08 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0d50d40a4a39 6850958: Honor -XX:OnOutOfMemoryError when array size exceeds VM limit Summary: Test hotspot/jvmti fix 6850957 using ProcessBuilder test infrastructure Reviewed-by: tbell, dholmes, alanb, ysr ! test/java/lang/ProcessBuilder/Basic.java Changeset: 8252729d51a3 Author: mullan Date: 2009-09-09 09:54 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8252729d51a3 6745437: Add option to only check revocation of end-entity certificate in a chain of certificates 6869739: Cannot check revocation of single certificate without validating the entire chain Reviewed-by: xuelei + src/share/classes/sun/security/action/GetBooleanSecurityPropertyAction.java ! src/share/classes/sun/security/provider/certpath/Builder.java ! src/share/classes/sun/security/provider/certpath/CertId.java ! src/share/classes/sun/security/provider/certpath/CrlRevocationChecker.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java + src/share/classes/sun/security/provider/certpath/OCSP.java ! src/share/classes/sun/security/provider/certpath/OCSPChecker.java ! src/share/classes/sun/security/provider/certpath/OCSPRequest.java ! src/share/classes/sun/security/provider/certpath/OCSPResponse.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/provider/certpath/SunCertPathBuilder.java ! src/share/classes/sun/security/x509/AccessDescription.java Changeset: 7b85ef3d752e Author: mullan Date: 2009-09-09 09:59 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7b85ef3d752e Merge Changeset: f1eb4c28b313 Author: lancea Date: 2009-09-09 20:15 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f1eb4c28b313 6737212: Fixed javadoc warning messages in RowSet classes Reviewed-by: darcy ! src/share/classes/com/sun/rowset/JdbcRowSetResourceBundle.java ! src/share/classes/com/sun/rowset/JoinRowSetImpl.java ! src/share/classes/com/sun/rowset/internal/WebRowSetXmlReader.java ! src/share/classes/javax/sql/rowset/BaseRowSet.java Changeset: 46406871599c Author: sherman Date: 2009-09-11 16:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/46406871599c 6881337: ZipEntry.setComment() was accidentally changed back to old spec/impl in jdk7-b64 Summary: restored the correct spec and implementation of setComment Reviewed-by: martin ! src/share/classes/java/util/zip/ZipEntry.java Changeset: 020a0fed38c9 Author: martin Date: 2009-09-12 15:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/020a0fed38c9 6881442: (reflect) Race condition in Class.getName() Summary: only read "name" field racily once Reviewed-by: darcy ! src/share/classes/java/lang/Class.java Changeset: 060c4c7082ef Author: alanb Date: 2009-09-14 15:29 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/060c4c7082ef 6529758: JVMTI Waiters demo crashes. Double free. Reviewed-by: ohair, tbell ! src/share/demo/jvmti/waiters/Agent.cpp ! src/share/demo/jvmti/waiters/Agent.hpp ! src/share/demo/jvmti/waiters/Monitor.cpp ! src/share/demo/jvmti/waiters/Monitor.hpp Changeset: aac01ec2cec4 Author: alanb Date: 2009-09-14 17:47 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/aac01ec2cec4 6876541: (file) Files.walkFileTree(...): no SecurityException if read access to the starting file is denied Reviewed-by: chegar ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/Files.java + test/java/nio/file/Files/WalkWithSecurity.java + test/java/nio/file/Files/denyAll.policy + test/java/nio/file/Files/grantAll.policy + test/java/nio/file/Files/grantTopOnly.policy Changeset: eb19c5dc52bf Author: kevinw Date: 2009-09-14 20:55 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/eb19c5dc52bf 6842838: 64-bit failure in handling invalid manifest in launcher. Summary: Don't compare with hard-coded 32-bit -1 when checking zip fields. Reviewed-by: ksrini ! src/share/bin/parse_manifest.c + test/tools/launcher/6842838/CreateBadJar.java + test/tools/launcher/6842838/Test6842838.sh Changeset: c7e469ae3edb Author: mchung Date: 2009-09-14 13:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c7e469ae3edb 6878481: Add performance counters in the JDK Summary: Added new performance counters in the JDK to track performance metrics Reviewed-by: alanb, dholmes, iris, forax, andrew ! make/java/java/FILES_java.gmk ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/net/URLClassLoader.java ! src/share/classes/java/util/zip/ZipFile.java + src/share/classes/sun/misc/PerfCounter.java ! src/windows/classes/sun/java2d/d3d/D3DGraphicsDevice.java Changeset: 0a3244fe7142 Author: mchung Date: 2009-09-14 13:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0a3244fe7142 Merge Changeset: f0182203084a Author: dcubed Date: 2009-09-14 18:45 -0600 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f0182203084a 6862295: JDWP threadid changes during debugging session (leading to ingored breakpoints) Summary: New test for the above fix. Reviewed-by: tbell + test/com/sun/jdi/BreakpointWithFullGC.sh Changeset: f78b7d9973b7 Author: dcubed Date: 2009-09-14 18:54 -0600 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f78b7d9973b7 Merge Changeset: e8c2dd4b8bac Author: dcubed Date: 2009-09-15 22:11 -0600 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e8c2dd4b8bac 6882363: 4/4 typos in java.util.logging javadocs Summary: Fix typos, some grammar and some inconsistencies in phrasing. Reviewed-by: tbell ! src/share/classes/java/util/logging/ErrorManager.java ! src/share/classes/java/util/logging/FileHandler.java ! src/share/classes/java/util/logging/Formatter.java ! src/share/classes/java/util/logging/Handler.java ! src/share/classes/java/util/logging/Level.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/java/util/logging/Logger.java ! src/share/classes/java/util/logging/LoggingMXBean.java ! src/share/classes/java/util/logging/MemoryHandler.java ! src/share/classes/java/util/logging/StreamHandler.java Changeset: 81b85ea694f8 Author: tbell Date: 2009-09-16 09:23 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/81b85ea694f8 Merge Changeset: ee68feef41d2 Author: jccollet Date: 2009-09-18 10:51 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ee68feef41d2 6737819: sun.misc.net.DefaultProxySelector doesn't use proxy setting to localhost Summary: Move default nonProxyHosts from hardcoded to property default value Reviewed-by: chegar ! src/share/classes/java/net/doc-files/net-properties.html ! src/share/classes/sun/net/spi/DefaultProxySelector.java ! src/share/lib/net.properties + test/java/net/ProxySelector/B6737819.java Changeset: 39c15c0a71f7 Author: andrew Date: 2009-09-10 19:04 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/39c15c0a71f7 6882745: Add DISABLE_INTREE_EC option to make new EC provider optional. Summary: Don't build the ec subdirectory when DISABLE_INTREE_EC is defined. Reviewed-by: vinnie ! make/sun/security/Makefile Changeset: f119e21c0ca7 Author: tbell Date: 2009-09-18 08:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f119e21c0ca7 Merge Changeset: c9cbd2a09fd4 Author: chegar Date: 2009-09-18 16:24 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c9cbd2a09fd4 6882609: Move default InMemoryCookieStore to java.net Summary: remove static dependency on sun.net.www.protocol.http Reviewed-by: alanb, jccollet ! make/sun/net/FILES_java.gmk ! src/share/classes/java/net/CookieManager.java + src/share/classes/java/net/InMemoryCookieStore.java - src/share/classes/sun/net/www/protocol/http/InMemoryCookieStore.java Changeset: 9cd7133ea287 Author: chegar Date: 2009-09-18 22:18 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9cd7133ea287 6882594: Remove static dependancy on NTLM authentication Reviewed-by: alanb, weijun ! make/sun/net/FILES_java.gmk ! src/share/classes/sun/net/www/protocol/http/AuthCache.java ! src/share/classes/sun/net/www/protocol/http/AuthCacheValue.java + src/share/classes/sun/net/www/protocol/http/AuthScheme.java ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java + src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java ! src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java ! src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java Changeset: 45a343706f73 Author: chegar Date: 2009-09-18 22:19 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/45a343706f73 Merge Changeset: d3281fa8e46c Author: mchung Date: 2009-09-17 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d3281fa8e46c 6882376: Add internal support for JRE implementation to eliminate the dependency on logging Summary: Added sun.util.logging.PlatformLogger for JRE implementation to log messages. Reviewed-by: alanb, naoto ! make/java/logging/Makefile ! src/share/classes/java/util/Currency.java ! src/share/classes/java/util/jar/Attributes.java ! src/share/classes/java/util/logging/LogManager.java ! src/share/classes/java/util/logging/LogRecord.java ! src/share/classes/sun/util/LocaleServiceProviderPool.java + src/share/classes/sun/util/logging/PlatformLogger.java ! src/windows/classes/java/util/prefs/WindowsPreferences.java + test/sun/util/logging/PlatformLoggerTest.java Changeset: 7b4e73ca6fd7 Author: mchung Date: 2009-09-18 17:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7b4e73ca6fd7 Merge Changeset: 845fefff00a4 Author: vinnie Date: 2009-09-21 23:01 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/845fefff00a4 6884175: CR cleanup for 6840752: Provide out-of-the-box support for ECC algorithms Reviewed-by: wetmore ! make/sun/security/ec/Makefile ! make/sun/security/other/Makefile ! src/share/classes/sun/security/ec/ECDHKeyAgreement.java ! src/share/classes/sun/security/ec/ECDSASignature.java ! src/share/classes/sun/security/ec/ECKeyPairGenerator.java ! src/share/classes/sun/security/ec/SunEC.java ! src/share/classes/sun/security/ec/SunECEntries.java ! src/share/native/sun/security/ec/ECC_JNI.cpp - src/share/native/sun/security/ec/ec.c + src/share/native/sun/security/ec/impl/ec.c + src/share/native/sun/security/ec/impl/ec.h + src/share/native/sun/security/ec/impl/ec2.h + src/share/native/sun/security/ec/impl/ec2_163.c + src/share/native/sun/security/ec/impl/ec2_193.c + src/share/native/sun/security/ec/impl/ec2_233.c + src/share/native/sun/security/ec/impl/ec2_aff.c + src/share/native/sun/security/ec/impl/ec2_mont.c + src/share/native/sun/security/ec/impl/ec_naf.c + src/share/native/sun/security/ec/impl/ecc_impl.h + src/share/native/sun/security/ec/impl/ecdecode.c + src/share/native/sun/security/ec/impl/ecl-curve.h + src/share/native/sun/security/ec/impl/ecl-exp.h + src/share/native/sun/security/ec/impl/ecl-priv.h + src/share/native/sun/security/ec/impl/ecl.c + src/share/native/sun/security/ec/impl/ecl.h + src/share/native/sun/security/ec/impl/ecl_curve.c + src/share/native/sun/security/ec/impl/ecl_gf.c + src/share/native/sun/security/ec/impl/ecl_mult.c + src/share/native/sun/security/ec/impl/ecp.h + src/share/native/sun/security/ec/impl/ecp_192.c + src/share/native/sun/security/ec/impl/ecp_224.c + src/share/native/sun/security/ec/impl/ecp_256.c + src/share/native/sun/security/ec/impl/ecp_384.c + src/share/native/sun/security/ec/impl/ecp_521.c + src/share/native/sun/security/ec/impl/ecp_aff.c + src/share/native/sun/security/ec/impl/ecp_jac.c + src/share/native/sun/security/ec/impl/ecp_jm.c + src/share/native/sun/security/ec/impl/ecp_mont.c + src/share/native/sun/security/ec/impl/logtab.h + src/share/native/sun/security/ec/impl/mp_gf2m-priv.h + src/share/native/sun/security/ec/impl/mp_gf2m.c + src/share/native/sun/security/ec/impl/mp_gf2m.h + src/share/native/sun/security/ec/impl/mpi-config.h + src/share/native/sun/security/ec/impl/mpi-priv.h + src/share/native/sun/security/ec/impl/mpi.c + src/share/native/sun/security/ec/impl/mpi.h + src/share/native/sun/security/ec/impl/mplogic.c + src/share/native/sun/security/ec/impl/mplogic.h + src/share/native/sun/security/ec/impl/mpmontg.c + src/share/native/sun/security/ec/impl/mpprime.h + src/share/native/sun/security/ec/impl/oid.c + src/share/native/sun/security/ec/impl/secitem.c + src/share/native/sun/security/ec/impl/secoidt.h ! test/sun/security/ec/TestEC.java + test/sun/security/ec/certs/sunlabscerts.pem + test/sun/security/ec/keystore + test/sun/security/ec/truststore ! test/sun/security/pkcs11/ec/ReadCertificates.java ! test/sun/security/pkcs11/sslecc/CipherTest.java Changeset: 81dffe63c913 Author: weijun Date: 2009-09-22 10:01 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/81dffe63c913 6877357: IPv6 address does not work Reviewed-by: xuelei, alanb ! src/share/classes/sun/security/krb5/KrbKdcReq.java + test/sun/security/krb5/IPv6.java Changeset: 023063a403ed Author: chegar Date: 2009-09-22 14:42 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/023063a403ed 6882654: Remove dependency on java.util.concurrent from KeepAlive implementaion Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.java ! src/share/classes/sun/net/www/http/KeepAliveStream.java ! src/share/classes/sun/net/www/http/KeepAliveStreamCleaner.java Changeset: 44ccaa4bb8a0 Author: chegar Date: 2009-09-22 14:49 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/44ccaa4bb8a0 6882384: Update http protocol handler to use PlatformLogger Reviewed-by: jccollet, alanb ! src/share/classes/sun/net/www/http/HttpCapture.java ! src/share/classes/sun/net/www/http/HttpClient.java ! src/share/classes/sun/net/www/protocol/http/HttpLogFormatter.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/NTLMAuthenticationProxy.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: b8004f6f4812 Author: kevinw Date: 2009-09-22 17:01 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b8004f6f4812 6882768: (launcher) test for 6842838 is broken Summary: Testcase correction. Reviewed-by: ksrini ! test/tools/launcher/6842838/Test6842838.sh Changeset: f708138c9aca Author: kevinw Date: 2009-09-22 17:16 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f708138c9aca Merge Changeset: 59b45d636384 Author: xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/59b45d636384 Added tag jdk7-b73 for changeset f708138c9aca ! .hgtags Changeset: 8e5d45fc8d1e Author: jgodinez Date: 2009-07-01 12:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8e5d45fc8d1e 6848799: Reg-test java/awt/print/PageFormat/PageFormatFromAttributes.java fails on Rhel_5 Reviewed-by: tdv, prr ! src/solaris/classes/sun/print/IPPPrintService.java + test/java/awt/print/PageFormat/PageFormatFromAttributes.java Changeset: 837bb8760bad Author: yan Date: 2009-07-13 09:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/837bb8760bad Merge - src/share/classes/java/nio/file/DirectoryStreamFilters.java - src/share/classes/java/nio/file/FileAction.java - src/share/classes/java/nio/file/spi/AbstractPath.java - src/share/classes/sun/io/ByteToCharMS932DB.java - src/share/classes/sun/io/CharToByteMS932DB.java - src/share/classes/sun/nio/cs/ext/EUC_CN.java - src/share/classes/sun/nio/cs/ext/EUC_KR.java - src/share/classes/sun/nio/cs/ext/GBK.java - src/share/classes/sun/nio/cs/ext/Johab.java - src/share/classes/sun/nio/cs/ext/MS932.java - src/share/classes/sun/nio/cs/ext/MS932DB.java - src/share/classes/sun/nio/cs/ext/MS936.java - src/share/classes/sun/nio/cs/ext/MS949.java - src/share/classes/sun/nio/cs/ext/MS950.java - src/share/classes/sun/nio/fs/AbstractFileStoreSpaceAttributeView.java - src/share/classes/sun/nio/fs/MimeType.java - src/share/classes/sun/swing/AccessibleMethod.java - test/java/nio/file/DirectoryStream/Filters.java - test/java/nio/file/Files/content_type.sh - test/java/nio/file/Path/temporary_files.sh - test/java/nio/file/attribute/Attributes/Basic.java Changeset: a0b315ecdc78 Author: rkennke Date: 2009-07-22 15:52 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a0b315ecdc78 6857358: Two testcases are failing in jdk7 b64 pit build with java.security.AccessControlException Summary: Try to load GraphicsEnvironment with bootclassloader first, only then try app classloader. Reviewed-by: prr, tdv, igor ! src/share/classes/java/awt/GraphicsEnvironment.java Changeset: 9fa696ed1f38 Author: jgodinez Date: 2009-07-30 12:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9fa696ed1f38 Merge Changeset: 7fe0497ee5b5 Author: jgodinez Date: 2009-08-04 17:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7fe0497ee5b5 6829673: ThinLineTest: A line < 1 pixel disappears. Reviewed-by: igor, prr Contributed-by: rkennke ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java + test/sun/pisces/ThinLineTest.java Changeset: 64b0c953635d Author: rkennke Date: 2009-08-07 18:31 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/64b0c953635d 6795908: Refactor FontManager Reviewed-by: prr, igor ! make/sun/awt/FILES_export_windows.gmk ! make/sun/awt/make.depend ! make/sun/awt/mapfile-mawt-vers ! make/sun/awt/mapfile-vers-linux ! make/sun/font/mapfile-vers ! make/sun/font/mapfile-vers.openjdk ! make/sun/headless/mapfile-vers ! make/sun/xawt/mapfile-vers ! src/share/classes/com/sun/java/swing/plaf/gtk/PangoFonts.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Font.java ! src/share/classes/java/awt/GraphicsEnvironment.java ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template ! src/share/classes/javax/swing/text/StyleContext.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/font/CMap.java ! src/share/classes/sun/font/CompositeFont.java ! src/share/classes/sun/font/CompositeGlyphMapper.java ! src/share/classes/sun/font/FileFont.java ! src/share/classes/sun/font/FileFontStrike.java ! src/share/classes/sun/font/FontDesignMetrics.java ! src/share/classes/sun/font/FontFamily.java ! src/share/classes/sun/font/FontManager.java ! src/share/classes/sun/font/FontManagerNativeLibrary.java ! src/share/classes/sun/font/FontResolver.java ! src/share/classes/sun/font/FontScaler.java ! src/share/classes/sun/font/FreetypeFontScaler.java ! src/share/classes/sun/font/GlyphLayout.java ! src/share/classes/sun/font/PhysicalStrike.java ! src/share/classes/sun/font/StandardGlyphVector.java ! src/share/classes/sun/font/StrikeCache.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/font/TrueTypeGlyphMapper.java ! src/share/classes/sun/font/Type1Font.java ! src/share/classes/sun/font/Type1GlyphMapper.java ! src/share/classes/sun/java2d/SunGraphics2D.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/share/classes/sun/print/PSPrinterJob.java ! src/share/classes/sun/print/PathGraphics.java ! src/share/classes/sun/swing/SwingUtilities2.java ! src/share/native/sun/font/sunFont.c ! src/share/native/sun/font/sunfontids.h ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java ! src/solaris/classes/sun/awt/motif/MToolkit.java ! src/solaris/classes/sun/font/FcFontConfiguration.java ! src/solaris/classes/sun/font/NativeFont.java ! src/solaris/classes/sun/font/NativeStrike.java ! src/solaris/native/sun/awt/fontpath.c ! src/windows/classes/sun/awt/Win32GraphicsEnvironment.java ! src/windows/classes/sun/awt/windows/WFontConfiguration.java ! src/windows/classes/sun/awt/windows/WPathGraphics.java ! src/windows/classes/sun/awt/windows/WPrinterJob.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/native/sun/font/fontpath.c ! src/windows/native/sun/windows/awt_Win32GraphicsEnv.cpp Changeset: 92607d652d7a Author: rkennke Date: 2009-08-07 19:36 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/92607d652d7a 6869705: Missing files of CR6795908, FontManager refactoring Reviewed-by: prr, igor + src/share/classes/sun/font/FontAccess.java + src/share/classes/sun/font/FontManagerFactory.java + src/share/classes/sun/font/FontManagerForSGE.java + src/share/classes/sun/font/FontUtilities.java + src/share/classes/sun/font/SunFontManager.java + src/solaris/classes/sun/awt/X11FontManager.java + src/solaris/classes/sun/font/FontConfigManager.java + src/windows/classes/sun/awt/Win32FontManager.java Changeset: 11b38980893c Author: rkennke Date: 2009-08-12 17:21 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/11b38980893c 6870238: Font2DTest fails on Debian after FontManager refactoring Summary: Use fontManager field instead of querying the FontManagerFactory Reviewed-by: igor, prr ! src/solaris/classes/sun/font/FcFontConfiguration.java Changeset: a389af17df10 Author: prr Date: 2009-08-14 14:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a389af17df10 6867603: sun.font.FontManager.getDefaultPlatformFont throws NPE in OpenJDK on Solaris 10 10/08 Reviewed-by: igor, jgodinez ! src/solaris/classes/sun/font/FontConfigManager.java ! src/solaris/native/sun/awt/fontpath.c Changeset: e90f58148115 Author: jgodinez Date: 2009-09-16 19:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e90f58148115 Merge - make/javax/swing/plaf/nimbus/Makefile - make/tools/swing-nimbus/Makefile - make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java - src/share/classes/com/sun/crypto/provider/JarVerifier.java ! src/share/classes/com/sun/java/swing/plaf/windows/WindowsLookAndFeel.java ! src/share/classes/java/awt/Component.java - src/share/classes/javax/swing/plaf/basic/DesktopIconMover.java ! src/share/classes/javax/swing/plaf/nimbus/Defaults.template - src/share/classes/sun/nio/ch/AbstractFuture.java - src/share/classes/sun/security/pkcs11/JarVerifier.java ! src/share/classes/sun/swing/SwingUtilities2.java - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h ! src/solaris/classes/sun/awt/X11/XToolkit.java - src/windows/classes/sun/security/mscapi/JarVerifier.java - test/java/util/concurrent/ConcurrentLinkedQueue/ConcurrentQueueLoops.java - test/java/util/concurrent/ConcurrentLinkedQueue/LoopHelpers.java - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: 27d58a02bb9d Author: srl Date: 2009-09-28 11:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/27d58a02bb9d 6795060: VM crash on Linux in ICU layout library when processing \u0DDD (Sinhalese) Reviewed-by: igor, prr ! src/share/native/sun/font/layout/IndicClassTables.cpp + test/java/awt/font/TextLayout/TestSinhalaChar.java Changeset: e6ced7714609 Author: jgodinez Date: 2009-09-29 09:02 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e6ced7714609 Merge - src/share/classes/sun/net/www/protocol/http/InMemoryCookieStore.java - src/share/native/sun/security/ec/ec.c Changeset: c74d38ef118c Author: srl Date: 2009-09-29 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c74d38ef118c 6501644: sync LayoutEngine *code* structure to match ICU Reviewed-by: prr ! make/sun/font/Makefile ! src/share/native/sun/font/layout/AlternateSubstSubtables.cpp ! src/share/native/sun/font/layout/AlternateSubstSubtables.h ! src/share/native/sun/font/layout/AnchorTables.cpp ! src/share/native/sun/font/layout/AnchorTables.h ! src/share/native/sun/font/layout/ArabicLayoutEngine.cpp ! src/share/native/sun/font/layout/ArabicLayoutEngine.h ! src/share/native/sun/font/layout/ArabicShaping.cpp ! src/share/native/sun/font/layout/ArabicShaping.h ! src/share/native/sun/font/layout/AttachmentPosnSubtables.h ! src/share/native/sun/font/layout/CanonData.cpp ! src/share/native/sun/font/layout/CanonShaping.cpp ! src/share/native/sun/font/layout/CanonShaping.h ! src/share/native/sun/font/layout/CharSubstitutionFilter.h ! src/share/native/sun/font/layout/ClassDefinitionTables.cpp ! src/share/native/sun/font/layout/ClassDefinitionTables.h ! src/share/native/sun/font/layout/ContextualGlyphInsertion.h ! src/share/native/sun/font/layout/ContextualGlyphSubstProc.cpp ! src/share/native/sun/font/layout/ContextualGlyphSubstProc.h ! src/share/native/sun/font/layout/ContextualGlyphSubstitution.h ! src/share/native/sun/font/layout/ContextualSubstSubtables.cpp ! src/share/native/sun/font/layout/ContextualSubstSubtables.h ! src/share/native/sun/font/layout/CoverageTables.cpp ! src/share/native/sun/font/layout/CoverageTables.h ! src/share/native/sun/font/layout/CursiveAttachmentSubtables.cpp ! src/share/native/sun/font/layout/CursiveAttachmentSubtables.h ! src/share/native/sun/font/layout/DefaultCharMapper.h ! src/share/native/sun/font/layout/DeviceTables.cpp ! src/share/native/sun/font/layout/DeviceTables.h ! src/share/native/sun/font/layout/ExtensionSubtables.cpp ! src/share/native/sun/font/layout/ExtensionSubtables.h ! src/share/native/sun/font/layout/Features.cpp ! src/share/native/sun/font/layout/Features.h ! src/share/native/sun/font/layout/GDEFMarkFilter.cpp ! src/share/native/sun/font/layout/GDEFMarkFilter.h ! src/share/native/sun/font/layout/GXLayoutEngine.cpp ! src/share/native/sun/font/layout/GXLayoutEngine.h ! src/share/native/sun/font/layout/GlyphDefinitionTables.cpp ! src/share/native/sun/font/layout/GlyphDefinitionTables.h ! src/share/native/sun/font/layout/GlyphIterator.cpp ! src/share/native/sun/font/layout/GlyphIterator.h ! src/share/native/sun/font/layout/GlyphLookupTables.cpp ! src/share/native/sun/font/layout/GlyphLookupTables.h ! src/share/native/sun/font/layout/GlyphPositionAdjustments.cpp ! src/share/native/sun/font/layout/GlyphPositionAdjustments.h ! src/share/native/sun/font/layout/GlyphPositioningTables.cpp ! src/share/native/sun/font/layout/GlyphPositioningTables.h ! src/share/native/sun/font/layout/GlyphPosnLookupProc.cpp ! src/share/native/sun/font/layout/GlyphPosnLookupProc.h ! src/share/native/sun/font/layout/GlyphSubstLookupProc.cpp ! src/share/native/sun/font/layout/GlyphSubstLookupProc.h ! src/share/native/sun/font/layout/GlyphSubstitutionTables.cpp ! src/share/native/sun/font/layout/GlyphSubstitutionTables.h ! src/share/native/sun/font/layout/HanLayoutEngine.cpp ! src/share/native/sun/font/layout/HanLayoutEngine.h ! src/share/native/sun/font/layout/IndicClassTables.cpp ! src/share/native/sun/font/layout/IndicLayoutEngine.cpp ! src/share/native/sun/font/layout/IndicLayoutEngine.h ! src/share/native/sun/font/layout/IndicRearrangement.h ! src/share/native/sun/font/layout/IndicRearrangementProcessor.cpp ! src/share/native/sun/font/layout/IndicRearrangementProcessor.h ! src/share/native/sun/font/layout/IndicReordering.cpp ! src/share/native/sun/font/layout/IndicReordering.h ! src/share/native/sun/font/layout/KernTable.cpp ! src/share/native/sun/font/layout/KernTable.h ! src/share/native/sun/font/layout/KhmerLayoutEngine.cpp ! src/share/native/sun/font/layout/KhmerLayoutEngine.h ! src/share/native/sun/font/layout/KhmerReordering.cpp ! src/share/native/sun/font/layout/KhmerReordering.h ! src/share/native/sun/font/layout/LEFontInstance.cpp ! src/share/native/sun/font/layout/LEFontInstance.h ! src/share/native/sun/font/layout/LEGlyphFilter.h ! src/share/native/sun/font/layout/LEGlyphStorage.cpp ! src/share/native/sun/font/layout/LEGlyphStorage.h ! src/share/native/sun/font/layout/LEInsertionList.cpp ! src/share/native/sun/font/layout/LEInsertionList.h ! src/share/native/sun/font/layout/LELanguages.h ! src/share/native/sun/font/layout/LEScripts.h + src/share/native/sun/font/layout/LEStandalone.h ! src/share/native/sun/font/layout/LESwaps.h ! src/share/native/sun/font/layout/LETypes.h ! src/share/native/sun/font/layout/LayoutEngine.cpp ! src/share/native/sun/font/layout/LayoutEngine.h ! src/share/native/sun/font/layout/LayoutTables.h ! src/share/native/sun/font/layout/LigatureSubstProc.cpp ! src/share/native/sun/font/layout/LigatureSubstProc.h ! src/share/native/sun/font/layout/LigatureSubstSubtables.cpp ! src/share/native/sun/font/layout/LigatureSubstSubtables.h ! src/share/native/sun/font/layout/LigatureSubstitution.h ! src/share/native/sun/font/layout/LookupProcessor.cpp ! src/share/native/sun/font/layout/LookupProcessor.h ! src/share/native/sun/font/layout/LookupTables.cpp ! src/share/native/sun/font/layout/LookupTables.h ! src/share/native/sun/font/layout/Lookups.cpp ! src/share/native/sun/font/layout/Lookups.h ! src/share/native/sun/font/layout/MPreFixups.cpp ! src/share/native/sun/font/layout/MPreFixups.h ! src/share/native/sun/font/layout/MarkArrays.cpp ! src/share/native/sun/font/layout/MarkArrays.h ! src/share/native/sun/font/layout/MarkToBasePosnSubtables.cpp ! src/share/native/sun/font/layout/MarkToBasePosnSubtables.h ! src/share/native/sun/font/layout/MarkToLigaturePosnSubtables.cpp ! src/share/native/sun/font/layout/MarkToLigaturePosnSubtables.h ! src/share/native/sun/font/layout/MarkToMarkPosnSubtables.cpp ! src/share/native/sun/font/layout/MarkToMarkPosnSubtables.h ! src/share/native/sun/font/layout/MirroredCharData.cpp ! src/share/native/sun/font/layout/MorphStateTables.h ! src/share/native/sun/font/layout/MorphTables.cpp ! src/share/native/sun/font/layout/MorphTables.h ! src/share/native/sun/font/layout/MultipleSubstSubtables.cpp ! src/share/native/sun/font/layout/MultipleSubstSubtables.h ! src/share/native/sun/font/layout/NonContextualGlyphSubst.h ! src/share/native/sun/font/layout/NonContextualGlyphSubstProc.cpp ! src/share/native/sun/font/layout/NonContextualGlyphSubstProc.h ! src/share/native/sun/font/layout/OpenTypeLayoutEngine.cpp ! src/share/native/sun/font/layout/OpenTypeLayoutEngine.h ! src/share/native/sun/font/layout/OpenTypeTables.h ! src/share/native/sun/font/layout/OpenTypeUtilities.cpp ! src/share/native/sun/font/layout/OpenTypeUtilities.h ! src/share/native/sun/font/layout/PairPositioningSubtables.cpp ! src/share/native/sun/font/layout/PairPositioningSubtables.h ! src/share/native/sun/font/layout/ScriptAndLanguage.cpp ! src/share/native/sun/font/layout/ScriptAndLanguage.h ! src/share/native/sun/font/layout/ScriptAndLanguageTags.cpp ! src/share/native/sun/font/layout/ScriptAndLanguageTags.h ! src/share/native/sun/font/layout/SegmentArrayProcessor.cpp ! src/share/native/sun/font/layout/SegmentArrayProcessor.h ! src/share/native/sun/font/layout/SegmentSingleProcessor.cpp ! src/share/native/sun/font/layout/SegmentSingleProcessor.h ! src/share/native/sun/font/layout/ShapingTypeData.cpp ! src/share/native/sun/font/layout/SimpleArrayProcessor.cpp ! src/share/native/sun/font/layout/SimpleArrayProcessor.h ! src/share/native/sun/font/layout/SinglePositioningSubtables.cpp ! src/share/native/sun/font/layout/SinglePositioningSubtables.h ! src/share/native/sun/font/layout/SingleSubstitutionSubtables.cpp ! src/share/native/sun/font/layout/SingleSubstitutionSubtables.h ! src/share/native/sun/font/layout/SingleTableProcessor.cpp ! src/share/native/sun/font/layout/SingleTableProcessor.h ! src/share/native/sun/font/layout/StateTableProcessor.cpp ! src/share/native/sun/font/layout/StateTableProcessor.h ! src/share/native/sun/font/layout/StateTables.h ! src/share/native/sun/font/layout/SubstitutionLookups.cpp ! src/share/native/sun/font/layout/SubstitutionLookups.h ! src/share/native/sun/font/layout/SubtableProcessor.cpp ! src/share/native/sun/font/layout/SubtableProcessor.h ! src/share/native/sun/font/layout/ThaiLayoutEngine.cpp ! src/share/native/sun/font/layout/ThaiLayoutEngine.h ! src/share/native/sun/font/layout/ThaiShaping.cpp ! src/share/native/sun/font/layout/ThaiShaping.h ! src/share/native/sun/font/layout/ThaiStateTables.cpp ! src/share/native/sun/font/layout/TrimmedArrayProcessor.cpp ! src/share/native/sun/font/layout/TrimmedArrayProcessor.h ! src/share/native/sun/font/layout/ValueRecords.cpp ! src/share/native/sun/font/layout/ValueRecords.h Changeset: e8a764450aa7 Author: srl Date: 2009-09-29 15:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e8a764450aa7 Merge - src/share/classes/sun/net/www/protocol/http/InMemoryCookieStore.java - src/share/native/sun/security/ec/ec.c Changeset: e8b1b4c00e8a Author: srl Date: 2009-09-29 16:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e8b1b4c00e8a 6886718: missing license info Reviewed-by: igor, prr ! test/java/awt/font/TextLayout/TestSinhalaChar.java Changeset: ec67b240b727 Author: mchung Date: 2009-09-29 16:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ec67b240b727 6879044: Eliminate the dependency on logging from the AWT/2D/Swing classes Summary: Replace calls to Logger with sun.util.logging.PlatformLogger Reviewed-by: prr, art, alexp, dcherepanov, igor, dav, anthony ! src/share/classes/java/awt/AWTEvent.java ! src/share/classes/java/awt/AttributeValue.java ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/ContainerOrderFocusTraversalPolicy.java ! src/share/classes/java/awt/Cursor.java ! src/share/classes/java/awt/DefaultKeyboardFocusManager.java ! src/share/classes/java/awt/EventDispatchThread.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/java/awt/KeyboardFocusManager.java ! src/share/classes/java/awt/SplashScreen.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/awt/event/InputEvent.java ! src/share/classes/javax/swing/BufferStrategyPaintManager.java ! src/share/classes/javax/swing/SortingFocusTraversalPolicy.java ! src/share/classes/sun/awt/AWTAutoShutdown.java ! src/share/classes/sun/awt/AppContext.java ! src/share/classes/sun/awt/ComponentAccessor.java ! src/share/classes/sun/awt/DebugSettings.java ! src/share/classes/sun/awt/FontConfiguration.java ! src/share/classes/sun/awt/KeyboardFocusManagerPeerImpl.java ! src/share/classes/sun/awt/ScrollPaneWheelScroller.java ! src/share/classes/sun/awt/SunDisplayChanger.java ! src/share/classes/sun/awt/SunGraphicsCallback.java ! src/share/classes/sun/awt/SunToolkit.java ! src/share/classes/sun/awt/WindowAccessor.java ! src/share/classes/sun/awt/datatransfer/DataTransferer.java ! src/share/classes/sun/awt/dnd/SunDropTargetContextPeer.java ! src/share/classes/sun/awt/im/InputContext.java ! src/share/classes/sun/font/FontUtilities.java ! src/share/classes/sun/font/SunFontManager.java ! src/share/classes/sun/font/TrueTypeFont.java ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11/InfoWindow.java ! src/solaris/classes/sun/awt/X11/ListHelper.java ! src/solaris/classes/sun/awt/X11/UnsafeXDisposerRecord.java ! src/solaris/classes/sun/awt/X11/XAWTXSettings.java ! src/solaris/classes/sun/awt/X11/XBaseMenuWindow.java ! src/solaris/classes/sun/awt/X11/XBaseWindow.java ! src/solaris/classes/sun/awt/X11/XCheckboxMenuItemPeer.java ! src/solaris/classes/sun/awt/X11/XCheckboxPeer.java ! src/solaris/classes/sun/awt/X11/XChoicePeer.java ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XContentWindow.java ! src/solaris/classes/sun/awt/X11/XDecoratedPeer.java ! src/solaris/classes/sun/awt/X11/XDnDDragSourceProtocol.java ! src/solaris/classes/sun/awt/X11/XDnDDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDragSourceContextPeer.java ! src/solaris/classes/sun/awt/X11/XDropTargetContextPeer.java ! src/solaris/classes/sun/awt/X11/XDropTargetProtocol.java ! src/solaris/classes/sun/awt/X11/XDropTargetRegistry.java ! src/solaris/classes/sun/awt/X11/XEmbedCanvasPeer.java ! src/solaris/classes/sun/awt/X11/XEmbedClientHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedHelper.java ! src/solaris/classes/sun/awt/X11/XEmbedServerTester.java ! src/solaris/classes/sun/awt/X11/XEmbeddedFramePeer.java ! src/solaris/classes/sun/awt/X11/XFileDialogPeer.java ! src/solaris/classes/sun/awt/X11/XFocusProxyWindow.java ! src/solaris/classes/sun/awt/X11/XFramePeer.java ! src/solaris/classes/sun/awt/X11/XIconWindow.java ! src/solaris/classes/sun/awt/X11/XInputMethod.java ! src/solaris/classes/sun/awt/X11/XKeyboardFocusManagerPeer.java ! src/solaris/classes/sun/awt/X11/XKeysym.java ! src/solaris/classes/sun/awt/X11/XListPeer.java ! src/solaris/classes/sun/awt/X11/XMSelection.java ! src/solaris/classes/sun/awt/X11/XMenuBarPeer.java ! src/solaris/classes/sun/awt/X11/XMenuItemPeer.java ! src/solaris/classes/sun/awt/X11/XMenuPeer.java ! src/solaris/classes/sun/awt/X11/XMenuWindow.java ! src/solaris/classes/sun/awt/X11/XNETProtocol.java ! src/solaris/classes/sun/awt/X11/XPopupMenuPeer.java ! src/solaris/classes/sun/awt/X11/XProtocol.java ! src/solaris/classes/sun/awt/X11/XQueryTree.java ! src/solaris/classes/sun/awt/X11/XScrollbar.java ! src/solaris/classes/sun/awt/X11/XScrollbarPeer.java ! src/solaris/classes/sun/awt/X11/XSystemTrayPeer.java ! src/solaris/classes/sun/awt/X11/XTextFieldPeer.java ! src/solaris/classes/sun/awt/X11/XToolkit.java ! src/solaris/classes/sun/awt/X11/XTrayIconPeer.java ! src/solaris/classes/sun/awt/X11/XWINProtocol.java ! src/solaris/classes/sun/awt/X11/XWM.java ! src/solaris/classes/sun/awt/X11/XWindow.java ! src/solaris/classes/sun/awt/X11/XWindowPeer.java ! src/solaris/classes/sun/awt/X11/XWrapperBase.java ! src/solaris/classes/sun/awt/X11/generator/WrapperGenerator.java ! src/solaris/classes/sun/awt/X11/keysym2ucs.h ! src/solaris/classes/sun/awt/X11FontManager.java ! src/solaris/classes/sun/awt/X11GraphicsEnvironment.java ! src/solaris/classes/sun/awt/X11InputMethod.java ! src/solaris/classes/sun/awt/motif/MFontConfiguration.java ! src/solaris/classes/sun/awt/motif/MToolkit.java ! src/solaris/classes/sun/font/FcFontConfiguration.java ! src/solaris/classes/sun/font/FontConfigManager.java ! src/windows/classes/sun/awt/windows/WComponentPeer.java ! src/windows/classes/sun/awt/windows/WDesktopProperties.java ! src/windows/classes/sun/awt/windows/WMenuItemPeer.java ! src/windows/classes/sun/awt/windows/WPanelPeer.java ! src/windows/classes/sun/awt/windows/WScrollPanePeer.java ! src/windows/classes/sun/awt/windows/WToolkit.java ! src/windows/classes/sun/awt/windows/WWindowPeer.java Changeset: 5b52851b0927 Author: mchung Date: 2009-09-29 22:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5b52851b0927 Merge Changeset: 633806cdab51 Author: jgodinez Date: 2009-10-05 18:22 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/633806cdab51 Merge Changeset: c715b68cdcaf Author: darcy Date: 2009-09-22 16:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c715b68cdcaf 6468534: (reflect) Exception types cannot be parameterized, rephrase getGenericExceptionTypes. Reviewed-by: alanb ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Method.java Changeset: bbb543254c63 Author: martin Date: 2009-09-22 18:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bbb543254c63 4245470: algorithm of java.lang.Byte.hashCode() is not specified Summary: Specify some hashCode methods are equivalent to intValue Reviewed-by: darcy ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Short.java + test/java/lang/HashCode.java Changeset: eb92c939b8a7 Author: martin Date: 2009-09-22 18:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/eb92c939b8a7 6582946: Add suite of compare(T, T) methods for ints, longs etc Reviewed-by: darcy Contributed-by: kevinb at google.com ! src/share/classes/java/lang/Boolean.java ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Character.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java + test/java/lang/Compare.java Changeset: bd928aefe692 Author: weijun Date: 2009-09-24 21:35 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bd928aefe692 6885166: regression test for 6877357 (IPv6 address does not work) error (timed out) Reviewed-by: xuelei ! test/sun/security/krb5/IPv6.java Changeset: 5b1aaf2d7504 Author: ptisnovs Date: 2009-09-30 11:49 +0200 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5b1aaf2d7504 6884837: JTReg test SetOutgoingIf is not correct Summary: Added check of network interfaces status Reviewed-by: alanb, chegar ! test/java/net/MulticastSocket/SetOutgoingIf.java Changeset: dd724911c90a Author: michaelm Date: 2009-09-29 10:00 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dd724911c90a 6886108: Test case B4933582 binding to fixed port number Reviewed-by: chegar ! test/java/net/Authenticator/B4933582.java ! test/sun/net/www/httptest/HttpTransaction.java ! test/sun/security/ssl/sun/net/www/httpstest/HttpTransaction.java Changeset: 896cbd9c91f4 Author: michaelm Date: 2009-10-01 11:25 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/896cbd9c91f4 Merge Changeset: 527ad9cbc9cf Author: weijun Date: 2009-10-02 18:44 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/527ad9cbc9cf 6324292: keytool -help is unhelpful Reviewed-by: xuelei, mullan ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/util/Resources.java + test/sun/security/tools/keytool/newhelp.sh Changeset: 56bad48e2810 Author: weijun Date: 2009-10-02 18:47 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/56bad48e2810 6862679: ESC: AD Authentication with user with umlauts fails Reviewed-by: valeriep, mullan ! src/share/classes/sun/security/krb5/Credentials.java ! src/share/classes/sun/security/krb5/KrbAsReq.java ! src/share/classes/sun/security/krb5/PrincipalName.java ! src/share/classes/sun/security/krb5/Realm.java ! src/share/classes/sun/security/krb5/internal/ETypeInfo.java ! src/share/classes/sun/security/krb5/internal/ETypeInfo2.java ! src/share/classes/sun/security/krb5/internal/KRBError.java ! src/share/classes/sun/security/krb5/internal/crypto/Des.java + src/share/classes/sun/security/krb5/internal/util/KerberosString.java ! src/windows/classes/sun/security/krb5/internal/tools/Kinit.java + test/sun/security/krb5/RFC396xTest.java Changeset: a2d24418be6c Author: weijun Date: 2009-10-02 18:49 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a2d24418be6c 6874472: display address lists for tickets in klist tool Reviewed-by: valeriep ! src/windows/classes/sun/security/krb5/internal/tools/Klist.java Changeset: a6046f6e720e Author: weijun Date: 2009-10-02 18:49 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a6046f6e720e 6868579: RFE: jarsigner to support reading password from environment variable Reviewed-by: xuelei, wetmore ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/util/Resources.java + test/sun/security/tools/jarsigner/passtype.sh Changeset: f0fdc4dd97d5 Author: michaelm Date: 2009-10-02 13:57 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f0fdc4dd97d5 6870935: DIGEST proxy authentication fails to connect to URLs with no trailing slash Reviewed-by: chegar ! src/share/classes/sun/net/www/protocol/http/AuthenticationInfo.java ! src/share/classes/sun/net/www/protocol/http/BasicAuthentication.java ! src/share/classes/sun/net/www/protocol/http/DigestAuthentication.java ! src/share/classes/sun/net/www/protocol/http/HttpURLConnection.java ! src/share/classes/sun/net/www/protocol/http/NegotiateAuthentication.java ! src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java ! src/windows/classes/sun/net/www/protocol/http/NTLMAuthentication.java + test/java/net/Authenticator/B6870935.java Changeset: e782a9564eae Author: michaelm Date: 2009-10-02 13:59 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e782a9564eae Merge Changeset: 9fcca0aae3da Author: tbell Date: 2009-10-02 08:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9fcca0aae3da 6787605: OpenSolaris doesn't have /usr/ucb/ps so ShellScaffold fails Reviewed-by: dcubed ! test/com/sun/jdi/ShellScaffold.sh Changeset: 97f17e6d0560 Author: alanb Date: 2009-10-04 15:42 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/97f17e6d0560 6884800: (file) Path.newInputStream does not usefully implement available() Reviewed-by: martin, chegar ! src/share/classes/sun/nio/ch/ChannelInputStream.java ! test/java/nio/channels/Channels/Basic.java Changeset: a4f31836660a Author: alanb Date: 2009-10-05 16:45 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a4f31836660a 6854954: Eliminate static dependency on java.awt.AWTPermission Reviewed-by: mullan, mchung, anthony ! src/share/classes/java/awt/Dialog.java ! src/share/classes/java/awt/MouseInfo.java ! src/share/classes/java/awt/Robot.java ! src/share/classes/java/awt/SystemTray.java ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java ! src/share/classes/java/lang/SecurityManager.java ! src/share/classes/javax/swing/JPopupMenu.java + src/share/classes/sun/awt/AWTPermissionFactory.java ! src/share/classes/sun/security/provider/PolicyFile.java + src/share/classes/sun/security/util/PermissionFactory.java ! src/share/classes/sun/security/util/SecurityConstants.java Changeset: 54118c8e0ebe Author: vinnie Date: 2009-10-05 23:42 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/54118c8e0ebe 6885204: JSSE should not require Kerberos to be present Reviewed-by: wetmore, alanb ! src/share/classes/com/sun/net/ssl/internal/www/protocol/https/DelegateHttpsURLConnection.java ! src/share/classes/sun/net/www/protocol/https/HttpsClient.java ! src/share/classes/sun/security/ssl/CipherSuite.java ! src/share/classes/sun/security/ssl/JsseJce.java Changeset: c499401bc138 Author: mchung Date: 2009-10-05 18:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c499401bc138 6612680: Remove classloader dependency on jkernel Summary: Add a new sun.misc.BootClassLoaderHook that DownloadManager will implement Reviewed-by: alanb, forax, igor ! make/sun/jkernel/Makefile ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/util/zip/ZipEntry.java ! src/share/classes/sun/jkernel/DownloadManager.java + src/share/classes/sun/misc/BootClassLoaderHook.java ! src/share/classes/sun/misc/Launcher.java ! src/share/classes/sun/misc/VM.java ! src/share/native/sun/misc/VM.c Changeset: 572791538be5 Author: darcy Date: 2009-10-06 13:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/572791538be5 5062288: (reflect) Core reflection uses raw types when it could be using wildcards Reviewed-by: alanb ! src/share/classes/java/lang/Class.java ! src/share/classes/java/lang/Package.java ! src/share/classes/java/lang/reflect/AccessibleObject.java ! src/share/classes/java/lang/reflect/Constructor.java ! src/share/classes/java/lang/reflect/Field.java ! src/share/classes/java/lang/reflect/Method.java ! src/share/classes/java/lang/reflect/Proxy.java ! src/share/classes/java/lang/reflect/ReflectAccess.java ! src/share/classes/sun/reflect/LangReflectAccess.java ! src/share/classes/sun/reflect/annotation/AnnotationInvocationHandler.java ! src/share/classes/sun/reflect/annotation/AnnotationParser.java ! src/share/classes/sun/reflect/annotation/AnnotationType.java Changeset: 1b81fc851b20 Author: mchung Date: 2009-10-06 15:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1b81fc851b20 6888802: sun.misc.BootClassLoaderHook.getBootstrapPaths stack overflow Summary: Fixed sun.misc.BootClassLoaderHook.getBootstrapPaths calls hook.getAdditionalBootstrapPaths Reviewed-by: alanb, tbell ! src/share/classes/sun/misc/BootClassLoaderHook.java + test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: f69b40e43bff Author: kamg Date: 2009-10-06 22:01 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f69b40e43bff 6885916: Memory leak in inferencing verifier (libverify.so) Summary: Use the memory management already present to track allocated memory Reviewed-by: coleenp, acorn ! src/share/native/common/check_code.c Changeset: f864c15f6779 Author: chegar Date: 2009-10-07 17:23 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f864c15f6779 6887364: SetOutgoingIf.java fails if run on multihomed machine without PIv6 on all interfaces Reviewed-by: alanb ! test/java/net/MulticastSocket/SetOutgoingIf.java Changeset: 777714bd992a Author: tbell Date: 2009-10-07 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/777714bd992a 6888888: new javah throws NullPointerException when building in jdk/make/java/nio Summary: Use the bootstrap javah during the build until bug-ID 6889255 is fixed Reviewed-by: jjg ! make/common/shared/Defs-java.gmk Changeset: e7ad502130ba Author: darcy Date: 2009-10-07 14:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e7ad502130ba 6480728: Byte.valueOf(byte) returns a cached value but Byte.valueOf(String) 6655735: Integer.toString() and String.valueOf(int) contain slow delegations Reviewed-by: lancea ! src/share/classes/java/lang/Byte.java ! src/share/classes/java/lang/Double.java ! src/share/classes/java/lang/Float.java ! src/share/classes/java/lang/Integer.java ! src/share/classes/java/lang/Long.java ! src/share/classes/java/lang/Short.java ! src/share/classes/java/lang/String.java Changeset: 405fd587f13f Author: tbell Date: 2009-10-07 14:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/405fd587f13f Merge ! src/share/classes/java/awt/Toolkit.java ! src/share/classes/java/awt/Window.java Changeset: 317ac0bf2285 Author: anthony Date: 2009-09-15 16:15 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/317ac0bf2285 6868255: Requirements for correct operating of the HW/LW Mixing feature need to be specified Summary: The specification is updated Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java Changeset: 986ec552383f Author: yan Date: 2009-09-22 01:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/986ec552383f Merge - make/javax/swing/plaf/nimbus/Makefile - make/tools/swing-nimbus/Makefile - make/tools/swing-nimbus/classes/org/jdesktop/beans/AbstractBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BezierControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/BlendingMode.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Canvas.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/ControlPoint.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Designer.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/DoubleBean.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/EllipseShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/GraphicsHelper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/Layer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/LayerContainer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PaintedShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/PathShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/RectangleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/SimpleShape.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/TemplateLayer.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/DropShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/Effect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/EffectUtilsTemp.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/InnerShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/OuterGlowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/effects/ShadowEffect.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/font/Typeface.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/CanvasMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/ColorMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/DimensionMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/jibxhelpers/InsetsMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/AbstractGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Gradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/GradientStop.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Matte.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/PaintModel.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/RadialGradient.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/paint/Texture.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasPath.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasResources.java - make/tools/swing-nimbus/classes/org/jdesktop/swingx/designer/utils/HasUIDefaults.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/DefaultsGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/Generator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/GeneratorUtils.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/ObjectCodeConvertors.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/PainterGenerator.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/generator/TemplateWriter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/CustomUIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/HasUIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/PainterBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/SynthModel.jibx.xml - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIBorder.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIColor.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIComponent.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDefault.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIDimension.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIFont.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIcon.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIIconRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIInsets.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIPaint.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIProperty.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIRegion.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIState.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStateType.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/UIStyle.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/BorderMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassConverter.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/ClassMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/FontMapper.java - make/tools/swing-nimbus/classes/org/jdesktop/synthdesigner/synthmodel/jibxhelpers/UIPropertyMapper.java - src/share/classes/sun/nio/ch/AbstractFuture.java - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: b6980b0d8440 Author: dcherepanov Date: 2009-09-30 13:21 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b6980b0d8440 6853592: VM test nsk.regression.b4261880 fails with "X Error of failed request: BadWindow" inconsistently. Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: a21d00087df9 Author: dcherepanov Date: 2009-09-30 15:48 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a21d00087df9 6878284: Sometimes test/javax/swing/system/6799345/TestShutdown.java "hangs" Reviewed-by: art, ant ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/AWTAutoShutdown.java Changeset: cf3f9c09ba1d Author: anthony Date: 2009-10-01 14:48 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cf3f9c09ba1d 6886868: giflib has a memory leak in the MakeMapObject() function Summary: free() the object before returning NULL Reviewed-by: art, dcherepanov ! src/share/native/sun/awt/giflib/gifalloc.c Changeset: 80db944866a9 Author: anthony Date: 2009-10-01 15:06 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/80db944866a9 6862611: Reg testcase closed/java/awt/Component/NativeInLightShow/NativeInLightShow.html fails Summary: The recursiveShowHeavyweightChildren() must be invoked unconditionally in mixOnShowing() Reviewed-by: art, dcherepanov ! src/share/classes/java/awt/Container.java Changeset: 4358934555bc Author: yan Date: 2009-10-06 23:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4358934555bc Merge ! src/share/classes/java/awt/Component.java ! src/share/classes/java/awt/Container.java ! src/share/classes/java/awt/EventQueue.java ! src/share/classes/sun/awt/AWTAutoShutdown.java ! src/solaris/classes/sun/awt/X11/XToolkit.java Changeset: 6216604c05e2 Author: alexp Date: 2009-09-09 17:32 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6216604c05e2 6878792: Sample provided in javax.swing.JLayer class description is not usable Reviewed-by: rupashka ! src/share/classes/javax/swing/JLayer.java Changeset: afd85f72784b Author: peterz Date: 2009-09-10 12:30 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/afd85f72784b 6827786: Mnemonic cycling for multiple equal mnemonic armed menu items stops when encountering a submenu Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicMenuUI.java ! src/share/classes/javax/swing/plaf/basic/BasicPopupMenuUI.java Changeset: 51ccbb892a1f Author: alexp Date: 2009-09-15 16:26 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/51ccbb892a1f 6875716: JLayer.remove((Component)null) should behave consistently in (not) throwing NPE Reviewed-by: rupashka ! src/share/classes/javax/swing/JLayer.java + test/javax/swing/JLayer/6875716/bug6875716.java Changeset: a64dbe61a984 Author: gsm Date: 2009-09-16 16:15 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a64dbe61a984 4337267: Arabic Numeral Shaping Reviewed-by: peterz ! src/share/classes/javax/swing/text/TextLayoutStrategy.java ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/JComponent/4337267/bug4337267.java Changeset: 481c01572c62 Author: alexp Date: 2009-09-17 19:08 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/481c01572c62 4833524: BasicTreeUI.isToggleSelectionEvent() does not properly handle popup triggers Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java ! src/share/classes/javax/swing/plaf/basic/BasicComboPopup.java ! src/share/classes/javax/swing/plaf/basic/BasicFileChooserUI.java ! src/share/classes/javax/swing/plaf/basic/BasicGraphicsUtils.java ! src/share/classes/javax/swing/plaf/basic/BasicListUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTableUI.java ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java ! src/share/classes/javax/swing/text/DefaultCaret.java Changeset: 1c7abc800502 Author: rupashka Date: 2009-09-18 15:11 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1c7abc800502 6840086: JFileChooser lacks icons on top right when running on Windows 7 Reviewed-by: peterz, uta ! src/share/classes/sun/awt/shell/ShellFolderManager.java ! src/windows/classes/sun/awt/shell/Win32ShellFolder2.java ! src/windows/classes/sun/awt/shell/Win32ShellFolderManager2.java ! src/windows/native/sun/windows/ShellFolder2.cpp + test/javax/swing/JFileChooser/6840086/bug6840086.java Changeset: fa71ca7a3655 Author: yan Date: 2009-09-21 01:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fa71ca7a3655 Merge - src/share/classes/sun/nio/ch/AbstractFuture.java - src/share/native/java/util/zip/zlib-1.1.3/ChangeLog - src/share/native/java/util/zip/zlib-1.1.3/README - src/share/native/java/util/zip/zlib-1.1.3/compress.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.c - src/share/native/java/util/zip/zlib-1.1.3/deflate.h - src/share/native/java/util/zip/zlib-1.1.3/doc/algorithm.doc - src/share/native/java/util/zip/zlib-1.1.3/example.c - src/share/native/java/util/zip/zlib-1.1.3/gzio.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.c - src/share/native/java/util/zip/zlib-1.1.3/infblock.h - src/share/native/java/util/zip/zlib-1.1.3/infcodes.c - src/share/native/java/util/zip/zlib-1.1.3/infcodes.h - src/share/native/java/util/zip/zlib-1.1.3/inffast.c - src/share/native/java/util/zip/zlib-1.1.3/inffast.h - src/share/native/java/util/zip/zlib-1.1.3/inffixed.h - src/share/native/java/util/zip/zlib-1.1.3/inflate.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.c - src/share/native/java/util/zip/zlib-1.1.3/inftrees.h - src/share/native/java/util/zip/zlib-1.1.3/infutil.c - src/share/native/java/util/zip/zlib-1.1.3/infutil.h - src/share/native/java/util/zip/zlib-1.1.3/minigzip.c - src/share/native/java/util/zip/zlib-1.1.3/trees.c - src/share/native/java/util/zip/zlib-1.1.3/trees.h - src/share/native/java/util/zip/zlib-1.1.3/uncompr.c - src/share/native/java/util/zip/zlib-1.1.3/zadler32.c - src/share/native/java/util/zip/zlib-1.1.3/zconf.h - src/share/native/java/util/zip/zlib-1.1.3/zcrc32.c - src/share/native/java/util/zip/zlib-1.1.3/zlib.h - src/share/native/java/util/zip/zlib-1.1.3/zutil.c - src/share/native/java/util/zip/zlib-1.1.3/zutil.h - test/java/util/concurrent/LinkedBlockingQueue/LastElement.java - test/java/util/concurrent/LinkedBlockingQueue/OfferRemoveLoops.java Changeset: 9d78c3d9def2 Author: alexp Date: 2009-09-21 17:58 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9d78c3d9def2 6883341: SWAT: jdk7-b72 swat build(2009-09-17) threw exceptions when running Java2D demo by clicking Paint ta Reviewed-by: peterz ! src/share/classes/sun/swing/SwingUtilities2.java + test/javax/swing/JMenuItem/6883341/bug6883341.java Changeset: 6115613a3386 Author: peterz Date: 2009-09-23 21:14 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6115613a3386 6857888: closed/javax/swing/JMenuItem/6458123/bug6458123.java fails with InvocationTargetException. Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/nimbus/skin.laf ! src/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java Changeset: d5045dd60c29 Author: rupashka Date: 2009-10-06 17:01 +0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d5045dd60c29 6489130: FileChooserDemo hung by keeping pressing Enter key Reviewed-by: alexp ! src/share/classes/javax/swing/JFileChooser.java + test/javax/swing/JFileChooser/6489130/bug6489130.java Changeset: dca0ab1a1ac3 Author: yan Date: 2009-10-06 23:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dca0ab1a1ac3 Merge ! src/share/classes/sun/swing/SwingUtilities2.java Changeset: 77f213891ce3 Author: lana Date: 2009-10-13 15:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/77f213891ce3 Merge Changeset: eacb36e30327 Author: vinnie Date: 2009-10-14 23:41 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/eacb36e30327 6891632: Remove duplicate ECC source files Reviewed-by: wetmore - src/share/native/sun/security/ec/ec.h - src/share/native/sun/security/ec/ec2.h - src/share/native/sun/security/ec/ec2_163.c - src/share/native/sun/security/ec/ec2_193.c - src/share/native/sun/security/ec/ec2_233.c - src/share/native/sun/security/ec/ec2_aff.c - src/share/native/sun/security/ec/ec2_mont.c - src/share/native/sun/security/ec/ec_naf.c - src/share/native/sun/security/ec/ecc_impl.h - src/share/native/sun/security/ec/ecdecode.c - src/share/native/sun/security/ec/ecl-curve.h - src/share/native/sun/security/ec/ecl-exp.h - src/share/native/sun/security/ec/ecl-priv.h - src/share/native/sun/security/ec/ecl.c - src/share/native/sun/security/ec/ecl.h - src/share/native/sun/security/ec/ecl_curve.c - src/share/native/sun/security/ec/ecl_gf.c - src/share/native/sun/security/ec/ecl_mult.c - src/share/native/sun/security/ec/ecp.h - src/share/native/sun/security/ec/ecp_192.c - src/share/native/sun/security/ec/ecp_224.c - src/share/native/sun/security/ec/ecp_256.c - src/share/native/sun/security/ec/ecp_384.c - src/share/native/sun/security/ec/ecp_521.c - src/share/native/sun/security/ec/ecp_aff.c - src/share/native/sun/security/ec/ecp_jac.c - src/share/native/sun/security/ec/ecp_jm.c - src/share/native/sun/security/ec/ecp_mont.c - src/share/native/sun/security/ec/logtab.h - src/share/native/sun/security/ec/mp_gf2m-priv.h - src/share/native/sun/security/ec/mp_gf2m.c - src/share/native/sun/security/ec/mp_gf2m.h - src/share/native/sun/security/ec/mpi-config.h - src/share/native/sun/security/ec/mpi-priv.h - src/share/native/sun/security/ec/mpi.c - src/share/native/sun/security/ec/mpi.h - src/share/native/sun/security/ec/mplogic.c - src/share/native/sun/security/ec/mplogic.h - src/share/native/sun/security/ec/mpmontg.c - src/share/native/sun/security/ec/mpprime.h - src/share/native/sun/security/ec/oid.c - src/share/native/sun/security/ec/secitem.c - src/share/native/sun/security/ec/secoidt.h Changeset: 99dfeece98e2 Author: xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/99dfeece98e2 Added tag jdk7-b74 for changeset eacb36e30327 ! .hgtags From john.coomes at sun.com Fri Oct 16 03:46:54 2009 From: john.coomes at sun.com (john.coomes at sun.com) Date: Fri, 16 Oct 2009 10:46:54 +0000 Subject: hg: jdk7/hotspot-gc/langtools: 18 new changesets Message-ID: <20091016104729.90F69418B2@hg.openjdk.java.net> Changeset: 14735c7932d7 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/14735c7932d7 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javap/JavapTask.java ! test/com/sun/javadoc/lib/JavadocTester.java ! test/com/sun/javadoc/testCRLineSeparator/TestCRLineSeparator.java ! test/com/sun/javadoc/testCRLineSeparator/pkg/MyClass.java ! test/com/sun/javadoc/testNoPackagesFile/TestNoPackagesFile.java ! test/com/sun/javadoc/testOverridenMethods/TestMultiInheritence.java ! test/com/sun/javadoc/testTaglets/TestTaglets.java ! test/tools/apt/Basics/apt.sh ! test/tools/apt/Basics/print.sh ! test/tools/apt/Compile/compile.sh ! test/tools/javac/4846262/Test.sh ! test/tools/javac/6302184/T6302184.sh ! test/tools/javac/6627362/T6627362.java ! test/tools/javac/ClassPathTest/ClassPathTest.sh ! test/tools/javac/ExtDirs/ExtDirs.sh ! test/tools/javac/MissingInclude.sh ! test/tools/javac/ProtectedInnerClass/ProtectedInnerClass.sh ! test/tools/javac/T5090006/compiler.sh ! test/tools/javac/api/6440333/T6440333.java ! test/tools/javac/api/Sibling.java ! test/tools/javac/code/ArrayClone.java ! test/tools/javac/constDebug/ConstDebug.sh ! test/tools/javac/fatalErrors/NoJavaLang.sh ! test/tools/javac/generics/inference/6302954/T6476073.java ! test/tools/javac/innerClassFile/Driver.sh ! test/tools/javac/javazip/Test.sh ! test/tools/javac/meth/MakeNegTests.sh ! test/tools/javac/newlines/Newlines.sh ! test/tools/javac/quid/MakeNegTests.sh ! test/tools/javac/quid/QuotedIdent.java ! test/tools/javac/quid/QuotedIdent2.java ! test/tools/javac/stackmap/T4955930.sh ! test/tools/javac/unicode/SupplementaryJavaID6.sh ! test/tools/javah/6257087/foo.sh ! test/tools/javah/ConstMacroTest.sh ! test/tools/javah/MissingParamClassTest.sh ! test/tools/javah/ReadOldClass.sh ! test/tools/javap/T4975569.java ! test/tools/javap/pathsep.sh ! test/tools/javap/stackmap/T6271292.sh Changeset: ebb6ad5a95bb Author: jjg Date: 2009-09-08 13:53 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ebb6ad5a95bb 5093723: REGRESSION: ClassCastException in SingleIndexWriter Reviewed-by: jjg Contributed-by: ahe at google.com ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties + test/com/sun/javadoc/5093723/DocumentedClass.java + test/com/sun/javadoc/5093723/T5093723.java + test/com/sun/javadoc/5093723/UndocumentedClass.java Changeset: 071a4e36cd87 Author: jjg Date: 2009-09-08 14:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/071a4e36cd87 6709246: ClassCastException in javadoc Reviewed-by: jjg Contributed-by: ahe at google.com ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java + test/tools/javadoc/annotations/missing/Main.java + test/tools/javadoc/annotations/missing/somepackage/MissingAnnotationClass.java Changeset: f8be8bf150c3 Author: jjg Date: 2009-09-14 17:13 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/f8be8bf150c3 6881317: regression: NPE in CloseableURLClassLoader Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/file/CloseableURLClassLoader.java Changeset: 9dd34ed62341 Author: jjg Date: 2009-09-15 12:20 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/9dd34ed62341 6882235: invalid exponent causes silent javac crash Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/T6882235.java + test/tools/javac/T6882235.out Changeset: 69eaccd3ea85 Author: jjg Date: 2009-09-15 18:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/69eaccd3ea85 6860965: Project Coin: binary literals 6860973: Project Coin: Underscores in literals Summary: [Portions contributed by Bruce Chapman] Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/code/Source.java ! src/share/classes/com/sun/tools/javac/parser/Scanner.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/enum/6384542/T6384542.out + test/tools/javac/literals/BadBinaryLiterals.6.out + test/tools/javac/literals/BadBinaryLiterals.7.out + test/tools/javac/literals/BadBinaryLiterals.java + test/tools/javac/literals/BadUnderscoreLiterals.6.out + test/tools/javac/literals/BadUnderscoreLiterals.7.out + test/tools/javac/literals/BadUnderscoreLiterals.java + test/tools/javac/literals/BinaryLiterals.java + test/tools/javac/literals/UnderscoreLiterals.java Changeset: 5dd400fd62d9 Author: tbell Date: 2009-09-18 08:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/5dd400fd62d9 Merge Changeset: 789ee1acf107 Author: darcy Date: 2009-09-21 21:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/789ee1acf107 6884227: Clarify ordering requirements of javax.lang.model.TypeElement.getEnclosedElements Reviewed-by: ahe ! src/share/classes/javax/lang/model/element/TypeElement.java Changeset: 9596dff46093 Author: tbell Date: 2009-09-25 14:24 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/9596dff46093 Merge Changeset: d498d6ef9c6c Author: xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/d498d6ef9c6c Added tag jdk7-b73 for changeset 9596dff46093 ! .hgtags Changeset: e992e602788e Author: darcy Date: 2009-09-23 18:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/e992e602788e 6517779: javax.lang.model.util.Elements.getConstantExpression() doesn't throw any exception 6517907: javax.lang.model.util.Elements.getConstantExpression() with negative byte value fails Summary: Fix various problems with Elements.getConstantExpression() Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/util/Constants.java ! src/share/classes/com/sun/tools/javac/util/Convert.java + test/tools/javac/processing/model/util/elements/Foo.java + test/tools/javac/processing/model/util/elements/TestGetConstantExpression.java Changeset: 49359d0e6a9c Author: jjg Date: 2009-09-23 18:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/49359d0e6a9c 6410637: Make decision on deprecated methods in DefaultFileManager and BaseFileObject. 6747645: ZipFileObject.getName is incorrectly deprecated 6885123: JavaFileObject getName issues Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/mirror/util/SourcePositionImpl.java ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java - src/share/classes/com/sun/tools/javac/file/Old199.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/util/AbstractDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javac/util/DiagnosticSource.java ! src/share/classes/com/sun/tools/javac/util/JCDiagnostic.java ! src/share/classes/com/sun/tools/javac/util/Log.java ! src/share/classes/com/sun/tools/javac/util/RawDiagnosticFormatter.java ! src/share/classes/com/sun/tools/javadoc/SourcePositionImpl.java ! src/share/classes/javax/tools/SimpleJavaFileObject.java + test/tools/javac/4241573/T4241573.java ! test/tools/javac/6589361/T6589361.java ! test/tools/javac/Diagnostics/6769027/T6769027.java ! test/tools/javac/T6705935.java ! test/tools/javac/api/6411310/T6411310.java + test/tools/javac/api/6411310/Test.java ! test/tools/javac/api/6733837/T6733837.java Changeset: c287d51c57da Author: jjg Date: 2009-09-23 19:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/c287d51c57da 6572945: javah should be written as an annotation processor, not a doclet Reviewed-by: darcy ! make/build.xml ! src/share/classes/com/sun/tools/javah/Gen.java + src/share/classes/com/sun/tools/javah/InternalError.java ! src/share/classes/com/sun/tools/javah/JNI.java + src/share/classes/com/sun/tools/javah/JavahFileManager.java + src/share/classes/com/sun/tools/javah/JavahTask.java + src/share/classes/com/sun/tools/javah/JavahTool.java ! src/share/classes/com/sun/tools/javah/LLNI.java ! src/share/classes/com/sun/tools/javah/Main.java - src/share/classes/com/sun/tools/javah/MainDoclet.java ! src/share/classes/com/sun/tools/javah/Mangle.java + src/share/classes/com/sun/tools/javah/NativeHeaderTool.java ! src/share/classes/com/sun/tools/javah/TypeSignature.java ! src/share/classes/com/sun/tools/javah/Util.java - src/share/classes/com/sun/tools/javah/resources/Linux_ppc.properties - src/share/classes/com/sun/tools/javah/resources/Linux_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparcv9.properties ! src/share/classes/com/sun/tools/javah/resources/l10n.properties - src/share/classes/com/sun/tools/javah/resources/win32_x86.properties ! src/share/classes/com/sun/tools/javap/DisassemblerTool.java + test/tools/javah/6572945/T6572945.java + test/tools/javah/6572945/TestClass1.java + test/tools/javah/6572945/TestClass2.java + test/tools/javah/6572945/TestClass3.java + test/tools/javah/6572945/gold/jni.dir.1/TestClass1.h + test/tools/javah/6572945/gold/jni.dir.1/TestClass1_Inner1.h + test/tools/javah/6572945/gold/jni.dir.1/TestClass1_Inner2.h + test/tools/javah/6572945/gold/jni.dir.1/TestClass2.h + test/tools/javah/6572945/gold/jni.file.1 + test/tools/javah/6572945/gold/jni.file.2 + test/tools/javah/6572945/gold/jni.file.3 ! test/tools/javah/MissingParamClassTest.sh + test/tools/javah/compareTest/CompareTest.java + test/tools/javah/compareTest/CompareTest.sh + test/tools/javah/compareTest/FindNativeFiles.java + test/tools/javah/compareTest/README Changeset: d0f541480556 Author: darcy Date: 2009-09-24 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/d0f541480556 6337964: should ignore last comma in annotation array Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java + test/tools/javac/annotations/pos/TrailingComma.java Changeset: 4776a869fdfa Author: tbell Date: 2009-09-25 22:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/4776a869fdfa Merge ! src/share/classes/com/sun/tools/javac/file/BaseFileObject.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java - src/share/classes/com/sun/tools/javac/file/Old199.java ! src/share/classes/com/sun/tools/javac/file/RegularFileObject.java ! src/share/classes/com/sun/tools/javac/file/SymbolArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipArchive.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndexArchive.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java - src/share/classes/com/sun/tools/javah/MainDoclet.java - src/share/classes/com/sun/tools/javah/resources/Linux_ppc.properties - src/share/classes/com/sun/tools/javah/resources/Linux_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparcv9.properties - src/share/classes/com/sun/tools/javah/resources/win32_x86.properties ! test/tools/javah/MissingParamClassTest.sh Changeset: c6d0c55b1aba Author: jjg Date: 2009-09-28 16:48 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/c6d0c55b1aba 6886348: apt incorrectly uses Scope.table Reviewed-by: darcy ! src/share/classes/com/sun/tools/apt/comp/Apt.java Changeset: 1a66b08deed0 Author: tbell Date: 2009-10-07 14:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/1a66b08deed0 Merge - src/share/classes/com/sun/tools/javac/file/Old199.java - src/share/classes/com/sun/tools/javah/MainDoclet.java - src/share/classes/com/sun/tools/javah/resources/Linux_ppc.properties - src/share/classes/com/sun/tools/javah/resources/Linux_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparc.properties - src/share/classes/com/sun/tools/javah/resources/SunOS_sparcv9.properties - src/share/classes/com/sun/tools/javah/resources/win32_x86.properties Changeset: 79c13af9217e Author: xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/79c13af9217e Added tag jdk7-b74 for changeset 1a66b08deed0 ! .hgtags From y.s.ramakrishna at sun.com Fri Oct 16 04:31:38 2009 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Fri, 16 Oct 2009 11:31:38 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6888898: CMS: ReduceInitialCardMarks unsafe in the presence of cms precleaning; ... Message-ID: <20091016113143.7B17A418C4@hg.openjdk.java.net> Changeset: 39b01ab7035a Author: ysr Date: 2009-10-16 02:05 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/39b01ab7035a 6888898: CMS: ReduceInitialCardMarks unsafe in the presence of cms precleaning 6889757: G1: enable card mark elision for initializing writes from compiled code (ReduceInitialCardMarks) Summary: Defer the (compiler-elided) card-mark upon a slow-path allocation until after the store and before the next subsequent safepoint; G1 now answers yes to can_elide_tlab_write_barriers(). Reviewed-by: jcoomes, kvn, never ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.hpp ! src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.inline.hpp ! src/share/vm/gc_interface/collectedHeap.cpp ! src/share/vm/gc_interface/collectedHeap.hpp ! src/share/vm/memory/genCollectedHeap.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/runtime.cpp ! src/share/vm/opto/runtime.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/thread.hpp From Jon.Masamitsu at Sun.COM Fri Oct 16 07:33:35 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Fri, 16 Oct 2009 07:33:35 -0700 Subject: Excessive concurrent-abortable-preclean wall time? In-Reply-To: <4AD7A017.5070100@Sun.COM> References: <4AD7A017.5070100@Sun.COM> Message-ID: <4AD8843F.5050701@sun.com> Y.S.Ramakrishna at Sun.COM wrote On 10/15/09 15:20,: > ... > > >Unless someone else on this list knows the reason for this >behaviour or has other suggestions, I'd suggest the following: >(a) try the latest 5uXX (5u21 i believe), although it's unlikely its > behaviour will be any different. (Aside: Note that > 5uXX is approaching EOSL end of this month, so make sure > to check with http://www.sun.com/software/javaforbusiness/support.jsp > re support of that product going forward.) >(b) try the latest 6uXX (6u16), and latest HotSpot hs17 to > see if the behaviour is similar. If the behaviour w/hs17 etc > is good we are all happy. If not, report the bug below. > > Note that the CMS default settings for jdk6 changed so you might see some differences just from those changes. http://java.sun.com/javase/6/docs/technotes/guides/vm/cms-6.html _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From shane.cox at gmail.com Fri Oct 16 10:58:33 2009 From: shane.cox at gmail.com (Shane Cox) Date: Fri, 16 Oct 2009 13:58:33 -0400 Subject: Why is default Young Space so small? Message-ID: We recently moved one of our apps onto a new box running i7 processors (Nehalem). After doing so, we noticed that the default Young Space allocation decreased substantially even though the new box has more processors and RAM ... and the JVM allocated more Parallel GC threads. Old machine: # mpstat CPU minf mjf xcal intr ithr csw icsw migr smtx srw syscl usr sys wt idl 0 3 0 49 2355 1251 274 3 15 2 0 345 1 1 0 99 1 3 0 48 188 0 284 4 17 2 0 359 1 0 0 99 2 7 0 58 238 104 214 3 12 4 0 294 0 0 0 99 3 2 0 29 127 3 144 2 8 1 0 257 0 0 0 99 # prtconf System Configuration: Sun Microsystems i86pc Memory size: 8192 Megabytes Start of GC log shows 59MB Young Space: 3.242: [GC 3.242: [ParNew: 52480K->6528K(*59008K*), 0.0221415 secs] 52480K->7228K(761472K), 0.0222595 secs] New machine: # mpstat CPU minf mjf xcal intr ithr csw icsw migr smtx srw syscl usr sys wt idl 0 229 0 686 448 142 221 0 3 10 0 662 0 1 0 99 1 181 0 593 114 0 188 0 1 10 0 574 0 0 0 99 2 16 0 88 148 0 230 0 1 7 0 478 1 0 0 99 3 16 0 199 161 21 215 0 0 9 0 532 0 0 0 99 4 5 0 50 150 0 181 0 1 5 0 378 0 0 0 99 5 21 0 125 147 2 184 0 0 10 0 523 0 0 0 99 6 2 0 185 145 4 157 0 1 3 0 317 0 0 0 99 7 16 0 114 152 7 128 0 0 5 0 367 0 0 0 100 8 1 0 73 456 307 45 0 1 2 0 50 0 0 0 100 9 15 0 86 148 0 12 0 0 1 0 89 0 0 0 100 10 0 0 15 158 6 26 0 1 1 0 28 0 0 0 100 11 2 0 31 151 0 9 0 0 1 0 36 0 0 0 100 12 0 0 7 153 0 12 0 0 1 0 19 0 0 0 100 13 1 0 8 153 0 4 0 0 0 0 55 0 0 0 100 14 0 0 15 152 0 5 0 0 1 0 14 0 0 0 100 15 1 0 6 153 0 7 0 0 1 0 21 0 0 0 100 # prtconf System Configuration: Sun Microsystems i86pc Memory size: 24566 Megabytes Start of GC log shows approx 15MB Young Space: 0.543: [GC 0.543: [ParNew: 13184K->1483K(*14784K*), 0.0029503 secs] 13184K->1483K(766400K), 0.0030164 secs] [Times: user=0.02 sys=0.00, real=0.00 secs] Java version is the same on both machines: java version "1.6.0_14" Java(TM) SE Runtime Environment (build 1.6.0_14-b08) Java HotSpot(TM) Server VM (build 14.0-b16, mixed mode) I did a thread dump on the new machine to determine how many Parallel GC Threads (Gang Workers) are running. Looks like 13: "Gang worker#0 (Parallel GC Threads)" prio=3 tid=0x08075400 nid=0x3 runnable "Gang worker#1 (Parallel GC Threads)" prio=3 tid=0x08076400 nid=0x4 runnable "Gang worker#2 (Parallel GC Threads)" prio=3 tid=0x08077800 nid=0x5 runnable "Gang worker#3 (Parallel GC Threads)" prio=3 tid=0x08078c00 nid=0x6 runnable "Gang worker#4 (Parallel GC Threads)" prio=3 tid=0x0807a000 nid=0x7 runnable "Gang worker#5 (Parallel GC Threads)" prio=3 tid=0x0807b800 nid=0x8 runnable "Gang worker#6 (Parallel GC Threads)" prio=3 tid=0x0807cc00 nid=0x9 runnable "Gang worker#7 (Parallel GC Threads)" prio=3 tid=0x0807e000 nid=0xa runnable "Gang worker#8 (Parallel GC Threads)" prio=3 tid=0x0807f400 nid=0xb runnable "Gang worker#9 (Parallel GC Threads)" prio=3 tid=0x08080800 nid=0xc runnable "Gang worker#10 (Parallel GC Threads)" prio=3 tid=0x08081c00 nid=0xd runnable "Gang worker#11 (Parallel GC Threads)" prio=3 tid=0x08083000 nid=0xe runnable "Gang worker#12 (Parallel GC Threads)" prio=3 tid=0x08084400 nid=0xf runnable We use the CMS collector. We don't specify a NewSize. We like to run with defaults if possible. Any ideas why the JVM decreased the Young Space allocation by 3/4th even though the number of processors increased by 4x? Thanks -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20091016/a08128ba/attachment-0001.html From Jon.Masamitsu at Sun.COM Fri Oct 16 11:26:52 2009 From: Jon.Masamitsu at Sun.COM (Jon Masamitsu) Date: Fri, 16 Oct 2009 11:26:52 -0700 Subject: Why is default Young Space so small? In-Reply-To: References: Message-ID: <4AD8BAEC.3030604@sun.com> Please run the following command on both your systems and send us the output. This will show us more information about the shape of the heap. java -XX:+UseConcMarkSweepGC -XX:+PrintGCDetails -version It should show something like this. java -XX:+UseConcMarkSweepGC -XX:+PrintGCDetails -Xmx512m -version java version "1.6.0" Java(TM) SE Runtime Environment (build 1.6.0-b105) Java HotSpot(TM) Server VM (build 1.6.0-b105, mixed mode) Heap par new generation total 14784K, used 263K [0xd8000000, 0xd9000000, 0xda000000) eden space 13184K, 2% used [0xd8000000, 0xd8041ec8, 0xd8ce0000) from space 1600K, 0% used [0xd8ce0000, 0xd8ce0000, 0xd8e70000) to space 1600K, 0% used [0xd8e70000, 0xd8e70000, 0xd9000000) concurrent mark-sweep generation total 49152K, used 0K [0xda000000, 0xdd000000, 0xf8000000) concurrent-mark-sweep perm gen total 16384K, used 1465K [0xf8000000, 0xf9000000, 0xfc000000) Shane Cox wrote On 10/16/09 10:58,: > We recently moved one of our apps onto a new box running i7 processors > (Nehalem). After doing so, we noticed that the default Young Space > allocation decreased substantially even though the new box has more > processors and RAM ... and the JVM allocated more Parallel GC threads. > > Old machine: > # mpstat > CPU minf mjf xcal intr ithr csw icsw migr smtx srw syscl usr sys > wt idl > 0 3 0 49 2355 1251 274 3 15 2 0 345 1 1 > 0 99 > 1 3 0 48 188 0 284 4 17 2 0 359 1 0 > 0 99 > 2 7 0 58 238 104 214 3 12 4 0 294 0 0 > 0 99 > 3 2 0 29 127 3 144 2 8 1 0 257 0 0 > 0 99 > > # prtconf > System Configuration: Sun Microsystems i86pc > Memory size: 8192 Megabytes > > Start of GC log shows 59MB Young Space: > 3.242: [GC 3.242: [ParNew: 52480K->6528K(*59008K*), 0.0221415 secs] > 52480K->7228K(761472K), 0.0222595 secs] > > > > New machine: > # mpstat > CPU minf mjf xcal intr ithr csw icsw migr smtx srw syscl usr sys > wt idl > 0 229 0 686 448 142 221 0 3 10 0 662 0 1 > 0 99 > 1 181 0 593 114 0 188 0 1 10 0 574 0 0 > 0 99 > 2 16 0 88 148 0 230 0 1 7 0 478 1 0 > 0 99 > 3 16 0 199 161 21 215 0 0 9 0 532 0 0 > 0 99 > 4 5 0 50 150 0 181 0 1 5 0 378 0 0 > 0 99 > 5 21 0 125 147 2 184 0 0 10 0 523 0 0 > 0 99 > 6 2 0 185 145 4 157 0 1 3 0 317 0 0 > 0 99 > 7 16 0 114 152 7 128 0 0 5 0 367 0 0 > 0 100 > 8 1 0 73 456 307 45 0 1 2 0 50 0 0 > 0 100 > 9 15 0 86 148 0 12 0 0 1 0 89 0 0 > 0 100 > 10 0 0 15 158 6 26 0 1 1 0 28 0 0 > 0 100 > 11 2 0 31 151 0 9 0 0 1 0 36 0 0 > 0 100 > 12 0 0 7 153 0 12 0 0 1 0 19 0 0 > 0 100 > 13 1 0 8 153 0 4 0 0 0 0 55 0 0 > 0 100 > 14 0 0 15 152 0 5 0 0 1 0 14 0 0 > 0 100 > 15 1 0 6 153 0 7 0 0 1 0 21 0 0 > 0 100 > > # prtconf > System Configuration: Sun Microsystems i86pc > Memory size: 24566 Megabytes > > Start of GC log shows approx 15MB Young Space: > 0.543: [GC 0.543: [ParNew: 13184K->1483K(*14784K*), 0.0029503 secs] > 13184K->1483K(766400K), 0.0030164 secs] [Times: user=0.02 sys=0.00, > real=0.00 secs] > > > Java version is the same on both machines: > java version "1.6.0_14" > Java(TM) SE Runtime Environment (build 1.6.0_14-b08) > Java HotSpot(TM) Server VM (build 14.0-b16, mixed mode) > > > > I did a thread dump on the new machine to determine how many Parallel > GC Threads (Gang Workers) are running. Looks like 13: > "Gang worker#0 (Parallel GC Threads)" prio=3 tid=0x08075400 nid=0x3 > runnable > "Gang worker#1 (Parallel GC Threads)" prio=3 tid=0x08076400 nid=0x4 > runnable > "Gang worker#2 (Parallel GC Threads)" prio=3 tid=0x08077800 nid=0x5 > runnable > "Gang worker#3 (Parallel GC Threads)" prio=3 tid=0x08078c00 nid=0x6 > runnable > "Gang worker#4 (Parallel GC Threads)" prio=3 tid=0x0807a000 nid=0x7 > runnable > "Gang worker#5 (Parallel GC Threads)" prio=3 tid=0x0807b800 nid=0x8 > runnable > "Gang worker#6 (Parallel GC Threads)" prio=3 tid=0x0807cc00 nid=0x9 > runnable > "Gang worker#7 (Parallel GC Threads)" prio=3 tid=0x0807e000 nid=0xa > runnable > "Gang worker#8 (Parallel GC Threads)" prio=3 tid=0x0807f400 nid=0xb > runnable > "Gang worker#9 (Parallel GC Threads)" prio=3 tid=0x08080800 nid=0xc > runnable > "Gang worker#10 (Parallel GC Threads)" prio=3 tid=0x08081c00 nid=0xd > runnable > "Gang worker#11 (Parallel GC Threads)" prio=3 tid=0x08083000 nid=0xe > runnable > "Gang worker#12 (Parallel GC Threads)" prio=3 tid=0x08084400 nid=0xf > runnable > > > > We use the CMS collector. We don't specify a NewSize. We like to run > with defaults if possible. > > > Any ideas why the JVM decreased the Young Space allocation by 3/4th > even though the number of processors increased by 4x? > > Thanks From Paul.Hohensee at Sun.COM Mon Oct 19 12:44:16 2009 From: Paul.Hohensee at Sun.COM (Paul Hohensee) Date: Mon, 19 Oct 2009 15:44:16 -0400 Subject: 6-bit age field for 64-bit vms Message-ID: <4ADCC190.2010003@sun.com> Right now, the object age field is 4 bits wide for both 32 and 64-bit vms. It used to be 5 bits until we took away a bit for biased locking in 5u6. I'd like to bump it back up to 5 (or maybe even 6) bits for 64-bit vms, since there's plenty of space in the mark word. Doing so would help applications that have objects that live a "medium" length of time, esp. in conjunction with larger young gens that can be collected quickly with enough hardware threads. This looks pretty easy to do. Using LP64_ONLY and NOT_LP64, just change the age field width to 5 in markOop.hpp and the default values for MaxTenuringThreshold and IntialTenuringThreshold in globals.hpp back to 31 and 15 respectively for 64-bit. Doing this makes it harder (than it already is) to compress the mark word down to 32-bits when using compressed pointers, but that's already a tough problem which doesn't get tougher with this change. Comments? Thanks, Paul From Paul.Hohensee at Sun.COM Mon Oct 19 13:16:45 2009 From: Paul.Hohensee at Sun.COM (Paul Hohensee) Date: Mon, 19 Oct 2009 16:16:45 -0400 Subject: 6-bit age field for 64-bit vms In-Reply-To: <4ADCC190.2010003@sun.com> References: <4ADCC190.2010003@sun.com> Message-ID: <4ADCC92D.3000001@sun.com> Well, it doesn't get '"significantly" tougher with this change. :) Paul Paul Hohensee wrote: > Right now, the object age field is 4 bits wide for both 32 and 64-bit > vms. > It used to be 5 bits until we took away a bit for biased locking in 5u6. > I'd like to bump it back up to 5 (or maybe even 6) bits for 64-bit vms, > since there's plenty of space in the mark word. Doing so would > help applications that have objects that live a "medium" length of > time, esp. in conjunction with larger young gens that can be collected > quickly with enough hardware threads. > > This looks pretty easy to do. Using LP64_ONLY and NOT_LP64, just > change the age field width to 5 in markOop.hpp and the default values > for MaxTenuringThreshold and IntialTenuringThreshold in globals.hpp > back to 31 and 15 respectively for 64-bit. > > Doing this makes it harder (than it already is) to compress the mark word > down to 32-bits when using compressed pointers, but that's already a > tough > problem which doesn't get tougher with this change. > > Comments? > > Thanks, > > Paul > From y.s.ramakrishna at sun.com Tue Oct 20 03:52:10 2009 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Tue, 20 Oct 2009 10:52:10 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6892749: assert(UseParNewGC || UseSerialGC || UseConcMarkSweepGC, "...") fails Message-ID: <20091020105214.43AFB41EBE@hg.openjdk.java.net> Changeset: 052a899eec3e Author: ysr Date: 2009-10-20 00:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/052a899eec3e 6892749: assert(UseParNewGC || UseSerialGC || UseConcMarkSweepGC, "...") fails Summary: Removed the assert: UseSerialGC is not necessarily always set when serial gc is being used. Reviewed-by: jcoomes, jmasa, tonyp ! src/share/vm/memory/genCollectedHeap.hpp From antonios.printezis at sun.com Tue Oct 20 15:29:08 2009 From: antonios.printezis at sun.com (antonios.printezis at sun.com) Date: Tue, 20 Oct 2009 22:29:08 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 26 new changesets Message-ID: <20091020223001.BDB5241F7D@hg.openjdk.java.net> Changeset: 6e6427f797c0 Author: xdono Date: 2009-09-03 10:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6e6427f797c0 Added tag jdk7-b71 for changeset 50a95aa4a247 ! .hgtags Changeset: a94714c55065 Author: trims Date: 2009-09-15 20:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a94714c55065 Merge Changeset: 1e5f0e56d242 Author: xdono Date: 2009-09-17 13:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1e5f0e56d242 Added tag jdk7-b72 for changeset a94714c55065 ! .hgtags Changeset: 89e0543e1737 Author: xdono Date: 2009-09-22 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/89e0543e1737 6884624: Update copyright year Summary: Update copyright for files that have been modified in 2009 through Septermber Reviewed-by: tbell, ohair ! agent/make/saenv.sh ! agent/make/saenv64.sh ! agent/src/os/solaris/proc/Makefile ! agent/src/os/solaris/proc/mapfile ! agent/src/share/classes/sun/jvm/hotspot/memory/CompactibleFreeListSpace.java ! agent/src/share/classes/sun/jvm/hotspot/memory/FreeChunk.java ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/os_cpu/solaris_sparc/vm/atomic_solaris_sparc.inline.hpp ! src/os_cpu/solaris_x86/vm/atomic_solaris_x86.inline.hpp ! src/share/vm/c1/c1_IR.cpp ! src/share/vm/c1/c1_IR.hpp ! src/share/vm/c1/c1_LIRAssembler.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classLoader.hpp ! src/share/vm/code/debugInfoRec.hpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/compiler/oopMap.cpp ! src/share/vm/compiler/oopMap.hpp ! src/share/vm/gc_implementation/g1/concurrentZFThread.cpp ! src/share/vm/gc_implementation/g1/g1MMUTracker.cpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.cpp ! src/share/vm/gc_implementation/parallelScavenge/psCompactionManager.hpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/memory/serialize.cpp ! src/share/vm/oops/arrayKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp ! src/share/vm/oops/instanceRefKlass.cpp ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/oops/objArrayOop.hpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/phaseX.hpp ! src/share/vm/opto/postaloc.cpp ! src/share/vm/prims/jvm.h ! src/share/vm/runtime/atomic.hpp ! src/share/vm/runtime/perfData.hpp ! src/share/vm/runtime/sweeper.cpp ! src/share/vm/runtime/vframeArray.hpp ! src/share/vm/runtime/vframe_hp.hpp ! src/share/vm/services/threadService.cpp ! src/share/vm/services/threadService.hpp Changeset: 7a102acc9f17 Author: trims Date: 2009-09-25 12:17 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/7a102acc9f17 Merge ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/prims/jvm.h Changeset: faf94d94786b Author: trims Date: 2009-09-25 12:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/faf94d94786b 6885900: Bump the HS17 build number to 02 Summary: Update the HS17 build number to 02 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 6ddec5389232 Author: xdono Date: 2009-10-02 11:26 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6ddec5389232 Added tag jdk7-b73 for changeset faf94d94786b ! .hgtags Changeset: a1423fe86a18 Author: trims Date: 2009-10-09 15:18 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a1423fe86a18 Merge ! src/cpu/x86/vm/c1_LIRGenerator_x86.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/gc_implementation/parallelScavenge/pcTasks.cpp ! src/share/vm/gc_implementation/shared/markSweep.cpp ! src/share/vm/gc_implementation/shared/markSweep.hpp ! src/share/vm/memory/genMarkSweep.cpp ! src/share/vm/memory/iterator.cpp ! src/share/vm/memory/iterator.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/runtime/sweeper.cpp Changeset: f4b900403d6e Author: trims Date: 2009-10-09 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f4b900403d6e 6890293: Bump the HS17 build number to 03 Summary: Update the HS17 build number to 03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 528d98fe1037 Author: xlu Date: 2009-09-24 12:10 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/528d98fe1037 6880029: JDK 1.6.0_u14p Application crashed very early Reviewed-by: never, ysr, acorn ! src/share/vm/runtime/safepoint.cpp Changeset: 054afbef9081 Author: acorn Date: 2009-09-28 12:27 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/054afbef9081 Merge Changeset: a2ad635573fb Author: xlu Date: 2009-10-14 12:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a2ad635573fb Merge Changeset: dcf03e02b020 Author: twisti Date: 2009-10-06 02:11 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/dcf03e02b020 6879902: CTW failure jdk6_18/hotspot/src/cpu/sparc/vm/assembler_sparc.hpp:845 Summary: For signatures with a large number of arguments the offset for the float store becomes too big and does not fit in 13-bit. Reviewed-by: kvn, never ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/assembler_sparc.hpp ! src/cpu/sparc/vm/assembler_sparc.inline.hpp ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp + test/compiler/6879902/Test6879902.java Changeset: 1ce3281a8e93 Author: kvn Date: 2009-10-06 10:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1ce3281a8e93 6880034: SIGBUS during deoptimisation at a safepoint on 64bit-SPARC Summary: Fix problem with the double register encodings in sparc.ad Reviewed-by: never, jrose Contributed-by: volker.simonis at gmail.com ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp ! src/cpu/sparc/vm/sparc.ad + test/compiler/6880034/Test6880034.java Changeset: e90521d61f9a Author: kvn Date: 2009-10-07 12:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e90521d61f9a 6875959: CTW fails hotspot/src/share/vm/opto/reg_split.cpp:1087 Summary: To break spill ties choose bound live range over unbound to free register or one with smaller cost to spill. Reviewed-by: never, jrose ! src/share/vm/opto/chaitin.cpp Changeset: 03b336640699 Author: never Date: 2009-10-07 15:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/03b336640699 6885584: A particular class structure causes large allocation spike for jit Reviewed-by: kvn ! src/share/vm/opto/phaseX.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/opto/type.hpp + test/compiler/6885584/Test6885584.java Changeset: 354d3184f6b2 Author: never Date: 2009-10-13 12:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/354d3184f6b2 6890308: integrate zero assembler hotspot changes Reviewed-by: never Contributed-by: gbenson at redhat.com ! make/Makefile ! make/defs.make ! make/linux/Makefile ! make/linux/makefiles/buildtree.make ! make/linux/makefiles/defs.make ! make/linux/makefiles/gcc.make ! make/linux/makefiles/sa.make ! make/linux/makefiles/saproc.make ! make/linux/makefiles/top.make ! make/linux/makefiles/vm.make + make/linux/makefiles/zero.make + make/linux/makefiles/zeroshark.make + make/linux/platform_zero.in + src/cpu/zero/vm/assembler_zero.cpp + src/cpu/zero/vm/assembler_zero.hpp + src/cpu/zero/vm/assembler_zero.inline.hpp + src/cpu/zero/vm/bytecodeInterpreter_zero.cpp + src/cpu/zero/vm/bytecodeInterpreter_zero.hpp + src/cpu/zero/vm/bytecodeInterpreter_zero.inline.hpp + src/cpu/zero/vm/bytecodes_zero.cpp + src/cpu/zero/vm/bytecodes_zero.hpp + src/cpu/zero/vm/bytes_zero.hpp + src/cpu/zero/vm/codeBuffer_zero.hpp + src/cpu/zero/vm/copy_zero.hpp + src/cpu/zero/vm/cppInterpreterGenerator_zero.hpp + src/cpu/zero/vm/cppInterpreter_zero.cpp + src/cpu/zero/vm/cppInterpreter_zero.hpp + src/cpu/zero/vm/debug_zero.cpp + src/cpu/zero/vm/depChecker_zero.cpp + src/cpu/zero/vm/depChecker_zero.hpp + src/cpu/zero/vm/disassembler_zero.cpp + src/cpu/zero/vm/disassembler_zero.hpp + src/cpu/zero/vm/dump_zero.cpp + src/cpu/zero/vm/entryFrame_zero.hpp + src/cpu/zero/vm/entry_zero.hpp + src/cpu/zero/vm/fakeStubFrame_zero.hpp + src/cpu/zero/vm/frame_zero.cpp + src/cpu/zero/vm/frame_zero.hpp + src/cpu/zero/vm/frame_zero.inline.hpp + src/cpu/zero/vm/globalDefinitions_zero.hpp + src/cpu/zero/vm/globals_zero.hpp + src/cpu/zero/vm/icBuffer_zero.cpp + src/cpu/zero/vm/icache_zero.cpp + src/cpu/zero/vm/icache_zero.hpp + src/cpu/zero/vm/interp_masm_zero.cpp + src/cpu/zero/vm/interp_masm_zero.hpp + src/cpu/zero/vm/interpreterFrame_zero.hpp + src/cpu/zero/vm/interpreterGenerator_zero.hpp + src/cpu/zero/vm/interpreterRT_zero.cpp + src/cpu/zero/vm/interpreterRT_zero.hpp + src/cpu/zero/vm/interpreter_zero.cpp + src/cpu/zero/vm/interpreter_zero.hpp + src/cpu/zero/vm/javaFrameAnchor_zero.hpp + src/cpu/zero/vm/jniFastGetField_zero.cpp + src/cpu/zero/vm/jniTypes_zero.hpp + src/cpu/zero/vm/jni_zero.h + src/cpu/zero/vm/methodHandles_zero.cpp + src/cpu/zero/vm/nativeInst_zero.cpp + src/cpu/zero/vm/nativeInst_zero.hpp + src/cpu/zero/vm/registerMap_zero.hpp + src/cpu/zero/vm/register_definitions_zero.cpp + src/cpu/zero/vm/register_zero.cpp + src/cpu/zero/vm/register_zero.hpp + src/cpu/zero/vm/relocInfo_zero.cpp + src/cpu/zero/vm/relocInfo_zero.hpp + src/cpu/zero/vm/sharedRuntime_zero.cpp + src/cpu/zero/vm/sharkFrame_zero.hpp + src/cpu/zero/vm/stack_zero.hpp + src/cpu/zero/vm/stubGenerator_zero.cpp + src/cpu/zero/vm/stubRoutines_zero.cpp + src/cpu/zero/vm/stubRoutines_zero.hpp + src/cpu/zero/vm/templateInterpreterGenerator_zero.hpp + src/cpu/zero/vm/templateInterpreter_zero.cpp + src/cpu/zero/vm/templateInterpreter_zero.hpp + src/cpu/zero/vm/templateTable_zero.cpp + src/cpu/zero/vm/templateTable_zero.hpp + src/cpu/zero/vm/vmStructs_zero.hpp + src/cpu/zero/vm/vm_version_zero.cpp + src/cpu/zero/vm/vm_version_zero.hpp + src/cpu/zero/vm/vmreg_zero.cpp + src/cpu/zero/vm/vmreg_zero.hpp + src/cpu/zero/vm/vmreg_zero.inline.hpp + src/cpu/zero/vm/vtableStubs_zero.cpp ! src/os/linux/vm/os_linux.cpp + src/os_cpu/linux_zero/vm/assembler_linux_zero.cpp + src/os_cpu/linux_zero/vm/atomic_linux_zero.inline.hpp + src/os_cpu/linux_zero/vm/bytes_linux_zero.inline.hpp + src/os_cpu/linux_zero/vm/globals_linux_zero.hpp + src/os_cpu/linux_zero/vm/orderAccess_linux_zero.inline.hpp + src/os_cpu/linux_zero/vm/os_linux_zero.cpp + src/os_cpu/linux_zero/vm/os_linux_zero.hpp + src/os_cpu/linux_zero/vm/prefetch_linux_zero.inline.hpp + src/os_cpu/linux_zero/vm/threadLS_linux_zero.cpp + src/os_cpu/linux_zero/vm/threadLS_linux_zero.hpp + src/os_cpu/linux_zero/vm/thread_linux_zero.cpp + src/os_cpu/linux_zero/vm/thread_linux_zero.hpp + src/os_cpu/linux_zero/vm/vmStructs_linux_zero.hpp + src/os_cpu/linux_zero/vm/vm_version_linux_zero.cpp + src/share/vm/includeDB_zero ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/oopMapCache.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/jniHandles.hpp ! src/share/vm/runtime/mutex.hpp ! src/share/vm/runtime/signature.hpp ! src/share/vm/runtime/vm_version.cpp ! src/share/vm/utilities/vmError.cpp Changeset: fcb148c6b605 Author: never Date: 2009-10-13 16:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fcb148c6b605 6889302: TraceExceptions output should include detail message Reviewed-by: twisti, jrose, kvn ! src/share/vm/utilities/exceptions.cpp ! src/share/vm/utilities/exceptions.hpp Changeset: 5f29a958a545 Author: kvn Date: 2009-10-13 20:54 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5f29a958a545 6889656: assert(lo_lrg->lo_degree() || !lo_no_simplify,"Live range was lo-degree before coalesce Summary: Restore the original code: uint i = _hi_degree. Reviewed-by: never, jrose ! src/share/vm/opto/chaitin.cpp Changeset: ce590301ae2a Author: kvn Date: 2009-10-13 22:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ce590301ae2a 6889300: assert(i != k || is_new || i->outcnt() > 0, "don't return dead nodes") Summary: PhiNode::Ideal() should return TOP for Phi node with no users. Reviewed-by: never, jrose ! src/share/vm/opto/cfgnode.cpp ! src/share/vm/opto/ifnode.cpp Changeset: 8e954aedbb81 Author: never Date: 2009-10-14 10:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8e954aedbb81 6889869: assert(!Interpreter::bytecode_should_reexecute(code),"should not reexecute") Reviewed-by: jrose, kvn, cfang, twisti ! src/share/vm/code/debugInfoRec.cpp ! src/share/vm/code/pcDesc.hpp Changeset: 23862fc517bb Author: kvn Date: 2009-10-14 11:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/23862fc517bb 6722084: JPRT make file doesn't create required symbolic link to libjvm.so Summary: Use -y zip option to preserve symbolic links. Reviewed-by: never, jcoomes, kamg ! make/jprt.gmk ! make/linux/makefiles/defs.make ! make/solaris/makefiles/defs.make Changeset: d40f03b57795 Author: kvn Date: 2009-10-14 15:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d40f03b57795 6890984: Comparison of 2 arrays could cause VM crash Summary: Restore original null checks. Reviewed-by: never, cfang ! src/cpu/sparc/vm/sparc.ad ! src/cpu/x86/vm/assembler_x86.cpp Changeset: e715b51789d8 Author: cfang Date: 2009-10-16 14:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e715b51789d8 Merge ! src/share/vm/opto/ifnode.cpp ! src/share/vm/opto/phaseX.cpp Changeset: f99f695bb8ef Author: tonyp Date: 2009-10-19 17:02 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f99f695bb8ef Merge ! src/share/vm/gc_implementation/g1/concurrentZFThread.cpp Changeset: b0b36f0de97e Author: tonyp Date: 2009-10-20 11:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b0b36f0de97e Merge From andrey.petrusenko at sun.com Thu Oct 22 10:48:00 2009 From: andrey.petrusenko at sun.com (andrey.petrusenko at sun.com) Date: Thu, 22 Oct 2009 17:48:00 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6858886: G1: guarantee(_next_marked_bytes <= used(), "invariant") at heapRegion.hpp:359 Message-ID: <20091022174804.A3482415E0@hg.openjdk.java.net> Changeset: dfdaf65c3423 Author: apetrusenko Date: 2009-10-22 07:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/dfdaf65c3423 6858886: G1: guarantee(_next_marked_bytes <= used(),"invariant") at heapRegion.hpp:359 Reviewed-by: tonyp, ysr ! src/share/vm/gc_implementation/g1/concurrentMark.cpp From antonios.printezis at sun.com Fri Oct 23 14:10:49 2009 From: antonios.printezis at sun.com (antonios.printezis at sun.com) Date: Fri, 23 Oct 2009 21:10:49 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <20091023211059.C4B86417AF@hg.openjdk.java.net> Changeset: fc06cd9b42c7 Author: tonyp Date: 2009-10-23 14:34 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fc06cd9b42c7 6886024: G1: assert(recent_avg_pause_time_ratio() < 1.00,"All GC?") Summary: the assert is incorrect and can fire incorrectly due to floating point inaccuracy. Reviewed-by: apetrusenko, ysr, jcoomes ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp Changeset: 6270f80a7331 Author: tonyp Date: 2009-09-30 14:50 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6270f80a7331 6890137: G1: revamp reachable object dump Summary: Revamp the reachable object dump debugging facility. Reviewed-by: jmasa, apetrusenko ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMark.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp From andrey.petrusenko at sun.com Tue Oct 27 06:47:08 2009 From: andrey.petrusenko at sun.com (andrey.petrusenko at sun.com) Date: Tue, 27 Oct 2009 13:47:08 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6870843: G1: G1 GC memory leak Message-ID: <20091027134716.BE78141D57@hg.openjdk.java.net> Changeset: fa2f65ebeb08 Author: apetrusenko Date: 2009-10-27 02:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fa2f65ebeb08 6870843: G1: G1 GC memory leak Summary: The fix addresses two memory leaks in G1 code: (1) _evac_failure_scan_stack - a resource object allocated on the C heap was not freed; (2) RSHashTable were linked into deleted list which was only cleared at full GC. Reviewed-by: tonyp, iveresov ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.cpp ! src/share/vm/gc_implementation/g1/sparsePRT.hpp From Y.S.Ramakrishna at Sun.COM Tue Oct 27 11:42:24 2009 From: Y.S.Ramakrishna at Sun.COM (Y.S.Ramakrishna at Sun.COM) Date: Tue, 27 Oct 2009 11:42:24 -0700 Subject: Parsing GC log for Thread Stops In-Reply-To: <19B27FD5AF2EAA49A66F787911CF519596D0A0@CTSINCHNSXUU.cts.com> References: <19B27FD5AF2EAA49A66F787911CF519596D0A0@CTSINCHNSXUU.cts.com> Message-ID: <4AE73F10.5050709@Sun.COM> You seem to have deleted some o/p, but the stop time printing strictly follows the stop; it does not precede it in the log. (Note of course that threads may be stopped for stuff other than GC as well, and those reasons may not necessarily be published to the log (even though the fact that threads were stopped and for how long is).) -- ramki On 10/27/09 09:49, Sujit.Das at cognizant.com wrote: > Hi, > > We are using JDK jdk1.6.0_14 on Solaris 10 platform. I am having > difficulty in associating timestamp to thread stop time. Please refer > the log snippet below. > > There are two occurence of thread stops. The first is at 18:06 with > thread stop time value of 0.0336887 seconds. The second thread stop > time, of value 3.4217414 seconds, has no associated timestamp. My > question - what is the associated timestamp for second thread stop? Is > it 18:06 or 18:09? > > 2009-10-26T18:06:19.008-0500: 3534.051: [GC Before GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ > Total Free Space: 385976134 > Max Chunk Size: 385976134 > Number of Blocks: 1 > Av. Block Size: 385976134 > Tree Height: 1 > Before GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ > Total Free Space: 0 > Max Chunk Size: 0 > Number of Blocks: 0 > Tree Height: 0 > 3534.051: [ParNew > Desired survivor size 218431488 bytes, new threshold 4 (max 4) > - age 1: 4747768 bytes, 4747768 total > - age 2: 8973152 bytes, 13720920 total > - age 3: 16305200 bytes, 30026120 total > - age 4: 1050896 bytes, 31077016 total > : 4300016K->43704K(4693376K), 0.0265603 secs] > 5380449K->1124137K(8789376K)After GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ > Total Free Space: 385976134 > Max Chunk Size: 385976134 > Number of Blocks: 1 > Av. Block Size: 385976134 > Tree Height: 1 > After GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ > Total Free Space: 0 > Max Chunk Size: 0 > Number of Blocks: 0 > Tree Height: 0 > , 0.0272833 secs] [Times: user=0.36 sys=0.01, real=0.03 secs] > Heap after GC invocations=213 (full 2): > par new generation total 4693376K, used 43704K [0xfffffd7dbf600000, > 0xfffffd7ef7e00000, 0xfffffd7ef7e00000) > eden space 4266752K, 0% used [0xfffffd7dbf600000, > 0xfffffd7dbf600000, 0xfffffd7ec3cc0000) > from space 426624K, 10% used [0xfffffd7ec3cc0000, 0xfffffd7ec676e090, > 0xfffffd7eddd60000) > to space 426624K, 0% used [0xfffffd7eddd60000, 0xfffffd7eddd60000, > 0xfffffd7ef7e00000) > concurrent mark-sweep generation total 4096000K, used 1080433K > [0xfffffd7ef7e00000, 0xfffffd7ff1e00000, 0xfffffd7ff1e00000) > concurrent-mark-sweep perm gen total 131072K, used 62140K > [0xfffffd7ff1e00000, 0xfffffd7ff9e00000, 0xfffffd7ff9e00000) > } > *Total time for which application threads were stopped: 0.0336887 seconds > *3878 ...class name-method name... > 3879 ...class name-method name... > 3880 ...class name-method name... > 3881 ...class name-method name... > 3882 ...class name-method name... > Application time: 163.9563827 seconds > 3867 ...class name-method name... > 3868 ...class name-method name... > Before GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ > Total Free Space: 385976134 > Max Chunk Size: 385976134 > Number of Blocks: 1 > Av. Block Size: 385976134 > Tree Height: 1 > Before GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ > Total Free Space: 0 > Max Chunk Size: 0 > Number of Blocks: 0 > Tree Height: 0 > After GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ > Total Free Space: 385976134 > Max Chunk Size: 385976134 > Number of Blocks: 1 > Av. Block Size: 385976134 > Tree Height: 1 > After GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ > Total Free Space: 0 > Max Chunk Size: 0 > Number of Blocks: 0 > Tree Height: 0 > *Total time for which application threads were stopped: 3.4217414 seconds* > Application time: 0.3801325 seconds > {Heap before GC invocations=213 (full 2): > par new generation total 4693376K, used 1247868K [0xfffffd7dbf600000, > 0xfffffd7ef7e00000, 0xfffffd7ef7e00000) > eden space 4266752K, 28% used [0xfffffd7dbf600000, > 0xfffffd7e08df1070, 0xfffffd7ec3cc0000) > from space 426624K, 10% used [0xfffffd7ec3cc0000, 0xfffffd7ec676e090, > 0xfffffd7eddd60000) > to space 426624K, 0% used [0xfffffd7eddd60000, 0xfffffd7eddd60000, > 0xfffffd7ef7e00000) > concurrent mark-sweep generation total 4096000K, used 1080433K > [0xfffffd7ef7e00000, 0xfffffd7ff1e00000, 0xfffffd7ff1e00000) > concurrent-mark-sweep perm gen total 131072K, used 62142K > [0xfffffd7ff1e00000, 0xfffffd7ff9e00000, 0xfffffd7ff9e00000) > 2009-10-26T18:09:45.836-0500: 3740.882: [Full GC Before GC: > Statistics for BinaryTreeDictionary: > ------------------------------------ _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From John.Cuthbertson at Sun.COM Tue Oct 27 14:51:46 2009 From: John.Cuthbertson at Sun.COM (john cuthbertson - Sun Microsystems) Date: Tue, 27 Oct 2009 14:51:46 -0700 Subject: Request for review (S): CR 6889740 - G1: OpenDS fails with "unhandled exception in compiled code" Message-ID: <4AE76B72.1030002@sun.com> Hi Everyone, Can I have a couple of volunteers to review the proposed fix for this bug? The webrev can be found at http://cr.openjdk.java.net/~johnc/6889740/webrev.0/. The issue is that bad code was being generated for the store operation in the null case of the aastore bytecode template. The bad code was caused by there being only one version of the store_heap_oop routine that took a Register as the second argument. When the calling code passed in NULL_WORD (0) to this routine the value was used as a Register encoding and converted to Register(0), which is rax. Thus the generated store was "mov (dst), $rax" instead of "mov (dst), $0x0". This is normally not a problem as the preceding code in the template fetches the value to be stored into rax. When the G1 pre-barrier code calls the runtime, however, the value in rax can be overwritten and the heap can become corrupted. Testing: OpenDS, jprt, refworkload, and the GC test suite. Thanks, JohnC From John.Cuthbertson at Sun.COM Wed Oct 28 13:58:04 2009 From: John.Cuthbertson at Sun.COM (john cuthbertson - Sun Microsystems) Date: Wed, 28 Oct 2009 13:58:04 -0700 Subject: Request for review (S): CR 6889740 - G1: OpenDS fails with "unhandled exception in compiled code" In-Reply-To: <4AE76B72.1030002@sun.com> References: <4AE76B72.1030002@sun.com> Message-ID: <4AE8B05C.4040700@sun.com> Hi Everyone, I've tweaked the change based on feedback from Christian and Tom. The new webrev can be found here: http://cr.openjdk.java.net/~johnc/6889740/webrev.1/ Regards, JohnC On 10/27/09 14:51, john cuthbertson - Sun Microsystems wrote: > Hi Everyone, > > Can I have a couple of volunteers to review the proposed fix for this > bug? The webrev can be found at > http://cr.openjdk.java.net/~johnc/6889740/webrev.0/. > > The issue is that bad code was being generated for the store operation > in the null case of the aastore bytecode template. The bad code was > caused by there being only one version of the store_heap_oop routine > that took a Register as the second argument. When the calling code > passed in NULL_WORD (0) to this routine the value was used as a > Register encoding and converted to Register(0), which is rax. Thus the > generated store was "mov (dst), $rax" instead of "mov (dst), $0x0". > This is normally not a problem as the preceding code in the template > fetches the value to be stored into rax. When the G1 pre-barrier code > calls the runtime, however, the value in rax can be overwritten and > the heap can become corrupted. > > Testing: OpenDS, jprt, refworkload, and the GC test suite. > > Thanks, > > JohnC From Vladimir.Kozlov at Sun.COM Wed Oct 28 14:03:27 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 28 Oct 2009 14:03:27 -0700 Subject: Request for review (S): CR 6889740 - G1: OpenDS fails with "unhandled exception in compiled code" In-Reply-To: <4AE8B05C.4040700@sun.com> References: <4AE76B72.1030002@sun.com> <4AE8B05C.4040700@sun.com> Message-ID: <4AE8B19F.9040409@sun.com> Looks good. Vladimir john cuthbertson - Sun Microsystems wrote: > Hi Everyone, > > I've tweaked the change based on feedback from Christian and Tom. The > new webrev can be found here: > > http://cr.openjdk.java.net/~johnc/6889740/webrev.1/ > > Regards, > > JohnC > > On 10/27/09 14:51, john cuthbertson - Sun Microsystems wrote: >> Hi Everyone, >> >> Can I have a couple of volunteers to review the proposed fix for this >> bug? The webrev can be found at >> http://cr.openjdk.java.net/~johnc/6889740/webrev.0/. >> >> The issue is that bad code was being generated for the store operation >> in the null case of the aastore bytecode template. The bad code was >> caused by there being only one version of the store_heap_oop routine >> that took a Register as the second argument. When the calling code >> passed in NULL_WORD (0) to this routine the value was used as a >> Register encoding and converted to Register(0), which is rax. Thus the >> generated store was "mov (dst), $rax" instead of "mov (dst), $0x0". >> This is normally not a problem as the preceding code in the template >> fetches the value to be stored into rax. When the G1 pre-barrier code >> calls the runtime, however, the value in rax can be overwritten and >> the heap can become corrupted. >> >> Testing: OpenDS, jprt, refworkload, and the GC test suite. >> >> Thanks, >> >> JohnC > From y.s.ramakrishna at sun.com Wed Oct 28 14:57:00 2009 From: y.s.ramakrishna at sun.com (y.s.ramakrishna at sun.com) Date: Wed, 28 Oct 2009 21:57:00 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6818264: Heap dumper unexpectedly adds .hprof suffix Message-ID: <20091028215705.AAB1B41633@hg.openjdk.java.net> Changeset: 72a6752ac432 Author: ysr Date: 2009-10-28 11:16 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/72a6752ac432 6818264: Heap dumper unexpectedly adds .hprof suffix Summary: Restore old behaviour wrt HeapDumpPath; first dump goes to , th dump goes to ., with default value of the same as before. Reviewed-by: alanb, jcoomes, tonyp ! src/share/vm/services/heapDumper.cpp From Vladimir.Kozlov at Sun.COM Wed Oct 28 18:16:55 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Wed, 28 Oct 2009 18:16:55 -0700 Subject: Request for reviews (S): 6892186: 6896084: VM does not reserve protected page below heap for compressed oops implicit null checks Message-ID: <4AE8ED07.2010109@sun.com> Coping to GC and Runtime groups. -------- Original Message -------- Subject: Request for reviews (S): 6892186: 6896084: VM does not reserve protected page below heap for compressed oops implicit null checks Date: Wed, 28 Oct 2009 16:13:21 -0700 From: Vladimir Kozlov To: hotspot compiler http://cr.openjdk.java.net/~kvn/6896084/webrev.00 Fixed 6896084: VM does not reserve protected page below heap for compressed oops implicit null checks Problem: VM should reserve protected page below heap for compressed oops implicit null checks in compiled code (see 6716785). After zero based compressed oops changes (6791178) the page is not reserved because undefined narrow_oop_base (NULL by default) is used in ReservedHeapSpace() to determine if the page is needed. Solution: Set narrow_oop_base and narrow_oop_use_implicit_null_checks values according to compressed oops encoding mode in Universe::preferred_heap_base() which is called before ReservedHeapSpace() constructors. Reviewed by: Fix verified (y/n): y, test output Other testing: JPRT From Christian.Thalinger at Sun.COM Thu Oct 29 02:32:06 2009 From: Christian.Thalinger at Sun.COM (Christian Thalinger) Date: Thu, 29 Oct 2009 10:32:06 +0100 Subject: Request for review (S): CR 6889740 - G1: OpenDS fails with "unhandled exception in compiled code" In-Reply-To: <4AE8B05C.4040700@sun.com> References: <4AE76B72.1030002@sun.com> <4AE8B05C.4040700@sun.com> Message-ID: <1256808726.3638.31.camel@macbook> On Wed, 2009-10-28 at 13:58 -0700, john cuthbertson - Sun Microsystems wrote: > Hi Everyone, > > I've tweaked the change based on feedback from Christian and Tom. The > new webrev can be found here: > > http://cr.openjdk.java.net/~johnc/6889740/webrev.1/ Looks good. -- Christian From John.Coomes at sun.com Thu Oct 29 13:21:10 2009 From: John.Coomes at sun.com (John Coomes) Date: Thu, 29 Oct 2009 13:21:10 -0700 Subject: Request for reviews (S): 6892186: 6896084: VM does not reserve protected page below heap for compressed oops implicit null checks In-Reply-To: <4AE8ED07.2010109@sun.com> References: <4AE8ED07.2010109@sun.com> Message-ID: <19177.63798.758074.686080@sun.com> Vladimir Kozlov (Vladimir.Kozlov at Sun.COM) wrote: > ... > http://cr.openjdk.java.net/~kvn/6896084/webrev.00 > > Fixed 6896084: VM does not reserve protected page below heap for compressed oops implicit null checks > > Problem: > VM should reserve protected page below heap for compressed oops > implicit null checks in compiled code (see 6716785). > After zero based compressed oops changes (6791178) the page is > not reserved because undefined narrow_oop_base (NULL by default) > is used in ReservedHeapSpace() to determine if the page is needed. > > Solution: > Set narrow_oop_base and narrow_oop_use_implicit_null_checks > values according to compressed oops encoding mode in > Universe::preferred_heap_base() which is called before > ReservedHeapSpace() constructors. Your changes look good to me. Some comment typos/nits: 788 // Set not NULL value to indicate the need of narrow_oop_base. The comment didn't help me understand why it had to be non-null. Maybe "Set to a non-NULL value so the ReservedSpace ctor computes the correct no-access prefix." Not your change, but the conditional expression in ReservedHeapSpace ctor that uses this should be made into a static function, e.g., no_access_prefix_size(...). I'll add it to my cleanups list. 794 // addressing mode, when large pages are specified on windows. FWIW, the comma isn't necessary. -John From Vladimir.Kozlov at Sun.COM Thu Oct 29 13:41:12 2009 From: Vladimir.Kozlov at Sun.COM (Vladimir Kozlov) Date: Thu, 29 Oct 2009 13:41:12 -0700 Subject: Request for reviews (S): 6896084: VM does not reserveprotected page below heap for compressed oops implicit null checks In-Reply-To: <19177.63798.758074.686080@sun.com> References: <4AE8ED07.2010109@sun.com> <19177.63798.758074.686080@sun.com> Message-ID: <4AE9FDE8.2040005@sun.com> Thank you, John Vladimir John Coomes wrote: > Vladimir Kozlov (Vladimir.Kozlov at Sun.COM) wrote: >> ... >> http://cr.openjdk.java.net/~kvn/6896084/webrev.00 >> >> Fixed 6896084: VM does not reserve protected page below heap for compressed oops implicit null checks >> >> Problem: >> VM should reserve protected page below heap for compressed oops >> implicit null checks in compiled code (see 6716785). >> After zero based compressed oops changes (6791178) the page is >> not reserved because undefined narrow_oop_base (NULL by default) >> is used in ReservedHeapSpace() to determine if the page is needed. >> >> Solution: >> Set narrow_oop_base and narrow_oop_use_implicit_null_checks >> values according to compressed oops encoding mode in >> Universe::preferred_heap_base() which is called before >> ReservedHeapSpace() constructors. > > Your changes look good to me. Some comment typos/nits: > > 788 // Set not NULL value to indicate the need of narrow_oop_base. > > The comment didn't help me understand why it had to be non-null. > Maybe "Set to a non-NULL value so the ReservedSpace ctor computes the > correct no-access prefix." > > Not your change, but the conditional expression in ReservedHeapSpace > ctor that uses this should be made into a static function, e.g., > no_access_prefix_size(...). I'll add it to my cleanups list. > > 794 // addressing mode, when large pages are specified on windows. > > FWIW, the comma isn't necessary. > > -John > From Thomas.Rodriguez at Sun.COM Thu Oct 29 13:52:42 2009 From: Thomas.Rodriguez at Sun.COM (Tom Rodriguez) Date: Thu, 29 Oct 2009 13:52:42 -0700 Subject: Request for review (S): CR 6889740 - G1: OpenDS fails with "unhandled exception in compiled code" In-Reply-To: <4AE8B05C.4040700@sun.com> References: <4AE76B72.1030002@sun.com> <4AE8B05C.4040700@sun.com> Message-ID: <57030A29-818D-48FB-8AD2-977A34C6F8A0@sun.com> looks good. tom On Oct 28, 2009, at 1:58 PM, john cuthbertson - Sun Microsystems wrote: > Hi Everyone, > > I've tweaked the change based on feedback from Christian and Tom. > The new webrev can be found here: > > http://cr.openjdk.java.net/~johnc/6889740/webrev.1/ > > Regards, > > JohnC > > On 10/27/09 14:51, john cuthbertson - Sun Microsystems wrote: >> Hi Everyone, >> >> Can I have a couple of volunteers to review the proposed fix for >> this bug? The webrev can be found at http://cr.openjdk.java.net/~johnc/6889740/webrev.0/ >> . >> >> The issue is that bad code was being generated for the store >> operation in the null case of the aastore bytecode template. The >> bad code was caused by there being only one version of the >> store_heap_oop routine that took a Register as the second argument. >> When the calling code passed in NULL_WORD (0) to this routine the >> value was used as a Register encoding and converted to Register(0), >> which is rax. Thus the generated store was "mov (dst), $rax" >> instead of "mov (dst), $0x0". This is normally not a problem as the >> preceding code in the template fetches the value to be stored into >> rax. When the G1 pre-barrier code calls the runtime, however, the >> value in rax can be overwritten and the heap can become corrupted. >> >> Testing: OpenDS, jprt, refworkload, and the GC test suite. >> >> Thanks, >> >> JohnC > From john.cuthbertson at sun.com Thu Oct 29 14:23:54 2009 From: john.cuthbertson at sun.com (john.cuthbertson at sun.com) Date: Thu, 29 Oct 2009 21:23:54 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6889740: G1: OpenDS fails with "unhandled exception in compiled code" Message-ID: <20091029212402.115EA417BA@hg.openjdk.java.net> Changeset: beb8f45ee9f0 Author: johnc Date: 2009-10-29 09:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/beb8f45ee9f0 6889740: G1: OpenDS fails with "unhandled exception in compiled code" Summary: Incorrect code was being generated for the store operation in the null case of the aastore bytecode template. The bad code was generated by the store_heap_oop routine which takes a Register as its second argument. Passing NULL_WORD (0) as the second argument causes the value to be converted to Register(0), which is rax. Thus the generated store was "mov (dst), $rax" instead of "mov (dst), $0x0". Changed calls to store_heap_oop that pass NULL_WORD as the second argument to a new routine store_heap_oop_null. Reviewed-by: kvn, twisti ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/templateTable_x86_64.cpp From Changpeng.Fang at Sun.COM Thu Oct 29 15:58:35 2009 From: Changpeng.Fang at Sun.COM (Changpeng Fang) Date: Thu, 29 Oct 2009 15:58:35 -0700 Subject: Request for Review (S) 6852078: HSX 14/16 in jdk 5.0: api/javax_management api/org_omg jck tests crashes or make tnameserv crash In-Reply-To: <4AE6380F.6000308@sun.com> References: <494140A6.2070703@sun.com> <49A59C83.5030406@Sun.COM> <894501F8-FA27-42C9-9BBD-EFAC7166B4A4@Sun.COM> <49A5A963.6020701@Sun.COM> <3ADCAF44-7AC1-4F59-9B60-0FAE71184D8C@Sun.COM> <49A82387.4060902@Sun.COM> <49A82929.2070305@Sun.COM> <546A5F65-EA0D-4752-B4B3-2F745866C1A1@Sun.COM> <49CC1575.6020505@Sun.COM> <4AE6380F.6000308@sun.com> Message-ID: <4AEA1E1B.6020302@sun.com> http://cr.openjdk.java.net/~cfang/6852078/webrev.00/ Note that I am requesting for change to the current jdk source (For the SubCR) 6852078: HSX 14/16 in jdk 5.0: api/javax_management api/org_omg jck tests crashes or make tnameserv crash Problem: Current implementation of superword optimization does not check for unsafe memory accesses. Since unsafe memory accesses could not be aligned appropriately without runtime checking, a un-aligned superword read/write could cause runtime failure. Solution: Simply disable superword for unsafe memory access whose base is top. Tests: Test case in 6852078 Thanks, Changpeng From antonios.printezis at sun.com Fri Oct 30 14:40:50 2009 From: antonios.printezis at sun.com (antonios.printezis at sun.com) Date: Fri, 30 Oct 2009 21:40:50 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 13 new changesets Message-ID: <20091030214117.53BE541953@hg.openjdk.java.net> Changeset: 67a9176de85c Author: trims Date: 2009-10-23 14:27 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/67a9176de85c 6894844: Bump the HS17 build number to 04 Summary: Update the HS17 build number to 04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 411c9c4ca96a Author: xdono Date: 2009-10-15 16:40 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/411c9c4ca96a Added tag jdk7-b74 for changeset f4b900403d6e ! .hgtags Changeset: d8dd291a362a Author: trims Date: 2009-10-23 14:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d8dd291a362a Merge Changeset: 08780c8a9f04 Author: kamg Date: 2009-10-20 16:34 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/08780c8a9f04 6893483: DTrace probe return values for a couple JNI methods are wrong Summary: Fix the shadowing and incorrect macro usages Reviewed-by: coleenp ! src/share/vm/prims/jni.cpp Changeset: a3b9e96881fe Author: xlu Date: 2009-10-23 18:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a3b9e96881fe Merge Changeset: d912f17c1ae4 Author: xlu Date: 2009-10-28 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d912f17c1ae4 Merge Changeset: 0a46d0c5dccb Author: never Date: 2009-10-15 11:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0a46d0c5dccb 6891750: deopt blob kills values in O5 Reviewed-by: kvn, twisti ! src/cpu/sparc/vm/sharedRuntime_sparc.cpp + test/compiler/6891750/Test6891750.java Changeset: 71fdc5052e49 Author: cfang Date: 2009-10-16 16:14 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/71fdc5052e49 Merge Changeset: 987e948ebbc8 Author: jrose Date: 2009-10-17 19:51 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/987e948ebbc8 6815692: method handle code needs some cleanup (post-6655638) Summary: correctly raise exceptions, support safe bitwise "raw" conversions, fix bugs revealed by VerifyMethodHandles, remove dead code, improve debugging support Reviewed-by: never, twisti ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/templateInterpreter_x86_32.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/klass.cpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/markOop.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp Changeset: 873ec3787992 Author: kvn Date: 2009-10-21 09:15 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/873ec3787992 6892186: SA does not dump debug info for scalar replaced objects Summary: Implement scalar replaced objects debug info dump in SA. Reviewed-by: twisti ! agent/make/saenv.sh ! agent/make/saenv64.sh ! agent/src/share/classes/sun/jvm/hotspot/CommandProcessor.java ! agent/src/share/classes/sun/jvm/hotspot/code/CodeCache.java ! agent/src/share/classes/sun/jvm/hotspot/code/NMethod.java ! agent/src/share/classes/sun/jvm/hotspot/code/PCDesc.java ! agent/src/share/classes/sun/jvm/hotspot/code/ScopeDesc.java ! agent/src/share/classes/sun/jvm/hotspot/ui/classbrowser/HTMLGenerator.java ! agent/src/share/classes/sun/jvm/hotspot/utilities/soql/sa.js ! src/share/vm/opto/callnode.cpp ! src/share/vm/runtime/vmStructs.cpp Changeset: f875b4f472f7 Author: twisti Date: 2009-10-27 03:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f875b4f472f7 6893554: SPECjvm2008 mpegaudio fails with SecurityException Summary: The problem occurs with negative numbers, as the 32-bit input values are sign extended into the 64-bit registers. Reviewed-by: kvn ! src/cpu/sparc/vm/sparc.ad Changeset: 4926bf2d292f Author: cfang Date: 2009-10-29 08:49 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/4926bf2d292f Merge Changeset: 29adffcb6a61 Author: tonyp Date: 2009-10-30 13:31 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/29adffcb6a61 Merge