Request for review (s): 6814390 G1: remove the concept of non-generational G1
bengt.rutisson at oracle.com
Thu Aug 18 00:28:12 PDT 2011
Thanks for the review!
> Looks good to me. You may want to consider removing the
> CMCheckpointRootsInitialClosure - it's only instantiated in the code
> you removed from concurrentMarkThread.cpp.
Good point. I removed the CMCheckpointRootsInitialClosure class. Here is
an updated webrev:
> On 08/16/11 11:03, Bengt Rutisson wrote:
>> Hi all,
>> Could I have a couple of reviews for this change?
>> G1 was originally designed to be able to run in a non-generational
>> mode. This has not been used for a long time and no testing has been
>> done. Thus, the code has bit rotted. We don't see the need for this
>> feature anymore, so rather than fixing it we should remove it.
>> This is actually a low priority item, but since it will make my next
>> step (supporting young space sizing better) simpler I would like to
>> get this CR out of the way.
>> 6814390 G1: remove the concept of non-generational G1
More information about the hotspot-gc-dev