RFR (S): 7080389: G1: refactor marking code in evacuation pause copy closures

Stefan Karlsson stefan.karlsson at oracle.com
Fri Aug 19 07:35:32 PDT 2011


Tony,

On 08/19/2011 04:19 PM, Tony Printezis wrote:
> Stefan,
>
> OK, good point. Maybe John can change the comment to something like 
> "Need to mark the copied object if we're root scanning closure during 
> initial mark, ....". Would this address your concern?

I just don't see the reason for giving the parameter such a "generic" 
name and then having comments about initial marking root scan in the 
code whenever the parameter is used.

StefanK

>
> Tony
>
> On 08/19/2011 10:01 AM, Stefan Karlsson wrote:
>> But that's not what the comment says:
>>
>> 4339   // Need to mark the copied object if we're an initial
>> 4340   // mark closure, or the object is already marked and
>> 4341   // we need to preserve the mark.
>> 4342   bool should_mark = do_mark_forwardee ||
>> 4343       (_g1->mark_in_progress()&&  !_g1->is_obj_ill(obj));
>>
>> and
>>
>> 4357     // Object is not in collection set - if we're an initial mark
>> 4358     // closure then mark the object.
>> 4359     if (do_mark_forwardee) {
>>
>> StefanK
>>
>>>
>>> Tony
>>



More information about the hotspot-gc-dev mailing list