Request for review (XS): 7082220: Visual Studio projects broken after change 7016797: Hotspot: securely/restrictive load dlls and new

Keith McGuigan keith.mcguigan at oracle.com
Tue Aug 23 11:59:59 PDT 2011


Thumbs up.

On Aug 23, 2011, at 2:31 PM, Bengt Rutisson wrote:

>
> Poonam and Jesper,
>
> Thanks for the prompt reviews! In theory I am all set now, but since  
> I think this is runtime code it would be great if I could get a  
> review from someone on the runtime team as well.
>
> It's a really small change, so a review should be fast...
>
> Thanks,
> Bengt
>
> On 2011-08-23 12:58, Poonam Bajaj wrote:
>>
>> Looks good!
>>
>> Thanks,
>> Poonam
>>
>> On 8/23/2011 2:56 PM, Bengt Rutisson wrote:
>>>
>>>
>>> Hi all,
>>>
>>> Could I please have a couple of reviews for this small fix? After  
>>> the secure dll loading fix (7016797) the psapi.lib library is  
>>> needed for Windows builds. The original change made sure that this  
>>> library is provided to the linker for the command line builds.  
>>> However, the builds from inside Visual Studio also need to know  
>>> about this library.
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~brutisso/7082220/webrev/
>>>
>>> CR:
>>> http://monaco.us.oracle.com/detail.jsf?cr=7082220
>>>
>>> Testing:
>>> I created a Visual Studio project with the create script and with  
>>> the change above the project builds nicely.
>>>
>>> I am including both Runtime and GC in this mail. The change is to  
>>> runtime code, but I would like to push this through hotspot-gc.  
>>> The reason is that this is blocking my work. Whenever I am setting  
>>> up a new repository I run into this issue. But it seems that I am  
>>> the only one who uses the Visual Studio builds at the moment. The  
>>> issue has been around for several months but it only got  
>>> integrated into hsx/hotspot-gc 5 days ago. So, for me it would be  
>>> easier to integrate directly into hotspot-gc and start using the  
>>> fix rather than having to wait for the fix to propagate from  
>>> hotspot-rt to hotspot-gc.
>>>
>>> Thanks,
>>> Bengt
>>
>>
>



More information about the hotspot-gc-dev mailing list