CRR (XS): 7123165: G1: output during parallel verification can get messed up
bengt.rutisson at oracle.com
Tue Dec 20 11:11:24 PST 2011
On 2011-12-20 17:28, Tony Printezis wrote:
> Thanks for the _very_ prompt code review! I made the change you
> requested, latest webrev here:
Thanks for fixing that! Looks good. Ship it!
> On 12/20/2011 10:25 AM, Bengt Rutisson wrote:
>> Looks good to me.
>> One style question. Line 97. Would you be ok with adding a newline
>> after "template<class T>"?
>> I think that's common in hotspot and it's what is done on line 193.
>> 20 dec 2011 kl. 14:38 skrev Tony Printezis<tony.printezis at oracle.com>:
>>> Hi all,
>>> Can I have a couple of quick reviews for this very small change (<
>>> 10 lines changed)?
>>> During parallel verification each worker now takes a lock after it
>>> detects a failure and while it's generating output. This way the
>>> output from separate workers is not interleaved and it's easier to
>>> read. I came across this issue while testing some recent changes and
>>> this patch made my life easier. It might make your life easier some
>>> day too. :-)
More information about the hotspot-gc-dev