From jon.masamitsu at oracle.com Tue Mar 1 08:29:47 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Tue, 01 Mar 2011 08:29:47 -0800 Subject: Hung JVM consuming 100% CPU In-Reply-To: <4D6CBE9A.6040304@cisco.com> References: <4D6CBE9A.6040304@cisco.com> Message-ID: <4D6D1EFB.70606@oracle.com> For 6692906 to be the problem there needs to be a CMS concurrent phase in progress (marking, precleaning or sweeping) and a minor collection running (with UseParNewGC in use). From the fragment of the gc log I could not tell for sure (maybe it was in the ... removed) but I don't think a concurrent phase was in progress so I would say it is not 6692906). Did you try -XX:-UseParNewGC as was suggested? Your minor pauses are not particularly long so maybe you could afford to try it. 6692906 will not happen without UseParNewGC. Note you need to turn of UseParNewGC as it is the default for CMS. Look back through the log for any other ParNew (promotion failed) and see what happens in those cases (in you find one). 2+ hours is too long. The gentleman who would know best about this code is out of the office until the end of the week. I'll talk to him about this to see if he remembers a recent fix that I don't. On 03/01/11 01:38, Bogdan Dimitriu wrote: > Hi guys, > > We're having a problem with garbage collection as described here: > http://forums.oracle.com/forums/message.jspa?messageID=9345173 (I > apologise if posting links is not the right policy, but I prefer not to > duplicate data). > > We are going to try an upgrade to JRE 6u24 soon, but reading the release > notes for each of the versions since 6u20, I don't have much hope of > this upgrade fixing the problem. > > I have searched a bit on the Java bugs database and I've come across > something that looks similar to the problem I am experiencing: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6692906, but I'm not > convinced this is exactly the same issue. This bug it seems will be > fixed in 6u25 (which I've read will be released late March or early April). > > The reason I'm leaning towards thinking this is a JVM bug is the fact > that the JVM can stay in the hung state (as described on the forum) for > 2+ hours until we kill the process. > > I was hoping to get an idea about this from the source :), so any hints > will be greatly appreciated. > > Thanks, > Bogdan > _______________________________________________ > hotspot-gc-use mailing list > hotspot-gc-use at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From jon.masamitsu at oracle.com Tue Mar 1 13:12:40 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Tue, 01 Mar 2011 13:12:40 -0800 Subject: Hung JVM consuming 100% CPU In-Reply-To: <3BA76B61-E7DA-49E1-AEFE-819214B3C729@kodewerk.com> References: <4D6CBE9A.6040304@cisco.com> <4D6D1EFB.70606@oracle.com> <3BA76B61-E7DA-49E1-AEFE-819214B3C729@kodewerk.com> Message-ID: <4D6D6148.7090906@oracle.com> On 03/01/11 09:26, Charles K Pepperdine wrote: > Tenured is 524288K of which 478087K is occupied, greater than 90% I've > just been recently poking about in the source trying to sort out how > logs are being printed. I've seen that partial fragments of the log > are printed and that the " [CMS" fragment is printed only after a CMS > has been triggered. So, the problem is bounded by the log messages > (sans a stray pointer bug). > > My question is, shouldn't a 90% occupancy of tenured trigger a full GC? The CMS concurrent collections are fast from what I've seen (on the order of the time between ParNew collections). The rate at which objects are getting promoted is also low (maybe 3m per ParNew collection). CMS thinks it can wait to start a concurrent collection. The fact that a "promotion failure" happened makes it look like fragmentation. > > Regards, > Kirk > > > On Mar 1, 2011, at 5:29 PM, Jon Masamitsu wrote: > >> For 6692906 to be the problem there needs to be a >> CMS concurrent phase in progress (marking, precleaning or >> sweeping) and a minor collection running (with >> UseParNewGC in use). From the fragment of the gc log >> I could not tell for sure (maybe it was in the ... removed) >> but I don't think a concurrent phase was in progress >> so I would say it is not 6692906). Did you try >> -XX:-UseParNewGC as was suggested? Your minor >> pauses are not particularly long so maybe you >> could afford to try it. 6692906 will not happen >> without UseParNewGC. Note you need to turn of >> UseParNewGC as it is the default for CMS. >> >> Look back through the log for any other >> ParNew (promotion failed) and see what happens >> in those cases (in you find one). 2+ hours is too >> long. >> >> The gentleman who would know best about this code >> is out of the office until the end of the week. I'll talk >> to him about this to see if he remembers a recent >> fix that I don't. >> >> >> On 03/01/11 01:38, Bogdan Dimitriu wrote: >>> Hi guys, >>> >>> We're having a problem with garbage collection as described here: >>> http://forums.oracle.com/forums/message.jspa?messageID=9345173 (I >>> apologise if posting links is not the right policy, but I prefer not to >>> duplicate data). >>> >>> We are going to try an upgrade to JRE 6u24 soon, but reading the release >>> notes for each of the versions since 6u20, I don't have much hope of >>> this upgrade fixing the problem. >>> >>> I have searched a bit on the Java bugs database and I've come across >>> something that looks similar to the problem I am experiencing: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6692906, but I'm not >>> convinced this is exactly the same issue. This bug it seems will be >>> fixed in 6u25 (which I've read will be released late March or early >>> April). >>> >>> The reason I'm leaning towards thinking this is a JVM bug is the fact >>> that the JVM can stay in the hung state (as described on the forum) for >>> 2+ hours until we kill the process. >>> >>> I was hoping to get an idea about this from the source :), so any hints >>> will be greatly appreciated. >>> >>> Thanks, >>> Bogdan >>> _______________________________________________ >>> hotspot-gc-use mailing list >>> hotspot-gc-use at openjdk.java.net >>> http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use >> _______________________________________________ >> hotspot-gc-use mailing list >> hotspot-gc-use at openjdk.java.net >> http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110301/56ae70c8/attachment.html -------------- next part -------------- _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From jon.masamitsu at oracle.com Tue Mar 1 14:44:39 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Tue, 01 Mar 2011 14:44:39 -0800 Subject: Hung JVM consuming 100% CPU In-Reply-To: <919F96FA-E09E-47BA-819C-0DFF2D9CF5F9@kodewerk.com> References: <4D6CBE9A.6040304@cisco.com> <4D6D1EFB.70606@oracle.com> <3BA76B61-E7DA-49E1-AEFE-819214B3C729@kodewerk.com> <4D6D6148.7090906@oracle.com> <919F96FA-E09E-47BA-819C-0DFF2D9CF5F9@kodewerk.com> Message-ID: <4D6D76D7.9070505@oracle.com> On 03/01/11 14:00, Charles K Pepperdine wrote: > > ... >> The CMS concurrent collections are fast from what I've seen (on the >> order of >> the time between ParNew collections). The rate at which objects are >> getting >> promoted is also low (maybe 3m per ParNew collection). CMS thinks it >> can wait to start a concurrent collection. The fact that a >> "promotion failure" >> happened makes it look like fragmentation. > > Even with occupancy greater than 90%? I could very well be wrong about > this but I thought that promotion failure meant just that, the young > gen collector wasn't able to stuff objects up into tenured space. That > didn't preclude fragmentation but in this case occupancy is 90% which > IIRC is well above the OMG, I can't keep up lets trigger a parallel > collection threshold. > > I don't see CMSInitiatingOccupancyFraction on the command line. -Xmx896m -Xss128k -XX:NewSize=384M -XX:MaxPermSize=96m -XX:+UseParNewGC -XX:+UseConcMarkSweepGC so CMS isn't using occupancy of the tenured gen to start a cycle. That is the default behavior. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110301/525fcdd5/attachment.html -------------- next part -------------- _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From jon.masamitsu at oracle.com Wed Mar 2 10:45:22 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Wed, 02 Mar 2011 10:45:22 -0800 Subject: Hung JVM consuming 100% CPU In-Reply-To: References: <4D6CBE9A.6040304@cisco.com> <4D6D1EFB.70606@oracle.com> <3BA76B61-E7DA-49E1-AEFE-819214B3C729@kodewerk.com> <4D6D6148.7090906@oracle.com> <919F96FA-E09E-47BA-819C-0DFF2D9CF5F9@kodewerk.com> <4D6D76D7.9070505@oracle.com> Message-ID: <4D6E9042.4000201@oracle.com> Kirk, you're right! The MinFreeRatio and MaxFreeRatio do result in an initiating occupancy as you describe. Does seem like a concurrent collection should have started. On 3/1/2011 9:06 PM, Charles K Pepperdine wrote: > Hi Jon, > > >>> >>> >> I don't see CMSInitiatingOccupancyFraction on the command line. >> >> >> -Xmx896m -Xss128k -XX:NewSize=384M -XX:MaxPermSize=96m >> -XX:+UseParNewGC -XX:+UseConcMarkSweepGC >> >> so CMS isn't using occupancy of the tenured gen to start a cycle. >> That is the >> default behavior. > > Ok, I'm trying to understand what you are saying. It was my > understanding that CMS is initiated when tenured reaches a value of > 68% = current occupancy + the anticipated promotions. So are you > saying that setting the initiating occupancy fraction doesn't override > that value, it completely changes how CMS is triggered? Is the > flag UseCMSInitiatingOccupancyOnly only valid when you > use CMSInitiatingOccupancyFraction or does that flag also use > anticipated promotions as part of it's calculation? > > TIA, > Kirk -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110302/95113e96/attachment.html -------------- next part -------------- _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From jon.masamitsu at oracle.com Wed Mar 2 11:56:19 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Wed, 02 Mar 2011 11:56:19 -0800 Subject: Hung JVM consuming 100% CPU In-Reply-To: References: <4D6CBE9A.6040304@cisco.com> <4D6D1EFB.70606@oracle.com> <3BA76B61-E7DA-49E1-AEFE-819214B3C729@kodewerk.com> <4D6D6148.7090906@oracle.com> <919F96FA-E09E-47BA-819C-0DFF2D9CF5F9@kodewerk.com> <4D6D76D7.9070505@oracle.com> <4D6E9042.4000201@oracle.com> Message-ID: <4D6EA0E3.8080408@oracle.com> Kirk, Just checked and the default values of MinHeapFreeRatio results in an initiating occupancy of 92% so that answers that (see ConcurrentMarkSweepGeneration::init_initiating_occupancy()). Hopefully not to get too boring but I think the problem has to do with a partially initialized object. I've seen other parts of the collector run into such objects but this may be a new one. Have to consult about this. Jon PS. Don't think it is the mix of objects. More likely a timing issue plus some circumstance we have not run into before. On 3/2/2011 11:31 AM, Charles K Pepperdine wrote: > Hi Jon, > > Thats a relief, I though I was going to have to rework a section of > slides! > > So, it seems like an unexpected glut of objects were promoted and the > cms-abortable-preclean wasn't able to get rid of anything grey. Could > it be that fragmentation was bad enough and free space was low enough > to make compaction difficult if not impossible? Certainly enough free > space to avoid OOME. How would one simulate that? Maps of Maps of Maps > of Maps ad nasium with holes punched into them containing randomly > sized data? > > TIA, > Kirk > > PS not to figure out why I'm half subscribed... > > On Mar 2, 2011, at 7:45 PM, Jon Masamitsu wrote: > >> Kirk, you're right! The MinFreeRatio and MaxFreeRatio do result in an >> initiating occupancy as you describe. Does seem like a concurrent >> collection should have started. >> >> >> On 3/1/2011 9:06 PM, Charles K Pepperdine wrote: >>> Hi Jon, >>> >>> >>>>> >>>>> >>>> I don't see CMSInitiatingOccupancyFraction on the command line. >>>> >>>> >>>> -Xmx896m -Xss128k -XX:NewSize=384M -XX:MaxPermSize=96m >>>> -XX:+UseParNewGC -XX:+UseConcMarkSweepGC >>>> >>>> so CMS isn't using occupancy of the tenured gen to start a cycle. >>>> That is the >>>> default behavior. >>> >>> Ok, I'm trying to understand what you are saying. It was my >>> understanding that CMS is initiated when tenured reaches a value of >>> 68% = current occupancy + the anticipated promotions. So are you >>> saying that setting the initiating occupancy fraction doesn't >>> override that value, it completely changes how CMS is triggered? Is >>> the flag UseCMSInitiatingOccupancyOnly only valid when you >>> use CMSInitiatingOccupancyFraction or does that flag also use >>> anticipated promotions as part of it's calculation? >>> >>> TIA, >>> Kirk > -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110302/055ac2cd/attachment-0001.html -------------- next part -------------- _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From y.s.ramakrishna at oracle.com Thu Mar 3 03:01:21 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 03 Mar 2011 03:01:21 -0800 Subject: Hung JVM consuming 100% CPU In-Reply-To: <4D6CBE9A.6040304@cisco.com> References: <4D6CBE9A.6040304@cisco.com> Message-ID: <4D6F7501.5070805@oracle.com> Hi Bogdan -- I agree with Jon that this is not 6692906. Rather it's a case of a bug in object size computation causing the GC to go awry. There _were_ a few related bugs fixed in this area not long ago (in 6u23 i believe), so I believe you'll find that the upgrade to 6u23 or higher would fix this problem. If you find that the latest 6uXX update (6u24?) still exhibits this problem, please file a new bug via your Java support channel and let us know. thanks! -- ramki On 3/1/2011 1:38 AM, Bogdan Dimitriu wrote: > Hi guys, > > We're having a problem with garbage collection as described here: > http://forums.oracle.com/forums/message.jspa?messageID=9345173 (I > apologise if posting links is not the right policy, but I prefer not to > duplicate data). > > We are going to try an upgrade to JRE 6u24 soon, but reading the release > notes for each of the versions since 6u20, I don't have much hope of > this upgrade fixing the problem. > > I have searched a bit on the Java bugs database and I've come across > something that looks similar to the problem I am experiencing: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6692906, but I'm not > convinced this is exactly the same issue. This bug it seems will be > fixed in 6u25 (which I've read will be released late March or early April). > > The reason I'm leaning towards thinking this is a JVM bug is the fact > that the JVM can stay in the hung state (as described on the forum) for > 2+ hours until we kill the process. > > I was hoping to get an idea about this from the source :), so any hints > will be greatly appreciated. > > Thanks, > Bogdan > _______________________________________________ > hotspot-gc-use mailing list > hotspot-gc-use at openjdk.java.net > http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From y.s.ramakrishna at oracle.com Thu Mar 3 09:57:11 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 03 Mar 2011 09:57:11 -0800 Subject: Hung JVM consuming 100% CPU In-Reply-To: <4D6F8A13.1030903@cisco.com> References: <4D6CBE9A.6040304@cisco.com> <4D6F7501.5070805@oracle.com> <4D6F8A13.1030903@cisco.com> Message-ID: <4D6FD677.7030405@oracle.com> On 3/3/2011 4:31 AM, Bogdan Dimitriu wrote: > Thanks Srinivas, > > We will upgrade our servers to JRE 6u24 soon and I will let you know after a while if we are still > seeing the problem. OK, thanks! > > If it is still a problem, do you reckon that fiddling with the -XX:CMSInitiatingOccupancyFraction > option could improve the fragmentation issue and hence will make compaction less likely (assuming > the bug is in the compaction code)? We've got some CPU cycles to spare, so we could afford to lower > this value a bit. The bug i am thinking about is actually not in compaction code; rather it's in ParNew+CMS scavenge code that causes promoted objects to be corrupted. Compaction is then unlucky to run into those objects (because they are still alive). So avoiding the compaction is not necessarily going to avoid the issue. Nonetheless, avoiding a situation where compaction is needed is probably worthwhile, because I am assuming that you are using CMS so as to avoid the kind of costly GC pauses that compaction entails. Thus, tuning to avoid compaction has independent value, i think. PS: By the way, I think it might be worthwhile to send in the core file to Oracle, in any case, for analysis to see if the crash in question has the rough shape of the bug(s) that we were thinking about... -- ramki > > Bogdan > > On 03/03/11 11:01, Y. Srinivas Ramakrishna wrote: >> Hi Bogdan -- >> >> I agree with Jon that this is not 6692906. >> Rather it's a case of a bug in object size computation >> causing the GC to go awry. There _were_ a few related >> bugs fixed in this area not long ago (in 6u23 i believe), >> so I believe you'll find that the upgrade to 6u23 >> or higher would fix this problem. >> If you find that the latest 6uXX update (6u24?) still >> exhibits this problem, please file a new bug via your >> Java support channel and let us know. >> >> thanks! >> -- ramki >> >> On 3/1/2011 1:38 AM, Bogdan Dimitriu wrote: >>> Hi guys, >>> >>> We're having a problem with garbage collection as described here: >>> http://forums.oracle.com/forums/message.jspa?messageID=9345173 (I >>> apologise if posting links is not the right policy, but I prefer not to >>> duplicate data). >>> >>> We are going to try an upgrade to JRE 6u24 soon, but reading the release >>> notes for each of the versions since 6u20, I don't have much hope of >>> this upgrade fixing the problem. >>> >>> I have searched a bit on the Java bugs database and I've come across >>> something that looks similar to the problem I am experiencing: >>> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6692906, but I'm not >>> convinced this is exactly the same issue. This bug it seems will be >>> fixed in 6u25 (which I've read will be released late March or early April). >>> >>> The reason I'm leaning towards thinking this is a JVM bug is the fact >>> that the JVM can stay in the hung state (as described on the forum) for >>> 2+ hours until we kill the process. >>> >>> I was hoping to get an idea about this from the source :), so any hints >>> will be greatly appreciated. >>> >>> Thanks, >>> Bogdan >>> _______________________________________________ >>> hotspot-gc-use mailing list >>> hotspot-gc-use at openjdk.java.net >>> http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use >> _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From john.coomes at oracle.com Thu Mar 3 20:44:36 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Mar 2011 04:44:36 +0000 Subject: hg: jdk7/hotspot-gc: 13 new changesets Message-ID: <20110304044436.76B5C47C63@hg.openjdk.java.net> Changeset: 995077c73fbb Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/995077c73fbb Added tag jdk7-b130 for changeset cc58c11af154 ! .hgtags Changeset: 0fd0aeb592cb Author: jqzuo Date: 2010-12-09 10:58 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/0fd0aeb592cb Merge Changeset: 20955959b7b7 Author: jqzuo Date: 2010-12-22 15:55 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/20955959b7b7 Merge Changeset: 08fe18caf411 Author: jqzuo Date: 2011-01-10 13:45 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/08fe18caf411 Merge Changeset: aee1b0183364 Author: jqzuo Date: 2011-01-24 17:14 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/aee1b0183364 Merge Changeset: 12764a5a3aec Author: jqzuo Date: 2011-02-01 15:03 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/12764a5a3aec Merge Changeset: df3abd560cbd Author: jqzuo Date: 2011-02-09 16:05 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/df3abd560cbd Merge Changeset: e2370dfcc721 Author: paulk Date: 2011-02-14 14:29 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/e2370dfcc721 7019371: JDK7 is not building UPX. IFTW wrappers are not compressed. Reviewed-by: billyh, jqzuo ! make/deploy-rules.gmk Changeset: 5466f13d19be Author: jqzuo Date: 2011-02-21 14:18 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/5466f13d19be Merge Changeset: da55264ff2fb Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/da55264ff2fb 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 5d86d951426a Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/5d86d951426a Merge Changeset: 0f62a65fb666 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/0f62a65fb666 Added tag jdk7-b131 for changeset 5d86d951426a ! .hgtags Changeset: b1fafacc3040 Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/b1fafacc3040 Added tag jdk7-b132 for changeset 0f62a65fb666 ! .hgtags From john.coomes at oracle.com Thu Mar 3 20:44:45 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Mar 2011 04:44:45 +0000 Subject: hg: jdk7/hotspot-gc/corba: 9 new changesets Message-ID: <20110304044453.2E0F047C64@hg.openjdk.java.net> Changeset: 30ecf5c90a30 Author: mfang Date: 2011-02-10 11:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/30ecf5c90a30 7014477: pt_BR corba resource bundle is missing in jdk7 build Reviewed-by: ohair ! make/common/Defs.gmk Changeset: c08dff674e53 Author: mfang Date: 2011-02-10 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/c08dff674e53 7017734: jdk7 message drop 1 translation integration Reviewed-by: ogino, yhuang ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_de.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_es.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_fr.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_it.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ja.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_ko.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_pt_BR.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_sv.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_zh_CN.properties ! src/share/classes/com/sun/corba/se/impl/orbutil/resources/sunorb_zh_TW.properties Changeset: e0f0b358cd2c Author: mfang Date: 2011-02-11 22:50 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/e0f0b358cd2c Merge Changeset: 563a8f8b5be3 Author: mfang Date: 2011-02-11 23:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/563a8f8b5be3 Merge Changeset: 49a96611c870 Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/49a96611c870 Added tag jdk7-b130 for changeset 563a8f8b5be3 ! .hgtags Changeset: a9335b646c1c Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/a9335b646c1c 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 9d6dd2cdfcb9 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/9d6dd2cdfcb9 Merge Changeset: 1b1e75e8f476 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/1b1e75e8f476 Added tag jdk7-b131 for changeset 9d6dd2cdfcb9 ! .hgtags Changeset: 671fe2e623ff Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/671fe2e623ff Added tag jdk7-b132 for changeset 1b1e75e8f476 ! .hgtags From john.coomes at oracle.com Thu Mar 3 20:45:00 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Mar 2011 04:45:00 +0000 Subject: hg: jdk7/hotspot-gc/jaxp: 5 new changesets Message-ID: <20110304044500.AA67A47C65@hg.openjdk.java.net> Changeset: f2ad604323c0 Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/f2ad604323c0 Added tag jdk7-b130 for changeset ab107c1bc4b9 ! .hgtags Changeset: a57220f22751 Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/a57220f22751 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: eab6f27131e4 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/eab6f27131e4 Merge Changeset: abe04c59a556 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/abe04c59a556 Added tag jdk7-b131 for changeset eab6f27131e4 ! .hgtags Changeset: 8e1148c7911b Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/8e1148c7911b Added tag jdk7-b132 for changeset abe04c59a556 ! .hgtags From john.coomes at oracle.com Thu Mar 3 20:45:07 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Mar 2011 04:45:07 +0000 Subject: hg: jdk7/hotspot-gc/jaxws: 5 new changesets Message-ID: <20110304044507.A79D247C66@hg.openjdk.java.net> Changeset: a8ffd75ad5df Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/a8ffd75ad5df Added tag jdk7-b130 for changeset ba1fac1c2083 ! .hgtags Changeset: 9e3904866cab Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/9e3904866cab 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 438abc0356cd Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/438abc0356cd Merge Changeset: 0e57c3272d37 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/0e57c3272d37 Added tag jdk7-b131 for changeset 438abc0356cd ! .hgtags Changeset: 359d0c8c00a0 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/359d0c8c00a0 Added tag jdk7-b132 for changeset 0e57c3272d37 ! .hgtags From john.coomes at oracle.com Thu Mar 3 20:51:34 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Mar 2011 04:51:34 +0000 Subject: hg: jdk7/hotspot-gc/jdk: 155 new changesets Message-ID: <20110304051906.3445247C6F@hg.openjdk.java.net> Changeset: bad0ddc6f573 Author: prr Date: 2011-01-26 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bad0ddc6f573 7014738: Update jdk repo application manifests with Windows 7 compatibility section. Reviewed-by: bae, igor ! src/windows/resource/java.manifest Changeset: d0e158473b6f Author: prr Date: 2011-01-26 13:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d0e158473b6f 6940890: Java doesn't pick up the correct fontconfig files in latest Solaris Next builds Reviewed-by: bae, igor ! src/share/classes/sun/java2d/SunGraphicsEnvironment.java Changeset: 4cf20706dbfa Author: dlila Date: 2011-01-27 16:43 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4cf20706dbfa 4645692: solveCubic does not return all solutions. Summary: more robust solveCubic implementation. Reviewed-by: flar ! src/share/classes/java/awt/geom/CubicCurve2D.java + test/java/awt/geom/CubicCurve2D/ContainsTest.java + test/java/awt/geom/CubicCurve2D/IntersectsTest.java + test/java/awt/geom/CubicCurve2D/SolveCubicTest.java Changeset: 21621a756b32 Author: lana Date: 2011-02-03 19:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/21621a756b32 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 5e624003e622 Author: dlila Date: 2011-02-08 09:22 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5e624003e622 7016856: dashing performance was reduced during latest changes to the OpenJDK rasterizer Summary: Optimized dashing, rasterizing, and the flow of transformed coordinates Reviewed-by: flar ! src/share/classes/sun/java2d/pisces/Curve.java ! src/share/classes/sun/java2d/pisces/Dasher.java ! src/share/classes/sun/java2d/pisces/Helpers.java ! src/share/classes/sun/java2d/pisces/PiscesCache.java ! src/share/classes/sun/java2d/pisces/PiscesRenderingEngine.java ! src/share/classes/sun/java2d/pisces/PiscesTileGenerator.java ! src/share/classes/sun/java2d/pisces/Renderer.java ! src/share/classes/sun/java2d/pisces/Stroker.java ! src/share/classes/sun/java2d/pisces/TransformingPathConsumer2D.java Changeset: 577c5d930e44 Author: dav Date: 2011-01-25 15:33 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/577c5d930e44 6693961: cross-window focus transfer ability in the Focus Spec should be revised Reviewed-by: ant, art ! src/share/classes/java/awt/doc-files/FocusSpec.html Changeset: 5f3615691623 Author: dav Date: 2011-01-25 19:07 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5f3615691623 6431076: Cursor gets reset to text cursor in xawt TextArea when autoscrolling on append Reviewed-by: art, anthony ! src/solaris/classes/sun/awt/X11/XComponentPeer.java ! src/solaris/classes/sun/awt/X11/XGlobalCursorManager.java ! src/solaris/classes/sun/awt/X11/XTextAreaPeer.java + test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test.java + test/java/awt/TextArea/MouseOverScrollbarWhenTyping/Test1.java Changeset: 6fd2d28e66cd Author: denis Date: 2011-01-28 16:52 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6fd2d28e66cd 6340263: Regression testcase java/awt/dnd/DnDClipboardDeadlockTest throughs IOException: Owner timed out Reviewed-by: anthony, art ! src/solaris/classes/sun/awt/X11/XSelection.java Changeset: 9da15efec22b Author: andrew Date: 2011-02-01 17:44 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9da15efec22b 7015232: missing copyright header in CheckZOrderChange.java Summary: Add standard GPL header as on other tests Reviewed-by: anthony ! test/java/awt/Container/CheckZOrderChange/CheckZOrderChange.java Changeset: 3244848a4a2b Author: dav Date: 2011-02-04 17:32 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3244848a4a2b 6741526: KeyboardFocusManager.setDefaultFocusTraversalPolicy(FocusTraversalPolicy) affects created components Reviewed-by: ant, dcherepanov ! src/share/classes/java/awt/Window.java + test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_AWT.java + test/java/awt/KeyboardFocusmanager/DefaultPolicyChange/DefaultPolicyChange_Swing.java Changeset: b5fc02e1a944 Author: lana Date: 2011-02-08 14:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b5fc02e1a944 Merge Changeset: 69fac04eda38 Author: rupashka Date: 2011-01-27 14:23 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/69fac04eda38 6902615: Method JTextComponent.getKeyStrokesForAction() throws StackOverflowError Reviewed-by: peterz ! src/share/classes/javax/swing/text/Keymap.java Changeset: ec066e903b84 Author: rupashka Date: 2011-01-27 14:33 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ec066e903b84 6935155: @since tag is missing in JTextComponent.save/restoreComposedText Reviewed-by: alexp ! src/share/classes/javax/swing/text/JTextComponent.java Changeset: 457f6b2cc155 Author: malenkov Date: 2011-01-31 21:22 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/457f6b2cc155 7001484: DOC: Method javax.swing.border.StrokeBorder.getBorderInsets() should specify how it converts float Reviewed-by: alexp ! src/share/classes/javax/swing/border/StrokeBorder.java Changeset: 020b4695370c Author: malenkov Date: 2011-01-31 21:31 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/020b4695370c 7001118: DOC: javax.swing.border.StrokeBorder.paintBorder() doesn't throw NPE in all specified cases Reviewed-by: alexp ! src/share/classes/javax/swing/border/StrokeBorder.java Changeset: 07bea0d4e454 Author: malenkov Date: 2011-01-31 21:49 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/07bea0d4e454 6999045: DOC: Unclear spec for BevelBorder constructor and BorderFactory factory method (colors switching) Reviewed-by: alexp ! src/share/classes/javax/swing/BorderFactory.java ! src/share/classes/javax/swing/border/BevelBorder.java Changeset: cbcd461067c5 Author: rupashka Date: 2011-02-02 18:37 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cbcd461067c5 6988168: Press the "Toggle Font" button.The size of the combo box didn't change. Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java Changeset: 6c4b6780ab20 Author: rupashka Date: 2011-02-02 18:41 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6c4b6780ab20 6988176: There is focus painted inside the button. Reviewed-by: alexp ! src/share/classes/sun/swing/WindowsPlacesBar.java Changeset: 057e9b837105 Author: rupashka Date: 2011-02-03 16:30 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/057e9b837105 7013453: BufferStrategyPaintManager.dispose will cause IllegalMonitorStateException in event thread Reviewed-by: alexp ! src/share/classes/javax/swing/BufferStrategyPaintManager.java + test/javax/swing/RepaintManager/7013453/bug7013453.java Changeset: 0fae79ec7248 Author: naoto Date: 2011-02-03 09:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0fae79ec7248 7013282: No appropriate CCC request for listed JDK 7 changes in java.util.spi package (b121) Reviewed-by: peytoia ! src/share/classes/java/util/spi/LocaleNameProvider.java Changeset: c7e368a95c75 Author: alexp Date: 2011-02-07 21:15 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c7e368a95c75 7016942: Revert a refactoring in TooltipManager to allow reflection hack Reviewed-by: rupashka ! src/share/classes/javax/swing/ToolTipManager.java Changeset: 989f6d3eee0d Author: alexp Date: 2011-02-07 21:34 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/989f6d3eee0d 6979537: closed/javax/swing/JSplitPane/UnitTest/UnitTest.java fails Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicSplitPaneUI.java Changeset: 842a0f8c89ea Author: naoto Date: 2011-02-08 09:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/842a0f8c89ea 7015500: Locale.toLanguageTag() uses "und" as lang subtag for private use only Locale Reviewed-by: srl ! src/share/classes/java/util/Locale.java ! src/share/classes/sun/util/locale/LanguageTag.java ! test/java/util/Locale/LocaleEnhanceTest.java Changeset: d002fe0c57c5 Author: lana Date: 2011-02-08 14:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d002fe0c57c5 Merge Changeset: dbfc1e419cb2 Author: darcy Date: 2011-01-24 20:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dbfc1e419cb2 7006578: Project Coin: Retrofit JDK libraries with @SafeVarargs Reviewed-by: mduigou, alexp ! src/share/classes/java/util/Arrays.java ! src/share/classes/java/util/Collections.java ! src/share/classes/java/util/EnumSet.java ! src/share/classes/javax/swing/SwingWorker.java ! src/share/classes/sun/swing/AccumulativeRunnable.java Changeset: ae38d1374e31 Author: mullan Date: 2011-01-24 14:56 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ae38d1374e31 5001004: Required Security Algorithms need to be defined Reviewed-by: wetmore ! src/share/classes/java/security/AlgorithmParameterGenerator.java ! src/share/classes/java/security/AlgorithmParameters.java ! src/share/classes/java/security/KeyFactory.java ! src/share/classes/java/security/KeyPairGenerator.java ! src/share/classes/java/security/KeyStore.java ! src/share/classes/java/security/MessageDigest.java ! src/share/classes/java/security/Policy.java ! src/share/classes/java/security/SecureRandom.java ! src/share/classes/java/security/Security.java ! src/share/classes/java/security/Signature.java ! src/share/classes/java/security/cert/CertPath.java ! src/share/classes/java/security/cert/CertPathBuilder.java ! src/share/classes/java/security/cert/CertPathValidator.java ! src/share/classes/java/security/cert/CertStore.java ! src/share/classes/java/security/cert/Certificate.java ! src/share/classes/java/security/cert/CertificateFactory.java ! src/share/classes/java/security/cert/CertificateFactorySpi.java ! src/share/classes/java/security/cert/package.html ! src/share/classes/java/security/package.html ! src/share/classes/javax/crypto/Cipher.java ! src/share/classes/javax/crypto/ExemptionMechanism.java ! src/share/classes/javax/crypto/KeyAgreement.java ! src/share/classes/javax/crypto/KeyGenerator.java ! src/share/classes/javax/crypto/Mac.java ! src/share/classes/javax/crypto/SecretKeyFactory.java ! src/share/classes/javax/crypto/package.html ! src/share/classes/javax/net/ssl/SSLContext.java ! src/share/classes/javax/net/ssl/package.html ! src/share/classes/javax/security/auth/login/Configuration.java ! src/share/classes/javax/security/auth/login/package.html Changeset: b33e9b15835e Author: mullan Date: 2011-01-24 15:08 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b33e9b15835e Merge - make/common/internal/BinaryPlugs.gmk - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/classes/java/dyn/JavaMethodHandle.java - src/share/classes/java/dyn/LinkagePermission.java - src/share/classes/java/nio/channels/AsynchronousDatagramChannel.java ! src/share/classes/java/security/Security.java ! src/share/classes/javax/net/ssl/SSLContext.java - src/share/classes/sun/java2d/pisces/LineSink.java - src/share/classes/sun/net/httpserver/SelectorCache.java - src/share/classes/sun/nio/ch/SimpleAsynchronousDatagramChannelImpl.java - src/share/classes/sun/security/krb5/KrbKdcReq.java - src/share/classes/sun/security/krb5/internal/TCPClient.java - src/share/classes/sun/security/krb5/internal/UDPClient.java - src/share/demo/nio/zipfs/META-INF/services/java.nio.file.spi.FileSystemProvider - src/share/demo/nio/zipfs/com/sun/nio/zipfs/JarFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipCoder.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipConstants.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipDirectoryStream.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributeView.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileAttributes.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileStore.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystem.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipFileSystemProvider.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipInfo.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipPath.java - src/share/demo/nio/zipfs/com/sun/nio/zipfs/ZipUtils.java - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/share/native/sun/font/layout/HebrewLigatureData.cpp - src/share/native/sun/font/layout/HebrewShaping.cpp - src/share/native/sun/font/layout/HebrewShaping.h - src/solaris/classes/sun/net/www/protocol/http/NTLMAuthentication.java - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.html - test/java/awt/Insets/WindowWithWarningTest/WindowWithWarningTest.java - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/java/nio/channels/AsynchronousDatagramChannel/Basic.java - test/javax/script/E4XErrorTest.java - test/javax/swing/SwingWorker/6480289/bug6480289.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java - test/sun/security/krb5/auto/basic.sh Changeset: 6ac9383640c6 Author: mullan Date: 2011-01-24 15:46 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6ac9383640c6 Merge Changeset: 6e7bed89ce84 Author: mullan Date: 2011-01-25 08:41 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6e7bed89ce84 Merge Changeset: bf1b937076db Author: alanb Date: 2011-01-26 18:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bf1b937076db 7012663: javadoc warning in javax.swing.JComponent and javax.swing.plaf.synth.SynthTextPaneUI Reviewed-by: alexp ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/plaf/synth/SynthTextPaneUI.java Changeset: abab55565eda Author: darcy Date: 2011-01-26 12:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/abab55565eda 7013420: Project Coin: remove general expression support from try-with-resources statement Reviewed-by: alanb ! test/java/nio/channels/FileChannel/Truncate.java Changeset: 236e3f2d0a6b Author: alanb Date: 2011-01-28 09:28 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/236e3f2d0a6b 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: chegar, sherman ! make/java/java/FILES_java.gmk ! make/java/nio/FILES_java.gmk ! make/mkdemo/Makefile ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FileInputStream.java ! src/share/classes/java/io/FileOutputStream.java ! src/share/classes/java/io/FilePermission.java ! src/share/classes/java/io/SerialCallbackContext.java - src/share/classes/java/io/TempFileHelper.java ! src/share/classes/java/nio/channels/FileChannel.java ! src/share/classes/java/nio/channels/SeekableByteChannel.java ! src/share/classes/java/nio/file/AccessMode.java + src/share/classes/java/nio/file/CopyMoveHelper.java ! src/share/classes/java/nio/file/CopyOption.java ! src/share/classes/java/nio/file/DirectoryStream.java - src/share/classes/java/nio/file/FileRef.java ! src/share/classes/java/nio/file/FileStore.java ! src/share/classes/java/nio/file/FileSystem.java ! src/share/classes/java/nio/file/FileSystems.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/FileVisitor.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/LinkOption.java ! src/share/classes/java/nio/file/LinkPermission.java ! src/share/classes/java/nio/file/OpenOption.java ! src/share/classes/java/nio/file/Path.java ! src/share/classes/java/nio/file/PathMatcher.java ! src/share/classes/java/nio/file/Paths.java ! src/share/classes/java/nio/file/SecureDirectoryStream.java + src/share/classes/java/nio/file/TempFileHelper.java ! src/share/classes/java/nio/file/WatchEvent.java ! src/share/classes/java/nio/file/WatchKey.java ! src/share/classes/java/nio/file/WatchService.java ! src/share/classes/java/nio/file/attribute/AclEntry.java ! src/share/classes/java/nio/file/attribute/AclFileAttributeView.java - src/share/classes/java/nio/file/attribute/Attributes.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributeView.java ! src/share/classes/java/nio/file/attribute/BasicFileAttributes.java ! src/share/classes/java/nio/file/attribute/DosFileAttributeView.java ! src/share/classes/java/nio/file/attribute/DosFileAttributes.java ! src/share/classes/java/nio/file/attribute/FileAttribute.java ! src/share/classes/java/nio/file/attribute/FileAttributeView.java ! src/share/classes/java/nio/file/attribute/FileOwnerAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! src/share/classes/java/nio/file/attribute/FileTime.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributeView.java ! src/share/classes/java/nio/file/attribute/PosixFileAttributes.java ! src/share/classes/java/nio/file/attribute/PosixFilePermission.java ! src/share/classes/java/nio/file/attribute/PosixFilePermissions.java ! src/share/classes/java/nio/file/attribute/UserDefinedFileAttributeView.java ! src/share/classes/java/nio/file/attribute/package-info.java ! src/share/classes/java/nio/file/package-info.java ! src/share/classes/java/nio/file/spi/FileSystemProvider.java ! src/share/classes/java/nio/file/spi/FileTypeDetector.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/sun/nio/fs/AbstractAclFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractBasicFileAttributeView.java + src/share/classes/sun/nio/fs/AbstractFileSystemProvider.java ! src/share/classes/sun/nio/fs/AbstractFileTypeDetector.java ! src/share/classes/sun/nio/fs/AbstractPath.java ! src/share/classes/sun/nio/fs/AbstractPoller.java ! src/share/classes/sun/nio/fs/AbstractUserDefinedFileAttributeView.java ! src/share/classes/sun/nio/fs/AbstractWatchKey.java ! src/share/classes/sun/nio/fs/AbstractWatchService.java ! src/share/classes/sun/nio/fs/DynamicFileAttributeView.java ! src/share/classes/sun/nio/fs/FileOwnerAttributeViewImpl.java ! src/share/classes/sun/nio/fs/PollingWatchService.java ! src/share/classes/sun/security/provider/SeedGenerator.java ! src/share/classes/sun/tools/jar/Main.java ! src/share/sample/nio/file/AclEdit.java ! src/share/sample/nio/file/Chmod.java ! src/share/sample/nio/file/Copy.java ! src/share/sample/nio/file/DiskUsage.java ! src/share/sample/nio/file/FileType.java ! src/share/sample/nio/file/WatchDir.java ! src/share/sample/nio/file/Xdd.java ! src/solaris/classes/sun/nio/fs/GnomeFileTypeDetector.java ! src/solaris/classes/sun/nio/fs/LinuxDosFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystem.java ! src/solaris/classes/sun/nio/fs/LinuxFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/LinuxUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/LinuxWatchService.java ! src/solaris/classes/sun/nio/fs/SolarisAclFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystem.java ! src/solaris/classes/sun/nio/fs/SolarisFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/SolarisUserDefinedFileAttributeView.java ! src/solaris/classes/sun/nio/fs/SolarisWatchService.java ! src/solaris/classes/sun/nio/fs/UnixCopyFile.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributeViews.java ! src/solaris/classes/sun/nio/fs/UnixFileAttributes.java ! src/solaris/classes/sun/nio/fs/UnixFileStore.java ! src/solaris/classes/sun/nio/fs/UnixFileSystem.java ! src/solaris/classes/sun/nio/fs/UnixFileSystemProvider.java ! src/solaris/classes/sun/nio/fs/UnixPath.java ! src/solaris/classes/sun/nio/fs/UnixSecureDirectoryStream.java ! src/windows/classes/sun/nio/fs/RegistryFileTypeDetector.java ! src/windows/classes/sun/nio/fs/WindowsFileAttributeViews.java ! src/windows/classes/sun/nio/fs/WindowsFileCopy.java ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! src/windows/classes/sun/nio/fs/WindowsFileSystem.java ! src/windows/classes/sun/nio/fs/WindowsFileSystemProvider.java ! src/windows/classes/sun/nio/fs/WindowsPath.java ! src/windows/classes/sun/nio/fs/WindowsPathParser.java ! src/windows/classes/sun/nio/fs/WindowsSecurityDescriptor.java ! src/windows/classes/sun/nio/fs/WindowsUserDefinedFileAttributeView.java ! src/windows/classes/sun/nio/fs/WindowsWatchService.java ! test/demo/zipfs/basic.sh ! test/java/io/File/IsHidden.java ! test/java/io/File/SetAccess.java ! test/java/io/File/SymLinks.java ! test/java/io/FileInputStream/LargeFileAvailable.java ! test/java/nio/channels/FileChannel/AtomicAppend.java ! test/java/nio/channels/FileChannel/Transfer.java ! test/java/nio/file/DirectoryStream/Basic.java ! test/java/nio/file/DirectoryStream/DriveLetter.java ! test/java/nio/file/DirectoryStream/SecureDS.java ! test/java/nio/file/FileStore/Basic.java + test/java/nio/file/Files/BytesAndLines.java + test/java/nio/file/Files/CheckPermissions.java - test/java/nio/file/Files/ContentType.java + test/java/nio/file/Files/CopyAndMove.java - test/java/nio/file/Files/CreateFileTree.java + test/java/nio/file/Files/DeleteOnClose.java + test/java/nio/file/Files/FileAttributes.java - test/java/nio/file/Files/ForceLoad.java + test/java/nio/file/Files/InterruptCopy.java + test/java/nio/file/Files/Links.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java ! test/java/nio/file/Files/Misc.java + test/java/nio/file/Files/PassThroughFileSystem.java - test/java/nio/file/Files/PrintFileTree.java + test/java/nio/file/Files/SBC.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java + test/java/nio/file/Files/TemporaryFiles.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java + test/java/nio/file/Files/delete_on_close.sh - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy + test/java/nio/file/Files/probeContentType/Basic.java + test/java/nio/file/Files/probeContentType/ForceLoad.java + test/java/nio/file/Files/probeContentType/META-INF/services/java.nio.file.spi.FileTypeDetector + test/java/nio/file/Files/probeContentType/SimpleFileTypeDetector.java + test/java/nio/file/Files/walkFileTree/CreateFileTree.java + test/java/nio/file/Files/walkFileTree/MaxDepth.java + test/java/nio/file/Files/walkFileTree/Nulls.java + test/java/nio/file/Files/walkFileTree/PrintFileTree.java + test/java/nio/file/Files/walkFileTree/SkipSiblings.java + test/java/nio/file/Files/walkFileTree/TerminateWalk.java + test/java/nio/file/Files/walkFileTree/WalkWithSecurity.java + test/java/nio/file/Files/walkFileTree/denyAll.policy + test/java/nio/file/Files/walkFileTree/grantAll.policy + test/java/nio/file/Files/walkFileTree/grantTopOnly.policy + test/java/nio/file/Files/walkFileTree/walk_file_tree.sh - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java ! test/java/nio/file/Path/Misc.java - test/java/nio/file/Path/PassThroughFileSystem.java ! test/java/nio/file/Path/PathOps.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh ! test/java/nio/file/TestUtil.java ! test/java/nio/file/WatchService/Basic.java ! test/java/nio/file/WatchService/FileTreeModifier.java ! test/java/nio/file/WatchService/LotsOfEvents.java ! test/java/nio/file/WatchService/SensitivityModifier.java ! test/java/nio/file/attribute/AclFileAttributeView/Basic.java ! test/java/nio/file/attribute/BasicFileAttributeView/Basic.java ! test/java/nio/file/attribute/DosFileAttributeView/Basic.java - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java ! test/java/nio/file/attribute/FileTime/Basic.java ! test/java/nio/file/attribute/PosixFileAttributeView/Basic.java ! test/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java ! test/java/nio/file/spi/SetDefaultProvider.java ! test/java/nio/file/spi/TestProvider.java Changeset: 60d347deb54d Author: alanb Date: 2011-01-28 09:31 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/60d347deb54d Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! test/demo/zipfs/basic.sh - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: dea360853f8b Author: alanb Date: 2011-01-28 13:26 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dea360853f8b 7015410: test/java/net/Socks/SocksProxyVersion.java needs to be updated due to 7013420 Reviewed-by: chegar ! test/java/net/Socks/SocksProxyVersion.java Changeset: d21a1ce074a7 Author: darcy Date: 2011-01-28 17:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d21a1ce074a7 7015156: Remove JSR 308 changes from core libraries Reviewed-by: mduigou ! src/share/classes/java/lang/SuppressWarnings.java ! src/share/classes/java/lang/annotation/ElementType.java Changeset: f110edeb4428 Author: darcy Date: 2011-02-01 00:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f110edeb4428 7015827: Fix HTML validation issues in java.math package Reviewed-by: mduigou ! src/share/classes/java/math/BigDecimal.java ! src/share/classes/java/math/RoundingMode.java Changeset: d4bc38aa7594 Author: xuelei Date: 2011-02-01 04:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d4bc38aa7594 7011497: new CertPathValidatorException.BasicReason enum constant for constrained algorithm Summary: add new BasicReason and improve trust anchor searching method during cert path validation Reviewed-by: mullan ! src/share/classes/java/security/cert/CertPathValidatorException.java + src/share/classes/sun/security/provider/certpath/AdaptableX509CertSelector.java ! src/share/classes/sun/security/provider/certpath/AlgorithmChecker.java ! src/share/classes/sun/security/provider/certpath/DistributionPointFetcher.java ! src/share/classes/sun/security/provider/certpath/ForwardBuilder.java ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java ! src/share/classes/sun/security/validator/SimpleValidator.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorEndEntity.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorIntermediate.java ! test/sun/security/provider/certpath/DisabledAlgorithms/CPValidatorTrustAnchor.java Changeset: 21d7cd823247 Author: sundar Date: 2011-02-01 21:00 +0530 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/21d7cd823247 7015908: 3 javax.script tests fail with openjdk build Reviewed-by: alanb ! test/javax/script/CauseExceptionTest.java ! test/javax/script/StringWriterPrintTest.java ! test/javax/script/UnescapedBracketRegExTest.java Changeset: 312dc0abb960 Author: sherman Date: 2011-02-01 14:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/312dc0abb960 7015391: (zipfs) Update zip provider for 1/2011 changes 7014948: (zipfs) ZipFileSystem.newFileSystem(Path...) should not throw FileSystemAlreadyExistsException 7015139: (zipfs) ZipPath.delete() should throw DirectoryNotEmptyException when handling "real, non-empty" dir Summary: zip filesystem provider update Reviewed-by: alanb ! make/mkdemo/Makefile ! src/share/demo/nio/zipfs/Demo.java ! src/share/demo/nio/zipfs/README.txt ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileAttributeView.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileStore.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java - src/share/demo/zipfs ! test/demo/zipfs/Basic.java ! test/demo/zipfs/PathOps.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: 25462d7eee24 Author: briangoetz Date: 2011-02-02 13:13 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/25462d7eee24 7012540: java.util.Objects.nonNull() incorrectly named Reviewed-by: darcy, weijun ! src/share/classes/java/io/PrintStream.java ! src/share/classes/java/io/PrintWriter.java ! src/share/classes/java/lang/StackTraceElement.java ! src/share/classes/java/nio/file/DirectoryIteratorException.java ! src/share/classes/java/nio/file/FileTreeWalker.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/java/nio/file/SimpleFileVisitor.java ! src/share/classes/java/util/Formatter.java ! src/share/classes/java/util/Objects.java ! src/share/classes/java/util/Scanner.java ! src/share/classes/sun/security/krb5/KrbAsRep.java ! test/java/util/Objects/BasicObjectsTest.java Changeset: 3c86f24f7500 Author: chegar Date: 2011-02-03 10:10 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3c86f24f7500 7008595: Class loader leak caused by keepAliveTimer thread in KeepAliveCache Reviewed-by: michaelm ! src/share/classes/sun/net/www/http/KeepAliveCache.java ! src/share/classes/sun/net/www/http/KeepAliveStream.java Changeset: dff9b6d18628 Author: coffeys Date: 2011-02-03 11:28 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dff9b6d18628 7016897: Copyright header correction : test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java Reviewed-by: vinnie ! test/sun/security/provider/SeedGenerator/SeedGeneratorChoice.java Changeset: 0f5dc2fc81b1 Author: chegar Date: 2011-02-03 11:56 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0f5dc2fc81b1 6887710: Jar index should avoid putting META-INF in the INDEX.LIST Reviewed-by: michaelm ! src/share/classes/sun/misc/JarIndex.java + test/sun/misc/JarIndex/metaInfFilenames/Basic.java + test/sun/misc/JarIndex/metaInfFilenames/jarA/META-INF/services/my.happy.land + test/sun/misc/JarIndex/metaInfFilenames/jarA/a/A.java + test/sun/misc/JarIndex/metaInfFilenames/jarA/com/message/spi/MessageService.java + test/sun/misc/JarIndex/metaInfFilenames/jarB/META-INF/JAVA2.DS + test/sun/misc/JarIndex/metaInfFilenames/jarB/META-INF/services/no.name.service + test/sun/misc/JarIndex/metaInfFilenames/jarB/b/B.java + test/sun/misc/JarIndex/metaInfFilenames/jarC/META-INF/fonts.mf + test/sun/misc/JarIndex/metaInfFilenames/jarC/META-INF/fonts/Company-corporate.ttf + test/sun/misc/JarIndex/metaInfFilenames/jarC/META-INF/fonts/kidpr.ttf + test/sun/misc/JarIndex/metaInfFilenames/jarC/META-INF/services/com.message.spi.MessageService + test/sun/misc/JarIndex/metaInfFilenames/jarC/my/impl/StandardMessageService.java Changeset: 68e3eba12afe Author: michaelm Date: 2011-02-03 12:57 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/68e3eba12afe 6751021: TEST_BUG: race condition in the test java/lang/Runtime/exec/Duped.java Reviewed-by: alanb ! test/java/lang/Runtime/exec/Duped.java Changeset: e2a182adb30f Author: alanb Date: 2011-02-03 13:37 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e2a182adb30f 7014794: (file) lookupPrincipalByGroupName fails to find large NIS groups Reviewed-by: chegar ! src/solaris/native/sun/nio/fs/UnixNativeDispatcher.c Changeset: 515512634eb4 Author: vinnie Date: 2011-02-03 19:09 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/515512634eb4 6997561: A request for better error handling in JNDI Reviewed-by: robm ! src/share/classes/com/sun/jndi/toolkit/ctx/Continuation.java + test/com/sun/jndi/ldap/LdapName/EmptyNameSearch.java Changeset: 035ecca4379c Author: sherman Date: 2011-02-03 13:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/035ecca4379c 7014645: Support perl style Unicode hex notation \x{...} Summary: Added the construct \x{...} for Unicode hex notation support Reviewed-by: alanb, okutsu ! src/share/classes/java/util/regex/Pattern.java ! test/java/util/regex/RegExTest.java Changeset: 3c1eca364cc7 Author: ksrini Date: 2011-02-03 15:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3c1eca364cc7 6968053: (launcher) hide exceptions under certain launcher failures Reviewed-by: mchung ! src/share/bin/java.c ! src/share/classes/sun/launcher/LauncherHelper.java ! src/share/classes/sun/launcher/resources/launcher.properties ! src/share/classes/sun/misc/VM.java ! test/tools/launcher/Arrrghs.java Changeset: 1b5c838b8db8 Author: vinnie Date: 2011-02-04 00:33 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1b5c838b8db8 6989705: ECC security code native code compiler warnings Reviewed-by: alanb, ohair ! src/share/native/sun/security/ec/ECC_JNI.cpp ! src/share/native/sun/security/ec/impl/ec.c ! src/share/native/sun/security/ec/impl/ec.h ! src/share/native/sun/security/ec/impl/ec2.h ! src/share/native/sun/security/ec/impl/ec2_163.c ! src/share/native/sun/security/ec/impl/ec2_193.c ! src/share/native/sun/security/ec/impl/ec2_233.c ! src/share/native/sun/security/ec/impl/ec2_aff.c ! src/share/native/sun/security/ec/impl/ec2_mont.c ! src/share/native/sun/security/ec/impl/ec_naf.c ! src/share/native/sun/security/ec/impl/ecc_impl.h ! src/share/native/sun/security/ec/impl/ecdecode.c ! src/share/native/sun/security/ec/impl/ecl-curve.h ! src/share/native/sun/security/ec/impl/ecl-exp.h ! src/share/native/sun/security/ec/impl/ecl-priv.h ! src/share/native/sun/security/ec/impl/ecl.c ! src/share/native/sun/security/ec/impl/ecl.h ! src/share/native/sun/security/ec/impl/ecl_curve.c ! src/share/native/sun/security/ec/impl/ecl_gf.c ! src/share/native/sun/security/ec/impl/ecl_mult.c ! src/share/native/sun/security/ec/impl/ecp.h ! src/share/native/sun/security/ec/impl/ecp_192.c ! src/share/native/sun/security/ec/impl/ecp_224.c ! src/share/native/sun/security/ec/impl/ecp_256.c ! src/share/native/sun/security/ec/impl/ecp_384.c ! src/share/native/sun/security/ec/impl/ecp_521.c ! src/share/native/sun/security/ec/impl/ecp_aff.c ! src/share/native/sun/security/ec/impl/ecp_jac.c ! src/share/native/sun/security/ec/impl/ecp_jm.c ! src/share/native/sun/security/ec/impl/ecp_mont.c ! src/share/native/sun/security/ec/impl/logtab.h ! src/share/native/sun/security/ec/impl/mp_gf2m-priv.h ! src/share/native/sun/security/ec/impl/mp_gf2m.c ! src/share/native/sun/security/ec/impl/mp_gf2m.h ! src/share/native/sun/security/ec/impl/mpi-config.h ! src/share/native/sun/security/ec/impl/mpi-priv.h ! src/share/native/sun/security/ec/impl/mpi.c ! src/share/native/sun/security/ec/impl/mpi.h ! src/share/native/sun/security/ec/impl/mplogic.c ! src/share/native/sun/security/ec/impl/mplogic.h ! src/share/native/sun/security/ec/impl/mpmontg.c ! src/share/native/sun/security/ec/impl/mpprime.h ! src/share/native/sun/security/ec/impl/oid.c ! src/share/native/sun/security/ec/impl/secitem.c ! src/share/native/sun/security/ec/impl/secoidt.h Changeset: fed61c2f4d14 Author: vinnie Date: 2011-02-04 00:33 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fed61c2f4d14 Merge Changeset: 78fe1b7a9a1a Author: vinnie Date: 2011-02-04 09:52 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/78fe1b7a9a1a 7017176: Several JNDI tests are mssing GPL header Reviewed-by: alanb ! test/com/sun/jndi/ldap/LdapName/Case.java ! test/com/sun/jndi/ldap/LdapName/EmptyNameSearch.java ! test/com/sun/jndi/ldap/LdapName/UnescapeTest.java ! test/com/sun/jndi/ldap/ReadTimeoutTest.java Changeset: 9599534b1727 Author: lancea Date: 2011-02-04 09:07 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9599534b1727 7014095: Broken link in java.sql package specification Reviewed-by: alanb ! src/share/classes/java/sql/package.html Changeset: c5f953e920c6 Author: mduigou Date: 2011-02-04 12:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c5f953e920c6 7015783: Update JDK Netbeans projects to -source 1.7 Reviewed-by: darcy ! make/netbeans/common/java-data-native.ent ! make/netbeans/common/java-data-no-native.ent Changeset: b8662dac7c91 Author: sherman Date: 2011-02-04 13:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b8662dac7c91 7005986: (zipfs) ZipPath.startsWith() fails because of the implementation of getName(index) Summary: Updated starsWith/endsWith to be consistent with default file system Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java ! test/demo/zipfs/PathOps.java ! test/demo/zipfs/basic.sh Changeset: a775b8d3fed0 Author: lana Date: 2011-02-04 17:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a775b8d3fed0 Merge - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties Changeset: b0bd638036bd Author: vinnie Date: 2011-02-07 09:11 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b0bd638036bd 7017486: Need synchronized access when flushing the LDAP request queue Reviewed-by: alanb ! src/share/classes/com/sun/jndi/ldap/Connection.java Changeset: f34dcfeecc8d Author: alanb Date: 2011-02-07 13:53 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f34dcfeecc8d 7012823: TEST_BUG: java/nio/MappedByteBuffer tests leave file mappingsthat prevent clean-up (win) Reviewed-by: forax ! test/java/nio/MappedByteBuffer/Force.java ! test/java/nio/MappedByteBuffer/ZeroMap.java Changeset: 32f1c5f67aae Author: alanb Date: 2011-02-07 13:55 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/32f1c5f67aae 7003155: (fs) Paths.get() does not handle escaped octets correctly Reviewed-by: sherman ! src/solaris/classes/sun/nio/fs/UnixUriUtils.java ! test/java/nio/file/Path/UriImportExport.java Changeset: 94bcd9aa2119 Author: chegar Date: 2011-02-07 14:08 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/94bcd9aa2119 7016898: PlainSocketImpl.fd is null on Windows Reviewed-by: alanb ! src/windows/classes/java/net/PlainSocketImpl.java Changeset: f9f321a7502c Author: alanb Date: 2011-02-07 18:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f9f321a7502c 7017454: Residual warnings in sun/nio/** and java/io native code (win64) Reviewed-by: chegar ! src/share/native/java/io/io_util.c ! src/windows/native/java/io/WinNTFileSystem_md.c ! src/windows/native/java/io/canonicalize_md.c ! src/windows/native/java/io/io_util_md.c ! src/windows/native/sun/nio/ch/Iocp.c ! src/windows/native/sun/nio/fs/RegistryFileTypeDetector.c ! src/windows/native/sun/nio/fs/WindowsNativeDispatcher.c Changeset: 08e1914d5852 Author: alanb Date: 2011-02-07 18:02 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/08e1914d5852 Merge Changeset: 947ce00ed7a2 Author: alanb Date: 2011-02-08 15:50 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/947ce00ed7a2 7013585: Dual-pivot quicksort improvements for highly structured (nearly sorted) and data with small periods Reviewed-by: mduigou, alanb Contributed-by: vladimir.yaroslavskiy at oracle.com ! src/share/classes/java/util/DualPivotQuicksort.java ! test/java/util/Arrays/Sorting.java Changeset: 82c8c54ac1d5 Author: alanb Date: 2011-02-08 19:31 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/82c8c54ac1d5 4421494: infinite loop while parsing double literal Reviewed-by: darcy, alanb Contributed-by: dmitry.nadezhin at oracle.com ! src/share/classes/sun/misc/FloatingDecimal.java ! test/java/lang/Double/ParseDouble.java Changeset: 6661a1dfa369 Author: sherman Date: 2011-02-08 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6661a1dfa369 7017840: (zipfs) test/demo/zipfs/basic.sh needs to be updated due to 7013420 Summary: updated try-with-resourcse usage in test/demo code Reviewed-by: alanb ! src/share/demo/nio/zipfs/Demo.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: 1899523d8f24 Author: lana Date: 2011-02-08 14:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1899523d8f24 Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/demo/zipfs - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: cd9a302f2806 Author: chegar Date: 2011-02-09 09:53 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cd9a302f2806 7013961: Threads attached via JNI attach prevent daemon ThreadGroups from being destroyed Reviewed-by: dholmes ! src/share/classes/java/lang/Thread.java ! src/share/classes/java/lang/ThreadGroup.java Changeset: 6a274c4d3e00 Author: alanb Date: 2011-02-09 15:59 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6a274c4d3e00 7018258: Dual-pivot updates in 7013585 can fail with ArrayIndexOutOfBoundsException Reviewed-by: alanb Contributed-by: vladimir.yaroslavskiy at oracle.com ! src/share/classes/java/util/DualPivotQuicksort.java ! test/java/util/Arrays/Sorting.java Changeset: 37563c09305d Author: alanb Date: 2011-02-09 16:30 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/37563c09305d Merge Changeset: a8fcaf5097ec Author: lana Date: 2011-02-09 10:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a8fcaf5097ec Merge Changeset: 9d141e45ee4b Author: lana Date: 2011-02-14 16:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9d141e45ee4b Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/demo/zipfs - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: e4802c87e5c7 Author: herrick Date: 2011-02-09 09:19 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e4802c87e5c7 7016724: Remove sun.jkernel.* classes in JDK 7 Summary: Remove sun.jkernel.* classes in JDK 7 Reviewed-by: ohair, alanb, mchung ! make/modules/modules.config ! make/sun/Makefile - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/util/zip/ZipEntry.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java ! src/share/classes/sun/jvmstat/monitor/MonitoredVmUtil.java ! src/share/classes/sun/misc/BootClassLoaderHook.java ! src/share/classes/sun/tools/attach/HotSpotAttachProvider.java ! src/windows/bin/java_md.c - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc Changeset: dc909d130397 Author: herrick Date: 2011-02-09 09:32 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dc909d130397 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 4f84cda2a7d5 Author: igor Date: 2011-02-09 21:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4f84cda2a7d5 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc Changeset: 802c085308bf Author: igor Date: 2011-02-15 19:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/802c085308bf Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/demo/zipfs - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 7bb09178ffc7 Author: ohair Date: 2011-02-10 20:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7bb09178ffc7 7012644: Regression: jdk/make/common/shared/Defs-windows.gmk has problems on cygwin 7018835: Debug build issues in jdk makefiles Reviewed-by: ksrini ! make/common/shared/Defs-windows.gmk ! make/common/shared/Defs.gmk ! make/common/shared/Platform.gmk Changeset: 9478964f9425 Author: ohair Date: 2011-02-10 20:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9478964f9425 Merge Changeset: 71b52ce5f389 Author: mfang Date: 2011-02-10 20:52 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/71b52ce5f389 7017734: jdk7 message drop 1 translation integration Reviewed-by: ogino, yhuang ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_de.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_es.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_fr.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_it.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ja.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_ko.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_pt_BR.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_sv.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_CN.properties ! src/share/classes/com/sun/accessibility/internal/resources/accessibility_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_de.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_es.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_fr.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_it.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ja.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_ko.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_sv.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_de.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_es.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_fr.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_it.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ja.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_ko.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_sv.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/motif/resources/motif_zh_TW.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_de.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_es.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_fr.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_it.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ja.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_ko.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_pt_BR.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_sv.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_CN.properties ! src/share/classes/com/sun/java/swing/plaf/windows/resources/windows_zh_TW.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_de.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_es.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_fr.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_it.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_ja.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_ko.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_pt_BR.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_sv.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_CN.properties ! src/share/classes/com/sun/rowset/RowSetResourceBundle_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_de.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_es.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_it.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/basic/resources/basic_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_de.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_es.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_it.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/metal/resources/metal_zh_TW.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_de.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_es.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_fr.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_it.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ja.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_ko.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_pt_BR.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_sv.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_CN.properties ! src/share/classes/com/sun/swing/internal/plaf/synth/resources/synth_zh_TW.properties ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_ja.java ! src/share/classes/com/sun/tools/example/debug/tty/TTYResources_zh_CN.java ! src/share/classes/com/sun/tools/jdi/resources/jdi_ja.properties ! src/share/classes/com/sun/tools/jdi/resources/jdi_zh_CN.properties ! src/share/classes/sun/applet/resources/MsgAppletViewer_de.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_es.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_fr.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_it.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_ja.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_ko.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_pt_BR.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_sv.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_CN.java ! src/share/classes/sun/applet/resources/MsgAppletViewer_zh_TW.java ! src/share/classes/sun/awt/resources/awt_de.properties ! src/share/classes/sun/awt/resources/awt_es.properties ! src/share/classes/sun/awt/resources/awt_fr.properties ! src/share/classes/sun/awt/resources/awt_it.properties ! src/share/classes/sun/awt/resources/awt_ja.properties ! src/share/classes/sun/awt/resources/awt_ko.properties ! src/share/classes/sun/awt/resources/awt_pt_BR.properties ! src/share/classes/sun/awt/resources/awt_sv.properties ! src/share/classes/sun/awt/resources/awt_zh_CN.properties ! src/share/classes/sun/awt/resources/awt_zh_TW.properties ! src/share/classes/sun/management/resources/agent_de.properties ! src/share/classes/sun/management/resources/agent_es.properties ! src/share/classes/sun/management/resources/agent_fr.properties ! src/share/classes/sun/management/resources/agent_it.properties ! src/share/classes/sun/management/resources/agent_ja.properties ! src/share/classes/sun/management/resources/agent_ko.properties ! src/share/classes/sun/management/resources/agent_pt_BR.properties ! src/share/classes/sun/management/resources/agent_sv.properties ! src/share/classes/sun/management/resources/agent_zh_CN.properties ! src/share/classes/sun/management/resources/agent_zh_TW.properties ! src/share/classes/sun/misc/resources/Messages_de.java ! src/share/classes/sun/misc/resources/Messages_es.java ! src/share/classes/sun/misc/resources/Messages_fr.java ! src/share/classes/sun/misc/resources/Messages_it.java ! src/share/classes/sun/misc/resources/Messages_ja.java ! src/share/classes/sun/misc/resources/Messages_ko.java ! src/share/classes/sun/misc/resources/Messages_pt_BR.java ! src/share/classes/sun/misc/resources/Messages_sv.java ! src/share/classes/sun/misc/resources/Messages_zh_CN.java ! src/share/classes/sun/misc/resources/Messages_zh_TW.java ! src/share/classes/sun/print/resources/serviceui_de.properties ! src/share/classes/sun/print/resources/serviceui_es.properties ! src/share/classes/sun/print/resources/serviceui_fr.properties ! src/share/classes/sun/print/resources/serviceui_it.properties ! src/share/classes/sun/print/resources/serviceui_ja.properties ! src/share/classes/sun/print/resources/serviceui_ko.properties ! src/share/classes/sun/print/resources/serviceui_pt_BR.properties ! src/share/classes/sun/print/resources/serviceui_sv.properties ! src/share/classes/sun/print/resources/serviceui_zh_CN.properties ! src/share/classes/sun/print/resources/serviceui_zh_TW.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_de.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_es.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_fr.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_it.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_ja.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_ko.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_pt_BR.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_sv.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_zh_CN.properties ! src/share/classes/sun/rmi/registry/resources/rmiregistry_zh_TW.properties ! src/share/classes/sun/rmi/rmic/resources/rmic_ja.properties ! src/share/classes/sun/rmi/rmic/resources/rmic_zh_CN.properties ! src/share/classes/sun/rmi/server/resources/rmid_de.properties ! src/share/classes/sun/rmi/server/resources/rmid_es.properties ! src/share/classes/sun/rmi/server/resources/rmid_fr.properties ! src/share/classes/sun/rmi/server/resources/rmid_it.properties ! src/share/classes/sun/rmi/server/resources/rmid_ja.properties ! src/share/classes/sun/rmi/server/resources/rmid_ko.properties ! src/share/classes/sun/rmi/server/resources/rmid_pt_BR.properties ! src/share/classes/sun/rmi/server/resources/rmid_sv.properties ! src/share/classes/sun/rmi/server/resources/rmid_zh_CN.properties ! src/share/classes/sun/rmi/server/resources/rmid_zh_TW.properties ! src/share/classes/sun/security/tools/JarSignerResources_ja.java ! src/share/classes/sun/security/tools/JarSignerResources_zh_CN.java ! src/share/classes/sun/security/util/AuthResources_de.java ! src/share/classes/sun/security/util/AuthResources_es.java ! src/share/classes/sun/security/util/AuthResources_fr.java ! src/share/classes/sun/security/util/AuthResources_it.java ! src/share/classes/sun/security/util/AuthResources_ja.java ! src/share/classes/sun/security/util/AuthResources_ko.java ! src/share/classes/sun/security/util/AuthResources_pt_BR.java ! src/share/classes/sun/security/util/AuthResources_sv.java ! src/share/classes/sun/security/util/AuthResources_zh_CN.java ! src/share/classes/sun/security/util/AuthResources_zh_TW.java ! src/share/classes/sun/security/util/Resources_de.java ! src/share/classes/sun/security/util/Resources_es.java ! src/share/classes/sun/security/util/Resources_fr.java ! src/share/classes/sun/security/util/Resources_it.java ! src/share/classes/sun/security/util/Resources_ja.java ! src/share/classes/sun/security/util/Resources_ko.java ! src/share/classes/sun/security/util/Resources_pt_BR.java ! src/share/classes/sun/security/util/Resources_sv.java ! src/share/classes/sun/security/util/Resources_zh_CN.java ! src/share/classes/sun/security/util/Resources_zh_TW.java ! src/share/classes/sun/tools/jar/resources/jar_de.properties ! src/share/classes/sun/tools/jar/resources/jar_es.properties ! src/share/classes/sun/tools/jar/resources/jar_fr.properties ! src/share/classes/sun/tools/jar/resources/jar_it.properties ! src/share/classes/sun/tools/jar/resources/jar_ja.properties ! src/share/classes/sun/tools/jar/resources/jar_ko.properties ! src/share/classes/sun/tools/jar/resources/jar_pt_BR.properties ! src/share/classes/sun/tools/jar/resources/jar_sv.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_CN.properties ! src/share/classes/sun/tools/jar/resources/jar_zh_TW.properties ! src/share/classes/sun/tools/javac/resources/javac_ja.properties ! src/share/classes/sun/tools/javac/resources/javac_zh_CN.properties ! src/share/classes/sun/tools/jconsole/resources/JConsoleResources_ja.java ! src/share/classes/sun/tools/jconsole/resources/JConsoleResources_zh_CN.java ! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_ja.java ! src/share/classes/sun/tools/native2ascii/resources/MsgNative2ascii_zh_CN.java ! src/share/classes/sun/tools/serialver/serialver_ja.properties ! src/share/classes/sun/tools/serialver/serialver_zh_CN.properties ! src/share/classes/sun/util/logging/resources/logging_de.properties ! src/share/classes/sun/util/logging/resources/logging_es.properties ! src/share/classes/sun/util/logging/resources/logging_fr.properties ! src/share/classes/sun/util/logging/resources/logging_it.properties ! src/share/classes/sun/util/logging/resources/logging_ja.properties ! src/share/classes/sun/util/logging/resources/logging_ko.properties ! src/share/classes/sun/util/logging/resources/logging_pt_BR.properties ! src/share/classes/sun/util/logging/resources/logging_sv.properties ! src/share/classes/sun/util/logging/resources/logging_zh_CN.properties ! src/share/classes/sun/util/logging/resources/logging_zh_TW.properties ! src/share/demo/jfc/CodePointIM/resources/codepoint_ja.properties ! src/share/demo/jfc/CodePointIM/resources/codepoint_zh_CN.properties ! src/share/demo/jfc/Font2DTest/resources/TextResources_ja.properties ! src/share/demo/jfc/Font2DTest/resources/TextResources_zh_CN.properties ! src/share/demo/jfc/Notepad/resources/Notepad_ja.properties ! src/share/demo/jfc/Notepad/resources/Notepad_zh_CN.properties ! src/windows/classes/sun/awt/windows/awtLocalization_es.properties ! src/windows/classes/sun/awt/windows/awtLocalization_ja.properties ! src/windows/classes/sun/awt/windows/awtLocalization_ko.properties ! src/windows/classes/sun/awt/windows/awtLocalization_pt_BR.properties ! src/windows/classes/sun/awt/windows/awtLocalization_zh_CN.properties ! src/windows/classes/sun/awt/windows/awtLocalization_zh_TW.properties ! src/windows/native/sun/jkernel/kernel_de.rc ! src/windows/native/sun/jkernel/kernel_es.rc ! src/windows/native/sun/jkernel/kernel_fr.rc ! src/windows/native/sun/jkernel/kernel_it.rc ! src/windows/native/sun/jkernel/kernel_ja.rc ! src/windows/native/sun/jkernel/kernel_ko.rc ! src/windows/native/sun/jkernel/kernel_pt_BR.rc ! src/windows/native/sun/jkernel/kernel_sv.rc ! src/windows/native/sun/jkernel/kernel_zh.rc ! src/windows/native/sun/jkernel/kernel_zh_TW.rc Changeset: 8b6d1d96ef3d Author: mfang Date: 2011-02-11 22:57 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8b6d1d96ef3d Merge Changeset: 0eacbbc8e1fb Author: mfang Date: 2011-02-11 23:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0eacbbc8e1fb Merge Changeset: 780e53ad2896 Author: mfang Date: 2011-02-14 13:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/780e53ad2896 Merge Changeset: 5fab973e5a47 Author: ohair Date: 2011-02-15 12:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5fab973e5a47 Merge Changeset: bdc069d3f910 Author: ohair Date: 2011-02-15 20:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bdc069d3f910 Merge Changeset: 89055b6d9ae0 Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/89055b6d9ae0 Added tag jdk7-b130 for changeset bdc069d3f910 ! .hgtags Changeset: 0355c60c2da4 Author: ohair Date: 2011-02-16 13:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0355c60c2da4 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 9b2631288894 Author: ohair Date: 2011-02-16 14:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9b2631288894 7010594: Add /SAFESEH to links on windows to verify safe exceptions Reviewed-by: alanb ! make/common/Defs-windows.gmk ! make/common/shared/Defs-windows.gmk Changeset: 5e09deee1967 Author: andrew Date: 2011-02-23 17:10 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5e09deee1967 7021314: Build should not install javaws man page Summary: Only install javaws.1 when not building OpenJDK Reviewed-by: alanb, ohair ! make/common/Release.gmk Changeset: 8ac52c85f9e9 Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8ac52c85f9e9 Merge Changeset: 11c9a066a5a4 Author: cl Date: 2011-02-24 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/11c9a066a5a4 Added tag jdk7-b131 for changeset 8ac52c85f9e9 ! .hgtags Changeset: d7de46ec011b Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d7de46ec011b 7013417: JSR 292 needs to support variadic method handle calls Summary: Implement MH.asVarargsCollector, etc., and remove withTypeHandler. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodTypeImpl.java ! test/java/dyn/InvokeDynamicPrintArgs.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java ! test/java/dyn/indify/Indify.java Changeset: c86c60ad8822 Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c86c60ad8822 7012650: implement JSR 292 EG adjustments through January 2010 Summary: misc. EG changes and polishes (excluding 7013417) Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/ClassValue.java ! src/share/classes/java/dyn/ConstantCallSite.java ! src/share/classes/java/dyn/InvokeDynamicBootstrapError.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodHandle.java ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/MethodType.java ! src/share/classes/java/dyn/MutableCallSite.java + src/share/classes/java/dyn/SwitchPoint.java - src/share/classes/java/dyn/Switcher.java ! src/share/classes/java/dyn/VolatileCallSite.java ! src/share/classes/java/dyn/WrongMethodTypeException.java ! src/share/classes/java/dyn/package-info.java ! src/share/classes/sun/dyn/AdapterMethodHandle.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/ToGeneric.java + src/share/classes/sun/dyn/WrapperInstance.java ! test/java/dyn/InvokeGenericTest.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java Changeset: a2241b109aa1 Author: jrose Date: 2011-02-11 01:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a2241b109aa1 7013730: JSR 292 reflective operations should report errors with standard exception types Summary: remove NoAccessException, replace it by ReflectiveOperationException subtypes; adjust javadoc of exceptions Reviewed-by: twisti ! src/share/classes/java/dyn/CallSite.java ! src/share/classes/java/dyn/Linkage.java ! src/share/classes/java/dyn/MethodHandles.java - src/share/classes/java/dyn/NoAccessException.java ! src/share/classes/sun/dyn/CallSiteImpl.java ! src/share/classes/sun/dyn/FilterGeneric.java ! src/share/classes/sun/dyn/FilterOneArgument.java ! src/share/classes/sun/dyn/FromGeneric.java ! src/share/classes/sun/dyn/InvokeGeneric.java ! src/share/classes/sun/dyn/Invokers.java ! src/share/classes/sun/dyn/MemberName.java ! src/share/classes/sun/dyn/MethodHandleImpl.java ! src/share/classes/sun/dyn/MethodHandleNatives.java ! src/share/classes/sun/dyn/SpreadGeneric.java ! src/share/classes/sun/dyn/ToGeneric.java ! src/share/classes/sun/dyn/util/ValueConversions.java ! src/share/classes/sun/dyn/util/VerifyAccess.java ! test/java/dyn/InvokeGenericTest.java ! test/java/dyn/JavaDocExamplesTest.java ! test/java/dyn/MethodHandlesTest.java Changeset: 5e4a41d0fccd Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5e4a41d0fccd 7016261: JSR 292 MethodType objects should be serializable Summary: Define private writeObject, readObject, and readResolve methods. Also add unit tests. Reviewed-by: twisti ! src/share/classes/java/dyn/MethodType.java + test/java/dyn/MethodTypeTest.java Changeset: 56cbd0504a53 Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/56cbd0504a53 7014755: JSR 292 member lookup interaction with security manager Summary: add security manager interactions for Lookup methods Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandles.java ! src/share/classes/java/dyn/package-info.java Changeset: 52bcd47b4521 Author: jrose Date: 2011-02-15 00:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/52bcd47b4521 7016520: JSR 292 rules for polymorphic signature processing must be in package-info Summary: insert rules for bytecode processors to recognize signature polymorphic names Reviewed-by: twisti ! src/share/classes/java/dyn/MethodHandle.java Changeset: f6cd84cfed70 Author: trims Date: 2011-02-25 12:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f6cd84cfed70 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java Changeset: 7905b047a475 Author: prr Date: 2011-02-08 14:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7905b047a475 7006865: Regression: Corrupted output when printing images with bit depth of 4 Reviewed-by: bae, jgodinez ! src/windows/classes/sun/awt/windows/WPathGraphics.java ! src/windows/classes/sun/awt/windows/WPrinterJob.java + test/java/awt/print/PrinterJob/ImagePrinting/ImageTypes.java Changeset: d42ce0b309ae Author: bae Date: 2011-02-09 22:24 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d42ce0b309ae 6818960: ImageFetcher ( MediaTracker) Thread leak Reviewed-by: igor, prr ! src/share/classes/sun/awt/image/ImageFetcher.java ! src/share/classes/sun/awt/image/InputStreamImageSource.java Changeset: 37d20456c54c Author: ceisserer Date: 2011-02-09 14:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/37d20456c54c 7018387: Xrender pipeline may leak GC's Reviewed-by: prr ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java Changeset: bcf663c292ef Author: bae Date: 2011-02-10 13:44 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bcf663c292ef 6989774: imageio compiler warnings in native code Reviewed-by: igor, prr ! make/sun/jpeg/Makefile ! make/sun/jpeg/reorder-i586 ! make/sun/jpeg/reorder-sparc ! make/sun/jpeg/reorder-sparcv9 ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c ! src/share/native/sun/awt/image/jpeg/jdmarker.c ! src/share/native/sun/awt/image/jpeg/jmemmgr.c ! src/share/native/sun/awt/image/jpeg/jmemnobs.c ! src/share/native/sun/awt/image/jpeg/jmemsys.h ! src/share/native/sun/awt/image/jpeg/jpegdecoder.c ! src/share/native/sun/awt/image/jpeg/jpeglib.h Changeset: 1881764c4cdf Author: prr Date: 2011-02-11 10:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1881764c4cdf 7018364: XShmGetImage with image's > drawable's size causes BadMatch Reviewed-by: art, anthony Contributed-by: linuxhippy at gmail.com ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/java2d/x11/X11SurfaceData.h Changeset: b04dafeda706 Author: prr Date: 2011-02-16 15:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b04dafeda706 7019441: No lookup cache for internal composite font creation leads to java heap growth Reviewed-by: igor, jgodinez ! src/share/classes/sun/font/FontUtilities.java Changeset: e45f7d50dbc9 Author: bae Date: 2011-02-17 13:42 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e45f7d50dbc9 7018912: [parfait] potential buffer overruns in imageio jpeg Reviewed-by: jgodinez, prr ! src/share/native/sun/awt/image/jpeg/imageioJPEG.c Changeset: 810445ab3099 Author: prr Date: 2011-02-18 09:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/810445ab3099 6857592: Getting warning while moving or resizing the frame when component.printAll() is called on local JNI Reviewed-by: bae, flar ! src/windows/native/sun/java2d/windows/GDIBlitLoops.cpp Changeset: 5d8cfcb9a4e8 Author: prr Date: 2011-02-18 09:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5d8cfcb9a4e8 7017637: closed/java/awt/font/StyledMetrics/BoldSpace.java failed : Space char should have 0 advance Reviewed-by: igor, jgodinez + test/java/awt/font/StyledMetrics/BoldSpace.java Changeset: 4c6500d20ebf Author: jgodinez Date: 2011-02-04 11:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4c6500d20ebf 7014796: Regression test java/awt/PrintJob/Text/stringwidth.sh cannot be terminated on Windows. Reviewed-by: prr ! test/java/awt/PrintJob/Text/StringWidth.java Changeset: 33cd780e8989 Author: jgodinez Date: 2011-02-04 11:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/33cd780e8989 6995147: Case needs to be update. ServiceDialogTest.java failed as compilation error. Reviewed-by: prr ! test/javax/print/attribute/ServiceDialogTest.java Changeset: 1d3f3c8d7ed5 Author: jgodinez Date: 2011-02-18 11:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1d3f3c8d7ed5 6722351: sun.print.Win32PrintService.initMedia() is slow Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: 059b56058cad Author: jgodinez Date: 2011-02-18 12:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/059b56058cad Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 1acdde062e92 Author: jgodinez Date: 2011-02-18 13:47 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1acdde062e92 6850806: NPE exception throws in PrintServce.getSupportedAttributeValues Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: fa6547fa57e6 Author: lana Date: 2011-02-21 14:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fa6547fa57e6 Merge Changeset: 5a6bd7df28b8 Author: lana Date: 2011-02-11 15:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5a6bd7df28b8 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 14d9e6af8889 Author: andrew Date: 2011-02-15 15:09 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/14d9e6af8889 7017581: missing copyright header in test/sun/java2d/pipe/RegionOps.java Reviewed-by: anthony ! test/sun/java2d/pipe/RegionOps.java Changeset: 7c98b6b4e8a7 Author: dav Date: 2011-02-16 01:12 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7c98b6b4e8a7 6994933: java.awt.Desktop feature is "intermittently" supported on Solaris. Really unexpected behavior. Reviewed-by: art, dcherepanov ! src/solaris/classes/sun/awt/X11/XDesktopPeer.java ! src/solaris/native/sun/xawt/awt_Desktop.c Changeset: 41da8f9ea83a Author: lana Date: 2011-02-21 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/41da8f9ea83a Merge Changeset: eeaad0d340b2 Author: peytoia Date: 2011-02-09 18:00 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/eeaad0d340b2 7017800: (tz) Support tzdata2011b Reviewed-by: okutsu ! make/sun/javazic/tzdata/VERSION ! make/sun/javazic/tzdata/australasia ! make/sun/javazic/tzdata/northamerica ! make/sun/javazic/tzdata/zone.tab ! src/share/classes/sun/util/resources/TimeZoneNames.java ! src/share/classes/sun/util/resources/TimeZoneNames_de.java ! src/share/classes/sun/util/resources/TimeZoneNames_es.java ! src/share/classes/sun/util/resources/TimeZoneNames_fr.java ! src/share/classes/sun/util/resources/TimeZoneNames_it.java ! src/share/classes/sun/util/resources/TimeZoneNames_ja.java ! src/share/classes/sun/util/resources/TimeZoneNames_ko.java ! src/share/classes/sun/util/resources/TimeZoneNames_pt_BR.java ! src/share/classes/sun/util/resources/TimeZoneNames_sv.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_CN.java ! src/share/classes/sun/util/resources/TimeZoneNames_zh_TW.java Changeset: 493a9eeb9bca Author: alexp Date: 2011-02-10 21:36 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/493a9eeb9bca 6993171: JavaTest/JDK7b114 - no help text is shown for interview questions, JavaTest HANGS UP Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java ! src/share/classes/javax/swing/JLayer.java ! src/share/classes/javax/swing/RepaintManager.java ! src/share/classes/javax/swing/SwingUtilities.java ! src/share/classes/javax/swing/plaf/LayerUI.java ! test/javax/swing/JComponent/6989617/bug6989617.java Changeset: be8045e2d792 Author: lana Date: 2011-02-11 12:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/be8045e2d792 Merge - make/java/hpi/Makefile - make/java/hpi/hpi_common.gmk - make/java/hpi/native/Makefile - make/java/hpi/native/mapfile-vers - make/java/hpi/native/reorder-i586 - make/java/hpi/native/reorder-sparc - make/java/hpi/native/reorder-sparcv9 - make/java/hpi/windows/Makefile - src/share/hpi/export/bool.h - src/share/hpi/export/dll.h - src/share/hpi/export/hpi.h - src/share/hpi/include/hpi_impl.h - src/share/hpi/include/vm_calls.h - src/share/hpi/src/hpi.c - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.8.properties - src/solaris/classes/sun/awt/fontconfigs/solaris.fontconfig.5.9.properties - src/solaris/hpi/export/byteorder_md.h - src/solaris/hpi/export/hpi_md.h - src/solaris/hpi/export/io_md.h - src/solaris/hpi/export/path_md.h - src/solaris/hpi/export/timeval_md.h - src/solaris/hpi/include/hpi_init.h - src/solaris/hpi/include/interrupt.h - src/solaris/hpi/include/largefile.h - src/solaris/hpi/include/largefile_linux.h - src/solaris/hpi/include/largefile_solaris.h - src/solaris/hpi/native_threads/include/condvar_md.h - src/solaris/hpi/native_threads/include/monitor_md.h - src/solaris/hpi/native_threads/include/mutex_md.h - src/solaris/hpi/native_threads/include/np.h - src/solaris/hpi/native_threads/include/porting.h - src/solaris/hpi/native_threads/include/threads_md.h - src/solaris/hpi/native_threads/src/condvar_md.c - src/solaris/hpi/native_threads/src/interrupt_md.c - src/solaris/hpi/native_threads/src/monitor_md.c - src/solaris/hpi/native_threads/src/mutex_md.c - src/solaris/hpi/native_threads/src/sys_api_td.c - src/solaris/hpi/native_threads/src/threads_linux.c - src/solaris/hpi/native_threads/src/threads_md.c - src/solaris/hpi/native_threads/src/threads_solaris.c - src/solaris/hpi/src/interrupt.c - src/solaris/hpi/src/linker_md.c - src/solaris/hpi/src/memory_md.c - src/solaris/hpi/src/system_md.c - src/windows/hpi/export/byteorder_md.h - src/windows/hpi/export/hpi_md.h - src/windows/hpi/export/io_md.h - src/windows/hpi/export/path_md.h - src/windows/hpi/export/timeval_md.h - src/windows/hpi/include/monitor_md.h - src/windows/hpi/include/mutex_md.h - src/windows/hpi/include/threads_md.h - src/windows/hpi/src/linker_md.c - src/windows/hpi/src/memory_md.c - src/windows/hpi/src/monitor_md.c - src/windows/hpi/src/path_md.c - src/windows/hpi/src/socket_md.c - src/windows/hpi/src/sys_api_md.c - src/windows/hpi/src/system_md.c - src/windows/hpi/src/threads_md.c - test/java/net/InetAddress/B4762344.java - test/java/net/InetAddress/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/java/net/InetAddress/Simple1NameServiceDescriptor.java - test/java/net/InetAddress/Simple2NameServiceDescriptor.java - test/java/net/InetAddress/SimpleNameService.java - test/sun/net/InetAddress/nameservice/B6442088.java - test/sun/net/InetAddress/nameservice/CacheTest.java - test/sun/net/InetAddress/nameservice/META-INF/services/sun.net.spi.nameservice.NameServiceDescriptor - test/sun/net/InetAddress/nameservice/SimpleNameService.java - test/sun/net/InetAddress/nameservice/SimpleNameServiceDescriptor.java Changeset: 82f7b8f6b174 Author: alexp Date: 2011-02-15 16:40 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/82f7b8f6b174 6956842: BasicTreeUI.getPreferredSize(JComp c) is delegated to getPreferredSize(c, true) not (c, false) Reviewed-by: rupashka ! src/share/classes/javax/swing/plaf/basic/BasicTreeUI.java Changeset: be44bda15fcf Author: okutsu Date: 2011-02-16 16:51 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/be44bda15fcf 6936350: API clarification needed on useDaylightTime() for timezones that have defined usage dates Reviewed-by: peytoia ! src/share/classes/java/util/SimpleTimeZone.java ! src/share/classes/java/util/TimeZone.java + test/java/util/TimeZone/DaylightTimeTest.java Changeset: f326139e7fda Author: malenkov Date: 2011-02-16 18:32 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f326139e7fda 6980124: closed/javax/swing/plaf/synth/SynthPainter/unitTest/UnitTest.java fails Reviewed-by: alexp ! src/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java Changeset: 888baed5c55b Author: rupashka Date: 2011-02-18 00:16 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/888baed5c55b 7016693: javax/swing/JScrollBar/6542335/bug6542335.java failed on Ubuntu Reviewed-by: alexp ! test/javax/swing/JScrollBar/6542335/bug6542335.java Changeset: db0a6fd0fea9 Author: amenkov Date: 2011-02-18 13:21 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/db0a6fd0fea9 6801236: test closed/javax/sound/sampled/FileWriter/WaveBigEndian.java fails Reviewed-by: alexp ! src/share/classes/com/sun/media/sound/services/javax.sound.sampled.spi.FormatConversionProvider Changeset: 64b4226f171f Author: amenkov Date: 2011-02-18 13:27 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/64b4226f171f 7000132: Misplaced description in javax.sound.sampled.AudioSystem.getTargetDataLine Reviewed-by: dav ! src/share/classes/javax/sound/sampled/AudioSystem.java Changeset: a93bb05d00fd Author: alexp Date: 2011-02-18 19:21 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a93bb05d00fd 6474153: LookAndFeel.makeKeyBindings(...) doesn't ignore last element in keyBindingList with odd size Reviewed-by: rupashka ! src/share/classes/javax/swing/LookAndFeel.java + test/javax/swing/LookAndFeel/6474153/bug6474153.java Changeset: 3772a3d90b40 Author: rupashka Date: 2011-02-18 20:09 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3772a3d90b40 6997102: Test case has hard code, so that applet thread threw exception Reviewed-by: alexp ! test/javax/swing/JFileChooser/6798062/bug6798062.html ! test/javax/swing/JFileChooser/6798062/bug6798062.java Changeset: 2cc71008b6db Author: lana Date: 2011-02-21 14:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2cc71008b6db Merge ! src/share/classes/javax/swing/JComponent.java Changeset: cfd397d86474 Author: sundar Date: 2011-02-11 10:38 +0530 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/cfd397d86474 6604827: JavaDoc for ScriptEngineFactory.getMethodCallSyntax contains an error. Reviewed-by: mchung ! src/share/classes/javax/script/ScriptEngineFactory.java Changeset: 05a0271173a6 Author: ohair Date: 2011-02-10 20:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/05a0271173a6 Merge - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/demo/zipfs - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 1dc0c3021d13 Author: ohair Date: 2011-02-11 01:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1dc0c3021d13 Merge Changeset: 8711aedb08f2 Author: sherman Date: 2011-02-11 12:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8711aedb08f2 7007596: (zipfs) FileSystems.newFileSystem(FileRef...) always employs zipfs regardless the real Path type. Summary: updated newFileSystem() to throw UOE exception for non-zip/jar file Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystemProvider.java ! test/demo/zipfs/ZipFSTester.java ! test/demo/zipfs/basic.sh Changeset: 8860e17db3bd Author: weijun Date: 2011-02-12 05:09 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8860e17db3bd 6742654: Code insertion/replacement attacks against signed jars 6911041: JCK api/signaturetest tests fails for Mixed Code PIT builds (b91) for all trains 6921823: JarVerifier csdomain field not initialized 6921839: Update trusted.libraries list Reviewed-by: dgu ! make/java/security/Makefile ! src/share/classes/java/util/jar/JarFile.java ! src/share/classes/java/util/jar/JarVerifier.java ! src/share/classes/java/util/jar/JavaUtilJarAccessImpl.java ! src/share/classes/sun/misc/JarIndex.java ! src/share/classes/sun/misc/JavaUtilJarAccess.java ! src/share/classes/sun/security/util/SignatureFileVerifier.java Changeset: de923c0ec3c4 Author: weijun Date: 2011-02-12 07:30 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/de923c0ec3c4 7016698: test sun/security/krb5/runNameEquals.sh failed on Ubuntu Reviewed-by: valeriep ! src/share/classes/sun/security/jgss/wrapper/SunNativeProvider.java Changeset: 21a1e86dedc2 Author: sherman Date: 2011-02-11 17:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/21a1e86dedc2 6996192: Console.readPassword race: input echo off must be prior to writing prompt Summary: To turn off echo before prompt Reviewed-by: alanb ! src/share/classes/java/io/Console.java Changeset: b04e86b3e27e Author: dcubed Date: 2011-02-14 09:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b04e86b3e27e 6637230: 2/3 jps doesn't work for application waiting for direct attach Summary: Properly handle exceptions thrown when querying a monitored VM. Reviewed-by: dsamersoff, swamyv ! src/share/classes/sun/tools/jps/Jps.java Changeset: fefc740bff52 Author: alanb Date: 2011-02-14 18:30 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fefc740bff52 7016704: TEST_BUG: java/nio/file/Files/walk_file_tree.sh fails with new version of find (lnx) Reviewed-by: forax ! test/java/nio/file/Files/walkFileTree/PrintFileTree.java Changeset: 28037efa90a3 Author: mduigou Date: 2011-02-14 10:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/28037efa90a3 6934356: Vector.writeObject() serialization may deadlock Summary: No longer synchronize on self while writing other objects. Reviewed-by: alanb, forax, mduigou, peterjones Contributed-by: Neil Richards ! src/share/classes/java/util/Vector.java + test/java/util/Vector/SerializationDeadlock.java + test/java/util/Vector/SimpleSerialization.java Changeset: 2633daa325ed Author: mduigou Date: 2011-02-14 10:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2633daa325ed Merge Changeset: 338c5b815ff2 Author: mduigou Date: 2011-02-14 11:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/338c5b815ff2 6927486: Hashtable writeObject() may deadlock Summary: Do not synchronize on self while writing hash table elements Reviewed-by: alanb, mduigou Contributed-by: Neil Richards ! src/share/classes/java/util/Hashtable.java + test/java/util/Hashtable/SerializationDeadlock.java + test/java/util/Hashtable/SimpleSerialization.java Changeset: 44c99f30f9df Author: xuelei Date: 2011-02-14 13:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/44c99f30f9df 7018897: CertPath validation cannot handle self-signed cert with bad KeyUsage Summary: Remove KeyUsage checking for trust anchors Reviewed-by: mullan ! src/share/classes/sun/security/provider/certpath/PKIXCertPathValidator.java Changeset: 9024288330c4 Author: weijun Date: 2011-02-15 12:11 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9024288330c4 7018928: test failure: sun/security/krb5/auto/SSL.java Reviewed-by: valeriep ! test/sun/security/krb5/auto/BadKdc1.java ! test/sun/security/krb5/auto/BadKdc2.java ! test/sun/security/krb5/auto/BadKdc3.java ! test/sun/security/krb5/auto/BadKdc4.java ! test/sun/security/krb5/auto/CleanState.java ! test/sun/security/krb5/auto/CrossRealm.java ! test/sun/security/krb5/auto/HttpNegotiateServer.java ! test/sun/security/krb5/auto/IgnoreChannelBinding.java ! test/sun/security/krb5/auto/KerberosHashEqualsTest.java ! test/sun/security/krb5/auto/LifeTimeInSeconds.java ! test/sun/security/krb5/auto/LoginModuleOptions.java ! test/sun/security/krb5/auto/MaxRetries.java ! test/sun/security/krb5/auto/MoreKvno.java ! test/sun/security/krb5/auto/NewSalt.java ! test/sun/security/krb5/auto/NonMutualSpnego.java ! test/sun/security/krb5/auto/SSL.java ! test/sun/security/krb5/auto/SpnegoReqFlags.java ! test/sun/security/krb5/auto/Test5653.java Changeset: b578c9ccfb01 Author: lana Date: 2011-02-15 08:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b578c9ccfb01 Merge Changeset: afa89f8ab9c8 Author: chegar Date: 2011-02-16 12:38 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/afa89f8ab9c8 6562203: Thread doesn't terminate immediately if it was stopped before start Reviewed-by: dholmes, alanb ! src/share/classes/java/lang/Thread.java - test/java/lang/Thread/StopBeforeStart.java Changeset: dbc74475822f Author: sherman Date: 2011-02-16 11:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dbc74475822f 6999337: java.exe fails to start if some directory names in path to java binaries contain Russian characters Summary: updated to make sure the system properties are accessable by vm during initialization Reviewed-by: alanb, mchung ! src/share/classes/java/lang/System.java Changeset: 6e33b377aa6e Author: smarks Date: 2011-02-16 18:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6e33b377aa6e 7018392: update URLJarFile.java to use try-with-resources Reviewed-by: alanb, chegar, hawtin ! src/share/classes/sun/net/www/protocol/jar/URLJarFile.java Changeset: 15ef6cf616d6 Author: chegar Date: 2011-02-17 09:56 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/15ef6cf616d6 7017901: OOME in java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java Summary: Unbounded queues should be disabled in the test Reviewed-by: alanb ! test/java/util/concurrent/BlockingQueue/CancelledProducerConsumerLoops.java Changeset: 302877469037 Author: alanb Date: 2011-02-17 20:50 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/302877469037 6526860: (fc) FileChannel.position returns 0 when FileOutputStream opened in append mode Reviewed-by: forax ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/solaris/classes/sun/nio/fs/UnixChannelFactory.java ! test/java/nio/channels/FileChannel/Position.java Changeset: a5861eb81f3c Author: alanb Date: 2011-02-17 20:53 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a5861eb81f3c Merge Changeset: dd143033cef1 Author: sundar Date: 2011-02-18 12:07 +0530 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dd143033cef1 7018459: javax.script code comments have issues with HTML4 validation and Accessibility compliance Reviewed-by: jjh ! src/share/classes/javax/script/ScriptEngineFactory.java Changeset: 5bf920749b97 Author: smarks Date: 2011-02-18 12:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5bf920749b97 7018385: update javax.sql classes to use try-with-resources Reviewed-by: alanb, lancea, darcy ! src/share/classes/javax/sql/rowset/serial/SerialClob.java ! src/share/classes/javax/sql/rowset/spi/SyncFactory.java Changeset: 42e4205db024 Author: mduigou Date: 2011-02-21 13:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/42e4205db024 7001685: Renable EnumSetBash Test Reviewed-by: alanb, ohair, darcy ! test/ProblemList.txt Changeset: 3ebece41badd Author: lana Date: 2011-02-21 14:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3ebece41badd Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: f046a44e92fd Author: jgodinez Date: 2011-02-24 15:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f046a44e92fd 7022228: JPRT failure: RuntimeException in SupportedMedia regression test Reviewed-by: igor, prr ! src/windows/classes/sun/print/Win32PrintService.java Changeset: 094c70388ab0 Author: lana Date: 2011-02-24 18:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/094c70388ab0 Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: 6bbc7a473495 Author: lana Date: 2011-03-01 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6bbc7a473495 Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: b88e4395c437 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b88e4395c437 Added tag jdk7-b132 for changeset 6bbc7a473495 ! .hgtags From john.coomes at oracle.com Fri Mar 4 01:21:00 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 04 Mar 2011 09:21:00 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 23 new changesets Message-ID: <20110304092143.3077547C9C@hg.openjdk.java.net> Changeset: 162b62460264 Author: dholmes Date: 2011-02-24 21:38 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/162b62460264 7021953: Remove flags from globals.hpp inadvertently dragged in by 7016023 Summary: removed erroneous flags Reviewed-by: kvn, dcubed ! src/share/vm/runtime/globals.hpp Changeset: cf16c93393f5 Author: rottenha Date: 2011-02-25 03:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/cf16c93393f5 Merge ! src/share/vm/runtime/globals.hpp Changeset: 76b97f73ee91 Author: tonyp Date: 2011-02-25 08:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/76b97f73ee91 Merge Changeset: 0a2ecf4cc384 Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0a2ecf4cc384 Added tag jdk7-b130 for changeset e9aa2ca89ad6 ! .hgtags Changeset: cdef89d821bd Author: ohair Date: 2011-02-16 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/cdef89d821bd 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 0aa3b4908911 Author: cl Date: 2011-02-23 15:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0aa3b4908911 Merge Changeset: 2015d9b41531 Author: cl Date: 2011-02-24 15:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/2015d9b41531 Added tag jdk7-b131 for changeset 0aa3b4908911 ! .hgtags Changeset: f3e07ceeaed9 Author: trims Date: 2011-02-25 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f3e07ceeaed9 Added tag hs21-b02 for changeset e9aa2ca89ad6 ! .hgtags Changeset: 5a4223160326 Author: trims Date: 2011-02-25 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5a4223160326 Merge - make/windows/platform_amd64 - make/windows/platform_i486 - make/windows/platform_ia64 - src/share/tools/ProjectCreator/Macro.java - src/share/tools/ProjectCreator/MacroDefinitions.java Changeset: 658d198b2e04 Author: trims Date: 2011-02-25 12:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/658d198b2e04 7022570: Bump the HS21 build number to 03 Summary: Update the HS21 build number to 03 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 7dc5384467e0 Author: coleenp Date: 2011-02-12 10:28 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/7dc5384467e0 7022659: errorHandler doesn't compile without precompiled headers Summary: add proper includes in errorHandler.hpp Reviewed-by: phh, kamg ! src/share/vm/utilities/errorReporter.hpp Changeset: 0e531ab5ba04 Author: trims Date: 2011-03-01 11:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0e531ab5ba04 Merge Changeset: f91db74a6810 Author: kamg Date: 2011-02-26 13:33 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f91db74a6810 7017640: Fix for 6766644 deadlocks on some NSK tests when running with -Xcomp Summary: Dynamic-code generated events should be deferred and processed by service thread Reviewed-by: dsamersoff, dcubed ! src/share/vm/prims/jvmtiExport.cpp ! src/share/vm/prims/jvmtiExport.hpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp Changeset: da091bb67459 Author: sla Date: 2011-02-28 14:19 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/da091bb67459 7022037: Pause when exiting if debugger is attached on windows Reviewed-by: dsamersoff, kamg, hosterda ! src/os/linux/vm/os_linux.cpp ! src/os/posix/vm/os_posix.cpp ! src/os/solaris/vm/os_solaris.cpp ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/utilities/vmError.cpp Changeset: c1a6154012c8 Author: kamg Date: 2011-02-28 16:01 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c1a6154012c8 7020118: Alter frame assignability to allow for exception handler coverage of invokespecial Summary: Add special rule to allow assignment of frames with uninit flags set. Reviewed-by: never, coleenp ! src/share/vm/classfile/stackMapFrame.cpp ! src/share/vm/classfile/stackMapFrame.hpp ! src/share/vm/classfile/verificationType.hpp Changeset: 23ae54207126 Author: rottenha Date: 2011-02-28 15:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/23ae54207126 Merge ! src/os/solaris/vm/os_solaris.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/java.cpp ! src/share/vm/runtime/os.hpp Changeset: cef8c988e7b8 Author: rottenha Date: 2011-02-28 22:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/cef8c988e7b8 Merge Changeset: 5584e20db481 Author: sla Date: 2011-03-02 09:41 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5584e20db481 7023323: Build failure on VS2003: IsDebuggerPresent not found Summary: #define _WIN32_WINNT 0x500 Reviewed-by: ohrstrom, hosterda, coleenp ! src/os/windows/vm/os_windows.cpp Changeset: 4a9604cd7c5f Author: kamg Date: 2011-03-02 08:18 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/4a9604cd7c5f 6878713: Verifier heap corruption, relating to backward jsrs Summary: Added overflow detection in arena Amalloc methods Reviewed-by: coleenp, phh ! src/share/vm/memory/allocation.cpp ! src/share/vm/memory/allocation.hpp ! src/share/vm/utilities/globalDefinitions_gcc.hpp ! src/share/vm/utilities/globalDefinitions_sparcWorks.hpp ! src/share/vm/utilities/globalDefinitions_visCPP.hpp + test/runtime/6878713/Test6878713.sh + test/runtime/6878713/testcase.jar Changeset: 99bd05619fa4 Author: zgu Date: 2011-03-02 09:16 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/99bd05619fa4 7017110: Add /SAFESEH to links on windows 32bit to verify safe exceptions Summary: Ensure safe exception handler table is generated on Win32 binaries when compile with VS2010 Reviewed-by: acorn, coleenp, dcubed, sla, ohair ! make/windows/makefiles/compile.make ! make/windows/makefiles/launcher.make Changeset: a3c0ec0428a2 Author: zgu Date: 2011-03-02 16:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a3c0ec0428a2 Merge Changeset: 8c0d0510d36f Author: dcubed Date: 2011-03-03 09:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8c0d0510d36f Merge Changeset: 11303bede852 Author: jcoomes Date: 2011-03-03 21:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/11303bede852 Merge From John.Coomes at oracle.com Fri Mar 4 04:39:33 2011 From: John.Coomes at oracle.com (John Coomes) Date: Fri, 4 Mar 2011 04:39:33 -0800 Subject: review request (S+) 7018056: large pages not always enabled by default Message-ID: <19824.56709.70594.158317@oracle.com> I'd appreciate reviews of the fix for 7018056 which fixes a regression on solaris where large pages were not always enabled by default. http://cr.openjdk.java.net/~jcoomes/7018056-large-pages/ Details are in the webrev. The code is based on rev 2133:4e0069ff33df. -John From vladimir.kozlov at oracle.com Fri Mar 4 09:55:32 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Fri, 04 Mar 2011 09:55:32 -0800 Subject: review request (S+) 7018056: large pages not always enabled by default In-Reply-To: <19824.56709.70594.158317@oracle.com> References: <19824.56709.70594.158317@oracle.com> Message-ID: <4D712794.3080605@oracle.com> Looks good. Vladimir John Coomes wrote: > I'd appreciate reviews of the fix for 7018056 which fixes a regression > on solaris where large pages were not always enabled by default. > > http://cr.openjdk.java.net/~jcoomes/7018056-large-pages/ > > Details are in the webrev. The code is based on rev > 2133:4e0069ff33df. > > -John > From John.Coomes at oracle.com Fri Mar 4 13:34:29 2011 From: John.Coomes at oracle.com (John Coomes) Date: Fri, 4 Mar 2011 13:34:29 -0800 Subject: review request (S+) 7018056: large pages not always enabled by default In-Reply-To: <4D712794.3080605@oracle.com> References: <19824.56709.70594.158317@oracle.com> <4D712794.3080605@oracle.com> Message-ID: <19825.23269.692725.561592@oracle.com> Vladimir Kozlov (vladimir.kozlov at oracle.com) wrote: > Looks good. Thanks! -John > John Coomes wrote: > > I'd appreciate reviews of the fix for 7018056 which fixes a regression > > on solaris where large pages were not always enabled by default. > > > > http://cr.openjdk.java.net/~jcoomes/7018056-large-pages/ > > > > Details are in the webrev. The code is based on rev > > 2133:4e0069ff33df. > > > > -John > > From igor.veresov at oracle.com Fri Mar 4 16:33:15 2011 From: igor.veresov at oracle.com (Igor Veresov) Date: Fri, 04 Mar 2011 16:33:15 -0800 Subject: review request (S+) 7018056: large pages not always enabled by default In-Reply-To: <19824.56709.70594.158317@oracle.com> References: <19824.56709.70594.158317@oracle.com> Message-ID: <4D7184CB.1050801@oracle.com> Looks good. igor On 3/4/11 4:39 AM, John Coomes wrote: > I'd appreciate reviews of the fix for 7018056 which fixes a regression > on solaris where large pages were not always enabled by default. > > http://cr.openjdk.java.net/~jcoomes/7018056-large-pages/ > > Details are in the webrev. The code is based on rev > 2133:4e0069ff33df. > > -John > From tony.printezis at oracle.com Fri Mar 4 22:42:06 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Sat, 05 Mar 2011 06:42:06 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7014923: G1: code cleanup Message-ID: <20110305064212.8936147D50@hg.openjdk.java.net> Changeset: 1216415d8e35 Author: tonyp Date: 2011-03-04 17:13 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1216415d8e35 7014923: G1: code cleanup Summary: Some G1 code cleanup. Reviewed-by: johnc, jcoomes, jwilhelm ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/concurrentMarkThread.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1MarkSweep.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.cpp ! src/share/vm/gc_implementation/g1/heapRegionSeq.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegionSets.cpp ! src/share/vm/utilities/debug.hpp ! src/share/vm/utilities/globalDefinitions.hpp From john.coomes at oracle.com Sun Mar 6 13:56:40 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sun, 06 Mar 2011 21:56:40 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7018056: large pages not always enabled by default Message-ID: <20110306215641.DC05F47E6D@hg.openjdk.java.net> Changeset: a2c2eac1ca62 Author: jcoomes Date: 2011-03-06 11:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a2c2eac1ca62 7018056: large pages not always enabled by default Reviewed-by: phh, kvn ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/arguments.hpp ! src/share/vm/runtime/globals.hpp From bengt.rutisson at oracle.com Mon Mar 7 02:33:10 2011 From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com) Date: Mon, 07 Mar 2011 10:33:10 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7022943: G1: improve logging to avoid interleaved numbers Message-ID: <20110307103318.B337847EDD@hg.openjdk.java.net> Changeset: c93aa6caa02f Author: brutisso Date: 2011-03-03 22:58 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c93aa6caa02f 7022943: G1: improve logging to avoid interleaved numbers Summary: Introduced buffered loggging to make sure that log lines are logged one line at a time Reviewed-by: stefank, johnc, dsamersoff ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp From bengt.rutisson at oracle.com Mon Mar 7 04:42:08 2011 From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com) Date: Mon, 07 Mar 2011 12:42:08 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7023747: G1: too strict assert in RefineRecordRefsIntoCSCardTableEntryClosure::do_card_ptr in g1RemSet.cpp Message-ID: <20110307124210.62C4347EED@hg.openjdk.java.net> Changeset: 04d1138b4cce Author: brutisso Date: 2011-03-03 11:35 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/04d1138b4cce 7023747: G1: too strict assert in RefineRecordRefsIntoCSCardTableEntryClosure::do_card_ptr in g1RemSet.cpp Summary: Made sure that the assert looks at ParallelGCThreads. Reviewed-by: stefank, tonyp, jwilhelm, johnc ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/g1RemSet.cpp From bluedavy at gmail.com Wed Mar 9 21:47:25 2011 From: bluedavy at gmail.com (BlueDavy Lin) Date: Thu, 10 Mar 2011 13:47:25 +0800 Subject: Hadoop JobTracker crash log,version is 6u23 Message-ID: hi! The crash log attached,can someone give some advices? # # A fatal error has been detected by the Java Runtime Environment: # # SIGBUS (0x7) at pc=0x0000003f41b72587, pid=18379, tid=1112861024 # # JRE version: 6.0_23-b05 # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.0-b09 mixed mode linux-amd64 compressed oops) # Problematic frame: # C [libc.so.6+0x72587] memcpy+0x37 # # If you would like to submit a bug report, please visit: # http://java.sun.com/webapps/bugreport/crash.jsp # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # -- ============================= |? ?? BlueDavy? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? | |? ?? http://www.bluedavy.com? ?? | ============================= -------------- next part -------------- A non-text attachment was scrubbed... Name: hs_err_pid.log Type: application/octet-stream Size: 71441 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110310/352d9874/attachment-0001.obj From y.s.ramakrishna at oracle.com Wed Mar 9 22:21:35 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Wed, 09 Mar 2011 22:21:35 -0800 Subject: Hadoop JobTracker crash log,version is 6u23 In-Reply-To: References: Message-ID: <4D786DEF.3030006@oracle.com> It looks like you have a sigbus accessing:- siginfo:si_signo=SIGBUS: si_errno=0, si_code=2 (BUS_ADRERR), si_addr=0x0000002ab978f000 which falls in this pmap section:- 2ab9773000-2ab9794000 r--s 0023b000 08:02 8437945 /home/hadoop/hadoop-0.19.1-dc/hadoop-0.19.1-dc-core.jar while your thread is attempting to load a class from that jar file:- Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) J java.util.zip.ZipFile.getEntry(JLjava/lang/String;Z)J J sun.misc.URLClassPath$JarLoader.getResource(Ljava/lang/String;Z)Lsun/misc/Resource; J sun.misc.URLClassPath.getResource(Ljava/lang/String;Z)Lsun/misc/Resource; j java.net.URLClassLoader$1.run()Ljava/lang/Object;+26 v ~StubRoutines::call_stub j java.security.AccessController.doPrivileged(Ljava/security/PrivilegedExceptionAction;Ljava/security/AccessControlContext;)Ljava/lang/Object;+0 j java.net.URLClassLoader.findClass(Ljava/lang/String;)Ljava/lang/Class;+13 j java.lang.ClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class;+47 j sun.misc.Launcher$AppClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class;+41 j java.lang.ClassLoader.loadClass(Ljava/lang/String;)Ljava/lang/Class;+3 v ~StubRoutines::call_stub j org.apache.hadoop.mapred.loadhistory_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+96 j org.apache.jasper.runtime.HttpJspBase.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+3 j javax.servlet.http.HttpServlet.service(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+30 j org.mortbay.jetty.servlet.ServletHolder.handle(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+161 j org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Lorg/mortbay/jetty/servlet/ServletHolder;I)V+249 j org.mortbay.jetty.servlet.Dispatcher.dispatch(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;I)V+447 j org.mortbay.jetty.servlet.Dispatcher.include(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+4 j org.apache.jasper.runtime.JspRuntimeLibrary.include(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;Ljava/lang/String;Ljavax/servlet/jsp/JspWriter;Z)V+45 j org.apache.hadoop.mapred.jobdetailshistory_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+225 j org.apache.jasper.runtime.HttpJspBase.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+3 j javax.servlet.http.HttpServlet.service(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+30 j org.mortbay.jetty.servlet.ServletHolder.handle(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+161 j org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Lorg/mortbay/jetty/servlet/ServletHolder;I)V+249 j org.mortbay.jetty.servlet.ServletHandler.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+290 j org.mortbay.http.HttpContext.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+157 j org.mortbay.jetty.servlet.WebApplicationContext.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+14 j org.mortbay.http.HttpContext.handle(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+455 j org.mortbay.http.HttpServer.service(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)Lorg/mortbay/http/HttpContext;+246 j org.mortbay.http.HttpConnection.service(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)Lorg/mortbay/http/HttpContext;+24 j org.mortbay.http.HttpConnection.handleNext()Z+545 j org.mortbay.http.HttpConnection.handle()V+17 j org.mortbay.http.SocketListener.handleConnection(Ljava/net/Socket;)V+65 j org.mortbay.util.ThreadedServer.handle(Ljava/lang/Object;)V+19 j org.mortbay.util.ThreadPool$PoolThread.run()V+124 v ~StubRoutines::call_stub Perhaps that mmapped jar file has sudddenly been yanked out from under your process? (Did the superuser decide to either delete it or update it while it was being used by your process?) Anyhow, this is not GC related so doesn't belong. i don't think, on this alias. best. -- ramki On 3/9/2011 9:47 PM, BlueDavy Lin wrote: > hi! > > The crash log attached,can someone give some advices? > > # > # A fatal error has been detected by the Java Runtime Environment: > # > # SIGBUS (0x7) at pc=0x0000003f41b72587, pid=18379, tid=1112861024 > # > # JRE version: 6.0_23-b05 > # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.0-b09 mixed mode > linux-amd64 compressed oops) > # Problematic frame: > # C [libc.so.6+0x72587] memcpy+0x37 > # > # If you would like to submit a bug report, please visit: > # http://java.sun.com/webapps/bugreport/crash.jsp > # The crash happened outside the Java Virtual Machine in native code. > # See problematic frame for where to report the bug. > # > From todd at cloudera.com Wed Mar 9 22:33:32 2011 From: todd at cloudera.com (Todd Lipcon) Date: Wed, 9 Mar 2011 22:33:32 -0800 Subject: Hadoop JobTracker crash log,version is 6u23 In-Reply-To: <4D786DEF.3030006@oracle.com> References: <4D786DEF.3030006@oracle.com> Message-ID: I've seen a similar issue before when there aren't enough file handles available via ulimit for the Java process. Oracle folks please refer to "Internal Review ID" 1985110. Basically some of the classloader code doesn't handle ENFILE well. See if bumping ulimit -n fixes things. -Todd On Wed, Mar 9, 2011 at 10:21 PM, Y. Srinivas Ramakrishna wrote: > It looks like you have a sigbus accessing:- > > siginfo:si_signo=SIGBUS: si_errno=0, si_code=2 (BUS_ADRERR), > si_addr=0x0000002ab978f000 > > which falls in this pmap section:- > > 2ab9773000-2ab9794000 r--s 0023b000 08:02 8437945 > /home/hadoop/hadoop-0.19.1-dc/hadoop-0.19.1-dc-core.jar > > while your thread is attempting to load a class from that jar file:- > > Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) > J ?java.util.zip.ZipFile.getEntry(JLjava/lang/String;Z)J > J > ?sun.misc.URLClassPath$JarLoader.getResource(Ljava/lang/String;Z)Lsun/misc/Resource; > J ?sun.misc.URLClassPath.getResource(Ljava/lang/String;Z)Lsun/misc/Resource; > j ?java.net.URLClassLoader$1.run()Ljava/lang/Object;+26 > v ?~StubRoutines::call_stub > j > java.security.AccessController.doPrivileged(Ljava/security/PrivilegedExceptionAction;Ljava/security/AccessControlContext;)Ljava/lang/Object;+0 > j ?java.net.URLClassLoader.findClass(Ljava/lang/String;)Ljava/lang/Class;+13 > j ?java.lang.ClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class;+47 > j > ?sun.misc.Launcher$AppClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class;+41 > j ?java.lang.ClassLoader.loadClass(Ljava/lang/String;)Ljava/lang/Class;+3 > v ?~StubRoutines::call_stub > j > org.apache.hadoop.mapred.loadhistory_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+96 > j > org.apache.jasper.runtime.HttpJspBase.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+3 > j > javax.servlet.http.HttpServlet.service(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+30 > j > org.mortbay.jetty.servlet.ServletHolder.handle(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+161 > j > org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Lorg/mortbay/jetty/servlet/ServletHolder;I)V+249 > j > org.mortbay.jetty.servlet.Dispatcher.dispatch(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;I)V+447 > j > org.mortbay.jetty.servlet.Dispatcher.include(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+4 > j > org.apache.jasper.runtime.JspRuntimeLibrary.include(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;Ljava/lang/String;Ljavax/servlet/jsp/JspWriter;Z)V+45 > j > org.apache.hadoop.mapred.jobdetailshistory_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+225 > j > org.apache.jasper.runtime.HttpJspBase.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+3 > j > javax.servlet.http.HttpServlet.service(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+30 > j > org.mortbay.jetty.servlet.ServletHolder.handle(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+161 > j > org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Lorg/mortbay/jetty/servlet/ServletHolder;I)V+249 > j > org.mortbay.jetty.servlet.ServletHandler.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+290 > j > org.mortbay.http.HttpContext.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+157 > j > org.mortbay.jetty.servlet.WebApplicationContext.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+14 > j > org.mortbay.http.HttpContext.handle(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+455 > j > org.mortbay.http.HttpServer.service(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)Lorg/mortbay/http/HttpContext;+246 > j > org.mortbay.http.HttpConnection.service(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)Lorg/mortbay/http/HttpContext;+24 > j ?org.mortbay.http.HttpConnection.handleNext()Z+545 > j ?org.mortbay.http.HttpConnection.handle()V+17 > j ?org.mortbay.http.SocketListener.handleConnection(Ljava/net/Socket;)V+65 > j ?org.mortbay.util.ThreadedServer.handle(Ljava/lang/Object;)V+19 > j ?org.mortbay.util.ThreadPool$PoolThread.run()V+124 > v ?~StubRoutines::call_stub > > > Perhaps that mmapped jar file has sudddenly been yanked out from under your > process? (Did the superuser decide to either delete it or update it while > it was being used by your process?) Anyhow, this is not GC related so > doesn't belong. > i don't think, on this alias. > > best. > -- ramki > > On 3/9/2011 9:47 PM, BlueDavy Lin wrote: >> >> hi! >> >> ? ? ? ?The crash log attached,can someone give some advices? >> >> # >> # A fatal error has been detected by the Java Runtime Environment: >> # >> # ?SIGBUS (0x7) at pc=0x0000003f41b72587, pid=18379, tid=1112861024 >> # >> # JRE version: 6.0_23-b05 >> # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.0-b09 mixed mode >> linux-amd64 compressed oops) >> # Problematic frame: >> # C ?[libc.so.6+0x72587] ?memcpy+0x37 >> # >> # If you would like to submit a bug report, please visit: >> # ? http://java.sun.com/webapps/bugreport/crash.jsp >> # The crash happened outside the Java Virtual Machine in native code. >> # See problematic frame for where to report the bug. >> # >> > > -- Todd Lipcon Software Engineer, Cloudera From y.s.ramakrishna at oracle.com Wed Mar 9 22:38:32 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Wed, 09 Mar 2011 22:38:32 -0800 Subject: Hadoop JobTracker crash log,version is 6u23 In-Reply-To: References: <4D786DEF.3030006@oracle.com> Message-ID: <4D7871E8.7060208@oracle.com> ulimit won't help, i don't think. I don't know how to look at "internal review id", but this one is not file descriptor exhaustion, but a sigbus acessing an mmapped address, because as i said the mmapped jar was either deleted or updated concurrent with this class loading going on. I'd check with the sys admin. -- ramki On 3/9/2011 10:33 PM, Todd Lipcon wrote: > I've seen a similar issue before when there aren't enough file handles > available via ulimit for the Java process. Oracle folks please refer > to "Internal Review ID" 1985110. Basically some of the classloader > code doesn't handle ENFILE well. > > See if bumping ulimit -n fixes things. > > -Todd > > On Wed, Mar 9, 2011 at 10:21 PM, Y. Srinivas Ramakrishna > wrote: >> It looks like you have a sigbus accessing:- >> >> siginfo:si_signo=SIGBUS: si_errno=0, si_code=2 (BUS_ADRERR), >> si_addr=0x0000002ab978f000 >> >> which falls in this pmap section:- >> >> 2ab9773000-2ab9794000 r--s 0023b000 08:02 8437945 >> /home/hadoop/hadoop-0.19.1-dc/hadoop-0.19.1-dc-core.jar >> >> while your thread is attempting to load a class from that jar file:- >> >> Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) >> J java.util.zip.ZipFile.getEntry(JLjava/lang/String;Z)J >> J >> sun.misc.URLClassPath$JarLoader.getResource(Ljava/lang/String;Z)Lsun/misc/Resource; >> J sun.misc.URLClassPath.getResource(Ljava/lang/String;Z)Lsun/misc/Resource; >> j java.net.URLClassLoader$1.run()Ljava/lang/Object;+26 >> v ~StubRoutines::call_stub >> j >> java.security.AccessController.doPrivileged(Ljava/security/PrivilegedExceptionAction;Ljava/security/AccessControlContext;)Ljava/lang/Object;+0 >> j java.net.URLClassLoader.findClass(Ljava/lang/String;)Ljava/lang/Class;+13 >> j java.lang.ClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class;+47 >> j >> sun.misc.Launcher$AppClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class;+41 >> j java.lang.ClassLoader.loadClass(Ljava/lang/String;)Ljava/lang/Class;+3 >> v ~StubRoutines::call_stub >> j >> org.apache.hadoop.mapred.loadhistory_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+96 >> j >> org.apache.jasper.runtime.HttpJspBase.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+3 >> j >> javax.servlet.http.HttpServlet.service(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+30 >> j >> org.mortbay.jetty.servlet.ServletHolder.handle(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+161 >> j >> org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Lorg/mortbay/jetty/servlet/ServletHolder;I)V+249 >> j >> org.mortbay.jetty.servlet.Dispatcher.dispatch(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;I)V+447 >> j >> org.mortbay.jetty.servlet.Dispatcher.include(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+4 >> j >> org.apache.jasper.runtime.JspRuntimeLibrary.include(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;Ljava/lang/String;Ljavax/servlet/jsp/JspWriter;Z)V+45 >> j >> org.apache.hadoop.mapred.jobdetailshistory_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+225 >> j >> org.apache.jasper.runtime.HttpJspBase.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+3 >> j >> javax.servlet.http.HttpServlet.service(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+30 >> j >> org.mortbay.jetty.servlet.ServletHolder.handle(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+161 >> j >> org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Lorg/mortbay/jetty/servlet/ServletHolder;I)V+249 >> j >> org.mortbay.jetty.servlet.ServletHandler.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+290 >> j >> org.mortbay.http.HttpContext.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+157 >> j >> org.mortbay.jetty.servlet.WebApplicationContext.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+14 >> j >> org.mortbay.http.HttpContext.handle(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+455 >> j >> org.mortbay.http.HttpServer.service(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)Lorg/mortbay/http/HttpContext;+246 >> j >> org.mortbay.http.HttpConnection.service(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)Lorg/mortbay/http/HttpContext;+24 >> j org.mortbay.http.HttpConnection.handleNext()Z+545 >> j org.mortbay.http.HttpConnection.handle()V+17 >> j org.mortbay.http.SocketListener.handleConnection(Ljava/net/Socket;)V+65 >> j org.mortbay.util.ThreadedServer.handle(Ljava/lang/Object;)V+19 >> j org.mortbay.util.ThreadPool$PoolThread.run()V+124 >> v ~StubRoutines::call_stub >> >> >> Perhaps that mmapped jar file has sudddenly been yanked out from under your >> process? (Did the superuser decide to either delete it or update it while >> it was being used by your process?) Anyhow, this is not GC related so >> doesn't belong. >> i don't think, on this alias. >> >> best. >> -- ramki >> >> On 3/9/2011 9:47 PM, BlueDavy Lin wrote: >>> >>> hi! >>> >>> The crash log attached,can someone give some advices? >>> >>> # >>> # A fatal error has been detected by the Java Runtime Environment: >>> # >>> # SIGBUS (0x7) at pc=0x0000003f41b72587, pid=18379, tid=1112861024 >>> # >>> # JRE version: 6.0_23-b05 >>> # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.0-b09 mixed mode >>> linux-amd64 compressed oops) >>> # Problematic frame: >>> # C [libc.so.6+0x72587] memcpy+0x37 >>> # >>> # If you would like to submit a bug report, please visit: >>> # http://java.sun.com/webapps/bugreport/crash.jsp >>> # The crash happened outside the Java Virtual Machine in native code. >>> # See problematic frame for where to report the bug. >>> # >>> >> >> > > > From y.s.ramakrishna at oracle.com Thu Mar 10 00:01:41 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 10 Mar 2011 00:01:41 -0800 Subject: Hadoop JobTracker crash log,version is 6u23 In-Reply-To: <4D7871E8.7060208@oracle.com> References: <4D786DEF.3030006@oracle.com> <4D7871E8.7060208@oracle.com> Message-ID: <4D788565.30501@oracle.com> Just to close the loop, BlueDavy confirmed that the jar file had been updated at that time, just as we'd suspected. -- ramki On 3/9/2011 10:38 PM, Y. Srinivas Ramakrishna wrote: > ulimit won't help, i don't think. > I don't know how to look at "internal review id", but > this one is not file descriptor exhaustion, but a sigbus > acessing an mmapped address, because as i said the mmapped > jar was either deleted or updated concurrent with this > class loading going on. I'd check with the sys admin. > > -- ramki > > On 3/9/2011 10:33 PM, Todd Lipcon wrote: >> I've seen a similar issue before when there aren't enough file handles >> available via ulimit for the Java process. Oracle folks please refer >> to "Internal Review ID" 1985110. Basically some of the classloader >> code doesn't handle ENFILE well. >> >> See if bumping ulimit -n fixes things. >> >> -Todd >> >> On Wed, Mar 9, 2011 at 10:21 PM, Y. Srinivas Ramakrishna >> wrote: >>> It looks like you have a sigbus accessing:- >>> >>> siginfo:si_signo=SIGBUS: si_errno=0, si_code=2 (BUS_ADRERR), >>> si_addr=0x0000002ab978f000 >>> >>> which falls in this pmap section:- >>> >>> 2ab9773000-2ab9794000 r--s 0023b000 08:02 8437945 >>> /home/hadoop/hadoop-0.19.1-dc/hadoop-0.19.1-dc-core.jar >>> >>> while your thread is attempting to load a class from that jar file:- >>> >>> Java frames: (J=compiled Java code, j=interpreted, Vv=VM code) >>> J java.util.zip.ZipFile.getEntry(JLjava/lang/String;Z)J >>> J >>> sun.misc.URLClassPath$JarLoader.getResource(Ljava/lang/String;Z)Lsun/misc/Resource; >>> J sun.misc.URLClassPath.getResource(Ljava/lang/String;Z)Lsun/misc/Resource; >>> j java.net.URLClassLoader$1.run()Ljava/lang/Object;+26 >>> v ~StubRoutines::call_stub >>> j >>> java.security.AccessController.doPrivileged(Ljava/security/PrivilegedExceptionAction;Ljava/security/AccessControlContext;)Ljava/lang/Object;+0 >>> >>> j java.net.URLClassLoader.findClass(Ljava/lang/String;)Ljava/lang/Class;+13 >>> j java.lang.ClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class;+47 >>> j >>> sun.misc.Launcher$AppClassLoader.loadClass(Ljava/lang/String;Z)Ljava/lang/Class;+41 >>> j java.lang.ClassLoader.loadClass(Ljava/lang/String;)Ljava/lang/Class;+3 >>> v ~StubRoutines::call_stub >>> j >>> org.apache.hadoop.mapred.loadhistory_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+96 >>> >>> j >>> org.apache.jasper.runtime.HttpJspBase.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+3 >>> >>> j >>> javax.servlet.http.HttpServlet.service(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+30 >>> >>> j >>> org.mortbay.jetty.servlet.ServletHolder.handle(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+161 >>> >>> j >>> org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Lorg/mortbay/jetty/servlet/ServletHolder;I)V+249 >>> >>> j >>> org.mortbay.jetty.servlet.Dispatcher.dispatch(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;I)V+447 >>> >>> j >>> org.mortbay.jetty.servlet.Dispatcher.include(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+4 >>> >>> j >>> org.apache.jasper.runtime.JspRuntimeLibrary.include(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;Ljava/lang/String;Ljavax/servlet/jsp/JspWriter;Z)V+45 >>> >>> j >>> org.apache.hadoop.mapred.jobdetailshistory_jsp._jspService(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+225 >>> >>> j >>> org.apache.jasper.runtime.HttpJspBase.service(Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;)V+3 >>> >>> j >>> javax.servlet.http.HttpServlet.service(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+30 >>> >>> j >>> org.mortbay.jetty.servlet.ServletHolder.handle(Ljavax/servlet/ServletRequest;Ljavax/servlet/ServletResponse;)V+161 >>> >>> j >>> org.mortbay.jetty.servlet.WebApplicationHandler.dispatch(Ljava/lang/String;Ljavax/servlet/http/HttpServletRequest;Ljavax/servlet/http/HttpServletResponse;Lorg/mortbay/jetty/servlet/ServletHolder;I)V+249 >>> >>> j >>> org.mortbay.jetty.servlet.ServletHandler.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+290 >>> >>> j >>> org.mortbay.http.HttpContext.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+157 >>> >>> j >>> org.mortbay.jetty.servlet.WebApplicationContext.handle(Ljava/lang/String;Ljava/lang/String;Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+14 >>> >>> j >>> org.mortbay.http.HttpContext.handle(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)V+455 >>> >>> j >>> org.mortbay.http.HttpServer.service(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)Lorg/mortbay/http/HttpContext;+246 >>> >>> j >>> org.mortbay.http.HttpConnection.service(Lorg/mortbay/http/HttpRequest;Lorg/mortbay/http/HttpResponse;)Lorg/mortbay/http/HttpContext;+24 >>> >>> j org.mortbay.http.HttpConnection.handleNext()Z+545 >>> j org.mortbay.http.HttpConnection.handle()V+17 >>> j org.mortbay.http.SocketListener.handleConnection(Ljava/net/Socket;)V+65 >>> j org.mortbay.util.ThreadedServer.handle(Ljava/lang/Object;)V+19 >>> j org.mortbay.util.ThreadPool$PoolThread.run()V+124 >>> v ~StubRoutines::call_stub >>> >>> >>> Perhaps that mmapped jar file has sudddenly been yanked out from under your >>> process? (Did the superuser decide to either delete it or update it while >>> it was being used by your process?) Anyhow, this is not GC related so >>> doesn't belong. >>> i don't think, on this alias. >>> >>> best. >>> -- ramki >>> >>> On 3/9/2011 9:47 PM, BlueDavy Lin wrote: >>>> >>>> hi! >>>> >>>> The crash log attached,can someone give some advices? >>>> >>>> # >>>> # A fatal error has been detected by the Java Runtime Environment: >>>> # >>>> # SIGBUS (0x7) at pc=0x0000003f41b72587, pid=18379, tid=1112861024 >>>> # >>>> # JRE version: 6.0_23-b05 >>>> # Java VM: Java HotSpot(TM) 64-Bit Server VM (19.0-b09 mixed mode >>>> linux-amd64 compressed oops) >>>> # Problematic frame: >>>> # C [libc.so.6+0x72587] memcpy+0x37 >>>> # >>>> # If you would like to submit a bug report, please visit: >>>> # http://java.sun.com/webapps/bugreport/crash.jsp >>>> # The crash happened outside the Java Virtual Machine in native code. >>>> # See problematic frame for where to report the bug. >>>> # >>>> >>> >>> >> >> >> > From john.coomes at oracle.com Thu Mar 10 20:55:32 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Mar 2011 04:55:32 +0000 Subject: hg: jdk7/hotspot-gc/corba: Added tag jdk7-b133 for changeset 671fe2e623ff Message-ID: <20110311045536.E473947075@hg.openjdk.java.net> Changeset: 918003855fa0 Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/918003855fa0 Added tag jdk7-b133 for changeset 671fe2e623ff ! .hgtags From john.coomes at oracle.com Thu Mar 10 20:55:44 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Mar 2011 04:55:44 +0000 Subject: hg: jdk7/hotspot-gc/jaxp: Added tag jdk7-b133 for changeset 8e1148c7911b Message-ID: <20110311045544.2D60E47076@hg.openjdk.java.net> Changeset: 2473f7027ac5 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/2473f7027ac5 Added tag jdk7-b133 for changeset 8e1148c7911b ! .hgtags From john.coomes at oracle.com Thu Mar 10 20:55:50 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Mar 2011 04:55:50 +0000 Subject: hg: jdk7/hotspot-gc/jaxws: Added tag jdk7-b133 for changeset 359d0c8c00a0 Message-ID: <20110311045550.D5E6C47077@hg.openjdk.java.net> Changeset: 8393aae2eb24 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/8393aae2eb24 Added tag jdk7-b133 for changeset 359d0c8c00a0 ! .hgtags From john.coomes at oracle.com Thu Mar 10 20:56:30 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Mar 2011 04:56:30 +0000 Subject: hg: jdk7/hotspot-gc/jdk: 13 new changesets Message-ID: <20110311045919.BF29047078@hg.openjdk.java.net> Changeset: 7931291bc5d3 Author: herrick Date: 2011-03-01 17:09 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7931291bc5d3 7021567: need to create jnlp javadoc for 64 bit bundles. Summary: need to create jnlp javadoc for 64 bit bundles. Reviewed-by: igor, ohair ! make/common/Release.gmk Changeset: c53711f82bfb Author: igor Date: 2011-03-08 14:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c53711f82bfb Merge - test/java/lang/Thread/StopBeforeStart.java Changeset: eb54e565c491 Author: ohair Date: 2011-02-26 09:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/eb54e565c491 7016175: HTML generated from new JavaDoc has tags added from makefile Reviewed-by: jjg ! make/common/shared/Defs-javadoc.gmk ! make/docs/Makefile Changeset: 391a9ef69036 Author: ohair Date: 2011-02-26 10:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/391a9ef69036 Merge Changeset: e88c8381eaca Author: ohair Date: 2011-02-26 12:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e88c8381eaca 7022237: Fix use of \" in the new "release" file at the top of the install, windows issues Reviewed-by: ohrstrom ! make/common/Release.gmk Changeset: 123dd69407f9 Author: ohair Date: 2011-02-26 12:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/123dd69407f9 Merge Changeset: ed1d4691da29 Author: ohrstrom Date: 2011-02-28 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ed1d4691da29 7021753: Add a build times report Summary: Report the build times at end of a jdkroot build. Reviewed-by: ohair ! make/common/shared/Defs-utils.gmk Changeset: f32f0ae3d873 Author: ohair Date: 2011-03-02 12:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f32f0ae3d873 Merge Changeset: 869cba583dd4 Author: ohair Date: 2011-03-02 13:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/869cba583dd4 7020815: REBASE should not be required for windows jdk repo builds - can't build with VS 2010 Express Reviewed-by: prr ! make/common/shared/Defs-utils.gmk ! make/common/shared/Sanity.gmk Changeset: e5cd10425e7e Author: ohair Date: 2011-03-03 07:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e5cd10425e7e Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java Changeset: c588355b5bb7 Author: ohair Date: 2011-03-03 15:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c588355b5bb7 Merge Changeset: 5e5f68a01d12 Author: ohair Date: 2011-03-08 16:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5e5f68a01d12 Merge ! make/common/Release.gmk Changeset: e947a98ea3c1 Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e947a98ea3c1 Added tag jdk7-b133 for changeset 5e5f68a01d12 ! .hgtags From john.coomes at oracle.com Thu Mar 10 20:55:25 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 11 Mar 2011 04:55:25 +0000 Subject: hg: jdk7/hotspot-gc: 6 new changesets Message-ID: <20110311045525.C45F747073@hg.openjdk.java.net> Changeset: a1c8b847b753 Author: ohrstrom Date: 2011-02-28 10:56 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/a1c8b847b753 7021753: Add a build times report Summary: Report the build times at end of a jdkroot build. Reviewed-by: ohair ! Makefile ! make/Defs-internal.gmk ! make/corba-rules.gmk ! make/deploy-rules.gmk ! make/hotspot-rules.gmk ! make/install-rules.gmk ! make/jaxp-rules.gmk ! make/jaxws-rules.gmk ! make/jdk-rules.gmk ! make/langtools-rules.gmk ! make/sponsors-rules.gmk Changeset: 47ad81d343e8 Author: ohair Date: 2011-03-01 11:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/47ad81d343e8 7023111: Add webrev script to make/scripts Reviewed-by: darcy + make/scripts/webrev.ksh Changeset: 258b21c7f4af Author: ohair Date: 2011-03-01 11:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/258b21c7f4af Merge Changeset: 27384dd2d8ed Author: ohair Date: 2011-03-03 15:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/27384dd2d8ed Merge Changeset: c6f380693342 Author: ohair Date: 2011-03-09 16:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/c6f380693342 7026167: Broken fastdebug only build Reviewed-by: cl ! Makefile Changeset: ddc2fcb3682f Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/ddc2fcb3682f Added tag jdk7-b133 for changeset c6f380693342 ! .hgtags From mark.g.j.christiaens at gmail.com Fri Mar 11 01:18:46 2011 From: mark.g.j.christiaens at gmail.com (Mark Christiaens) Date: Fri, 11 Mar 2011 10:18:46 +0100 Subject: Crash in b133 Message-ID: I reported a bug in G1 b133: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7026677 but I'm not sure if it percolates properly to this group (when filing the bug I couldn't indicate that it was in JDK 7 for example). Do you guys get to see it? Mark -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110311/65081251/attachment.html From jon.masamitsu at oracle.com Fri Mar 11 08:46:53 2011 From: jon.masamitsu at oracle.com (Jon Masamitsu) Date: Fri, 11 Mar 2011 08:46:53 -0800 Subject: Crash in b133 In-Reply-To: References: Message-ID: <4D7A51FD.3020002@oracle.com> Yes, we got notification on 7026677. On 3/11/2011 1:18 AM, Mark Christiaens wrote: > I reported a bug in G1 b133: > http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7026677 but I'm not > sure if it percolates properly to this group (when filing the bug I > couldn't indicate that it was in JDK 7 for example). Do you guys get > to see it? > > Mark > From john.cuthbertson at oracle.com Fri Mar 11 17:34:50 2011 From: john.cuthbertson at oracle.com (John Cuthbertson) Date: Fri, 11 Mar 2011 17:34:50 -0800 Subject: RFR(M): 7009266: G1: assert(obj->is_oop_or_null(true )) failed: Error Message-ID: <4D7ACDBA.7020003@oracle.com> Hi Everyone, I'm looking for a few of volunteers to review the changes that fix this assertion failure. The latest changes can be found at: http://cr.openjdk.java.net/~johnc/7009266/webrev.3/ and include changes based upon earlier internal reviews. The earlier changes are also on cr.openjdk.java.net for reference. Background: The G1 garbage collector includes a concurrent marking algorithm that makes use of snapshot-at-the-beginning or SATB. With this algorithm the GC will mark all objects that are reachable at the start of marking; objects that are allocated since the start of marking are implicitly considered live. In order to populate the "snapshot" of the object graph that existed at the start of marking, G1 employs a write barrier. When an object is stored into another object's field the write-barrier records the previous value of that field as it was part of the "snapshot" and concurrent marking will trace the sub-graph that is reachable from this previous value. Unfortunately, in the presence of Reference objects, SATB might not be sufficient to mark a referent object as live. Consider that, at the start of marking, we have a weakly reachable object i.e. an object where the only pointer to that object. If the referent is obtained from the Reference object and stored to another object's field (making the referent now strongly reachable and hence live) the G1 write barrier will record the field's previous value but not the value of the referent. If the referent object is strongly reachable from some other object that will be traced by concurrent marking, _or_ there is a subsequent assignment to the field where we have written the referent (in which case we record the previous value - the referent - in an SATB buffer) then the referent will be marked live. Otherwise the referent will not be marked. That is the issue that was causing the failure in this CR. There was a Logger object that was only reachable through a WeakReference at the start of concurrent marking. During marking the Logger object is obtained from the WeakReference and stored into a field of a live object. The G1 write barrier recorded the previous value in the field (as it is part of the snapshot at the start of marking). Since there was no other assignment to the live object's field and there was no other strong reference to the Logger object, the Logger object was not marked. At the end of concurrent marking the Logger object was considered dead and the link between the WeakReference and the Logger was severed by clearing the referent field during reference processing. To solve this (entirely in Hotspot and causing a performance overhead for G1 only) it was decided that the best approach was to intrinsify the Reference.get() method in the JIT compilers and add new interpreter entry points so that the value in the referent field will be recorded in an SATB buffer by the G1 pre-barrier code. The changes for Zero and the C++ interpreters are place holder routines but should be straight forward to implement. None of the individual changes is large - they are just well distributed around the JVM. :) Testing: white box test; eyeballing the generated compiled and interpreter code; the failing Kitchensink big-app on x86 (32/64 bit), sparc (32/64 bit), Xint, Xcomp (client and server), with and without G1; the GC test suite with and without G1; and jprt. Thanks and regards, JohnC From dalibor.topic at oracle.com Sun Mar 13 08:57:06 2011 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Sun, 13 Mar 2011 16:57:06 +0100 Subject: A few questions about G1 In-Reply-To: References: Message-ID: <4D7CE952.3030404@oracle.com> On 3/13/11 3:51 PM, Alex Aisinzon wrote: > Hi all > > > > I never heard back on this. Is there something wrong with the mailing list? Hi Alex, It sounds like you're asking about G1's Early Access status and are thinking about using it in production. I'd agree that the disappearance of the flag is a bit confusing, but the intention is that it's still an experimental feature. As the release notes for Java SE 6 Update 21 say at http://www.oracle.com/technetwork/java/javase/6u21-156341.html , "G1 continues to be available in Early Access [..]" The release notes for later releases, including those for Java SE 6 Update 24 don't mention G1. Accordingly, its status is still the same - it's available in Early Access, so usage in production settings is neither recommended nor supported. cheers, dalibor topic -- Oracle Dalibor Topic | Java F/OSS Ambassador Phone: +494023646738 | | | Mobile: +491772664192 Oracle Java Platform Group ORACLE Deutschland B.V. & Co. KG | Nagelsweg 55 | 20097 Hamburg ORACLE Deutschland B.V. & Co. KG Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRA 95603 Komplement?rin: ORACLE Deutschland Verwaltung B.V. Rijnzathe 6, 3454PV De Meern, Niederlande Handelsregister der Handelskammer Midden-Niederlande, Nr. 30143697 Gesch?ftsf?hrer: J?rgen Kunz, Marcel van de Molen, Alexander van der Ven Green Oracle Oracle is committed to developing practices and products that help protect the environment _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From y.s.ramakrishna at oracle.com Mon Mar 14 00:26:17 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Mon, 14 Mar 2011 00:26:17 -0700 Subject: A few questions about G1 In-Reply-To: References: Message-ID: <4D7DC319.9040502@oracle.com> Hi Alex -- On 3/13/2011 7:51 AM, Alex Aisinzon wrote: ... > I guess G1 is more mature and will give it a try as part of some tests > with the 1.6 JVM. Definitely more mature, both in performance and reliability. Try 6u25 EA, or 7 EA. > > I had some questions about G1: > > * Region size: our product does not generate large objects. > Nevertheless, some of our customers will configure it in a way that > results in the allocation of large objects. The typical example is that > our product will be integrated with a document management system and > that some very large documents (10s of MB or even 100s of MB) will go > through the JVM that supports our product. I wonder what happens if the > region size is smaller than these large objects and wonder if one can > size up the region size pre-emptively to avoid possible negative > effects. It may also make sense to instrument the JVM to output in the > GC log the size of the object that caused a region to become full, as it > would allow to identify such issues. G1 does treat large objects specially (see the ISMM 2004 paper). In typical programs the birth-death rates of large objects is quite small, so I would typically not expect G1 with its default region size to have any issues. So I would not start off with the assumption that region size will need any kind of adjustment. If you have any issues with the default size, you can revisit on this alias. > > * Pause time: with Sun JVM 1.5, I had experimented with > ParallelGC, ParallelOldGC and CMS. The two first show long full > collections. CMS was mostly better but resulted in some rare even longer > collections, which I attributed to fragmentation, which was in line with > our applications memory behavior. I wonder what customer/benchmark > experience is so far with G1 and whether I can hope to avoid these long > pauses with G1. G1 is compacting so the expectation is indeed that the long term fragmentation that is sometimes difficult to avoid with CMS would be much less of an issue with G1. Our experiences with G1 in the field are limited, but our expectation is indeed that it will cause far fewer issues with fragmentation. Please try it out and let us know of your experiences. > > * Possible tunings to minimize pause times: what would be the > best tunings to explore with G1, considering that objective of > containing pause times. From reading > http://www.oracle.com/technetwork/java/javase/tech/g1-intro-jsp-135488.h > tml, it seems that MaxGCPauseMillis would be a good tuning. Are they > other tunings I should consider to test G1 more specifically on the > pause time dimension? I believe most of our internal testing has shown that if your GC pause time and MMU settings are reasonable, G1 does a fairly good job of containing the pauses withing the requested band. Sometimes these may be difficult to meet, however, and in those cases you may need to explicitly size and shape the heap to avoid concurrent mode failure. Here, our experiences are again somewhat limited, so experiences from the field will help us refine our understanding of and tuning of G1 performance as we go forward. One thing to keep in mind is that G1 will typically do well with its heuristics if there is some amount of spare concurrency available on your platform to deal with its concurrent remembered set refinement and concurrent marking work, as well as, like CMS, extra room in the old generation so as to give its concurrent collection enough headroom to finish collection. If explicitly tuning the heap, larger heaps with smaller promotion rates into the old gen, just like in the case of CMS, would also be favourable to better operation of G1. I'll let those on our team more familiar with G1 performance and tuning please chine in with further detail as well as correct any inaccuracies in my understanding above. thanks! -- ramki _______________________________________________ hotspot-gc-use mailing list hotspot-gc-use at openjdk.java.net http://mail.openjdk.java.net/mailman/listinfo/hotspot-gc-use From y.s.ramakrishna at oracle.com Mon Mar 14 01:08:42 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Mon, 14 Mar 2011 01:08:42 -0700 Subject: Request for reviews (S): 6987703 iCMS: Intermittent hang with gc/gctests/CallGC/CallGC01 and +ExplicitGCInvokesConcurrent Message-ID: <4D7DCD0A.7000801@oracle.com> Summary: In the existing implementation of ExplicitGCInvokesConcurrent two concurrent System.gc()'s could intefere when using CMSIncremetalMode, leaving the CMS thread stranded in incremental mode with no foreground allocation happening to act as a trigger to get the (i)CMS thread going. Solution: enable_icms() and disable_icms(), which respectively enable and disable the incremental mode of CMS, should be counting requests so as not to intefere. Also added some related asserts. (Removed the obsolete and unused _next field in the CMST class.) webrev: http://cr.openjdk.java.net/~ysr/6987703/webrev.00/ Testing: The failing test (and JPRT) with +/-ExplicitGCInvokesConcurrent +/-ExplicitGCInvokesConcurrent Prior to the fix, on a specific machine, the test would hang about once in three runs or so. After the fix it's been running without hanging for a whole day (many thousands of iterations). thanks for your reviews! -- ramki From y.s.ramakrishna at oracle.com Mon Mar 14 16:43:39 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Mon, 14 Mar 2011 16:43:39 -0700 Subject: Request for review (S): 6668573: CMS: reference processing crash if ParallelCMSThreads > ParallelGCThreads Message-ID: <4D7EA82B.3000408@oracle.com> Note on "(S)" above: although there are a number of files that are touched, the changes are simple and are similar in shape across the collectors. Problem: The assumption that ConcGCThreads <= ParallelGCThreads had been hardwired into some of the code in the reference processor: the concept of an mt-discovery degree that could be distinct from mt-processing degree was also not clearly articulated in some portions of the code. A final problem was a bug in CMS+ParallelRefProcEnabled that had sneaked in undetected late last year and not known until late last week. Solution: In the reference processor class, allow for the possibility that mt-discovery degree is distinct from, and possibly larger than, mt-processing degree (when specific collectors choose to allow it). The remainder of the work is then taken care of by previous work in balance_queues(). Fix the CMS+ParallelRefProcEnabled regression by means of explicitly setting the terminator object in the parallel reference processing task object. Testing: various combinations of collector, parallel gc threads, concurrent gc threads and parallel reference processing settings. -XX:Use<...>GC -XX:ParallelGCThreads=... -XX:ConcGCThreads=... -XX:+/-ParallelRefProcEnabled Thanks to Jon Masamitsu and John Cuthbertson for their reviews of an earlier version of the changes, which can be found at:- Previous (now obsolete) version, provided here only for reference by previous reviewers: http://cr.openjdk.java.net/~ysr/6668573/webrev.00/ Based on their comments, I have made some minor modifications, and the latest webrev can be found below. Latest version: http://cr.openjdk.java.net/~ysr/6668573/webrev.01/ Thanks for any new/re-reviews! -- ramki From John.Coomes at oracle.com Mon Mar 14 18:15:39 2011 From: John.Coomes at oracle.com (John Coomes) Date: Mon, 14 Mar 2011 18:15:39 -0700 Subject: Request for reviews (S): 6987703 iCMS: Intermittent hang with gc/gctests/CallGC/CallGC01 and +ExplicitGCInvokesConcurrent In-Reply-To: <4D7DCD0A.7000801@oracle.com> References: <4D7DCD0A.7000801@oracle.com> Message-ID: <19838.48571.724262.498501@oracle.com> Y. Srinivas Ramakrishna (y.s.ramakrishna at oracle.com) wrote: > > Summary: In the existing implementation of ExplicitGCInvokesConcurrent > two concurrent System.gc()'s could intefere when using CMSIncremetalMode, > leaving the CMS thread stranded in incremental mode with no foreground > allocation happening to act as a trigger to get the (i)CMS thread going. > > Solution: enable_icms() and disable_icms(), which respectively enable and > disable the incremental mode of CMS, should be counting requests > so as not to intefere. Also added some related asserts. > (Removed the obsolete and unused _next field in the CMST class.) > > webrev: http://cr.openjdk.java.net/~ysr/6987703/webrev.00/ > > Testing: The failing test (and JPRT) with > +/-ExplicitGCInvokesConcurrent +/-ExplicitGCInvokesConcurrent > Prior to the fix, on a specific machine, the test would > hang about once in three runs or so. After the fix it's been > running without hanging for a whole day (many thousands of iterations). Looks good to me. -John From y.s.ramakrishna at oracle.com Mon Mar 14 19:07:08 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Mon, 14 Mar 2011 19:07:08 -0700 Subject: Request for review (S): 6627787, 6896099, 7000125: CMS heap sizing (1 RFE, 2 Bugs) Message-ID: <4D7EC9CC.4000902@oracle.com> (bug) 6627787: CMS: JVM refuses to start up with -Xms16m -Xmx16m (RFE) 6896099: Integrate CMS heap ergo with default heap sizing ergo (bug) 7000125: CMS: Anti-monotone young gen sizing with respect to maximum whole heap size specification Problem: CMS heap sizing does not make use of server/client heap sizing ergo, mainly because it wants to keep maximum gc pauses somewhat under control rather than necessarily sizing for throughput. There have been many changes and small tweaks over the years in this code and it has collected a lot of unnecessary settings which also conflict with the sizing decisions being made elsewhere in the heap sizing/policy subsystem, resulting, for example, in the two bugs in the list of CR's above. Solution: Allow CMS to make use of server/client heap sizing ergonomics, just like all the other collectors, while keeping the young generation small enough so as to keep pause times reasonable. One of these required a CPU-specific default. Jettison old settings and flags specific to use in JDK 6 to preserve JDK 5 like CMS settings, which are now considered quite obsolete. Since the fixes for the two defects and the one RFE were entangled, it made sense to fix them all in one changeset. Testing: internal reference workloads to assess the changes from current settings, and to ensure that gc pauses are still "reasonable" with the newer default settings. The command-lines in the two bugs to verify that the sizing anomalies are no longer present. Webrev: http://cr.openjdk.java.net/~ysr/6627787_6896099_7000125/webrev.01/ This contains changes following one internal review (thanks Bengt Rutisson!), but if anyone else has further feedback, please let me know. thanks! -- ramki From poonam.bajaj at oracle.com Mon Mar 14 23:41:37 2011 From: poonam.bajaj at oracle.com (Poonam Bajaj) Date: Tue, 15 Mar 2011 12:11:37 +0530 Subject: Request for review (S): 6627787, 6896099, 7000125: CMS heap sizing (1 RFE, 2 Bugs) In-Reply-To: <4D7EC9CC.4000902@oracle.com> References: <4D7EC9CC.4000902@oracle.com> Message-ID: <4D7F0A21.8000907@oracle.com> Hi Ramki, Thanks for improving the GC logging with these changes. What is the reason behind choosing 16M for sparc and 64M for x86 systems as the default value for CMSYoungGenPerWorker ? Thanks, Poonam On 3/15/2011 7:37 AM, Y. Srinivas Ramakrishna wrote: > (bug) 6627787: CMS: JVM refuses to start up with -Xms16m -Xmx16m > (RFE) 6896099: Integrate CMS heap ergo with default heap sizing ergo > (bug) 7000125: CMS: Anti-monotone young gen sizing with respect to > maximum whole heap size specification > > Problem: CMS heap sizing does not make use of server/client heap sizing > ergo, mainly because it wants to keep maximum gc pauses somewhat > under control rather than necessarily sizing for throughput. > There have been many changes and small tweaks over the years > in this code and it has collected a lot of unnecessary settings > which also conflict with the sizing decisions being made > elsewhere in the heap sizing/policy subsystem, resulting, > for example, in the two bugs in the list of CR's above. > > Solution: Allow CMS to make use of server/client heap sizing > ergonomics, just like all the other collectors, while keeping the > young generation small enough so as to keep pause times > reasonable. One of these required a CPU-specific default. > Jettison old settings and flags specific to use in JDK 6 > to preserve JDK 5 like CMS settings, which are now considered > quite obsolete. > > Since the fixes for the two defects and the one RFE were > entangled, it made sense to fix them all in one changeset. > > Testing: internal reference workloads to assess the changes > from current settings, and to ensure that gc pauses are > still "reasonable" with the newer default settings. > The command-lines in the two bugs to verify that the > sizing anomalies are no longer present. > > Webrev: > http://cr.openjdk.java.net/~ysr/6627787_6896099_7000125/webrev.01/ > > This contains changes following one internal review (thanks Bengt > Rutisson!), > but if anyone else has further feedback, please let me know. > > thanks! > -- ramki -- Best regards, Poonam Sun, an Oracle company Sun, an Oracle Company Poonam Bajaj | Staff Engineer Phone: +66937451 | Mobile: +9844511366 JVM Sustaining Engineering | Bangalore Green Oracle Oracle is committed to developing practices and products that help protect the environment -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110315/93eb6a91/attachment.html -------------- next part -------------- A non-text attachment was scrubbed... Name: sun-oracle-logo.gif Type: image/gif Size: 2088 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110315/93eb6a91/attachment.gif -------------- next part -------------- A non-text attachment was scrubbed... Name: green-for-email-sig_0.gif Type: image/gif Size: 356 bytes Desc: not available Url : http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110315/93eb6a91/attachment-0001.gif From y.s.ramakrishna at oracle.com Tue Mar 15 01:52:03 2011 From: y.s.ramakrishna at oracle.com (y.s.ramakrishna at oracle.com) Date: Tue, 15 Mar 2011 08:52:03 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6987703: iCMS: Intermittent hang with gc/gctests/CallGC/CallGC01 and +ExplicitGCInvokesConcurrent Message-ID: <20110315085205.4F06347171@hg.openjdk.java.net> Changeset: a181f3a124dd Author: ysr Date: 2011-03-14 21:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a181f3a124dd 6987703: iCMS: Intermittent hang with gc/gctests/CallGC/CallGC01 and +ExplicitGCInvokesConcurrent Summary: Count enable_icms() and disable_icms() events so as to prevent inteference between concurrent calls, which can cause the iCMS thread to be left stranded in icms_wait() with an unserviced request and no young allocations to unwedge it. Reviewed-by: jcoomes, poonam ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepThread.hpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/vmCMSOperations.hpp From john.cuthbertson at oracle.com Tue Mar 15 10:13:40 2011 From: john.cuthbertson at oracle.com (John Cuthbertson) Date: Tue, 15 Mar 2011 10:13:40 -0700 Subject: RFR(S): 7026932: G1: No need to abort VM when card count cache expansion fails Message-ID: <4D7F9E44.60204@oracle.com> Hi Everyone, Can I have a couple of volunteers to review the changes for this CR? The webrev can be found at: http://cr.openjdk.java.net/~johnc/7026932/webrev.0/ The problem here was that the allocation that is used to expand some side tables associated with the hot card cache failed and the JVM aborted with an out of C heap memory. For these particular tables an expansion is requested when the number of cards hashed to a location in these tables goes over a threshold. But it's not critical that the expansion succeeds - continuing with the smaller tables is reasonable (with perhaps a small performance penalty caused be doing slightly more refinement). The code that does these allocations uses NEW_C_HEAP_ARRAY which calls AllocateHeap. AllocateHeap calls os::malloc() followed by vm_exit_out_of_memory if the malloc fails. The solution is to call the C heap allocation routines directly and perform localized error handling. I have also added a flag that limits the size to which these table can expand to as a fraction of the number of cards for the maximum Java heap capacity. Testing: code modification to simulate out of C heap conditions, the GC test suite with expansion artifically disabled; the GC test suite with expansion enabled; jprt. Regards, JohnC From y.s.ramakrishna at oracle.com Tue Mar 15 11:12:44 2011 From: y.s.ramakrishna at oracle.com (Y. S. Ramakrishna) Date: Tue, 15 Mar 2011 11:12:44 -0700 Subject: Request for review (S): 6627787, 6896099, 7000125: CMS heap sizing (1 RFE, 2 Bugs) In-Reply-To: <4D7F0A21.8000907@oracle.com> References: <4D7EC9CC.4000902@oracle.com> <4D7F0A21.8000907@oracle.com> Message-ID: <4D7FAC1C.80509@oracle.com> Thanks for the review, Poonam. On 03/14/11 23:41, Poonam Bajaj wrote: > Hi Ramki, > > Thanks for improving the GC logging with these changes. > > What is the reason behind choosing 16M for sparc and 64M for x86 systems > as the default value for CMSYoungGenPerWorker ? This should ideally be keyed off of the "speed" of a single strand or virtual processor of the undrelying platform, but this will have to do for now. The intent is to limit the GC pause for copying the survivors during a scavenge, and thus the scavenge pause. thanks. -- ramki > > Thanks, > Poonam > > On 3/15/2011 7:37 AM, Y. Srinivas Ramakrishna wrote: >> (bug) 6627787: CMS: JVM refuses to start up with -Xms16m -Xmx16m >> (RFE) 6896099: Integrate CMS heap ergo with default heap sizing ergo >> (bug) 7000125: CMS: Anti-monotone young gen sizing with respect to >> maximum whole heap size specification >> >> Problem: CMS heap sizing does not make use of server/client heap sizing >> ergo, mainly because it wants to keep maximum gc pauses somewhat >> under control rather than necessarily sizing for throughput. >> There have been many changes and small tweaks over the years >> in this code and it has collected a lot of unnecessary settings >> which also conflict with the sizing decisions being made >> elsewhere in the heap sizing/policy subsystem, resulting, >> for example, in the two bugs in the list of CR's above. >> >> Solution: Allow CMS to make use of server/client heap sizing >> ergonomics, just like all the other collectors, while keeping the >> young generation small enough so as to keep pause times >> reasonable. One of these required a CPU-specific default. >> Jettison old settings and flags specific to use in JDK 6 >> to preserve JDK 5 like CMS settings, which are now considered >> quite obsolete. >> >> Since the fixes for the two defects and the one RFE were >> entangled, it made sense to fix them all in one changeset. >> >> Testing: internal reference workloads to assess the changes >> from current settings, and to ensure that gc pauses are >> still "reasonable" with the newer default settings. >> The command-lines in the two bugs to verify that the >> sizing anomalies are no longer present. >> >> Webrev: >> http://cr.openjdk.java.net/~ysr/6627787_6896099_7000125/webrev.01/ >> >> This contains changes following one internal review (thanks Bengt >> Rutisson!), >> but if anyone else has further feedback, please let me know. >> >> thanks! >> -- ramki > > -- > Best regards, Poonam > > Sun, an Oracle company > Sun, an Oracle Company > Poonam Bajaj | Staff Engineer > Phone: +66937451 | Mobile: +9844511366 > JVM Sustaining Engineering > | Bangalore > Green Oracle Oracle is committed to > developing practices and products that help protect the environment > From igor.veresov at oracle.com Tue Mar 15 11:29:11 2011 From: igor.veresov at oracle.com (Igor Veresov) Date: Tue, 15 Mar 2011 11:29:11 -0700 Subject: RFR(S): 7026932: G1: No need to abort VM when card count cache expansion fails In-Reply-To: <4D7F9E44.60204@oracle.com> References: <4D7F9E44.60204@oracle.com> Message-ID: <4D7FAFF7.9000805@oracle.com> This looks good! igor On 3/15/11 10:13 AM, John Cuthbertson wrote: > Hi Everyone, > > Can I have a couple of volunteers to review the changes for this CR? The > webrev can be found at: http://cr.openjdk.java.net/~johnc/7026932/webrev.0/ > > The problem here was that the allocation that is used to expand some > side tables associated with the hot card cache failed and the JVM > aborted with an out of C heap memory. For these particular tables an > expansion is requested when the number of cards hashed to a location in > these tables goes over a threshold. But it's not critical that the > expansion succeeds - continuing with the smaller tables is reasonable > (with perhaps a small performance penalty caused be doing slightly more > refinement). > > The code that does these allocations uses NEW_C_HEAP_ARRAY which calls > AllocateHeap. AllocateHeap calls os::malloc() followed by > vm_exit_out_of_memory if the malloc fails. The solution is to call the C > heap allocation routines directly and perform localized error handling. > > I have also added a flag that limits the size to which these table can > expand to as a fraction of the number of cards for the maximum Java heap > capacity. > > Testing: code modification to simulate out of C heap conditions, the GC > test suite with expansion artifically disabled; the GC test suite with > expansion enabled; jprt. > > Regards, > > JohnC From jesper.wilhelmsson at oracle.com Tue Mar 15 23:35:59 2011 From: jesper.wilhelmsson at oracle.com (jesper.wilhelmsson at oracle.com) Date: Wed, 16 Mar 2011 06:35:59 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <20110316063609.0E796471BE@hg.openjdk.java.net> Changeset: 1fb790245268 Author: jwilhelm Date: 2011-03-11 16:35 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1fb790245268 6820066: Check that -XX:ParGCArrayScanChunk has a value larger than zero. Summary: Check that -XX:ParGCArrayScanChunk has a value larger than zero. Reviewed-by: johnc, jmasa, ysr ! src/share/vm/gc_implementation/parallelScavenge/psPromotionManager.cpp ! src/share/vm/runtime/arguments.cpp Changeset: 1abd292f8c38 Author: jwilhelm Date: 2011-03-15 09:07 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1abd292f8c38 Merge From tom.rodriguez at oracle.com Wed Mar 16 10:35:02 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 16 Mar 2011 10:35:02 -0700 Subject: ScavengeRootsInCode Message-ID: I was getting ready to finish my statics fields in Class changes when I hit a failure with jbb and CMS. I've tracked it down to a race in the machinery for updating oop relocations and the logic for making sure that a scavengable nmethod is only scanned once. During a scavenge an nmethod can be reached for scanning in two different ways, either as a live activation on some thread stack or during the scan of scavengeable nmethods. The scan of scavengeable nmethods does two things though. It does the oops_do for the nmethod and then it calls fix_oop_relocations to update the generated code to match the new oop values. The problem is that the scan of the thread stacks and the scan of the scavengable nmethods are performed concurrently so the stack scanning thread might claim the nmethod first but actually scan the nmethod after the call to fix_oop_relocations in the other thread, leaving the oops valid but the code stale. I think the logical place to move the fix_oop_relocations call is into nmethod::oops_do_marking_epilogue. Does this seem reasonable to anyone who understands the new nmethod scavenge code better than I do? It seems to work fine. Actually one thing I noticed is that the nmethod::oops_do_marking_prologue/epiloque logic is being called during full gcs which seems somewhat pointless to me since it mostly creates redundant work. Actually if it's really scanning the scavengable nmethods there then it's turning them into strong roots which is wrong. Only nmethods which are live on stack should be scanned as strong roots. Does anyone know why the test_set_oops_do_mark builds yet another linked list instead of just having a flag on the nmethod to indicate that it's claimed? It seems overly complicated. The contents of the list should be the same as the scavenge roots list and a simple flag would indicate whether it was marked or not. tom From y.s.ramakrishna at oracle.com Wed Mar 16 11:01:50 2011 From: y.s.ramakrishna at oracle.com (Y. S. Ramakrishna) Date: Wed, 16 Mar 2011 11:01:50 -0700 Subject: ScavengeRootsInCode In-Reply-To: References: Message-ID: <4D80FB0E.8040205@oracle.com> Hi Tom -- A form of the strong-scanning problem for the nmethod scanning] code existed for a while, long preceding ScavengeRootsInCode, and was fixed a while ago so that the code-cache scanning did not inadvertently turn code-oops into strong refs. I can see that a parameter do_strong_roots_only now distinguishes the two types of scans: being true for the active nmethods on thread stacks scan and false for the code-cache scan of all nmethods, where the refs are treated weakly. I think that the list of scavengeable nmethod scanning should also be done weakly. I believe that would also take care of the synchronization issue that you ran into below, since there is in fact a synchronization barrier between the strong roots scan which must semantically strictly precede the weak scan. It would seem as though one should do the oop relocations during the second, weak scan? I don't know the answers to your other questions, but I am guessing John Rose would. -- ramki On 03/16/11 10:35, Tom Rodriguez wrote: > I was getting ready to finish my statics fields in Class changes when I hit a failure with jbb and CMS. I've tracked it down to a race in the machinery for updating oop relocations and the logic for making sure that a scavengable nmethod is only scanned once. During a scavenge an nmethod can be reached for scanning in two different ways, either as a live activation on some thread stack or during the scan of scavengeable nmethods. The scan of scavengeable nmethods does two things though. It does the oops_do for the nmethod and then it calls fix_oop_relocations to update the generated code to match the new oop values. The problem is that the scan of the thread stacks and the scan of the scavengable nmethods are performed concurrently so the stack scanning thread might claim the nmethod first but actually scan the nmethod after the call to fix_oop_relocations in the other thread, leaving the oops valid but the code stale. > > I think the logical place to move the fix_oop_relocations call is into nmethod::oops_do_marking_epilogue. Does this seem reasonable to anyone who understands the new nmethod scavenge code better than I do? It seems to work fine. > > Actually one thing I noticed is that the nmethod::oops_do_marking_prologue/epiloque logic is being called during full gcs which seems somewhat pointless to me since it mostly creates redundant work. Actually if it's really scanning the scavengable nmethods there then it's turning them into strong roots which is wrong. Only nmethods which are live on stack should be scanned as strong roots. > > Does anyone know why the test_set_oops_do_mark builds yet another linked list instead of just having a flag on the nmethod to indicate that it's claimed? It seems overly complicated. The contents of the list should be the same as the scavenge roots list and a simple flag would indicate whether it was marked or not. > > tom From tom.rodriguez at oracle.com Wed Mar 16 11:18:52 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Wed, 16 Mar 2011 11:18:52 -0700 Subject: ScavengeRootsInCode In-Reply-To: <4D80FB0E.8040205@oracle.com> References: <4D80FB0E.8040205@oracle.com> Message-ID: <4D72F1C0-7AF0-4B40-9B68-AADF278F3DB1@oracle.com> On Mar 16, 2011, at 11:01 AM, Y. S. Ramakrishna wrote: > Hi Tom -- > > A form of the strong-scanning problem for the nmethod scanning] > code existed for a while, long preceding ScavengeRootsInCode, and > was fixed a while ago so that the code-cache scanning did not > inadvertently turn code-oops into strong refs. What issue do you mean? Not the MDO one? > I can see that > a parameter do_strong_roots_only now distinguishes the two types of scans: > being true for the active nmethods on thread stacks scan > and false for the code-cache scan of all nmethods, where the > refs are treated weakly. That flag only controls a very minor part of the weakness. Oops in the exception cache are weak because they can be dropped even if the nmethod is alive and those are the only oops that strong_roots_only controls. For all nmethods that don't have live activations, if any oop they reference isn't live after a strong scan then they will be unloaded. > I think that the list of scavengeable > nmethod scanning should also be done weakly. The list of scavengeable nmethods shouldn't be scanned at all during a full collection. The whole code cache is already scanned. By scanning it as strong root it can keep classes from being unloaded. Presumably over time nmethods will migrate off of the scavenge list but it's still incorrect. > I believe that would also take > care of the synchronization issue that you ran into below, > since there is in fact a synchronization > barrier between the strong roots scan which must semantically > strictly precede the weak scan. It would seem as though one > should do the oop relocations during the second, weak scan? There's no problem with full gc's because gc_epilogue fixes the oop relocations at the end. That also why scanning the scavengeable list is a total waste. Any work it does is a duplication of work that will be done anyway. tom > > I don't know the answers to your other questions, but I am guessing > John Rose would. > > -- ramki > > On 03/16/11 10:35, Tom Rodriguez wrote: >> I was getting ready to finish my statics fields in Class changes when I hit a failure with jbb and CMS. I've tracked it down to a race in the machinery for updating oop relocations and the logic for making sure that a scavengable nmethod is only scanned once. During a scavenge an nmethod can be reached for scanning in two different ways, either as a live activation on some thread stack or during the scan of scavengeable nmethods. The scan of scavengeable nmethods does two things though. It does the oops_do for the nmethod and then it calls fix_oop_relocations to update the generated code to match the new oop values. The problem is that the scan of the thread stacks and the scan of the scavengable nmethods are performed concurrently so the stack scanning thread might claim the nmethod first but actually scan the nmethod after the call to fix_oop_relocations in the other thread, leaving the oops valid but the code stale. >> I think the logical place to move the fix_oop_relocations call is into nmethod::oops_do_marking_epilogue. Does this seem reasonable to anyone who understands the new nmethod scavenge code better than I do? It seems to work fine. >> Actually one thing I noticed is that the nmethod::oops_do_marking_prologue/epiloque logic is being called during full gcs which seems somewhat pointless to me since it mostly creates redundant work. Actually if it's really scanning the scavengable nmethods there then it's turning them into strong roots which is wrong. Only nmethods which are live on stack should be scanned as strong roots. >> Does anyone know why the test_set_oops_do_mark builds yet another linked list instead of just having a flag on the nmethod to indicate that it's claimed? It seems overly complicated. The contents of the list should be the same as the scavenge roots list and a simple flag would indicate whether it was marked or not. >> tom From y.s.ramakrishna at oracle.com Wed Mar 16 11:33:31 2011 From: y.s.ramakrishna at oracle.com (Y. S. Ramakrishna) Date: Wed, 16 Mar 2011 11:33:31 -0700 Subject: ScavengeRootsInCode In-Reply-To: <4D72F1C0-7AF0-4B40-9B68-AADF278F3DB1@oracle.com> References: <4D80FB0E.8040205@oracle.com> <4D72F1C0-7AF0-4B40-9B68-AADF278F3DB1@oracle.com> Message-ID: <4D81027B.5070808@oracle.com> On 03/16/11 11:18, Tom Rodriguez wrote: > On Mar 16, 2011, at 11:01 AM, Y. S. Ramakrishna wrote: > >> Hi Tom -- >> >> A form of the strong-scanning problem for the nmethod scanning] >> code existed for a while, long preceding ScavengeRootsInCode, and >> was fixed a while ago so that the code-cache scanning did not >> inadvertently turn code-oops into strong refs. > > What issue do you mean? Not the MDO one? No, i think this is older; lost in the fog of history, i guess, so "a while ago" probably gave the wrong impression. >> I can see that >> a parameter do_strong_roots_only now distinguishes the two types of scans: >> being true for the active nmethods on thread stacks scan >> and false for the code-cache scan of all nmethods, where the >> refs are treated weakly. > > That flag only controls a very minor part of the weakness. Oops in the exception cache are weak because they can be dropped even if the nmethod is alive and those are the only oops that strong_roots_only controls. For all nmethods that don't have live activations, if any oop they reference isn't live after a strong scan then they will be unloaded. > Sure, but see SharedHeap::process_weak_roots() where CodeCache::blobs_do() is called. Clearly any relocations (if i understand that term correctly) must strictly follow the strong marking, which should happen off of process_strong_roots(). >> I think that the list of scavengeable >> nmethod scanning should also be done weakly. > > The list of scavengeable nmethods shouldn't be scanned at all during a full collection. The whole code cache is already scanned. By scanning it as strong root it can keep classes from being unloaded. Presumably over time nmethods will migrate off of the scavenge list but it's still incorrect. > I agree. But I was getting (further above) on the sequencing problem that you brought up (at least as i understood it). >> I believe that would also take >> care of the synchronization issue that you ran into below, >> since there is in fact a synchronization >> barrier between the strong roots scan which must semantically >> strictly precede the weak scan. It would seem as though one >> should do the oop relocations during the second, weak scan? > > There's no problem with full gc's because gc_epilogue fixes the oop relocations at the end. That also why scanning the scavengeable list is a total waste. Any work it does is a duplication of work that will be done anyway. > Yes, duplicated work is bad. Doing it once at the right place is a good idea. Anyway, I should stop because I very briefly helped John Rose with this initially a long time ago, and the code has probably changed a lot since then and I haven't really kept up. -- ramki > tom > >> I don't know the answers to your other questions, but I am guessing >> John Rose would. >> >> -- ramki >> >> On 03/16/11 10:35, Tom Rodriguez wrote: >>> I was getting ready to finish my statics fields in Class changes when I hit a failure with jbb and CMS. I've tracked it down to a race in the machinery for updating oop relocations and the logic for making sure that a scavengable nmethod is only scanned once. During a scavenge an nmethod can be reached for scanning in two different ways, either as a live activation on some thread stack or during the scan of scavengeable nmethods. The scan of scavengeable nmethods does two things though. It does the oops_do for the nmethod and then it calls fix_oop_relocations to update the generated code to match the new oop values. The problem is that the scan of the thread stacks and the scan of the scavengable nmethods are performed concurrently so the stack scanning thread might claim the nmethod first but actually scan the nmethod after the call to fix_oop_relocations in the other thread, leaving the oops valid but the code stale. >>> I think the logical place to move the fix_oop_relocations call is into nmethod::oops_do_marking_epilogue. Does this seem reasonable to anyone who understands the new nmethod scavenge code better than I do? It seems to work fine. >>> Actually one thing I noticed is that the nmethod::oops_do_marking_prologue/epiloque logic is being called during full gcs which seems somewhat pointless to me since it mostly creates redundant work. Actually if it's really scanning the scavengable nmethods there then it's turning them into strong roots which is wrong. Only nmethods which are live on stack should be scanned as strong roots. >>> Does anyone know why the test_set_oops_do_mark builds yet another linked list instead of just having a flag on the nmethod to indicate that it's claimed? It seems overly complicated. The contents of the list should be the same as the scavenge roots list and a simple flag would indicate whether it was marked or not. >>> tom > From y.s.ramakrishna at oracle.com Wed Mar 16 13:49:51 2011 From: y.s.ramakrishna at oracle.com (y.s.ramakrishna at oracle.com) Date: Wed, 16 Mar 2011 20:49:51 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6896099: Integrate CMS heap ergo with default heap sizing ergo; ... Message-ID: <20110316204953.162BD471E6@hg.openjdk.java.net> Changeset: dde920245681 Author: ysr Date: 2011-03-16 10:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/dde920245681 6896099: Integrate CMS heap ergo with default heap sizing ergo 6627787: CMS: JVM refuses to start up with -Xms16m -Xmx16m 7000125: CMS: Anti-monotone young gen sizing with respect to maximum whole heap size specification 7027529: CMS: retire CMSUseOldDefaults flag Summary: Simplify CMS heap sizing code, relying on ergonomic initial sizing consistent with other collectors for the most part, controlling only young gen sizing to rein in pause times. Make CMS young gen sizing default statically cpu-dependant. Remove inconsistencies wrt generation sizing and policy code, allowing for the fixing for 6627787 and 7000125. For 7027529, retire the flag CMSUseOldDefaults which had been introduced as a bridge from JDK 5 to JDK 6 a number of years ago. Reviewed-by: brutisso, poonam ! src/cpu/sparc/vm/globals_sparc.hpp ! src/cpu/x86/vm/globals_x86.hpp ! src/share/vm/memory/collectorPolicy.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp From y.s.ramakrishna at oracle.com Thu Mar 17 14:41:08 2011 From: y.s.ramakrishna at oracle.com (y.s.ramakrishna at oracle.com) Date: Thu, 17 Mar 2011 21:41:08 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6668573: CMS: reference processing crash if ParallelCMSThreads > ParallelGCThreads Message-ID: <20110317214111.1540B4722D@hg.openjdk.java.net> Changeset: 92da084fefc9 Author: ysr Date: 2011-03-17 10:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/92da084fefc9 6668573: CMS: reference processing crash if ParallelCMSThreads > ParallelGCThreads Summary: Use _max_num_q = max(discovery_degree, processing_degree), and let balance_queues() redistribute from discovery_degree to processing_degree of queues. This should also allow a more dynamic and flexible parallelism policy in the future. Reviewed-by: jmasa, johnc ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.hpp ! src/share/vm/gc_implementation/g1/concurrentMark.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/parNew/parNewGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psMarkSweep.cpp ! src/share/vm/gc_implementation/parallelScavenge/psParallelCompact.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/memory/generation.cpp ! src/share/vm/memory/referenceProcessor.cpp ! src/share/vm/memory/referenceProcessor.hpp ! src/share/vm/utilities/workgroup.cpp ! src/share/vm/utilities/workgroup.hpp From john.coomes at oracle.com Thu Mar 17 20:42:33 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 Mar 2011 03:42:33 +0000 Subject: hg: jdk7/hotspot-gc: Added tag jdk7-b134 for changeset ddc2fcb3682f Message-ID: <20110318034233.839AB47257@hg.openjdk.java.net> Changeset: 168d9382ebab Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/rev/168d9382ebab Added tag jdk7-b134 for changeset ddc2fcb3682f ! .hgtags From john.coomes at oracle.com Thu Mar 17 20:42:40 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 Mar 2011 03:42:40 +0000 Subject: hg: jdk7/hotspot-gc/corba: Added tag jdk7-b134 for changeset 918003855fa0 Message-ID: <20110318034243.DF4E847258@hg.openjdk.java.net> Changeset: e0b72ae5dc5e Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/corba/rev/e0b72ae5dc5e Added tag jdk7-b134 for changeset 918003855fa0 ! .hgtags From john.coomes at oracle.com Thu Mar 17 20:42:51 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 Mar 2011 03:42:51 +0000 Subject: hg: jdk7/hotspot-gc/jaxp: 7 new changesets Message-ID: <20110318034251.70E1747259@hg.openjdk.java.net> Changeset: 877fd25c5a2f Author: ohair Date: 2011-03-02 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/877fd25c5a2f 7023289: jaxp 1.4.5 development jdk7 2nd integration Reviewed-by: joehw, mchung, alanb ! jaxp.properties Changeset: b693ccf23fb7 Author: lana Date: 2011-03-07 11:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/b693ccf23fb7 Merge Changeset: 02d4672e8c05 Author: lana Date: 2011-03-10 20:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/02d4672e8c05 Merge Changeset: e8be6b716643 Author: ohair Date: 2011-03-10 13:21 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/e8be6b716643 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung ! make/Makefile Changeset: 1259c6d09d09 Author: mfang Date: 2011-03-14 12:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/1259c6d09d09 Merge Changeset: d56b326ae054 Author: ohair Date: 2011-03-15 15:31 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/d56b326ae054 Merge Changeset: 4aa9916693dc Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxp/rev/4aa9916693dc Added tag jdk7-b134 for changeset d56b326ae054 ! .hgtags From john.coomes at oracle.com Thu Mar 17 20:42:58 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 Mar 2011 03:42:58 +0000 Subject: hg: jdk7/hotspot-gc/jaxws: 3 new changesets Message-ID: <20110318034258.5446F4725A@hg.openjdk.java.net> Changeset: ba12732b1453 Author: ohair Date: 2011-03-10 13:22 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/ba12732b1453 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung ! make/Makefile Changeset: 545de8303fec Author: mfang Date: 2011-03-14 12:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/545de8303fec Merge Changeset: d5fc61f18043 Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jaxws/rev/d5fc61f18043 Added tag jdk7-b134 for changeset 545de8303fec ! .hgtags From john.coomes at oracle.com Thu Mar 17 20:46:41 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 Mar 2011 03:46:41 +0000 Subject: hg: jdk7/hotspot-gc/jdk: 90 new changesets Message-ID: <20110318040226.8454A47262@hg.openjdk.java.net> Changeset: 864b669d54d8 Author: lana Date: 2011-02-21 19:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/864b669d54d8 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/share/demo/zipfs - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 196d6e802721 Author: prr Date: 2011-02-28 10:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/196d6e802721 7004728: [parfait] potential memory leaks in XRender code Reviewed-by: bae, ceisserer ! src/solaris/native/sun/java2d/x11/XRBackendNative.c Changeset: bbbf427a9007 Author: ceisserer Date: 2011-03-01 14:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bbbf427a9007 6974985: Jave2Demo threw exceptions when xrender enabled in OEL5.5 Reviewed-by: prr ! make/sun/awt/mapfile-mawt-vers ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/java2d/xr/XRSurfaceData.java ! src/solaris/native/sun/java2d/x11/X11SurfaceData.c ! src/solaris/native/sun/java2d/x11/XRSurfaceData.c Changeset: 01dcb496946e Author: ceisserer Date: 2011-03-03 16:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/01dcb496946e 7023589: Xrender : NullPointerException in sun.font.XRGlyphCache.freeGlyphs running Java 2D demo Reviewed-by: prr ! src/share/classes/sun/font/StrikeCache.java ! src/solaris/classes/sun/font/XRGlyphCache.java Changeset: f82f0af7de5b Author: prr Date: 2011-03-04 15:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f82f0af7de5b 7023591: Xrender: java2D font demo - text highlighting tab content is black Reviewed-by: flar ! src/share/classes/sun/java2d/pipe/AAShapePipe.java Changeset: 1356371db8c9 Author: lana Date: 2011-03-06 23:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1356371db8c9 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java Changeset: df0de56682b7 Author: dcherepanov Date: 2011-02-24 13:01 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/df0de56682b7 6996708: The event on the tray icon does not trigger and there is no message printed. Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_TrayIcon.cpp Changeset: 75d8c1200df8 Author: dcherepanov Date: 2011-02-25 13:58 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/75d8c1200df8 7020522: Need to reapply the fix for 6664512 Reviewed-by: art, mchung ! src/share/classes/sun/util/logging/PlatformLogger.java Changeset: c27520009762 Author: dcherepanov Date: 2011-02-25 15:33 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c27520009762 7009114: GTK FileDialog lies about it's Bounds Reviewed-by: art, anthony ! make/sun/xawt/mapfile-vers ! src/solaris/classes/sun/awt/X11/GtkFileDialogPeer.java ! src/solaris/native/sun/awt/gtk2_interface.c ! src/solaris/native/sun/awt/gtk2_interface.h ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.c ! src/solaris/native/sun/awt/sun_awt_X11_GtkFileDialogPeer.h Changeset: de0f2f8563eb Author: lana Date: 2011-02-26 23:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/de0f2f8563eb Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/share/demo/zipfs - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: 024d040af4a3 Author: anthony Date: 2011-03-01 13:49 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/024d040af4a3 7022488: The security warning may disappear unexpectedly Summary: Initialize the fullScreenExclusiveModeState flag in the AwtWindow constructor Reviewed-by: art, dcherepanov ! src/windows/native/sun/windows/awt_Window.cpp Changeset: b5e609488bc8 Author: dcherepanov Date: 2011-03-01 15:24 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b5e609488bc8 6826397: PIT : Frame System Menu is not seen for when ALT + Space Bar is pressed in jdk7 b55 build. Reviewed-by: art, ant ! src/windows/native/sun/windows/awt_Frame.cpp ! src/windows/native/sun/windows/awt_Frame.h Changeset: 8cd20d3e5448 Author: lana Date: 2011-03-06 20:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8cd20d3e5448 Merge - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - test/java/lang/Thread/StopBeforeStart.java Changeset: 333bd91466bd Author: lana Date: 2011-03-07 14:44 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/333bd91466bd Merge ! make/sun/xawt/mapfile-vers Changeset: f8fdf9bca159 Author: okutsu Date: 2011-02-22 14:51 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f8fdf9bca159 7010379: fontconfig update for RHEL 6 Reviewed-by: peytoia ! make/sun/awt/Makefile Changeset: 5957bd3cfdc3 Author: okutsu Date: 2011-02-23 14:09 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5957bd3cfdc3 6623219: Font.canDisplayUpTo does not work with supplementary characters Reviewed-by: prr, peytoia ! src/share/classes/java/awt/Font.java + test/java/awt/FontClass/SurrogateTest/SupplementaryCanDisplayUpToTest.java Changeset: 30d112b3b6f2 Author: okutsu Date: 2011-02-23 16:50 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/30d112b3b6f2 6955047: (tz) javadoc for TimeZone.getDisplayName(boolean daylight, int style, Locale locale) is not clear 7021680: (tz) daylight savings time should be daylight saving time Reviewed-by: peytoia ! src/share/classes/java/util/Calendar.java ! src/share/classes/java/util/GregorianCalendar.java ! src/share/classes/java/util/TimeZone.java Changeset: ff611d9474cb Author: okutsu Date: 2011-02-24 15:09 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ff611d9474cb 7021989: Missing observesDaylightTime override in ZoneInfo Reviewed-by: peytoia ! src/share/classes/sun/util/calendar/ZoneInfo.java Changeset: 01c752a48b51 Author: okutsu Date: 2011-02-24 16:29 +0900 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/01c752a48b51 6772689: java.sql.Date.valueOf("2042-10-xx").toString() wrong in some time zones Reviewed-by: peytoia ! src/share/classes/sun/util/calendar/ZoneInfo.java + test/java/util/TimeZone/Bug6772689.java Changeset: e390ce4509c6 Author: alexp Date: 2011-02-28 18:20 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e390ce4509c6 6826074: JScrollPane does not revalidate the component hierarchy after scrolling Reviewed-by: anthony ! src/share/classes/javax/swing/DefaultDesktopManager.java ! src/share/classes/javax/swing/JViewport.java Changeset: 1ef5b85d41f2 Author: amenkov Date: 2011-02-28 18:36 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1ef5b85d41f2 7013521: AudioSystem.write for AIFF files closes source audio stream Reviewed-by: dav ! src/share/classes/com/sun/media/sound/AiffFileWriter.java ! src/share/classes/com/sun/media/sound/AuFileWriter.java ! src/share/classes/com/sun/media/sound/SunFileWriter.java ! src/share/classes/com/sun/media/sound/WaveFileWriter.java + test/javax/sound/sampled/FileWriter/WriterCloseInput.java Changeset: d4e3c1f2177a Author: amenkov Date: 2011-03-03 15:41 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d4e3c1f2177a 6938426: Concurrency bug in ALAW encoder causes random bursts of static/noise in output. Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/AlawCodec.java + test/javax/sound/sampled/FileWriter/AlawEncoderSync.java Changeset: d3df100509ad Author: amenkov Date: 2011-03-03 15:45 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d3df100509ad 6801206: SoundTestSuite: test050 fails Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/DirectAudioDevice.java + test/javax/sound/sampled/Clip/ClipSetPos.java Changeset: 4e732aba71bf Author: amenkov Date: 2011-03-03 15:57 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/4e732aba71bf 6660470: RealTimeSequencer incorrectly opens (implicitly) synthesizer Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/RealTimeSequencer.java ! src/share/classes/javax/sound/midi/MidiSystem.java + test/javax/sound/midi/Sequencer/SequencerImplicitSynthOpen.java Changeset: 67d4b2e2e5b1 Author: amenkov Date: 2011-03-03 16:40 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/67d4b2e2e5b1 6835393: MidiSystem fails to correctly read Sequence with SMPTE division Reviewed-by: stayer ! src/share/classes/com/sun/media/sound/StandardMidiFileReader.java + test/javax/sound/midi/File/SMPTESequence.java Changeset: 52bdb4237d5e Author: rupashka Date: 2011-03-03 17:47 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/52bdb4237d5e 6796710: Html content in JEditorPane is overlapping on swing components while resizing the application. Reviewed-by: alexp ! src/share/classes/javax/swing/text/html/CSSBorder.java + test/javax/swing/regtesthelpers/Util.java + test/javax/swing/text/CSSBorder/6796710/bug6796710.java Changeset: 7dfcf271b73b Author: alexp Date: 2011-03-03 18:23 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7dfcf271b73b 6653511: JComponent.safelyGetGraphics() may sometimes return null Reviewed-by: rupashka ! src/share/classes/javax/swing/JComponent.java Changeset: e4ca9353150a Author: alexp Date: 2011-03-03 18:27 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e4ca9353150a Merge Changeset: dc34da6a3fa1 Author: rupashka Date: 2011-03-05 18:27 +0300 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dc34da6a3fa1 6760148: Certain fonts are not correctly soft wrapped when using JTextComponent.print() Reviewed-by: peterz ! src/share/classes/javax/swing/text/Utilities.java ! src/share/classes/javax/swing/text/WrappedPlainView.java Changeset: ca0f223b4be7 Author: lana Date: 2011-03-05 20:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/ca0f223b4be7 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java - src/share/classes/java/io/TempFileHelper.java - src/share/classes/java/nio/file/FileRef.java - src/share/classes/java/nio/file/attribute/Attributes.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributeView.java - src/share/classes/java/nio/file/attribute/FileStoreSpaceAttributes.java ! src/share/classes/javax/swing/JComponent.java - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/share/demo/zipfs - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc - test/java/lang/Thread/StopBeforeStart.java - test/java/nio/file/Files/ContentType.java - test/java/nio/file/Files/CreateFileTree.java - test/java/nio/file/Files/ForceLoad.java - test/java/nio/file/Files/META-INF/services/java.nio.file.spi.FileTypeDetector - test/java/nio/file/Files/MaxDepth.java - test/java/nio/file/Files/PrintFileTree.java - test/java/nio/file/Files/SimpleFileTypeDetector.java - test/java/nio/file/Files/SkipSiblings.java - test/java/nio/file/Files/TerminateWalk.java - test/java/nio/file/Files/WalkWithSecurity.java - test/java/nio/file/Files/denyAll.policy - test/java/nio/file/Files/grantAll.policy - test/java/nio/file/Files/grantTopOnly.policy - test/java/nio/file/Files/walk_file_tree.sh - test/java/nio/file/Path/CheckPermissions.java - test/java/nio/file/Path/CopyAndMove.java - test/java/nio/file/Path/DeleteOnClose.java - test/java/nio/file/Path/FileAttributes.java - test/java/nio/file/Path/InterruptCopy.java - test/java/nio/file/Path/Links.java - test/java/nio/file/Path/PassThroughFileSystem.java - test/java/nio/file/Path/SBC.java - test/java/nio/file/Path/TemporaryFiles.java - test/java/nio/file/Path/delete_on_close.sh - test/java/nio/file/attribute/FileStoreAttributeView/Basic.java Changeset: e3a69b9be2b5 Author: lana Date: 2011-03-07 14:46 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/e3a69b9be2b5 Merge Changeset: d26e79640fd4 Author: mduigou Date: 2011-02-21 14:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d26e79640fd4 7019705: Add -XX:+AggressiveOpts options to MOAT test Reviewed-by: alanb ! test/java/util/Collection/MOAT.java Changeset: dbdafe65af60 Author: alanb Date: 2011-02-21 13:54 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/dbdafe65af60 7020517: (fs) FileStore.equals returns true if both volumes have the same serial number Reviewed-by: chegar ! src/windows/classes/sun/nio/fs/WindowsFileStore.java ! test/java/nio/file/FileStore/Basic.java Changeset: d7cb44a4d08a Author: alanb Date: 2011-02-22 10:19 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d7cb44a4d08a Merge Changeset: 9d8a0369b906 Author: alanb Date: 2011-02-22 12:04 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9d8a0369b906 7020888: (file) Miscellaneous and trivial clean-ups (typos and opportunities to use suppressed exceptions) Reviewed-by: mduigou, chegar ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/File.java ! src/share/classes/java/io/FilterOutputStream.java ! src/share/classes/java/io/PushbackInputStream.java ! src/share/classes/java/io/PushbackReader.java ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/share/classes/java/nio/channels/SocketChannel.java ! src/share/classes/java/nio/file/CopyMoveHelper.java ! src/share/classes/java/nio/file/Files.java ! src/share/classes/sun/nio/ch/FileChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousServerSocketChannelImpl.java ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! test/java/lang/ProcessBuilder/Basic.java Changeset: bac152c6491a Author: alanb Date: 2011-02-22 14:28 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bac152c6491a 7021327: Changes for 7020888 included changes to other files in error Reviewed-by: chegar ! src/share/classes/java/io/BufferedReader.java ! src/share/classes/java/io/BufferedWriter.java ! src/share/classes/java/io/FilterOutputStream.java ! src/share/classes/java/io/PushbackInputStream.java ! src/share/classes/java/io/PushbackReader.java ! test/java/lang/ProcessBuilder/Basic.java Changeset: b853414b8eef Author: michaelm Date: 2011-02-22 14:44 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b853414b8eef 6702400: ChunkedInputStream expecting -1 from int read, but int->char comparision is wrong Reviewed-by: chegar ! src/share/classes/sun/net/httpserver/ChunkedInputStream.java Changeset: 75216854fb53 Author: valeriep Date: 2011-02-22 12:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/75216854fb53 6604496: Support for CKM_AES_CTR (counter mode) Summary: Enhanced SunPKCS11 provider to support AES/CTR/NoPadding transformation. Reviewed-by: vinnie ! src/share/classes/sun/security/pkcs11/P11Cipher.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java + src/share/classes/sun/security/pkcs11/wrapper/CK_AES_CTR_PARAMS.java ! src/share/classes/sun/security/pkcs11/wrapper/CK_MECHANISM.java ! src/share/classes/sun/security/pkcs11/wrapper/PKCS11Constants.java ! src/share/native/sun/security/pkcs11/wrapper/p11_convert.c + src/share/native/sun/security/pkcs11/wrapper/pkcs-11v2-20a3.h ! src/share/native/sun/security/pkcs11/wrapper/pkcs11wrapper.h ! test/sun/security/pkcs11/Cipher/TestSymmCiphers.java ! test/sun/security/pkcs11/Cipher/TestSymmCiphersNoPad.java Changeset: 84e339f1033b Author: smarks Date: 2011-02-22 15:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/84e339f1033b 7021209: convert lang, math, util to use try-with-resources Reviewed-by: alanb, darcy, naoto ! src/share/classes/java/lang/Package.java ! src/share/classes/java/util/Currency.java ! src/share/classes/sun/util/calendar/LocalGregorianCalendar.java ! src/solaris/classes/java/util/prefs/FileSystemPreferences.java ! test/java/lang/Character/CheckScript.java ! test/java/lang/Runtime/shutdown/ShutdownHooks.java ! test/java/lang/instrument/BootClassPath/Setup.java ! test/java/lang/instrument/ilib/Inject.java ! test/java/math/BigInteger/BigIntegerTest.java ! test/java/util/Currency/ValidateISO4217.java ! test/java/util/Formatter/FailingConstructors.java ! test/java/util/Locale/LocaleEnhanceTest.java ! test/java/util/ResourceBundle/Bug6204853.java ! test/java/util/Scanner/FailingConstructors.java Changeset: 892c3fc7249e Author: dl Date: 2011-02-23 14:56 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/892c3fc7249e 7017493: ConcurrentLinkedDeque: Unexpected initialization order can lead to crash due to use of Unsafe Reviewed-by: chegar ! src/share/classes/java/util/concurrent/ConcurrentLinkedDeque.java ! src/share/classes/java/util/concurrent/ConcurrentLinkedQueue.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListMap.java ! src/share/classes/java/util/concurrent/ConcurrentSkipListSet.java ! src/share/classes/java/util/concurrent/CopyOnWriteArrayList.java ! src/share/classes/java/util/concurrent/LinkedTransferQueue.java ! src/share/classes/java/util/concurrent/Phaser.java ! src/share/classes/java/util/concurrent/PriorityBlockingQueue.java ! src/share/classes/java/util/concurrent/SynchronousQueue.java Changeset: 744c2773e3f7 Author: lana Date: 2011-02-23 10:29 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/744c2773e3f7 Merge - make/sun/jkernel/FILES_c_windows.gmk - make/sun/jkernel/FILES_java.gmk - make/sun/jkernel/Makefile - src/share/classes/sun/jkernel/BackgroundDownloader.java - src/share/classes/sun/jkernel/Bundle.java - src/share/classes/sun/jkernel/BundleCheck.java - src/share/classes/sun/jkernel/ByteArrayToFromHexDigits.java - src/share/classes/sun/jkernel/DigestOutputStream.java - src/share/classes/sun/jkernel/DownloadManager.java - src/share/classes/sun/jkernel/KernelError.java - src/share/classes/sun/jkernel/Mutex.java - src/share/classes/sun/jkernel/StandaloneByteArrayAccess.java - src/share/classes/sun/jkernel/StandaloneMessageDigest.java - src/share/classes/sun/jkernel/StandaloneSHA.java - src/windows/native/sun/jkernel/DownloadDialog.cpp - src/windows/native/sun/jkernel/DownloadDialog.h - src/windows/native/sun/jkernel/DownloadHelper.cpp - src/windows/native/sun/jkernel/DownloadHelper.h - src/windows/native/sun/jkernel/graphics/bullet.bmp - src/windows/native/sun/jkernel/graphics/cautionshield32.bmp - src/windows/native/sun/jkernel/graphics/java-icon.ico - src/windows/native/sun/jkernel/graphics/masthead.bmp - src/windows/native/sun/jkernel/graphics/warningmasthead.bmp - src/windows/native/sun/jkernel/kernel.cpp - src/windows/native/sun/jkernel/kernel.def - src/windows/native/sun/jkernel/kernel.h - src/windows/native/sun/jkernel/kernel.rc - src/windows/native/sun/jkernel/kernel_de.rc - src/windows/native/sun/jkernel/kernel_en.rc - src/windows/native/sun/jkernel/kernel_es.rc - src/windows/native/sun/jkernel/kernel_fr.rc - src/windows/native/sun/jkernel/kernel_it.rc - src/windows/native/sun/jkernel/kernel_ja.rc - src/windows/native/sun/jkernel/kernel_ko.rc - src/windows/native/sun/jkernel/kernel_pt_BR.rc - src/windows/native/sun/jkernel/kernel_sv.rc - src/windows/native/sun/jkernel/kernel_zh.rc - src/windows/native/sun/jkernel/kernel_zh_TW.rc - src/windows/native/sun/jkernel/resource.h - src/windows/native/sun/jkernel/stdafx.cpp - src/windows/native/sun/jkernel/stdafx.h - src/windows/native/sun/jkernel/version.rc ! test/java/util/Locale/LocaleEnhanceTest.java Changeset: 0f0d6b8f98cc Author: wetmore Date: 2011-02-23 22:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0f0d6b8f98cc 6844879: Source distribution should be more robustly built without the security source distribution Reviewed-by: ohair ! make/common/shared/Defs-java.gmk Changeset: c2c8f9c38fd1 Author: chegar Date: 2011-02-24 12:57 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c2c8f9c38fd1 7020136: java/net/URLConnection/RedirectLimit.java fails intermittently Summary: Increase the socket timeout and clean up the test Reviewed-by: alanb ! test/java/net/URLConnection/RedirectLimit.java Changeset: 1f41e41ef2db Author: chegar Date: 2011-02-24 13:42 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1f41e41ef2db 6849693: index of fdTable should be less than num. of fdTable in jdk7 Reviewed-by: alanb ! src/solaris/native/java/net/linux_close.c Changeset: 51ef29aafc1b Author: michaelm Date: 2011-02-24 18:35 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/51ef29aafc1b 6835668: Use of /usr/include/linux/ files creates a dependence on kernel-headers Reviewed-by: chegar ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/PlainDatagramSocketImpl.c ! src/solaris/native/java/net/PlainSocketImpl.c Changeset: b74f1b830484 Author: smarks Date: 2011-02-24 22:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b74f1b830484 7022383: add reference to CR for ReadLongZipFileName test to problem list Reviewed-by: ohair ! test/ProblemList.txt Changeset: 32dc1cb2b995 Author: mchung Date: 2011-02-25 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/32dc1cb2b995 7021939: com.oracle.net is not a NON_CORE_PKGS Reviewed-by: ohair, alanb ! make/common/Release.gmk ! make/docs/NON_CORE_PKGS.gmk Changeset: 5dc98de2a35e Author: mchung Date: 2011-02-25 12:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/5dc98de2a35e 7016707: Remove the BootClassLoaderHook for jkernel support Reviewed-by: alanb, ohair ! make/java/java/FILES_java.gmk ! src/share/classes/java/awt/color/ICC_Profile.java ! src/share/classes/java/lang/ClassLoader.java ! src/share/classes/java/util/zip/ZipEntry.java - src/share/classes/sun/misc/BootClassLoaderHook.java ! src/share/classes/sun/misc/Launcher.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: 8887cb2f5d19 Author: smarks Date: 2011-02-25 02:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/8887cb2f5d19 7021582: convert jar/zip code and tests to use try-with-resources Reviewed-by: alanb, dholmes, sherman ! src/share/classes/java/util/jar/JarFile.java ! test/java/util/jar/JarEntry/GetMethodsReturnClones.java ! test/java/util/jar/JarFile/ScanSignedJar.java ! test/java/util/zip/Available.java ! test/java/util/zip/FileBuilder.java ! test/java/util/zip/GZIP/Accordion.java ! test/java/util/zip/GZIP/GZIPInputStreamRead.java ! test/java/util/zip/InflateIn_DeflateOut.java ! test/java/util/zip/InfoZip.java ! test/java/util/zip/LargeZip.java ! test/java/util/zip/TestEmptyZip.java ! test/java/util/zip/ZipCoding.java ! test/java/util/zip/ZipFile/Assortment.java ! test/java/util/zip/ZipFile/Comment.java ! test/java/util/zip/ZipFile/CopyJar.java ! test/java/util/zip/ZipFile/CorruptedZipFiles.java ! test/java/util/zip/ZipFile/DeleteTempJar.java ! test/java/util/zip/ZipFile/EnumAfterClose.java ! test/java/util/zip/ZipFile/GetDirEntry.java ! test/java/util/zip/ZipFile/LargeZipFile.java ! test/java/util/zip/ZipFile/ManyEntries.java ! test/java/util/zip/ZipFile/ManyZipFiles.java ! test/java/util/zip/ZipFile/ReadAfterClose.java ! test/java/util/zip/ZipFile/ReadZip.java ! test/java/util/zip/ZipFile/ShortRead.java ! test/java/util/zip/zip.java Changeset: 29f25ba547fc Author: chegar Date: 2011-02-28 11:03 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/29f25ba547fc 7022269: clean up fscanf usage in Linux networking native code Reviewed-by: michaelm, alanb ! src/solaris/native/java/net/NetworkInterface.c ! src/solaris/native/java/net/net_util_md.c Changeset: a3b6c262195b Author: dholmes Date: 2011-02-28 06:40 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a3b6c262195b 7022386: gethostbyname_r needs a pointer aligned buffer passed to it Summary: Change buffer type to ensure pointer-alignment Reviewed-by: alanb, chegar ! src/solaris/native/java/net/Inet4AddressImpl.c Changeset: f4613b378874 Author: weijun Date: 2011-02-28 23:02 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f4613b378874 7021789: Remove jarsigner -crl option Reviewed-by: mullan ! src/share/classes/com/sun/jarsigner/ContentSignerParameters.java ! src/share/classes/java/security/CodeSigner.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java ! src/share/classes/sun/misc/SharedSecrets.java ! src/share/classes/sun/security/tools/JarSigner.java ! src/share/classes/sun/security/tools/JarSignerResources.java ! src/share/classes/sun/security/tools/KeyTool.java ! src/share/classes/sun/security/tools/TimestampedSigner.java ! src/share/classes/sun/security/util/SignatureFileVerifier.java ! test/sun/security/tools/jarsigner/crl.sh Changeset: f8bf888edf20 Author: weijun Date: 2011-03-01 16:22 +0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f8bf888edf20 7020531: test: java/security/cert/CertificateFactory/openssl/OpenSSLCert.java file not closed after run Reviewed-by: alanb, smarks ! test/ProblemList.txt ! test/java/security/cert/CertificateFactory/openssl/OpenSSLCert.java ! test/sun/security/tools/keytool/NewSize7.java Changeset: b7e763a573a4 Author: alanb Date: 2011-03-01 12:03 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b7e763a573a4 7023034: Files.createTempDirectory((Path)null, "temp") does not throw NPE Reviewed-by: forax ! src/share/classes/java/nio/file/Files.java ! test/java/nio/file/Files/TemporaryFiles.java Changeset: 98d2d57d9e73 Author: smarks Date: 2011-03-01 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/98d2d57d9e73 7022624: use try-with-resources in java.io tests Reviewed-by: alanb ! test/java/io/File/SetLastModified.java ! test/java/io/FileOutputStream/AtomicAppend.java ! test/java/io/OutputStreamWriter/Encode.java ! test/java/io/PrintStream/EncodingConstructor.java ! test/java/io/PrintStream/FailingConstructors.java ! test/java/io/Serializable/evolution/RenamePackage/install/SerialDriver.java ! test/java/io/Serializable/evolution/RenamePackage/test/SerialDriver.java Changeset: 895687e879ca Author: alanb Date: 2011-03-02 16:56 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/895687e879ca 7021987: native2ascii "file cannot be read" error message is broken Reviewed-by: lancea, mchung ! src/share/classes/sun/tools/native2ascii/Main.java ! test/sun/tools/native2ascii/Native2AsciiTests.sh Changeset: 75064373ed6b Author: michaelm Date: 2011-03-03 15:34 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/75064373ed6b 7018606: (process) test/java/lang/ProcessBuilder/Basic.java failing intermittently (win) Reviewed-by: alanb ! test/java/lang/ProcessBuilder/Basic.java Changeset: 7cfb0693eb33 Author: chegar Date: 2011-03-03 16:44 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7cfb0693eb33 7018137: HTML4 compliance issues Summary: move end list items tags to after nested list Reviewed-by: alanb ! src/share/classes/java/net/URI.java ! src/share/classes/java/net/package.html Changeset: 9b99a14375bc Author: chegar Date: 2011-03-03 16:48 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/9b99a14375bc 6721694: java/lang/Thread/StartOOMTest.java fails with timeout or with crash Summary: the test is not suitable to be run automatically Reviewed-by: alanb ! test/java/lang/Thread/StartOOMTest.java Changeset: 732faed56eb0 Author: coffeys Date: 2011-03-03 16:51 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/732faed56eb0 6750362: Very large LDAP requests throw a OOM on LDAP servers which aren't aware of Paged Results Controls 6748156: add an new JNDI property to control the boolean flag WaitForReply Reviewed-by: vinnie, robm ! src/share/classes/com/sun/jndi/ldap/Connection.java ! src/share/classes/com/sun/jndi/ldap/LdapClient.java ! src/share/classes/com/sun/jndi/ldap/LdapCtx.java ! src/share/classes/com/sun/jndi/ldap/LdapRequest.java + test/com/sun/jndi/ldap/NoWaitForReplyTest.java Changeset: 0bd32f96187d Author: coffeys Date: 2011-03-03 17:00 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0bd32f96187d Merge Changeset: b645b5bc460b Author: michaelm Date: 2011-03-03 17:14 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b645b5bc460b 7024264: HttpURLConnection/NetPermission doc issue Reviewed-by: chegar ! src/share/classes/java/net/HttpURLConnection.java ! src/share/classes/java/net/NetPermission.java Changeset: 6e596210bf01 Author: michaelm Date: 2011-03-03 17:16 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6e596210bf01 Merge Changeset: 2fb9e2d4ef46 Author: alanb Date: 2011-03-04 09:29 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/2fb9e2d4ef46 6944810: (ch) Assert failure in sun.nio.ch.PendingIoCache.clearPendingIoMap [win] Reviewed-by: chegar ! src/share/classes/java/nio/channels/AsynchronousFileChannel.java ! src/windows/classes/sun/nio/ch/PendingIoCache.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java ! src/windows/classes/sun/nio/ch/WindowsAsynchronousSocketChannelImpl.java ! test/ProblemList.txt Changeset: 259011d14d48 Author: alanb Date: 2011-03-04 09:33 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/259011d14d48 Merge Changeset: c4bd93431a20 Author: ksrini Date: 2011-03-04 09:32 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c4bd93431a20 7023963: (misc) fix diamond anon instances in the jdk Reviewed-by: alanb, mchung, mcimadamore, dholmes ! src/share/classes/com/sun/java/util/jar/pack/PackageReader.java ! src/share/classes/com/sun/java/util/jar/pack/PackageWriter.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipDirectoryStream.java ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipPath.java Changeset: 90b7926884a8 Author: sherman Date: 2011-03-04 11:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/90b7926884a8 7023244: (zipfs) langtools CompileTest fails on read-only file system Summary: replaced checkAccess with Files.isWritable() Reviewed-by: alanb ! src/share/demo/nio/zipfs/src/com/sun/nio/zipfs/ZipFileSystem.java Changeset: 7b6ad3027f3d Author: alanb Date: 2011-03-04 21:26 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/7b6ad3027f3d 7023403: (ch) sun.nio.ch.SolarisEventPort.startPoll failed with AssertionError Reviewed-by: forax ! src/solaris/classes/sun/nio/ch/UnixAsynchronousSocketChannelImpl.java ! test/java/nio/channels/AsynchronousSocketChannel/Basic.java Changeset: 28bedf6eba87 Author: alanb Date: 2011-03-04 21:28 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/28bedf6eba87 Merge Changeset: 339342f311cc Author: coffeys Date: 2011-03-07 14:43 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/339342f311cc 7025105: TEST_BUG test/com/sun/jndi/ldap/NoWaitForReplyTest.java should be cleaned up Reviewed-by: alanb ! test/com/sun/jndi/ldap/NoWaitForReplyTest.java Changeset: bc0c58d65e97 Author: mullan Date: 2011-03-07 13:20 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/bc0c58d65e97 7022467: SecretKeyFactory doesn't support algorithm "AES" on Windows and Linux Reviewed-by: wetmore, valeriep ! src/share/classes/javax/crypto/SecretKeyFactory.java Changeset: 62b0337d1369 Author: mullan Date: 2011-03-07 13:44 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/62b0337d1369 Merge Changeset: 6d5a992dbac2 Author: lana Date: 2011-03-07 11:36 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6d5a992dbac2 Merge ! make/common/Release.gmk - src/share/classes/java/dyn/NoAccessException.java - src/share/classes/java/dyn/Switcher.java Changeset: a52da0bada39 Author: valeriep Date: 2011-03-07 14:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/a52da0bada39 6994008: PKCS11 should support "RSA" and "RSA/ECB/NoPadding" ciphers Summary: Add support for RSA_X_509 mechanism and aliasing of "RSA" to "RSA/ECB/PKCS1Padding". Reviewed-by: wetmore ! src/share/classes/sun/security/pkcs11/P11RSACipher.java ! src/share/classes/sun/security/pkcs11/SunPKCS11.java ! test/sun/security/pkcs11/Cipher/TestRSACipher.java ! test/sun/security/pkcs11/Cipher/TestRSACipherWrap.java + test/sun/security/pkcs11/Cipher/TestRawRSACipher.java Changeset: 0b6d82c838d4 Author: lana Date: 2011-03-07 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0b6d82c838d4 Merge - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: 663c7623b96b Author: alanb Date: 2011-03-08 10:32 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/663c7623b96b 7025468: Tests using diamond with anonymous inner classes needs to be reverted Reviewed-by: dholmes, forax ! test/java/nio/file/DirectoryStream/Basic.java ! test/java/util/PriorityQueue/NoNulls.java Changeset: c0bf0f19897a Author: lana Date: 2011-03-10 19:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c0bf0f19897a Merge Changeset: c975c4fbca20 Author: lana Date: 2011-03-10 20:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c975c4fbca20 Merge ! make/common/Release.gmk - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: 6aeed99af874 Author: mchung Date: 2011-03-09 23:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/6aeed99af874 7025631: Remove the modules build support from jdk 7 Reviewed-by: alanb, ohair ! make/Makefile ! make/com/sun/crypto/provider/Makefile ! make/com/sun/java/pack/Makefile ! make/com/sun/java/pack/prop/Makefile ! make/com/sun/jndi/cosnaming/Makefile ! make/com/sun/jndi/dns/Makefile ! make/com/sun/jndi/ldap/Makefile ! make/com/sun/jndi/rmi/registry/Makefile ! make/com/sun/nio/sctp/Makefile ! make/com/sun/org/apache/xml/Makefile ! make/com/sun/rowset/Makefile ! make/com/sun/script/Makefile ! make/com/sun/security/auth/module/Makefile ! make/com/sun/servicetag/Makefile ! make/com/sun/tools/attach/Makefile ! make/common/Defs.gmk ! make/common/Demo.gmk ! make/common/Library.gmk ! make/common/Program.gmk ! make/common/Release.gmk ! make/common/Sanity.gmk ! make/common/Subdirs.gmk ! make/common/shared/Sanity.gmk ! make/java/awt/Makefile ! make/java/fdlibm/Makefile ! make/java/instrument/Makefile ! make/java/java/Makefile ! make/java/java_crw_demo/Makefile ! make/java/java_hprof_demo/Makefile ! make/java/jli/Makefile ! make/java/jvm/Makefile ! make/java/logging/Makefile ! make/java/main/java/Makefile ! make/java/main/javaw/Makefile ! make/java/management/Makefile ! make/java/net/Makefile ! make/java/nio/Makefile ! make/java/npt/Makefile ! make/java/redist/Makefile ! make/java/redist/fonts/Makefile ! make/java/redist/sajdi/Makefile ! make/java/security/Makefile ! make/java/sql/Makefile ! make/java/text/base/Makefile ! make/java/verify/Makefile ! make/java/zip/Makefile ! make/javax/crypto/Makefile ! make/javax/imageio/Makefile ! make/javax/print/Makefile ! make/javax/sound/Makefile ! make/javax/sound/jsoundalsa/Makefile ! make/javax/sound/jsoundds/Makefile ! make/javax/sql/Makefile ! make/javax/swing/Makefile ! make/javax/swing/plaf/Makefile ! make/jpda/back/Makefile ! make/jpda/transport/Makefile ! make/jpda/transport/shmem/Makefile ! make/jpda/transport/socket/Makefile ! make/jpda/tty/Makefile ! make/launchers/Makefile ! make/mkdemo/jvmti/Makefile ! make/mkdemo/management/Makefile ! make/mksample/dtrace/Makefile ! make/mksample/jmx/jmx-scandir/Makefile ! make/mksample/nbproject/Makefile ! make/mksample/nio/file/Makefile ! make/mksample/nio/multicast/Makefile ! make/mksample/nio/server/Makefile ! make/mksample/scripting/scriptpad/Makefile ! make/mksample/webservices/EbayClient/Makefile ! make/mksample/webservices/EbayServer/Makefile ! make/sun/applet/Makefile ! make/sun/awt/Makefile ! make/sun/cmm/Makefile ! make/sun/cmm/kcms/Makefile ! make/sun/cmm/lcms/Makefile ! make/sun/dcpr/Makefile ! make/sun/font/Makefile ! make/sun/font/t2k/Makefile ! make/sun/headless/Makefile ! make/sun/image/generic/Makefile ! make/sun/image/vis/Makefile ! make/sun/jar/Makefile ! make/sun/javazic/Makefile ! make/sun/jawt/Makefile ! make/sun/jconsole/Makefile ! make/sun/jdbc/Makefile ! make/sun/jdga/Makefile ! make/sun/jpeg/Makefile ! make/sun/launcher/Makefile ! make/sun/management/Makefile ! make/sun/native2ascii/Makefile ! make/sun/net/others/Makefile ! make/sun/net/spi/nameservice/dns/Makefile ! make/sun/nio/cs/Makefile ! make/sun/org/mozilla/javascript/Makefile ! make/sun/pisces/Makefile ! make/sun/rmi/cgi/Makefile ! make/sun/rmi/oldtools/Makefile ! make/sun/rmi/registry/Makefile ! make/sun/rmi/rmi/Makefile ! make/sun/rmi/rmic/Makefile ! make/sun/rmi/rmid/Makefile ! make/sun/security/ec/Makefile ! make/sun/security/jgss/wrapper/Makefile ! make/sun/security/krb5/Makefile ! make/sun/security/mscapi/Makefile ! make/sun/security/pkcs11/Makefile ! make/sun/security/smartcardio/Makefile ! make/sun/security/tools/Makefile ! make/sun/serialver/Makefile ! make/sun/splashscreen/Makefile ! make/sun/text/Makefile ! make/sun/tools/Makefile ! make/sun/tracing/dtrace/Makefile ! make/sun/xawt/Makefile Changeset: 1657b854c956 Author: mchung Date: 2011-03-09 23:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/1657b854c956 7026228: Remove make/modules and make/common/Modules.gmk Reviewed-by: alanb, ohair - make/common/Modules.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: c28f5ac2d5f8 Author: ohair Date: 2011-03-10 14:48 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/c28f5ac2d5f8 7025412: make381 issues with quotes in jdk/make/docs/Makefile and other places Reviewed-by: mchung, herrick ! make/common/shared/Defs-javadoc.gmk ! make/common/shared/Sanity.gmk ! make/docs/Makefile ! make/javax/crypto/Defs-jce.gmk Changeset: 38be400c2608 Author: asaha Date: 2011-03-09 16:44 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/38be400c2608 6908562: JFB Custom Revision Version Build/Makefile changes Reviewed-by: ohair, ksrini, katleman ! make/common/Release.gmk ! make/common/shared/Defs.gmk Changeset: fc680f496eaf Author: asaha Date: 2011-03-14 12:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/fc680f496eaf Merge - make/common/Modules.gmk ! make/common/Release.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java Changeset: b1215d1f015b Author: ohair Date: 2011-03-15 15:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/b1215d1f015b Merge - make/common/Modules.gmk ! make/common/Release.gmk - make/java/nio/mxbean/Makefile - make/modules/Makefile - make/modules/bootmodule.roots - make/modules/jdk7.depconfig - make/modules/modules.config - make/modules/modules.group - make/modules/optional.depconfig - make/modules/tools/Makefile - make/modules/tools/build.xml - make/modules/tools/nbproject/project.properties - make/modules/tools/nbproject/project.xml - make/modules/tools/src/com/sun/classanalyzer/AnnotatedDependency.java - make/modules/tools/src/com/sun/classanalyzer/AnnotationParser.java - make/modules/tools/src/com/sun/classanalyzer/BootAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/CheckDeps.java - make/modules/tools/src/com/sun/classanalyzer/ClassAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ClassFileParser.java - make/modules/tools/src/com/sun/classanalyzer/ClassPath.java - make/modules/tools/src/com/sun/classanalyzer/CodeAttributeParser.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolAnalyzer.java - make/modules/tools/src/com/sun/classanalyzer/ConstantPoolParser.java - make/modules/tools/src/com/sun/classanalyzer/DependencyConfig.java - make/modules/tools/src/com/sun/classanalyzer/Klass.java - make/modules/tools/src/com/sun/classanalyzer/Module.java - make/modules/tools/src/com/sun/classanalyzer/ModuleConfig.java - make/modules/tools/src/com/sun/classanalyzer/ResolutionInfo.java - make/modules/tools/src/com/sun/classanalyzer/ResourceFile.java - make/modules/tools/src/com/sun/classanalyzer/ShowDeps.java ! make/sun/awt/Makefile Changeset: 3de1fed4b9ec Author: ohair Date: 2011-03-15 15:21 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/3de1fed4b9ec 6710813: SwingSet2 source display tabs do not work since JDK 7 b20 6685150: make/mkdemo/jpda/Makefile creates jpda.jar and src.zip instead of examples.jar Reviewed-by: prr ! make/common/Demo.gmk ! make/mkdemo/jfc/SwingSet2/Makefile ! make/mkdemo/jpda/Makefile Changeset: f5ecfc9e274c Author: ohair Date: 2011-03-15 23:46 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/f5ecfc9e274c Merge - src/share/classes/sun/misc/BootClassLoaderHook.java - src/share/classes/sun/misc/JavaSecurityCodeSignerAccess.java - test/sun/misc/BootClassLoaderHook/TestHook.java Changeset: d6c6d9566126 Author: katleman Date: 2011-03-16 09:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/d6c6d9566126 6973319: incorrect spec version in jdk 7 rt.jar manifest Reviewed-by: ohair ! make/tools/manifest.mf Changeset: 76a2ea69f47f Author: katleman Date: 2011-03-16 09:42 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/76a2ea69f47f 7022473: JDK7 still runs /etc/prtconf to find memory size Reviewed-by: ohair ! make/common/shared/Platform.gmk Changeset: 554adcfb615e Author: ohair Date: 2011-03-16 15:01 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/554adcfb615e 7027923: Disable VS2003 use in preparation for all VS2003 make logic removal Reviewed-by: prr ! make/common/shared/Compiler-msvc.gmk Changeset: 0653cab602f2 Author: schien Date: 2011-03-17 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/jdk/rev/0653cab602f2 Added tag jdk7-b134 for changeset 554adcfb615e ! .hgtags From john.coomes at oracle.com Fri Mar 18 15:06:50 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Fri, 18 Mar 2011 22:06:50 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 50 new changesets Message-ID: <20110318220823.4778D47296@hg.openjdk.java.net> Changeset: d89a22843c62 Author: iveresov Date: 2011-02-22 15:25 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d89a22843c62 7020521: arraycopy stubs place prebarriers incorrectly Summary: Rearranged the pre-barrier placement in arraycopy stubs so that they are properly called in case of chained calls. Also refactored the code a little bit so that it looks uniform across the platforms and is more readable. Reviewed-by: never, kvn ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp Changeset: d5a078cf7f39 Author: iveresov Date: 2011-02-22 18:13 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d5a078cf7f39 Merge Changeset: ba5d119730dd Author: kvn Date: 2011-02-23 12:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/ba5d119730dd Merge Changeset: d411927672ed Author: never Date: 2011-02-23 19:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d411927672ed 7012072: CompileTheWorld causes incorrect class initialization Reviewed-by: kvn, twisti ! src/share/vm/prims/unsafe.cpp Changeset: 5a41a201d08c Author: kvn Date: 2011-02-24 10:28 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5a41a201d08c 6812217: Base memory of MergeMem node violates assert during killing expanded AllocateArray node Summary: The assert in MergeMemNode::memory_at() misses the case when address is TOP. Reviewed-by: never ! src/share/vm/opto/memnode.cpp Changeset: 6f3746e69a78 Author: never Date: 2011-02-24 11:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/6f3746e69a78 7021603: crash in fill_sync_handler with ExtendedDTrace probes Reviewed-by: iveresov ! src/share/vm/c1/c1_GraphBuilder.cpp Changeset: 8190d4b75e09 Author: never Date: 2011-02-24 14:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8190d4b75e09 Merge Changeset: 41d4973cf100 Author: kvn Date: 2011-02-26 12:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/41d4973cf100 6942326: x86 code in string_indexof() could read beyond reserved heap space Summary: copy small (<8) strings on stack if str+16 crosses a page boundary and load from stack into XMM. Back up pointer when loading string's tail. Reviewed-by: never ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/assembler_x86.hpp ! src/cpu/x86/vm/x86_32.ad ! src/cpu/x86/vm/x86_64.ad ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp + test/compiler/6942326/Test.java Changeset: 1b4e6a5d98e0 Author: twisti Date: 2011-02-28 06:07 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1b4e6a5d98e0 7012914: JSR 292 MethodHandlesTest C1: frame::verify_return_pc(return_address) failed: must be a return pc Reviewed-by: never, bdelsart ! src/cpu/sparc/vm/c1_LIRAssembler_sparc.cpp ! src/cpu/sparc/vm/c1_Runtime1_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/x86/vm/c1_LIRAssembler_x86.cpp ! src/cpu/x86/vm/c1_Runtime1_x86.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/c1/c1_Runtime1.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/runtime/sharedRuntime.cpp ! src/share/vm/utilities/macros.hpp Changeset: 50c0f22d6d0e Author: never Date: 2011-02-28 17:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/50c0f22d6d0e 7023229: extraneous include of precompiled.hpp in hsdis.c Reviewed-by: never, jrose Contributed-by: volker.simonis at gmail.com ! src/share/tools/hsdis/hsdis-demo.c ! src/share/tools/hsdis/hsdis.c Changeset: bc6b27fb3568 Author: never Date: 2011-03-01 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/bc6b27fb3568 6725983: Assertion "method->method_holder())->is_not_initialized(),"method holder must be initialized" Reviewed-by: kvn, iveresov ! src/share/vm/classfile/classLoader.cpp ! src/share/vm/runtime/globals.hpp Changeset: 0ac769a57c64 Author: iveresov Date: 2011-03-01 14:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0ac769a57c64 6627983: G1: Bad oop deference during marking Summary: Bulk zeroing reduction didn't work with G1, because arraycopy would call pre-barriers on uninitialized oops. The solution is to have version of arraycopy stubs that don't have pre-barriers. Also refactored arraycopy stubs generation on SPARC to be more readable and reduced the number of stubs necessary in some cases. Reviewed-by: jrose, kvn, never ! src/cpu/sparc/vm/stubGenerator_sparc.cpp ! src/cpu/x86/vm/stubGenerator_x86_32.cpp ! src/cpu/x86/vm/stubGenerator_x86_64.cpp ! src/share/vm/gc_implementation/g1/g1SATBCardTableModRefBS.hpp ! src/share/vm/memory/barrierSet.cpp ! src/share/vm/memory/barrierSet.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/stubRoutines.cpp ! src/share/vm/runtime/stubRoutines.hpp Changeset: 8c9c9ee30d71 Author: kvn Date: 2011-03-03 23:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8c9c9ee30d71 Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp Changeset: a8d643a4db47 Author: katleman Date: 2011-03-03 14:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a8d643a4db47 Added tag jdk7-b132 for changeset 0e531ab5ba04 ! .hgtags Changeset: 1b3a350709e4 Author: trims Date: 2011-03-03 15:13 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1b3a350709e4 Added tag hs21-b03 for changeset a8d643a4db47 ! .hgtags Changeset: 3e2b59ab2d07 Author: trims Date: 2011-03-04 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3e2b59ab2d07 Merge Changeset: 3c76374706ea Author: trims Date: 2011-03-04 14:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3c76374706ea 7024814: Bump the HS21 build number to 04 Summary: Update the HS21 build number to 04 Reviewed-by: jcoomes ! make/hotspot_version Changeset: 9f44e9aad2d9 Author: coleenp Date: 2011-03-03 19:51 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/9f44e9aad2d9 7022999: Can't build with FORCE_TIERED=0 Summary: Put UseFastLocking test under #ifdef COMPILER1 Reviewed-by: kvn, phh, never, dcubed ! src/share/vm/runtime/arguments.cpp Changeset: fbbeec6dad2d Author: coleenp Date: 2011-03-03 19:52 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fbbeec6dad2d 6512830: Error: assert(tag_at(which).is_unresolved_klass(), "Corrupted constant pool") Summary: Redefine classes copies the constant pool while the constant pool may be resolving strings or classes Reviewed-by: dcubed, dsamersoff, acorn ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/prims/jvmtiRedefineClasses.cpp Changeset: f767174aac14 Author: coleenp Date: 2011-03-03 19:53 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f767174aac14 7021653: Parfait issue in hotspot/src/share/vm/oops/methodDataOops.hpp Summary: Fix compilation error(s) Reviewed-by: kvn, phh, jcoomes, dholmes ! src/share/vm/oops/methodDataOop.hpp ! src/share/vm/runtime/os.cpp Changeset: dbad0519a1c4 Author: kamg Date: 2011-03-04 14:40 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/dbad0519a1c4 6845426: non-static method with no args is called during the class initialization process Summary: Only call with ACC_STATIC for classfiles with version > 50 Reviewed-by: acorn, dholmes, coleenp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/oops/methodOop.hpp Changeset: 0cd0a06d2535 Author: acorn Date: 2011-03-07 09:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0cd0a06d2535 Merge ! src/share/vm/runtime/arguments.cpp Changeset: df1347358fe6 Author: coleenp Date: 2011-03-07 16:03 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/df1347358fe6 7024584: Symbol printouts shouldnt be under PrintGCDetails Summary: Put symbol printing under Verbose and WizardMode so you can get this information if you really want it. Reviewed-by: phh, stefank, never, dholmes, jcoomes ! src/share/vm/classfile/symbolTable.cpp Changeset: 70b50ac7e2af Author: cl Date: 2011-03-10 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/70b50ac7e2af Added tag jdk7-b133 for changeset 1b3a350709e4 ! .hgtags Changeset: 447e6faab4a8 Author: trims Date: 2011-03-11 11:18 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/447e6faab4a8 Merge Changeset: 02e6fc2effd8 Author: trims Date: 2011-03-11 22:41 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/02e6fc2effd8 Merge Changeset: 4f148718983e Author: bdelsart Date: 2011-03-10 17:44 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/4f148718983e 7025485: leverage shared x86-only deoptimization code Summary: removed an ifdef IA32 around harmless code useful for some ports Reviewed-by: chrisphi, never ! src/share/vm/runtime/deoptimization.cpp ! src/share/vm/runtime/deoptimization.hpp Changeset: 3d5a546351ef Author: phh Date: 2011-03-11 16:09 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3d5a546351ef 7023931: PcDescCache::find_pc_desc should not write _last_pc_desc Summary: Remove _last_pc_desc and use pcdescs[0] instead. Reviewed-by: dcubed, coleenp, ysr ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp Changeset: 4775a1e3e923 Author: acorn Date: 2011-03-14 11:43 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/4775a1e3e923 Merge Changeset: 216d916d5c12 Author: dcubed Date: 2011-03-15 06:35 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/216d916d5c12 7024234: 2/3 jvmti tests fail assert(!_oops_are_stale) failed: oops are stale on Win-AMD64 Summary: Move initialization of the '_instance' field to avoid race with ServiceThread start. Reviewed-by: dholmes, kamg, never, dsamersoff, ysr, coleenp, acorn ! src/share/vm/runtime/serviceThread.cpp Changeset: 46a56fac55c7 Author: dcubed Date: 2011-03-15 06:37 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/46a56fac55c7 7024970: 2/3 assert(ServiceThread::is_service_thread(Thread::current())) failed: Service thread must post enqueue Summary: Change nmethod_lock() to also prevent zombification of the nmethod. CompiledMethodUnload events also need to lock the nmethod. Clean ups in nmethod::make_not_entrant_or_zombie() Reviewed-by: dholmes, kamg, never, dsamersoff, ysr, coleenp, acorn ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/prims/jvmtiImpl.cpp ! src/share/vm/prims/jvmtiImpl.hpp Changeset: 65f880e2869b Author: dcubed Date: 2011-03-15 06:50 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/65f880e2869b Merge ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp Changeset: 8a3f8defe568 Author: coleenp Date: 2011-03-16 14:57 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8a3f8defe568 7019165: Incorrect symbols in pstack output after SymbolTable changes Summary: And out lsb which is set for symbols in constant pool slots to distinguish them from strings Reviewed-by: phh, dholmes, never, dcubed ! src/os/solaris/dtrace/libjvm_db.c Changeset: b9684d5ccb52 Author: vladidan Date: 2011-03-10 14:56 -0500 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b9684d5ccb52 7011490: Wrong computation results in Test6880034 Summary: incorrect handling of c2i deoptimization on little endian architectures Reviewed-by: never ! src/share/vm/c1/c1_LinearScan.cpp Changeset: bc57bfb5bfad Author: vladidan Date: 2011-03-16 10:47 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/bc57bfb5bfad Merge Changeset: 2074c95f707e Author: vladidan Date: 2011-03-16 23:45 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/2074c95f707e Merge Changeset: 5d8f5a6dced7 Author: iveresov Date: 2011-03-04 15:14 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5d8f5a6dced7 7020403: Add AdvancedCompilationPolicy for tiered Summary: This implements adaptive tiered compilation policy. Reviewed-by: kvn, never ! src/share/vm/oops/methodKlass.cpp ! src/share/vm/oops/methodOop.hpp + src/share/vm/runtime/advancedThresholdPolicy.cpp + src/share/vm/runtime/advancedThresholdPolicy.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/compilationPolicy.cpp Changeset: 4cd9add59b1e Author: never Date: 2011-03-04 20:01 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/4cd9add59b1e 7024866: # assert(limit == NULL || limit <= nm->code_end()) failed: in bounds Reviewed-by: kvn, iveresov ! src/share/vm/code/nmethod.cpp Changeset: 8ec5e1f45ea1 Author: never Date: 2011-03-04 22:44 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8ec5e1f45ea1 Merge Changeset: 8e72cd29b15d Author: kvn Date: 2011-03-05 11:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8e72cd29b15d 6589823: Error: meet not symmetric Summary: arrays pointers meet must fall to bottom if exact array klasses in upper lattice are not equal or super klass is exact. Reviewed-by: never ! src/share/vm/opto/type.cpp Changeset: 425688247f3d Author: never Date: 2011-03-06 22:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/425688247f3d 6965570: assert(!needs_patching && x->is_loaded(),"how do we know it's volatile if it's not loaded") Reviewed-by: iveresov ! src/share/vm/c1/c1_Canonicalizer.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Instruction.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/c1/c1_ValueMap.hpp Changeset: 1c0cf339481b Author: kvn Date: 2011-03-09 09:15 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/1c0cf339481b 7025742: Can not use CodeCache::unallocated_capacity() with fragmented CodeCache Summary: Use largest_free_block() instead of unallocated_capacity(). Reviewed-by: iveresov, never, ysr ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/compiler/compileBroker.cpp ! src/share/vm/memory/heap.cpp ! src/share/vm/opto/output.cpp ! src/share/vm/runtime/sweeper.cpp Changeset: 83f08886981c Author: kvn Date: 2011-03-11 07:50 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/83f08886981c 7026631: field _klass is incorrectly set for dual type of TypeAryPtr::OOPS Summary: add missing check this->dual() != TypeAryPtr::OOPS into TypeAryPtr::klass(). Reviewed-by: never ! src/share/vm/opto/type.cpp Changeset: 799d8ccf63cf Author: jrose Date: 2011-03-11 21:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/799d8ccf63cf Merge ! src/share/vm/oops/methodOop.hpp ! src/share/vm/runtime/arguments.cpp Changeset: 72dee110246f Author: jrose Date: 2011-03-11 22:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/72dee110246f 6839872: remove implementation inheritance from JSR 292 APIs Summary: consolidate runtime support in java.dyn.MethodHandleNatives; include transitional compatibility logic Reviewed-by: twisti ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/vmSymbols.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/nativeLookup.cpp ! src/share/vm/runtime/globals.hpp Changeset: 8033953d67ff Author: jrose Date: 2011-03-11 22:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/8033953d67ff 7012648: move JSR 292 to package java.lang.invoke and adjust names Summary: package and class renaming only; delete unused methods and classes Reviewed-by: twisti ! src/cpu/sparc/vm/assembler_sparc.cpp ! src/cpu/sparc/vm/cppInterpreter_sparc.cpp ! src/cpu/sparc/vm/interpreter_sparc.cpp ! src/cpu/sparc/vm/methodHandles_sparc.cpp ! src/cpu/sparc/vm/templateTable_sparc.cpp ! src/cpu/x86/vm/assembler_x86.cpp ! src/cpu/x86/vm/interpreter_x86_32.cpp ! src/cpu/x86/vm/interpreter_x86_64.cpp ! src/cpu/x86/vm/methodHandles_x86.cpp ! src/cpu/x86/vm/templateTable_x86_32.cpp ! src/cpu/x86/vm/templateTable_x86_64.cpp ! src/share/vm/c1/c1_LIR.hpp ! src/share/vm/c1/c1_LIRGenerator.cpp ! src/share/vm/ci/ciCallSite.cpp ! src/share/vm/ci/ciCallSite.hpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciMethod.cpp ! src/share/vm/ci/ciMethodHandle.hpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/ci/ciStreams.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/classfile/systemDictionary.cpp ! src/share/vm/classfile/systemDictionary.hpp ! src/share/vm/classfile/verifier.cpp ! src/share/vm/classfile/vmSymbols.hpp ! src/share/vm/interpreter/abstractInterpreter.hpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/interpreter/linkResolver.cpp ! src/share/vm/oops/cpCacheOop.hpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/methodOop.cpp ! src/share/vm/opto/bytecodeInfo.cpp ! src/share/vm/opto/callGenerator.cpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/prims/methodHandleWalk.cpp ! src/share/vm/prims/methodHandleWalk.hpp ! src/share/vm/prims/methodHandles.cpp ! src/share/vm/prims/methodHandles.hpp ! src/share/vm/prims/nativeLookup.cpp Changeset: 82de9bd880e3 Author: kvn Date: 2011-03-17 12:08 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/82de9bd880e3 7028394: Newer AMD Processor Prefetch Defaults Summary: This new default has shown improvement across many workloads. Reviewed-by: kvn Contributed-by: tom.deneau at amd.com ! src/cpu/x86/vm/vm_version_x86.cpp Changeset: d2134498fd3f Author: jrose Date: 2011-03-17 18:29 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d2134498fd3f 7011865: JSR 292 CTW fails: !THREAD->is_Compiler_thread() failed: Can not load classes with the Compiler thre Reviewed-by: kvn, never ! src/share/vm/interpreter/linkResolver.cpp Changeset: fc5ebbb2d1a8 Author: twisti Date: 2011-03-18 01:44 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fc5ebbb2d1a8 Merge ! src/share/vm/code/nmethod.cpp Changeset: 048f98400b8e Author: jcoomes Date: 2011-03-18 09:03 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/048f98400b8e Merge ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp From tom.rodriguez at oracle.com Fri Mar 18 19:14:31 2011 From: tom.rodriguez at oracle.com (tom.rodriguez at oracle.com) Date: Sat, 19 Mar 2011 02:14:31 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <20110319021439.C6054472A1@hg.openjdk.java.net> Changeset: d673ef06fe96 Author: never Date: 2011-03-18 15:52 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/d673ef06fe96 7028374: race in fix_oop_relocations for scavengeable nmethods Reviewed-by: kvn ! src/cpu/sparc/vm/nativeInst_sparc.cpp ! src/cpu/sparc/vm/nativeInst_sparc.hpp ! src/cpu/sparc/vm/relocInfo_sparc.cpp ! src/cpu/x86/vm/relocInfo_x86.cpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/codeCache.hpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/code/nmethod.hpp ! src/share/vm/code/relocInfo.cpp ! src/share/vm/code/relocInfo.hpp ! src/share/vm/memory/universe.cpp Changeset: c7f3d0b4570f Author: never Date: 2011-03-18 16:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c7f3d0b4570f 7017732: move static fields into Class to prepare for perm gen removal Reviewed-by: kvn, coleenp, twisti, stefank ! agent/src/share/classes/sun/jvm/hotspot/jdi/FieldImpl.java ! agent/src/share/classes/sun/jvm/hotspot/oops/InstanceKlass.java ! agent/src/share/classes/sun/jvm/hotspot/oops/IntField.java ! agent/src/share/classes/sun/jvm/hotspot/oops/OopField.java ! agent/src/share/classes/sun/jvm/hotspot/oops/OopUtilities.java ! agent/src/share/classes/sun/jvm/hotspot/runtime/VM.java ! agent/test/jdi/sasanity.sh ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/sparc/vm/dump_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp ! src/cpu/zero/vm/cppInterpreter_zero.cpp ! src/share/vm/c1/c1_GraphBuilder.cpp ! src/share/vm/c1/c1_Runtime1.cpp ! src/share/vm/ci/ciCPCache.cpp ! src/share/vm/ci/ciField.cpp ! src/share/vm/ci/ciInstance.cpp ! src/share/vm/ci/ciInstance.hpp ! src/share/vm/ci/ciInstanceKlass.cpp ! src/share/vm/ci/ciObjectFactory.cpp ! src/share/vm/classfile/classFileParser.cpp ! src/share/vm/classfile/classFileParser.hpp ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/javaClasses.hpp ! src/share/vm/code/codeCache.cpp ! src/share/vm/code/nmethod.cpp ! src/share/vm/interpreter/bytecodeInterpreter.cpp ! src/share/vm/interpreter/interpreterRuntime.cpp ! src/share/vm/memory/compactingPermGenGen.hpp ! src/share/vm/memory/oopFactory.cpp ! src/share/vm/memory/oopFactory.hpp ! src/share/vm/memory/universe.cpp ! src/share/vm/oops/arrayKlassKlass.cpp ! src/share/vm/oops/constantPoolOop.cpp ! src/share/vm/oops/cpCacheKlass.cpp ! src/share/vm/oops/cpCacheOop.cpp ! src/share/vm/oops/instanceKlass.cpp ! src/share/vm/oops/instanceKlass.hpp ! src/share/vm/oops/instanceKlassKlass.cpp ! src/share/vm/oops/instanceKlassKlass.hpp + src/share/vm/oops/instanceMirrorKlass.cpp + src/share/vm/oops/instanceMirrorKlass.hpp ! src/share/vm/oops/klass.hpp ! src/share/vm/oops/klassKlass.cpp ! src/share/vm/oops/klassOop.hpp ! src/share/vm/oops/klassVtable.cpp ! src/share/vm/oops/objArrayKlassKlass.cpp ! src/share/vm/oops/oop.hpp ! src/share/vm/oops/oop.inline.hpp ! src/share/vm/oops/oopsHierarchy.hpp ! src/share/vm/opto/compile.cpp ! src/share/vm/opto/compile.hpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse3.cpp ! src/share/vm/opto/type.cpp ! src/share/vm/prims/jni.cpp ! src/share/vm/prims/jniCheck.cpp ! src/share/vm/prims/jvm.cpp ! src/share/vm/prims/jvmtiEnvBase.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/prims/unsafe.cpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/reflection.cpp ! src/share/vm/runtime/thread.cpp ! src/share/vm/runtime/vmStructs.cpp ! src/share/vm/shark/sharkNativeWrapper.cpp From john.coomes at oracle.com Fri Mar 18 22:25:26 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 19 Mar 2011 05:25:26 +0000 Subject: hg: jdk7/hotspot-gc/langtools: 85 new changesets Message-ID: <20110319052810.C77E5472B1@hg.openjdk.java.net> Changeset: 73ab0b128918 Author: jjg Date: 2011-01-24 16:17 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/73ab0b128918 6963934: JCCompilationUnit.getImports does not report all imports Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/tree/JCTree.java + test/tools/javac/tree/T6963934.java Changeset: 22a040cbf0e0 Author: jjg Date: 2011-01-24 16:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/22a040cbf0e0 6581775: Fix the white space problem in javac shell tests Reviewed-by: mcimadamore ! test/tools/javac/ClassPathTest/ClassPathTest.sh ! test/tools/javac/ExtDirs/ExtDirs.sh ! test/tools/javac/Paths/Help.sh ! test/tools/javac/javazip/Test.sh ! test/tools/javac/versions/check.sh Changeset: a8437c34fdc7 Author: jjg Date: 2011-01-24 16:38 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/a8437c34fdc7 6988106: javac report 'java.lang.IllegalMonitorStateException' Reviewed-by: ksrini ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/file/ZipFileIndex.java + src/share/classes/com/sun/tools/javac/file/ZipFileIndexCache.java ! test/tools/javac/T6725036.java Changeset: 7f8794f9cc14 Author: darcy Date: 2011-01-25 17:02 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7f8794f9cc14 7013420: Project Coin: remove general expression support from try-with-resources statement Reviewed-by: mcimadamore, jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/TryWithResources/BadTwrSyntax.out ! test/tools/javac/TryWithResources/DuplicateResource.java + test/tools/javac/TryWithResources/ExplicitFinal.java ! test/tools/javac/TryWithResources/ImplicitFinal.java ! test/tools/javac/TryWithResources/ImplicitFinal.out ! test/tools/javac/TryWithResources/TwrFlow.java ! test/tools/javac/TryWithResources/TwrFlow.out - test/tools/javac/TryWithResources/TwrInference.java - test/tools/javac/TryWithResources/TwrIntersection.java - test/tools/javac/TryWithResources/TwrIntersection02.java - test/tools/javac/TryWithResources/TwrIntersection02.out ! test/tools/javac/TryWithResources/TwrMultiCatch.java ! test/tools/javac/TryWithResources/TwrOnNonResource.java ! test/tools/javac/TryWithResources/TwrOnNonResource.out + test/tools/javac/diags/examples/TryResourceTrailingSemi.java Changeset: df371fd16386 Author: jjg Date: 2011-01-26 11:20 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/df371fd16386 6554097: "final" confuses @SuppressWarnings Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java + test/tools/javac/T6554097.java + test/tools/javac/T6554097.out Changeset: 3da26790ccb7 Author: jjg Date: 2011-01-26 13:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3da26790ccb7 7013272: Automatically generate info about how compiler resource keys are used Reviewed-by: mcimadamore ! make/build.xml ! src/share/classes/com/sun/tools/javac/code/Printer.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/ArgTypeCompilerFactory.java ! test/tools/javac/diags/Example.java + test/tools/javac/diags/MessageFile.java + test/tools/javac/diags/MessageInfo.java ! test/tools/javac/diags/RunExamples.java Changeset: 92ab09ed59fd Author: jjh Date: 2011-01-28 00:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/92ab09ed59fd 7015482: jtreg test tools/javac/diags/MessageInfo.java fails when test/ dir is not in langtools repo Summary: Don't fail if the needed file isn't present, if running under jtreg. Reviewed-by: jjg ! test/tools/javac/diags/MessageInfo.java Changeset: 2088e674f0e0 Author: mcimadamore Date: 2011-01-28 12:01 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/2088e674f0e0 6910550: javac 1.5.0_17 fails with incorrect error message Summary: multiple clashing members declared in same class should be added to the class' scope in order to avoid downstream spurious diagnostics Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/generics/6910550/T6910550a.java + test/tools/javac/generics/6910550/T6910550a.out + test/tools/javac/generics/6910550/T6910550b.java + test/tools/javac/generics/6910550/T6910550b.out + test/tools/javac/generics/6910550/T6910550c.java + test/tools/javac/generics/6910550/T6910550c.out + test/tools/javac/generics/6910550/T6910550d.java + test/tools/javac/generics/6910550/T6910550d.out + test/tools/javac/generics/6910550/T6910550e.java + test/tools/javac/generics/6910550/T6910550e.out Changeset: 5a43b245aed1 Author: mcimadamore Date: 2011-01-28 12:03 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/5a43b245aed1 6313164: javac generates code that fails byte code verification for the varargs feature Summary: method applicability check should fail if formal varargs element type is not accessible Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/InaccessibleVarargsType/InaccessibleVarargsType.java + test/tools/javac/diags/examples/InaccessibleVarargsType/p1/A.java + test/tools/javac/diags/examples/InaccessibleVarargsType/p1/B.java ! test/tools/javac/generics/inference/6638712/T6638712c.out ! test/tools/javac/generics/inference/6638712/T6638712d.out + test/tools/javac/varargs/6313164/T6313164.java + test/tools/javac/varargs/6313164/T6313164.out + test/tools/javac/varargs/6313164/p1/A.java + test/tools/javac/varargs/6313164/p1/B.java + test/tools/javac/varargs/6313164/p1/C.java Changeset: 17bafae67e9d Author: mcimadamore Date: 2011-01-28 12:06 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/17bafae67e9d 6838943: inference: javac is not handling type-variable substitution properly Summary: free type-variables are being replaced with type-variables bound to forall type leading to unsoundness Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/inference/6838943/T6838943.java + test/tools/javac/generics/inference/6838943/T6838943.out Changeset: babf86a1ac92 Author: alanb Date: 2011-01-28 09:25 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/babf86a1ac92 7006126: (fs) Updates to file system API (1/2011) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/nio/JavacPathFileManager.java ! src/share/classes/com/sun/tools/javac/nio/PathFileObject.java ! test/tools/javac/nio/compileTest/CompileTest.java Changeset: df3394337b04 Author: alanb Date: 2011-01-28 12:36 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/df3394337b04 Merge Changeset: 7a75a1803c7a Author: darcy Date: 2011-01-28 16:54 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7a75a1803c7a 7015530: Reiterate API specializations in javax.lang.model.elment subinterfaces Reviewed-by: jjg ! src/share/classes/javax/lang/model/element/Element.java ! src/share/classes/javax/lang/model/element/ExecutableElement.java ! src/share/classes/javax/lang/model/element/PackageElement.java ! src/share/classes/javax/lang/model/element/TypeElement.java ! src/share/classes/javax/lang/model/element/TypeParameterElement.java ! src/share/classes/javax/lang/model/element/VariableElement.java Changeset: 2ab47c4cd618 Author: darcy Date: 2011-01-31 19:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/2ab47c4cd618 7014734: Project Coin: Allow optional trailing semicolon to terminate resources list in try-with-resources Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/TryWithResources/BadTwrSyntax.java ! test/tools/javac/TryWithResources/BadTwrSyntax.out - test/tools/javac/diags/examples/TryResourceTrailingSemi.java Changeset: cad51b6eb7a6 Author: darcy Date: 2011-02-01 10:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/cad51b6eb7a6 6961571: Update visitors to support ARM's ElementKind.RESOURCE_VARIABLE Reviewed-by: jjg + src/share/classes/javax/lang/model/type/DisjunctiveType.java ! src/share/classes/javax/lang/model/type/TypeKind.java ! src/share/classes/javax/lang/model/type/TypeVisitor.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor6.java ! src/share/classes/javax/lang/model/util/AbstractTypeVisitor7.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor6.java ! src/share/classes/javax/lang/model/util/ElementKindVisitor7.java ! src/share/classes/javax/lang/model/util/ElementScanner6.java ! src/share/classes/javax/lang/model/util/ElementScanner7.java ! src/share/classes/javax/lang/model/util/SimpleAnnotationValueVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleElementVisitor7.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor6.java ! src/share/classes/javax/lang/model/util/SimpleTypeVisitor7.java ! src/share/classes/javax/lang/model/util/TypeKindVisitor7.java ! src/share/classes/javax/lang/model/util/Types.java ! test/tools/javac/processing/model/element/TestResourceVariable.java Changeset: 899f7c3d9426 Author: mcimadamore Date: 2011-02-03 09:35 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/899f7c3d9426 6594914: @SuppressWarnings("deprecation") does not not work for the type of a variable Summary: Lint warnings generated during MemberEnter might ignore @SuppressWarnings annotations Reviewed-by: jjg + src/share/classes/com/sun/tools/javac/code/DeferredLintHandler.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/warnings/6594914/DeprecatedClass.java + test/tools/javac/warnings/6594914/T6594914a.java + test/tools/javac/warnings/6594914/T6594914a.out + test/tools/javac/warnings/6594914/T6594914b.java + test/tools/javac/warnings/6594914/T6594914b.out Changeset: 875262e89b52 Author: mcimadamore Date: 2011-02-03 09:36 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/875262e89b52 5017953: spurious cascaded diagnostics when name not found Summary: when an operator is applied to one or more erroneous operands, spurious diagnostics are generated Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/5017953/T5017953.java + test/tools/javac/5017953/T5017953.out ! test/tools/javac/6491592/T6491592.out Changeset: 03cf47d4de15 Author: mcimadamore Date: 2011-02-03 09:37 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/03cf47d4de15 6969184: poor error recovery after symbol not found Summary: generic type-well formedness check should ignore erroneous symbols Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/6969184/T6969184.java + test/tools/javac/generics/6969184/T6969184.out Changeset: afe226180744 Author: mcimadamore Date: 2011-02-03 09:38 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/afe226180744 7014715: javac returns different error code for certain failure(s) Summary: javac silently crashes when emitting certain kinds of resolution diagnostics Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java ! test/tools/javac/AnonStaticMember_2.java + test/tools/javac/AnonStaticMember_2.out ! test/tools/javac/InterfaceInInner.java + test/tools/javac/InterfaceInInner.out ! test/tools/javac/QualifiedNew.java + test/tools/javac/QualifiedNew.out ! test/tools/javac/T6247324.out ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/inference/6943278/T6943278.out Changeset: 9e6a09375d37 Author: lana Date: 2011-02-04 17:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/9e6a09375d37 Merge Changeset: 3aa269645199 Author: mcimadamore Date: 2011-02-07 18:09 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3aa269645199 7017414: before the move of JSR 292 to package java.lang.invoke, javac must recognize the new package Summary: added support for future 292 package (support for old location 'java.dyn' will be removed in followup changeset) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/util/Names.java Changeset: 96d4226bdd60 Author: mcimadamore Date: 2011-02-07 18:10 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/96d4226bdd60 7007615: java_util/generics/phase2/NameClashTest02 fails since jdk7/pit/b123. Summary: override clash algorithm is not implemented correctly Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Symtab.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/comp/Enter.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/diags/examples/NameClashSameErasureNoHide.java ! test/tools/javac/diags/examples/NameClashSameErasureNoOverride.java + test/tools/javac/diags/examples/NameClashSameErasureNoOverride1.java ! test/tools/javac/generics/5009937/T5009937.out ! test/tools/javac/generics/6182950/T6182950b.out ! test/tools/javac/generics/6476118/T6476118a.out ! test/tools/javac/generics/6476118/T6476118b.out ! test/tools/javac/generics/6476118/T6476118c.java ! test/tools/javac/generics/6476118/T6476118c.out ! test/tools/javac/generics/6985719/T6985719e.out ! test/tools/javac/generics/6985719/T6985719f.out ! test/tools/javac/generics/6985719/T6985719g.out ! test/tools/javac/generics/6985719/T6985719h.out + test/tools/javac/generics/7007615/T7007615.java + test/tools/javac/generics/7007615/T7007615.out + test/tools/javac/generics/7007615/acc1/AccessibilityCheck01.java + test/tools/javac/generics/7007615/acc1/p1/C.java + test/tools/javac/generics/7007615/acc1/p1/D.java + test/tools/javac/generics/7007615/acc1/p2/E.java + test/tools/javac/generics/7007615/acc2/AccessibilityCheck02.java + test/tools/javac/generics/7007615/acc2/AccessibilityCheck02.out + test/tools/javac/generics/7007615/acc2/p1/C.java + test/tools/javac/generics/7007615/acc2/p1/D.java + test/tools/javac/generics/7007615/acc2/p2/E.java ! test/tools/javac/scope/HashCollisionTest.java ! test/tools/javac/scope/StarImportTest.java Changeset: 56b77a38618c Author: jjg Date: 2011-02-07 11:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/56b77a38618c 7017675: typo in JavacParser for allowUnderscoresInLiterals Reviewed-by: dlsmith Contributed-by: peter.b.kessler at oracle.com ! src/share/classes/com/sun/tools/javac/parser/Scanner.java Changeset: 2cbaa43eb075 Author: lana Date: 2011-02-14 16:31 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/2cbaa43eb075 Merge - test/tools/javac/TryWithResources/TwrInference.java - test/tools/javac/TryWithResources/TwrIntersection.java - test/tools/javac/TryWithResources/TwrIntersection02.java - test/tools/javac/TryWithResources/TwrIntersection02.out Changeset: a21c7f194d31 Author: mfang Date: 2011-02-10 16:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/a21c7f194d31 7017734: jdk7 message drop 1 translation integration Reviewed-by: ogino, yhuang ! src/share/classes/com/sun/tools/apt/resources/apt_ja.properties ! src/share/classes/com/sun/tools/apt/resources/apt_zh_CN.properties ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_ja.properties ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard_zh_CN.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_ja.properties ! src/share/classes/com/sun/tools/doclets/internal/toolkit/resources/doclets_zh_CN.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_ja.properties ! src/share/classes/com/sun/tools/javac/resources/compiler_zh_CN.properties ! src/share/classes/com/sun/tools/javac/resources/javac_ja.properties ! src/share/classes/com/sun/tools/javac/resources/javac_zh_CN.properties ! src/share/classes/com/sun/tools/javadoc/resources/javadoc_ja.properties ! src/share/classes/com/sun/tools/javadoc/resources/javadoc_zh_CN.properties ! src/share/classes/com/sun/tools/javah/resources/l10n_ja.properties ! src/share/classes/com/sun/tools/javah/resources/l10n_zh_CN.properties Changeset: 4cdea0752a48 Author: mfang Date: 2011-02-11 22:58 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/4cdea0752a48 Merge Changeset: 26071d11c613 Author: mfang Date: 2011-02-11 23:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/26071d11c613 Merge Changeset: 7a98db8cbfce Author: ohair Date: 2011-02-15 12:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7a98db8cbfce Merge Changeset: 6cdb76cf4d1a Author: cl Date: 2011-02-18 14:23 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/6cdb76cf4d1a Added tag jdk7-b130 for changeset 7a98db8cbfce ! .hgtags Changeset: 22ea7d483794 Author: ohair Date: 2011-02-16 13:30 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/22ea7d483794 7013964: openjdk LICENSE file needs rebranding Reviewed-by: darcy, katleman, jjg ! LICENSE Changeset: 67221b8643b4 Author: cl Date: 2011-02-23 15:49 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/67221b8643b4 Merge Changeset: 80bbd1da4a72 Author: cl Date: 2011-02-24 15:16 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/80bbd1da4a72 Added tag jdk7-b131 for changeset 67221b8643b4 ! .hgtags Changeset: c6cb387190ee Author: jjg Date: 2011-02-09 14:04 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/c6cb387190ee 7016750: tools/javac/nio/CompileTest failing in nightly test Reviewed-by: mcimadamore ! test/tools/javac/nio/compileTest/CompileTest.java Changeset: 3ce4e1a07e92 Author: jjg Date: 2011-02-09 14:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3ce4e1a07e92 7010792: remove bad debugging method from javac Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/parser/Scanner.java Changeset: bfa59f3e84bd Author: jjg Date: 2011-02-09 18:26 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/bfa59f3e84bd 7018447: langtools launcher template fails if tools run from their own directory Reviewed-by: jjg Contributed-by: daniel.smith at oracle.com ! src/share/bin/launcher.sh-template Changeset: a19b1f4f23c9 Author: jjg Date: 2011-02-10 14:24 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/a19b1f4f23c9 7018098: CacheFSInfo persists too long Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/file/T7018098.java Changeset: 747a7601b6d6 Author: jjg Date: 2011-02-10 14:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/747a7601b6d6 7018452: langtools not buildable on Mac Reviewed-by: ohair ! make/build.xml Changeset: e0c16199b2e0 Author: jjg Date: 2011-02-10 15:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/e0c16199b2e0 6485027: javac incorrectly handles relative paths in manifest classpath Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/file/Paths.java ! test/tools/javac/Paths/Class-Path.sh + test/tools/javac/Paths/Class-Path2.sh ! test/tools/javac/Paths/Diagnostics.sh Changeset: bfeed79c70aa Author: jjg Date: 2011-02-11 17:10 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/bfeed79c70aa 6505047: javax.lang.model.element.Element.getEnclosingElement() doesn't return null for type parameter Reviewed-by: darcy + test/tools/javac/processing/model/element/TestTypeParameter.java Changeset: ef6c66215a93 Author: jjg Date: 2011-02-14 14:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ef6c66215a93 7008433: Minor copyright changes Reviewed-by: jjg Contributed-by: kelly.ohair at oracle.com ! test/tools/javac/4917091/Test255.java ! test/tools/javac/4917091/Test256a.java ! test/tools/javac/4917091/Test256b.java Changeset: 351027202f60 Author: mcimadamore Date: 2011-02-15 11:49 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/351027202f60 7017664: Add listeners infrastracture to javac scopes Summary: Add listeners to javac scopes, added CompoundScope and correct invalidation logic for ImplementationCache Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Scope.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/scope/7017664/CompoundScopeTest.java + test/tools/javac/scope/7017664/ImplementationCacheTest.java Changeset: fa0e4e1916f4 Author: mcimadamore Date: 2011-02-15 11:51 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/fa0e4e1916f4 7017104: improve error reporting for uncaught/undeclared exceptions from try-with-resources Summary: twr should generate better error message when uncaught exceptions are thrown by implicit call of close() method Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/TryWithResources/ResourceInterface.out ! test/tools/javac/TryWithResources/TwrFlow.out + test/tools/javac/diags/examples/UnreportedExceptionImplicitClose.java Changeset: 846d6644bb70 Author: lana Date: 2011-02-15 08:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/846d6644bb70 Merge Changeset: 0c24826853b2 Author: dlsmith Date: 2011-02-16 10:27 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/0c24826853b2 6990136: Cleanup use of Type.clone() Summary: Introduced factory methods in class Types which can be used rather than clone(). Reviewed-by: jjg, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Flow.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java Changeset: 4ce95dc0b908 Author: mcimadamore Date: 2011-02-18 12:28 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/4ce95dc0b908 7020043: Project Coin: diamond allowed on non-generic type Summary: Diamond oerator should be disallowed on non-generic class types (i.e. String) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties + test/tools/javac/generics/diamond/neg/Neg12.java + test/tools/javac/generics/diamond/neg/Neg12.out Changeset: 3d45cc94ee0f Author: ksrini Date: 2011-02-18 08:12 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3d45cc94ee0f 7018859: javac turn off the Zip optimization by default Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! test/tools/javac/4241573/T4241573.java ! test/tools/javac/6508981/TestInferBinaryName.java ! test/tools/javac/api/6411310/Test.java ! test/tools/javac/api/T6838467.java ! test/tools/javac/api/T6877206.java Changeset: 51e643f41a3a Author: mcimadamore Date: 2011-02-18 16:17 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/51e643f41a3a 7020626: diamond: add diagnostic test for diamond and non-generic classes Summary: Fix failure in regression test CheckExamples Reviewed-by: jjg + test/tools/javac/diags/examples/DiamondNonGeneric.java Changeset: 75e25df50873 Author: darcy Date: 2011-02-18 15:55 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/75e25df50873 7020047: Project Coin: generate null-check around try-with-resources close call Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Lower.java + test/tools/javac/TryWithResources/TwrNullTests.java Changeset: de5524670f80 Author: lana Date: 2011-02-21 14:35 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/de5524670f80 Merge Changeset: e3d011d59a33 Author: lana Date: 2011-02-24 18:05 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/e3d011d59a33 Merge Changeset: e77e98f936e8 Author: katleman Date: 2011-03-03 14:13 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/e77e98f936e8 Added tag jdk7-b132 for changeset e3d011d59a33 ! .hgtags Changeset: 0d056b7b93de Author: cl Date: 2011-03-10 17:11 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/0d056b7b93de Added tag jdk7-b133 for changeset e77e98f936e8 ! .hgtags Changeset: 015dc9a63efc Author: mcimadamore Date: 2011-02-23 14:16 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/015dc9a63efc 7020657: Javac rejects a fairly common idiom with raw override and interfaces Summary: name clash should not be reported if subinterface/implementing class resolves the clash by defining common overrider Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/7020657/T7020657neg.java + test/tools/javac/generics/7020657/T7020657neg.out + test/tools/javac/generics/7020657/T7020657pos.java Changeset: 3ab7bb46c5c1 Author: mcimadamore Date: 2011-02-23 14:17 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3ab7bb46c5c1 7019631: issues in test headers in b130 Summary: fix to test headers not containing correct bug ID Reviewed-by: jjg ! test/tools/javac/AnonStaticMember_2.java ! test/tools/javac/InterfaceInInner.java ! test/tools/javac/QualifiedNew.java ! test/tools/javac/generics/6969184/T6969184.java Changeset: 4b0491db73af Author: lana Date: 2011-02-23 10:34 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/4b0491db73af Merge Changeset: 3e30c95da3c6 Author: jjh Date: 2011-02-24 08:40 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3e30c95da3c6 7018753: tools/javac/varargs/warning/Warn5.java times out on slow machines Summary: Use a single file manager for all JavacTasks Reviewed-by: jjg, mcimadamore ! test/tools/javac/varargs/6199075/T6199075.java ! test/tools/javac/varargs/warning/Warn4.java ! test/tools/javac/varargs/warning/Warn5.java Changeset: 8f0dcb9499db Author: jjg Date: 2011-02-25 12:09 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/8f0dcb9499db 7021650: fix Context issues Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/util/Bark.java ! src/share/classes/com/sun/tools/javac/api/JavacTool.java ! src/share/classes/com/sun/tools/javac/file/CacheFSInfo.java ! src/share/classes/com/sun/tools/javac/file/JavacFileManager.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java ! src/share/classes/com/sun/tools/javac/util/Context.java ! src/share/classes/com/sun/tools/javadoc/JavadocClassReader.java ! src/share/classes/com/sun/tools/javadoc/JavadocEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocMemberEnter.java ! src/share/classes/com/sun/tools/javadoc/JavadocTodo.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! test/tools/javac/diags/ArgTypeCompilerFactory.java ! test/tools/javac/diags/Example.java + test/tools/javac/util/context/T7021650.java Changeset: 23b64ad3eec8 Author: jjg Date: 2011-02-25 12:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/23b64ad3eec8 7022310: test/tools/javac/diags/Example: args added twice Reviewed-by: mcimadamore ! test/tools/javac/diags/Example.java Changeset: 9286a5d1fae3 Author: mcimadamore Date: 2011-02-28 11:48 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/9286a5d1fae3 7015430: Incorrect thrown type determined for unchecked invocations Summary: Thrown types do not get updated after 15.12.2.8, and do not get erased as per 15.12.2.6 Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Infer.java + test/tools/javac/generics/7015430/T7015430.java + test/tools/javac/generics/7015430/T7015430.out Changeset: 9f9df9684cfc Author: mcimadamore Date: 2011-02-28 11:50 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/9f9df9684cfc 7015715: lub gets stuck on type with complex supertype Summary: lub should not scan supertypes unnecessarily Reviewed-by: jjg, dlsmith ! src/share/classes/com/sun/tools/javac/code/Types.java + test/tools/javac/generics/inference/T7015715.java Changeset: 9029f694e5df Author: jjg Date: 2011-02-28 12:19 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/9029f694e5df 7022337: repeated warnings about bootclasspath not set Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java - test/tools/javac/T6900037.java - test/tools/javac/T6900037.out + test/tools/javac/options/T6900037.java + test/tools/javac/options/T6900037.out + test/tools/javac/options/T7022337.java Changeset: bf9f162c7104 Author: jjg Date: 2011-02-28 13:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/bf9f162c7104 7022741: warning counts are wrong after anno processing Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/processing/JavacProcessingEnvironment.java + test/tools/javac/processing/TestWarnErrorCount.java ! test/tools/javac/processing/warnings/gold_0.out ! test/tools/javac/processing/warnings/gold_sv_warn_0_2.out ! test/tools/javac/processing/warnings/gold_sv_warn_2_3.out ! test/tools/javac/processing/warnings/gold_sv_warn_5_6.out Changeset: 67d6b2df47ba Author: jjg Date: 2011-02-28 13:42 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/67d6b2df47ba 7022711: compiler crash in try-with-resources Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Kinds.java + test/tools/javac/TryWithResources/T7022711.java + test/tools/javac/TryWithResources/T7022711.out Changeset: 938dda0bec17 Author: jjg Date: 2011-03-01 12:00 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/938dda0bec17 7021183: 269: assertion failure getting enclosing element of an undefined name Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/code/Symtab.java + test/tools/javac/processing/model/TestSymtabItems.java Changeset: 02b699d97a55 Author: mcimadamore Date: 2011-03-02 10:56 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/02b699d97a55 6541876: "Enclosing Instance" error new in 1.6 Summary: unqualified 'this' should not be selected in a qualified super() call in a default constructor Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Lower.java ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/implicitThis/6541876/T6541876a.java + test/tools/javac/implicitThis/6541876/T6541876b.java ! test/tools/javac/implicitThis/NewBeforeOuterConstructed3.java ! test/tools/javac/nested/4903103/T4903103.java Changeset: 2a5c919f20b8 Author: jjg Date: 2011-03-02 14:03 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/2a5c919f20b8 6986895: compiler gives misleading message for no input files Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/main/Main.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties + test/tools/javac/options/T6986895.java Changeset: 3085d0089546 Author: jjg Date: 2011-03-02 21:06 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3085d0089546 6986892: confusing warning given after errors in annotation processing Reviewed-by: darcy ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java + test/tools/javac/processing/warnings/UseImplicit/C1.java + test/tools/javac/processing/warnings/UseImplicit/TestProcUseImplicitWarning.java + test/tools/javac/processing/warnings/UseImplicit/err.out + test/tools/javac/processing/warnings/UseImplicit/p/C2.java + test/tools/javac/processing/warnings/UseImplicit/warn.out Changeset: 4baab658f357 Author: jjg Date: 2011-03-02 21:13 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/4baab658f357 6639645: Modeling type implementing missing interfaces Reviewed-by: darcy, mcimadamore ! src/share/classes/com/sun/tools/javac/code/Flags.java ! src/share/classes/com/sun/tools/javac/code/Symbol.java ! src/share/classes/com/sun/tools/javac/code/Type.java ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/MemberEnter.java ! src/share/classes/com/sun/tools/javac/parser/JavacParser.java ! src/share/classes/com/sun/tools/javac/tree/JCTree.java ! src/share/classes/com/sun/tools/javac/tree/TreeCopier.java ! src/share/classes/com/sun/tools/javac/tree/TreeMaker.java ! test/tools/javac/api/6557752/T6557752.java + test/tools/javac/processing/model/element/TestMissingElement/InvalidSource.java + test/tools/javac/processing/model/element/TestMissingElement/TestMissingElement.java + test/tools/javac/processing/model/element/TestMissingElement2/Generator.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingClass.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass1.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericClass2.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface1.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingGenericInterface2.java + test/tools/javac/processing/model/element/TestMissingElement2/TestMissingInterface.java Changeset: e9b8fbb30f5a Author: mcimadamore Date: 2011-03-03 09:43 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/e9b8fbb30f5a 7023233: False positive for -Xlint:try with nested try with resources blocks Summary: Wrong lint warning issued about unused resource when nested try-with-resource blocks are found Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/TryWithResources/UnusedResourcesTest.java Changeset: c15d788cb381 Author: mcimadamore Date: 2011-03-03 17:32 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/c15d788cb381 7023703: Valid code doesn't compile Summary: leftovers cause problems when analyzing loops in Flow.java Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Flow.java + test/tools/javac/7023703/T7023703neg.java + test/tools/javac/7023703/T7023703neg.out + test/tools/javac/7023703/T7023703pos.java Changeset: 32565546784b Author: mcimadamore Date: 2011-03-03 17:34 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/32565546784b 7022054: Invalid compiler error on covariant overriding methods with the same erasure Summary: Rules for method clash use notion of subsignature, which is sometimes too strict and incompatible with JDK 6 Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/code/Types.java ! src/share/classes/com/sun/tools/javac/comp/Check.java + test/tools/javac/generics/7022054/T7022054neg1.java + test/tools/javac/generics/7022054/T7022054neg1.out + test/tools/javac/generics/7022054/T7022054neg2.java + test/tools/javac/generics/7022054/T7022054neg2.out + test/tools/javac/generics/7022054/T7022054pos1.java + test/tools/javac/generics/7022054/T7022054pos2.java Changeset: 8fb48a9ac9ec Author: mcimadamore Date: 2011-03-03 18:05 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/8fb48a9ac9ec 7024212: TestWarnErrorCount fails Summary: TestWarnErrorCount should be executed with -Xlint:all,-path to avoid spurious failures Reviewed-by: jjg ! test/tools/javac/processing/TestWarnErrorCount.java Changeset: 7798e3a5ecf5 Author: jjg Date: 2011-03-04 11:33 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/7798e3a5ecf5 6966736: javac verbose output is inconsistent Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/apt/main/AptJavaCompiler.java ! src/share/classes/com/sun/tools/javac/jvm/ClassReader.java ! src/share/classes/com/sun/tools/javac/jvm/ClassWriter.java ! src/share/classes/com/sun/tools/javac/main/JavaCompiler.java ! src/share/classes/com/sun/tools/javac/util/Log.java Changeset: ebf7c13df6c0 Author: jjg Date: 2011-03-04 19:53 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ebf7c13df6c0 6866185: Util.getPackageSourcePath should use lastIndexOf not indexOf and related cleanup Reviewed-by: bpatel ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlDocletWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/HtmlSerialFieldWriter.java ! src/share/classes/com/sun/tools/doclets/formats/html/SourceToHTMLConverter.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/builders/SerializedFormBuilder.java ! src/share/classes/com/sun/tools/doclets/internal/toolkit/util/Util.java ! src/share/classes/com/sun/tools/javadoc/AnnotationDescImpl.java ! src/share/classes/com/sun/tools/javadoc/AnnotationValueImpl.java ! src/share/classes/com/sun/tools/javadoc/ClassDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ExecutableMemberDocImpl.java ! src/share/classes/com/sun/tools/javadoc/FieldDocImpl.java ! src/share/classes/com/sun/tools/javadoc/ParameterizedTypeImpl.java ! src/share/classes/com/sun/tools/javadoc/SeeTagImpl.java ! src/share/classes/com/sun/tools/javadoc/TypeMaker.java ! src/share/classes/com/sun/tools/javadoc/TypeVariableImpl.java ! src/share/classes/com/sun/tools/javadoc/WildcardTypeImpl.java Changeset: 4ee7de0684f5 Author: jjg Date: 2011-03-04 19:56 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/4ee7de0684f5 6227454: package.html and overview.html may not be read fully Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/DocImpl.java ! src/share/classes/com/sun/tools/javadoc/resources/javadoc.properties + test/tools/javadoc/6227454/Test.java Changeset: 5e6c661891da Author: jjg Date: 2011-03-04 19:59 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/5e6c661891da 6964914: javadoc does not output number of warnings using user written doclet Reviewed-by: bpatel ! src/share/classes/com/sun/tools/javadoc/DocletInvoker.java ! src/share/classes/com/sun/tools/javadoc/Messager.java ! src/share/classes/com/sun/tools/javadoc/RootDocImpl.java ! src/share/classes/com/sun/tools/javadoc/Start.java + test/tools/javadoc/6964914/Error.java + test/tools/javadoc/6964914/JavacWarning.java + test/tools/javadoc/6964914/JavadocWarning.java + test/tools/javadoc/6964914/Test.java + test/tools/javadoc/6964914/TestStdDoclet.java + test/tools/javadoc/6964914/TestUserDoclet.java + test/tools/javadoc/T6968833.java Changeset: 74f0c05c51eb Author: mcimadamore Date: 2011-03-07 14:11 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/74f0c05c51eb 7024568: Very long method resolution causing OOM error Summary: Resolve.findMethod scans same receiver type more than once in certain inheritance graphs Reviewed-by: jjg Contributed-by: jan.lahoda at oracle.com ! src/share/classes/com/sun/tools/javac/comp/Resolve.java + test/tools/javac/7024568/T7024568.java + test/tools/javac/7024568/T7024568.out Changeset: ca32f2986301 Author: mcimadamore Date: 2011-03-07 14:31 +0000 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/ca32f2986301 7020044: Project Coin: diamond erroneous allowed on some anonymous inner classes Summary: Disallow diamond on anonymous innner class creation expression (as per JSR 334's EDR) Reviewed-by: jjg ! src/share/classes/com/sun/tools/javac/comp/Attr.java ! src/share/classes/com/sun/tools/javac/comp/Check.java ! src/share/classes/com/sun/tools/javac/resources/compiler.properties ! test/tools/javac/diags/examples.not-yet.txt + test/tools/javac/diags/examples/DiamondAndAnonClass.java - test/tools/javac/diags/examples/DiamondInvalidArg.java - test/tools/javac/diags/examples/DiamondInvalidArgs.java ! test/tools/javac/generics/diamond/6996914/T6996914a.java ! test/tools/javac/generics/diamond/6996914/T6996914b.java ! test/tools/javac/generics/diamond/T6939780.java ! test/tools/javac/generics/diamond/T6939780.out ! test/tools/javac/generics/diamond/neg/Neg01.java ! test/tools/javac/generics/diamond/neg/Neg01.out ! test/tools/javac/generics/diamond/neg/Neg02.java ! test/tools/javac/generics/diamond/neg/Neg02.out ! test/tools/javac/generics/diamond/neg/Neg03.java ! test/tools/javac/generics/diamond/neg/Neg03.out ! test/tools/javac/generics/diamond/neg/Neg04.java ! test/tools/javac/generics/diamond/neg/Neg04.out ! test/tools/javac/generics/diamond/neg/Neg05.java ! test/tools/javac/generics/diamond/neg/Neg05.out ! test/tools/javac/generics/diamond/neg/Neg06.java ! test/tools/javac/generics/diamond/neg/Neg06.out ! test/tools/javac/generics/diamond/neg/Neg07.java ! test/tools/javac/generics/diamond/neg/Neg07.out ! test/tools/javac/generics/diamond/neg/Neg08.java ! test/tools/javac/generics/diamond/neg/Neg08.out ! test/tools/javac/generics/diamond/neg/Neg09.java ! test/tools/javac/generics/diamond/neg/Neg09.out ! test/tools/javac/generics/diamond/neg/Neg10.java ! test/tools/javac/generics/diamond/neg/Neg11.java - test/tools/javac/generics/diamond/neg/Neg12.java - test/tools/javac/generics/diamond/neg/Neg12.out ! test/tools/javac/generics/diamond/pos/Pos01.java ! test/tools/javac/generics/diamond/pos/Pos02.java ! test/tools/javac/generics/diamond/pos/Pos03.java ! test/tools/javac/generics/diamond/pos/Pos04.java ! test/tools/javac/generics/diamond/pos/Pos05.java + test/tools/javac/generics/diamond/pos/Pos06.java + test/tools/javac/generics/diamond/pos/Pos07.java - test/tools/javac/multicatch/Neg05.java - test/tools/javac/multicatch/Neg05.out + test/tools/javac/multicatch/Pos09.java Changeset: b1b898c00b71 Author: lana Date: 2011-03-07 11:37 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/b1b898c00b71 Merge Changeset: cb9493a80341 Author: jjg Date: 2011-03-07 13:45 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/cb9493a80341 6980021: javac should document @file command line option Reviewed-by: mcimadamore ! src/share/classes/com/sun/tools/javac/main/OptionName.java ! src/share/classes/com/sun/tools/javac/main/RecognizedOptions.java ! src/share/classes/com/sun/tools/javac/resources/javac.properties ! test/tools/javac/diags/CheckResourceKeys.java Changeset: d7dfa105f159 Author: lana Date: 2011-03-10 20:51 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/d7dfa105f159 Merge - test/tools/javac/T6900037.java - test/tools/javac/T6900037.out - test/tools/javac/diags/examples/DiamondInvalidArg.java - test/tools/javac/diags/examples/DiamondInvalidArgs.java - test/tools/javac/generics/diamond/neg/Neg12.java - test/tools/javac/generics/diamond/neg/Neg12.out - test/tools/javac/multicatch/Neg05.java - test/tools/javac/multicatch/Neg05.out Changeset: 0f19e1e98b42 Author: mfang Date: 2011-03-08 23:43 -0800 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/0f19e1e98b42 7025324: NLS: t13y fix for 7022005 [ja,zh_CN] javadoc, part of navigation bar in generated html are not translated Reviewed-by: yhuang, ogino, jennyh ! src/share/classes/com/sun/tools/doclets/formats/html/resources/standard.properties Changeset: 654336cabc5a Author: mfang Date: 2011-03-13 14:41 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/654336cabc5a Merge Changeset: 3d7acdbb72ca Author: ohair Date: 2011-03-15 15:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/3d7acdbb72ca Merge Changeset: 9d0a61ac567b Author: schien Date: 2011-03-17 14:33 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/langtools/rev/9d0a61ac567b Added tag jdk7-b134 for changeset 3d7acdbb72ca ! .hgtags From John.Coomes at oracle.com Sat Mar 19 21:51:21 2011 From: John.Coomes at oracle.com (John Coomes) Date: Sat, 19 Mar 2011 21:51:21 -0700 Subject: review request (S): 6962930 make the string table size configurable In-Reply-To: <19818.5813.759794.703682@oracle.com> References: <19804.4627.94089.715688@oracle.com> <4D5C74D1.1040902@oracle.com> <19818.5813.759794.703682@oracle.com> Message-ID: <19845.34761.58775.594369@oracle.com> John Coomes (John.Coomes at oracle.com) wrote: > David Holmes (David.Holmes at oracle.com) wrote: > > Can clarify in globals.hpp whether the size is in bytes, KB, MB. > > Thanks for taking a look. > > It's the number of buckets; I included that info in the doc string and > updated the webrev (same location). I've updated the webrev again based on feedback from Coleen. I changed arguments.cpp so that if a non-default StringTableSize is used, it ensures that class data sharing is disabled. See the same url. I plan to push this tomorrow; a review of this latest snippet isn't critical (Coleen suggested the idea, and it's simply setting flag values). -John > > John Coomes said the following on 02/17/11 04:06: > > > I'd appreciate reviews of a small change to allow the string table > > > size to be set on the command line: > > > > > > http://cr.openjdk.java.net/~jcoomes/6962930-str-tbl-sz/ > > > > > > -John > > > From tom.rodriguez at oracle.com Mon Mar 21 17:26:12 2011 From: tom.rodriguez at oracle.com (tom.rodriguez at oracle.com) Date: Tue, 22 Mar 2011 00:26:12 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7029509: nightly failures after static fields in Class Message-ID: <20110322002616.0CDB54735C@hg.openjdk.java.net> Changeset: 57552dca1708 Author: never Date: 2011-03-21 14:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/57552dca1708 7029509: nightly failures after static fields in Class Reviewed-by: kvn ! src/share/vm/prims/jvmtiRedefineClasses.cpp ! src/share/vm/prims/jvmtiTagMap.cpp ! src/share/vm/services/heapDumper.cpp From john.coomes at oracle.com Tue Mar 22 16:36:46 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Tue, 22 Mar 2011 23:36:46 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <20110322233650.A1F93473A9@hg.openjdk.java.net> Changeset: 924777755fad Author: jcoomes Date: 2011-03-21 18:38 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/924777755fad 6962930: make the string table size configurable Reviewed-by: never, phh, stefank, kamg, dholmes, coleenp ! agent/src/share/classes/sun/jvm/hotspot/memory/StringTable.java ! src/share/vm/classfile/symbolTable.hpp ! src/share/vm/runtime/arguments.cpp ! src/share/vm/runtime/globals.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: b099aaf51bf8 Author: jcoomes Date: 2011-03-22 13:36 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b099aaf51bf8 6962931: move interned strings out of the perm gen Reviewed-by: never, coleenp, ysr, jwilhelm ! src/share/vm/classfile/javaClasses.cpp ! src/share/vm/classfile/symbolTable.cpp ! src/share/vm/gc_implementation/concurrentMarkSweep/concurrentMarkSweepGeneration.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.cpp ! src/share/vm/gc_implementation/parallelScavenge/psScavenge.inline.hpp ! src/share/vm/gc_implementation/parallelScavenge/psTasks.cpp ! src/share/vm/memory/dump.cpp ! src/share/vm/memory/sharedHeap.cpp ! src/share/vm/oops/constantPoolKlass.cpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/memnode.cpp ! src/share/vm/opto/stringopts.cpp ! src/share/vm/opto/type.hpp ! src/share/vm/runtime/globals.hpp From authornari at gmail.com Tue Mar 22 23:11:24 2011 From: authornari at gmail.com (Narihiro Nakamura) Date: Wed, 23 Mar 2011 15:11:24 +0900 Subject: Write barrier for G1GC SATB wasn't atomic? Message-ID: Hi, all. I read G1GC by a hobby. I have one question about write barrier for SATB. I think that satb write barrier is defined in the following points: - cpu/sparc/vm/assembler_sparc.cpp: MacroAssembler::g1_write_barrier_pre() - cpu/x86/vm/assembler_x86.cpp: MacroAssembler::g1_write_barrier_pre() - share/vm/opto/graphKit.cpp: GraphKit::g1_write_barrier_pre() I read their code. I think that the pseudo-cord of "satb write barrier" is as follows: 1: def satb_write_barrier(field, newobj): 2: oldobj = *field // (a) 3: if $gc_phase == GC_CONCURRENT_MARK and oldobj != Null: 4: enqueue($current_thread.stab_mark_queue, oldobj) // (b) 5: *field = newobj // (c) This code doesn't look like in atomic operation from (a) to (b). In that case, when mutator more than 2 try to write *field at the same time, the reference that should record may leak out to satb mark queue. For example. 1. *field == obj0 address 2. t1(Thread1) try to write obj1 address to *field. 3. t2(Thread2) try to write obj2 address to *field. 4. t1 at (a): oldobj = obj0 5. t2 at (a): oldobj = obj0 6. t1 at (b): enqueue obj0 to satb mark queue 7. t2 at (b): enqueue obj0 to satb mark queue 8. t1 at (c): *field = obj1 9. t2 at (c): *field = obj2 In this example, obj1 that should enqueue satb mark queue is leaked. Is this intended behavior? Or, Is it my misunderstanding? Thanks. -- Narihiro Nakamura (nari) http://www.narihiro.info/index.en.html From igor.veresov at oracle.com Wed Mar 23 00:00:43 2011 From: igor.veresov at oracle.com (Igor Veresov) Date: Wed, 23 Mar 2011 00:00:43 -0700 Subject: Write barrier for G1GC SATB wasn't atomic? In-Reply-To: References: Message-ID: <4D899A9B.6000405@oracle.com> That's ok. The goal of SATB is to snapshot the object graph and track the changes to it. So, in your example, obj0 was the contents of the field before the snapshot. It doesn't matter if we capture it multiple times or values that were stored to the field after the snapshot - all of this will be filtered later. The important part is that we captured the value that was before the snapshot at least once. On 3/22/11 11:11 PM, Narihiro Nakamura wrote: > Hi, all. > > I read G1GC by a hobby. > I have one question about write barrier for SATB. > > I think that satb write barrier is defined in the following points: > - cpu/sparc/vm/assembler_sparc.cpp: MacroAssembler::g1_write_barrier_pre() > - cpu/x86/vm/assembler_x86.cpp: MacroAssembler::g1_write_barrier_pre() > - share/vm/opto/graphKit.cpp: GraphKit::g1_write_barrier_pre() > There are also C1 versions in c1_LIRGeneration.cpp, c1_CodeStubs_*.cpp, c1_Runtime_*.cpp. > I read their code. > I think that the pseudo-cord of "satb write barrier" is as follows: > > 1: def satb_write_barrier(field, newobj): > 2: oldobj = *field // (a) > 3: if $gc_phase == GC_CONCURRENT_MARK and oldobj != Null: > 4: enqueue($current_thread.stab_mark_queue, oldobj) // (b) > 5: *field = newobj // (c) > It actually checks if marking is in progress first, then loads the previous value. More importantly, the the marking flag can be set only during a safepoint, so from that point of view, barriers are "atomic" with respect to safepoints, a thread won't enter a safepoint while in the barrier. > This code doesn't look like in atomic operation from (a) to (b). > In that case, when mutator more than 2 try to write *field at the > same time, the reference that should record may leak out to satb > mark queue. > > For example. > 1. *field == obj0 address > 2. t1(Thread1) try to write obj1 address to *field. > 3. t2(Thread2) try to write obj2 address to *field. > 4. t1 at (a): oldobj = obj0 > 5. t2 at (a): oldobj = obj0 > 6. t1 at (b): enqueue obj0 to satb mark queue > 7. t2 at (b): enqueue obj0 to satb mark queue > 8. t1 at (c): *field = obj1 > 9. t2 at (c): *field = obj2 > > In this example, obj1 that should enqueue satb mark queue is leaked. > Yes, we're not interested in obj1 at all. We're only interested in the contents of the field that were there before the marking started. igor > Is this intended behavior? Or, Is it my misunderstanding? > > Thanks. From authornari at gmail.com Wed Mar 23 01:01:24 2011 From: authornari at gmail.com (Narihiro Nakamura) Date: Wed, 23 Mar 2011 17:01:24 +0900 Subject: Write barrier for G1GC SATB wasn't atomic? Message-ID: > That's ok. The goal of SATB is to snapshot the object graph and track > the changes to it. So, in your example, obj0 was the contents of the > field before the snapshot. It doesn't matter if we capture it multiple > times or values that were stored to the field after the snapshot - all > of this will be filtered later. The important part is that we captured > the value that was before the snapshot at least once. Aha! I understand :) Thank you very much for your detailed explanation and quick reply!! -- Narihiro Nakamura (nari) http://www.narihiro.info/index.en.html From tony.printezis at oracle.com Wed Mar 23 07:41:53 2011 From: tony.printezis at oracle.com (Tony Printezis) Date: Wed, 23 Mar 2011 10:41:53 -0400 Subject: Write barrier for G1GC SATB wasn't atomic? In-Reply-To: <4D899A9B.6000405@oracle.com> References: <4D899A9B.6000405@oracle.com> Message-ID: <4D8A06B1.4030305@oracle.com> What Igor said! Narihiro, Nice hobby you have. :-) The SATB barrier was first proposed by Yuasa in this paper (IIRC): Taichi Yuasa. *Real-time garbage collection on general-purpose machines*. / Journal of Systems and Software/, 11(3):181-198, 1990. Tony Igor Veresov wrote: > That's ok. The goal of SATB is to snapshot the object graph and track > the changes to it. So, in your example, obj0 was the contents of the > field before the snapshot. It doesn't matter if we capture it multiple > times or values that were stored to the field after the snapshot - all > of this will be filtered later. The important part is that we captured > the value that was before the snapshot at least once. > > On 3/22/11 11:11 PM, Narihiro Nakamura wrote: >> Hi, all. >> >> I read G1GC by a hobby. >> I have one question about write barrier for SATB. >> >> I think that satb write barrier is defined in the following points: >> - cpu/sparc/vm/assembler_sparc.cpp: >> MacroAssembler::g1_write_barrier_pre() >> - cpu/x86/vm/assembler_x86.cpp: MacroAssembler::g1_write_barrier_pre() >> - share/vm/opto/graphKit.cpp: GraphKit::g1_write_barrier_pre() >> > > There are also C1 versions in c1_LIRGeneration.cpp, > c1_CodeStubs_*.cpp, c1_Runtime_*.cpp. > >> I read their code. >> I think that the pseudo-cord of "satb write barrier" is as follows: >> >> 1: def satb_write_barrier(field, newobj): >> 2: oldobj = *field // (a) >> 3: if $gc_phase == GC_CONCURRENT_MARK and oldobj != Null: >> 4: enqueue($current_thread.stab_mark_queue, oldobj) // (b) >> 5: *field = newobj // (c) >> > > It actually checks if marking is in progress first, then loads the > previous value. More importantly, the the marking flag can be set only > during a safepoint, so from that point of view, barriers are "atomic" > with respect to safepoints, a thread won't enter a safepoint while in > the barrier. > >> This code doesn't look like in atomic operation from (a) to (b). >> In that case, when mutator more than 2 try to write *field at the >> same time, the reference that should record may leak out to satb >> mark queue. >> >> For example. >> 1. *field == obj0 address >> 2. t1(Thread1) try to write obj1 address to *field. >> 3. t2(Thread2) try to write obj2 address to *field. >> 4. t1 at (a): oldobj = obj0 >> 5. t2 at (a): oldobj = obj0 >> 6. t1 at (b): enqueue obj0 to satb mark queue >> 7. t2 at (b): enqueue obj0 to satb mark queue >> 8. t1 at (c): *field = obj1 >> 9. t2 at (c): *field = obj2 >> >> In this example, obj1 that should enqueue satb mark queue is leaked. >> > > Yes, we're not interested in obj1 at all. We're only interested in the > contents of the field that were there before the marking started. > > > igor > >> Is this intended behavior? Or, Is it my misunderstanding? >> >> Thanks. > > From John.Coomes at oracle.com Wed Mar 23 12:15:30 2011 From: John.Coomes at oracle.com (John Coomes) Date: Wed, 23 Mar 2011 12:15:30 -0700 Subject: (Fwd) hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <19850.18130.590547.891557@oracle.com> Apparently this notification didn't get delivered to the hotspot-gc-dev list; here's a copy from the jdk7-changes list. -John -------------- next part -------------- An embedded message was scrubbed... From: john.coomes at oracle.com Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Date: Tue, 22 Mar 2011 23:36:46 +0000 Size: 3735 Url: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110323/d01eb8cb/attachment.nws From kirk at kodewerk.com Wed Mar 23 15:00:40 2011 From: kirk at kodewerk.com (Charles K Pepperdine) Date: Wed, 23 Mar 2011 23:00:40 +0100 Subject: strange gc log In-Reply-To: References: Message-ID: I don't know who is responsible for documentation but I ran into this @ http://www.oracle.com/technetwork/java/javase/gc-tuning-6-140523.html. "Survivor Space Sizing If desired, the parameter SurvivorRatio can be used to tune the size of the survivor spaces, but this is often not as important for performance. <---- Sorry to disagree but I find proper survivor space sizing to be critical to good GC performance more than 1/2 of the GC problems I run into a due to premature promotion of object due to improperly sized survivor spaces. This leads to frequent full GCs. Regards, Kirk -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110323/3520a670/attachment.html From tom.rodriguez at oracle.com Wed Mar 23 20:40:01 2011 From: tom.rodriguez at oracle.com (tom.rodriguez at oracle.com) Date: Thu, 24 Mar 2011 03:40:01 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7030300: more nightly failures after statics in Class changes Message-ID: <20110324034007.9209C47407@hg.openjdk.java.net> Changeset: 32f7097f9d8f Author: never Date: 2011-03-23 10:55 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/32f7097f9d8f 7030300: more nightly failures after statics in Class changes Reviewed-by: iveresov, jcoomes, dcubed ! agent/src/share/classes/sun/jvm/hotspot/utilities/HeapHprofBinWriter.java ! src/cpu/sparc/vm/c1_CodeStubs_sparc.cpp ! src/cpu/x86/vm/c1_CodeStubs_x86.cpp From authornari at gmail.com Wed Mar 23 21:11:43 2011 From: authornari at gmail.com (Narihiro Nakamura) Date: Thu, 24 Mar 2011 13:11:43 +0900 Subject: Write barrier for G1GC SATB wasn't atomic? References: 4D899A9B.6000405@oracle.com Message-ID: <4D8AC47F.9090602@gmail.com> > What Igor said! > > Narihiro, > > Nice hobby you have. :-) Thank you! > The SATB barrier was first proposed by Yuasa in > this paper (IIRC): > > Taichi Yuasa. *Real-time garbage collection on general-purpose > machines*. / Journal of Systems and Software/, 11(3):181-198, 1990. > > Tony Yeah. I've read this paper, but I'll read it once again. --- Narihiro Nakamura(nari) http://www.narihiro.info/index.en.html From y.s.ramakrishna at oracle.com Thu Mar 24 01:15:10 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 24 Mar 2011 01:15:10 -0700 Subject: Request for review (S): 7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC Message-ID: <4D8AFD8E.8020606@oracle.com> I'd like a few reviews for a fix to the following CR:- 7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC Problem: This is a day one performance bug in card-table verification infrastructure in the so-called "gc framework", and affects CMS, ParNew and SerialGC. Details on why the problem was unmasked only recently can be found in the bug report. In a nutshell, existing code has quadratic complexity when scanning large arrays because for an object of size O(n) and with k clean card ranges, the cost is O(k.n), which with O(n) worst case clean card ranges would yield O(n^2) cost. Solution: By using a memory-interval-bounded iteration over the clean card ranges of these objects, the complexity is returned to O(k) which is O(n), because we do not end up scanning an entire prefix of the object each time before scanning each clean range. I also simplified the verification closure (for the product build) by ensuring that the iterator never returns reference locations outside the range of clean cards to the closure, which itself just asserts in non-product builds that this is always the case. (This assertion allowed us to find a few memory-interval-delimited iteration methods which were not respecting the memory-interval provided. That is being separately fixed in CR 7034035; stay tuned.) Testing: The tests listed in the bug report with +VerifyBefore/AfterGC to verify that the heap verification now does not "hang" but rather completes very quickly even with much larger heaps. Also refworkload on solaris/x86 and JPRT testing (ongoing) with heap verification switched on. webrev: http://cr.openjdk.java.net/~ysr/7029036/webrev.00/ Thanks for your reviews! -- ramki From y.s.ramakrishna at oracle.com Thu Mar 24 01:39:13 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 24 Mar 2011 01:39:13 -0700 Subject: Request for review (XS): 7030435: Some oop_oop_iterate_m() methods iterate outside of specified memory bounds Message-ID: <4D8B0331.4070007@oracle.com> This fixes the issues found by the newly added assert in the card-table verification closure, apropos of my last code review request. Tested in the same manner as described in the code review request for 7029036 that i sent a little while ago. webrev: http://cr.openjdk.java.net/~ysr/7030435/webrev.00/ Many thanks for your reviews! -- ramki From jesper.wilhelmsson at oracle.com Thu Mar 24 08:44:09 2011 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 24 Mar 2011 16:44:09 +0100 Subject: Request for review (XS): 7030435: Some oop_oop_iterate_m() methods iterate outside of specified memory bounds In-Reply-To: <4D8B0331.4070007@oracle.com> References: <4D8B0331.4070007@oracle.com> Message-ID: <4D8B66C9.9030700@oracle.com> In case you didn't see my comments on IM: Ship it! /Jesper On 2011-03-24 09:39, Y. Srinivas Ramakrishna wrote: > > This fixes the issues found by the newly added > assert in the card-table verification closure, apropos > of my last code review request. > > Tested in the same manner as described in the code > review request for 7029036 that i sent a little while > ago. > > webrev: http://cr.openjdk.java.net/~ysr/7030435/webrev.00/ > > Many thanks for your reviews! > -- ramki From jesper.wilhelmsson at oracle.com Thu Mar 24 09:01:14 2011 From: jesper.wilhelmsson at oracle.com (Jesper Wilhelmsson) Date: Thu, 24 Mar 2011 17:01:14 +0100 Subject: Request for review (S): 7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC In-Reply-To: <4D8AFD8E.8020606@oracle.com> References: <4D8AFD8E.8020606@oracle.com> Message-ID: <4D8B6ACA.6020903@oracle.com> Is there any particular reason to why you changed it from a while to a for? Either way it looks good. (But it would have looked even better in reviewboard ;)) Ship it! /Jesper On 2011-03-24 09:15, Y. Srinivas Ramakrishna wrote: > > I'd like a few reviews for a fix to the following CR:- > > 7029036: Card-table verification hangs with all framework collectors, except > G1, even before the first GC > > Problem: This is a day one performance bug in card-table verification > infrastructure > in the so-called "gc framework", and affects CMS, ParNew and SerialGC. > Details on why the problem was unmasked only recently can be found in > the bug report. In a nutshell, existing code has quadratic complexity > when scanning large arrays because for an object of size O(n) > and with k clean card ranges, the cost is O(k.n), which with O(n) > worst case clean card ranges would yield O(n^2) cost. > > Solution: By using a memory-interval-bounded iteration over the > clean card ranges of these objects, the complexity is returned > to O(k) which is O(n), because we do not end up scanning an > entire prefix of the object each time before scanning each > clean range. > > I also simplified the verification closure (for the product build) > by ensuring that the iterator never returns reference locations > outside the range of clean cards to the closure, which itself just > asserts in non-product builds that this is always the case. > (This assertion allowed us to find a few memory-interval-delimited > iteration methods which were not respecting the memory-interval provided. > That is being separately fixed in CR 7034035; stay tuned.) > > Testing: The tests listed in the bug report with +VerifyBefore/AfterGC > to verify that the heap verification now does not "hang" but rather > completes very quickly even with much larger heaps. Also refworkload > on solaris/x86 and JPRT testing (ongoing) with > heap verification switched on. > > webrev: http://cr.openjdk.java.net/~ysr/7029036/webrev.00/ > > Thanks for your reviews! > -- ramki From y.s.ramakrishna at oracle.com Thu Mar 24 10:08:02 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 24 Mar 2011 10:08:02 -0700 Subject: Request for review (S): 7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC In-Reply-To: <4D8B6ACA.6020903@oracle.com> References: <4D8AFD8E.8020606@oracle.com> <4D8B6ACA.6020903@oracle.com> Message-ID: <4D8B7A72.5070803@oracle.com> On 3/24/2011 9:01 AM, Jesper Wilhelmsson wrote: > Is there any particular reason to why you changed it from a while to a for? more compact :-) > Either way it looks good. (But it would have looked even better in reviewboard ;)) Yes, we need to get reviewboard talking with openjdk (although i must still say that i find webrev easier to navigate than what reviewboard gives me (especially when i am on my laptop with a relatively small display; from my desktop in the office with its larger display, it would probably look nice, i should try it). I'll definitely start using reviewboard soon; thanks for the hint! :-) > Ship it! Thanks for the review! -- ramki > /Jesper > > On 2011-03-24 09:15, Y. Srinivas Ramakrishna wrote: >> >> I'd like a few reviews for a fix to the following CR:- >> >> 7029036: Card-table verification hangs with all framework collectors, except >> G1, even before the first GC >> >> Problem: This is a day one performance bug in card-table verification >> infrastructure >> in the so-called "gc framework", and affects CMS, ParNew and SerialGC. >> Details on why the problem was unmasked only recently can be found in >> the bug report. In a nutshell, existing code has quadratic complexity >> when scanning large arrays because for an object of size O(n) >> and with k clean card ranges, the cost is O(k.n), which with O(n) >> worst case clean card ranges would yield O(n^2) cost. >> >> Solution: By using a memory-interval-bounded iteration over the >> clean card ranges of these objects, the complexity is returned >> to O(k) which is O(n), because we do not end up scanning an >> entire prefix of the object each time before scanning each >> clean range. >> >> I also simplified the verification closure (for the product build) >> by ensuring that the iterator never returns reference locations >> outside the range of clean cards to the closure, which itself just >> asserts in non-product builds that this is always the case. >> (This assertion allowed us to find a few memory-interval-delimited >> iteration methods which were not respecting the memory-interval provided. >> That is being separately fixed in CR 7034035; stay tuned.) >> >> Testing: The tests listed in the bug report with +VerifyBefore/AfterGC >> to verify that the heap verification now does not "hang" but rather >> completes very quickly even with much larger heaps. Also refworkload >> on solaris/x86 and JPRT testing (ongoing) with >> heap verification switched on. >> >> webrev: http://cr.openjdk.java.net/~ysr/7029036/webrev.00/ >> >> Thanks for your reviews! >> -- ramki From y.s.ramakrishna at oracle.com Thu Mar 24 10:08:58 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 24 Mar 2011 10:08:58 -0700 Subject: Request for review (XS): 7030435: Some oop_oop_iterate_m() methods iterate outside of specified memory bounds In-Reply-To: <4D8B66C9.9030700@oracle.com> References: <4D8B0331.4070007@oracle.com> <4D8B66C9.9030700@oracle.com> Message-ID: <4D8B7AAA.7070609@oracle.com> On 3/24/2011 8:44 AM, Jesper Wilhelmsson wrote: > In case you didn't see my comments on IM: Ship it! Sorry i had stepped away for a bit. Thanks for the review! -- ramki > /Jesper > > On 2011-03-24 09:39, Y. Srinivas Ramakrishna wrote: >> >> This fixes the issues found by the newly added >> assert in the card-table verification closure, apropos >> of my last code review request. >> >> Tested in the same manner as described in the code >> review request for 7029036 that i sent a little while >> ago. >> >> webrev: http://cr.openjdk.java.net/~ysr/7030435/webrev.00/ >> >> Many thanks for your reviews! >> -- ramki From y.s.ramakrishna at oracle.com Thu Mar 24 12:10:35 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 24 Mar 2011 12:10:35 -0700 Subject: Request for review (XS): 7030435: Some oop_oop_iterate_m() methods iterate outside of specified memory bounds In-Reply-To: <4D8B0331.4070007@oracle.com> References: <4D8B0331.4070007@oracle.com> Message-ID: <4D8B972B.9070702@oracle.com> John Coomes brought up the important question of safety of this change in that we might either scan too little now, or were scanning too much before. I thought i'd share the discussion here, and I'd also promised to follow up on (2) below (in terms of checking whether those field updates did card-marks). (1) does scanning outside of the mem-interval cause issues with closures that do not expect to do so: besides the newly modified verification closure, there are scavenging closures that expect that no old-to-new reference is scanned more than once. However, because in this case all of the objects involved are meta-data in perm gen, we are safe since these are not cross-generational into the young gen. (2) does not scanning outside the mem-interval now cause not enough oops to be marked? Recall that the memory-range-delimited iterators are used currently only for card-scanning (either for cross-generational pointers or, as used by CMS, in the form of an incremental update barrier that adds to a modified reference set). For the cross-generational reference case, we are fine because as we noted above the targets are in the same perm-space (at least as of today). If these fields are updated by means of an oop_store() we would be fine even if these were cross-space pointers. It turns out that all of these field updates use either oop_store() (so safe even in the cross-space case), or they use oop_store_wirthout_check(). The latter would be unsafe for cross-space pointers, but is safe for incremental update barriers that collect modified references because in those cases we set AlwaysDoUpdateBarrier which does a card-mark. (If and when some of those using the _without_check() form move to a different space, they might need the _with_check() form for safety, should they need to update remembered set information to allow independent collection.) In summary, the changes are safe today for both our stop-world and for our concurrent CMS collector. However, it's also true, as I noted in the CR, that we didn't really have a correctness issue before; may be perhaps a negligible theoretical (but not real) performance issue wrt sometimes over-scanning by a wee bit. However, fixing the iterators so they stay within the interval specified beings them in line with expectations, intention and specification, and makes for safety and hygiene of client code as it evolves. Many thanks again to everyone for their reviews, and i'll make the modifications stemming from the reviews before pushing these changes. -- ramki On 3/24/2011 1:39 AM, Y. Srinivas Ramakrishna wrote: > > This fixes the issues found by the newly added > assert in the card-table verification closure, apropos > of my last code review request. > > Tested in the same manner as described in the code > review request for 7029036 that i sent a little while > ago. > > webrev: http://cr.openjdk.java.net/~ysr/7030435/webrev.00/ > > Many thanks for your reviews! > -- ramki From y.s.ramakrishna at oracle.com Thu Mar 24 15:03:05 2011 From: y.s.ramakrishna at oracle.com (Y. Srinivas Ramakrishna) Date: Thu, 24 Mar 2011 15:03:05 -0700 Subject: Request for review (XS): 7030435: Some oop_oop_iterate_m() methods iterate outside of specified memory bounds In-Reply-To: <4D8B972B.9070702@oracle.com> References: <4D8B0331.4070007@oracle.com> <4D8B972B.9070702@oracle.com> Message-ID: <4D8BBF99.1020401@oracle.com> A quick fyi: i just synced with hotspot-gc (after ~ a week?), and it turns out that Tom has already made some of these changes (for the case of arrayKlassKlass and objArrayKlassKlass) in a recent putback:- http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c7f3d0b4570f So the only real payload (XXS now :-) that this changeset will contain will be the change to constantPoolKlass. -- ramki On 3/24/2011 12:10 PM, Y. Srinivas Ramakrishna wrote: > John Coomes brought up the important question > of safety of this change in that we might either > scan too little now, or were scanning too much before. > I thought i'd share the discussion here, and I'd also > promised to follow up on (2) below (in terms of checking > whether those field updates did card-marks). > > (1) does scanning outside of the mem-interval cause > issues with closures that do not expect to do so: > besides the newly modified verification closure, > there are scavenging closures that expect that no > old-to-new reference is scanned more than once. > However, because in this case all of the objects > involved are meta-data in perm gen, we are safe > since these are not cross-generational into the > young gen. > > (2) does not scanning outside the mem-interval now > cause not enough oops to be marked? Recall that > the memory-range-delimited iterators are used currently > only for card-scanning (either for cross-generational > pointers or, as used by CMS, in the form of an incremental > update barrier that adds to a modified reference set). > For the cross-generational reference case, we are fine > because as we noted above the targets are in the same > perm-space (at least as of today). > If these fields are updated by means of an oop_store() > we would be fine even if these were cross-space pointers. > It turns out that all of these field updates use either > oop_store() (so safe even in the cross-space case), or > they use oop_store_wirthout_check(). The latter would be > unsafe for cross-space pointers, but is safe for incremental > update barriers that collect modified references because > in those cases we set AlwaysDoUpdateBarrier which does > a card-mark. (If and when some of those using the _without_check() > form move to a different space, they might need the _with_check() > form for safety, should they need to update remembered set > information to allow independent collection.) > > In summary, the changes are safe today for both our stop-world > and for our concurrent CMS collector. However, it's also > true, as I noted in the CR, that we didn't really have > a correctness issue before; may be perhaps a negligible > theoretical (but not real) performance issue wrt sometimes > over-scanning by a wee bit. However, fixing the iterators > so they stay within the interval specified beings them in > line with expectations, intention and specification, > and makes for safety and hygiene of client code as it > evolves. > > Many thanks again to everyone for their reviews, and i'll make > the modifications stemming from the reviews before pushing > these changes. > -- ramki > > On 3/24/2011 1:39 AM, Y. Srinivas Ramakrishna wrote: >> >> This fixes the issues found by the newly added >> assert in the card-table verification closure, apropos >> of my last code review request. >> >> Tested in the same manner as described in the code >> review request for 7029036 that i sent a little while >> ago. >> >> webrev: http://cr.openjdk.java.net/~ysr/7030435/webrev.00/ >> >> Many thanks for your reviews! >> -- ramki > From tony.printezis at oracle.com Fri Mar 25 10:20:10 2011 From: tony.printezis at oracle.com (Tony Printezis) Date: Fri, 25 Mar 2011 13:20:10 -0400 Subject: CRR: 7027766: G1: introduce flag to dump the liveness information per region at the end of marking (S) Message-ID: <4D8CCECA.80603@oracle.com> Hi, I'd like a couple of reviewers to have a look at this change: http://cr.openjdk.java.net/~tonyp/7027766/webrev.0/ I ended up repurposing the existing develop flag G1PrintRegionLivenessInfo for this (I had actually forgotten it was there!) and I print the liveness information at the end of marking twice: - Info for all regions after we finalize the marking information, which means we have both the latest marking information as well as the previous marking information available. - The same info but for all sorted old regions. I attached example output. Tony -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: out Url: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110325/7149ce68/attachment-0001.ksh From y.s.ramakrishna at oracle.com Fri Mar 25 15:15:03 2011 From: y.s.ramakrishna at oracle.com (y.s.ramakrishna at oracle.com) Date: Fri, 25 Mar 2011 22:15:03 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 2 new changesets Message-ID: <20110325221509.E8139474A1@hg.openjdk.java.net> Changeset: a0de1dfd1933 Author: ysr Date: 2011-03-24 15:45 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/a0de1dfd1933 7030435: Some oop_oop_iterate_m() methods iterate outside of specified memory bounds Summary: Filter ref-containing locations through the memory-interval specified in the call. Reviewed-by: jcoomes, jwilhelm, tonyp ! src/share/vm/oops/constantPoolKlass.cpp Changeset: 5134fa1cfe63 Author: ysr Date: 2011-03-24 15:47 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5134fa1cfe63 7029036: Card-table verification hangs with all framework collectors, except G1, even before the first GC Summary: When verifying clean card ranges, use memory-range-bounded iteration over oops of objects overlapping that range, thus avoiding the otherwise quadratic worst-case cost of scanning large object arrays. Reviewed-by: jmasa, jwilhelm, tonyp ! src/share/vm/memory/cardTableRS.cpp From igor.veresov at oracle.com Fri Mar 25 15:38:25 2011 From: igor.veresov at oracle.com (Igor Veresov) Date: Fri, 25 Mar 2011 15:38:25 -0700 Subject: CRR: 7027766: G1: introduce flag to dump the liveness information per region at the end of marking (S) In-Reply-To: <4D8CCECA.80603@oracle.com> References: <4D8CCECA.80603@oracle.com> Message-ID: <4D8D1961.1050808@oracle.com> That's an awesome addition. Looks good. igor On 3/25/11 10:20 AM, Tony Printezis wrote: > Hi, > > I'd like a couple of reviewers to have a look at this change: > > http://cr.openjdk.java.net/~tonyp/7027766/webrev.0/ > > I ended up repurposing the existing develop flag > G1PrintRegionLivenessInfo for this (I had actually forgotten it was > there!) and I print the liveness information at the end of marking twice: > > - Info for all regions after we finalize the marking information, which > means we have both the latest marking information as well as the > previous marking information available. > - The same info but for all sorted old regions. > > I attached example output. > > Tony From john.coomes at oracle.com Sat Mar 26 00:15:59 2011 From: john.coomes at oracle.com (john.coomes at oracle.com) Date: Sat, 26 Mar 2011 07:15:59 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 13 new changesets Message-ID: <20110326071626.AE518474BA@hg.openjdk.java.net> Changeset: 2707f76d15e3 Author: schien Date: 2011-03-17 14:32 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/2707f76d15e3 Added tag jdk7-b134 for changeset 447e6faab4a8 ! .hgtags Changeset: fc1b183bfc0a Author: trims Date: 2011-03-17 17:25 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fc1b183bfc0a Added tag hs21-b04 for changeset 3c76374706ea ! .hgtags Changeset: e97ad5d5c990 Author: trims Date: 2011-03-18 13:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/e97ad5d5c990 Merge Changeset: b898f0fc3ced Author: trims Date: 2011-03-18 13:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/b898f0fc3ced 7028846: Bump the HS21 build number to 05 Summary: Update the HS21 build number to 05 Reviewed-by: jcoomes ! make/hotspot_version Changeset: f195ebb181b8 Author: jcoomes Date: 2011-03-24 23:00 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/f195ebb181b8 Merge Changeset: 3ef1a1866a60 Author: twisti Date: 2011-03-21 02:30 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/3ef1a1866a60 7027232: JSR 292: wrong numeric value returned by MH on solaris-sparc Reviewed-by: kvn, never ! src/cpu/sparc/vm/methodHandles_sparc.cpp Changeset: 9dc311b8473e Author: kvn Date: 2011-03-21 11:28 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/9dc311b8473e 7008866: Missing loop predicate for loop with multiple entries Summary: Add predicates when loop head bytecode is parsed instead of when back branch bytecode is parsed. Reviewed-by: never ! src/share/vm/opto/c2_globals.hpp ! src/share/vm/opto/graphKit.cpp ! src/share/vm/opto/graphKit.hpp ! src/share/vm/opto/idealKit.cpp ! src/share/vm/opto/idealKit.hpp ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/loopTransform.cpp ! src/share/vm/opto/loopUnswitch.cpp ! src/share/vm/opto/loopnode.cpp ! src/share/vm/opto/loopnode.hpp ! src/share/vm/opto/loopopts.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/parse1.cpp ! src/share/vm/opto/parse2.cpp ! src/share/vm/opto/stringopts.cpp Changeset: 0a5d9566b8a4 Author: twisti Date: 2011-03-23 04:19 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0a5d9566b8a4 7029805: JSR 292 compiler/6991596/Test6991596.java fails in nightly Summary: Both JSR 292 compiler tests were moved with 6839872 to the jdk repository Reviewed-by: never - test/compiler/6987555/Test6987555.java - test/compiler/6991596/Test6991596.java Changeset: 0e3ed5a14f73 Author: jcoomes Date: 2011-03-24 23:04 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/0e3ed5a14f73 Merge ! src/share/vm/opto/library_call.cpp ! src/share/vm/opto/parse.hpp ! src/share/vm/opto/stringopts.cpp - test/compiler/6987555/Test6987555.java - test/compiler/6991596/Test6991596.java Changeset: 083f13976b51 Author: dholmes Date: 2011-03-21 22:16 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/083f13976b51 6535709: interrupt of wait()ing thread isn't triggerring InterruptedException - test intwait3 Summary: only clear the interrupt state if we will report that it was set Reviewed-by: dcubed, alanb, phh, coleenp, dice ! src/os/windows/vm/os_windows.cpp ! src/share/vm/runtime/osThread.hpp ! src/share/vm/runtime/vmStructs.cpp Changeset: fc416c2556ec Author: mchung Date: 2011-03-22 18:04 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/fc416c2556ec 7025628: Remove the temporary hack added for jdk modularization in hotspot Summary: Removed Reviewed-by: ohair, coleenp ! src/share/vm/runtime/os.cpp Changeset: 006b3750a4d4 Author: jcoomes Date: 2011-03-24 23:06 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/006b3750a4d4 Merge ! src/share/vm/runtime/vmStructs.cpp Changeset: c6580380076b Author: jcoomes Date: 2011-03-25 17:39 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/c6580380076b Merge From bengt.rutisson at oracle.com Mon Mar 28 08:23:31 2011 From: bengt.rutisson at oracle.com (bengt.rutisson at oracle.com) Date: Mon, 28 Mar 2011 15:23:31 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 6948149: G1: Imbalance in termination times Message-ID: <20110328152333.36B9247540@hg.openjdk.java.net> Changeset: 5c0b591e1074 Author: brutisso Date: 2011-03-23 14:12 +0100 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/5c0b591e1074 6948149: G1: Imbalance in termination times Summary: Changed default value of WorkStealingYieldsBeforeSleep from 1000 to 5000. Added more information to G1 pause logging. Reviewed-by: jwilhelm, tonyp, jmasa ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.cpp ! src/share/vm/gc_implementation/g1/g1CollectorPolicy.hpp ! src/share/vm/runtime/globals.hpp From john.cuthbertson at oracle.com Mon Mar 28 10:35:28 2011 From: john.cuthbertson at oracle.com (John Cuthbertson) Date: Mon, 28 Mar 2011 10:35:28 -0700 Subject: RFR(M): 7009266: G1: assert(obj->is_oop_or_null(true )) failed: Error In-Reply-To: <4D7ACDBA.7020003@oracle.com> References: <4D7ACDBA.7020003@oracle.com> Message-ID: <4D90C6E0.9000901@oracle.com> Hi Everyone, A new webrev with changes based upon comments from Tom can be found at: http://cr.openjdk.java.net/~johnc/7009266/webrev.4/. The latest changes include inserting a suitably guarded barrier call in case the referent field of a Reference object is being read/fetched using JNI, reflection, or Unsafe. Thanks, JohnC On 3/11/2011 5:34 PM, John Cuthbertson wrote: > Hi Everyone, > > I'm looking for a few of volunteers to review the changes that fix > this assertion failure. The latest changes can be found at: > http://cr.openjdk.java.net/~johnc/7009266/webrev.3/ and include > changes based upon earlier internal reviews. The earlier changes are > also on cr.openjdk.java.net for reference. > > Background: > The G1 garbage collector includes a concurrent marking algorithm that > makes use of snapshot-at-the-beginning or SATB. With this algorithm > the GC will mark all objects that are reachable at the start of > marking; objects that are allocated since the start of marking are > implicitly considered live. In order to populate the "snapshot" of the > object graph that existed at the start of marking, G1 employs a write > barrier. When an object is stored into another object's field the > write-barrier records the previous value of that field as it was part > of the "snapshot" and concurrent marking will trace the sub-graph that > is reachable from this previous value. > > Unfortunately, in the presence of Reference objects, SATB might not be > sufficient to mark a referent object as live. Consider that, at the > start of marking, we have a weakly reachable object i.e. an object > where the only pointer to that object. If the referent is obtained > from the Reference object and stored to another object's field (making > the referent now strongly reachable and hence live) the G1 write > barrier will record the field's previous value but not the value of > the referent. > > If the referent object is strongly reachable from some other object > that will be traced by concurrent marking, _or_ there is a subsequent > assignment to the field where we have written the referent (in which > case we record the previous value - the referent - in an SATB buffer) > then the referent will be marked live. Otherwise the referent will not > be marked. > > That is the issue that was causing the failure in this CR. There was a > Logger object that was only reachable through a WeakReference at the > start of concurrent marking. During marking the Logger object is > obtained from the WeakReference and stored into a field of a live > object. The G1 write barrier recorded the previous value in the field > (as it is part of the snapshot at the start of marking). Since there > was no other assignment to the live object's field and there was no > other strong reference to the Logger object, the Logger object was not > marked. At the end of concurrent marking the Logger object was > considered dead and the link between the WeakReference and the Logger > was severed by clearing the referent field during reference processing. > > To solve this (entirely in Hotspot and causing a performance overhead > for G1 only) it was decided that the best approach was to intrinsify > the Reference.get() method in the JIT compilers and add new > interpreter entry points so that the value in the referent field will > be recorded in an SATB buffer by the G1 pre-barrier code. > > The changes for Zero and the C++ interpreters are place holder > routines but should be straight forward to implement. > > None of the individual changes is large - they are just well > distributed around the JVM. :) > > Testing: white box test; eyeballing the generated compiled and > interpreter code; the failing Kitchensink big-app on x86 (32/64 bit), > sparc (32/64 bit), Xint, Xcomp (client and server), with and without > G1; the GC test suite with and without G1; and jprt. > > Thanks and regards, > > JohnC From vladimir.kozlov at oracle.com Mon Mar 28 12:09:26 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Mon, 28 Mar 2011 12:09:26 -0700 Subject: RFR(M): 7009266: G1: assert(obj->is_oop_or_null(true )) failed: Error In-Reply-To: <4D90C6E0.9000901@oracle.com> References: <4D7ACDBA.7020003@oracle.com> <4D90C6E0.9000901@oracle.com> Message-ID: <4D90DCE6.3000804@oracle.com> You need to regenerated webrev since callGenerator.hpp and callGenerator.cpp are empty now. unsafe.cpp: + // We could be accessing the the referent field in a reference ^ Why you are not using update_barrier_set_pre (as in Unsafe_CompareAndSwapObject)? you left test outputs: + tty->print_cr("####### Unsafe_GetObject: offset = " INTX_FORMAT, offset); tty->print_cr("####### Unsafe_GetObject: need a G1 barrier"); Vladimir John Cuthbertson wrote: > Hi Everyone, > > A new webrev with changes based upon comments from Tom can be found at: > http://cr.openjdk.java.net/~johnc/7009266/webrev.4/. > > The latest changes include inserting a suitably guarded barrier call in > case the referent field of a Reference object is being read/fetched > using JNI, reflection, or Unsafe. > > Thanks, > > JohnC > > On 3/11/2011 5:34 PM, John Cuthbertson wrote: >> Hi Everyone, >> >> I'm looking for a few of volunteers to review the changes that fix >> this assertion failure. The latest changes can be found at: >> http://cr.openjdk.java.net/~johnc/7009266/webrev.3/ and include >> changes based upon earlier internal reviews. The earlier changes are >> also on cr.openjdk.java.net for reference. >> >> Background: >> The G1 garbage collector includes a concurrent marking algorithm that >> makes use of snapshot-at-the-beginning or SATB. With this algorithm >> the GC will mark all objects that are reachable at the start of >> marking; objects that are allocated since the start of marking are >> implicitly considered live. In order to populate the "snapshot" of the >> object graph that existed at the start of marking, G1 employs a write >> barrier. When an object is stored into another object's field the >> write-barrier records the previous value of that field as it was part >> of the "snapshot" and concurrent marking will trace the sub-graph that >> is reachable from this previous value. >> >> Unfortunately, in the presence of Reference objects, SATB might not be >> sufficient to mark a referent object as live. Consider that, at the >> start of marking, we have a weakly reachable object i.e. an object >> where the only pointer to that object. If the referent is obtained >> from the Reference object and stored to another object's field (making >> the referent now strongly reachable and hence live) the G1 write >> barrier will record the field's previous value but not the value of >> the referent. >> >> If the referent object is strongly reachable from some other object >> that will be traced by concurrent marking, _or_ there is a subsequent >> assignment to the field where we have written the referent (in which >> case we record the previous value - the referent - in an SATB buffer) >> then the referent will be marked live. Otherwise the referent will not >> be marked. >> >> That is the issue that was causing the failure in this CR. There was a >> Logger object that was only reachable through a WeakReference at the >> start of concurrent marking. During marking the Logger object is >> obtained from the WeakReference and stored into a field of a live >> object. The G1 write barrier recorded the previous value in the field >> (as it is part of the snapshot at the start of marking). Since there >> was no other assignment to the live object's field and there was no >> other strong reference to the Logger object, the Logger object was not >> marked. At the end of concurrent marking the Logger object was >> considered dead and the link between the WeakReference and the Logger >> was severed by clearing the referent field during reference processing. >> >> To solve this (entirely in Hotspot and causing a performance overhead >> for G1 only) it was decided that the best approach was to intrinsify >> the Reference.get() method in the JIT compilers and add new >> interpreter entry points so that the value in the referent field will >> be recorded in an SATB buffer by the G1 pre-barrier code. >> >> The changes for Zero and the C++ interpreters are place holder >> routines but should be straight forward to implement. >> >> None of the individual changes is large - they are just well >> distributed around the JVM. :) >> >> Testing: white box test; eyeballing the generated compiled and >> interpreter code; the failing Kitchensink big-app on x86 (32/64 bit), >> sparc (32/64 bit), Xint, Xcomp (client and server), with and without >> G1; the GC test suite with and without G1; and jprt. >> >> Thanks and regards, >> >> JohnC > From john.cuthbertson at oracle.com Mon Mar 28 12:41:54 2011 From: john.cuthbertson at oracle.com (John Cuthbertson) Date: Mon, 28 Mar 2011 12:41:54 -0700 Subject: RFR(M): 7009266: G1: assert(obj->is_oop_or_null(true )) failed: Error In-Reply-To: <4D90DCE6.3000804@oracle.com> References: <4D7ACDBA.7020003@oracle.com> <4D90C6E0.9000901@oracle.com> <4D90DCE6.3000804@oracle.com> Message-ID: <4D90E482.4050402@oracle.com> Hi Vladimir, On 03/28/11 12:09, Vladimir Kozlov wrote: > You need to regenerated webrev since callGenerator.hpp and > callGenerator.cpp are empty now. OK. I'll make the changes and re-generate > > unsafe.cpp: > + // We could be accessing the the referent field in a reference > ^ > Oops. > Why you are not using update_barrier_set_pre (as in > Unsafe_CompareAndSwapObject)? I didn't know it existed. I'll take a look and see if it's suitable. > > you left test outputs: > + tty->print_cr("####### Unsafe_GetObject: offset = " INTX_FORMAT, > offset); > tty->print_cr("####### Unsafe_GetObject: need a G1 barrier"); > Oops again. I thought I caught all of these. Thanks, JohnC From tom.rodriguez at oracle.com Mon Mar 28 13:00:24 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Mon, 28 Mar 2011 13:00:24 -0700 Subject: RFR(M): 7009266: G1: assert(obj->is_oop_or_null(true )) failed: Error In-Reply-To: <4D90C6E0.9000901@oracle.com> References: <4D7ACDBA.7020003@oracle.com> <4D90C6E0.9000901@oracle.com> Message-ID: <316080F8-7FC4-4CCA-AFE0-915E09FD1BDE@oracle.com> c1_LIRGenerator.cpp: you can't write the branches as you've done them. The register allocator only understands block based control flow and the special case of CodeStubs. It's a limitation of the LIR that unfortunately isn't checked for by any existing asserts. It will work until the allocator decides to place a spill in the middle of your control flow. So you either need to write the guard in the high level IR during parsing or you need to implement it in assembly in a stub on the side. You should also try to constant fold some of these tests by hand since the LIR won't do that for you and in 99.99% of the cases they won't be needed. library_call.cpp: Can you put in the some guards to skip the code generation in cases where it's obviously not needed? Otherwise we're generating a bunch of goo during parsing that we'll just have to optimize away. Something like: TypeX* otype = offset->find_intptr_t_type(); if (otype != NULL && otype->is_con() && otype->get_con() != java_lang_ref_Reference::_reference_offset) { // Constant offset but not the reference_offset so just return return; } TypeOopPtr* btype = base_oop->isa_oop_ptr(); if (btype != NULL && btype->isa_ary_ptr()) { // Array type so nothing to do return; } will filter most uses out completely. Testing for TypeInstPtr would be slightly more complicated though I think something like if (byte->isa_instr_ptr() && !byte->isa_inst_ptr()->klass->is_subtype_of(env()->Reference_klass()) && !env()->Reference_klass()->is_subtype_of(byte->isa_instptr()->klass()) { return; } would work. Actually I don't think you should be testing against reference_type since we can't statically optimize those checks. A regular instance of check can be optimized away if have good type information for the object. Other than the constant formation it's no more expensive than the check you wrote. tom On Mar 28, 2011, at 10:35 AM, John Cuthbertson wrote: > Hi Everyone, > > A new webrev with changes based upon comments from Tom can be found at: http://cr.openjdk.java.net/~johnc/7009266/webrev.4/. > > The latest changes include inserting a suitably guarded barrier call in case the referent field of a Reference object is being read/fetched using JNI, reflection, or Unsafe. > > Thanks, > > JohnC > > On 3/11/2011 5:34 PM, John Cuthbertson wrote: >> Hi Everyone, >> >> I'm looking for a few of volunteers to review the changes that fix this assertion failure. The latest changes can be found at: http://cr.openjdk.java.net/~johnc/7009266/webrev.3/ and include changes based upon earlier internal reviews. The earlier changes are also on cr.openjdk.java.net for reference. >> >> Background: >> The G1 garbage collector includes a concurrent marking algorithm that makes use of snapshot-at-the-beginning or SATB. With this algorithm the GC will mark all objects that are reachable at the start of marking; objects that are allocated since the start of marking are implicitly considered live. In order to populate the "snapshot" of the object graph that existed at the start of marking, G1 employs a write barrier. When an object is stored into another object's field the write-barrier records the previous value of that field as it was part of the "snapshot" and concurrent marking will trace the sub-graph that is reachable from this previous value. >> >> Unfortunately, in the presence of Reference objects, SATB might not be sufficient to mark a referent object as live. Consider that, at the start of marking, we have a weakly reachable object i.e. an object where the only pointer to that object. If the referent is obtained from the Reference object and stored to another object's field (making the referent now strongly reachable and hence live) the G1 write barrier will record the field's previous value but not the value of the referent. >> >> If the referent object is strongly reachable from some other object that will be traced by concurrent marking, _or_ there is a subsequent assignment to the field where we have written the referent (in which case we record the previous value - the referent - in an SATB buffer) then the referent will be marked live. Otherwise the referent will not be marked. >> >> That is the issue that was causing the failure in this CR. There was a Logger object that was only reachable through a WeakReference at the start of concurrent marking. During marking the Logger object is obtained from the WeakReference and stored into a field of a live object. The G1 write barrier recorded the previous value in the field (as it is part of the snapshot at the start of marking). Since there was no other assignment to the live object's field and there was no other strong reference to the Logger object, the Logger object was not marked. At the end of concurrent marking the Logger object was considered dead and the link between the WeakReference and the Logger was severed by clearing the referent field during reference processing. >> >> To solve this (entirely in Hotspot and causing a performance overhead for G1 only) it was decided that the best approach was to intrinsify the Reference.get() method in the JIT compilers and add new interpreter entry points so that the value in the referent field will be recorded in an SATB buffer by the G1 pre-barrier code. >> >> The changes for Zero and the C++ interpreters are place holder routines but should be straight forward to implement. >> >> None of the individual changes is large - they are just well distributed around the JVM. :) >> >> Testing: white box test; eyeballing the generated compiled and interpreter code; the failing Kitchensink big-app on x86 (32/64 bit), sparc (32/64 bit), Xint, Xcomp (client and server), with and without G1; the GC test suite with and without G1; and jprt. >> >> Thanks and regards, >> >> JohnC > From tony.printezis at oracle.com Tue Mar 29 09:21:15 2011 From: tony.printezis at oracle.com (Tony Printezis) Date: Tue, 29 Mar 2011 12:21:15 -0400 Subject: Take 2 : CRR: 7027766: G1: introduce flag to dump the liveness information per region at the end of marking (S) In-Reply-To: <4D8CCECA.80603@oracle.com> References: <4D8CCECA.80603@oracle.com> Message-ID: <4D9206FB.8020900@oracle.com> Hi all, First, thanks to Igor for a very prompt review. After I opened the previous version for code review I realized that if we want to create any graphs based on this information having the information about all the regions in a humongous region series grouped into a single region (which is what I did before) will make the parser work a bit harder to extract the per-region information (and we'd like that information to track what happens to an individual region over time). So, I changed the output format to show the information for humongous regions separately for each individual region. Here's a quick summary of the changes: - Now there are two tags for humongous regions: HUMS (starts humongous) and HUMC (continues humongous) - I removed the capacity per-region as now all the regions have the same capacity which is the region size. So we can save some space there. - Minor cosmetic changes. - I actually turned the flag off by default (I had accidentally set its default value to true before). Latest webrev here: http://cr.openjdk.java.net/~tonyp/7027766/webrev.1/ I attached example output from the new workspace (64-bit this time, and I made sure it also includes some humongous regions). Tony Tony Printezis wrote: > Hi, > > I'd like a couple of reviewers to have a look at this change: > > http://cr.openjdk.java.net/~tonyp/7027766/webrev.0/ > > I ended up repurposing the existing develop flag > G1PrintRegionLivenessInfo for this (I had actually forgotten it was > there!) and I print the liveness information at the end of marking twice: > > - Info for all regions after we finalize the marking information, > which means we have both the latest marking information as well as the > previous marking information available. > - The same info but for all sorted old regions. > > I attached example output. > > Tony -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: out Url: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20110329/4bc79623/attachment-0001.ksh From john.cuthbertson at oracle.com Tue Mar 29 17:01:45 2011 From: john.cuthbertson at oracle.com (john.cuthbertson at oracle.com) Date: Wed, 30 Mar 2011 00:01:45 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7026932: G1: No need to abort VM when card count cache expansion fails Message-ID: <20110330000148.0E85F4759C@hg.openjdk.java.net> Changeset: 02f49b66361a Author: johnc Date: 2011-03-28 10:58 -0700 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/02f49b66361a 7026932: G1: No need to abort VM when card count cache expansion fails Summary: Manage allocation/freeing of the card cache counts and epochs arrays directly so that an allocation failure while attempting to expand these arrays does not abort the JVM. Failure to expand these arrays is not fatal. Reviewed-by: iveresov, tonyp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.cpp ! src/share/vm/gc_implementation/g1/concurrentG1Refine.hpp ! src/share/vm/gc_implementation/g1/g1_globals.hpp From tony.printezis at oracle.com Wed Mar 30 01:42:24 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Wed, 30 Mar 2011 08:42:24 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7029458: G1: Add newly-reclaimed regions to the beginning of the region free list, not the end Message-ID: <20110330084226.5C6F1475C7@hg.openjdk.java.net> Changeset: 455328d90876 Author: tonyp Date: 2011-03-29 22:36 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/455328d90876 7029458: G1: Add newly-reclaimed regions to the beginning of the region free list, not the end Summary: What the synopsis says. Reviewed-by: jwilhelm, iveresov, johnc ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.cpp ! src/share/vm/gc_implementation/g1/heapRegionSet.hpp ! src/share/vm/gc_implementation/g1/heapRegionSet.inline.hpp From tony.printezis at oracle.com Wed Mar 30 10:03:38 2011 From: tony.printezis at oracle.com (tony.printezis at oracle.com) Date: Wed, 30 Mar 2011 17:03:38 +0000 Subject: hg: jdk7/hotspot-gc/hotspot: 7023069: G1: Introduce symmetric locking in the slow allocation path; ... Message-ID: <20110330170340.CEF9C47634@hg.openjdk.java.net> Changeset: abdfc822206f Author: tonyp Date: 2011-03-30 10:26 -0400 URL: http://hg.openjdk.java.net/jdk7/hotspot-gc/hotspot/rev/abdfc822206f 7023069: G1: Introduce symmetric locking in the slow allocation path 7023151: G1: refactor the code that operates on _cur_alloc_region to be re-used for allocs by the GC threads 7018286: G1: humongous allocation attempts should take the GC locker into account Summary: First, this change replaces the asymmetric locking scheme in the G1 slow alloc path by a summetric one. Second, it factors out the code that operates on _cur_alloc_region so that it can be re-used for allocations by the GC threads in the future. Reviewed-by: stefank, brutisso, johnc + src/share/vm/gc_implementation/g1/g1AllocRegion.cpp + src/share/vm/gc_implementation/g1/g1AllocRegion.hpp + src/share/vm/gc_implementation/g1/g1AllocRegion.inline.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.cpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.hpp ! src/share/vm/gc_implementation/g1/g1CollectedHeap.inline.hpp ! src/share/vm/gc_implementation/g1/heapRegion.cpp ! src/share/vm/gc_implementation/g1/heapRegion.hpp ! src/share/vm/gc_implementation/g1/heapRegion.inline.hpp ! src/share/vm/memory/cardTableModRefBS.hpp ! src/share/vm/memory/space.cpp From tom.rodriguez at oracle.com Thu Mar 31 12:41:14 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Thu, 31 Mar 2011 12:41:14 -0700 Subject: possible CMS problem with C2 Message-ID: While looking at the code we generate for a simple program I noticed that we were eliminating card marks with CMS in a illegal fashion. For this simple program: public class test { static Object a1; static Object a2; static Object a3; public static void main(String[] args) { a1 = args; a2 = args; a3 = args; } } we generate this: 000 B1: # N1 <- BLOCK HEAD IS JUNK Freq: 1 000 SAVE R_SP,-72,R_SP 004 SET precise klass test: 0x00843a50:Constant:exact *,R_L0 !ptr 00c + SET 0xf92d4000,R_L2 !ptr 010 + STW R_I0,[R_L0 + #352] ! ptr ! Field test.a3 014 + STW R_I0,[R_L0 + #348] ! ptr ! Field test.a2 018 + SRL R_L0,#9,R_L1 ! Cast ptr R_L0 to int and shift 01c STW R_I0,[R_L0 + #344] ! ptr ! Field test.a1 020 + STB #0,[R_L2 + R_L1] ! CMS card-mark byte 0 024 SETHI #PollAddr,L0 ! Load Polling address LDUW [L0],G0 !Poll for Safepointing RET RESTORE 034 + ! return 034 which happens to be ok because the STB happens last but we don't actually have enough dependences to ensure that we get this schedule. We emit 3 separate StoreCMs for each field references and each one has a dependence on the store that it covers. What's going wrong is that we're allowing StoreCM to participate in the the store elimination in StoreNode::Ideal so we end up with this: 45 StoreP === 5 7 44 10 [[ 16 50 ]] @precise klass test: 0x00843a50:Constant:exact+352 *, name=a3, idx=6; Memory: @precise klass test: 0 x00843a50:Constant:exact+352 *, name=a3, idx=6; !jvms: test::main @ bci:9 36 StoreP === 5 7 35 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+348 *, name=a2, idx=5; Memory: @precise klass test: 0x008 43a50:Constant:exact+348 *, name=a2, idx=5; !jvms: test::main @ bci:5 25 StoreP === 5 7 24 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+344 *, name=a1, idx=4; Memory: @precise klass test: 0x008 43a50:Constant:exact+344 *, name=a1, idx=4; !jvms: test::main @ bci:1 50 StoreCM === 5 7 31 23 45 [[ 16 ]] @rawptr:BotPTR, idx=Raw; Memory: @rawptr:BotPTR, idx=Raw; !jvms: test::main @ bci:9 The store to a3 has a StoreCM and it has killed the StoreCMs for a1 and a2 but it doesn't have a dependence on it. Since the slices are independent the a3 operations could be scheduled before the store to a1 and a2. It may be that this is rare in practice and/or the local schedule tends to put the StoreCM last but it's clearly wrong. G1 is safe from this because the StoreCMs are never close enough to be eliminated. It's easy to fix but it might hurt CMS performance a bit. It could also be done safely if the StoreCM could have dependences on multiple stores but since it's not using normal precedence edges I'm not sure how this would be implemented. Does this sound like any issues that have been seen in the past? tom From y.s.ramakrishna at oracle.com Thu Mar 31 13:52:30 2011 From: y.s.ramakrishna at oracle.com (Y. S. Ramakrishna) Date: Thu, 31 Mar 2011 13:52:30 -0700 Subject: possible CMS problem with C2 In-Reply-To: References: Message-ID: <4D94E98E.1010806@oracle.com> Hi Tom -- On 03/31/11 12:41, Tom Rodriguez wrote: > While looking at the code we generate for a simple program I noticed that we were eliminating card marks with CMS in a illegal fashion. For this simple program: > > public class test { > static Object a1; > static Object a2; > static Object a3; > public static void main(String[] args) { > a1 = args; > a2 = args; > a3 = args; > } > } > > we generate this: > > 000 B1: # N1 <- BLOCK HEAD IS JUNK Freq: 1 > 000 SAVE R_SP,-72,R_SP > 004 SET precise klass test: 0x00843a50:Constant:exact *,R_L0 !ptr > 00c + SET 0xf92d4000,R_L2 !ptr > 010 + STW R_I0,[R_L0 + #352] ! ptr ! Field test.a3 > 014 + STW R_I0,[R_L0 + #348] ! ptr ! Field test.a2 > 018 + SRL R_L0,#9,R_L1 ! Cast ptr R_L0 to int and shift > 01c STW R_I0,[R_L0 + #344] ! ptr ! Field test.a1 > 020 + STB #0,[R_L2 + R_L1] ! CMS card-mark byte 0 > 024 SETHI #PollAddr,L0 ! Load Polling address > LDUW [L0],G0 !Poll for Safepointing > RET > RESTORE > 034 + ! return > 034 > > which happens to be ok because the STB happens last but we don't actually have enough dependences to ensure that we get this schedule. We emit 3 separate StoreCMs for each field references and each one has a dependence on the store that it covers. What's going wrong is that we're allowing StoreCM to participate in the the store elimination in StoreNode::Ideal so we end up with this: > > 45 StoreP === 5 7 44 10 [[ 16 50 ]] @precise klass test: 0x00843a50:Constant:exact+352 *, name=a3, idx=6; Memory: @precise klass test: 0 > x00843a50:Constant:exact+352 *, name=a3, idx=6; !jvms: test::main @ bci:9 > 36 StoreP === 5 7 35 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+348 *, name=a2, idx=5; Memory: @precise klass test: 0x008 > 43a50:Constant:exact+348 *, name=a2, idx=5; !jvms: test::main @ bci:5 > 25 StoreP === 5 7 24 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+344 *, name=a1, idx=4; Memory: @precise klass test: 0x008 > 43a50:Constant:exact+344 *, name=a1, idx=4; !jvms: test::main @ bci:1 > 50 StoreCM === 5 7 31 23 45 [[ 16 ]] @rawptr:BotPTR, idx=Raw; Memory: @rawptr:BotPTR, idx=Raw; !jvms: test::main @ bci:9 > > The store to a3 has a StoreCM and it has killed the StoreCMs for a1 and a2 but it doesn't have a dependence on it. Since the slices are independent the a3 operations could be scheduled before the store to a1 and a2. It may be that this is rare in practice and/or the local schedule tends to put the StoreCM last but it's clearly wrong. G1 is safe from this because the StoreCMs are never close enough to be eliminated. > > It's easy to fix but it might hurt CMS performance a bit. It could also be done safely if the StoreCM could have dependences on multiple stores but since it's not using normal precedence edges I'm not sure how this would be implemented. > > Does this sound like any issues that have been seen in the past? If it's been seen in the past, it has never been identified as stemming from this kind of optimization / missing dependencies. I have heard people (Vladimir, Igor, John Cuthbertson) express the lack of confidence in the existence of sufficient dependencies in some of the card-mark eliminations before. There was a time way back when Mike Paleczny and Ross Knippel had fixed issues stemming from illegal (for CMS) elision of card-marks in the case of CMS, and we had also taken care to add some missing ones in the runtime for perm objects, but this one is new to me. Yes, please fix this; even though i imagine this will be rare because (1) such scheduling may be rare (2) it's only when this intersects with precleaning that this would manifest, and if CMS collections are infrequent, the error will be rare (3) the lack of a card-mark for the elided/rescheduled stores may be masked by a different store to an adjacent object, making an actual crash rarer still. But still, thanks for finding the issue and fixing it! It would be interesting to see how much of a difference in performance the new previously missing dependencies will make to real codes/workloads. -- ramki > > tom From vladimir.kozlov at oracle.com Thu Mar 31 14:03:44 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 31 Mar 2011 14:03:44 -0700 Subject: possible CMS problem with C2 In-Reply-To: <4D94E98E.1010806@oracle.com> References: <4D94E98E.1010806@oracle.com> Message-ID: <4D94EC30.9030301@oracle.com> Tom, Why it is matter when we mark card for this object? There is no safepoint in between. Could you or Ramki explain? Thanks, Vladimir Y. S. Ramakrishna wrote: > Hi Tom -- > > On 03/31/11 12:41, Tom Rodriguez wrote: >> While looking at the code we generate for a simple program I noticed >> that we were eliminating card marks with CMS in a illegal fashion. >> For this simple program: >> >> public class test { >> static Object a1; >> static Object a2; >> static Object a3; >> public static void main(String[] args) { >> a1 = args; >> a2 = args; >> a3 = args; >> } >> } >> >> we generate this: >> >> 000 B1: # N1 <- BLOCK HEAD IS JUNK Freq: 1 >> 000 SAVE R_SP,-72,R_SP >> 004 SET precise klass test: 0x00843a50:Constant:exact >> *,R_L0 !ptr >> 00c + SET 0xf92d4000,R_L2 !ptr >> 010 + STW R_I0,[R_L0 + #352] ! ptr ! Field test.a3 >> 014 + STW R_I0,[R_L0 + #348] ! ptr ! Field test.a2 >> 018 + SRL R_L0,#9,R_L1 ! Cast ptr R_L0 to int and shift >> 01c STW R_I0,[R_L0 + #344] ! ptr ! Field test.a1 >> 020 + STB #0,[R_L2 + R_L1] ! CMS card-mark byte 0 >> 024 SETHI #PollAddr,L0 ! Load Polling address >> LDUW [L0],G0 !Poll for Safepointing >> RET >> RESTORE >> 034 + ! return >> 034 >> >> which happens to be ok because the STB happens last but we don't >> actually have enough dependences to ensure that we get this schedule. >> We emit 3 separate StoreCMs for each field references and each one has >> a dependence on the store that it covers. What's going wrong is that >> we're allowing StoreCM to participate in the the store elimination in >> StoreNode::Ideal so we end up with this: >> >> 45 StoreP === 5 7 44 10 [[ 16 50 ]] @precise klass test: >> 0x00843a50:Constant:exact+352 *, name=a3, idx=6; Memory: @precise >> klass test: 0 >> x00843a50:Constant:exact+352 *, name=a3, idx=6; !jvms: test::main @ bci:9 >> 36 StoreP === 5 7 35 10 [[ 16 ]] @precise klass test: >> 0x00843a50:Constant:exact+348 *, name=a2, idx=5; Memory: @precise >> klass test: 0x008 >> 43a50:Constant:exact+348 *, name=a2, idx=5; !jvms: test::main @ bci:5 >> 25 StoreP === 5 7 24 10 [[ 16 ]] @precise klass test: >> 0x00843a50:Constant:exact+344 *, name=a1, idx=4; Memory: @precise >> klass test: 0x008 >> 43a50:Constant:exact+344 *, name=a1, idx=4; !jvms: test::main @ bci:1 >> 50 StoreCM === 5 7 31 23 45 [[ 16 ]] @rawptr:BotPTR, >> idx=Raw; Memory: @rawptr:BotPTR, idx=Raw; !jvms: test::main @ bci:9 >> >> The store to a3 has a StoreCM and it has killed the StoreCMs for a1 >> and a2 but it doesn't have a dependence on it. Since the slices are >> independent the a3 operations could be scheduled before the store to >> a1 and a2. It may be that this is rare in practice and/or the local >> schedule tends to put the StoreCM last but it's clearly wrong. G1 is >> safe from this because the StoreCMs are never close enough to be >> eliminated. >> >> It's easy to fix but it might hurt CMS performance a bit. It could >> also be done safely if the StoreCM could have dependences on multiple >> stores but since it's not using normal precedence edges I'm not sure >> how this would be implemented. >> >> Does this sound like any issues that have been seen in the past? > > If it's been seen in the past, it has never been identified > as stemming from this kind of optimization / missing dependencies. > I have heard people (Vladimir, Igor, John Cuthbertson) express the lack of > confidence in the existence of sufficient dependencies in some of the > card-mark eliminations before. > > There was a time way back when Mike Paleczny and Ross Knippel > had fixed issues stemming from illegal (for CMS) elision of card-marks > in the case of CMS, and we had also taken care to add some > missing ones in the runtime for perm objects, but this > one is new to me. > > Yes, please fix this; even though i imagine this will be rare > because (1) such scheduling may be rare (2) it's only when this > intersects with precleaning that this would manifest, and if > CMS collections are infrequent, the error will be rare (3) the > lack of a card-mark for the elided/rescheduled stores may be > masked by a different store to an adjacent object, making an > actual crash rarer still. But still, thanks for finding the > issue and fixing it! It would be interesting to see how much > of a difference in performance the new previously missing > dependencies will make to real codes/workloads. > > -- ramki > >> >> tom From tom.rodriguez at oracle.com Thu Mar 31 14:17:19 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Thu, 31 Mar 2011 14:17:19 -0700 Subject: possible CMS problem with C2 In-Reply-To: <4D94EC30.9030301@oracle.com> References: <4D94E98E.1010806@oracle.com> <4D94EC30.9030301@oracle.com> Message-ID: On Mar 31, 2011, at 2:03 PM, Vladimir Kozlov wrote: > Tom, > > Why it is matter when we mark card for this object? There is no safepoint in between. Could you or Ramki explain? Scanning is done concurrently with CMS so it's required that if you see a dirty card that you have also seen all updates within that card so the card update most follow the store. Otherwise you'd never know if you are done with that card. G1 has the same requirement. tom > > Thanks, > Vladimir > > Y. S. Ramakrishna wrote: >> Hi Tom -- >> On 03/31/11 12:41, Tom Rodriguez wrote: >>> While looking at the code we generate for a simple program I noticed that we were eliminating card marks with CMS in a illegal fashion. For this simple program: >>> >>> public class test { >>> static Object a1; >>> static Object a2; >>> static Object a3; >>> public static void main(String[] args) { >>> a1 = args; >>> a2 = args; >>> a3 = args; >>> } >>> } >>> >>> we generate this: >>> >>> 000 B1: # N1 <- BLOCK HEAD IS JUNK Freq: 1 >>> 000 SAVE R_SP,-72,R_SP >>> 004 SET precise klass test: 0x00843a50:Constant:exact *,R_L0 !ptr >>> 00c + SET 0xf92d4000,R_L2 !ptr >>> 010 + STW R_I0,[R_L0 + #352] ! ptr ! Field test.a3 >>> 014 + STW R_I0,[R_L0 + #348] ! ptr ! Field test.a2 >>> 018 + SRL R_L0,#9,R_L1 ! Cast ptr R_L0 to int and shift >>> 01c STW R_I0,[R_L0 + #344] ! ptr ! Field test.a1 >>> 020 + STB #0,[R_L2 + R_L1] ! CMS card-mark byte 0 >>> 024 SETHI #PollAddr,L0 ! Load Polling address >>> LDUW [L0],G0 !Poll for Safepointing >>> RET >>> RESTORE >>> 034 + ! return >>> 034 >>> >>> which happens to be ok because the STB happens last but we don't actually have enough dependences to ensure that we get this schedule. We emit 3 separate StoreCMs for each field references and each one has a dependence on the store that it covers. What's going wrong is that we're allowing StoreCM to participate in the the store elimination in StoreNode::Ideal so we end up with this: >>> >>> 45 StoreP === 5 7 44 10 [[ 16 50 ]] @precise klass test: 0x00843a50:Constant:exact+352 *, name=a3, idx=6; Memory: @precise klass test: 0 >>> x00843a50:Constant:exact+352 *, name=a3, idx=6; !jvms: test::main @ bci:9 >>> 36 StoreP === 5 7 35 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+348 *, name=a2, idx=5; Memory: @precise klass test: 0x008 >>> 43a50:Constant:exact+348 *, name=a2, idx=5; !jvms: test::main @ bci:5 >>> 25 StoreP === 5 7 24 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+344 *, name=a1, idx=4; Memory: @precise klass test: 0x008 >>> 43a50:Constant:exact+344 *, name=a1, idx=4; !jvms: test::main @ bci:1 >>> 50 StoreCM === 5 7 31 23 45 [[ 16 ]] @rawptr:BotPTR, idx=Raw; Memory: @rawptr:BotPTR, idx=Raw; !jvms: test::main @ bci:9 >>> >>> The store to a3 has a StoreCM and it has killed the StoreCMs for a1 and a2 but it doesn't have a dependence on it. Since the slices are independent the a3 operations could be scheduled before the store to a1 and a2. It may be that this is rare in practice and/or the local schedule tends to put the StoreCM last but it's clearly wrong. G1 is safe from this because the StoreCMs are never close enough to be eliminated. >>> >>> It's easy to fix but it might hurt CMS performance a bit. It could also be done safely if the StoreCM could have dependences on multiple stores but since it's not using normal precedence edges I'm not sure how this would be implemented. >>> >>> Does this sound like any issues that have been seen in the past? >> If it's been seen in the past, it has never been identified >> as stemming from this kind of optimization / missing dependencies. >> I have heard people (Vladimir, Igor, John Cuthbertson) express the lack of >> confidence in the existence of sufficient dependencies in some of the >> card-mark eliminations before. >> There was a time way back when Mike Paleczny and Ross Knippel >> had fixed issues stemming from illegal (for CMS) elision of card-marks >> in the case of CMS, and we had also taken care to add some >> missing ones in the runtime for perm objects, but this >> one is new to me. >> Yes, please fix this; even though i imagine this will be rare >> because (1) such scheduling may be rare (2) it's only when this >> intersects with precleaning that this would manifest, and if >> CMS collections are infrequent, the error will be rare (3) the >> lack of a card-mark for the elided/rescheduled stores may be >> masked by a different store to an adjacent object, making an >> actual crash rarer still. But still, thanks for finding the >> issue and fixing it! It would be interesting to see how much >> of a difference in performance the new previously missing >> dependencies will make to real codes/workloads. >> -- ramki >>> >>> tom From tom.rodriguez at oracle.com Thu Mar 31 14:17:52 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Thu, 31 Mar 2011 14:17:52 -0700 Subject: possible CMS problem with C2 In-Reply-To: <4D94E98E.1010806@oracle.com> References: <4D94E98E.1010806@oracle.com> Message-ID: <4811D9BE-A164-4F5D-B291-F9EAE89ED032@oracle.com> I filed 7032963 for this. tom On Mar 31, 2011, at 1:52 PM, Y. S. Ramakrishna wrote: > Hi Tom -- > > On 03/31/11 12:41, Tom Rodriguez wrote: >> While looking at the code we generate for a simple program I noticed that we were eliminating card marks with CMS in a illegal fashion. For this simple program: >> public class test { >> static Object a1; >> static Object a2; >> static Object a3; >> public static void main(String[] args) { >> a1 = args; >> a2 = args; >> a3 = args; >> } >> } >> we generate this: >> 000 B1: # N1 <- BLOCK HEAD IS JUNK Freq: 1 >> 000 SAVE R_SP,-72,R_SP >> 004 SET precise klass test: 0x00843a50:Constant:exact *,R_L0 !ptr >> 00c + SET 0xf92d4000,R_L2 !ptr >> 010 + STW R_I0,[R_L0 + #352] ! ptr ! Field test.a3 >> 014 + STW R_I0,[R_L0 + #348] ! ptr ! Field test.a2 >> 018 + SRL R_L0,#9,R_L1 ! Cast ptr R_L0 to int and shift >> 01c STW R_I0,[R_L0 + #344] ! ptr ! Field test.a1 >> 020 + STB #0,[R_L2 + R_L1] ! CMS card-mark byte 0 >> 024 SETHI #PollAddr,L0 ! Load Polling address >> LDUW [L0],G0 !Poll for Safepointing >> RET >> RESTORE >> 034 + ! return >> 034 >> which happens to be ok because the STB happens last but we don't actually have enough dependences to ensure that we get this schedule. We emit 3 separate StoreCMs for each field references and each one has a dependence on the store that it covers. What's going wrong is that we're allowing StoreCM to participate in the the store elimination in StoreNode::Ideal so we end up with this: >> 45 StoreP === 5 7 44 10 [[ 16 50 ]] @precise klass test: 0x00843a50:Constant:exact+352 *, name=a3, idx=6; Memory: @precise klass test: 0 >> x00843a50:Constant:exact+352 *, name=a3, idx=6; !jvms: test::main @ bci:9 >> 36 StoreP === 5 7 35 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+348 *, name=a2, idx=5; Memory: @precise klass test: 0x008 >> 43a50:Constant:exact+348 *, name=a2, idx=5; !jvms: test::main @ bci:5 >> 25 StoreP === 5 7 24 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+344 *, name=a1, idx=4; Memory: @precise klass test: 0x008 >> 43a50:Constant:exact+344 *, name=a1, idx=4; !jvms: test::main @ bci:1 >> 50 StoreCM === 5 7 31 23 45 [[ 16 ]] @rawptr:BotPTR, idx=Raw; Memory: @rawptr:BotPTR, idx=Raw; !jvms: test::main @ bci:9 >> The store to a3 has a StoreCM and it has killed the StoreCMs for a1 and a2 but it doesn't have a dependence on it. Since the slices are independent the a3 operations could be scheduled before the store to a1 and a2. It may be that this is rare in practice and/or the local schedule tends to put the StoreCM last but it's clearly wrong. G1 is safe from this because the StoreCMs are never close enough to be eliminated. >> It's easy to fix but it might hurt CMS performance a bit. It could also be done safely if the StoreCM could have dependences on multiple stores but since it's not using normal precedence edges I'm not sure how this would be implemented. >> Does this sound like any issues that have been seen in the past? > > If it's been seen in the past, it has never been identified > as stemming from this kind of optimization / missing dependencies. > I have heard people (Vladimir, Igor, John Cuthbertson) express the lack of > confidence in the existence of sufficient dependencies in some of the > card-mark eliminations before. > > There was a time way back when Mike Paleczny and Ross Knippel > had fixed issues stemming from illegal (for CMS) elision of card-marks > in the case of CMS, and we had also taken care to add some > missing ones in the runtime for perm objects, but this > one is new to me. > > Yes, please fix this; even though i imagine this will be rare > because (1) such scheduling may be rare (2) it's only when this > intersects with precleaning that this would manifest, and if > CMS collections are infrequent, the error will be rare (3) the > lack of a card-mark for the elided/rescheduled stores may be > masked by a different store to an adjacent object, making an > actual crash rarer still. But still, thanks for finding the > issue and fixing it! It would be interesting to see how much > of a difference in performance the new previously missing > dependencies will make to real codes/workloads. > > -- ramki > >> tom From vladimir.kozlov at oracle.com Thu Mar 31 14:22:30 2011 From: vladimir.kozlov at oracle.com (Vladimir Kozlov) Date: Thu, 31 Mar 2011 14:22:30 -0700 Subject: possible CMS problem with C2 In-Reply-To: References: <4D94E98E.1010806@oracle.com> <4D94EC30.9030301@oracle.com> Message-ID: <4D94F096.4020606@oracle.com> Got it. thanks, Vladimir Tom Rodriguez wrote: > On Mar 31, 2011, at 2:03 PM, Vladimir Kozlov wrote: > >> Tom, >> >> Why it is matter when we mark card for this object? There is no safepoint in between. Could you or Ramki explain? > > Scanning is done concurrently with CMS so it's required that if you see a dirty card that you have also seen all updates within that card so the card update most follow the store. Otherwise you'd never know if you are done with that card. G1 has the same requirement. > > tom > >> Thanks, >> Vladimir >> >> Y. S. Ramakrishna wrote: >>> Hi Tom -- >>> On 03/31/11 12:41, Tom Rodriguez wrote: >>>> While looking at the code we generate for a simple program I noticed that we were eliminating card marks with CMS in a illegal fashion. For this simple program: >>>> >>>> public class test { >>>> static Object a1; >>>> static Object a2; >>>> static Object a3; >>>> public static void main(String[] args) { >>>> a1 = args; >>>> a2 = args; >>>> a3 = args; >>>> } >>>> } >>>> >>>> we generate this: >>>> >>>> 000 B1: # N1 <- BLOCK HEAD IS JUNK Freq: 1 >>>> 000 SAVE R_SP,-72,R_SP >>>> 004 SET precise klass test: 0x00843a50:Constant:exact *,R_L0 !ptr >>>> 00c + SET 0xf92d4000,R_L2 !ptr >>>> 010 + STW R_I0,[R_L0 + #352] ! ptr ! Field test.a3 >>>> 014 + STW R_I0,[R_L0 + #348] ! ptr ! Field test.a2 >>>> 018 + SRL R_L0,#9,R_L1 ! Cast ptr R_L0 to int and shift >>>> 01c STW R_I0,[R_L0 + #344] ! ptr ! Field test.a1 >>>> 020 + STB #0,[R_L2 + R_L1] ! CMS card-mark byte 0 >>>> 024 SETHI #PollAddr,L0 ! Load Polling address >>>> LDUW [L0],G0 !Poll for Safepointing >>>> RET >>>> RESTORE >>>> 034 + ! return >>>> 034 >>>> >>>> which happens to be ok because the STB happens last but we don't actually have enough dependences to ensure that we get this schedule. We emit 3 separate StoreCMs for each field references and each one has a dependence on the store that it covers. What's going wrong is that we're allowing StoreCM to participate in the the store elimination in StoreNode::Ideal so we end up with this: >>>> >>>> 45 StoreP === 5 7 44 10 [[ 16 50 ]] @precise klass test: 0x00843a50:Constant:exact+352 *, name=a3, idx=6; Memory: @precise klass test: 0 >>>> x00843a50:Constant:exact+352 *, name=a3, idx=6; !jvms: test::main @ bci:9 >>>> 36 StoreP === 5 7 35 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+348 *, name=a2, idx=5; Memory: @precise klass test: 0x008 >>>> 43a50:Constant:exact+348 *, name=a2, idx=5; !jvms: test::main @ bci:5 >>>> 25 StoreP === 5 7 24 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+344 *, name=a1, idx=4; Memory: @precise klass test: 0x008 >>>> 43a50:Constant:exact+344 *, name=a1, idx=4; !jvms: test::main @ bci:1 >>>> 50 StoreCM === 5 7 31 23 45 [[ 16 ]] @rawptr:BotPTR, idx=Raw; Memory: @rawptr:BotPTR, idx=Raw; !jvms: test::main @ bci:9 >>>> >>>> The store to a3 has a StoreCM and it has killed the StoreCMs for a1 and a2 but it doesn't have a dependence on it. Since the slices are independent the a3 operations could be scheduled before the store to a1 and a2. It may be that this is rare in practice and/or the local schedule tends to put the StoreCM last but it's clearly wrong. G1 is safe from this because the StoreCMs are never close enough to be eliminated. >>>> >>>> It's easy to fix but it might hurt CMS performance a bit. It could also be done safely if the StoreCM could have dependences on multiple stores but since it's not using normal precedence edges I'm not sure how this would be implemented. >>>> >>>> Does this sound like any issues that have been seen in the past? >>> If it's been seen in the past, it has never been identified >>> as stemming from this kind of optimization / missing dependencies. >>> I have heard people (Vladimir, Igor, John Cuthbertson) express the lack of >>> confidence in the existence of sufficient dependencies in some of the >>> card-mark eliminations before. >>> There was a time way back when Mike Paleczny and Ross Knippel >>> had fixed issues stemming from illegal (for CMS) elision of card-marks >>> in the case of CMS, and we had also taken care to add some >>> missing ones in the runtime for perm objects, but this >>> one is new to me. >>> Yes, please fix this; even though i imagine this will be rare >>> because (1) such scheduling may be rare (2) it's only when this >>> intersects with precleaning that this would manifest, and if >>> CMS collections are infrequent, the error will be rare (3) the >>> lack of a card-mark for the elided/rescheduled stores may be >>> masked by a different store to an adjacent object, making an >>> actual crash rarer still. But still, thanks for finding the >>> issue and fixing it! It would be interesting to see how much >>> of a difference in performance the new previously missing >>> dependencies will make to real codes/workloads. >>> -- ramki >>>> tom > From tom.rodriguez at oracle.com Thu Mar 31 17:57:41 2011 From: tom.rodriguez at oracle.com (Tom Rodriguez) Date: Thu, 31 Mar 2011 17:57:41 -0700 Subject: possible CMS problem with C2 In-Reply-To: <4811D9BE-A164-4F5D-B291-F9EAE89ED032@oracle.com> References: <4D94E98E.1010806@oracle.com> <4811D9BE-A164-4F5D-B291-F9EAE89ED032@oracle.com> Message-ID: To close the loop on this, here's at least one case of this I found with a little awkery and inspection: 00c B1: # B151 B2 <- BLOCK HEAD IS JUNK Freq: 1 00c ! stack bang SAVE R_SP,-112,R_SP 018 SET 0xf92d4000,R_L1 !ptr 01c + STW R_I3,[R_I0 + #20] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.documentation 020 SRL R_I0,#9,R_L0 ! Cast ptr R_I0 to int and shift 024 + STB #0,[R_L1 + R_L0] ! CMS card-mark byte 0 028 LDUW [R_SP + #188],R_L0 ! spill 02c + STW R_L0,[R_I0 + #28] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.value 030 LDUW [R_SP + #184],R_L1 ! spill 034 + STW R_L1,[R_I0 + #24] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.exp 038 LDUW [R_SP + #176],R_L7 ! spill 03c + STW R_L7,[R_I0 + #36] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.name 040 + STW R_I5,[R_I0 + #16] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.type 044 + STW R_I4,[R_I0 + #12] ! Field spec/benchmarks/_213_javac/FieldDefinition.modifiers 048 STW R_I2,[R_SP + #96] ! spill 04c + STW R_I2,[R_I0 + #32] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.clazz 050 STW R_I1,[R_SP + #92] ! spill 054 + STW R_I1,[R_I0 + #8] ! Field spec/benchmarks/_213_javac/FieldDefinition.where 058 LDUW [R_I5 + #8],R_L1 ! int ! Field spec/benchmarks/_213_javac/Type.typeCode 05c NullCheck R_I5 If we don't eliminate any of the StoreCMs this code looks like this: 00c B1: # B152 B2 <- BLOCK HEAD IS JUNK Freq: 1 00c ! stack bang SAVE R_SP,-112,R_SP 018 SET 0xb53d2000,R_L2 !ptr 01c + SRL R_I0,#9,R_L1 ! Cast ptr R_I0 to int and shift 020 STW R_I2,[R_I0 + #32] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.clazz 024 + ADD R_L2,R_L1,R_L0 028 STW R_I5,[R_I0 + #16] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.type 02c + STB #0,[R_L0] ! CMS card-mark byte 0 030 LDUW [R_SP + #176],R_L3 ! spill 034 + STW R_L3,[R_I0 + #36] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.name 038 + STB #0,[R_L0] ! CMS card-mark byte 0 03c LDUW [R_SP + #184],R_L2 ! spill 040 + STW R_L2,[R_I0 + #24] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.exp 044 + STB #0,[R_L0] ! CMS card-mark byte 0 048 LDUW [R_SP + #188],R_L1 ! spill 04c + STW R_L1,[R_I0 + #28] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.value 050 + STB #0,[R_L0] ! CMS card-mark byte 0 054 + STW R_I3,[R_I0 + #20] ! ptr ! Field spec/benchmarks/_213_javac/FieldDefinition.documentation 058 + STB #0,[R_L0] ! CMS card-mark byte 0 05c + STB #0,[R_L0] ! CMS card-mark byte 0 060 STW R_I1,[R_SP + #92] ! spill 064 + STW R_I1,[R_I0 + #8] ! Field spec/benchmarks/_213_javac/FieldDefinition.where 068 STW R_I2,[R_SP + #96] ! spill 06c + STW R_I4,[R_I0 + #12] ! Field spec/benchmarks/_213_javac/FieldDefinition.modifiers 070 LDUW [R_I5 + #8],R_L1 ! int ! Field spec/benchmarks/_213_javac/Type.typeCode 074 NullCheck R_I5 So it definitely occurs in the wild. I think we're going to need to optimize away the redundant ones since they appear to be fairly common. II see how to do it during final_graph_reshape so that we can accumulate the dependences and place the single one where it should go. tom On Mar 31, 2011, at 2:17 PM, Tom Rodriguez wrote: > I filed 7032963 for this. > > tom > > On Mar 31, 2011, at 1:52 PM, Y. S. Ramakrishna wrote: > >> Hi Tom -- >> >> On 03/31/11 12:41, Tom Rodriguez wrote: >>> While looking at the code we generate for a simple program I noticed that we were eliminating card marks with CMS in a illegal fashion. For this simple program: >>> public class test { >>> static Object a1; >>> static Object a2; >>> static Object a3; >>> public static void main(String[] args) { >>> a1 = args; >>> a2 = args; >>> a3 = args; >>> } >>> } >>> we generate this: >>> 000 B1: # N1 <- BLOCK HEAD IS JUNK Freq: 1 >>> 000 SAVE R_SP,-72,R_SP >>> 004 SET precise klass test: 0x00843a50:Constant:exact *,R_L0 !ptr >>> 00c + SET 0xf92d4000,R_L2 !ptr >>> 010 + STW R_I0,[R_L0 + #352] ! ptr ! Field test.a3 >>> 014 + STW R_I0,[R_L0 + #348] ! ptr ! Field test.a2 >>> 018 + SRL R_L0,#9,R_L1 ! Cast ptr R_L0 to int and shift >>> 01c STW R_I0,[R_L0 + #344] ! ptr ! Field test.a1 >>> 020 + STB #0,[R_L2 + R_L1] ! CMS card-mark byte 0 >>> 024 SETHI #PollAddr,L0 ! Load Polling address >>> LDUW [L0],G0 !Poll for Safepointing >>> RET >>> RESTORE >>> 034 + ! return >>> 034 >>> which happens to be ok because the STB happens last but we don't actually have enough dependences to ensure that we get this schedule. We emit 3 separate StoreCMs for each field references and each one has a dependence on the store that it covers. What's going wrong is that we're allowing StoreCM to participate in the the store elimination in StoreNode::Ideal so we end up with this: >>> 45 StoreP === 5 7 44 10 [[ 16 50 ]] @precise klass test: 0x00843a50:Constant:exact+352 *, name=a3, idx=6; Memory: @precise klass test: 0 >>> x00843a50:Constant:exact+352 *, name=a3, idx=6; !jvms: test::main @ bci:9 >>> 36 StoreP === 5 7 35 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+348 *, name=a2, idx=5; Memory: @precise klass test: 0x008 >>> 43a50:Constant:exact+348 *, name=a2, idx=5; !jvms: test::main @ bci:5 >>> 25 StoreP === 5 7 24 10 [[ 16 ]] @precise klass test: 0x00843a50:Constant:exact+344 *, name=a1, idx=4; Memory: @precise klass test: 0x008 >>> 43a50:Constant:exact+344 *, name=a1, idx=4; !jvms: test::main @ bci:1 >>> 50 StoreCM === 5 7 31 23 45 [[ 16 ]] @rawptr:BotPTR, idx=Raw; Memory: @rawptr:BotPTR, idx=Raw; !jvms: test::main @ bci:9 >>> The store to a3 has a StoreCM and it has killed the StoreCMs for a1 and a2 but it doesn't have a dependence on it. Since the slices are independent the a3 operations could be scheduled before the store to a1 and a2. It may be that this is rare in practice and/or the local schedule tends to put the StoreCM last but it's clearly wrong. G1 is safe from this because the StoreCMs are never close enough to be eliminated. >>> It's easy to fix but it might hurt CMS performance a bit. It could also be done safely if the StoreCM could have dependences on multiple stores but since it's not using normal precedence edges I'm not sure how this would be implemented. >>> Does this sound like any issues that have been seen in the past? >> >> If it's been seen in the past, it has never been identified >> as stemming from this kind of optimization / missing dependencies. >> I have heard people (Vladimir, Igor, John Cuthbertson) express the lack of >> confidence in the existence of sufficient dependencies in some of the >> card-mark eliminations before. >> >> There was a time way back when Mike Paleczny and Ross Knippel >> had fixed issues stemming from illegal (for CMS) elision of card-marks >> in the case of CMS, and we had also taken care to add some >> missing ones in the runtime for perm objects, but this >> one is new to me. >> >> Yes, please fix this; even though i imagine this will be rare >> because (1) such scheduling may be rare (2) it's only when this >> intersects with precleaning that this would manifest, and if >> CMS collections are infrequent, the error will be rare (3) the >> lack of a card-mark for the elided/rescheduled stores may be >> masked by a different store to an adjacent object, making an >> actual crash rarer still. But still, thanks for finding the >> issue and fixing it! It would be interesting to see how much >> of a difference in performance the new previously missing >> dependencies will make to real codes/workloads. >> >> -- ramki >> >>> tom >