review(XXS): 7043564: compile warning and copyright fixes

John Coomes John.Coomes at oracle.com
Tue May 10 12:20:20 PDT 2011


Igor Veresov (igor.veresov at oracle.com) wrote:
> Compilation fails on newer GCCs with :
> os_linux.cpp: In static member function $,1rx(Bstatic bool 
> os::Linux::hugetlbfs_sanity_check(bool, size_t)$,1ry(B:
> os_linux.cpp:2853:43: error: use of assignment suppression and length 
> modifier together in gnu_scanf format
> The solution is to remove the length modifier.

That looks fine.

> Also, copyrights needed to be fixed in a couple of files.

IMHO, better to do those separately; they're unrelated to the build
failure.

-John


More information about the hotspot-gc-dev mailing list