Request for review (xs) - 7112997
jon.masamitsu at oracle.com
Mon Nov 28 10:24:53 PST 2011
Thanks for the review. I've made your suggested changes and
also removed some additional dead code (unused mark_and_follow()
methods) suggested by another reviewer. New webrev is at
On 11/27/11 23:38, Bengt Rutisson wrote:
> I think you removed the only calls to
> ParCompactionManager::should_verify_only() and
> ParCompactionManager::should_reset_only(). Can you remove those
> methods as well? That will propagate to removing the enum values
> VerifyUpdate and ResetObjects in ParCompactionManager::Action.
> Other than that it looks good.
> Thanks for doing cleanups like this one!
> On 2011-11-23 20:24, Jon Masamitsu wrote:
>> 7112997: Remove obsolete code ResetObjectsClosure and
>> Summary: Remove obsolete code.
>> This was debugging code that used the MarkSweep code to check
>> the UseParallelOldGC compaction. It has been broken for sometime
>> and there are no prospects for fixing it.
More information about the hotspot-gc-dev