Request for review (xs) - 7112997
ysr1729 at gmail.com
Mon Nov 28 11:47:48 PST 2011
Looks good. Didn't realize that mark_and_follow() had been dead for so
-- ramki (ysr)
On Mon, Nov 28, 2011 at 10:24 AM, Jon Masamitsu <jon.masamitsu at oracle.com>wrote:
> Thanks for the review. I've made your suggested changes and
> also removed some additional dead code (unused mark_and_follow()
> methods) suggested by another reviewer. New webrev is at
> On 11/27/11 23:38, Bengt Rutisson wrote:
>> I think you removed the only calls to ParCompactionManager::should_**verify_only()
>> and ParCompactionManager::should_**reset_only(). Can you remove those
>> methods as well? That will propagate to removing the enum values
>> VerifyUpdate and ResetObjects in ParCompactionManager::Action.
>> Other than that it looks good.
>> Thanks for doing cleanups like this one!
>> On 2011-11-23 20:24, Jon Masamitsu wrote:
>>> 7112997: Remove obsolete code ResetObjectsClosure and VerifyUpdateClosure
>>> Summary: Remove obsolete code.
>>> This was debugging code that used the MarkSweep code to check
>>> the UseParallelOldGC compaction. It has been broken for sometime
>>> and there are no prospects for fixing it.
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the hotspot-gc-dev