Request for review (L) - 6593758

poonam.bajaj at oracle.com poonam.bajaj at oracle.com
Thu Oct 27 02:49:24 PDT 2011


Hi Jon,

I looked at some of the files and here are few comments:

- concurrentMarkSweepGeneration.cpp, line 5551

Here, flag UseDynamicNumberOfGCThreads can be checked to make the 
decision if we need to use 'active_workers', the way you have done it in 
collectionSetChooser.cpp at line 258

- concurrentMarkSweepGeneration.cpp at line 5899

same as above comment

- concurrentMarkSweepGeneration.cpp, line 5552

Mis-spelled in comments, "active_works" should be "active_workers"


Thanks,
Poonam


On 10/27/2011 4:41 AM, Jon Masamitsu wrote:
> 6593758: RFE: Enhance GC ergonomics to dynamically choose 
> ParallelGCThreads
>
> http://cr.openjdk.java.net/~jmasa/6593758/webrev.00/
>
> Thanks.
>
>

-- 
Best regards, Poonam

Oracle <http://www.oracle.com>
Poonam Bajaj | Principal Member of Technical Staff
Phone: +91 80 66937451 <tel:+91%2080%2066937451> | Mobile: +91 
9844511366 <tel:+91%209844511366>
Oracle JVM Sustaining Engineering

ORACLE India Bangalore
Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20111027/0195e1bb/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20111027/0195e1bb/oracle_sig_logo.gif 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: green-for-email-sig_0.gif
Type: image/gif
Size: 356 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20111027/0195e1bb/green-for-email-sig_0.gif 


More information about the hotspot-gc-dev mailing list