Request for review (L) - 6593758

Jon Masamitsu jon.masamitsu at oracle.com
Thu Oct 27 11:23:35 PDT 2011



On 10/27/11 02:09, Rainer Jung wrote:
> On 27.10.2011 01:11, Jon Masamitsu wrote:
>> 6593758: RFE: Enhance GC ergonomics to dynamically choose ParallelGCThreads
>>
>> http://cr.openjdk.java.net/~jmasa/6593758/webrev.00/
> Interesting feature. Trivial remark:
>
> +  product(uintx, HeapSizePerGCThread, ScaleForWordSize(64*M),
>       \
> +          "Size of heap per GC thread used in calculating the "
>       \
> +          "numnber of GC threads")
>       \
>
> Typo: numnber ->  number
>
> Also: it might be nice to add, which units are used (size in MB or is it
Fixed.

-          "Size of heap per GC thread used in calculating the 
"             \
-          "numnber of GC 
threads")                                          \
+          "Size of heap (bytes) per GC thread used in calculating the 
"     \
+          "number of GC 
threads")                                           \

> in Bytes, does it support the usual scaling suffixes for memory sizes?)

Yes.  -XX:HeapSizePerGCThread=64m is the equivalent of the default.

Thanks.
>
> Regards,
>
> Rainer
>


More information about the hotspot-gc-dev mailing list