RFR(XXXS): 7092245: G1: Wrong format specifier in G1PrintRegionLivenessInfo header output

John Cuthbertson john.cuthbertson at oracle.com
Tue Sep 20 15:22:51 PDT 2011


Hi Everyone,

Can I have a review of the tiny fix for this CR? The webrev can be found 
at: http://cr.openjdk.java.net/~johnc/7092245/webrev.0/

Summary: In the G1PrintRegionLivenessInfo output, the region size in the 
header is printed using a SIZE_FORMAT but is typed as an int. That can 
cause some incorrect output by the 64-bit VM on some systems. The 
solution is to cast the value of HeapRegion::GrainBytes to a size_t in 
the print statement.

Tested using gcbasher:

Old output:
### PHASE Post-Marking @ 1.481
### HEAP  committed: 0x00000000eae00000-0x00000000f4d00000  reserved: 
0x00000000eae00000-0x00000000fae00000  region-size: 139672337514496
###

New output:
### PHASE Post-Marking @ 1.480
### HEAP  committed: 0x00000000eae00000-0x00000000f4d00000  reserved: 
0x00000000eae00000-0x00000000fae00000  region-size: 1048576
###

Thanks,

JohnC


More information about the hotspot-gc-dev mailing list