Request for review (XS): 7091366 re-enable quicksort tests

Bengt Rutisson bengt.rutisson at oracle.com
Mon Sep 26 06:06:30 PDT 2011


Hi all,

This is a small hs23 fix. I hope that we have most of the hs22 work 
behind us, so I thought I'd send this out for review.

http://cr.openjdk.java.net/~brutisso/7091366/webrev/

Background:
One of the tests in the quicksort implementation that I did before the 
summer uses the stdlib::qsort() to verify that my implementation sorts 
the same way that the stdlib does. The tests needs to pass a function 
pointer to stdlib::qsort() and it seems that the older Solaris compilers 
that JDK6 uses requires the function to be declared extern "C" for this 
to work.

John Coomes recently had to make a quick fix to get this to build with 
JDK6 at all. He disabled the tests all together. With my fix now I am 
re-enabling the tests and declaring the call back function extern "C".

I have tested this with jprt and "-relase jdk6". Seems to build fine now.
http://prt-web.us.oracle.com//archive/2011/09/2011-09-26-082420.brutisso.hs-gc-qsfix//JobStatus.txt

With the recent discussions about the Hotspot express model, it seems 
like we might not be supplying this code into JDK6 after all, but I 
would still like to get this fixed.

CR:
7091366 re-enable quicksort tests
http://monaco.us.oracle.com/detail.jsf?cr=7091366

Jesper already looked at the changes, but I need at least one more review.

Thanks,
Bengt


More information about the hotspot-gc-dev mailing list