RFR(S): 7189971: Implement CMSWaitDuration for non-incremental mode of CMS

Srinivas Ramakrishna ysr1729 at gmail.com
Wed Dec 5 14:47:36 PST 2012


The high level idea looks correct. I'll look at the details in a bit
(seriously this time; sorry it dropped off my plate last time I promised).
Does anyone have a pointer to the related discussion thread on this aias
from earlier in the year, by chance, so one could refresh one's
memory of that discussion?

Also you might want to check this with a very long CMSWaitDuration value
and +ExplicitGCInvokesConcurrent, just to further sanity check.

thanks!
-- ramki

On Mon, Oct 29, 2012 at 9:37 AM, John Cuthbertson <
john.cuthbertson at oracle.com> wrote:

> Hi Everyone,
>
> Can I have a couple of volunteers review this change that was submitted by
> Michal Frajt? The webrev can be found at: http://cr.openjdk.java.net/~**
> johnc/7189971/webrev.0/<http://cr.openjdk.java.net/%7Ejohnc/7189971/webrev.0/>
>
> In the original patch, Michal was returning (if the CMS thread was
> terminating or if a foreground collection was scheduled) after setting the
> CMS flag. Michal incorporated my suggestion to change that and return
> before setting the CMS flag.
>
> I'm not an expert in the inner workings of CMS so I'd appreciate further
> reviews from those more familiar with  CMS' operation.
>
> Testing:
> Functional testing was performed using the GC test suite in both
> incremental and non-incremental modes with various values of
> CMSWaitDuration and checking the log files.  Additional tests: nsk, jprt.
>
> Thanks,
>
> JohnC
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20121205/9cab2717/attachment.html 


More information about the hotspot-gc-dev mailing list