Request for review (XS): 8003822: Deprecate the incremental mode of CMS

John Cuthbertson john.cuthbertson at oracle.com
Wed Dec 19 15:55:46 PST 2012


Hi Bengt,

Changes look good to me. You may want to add an 
JDK_Version::is_gte_jdk18x_version() check just in case someone 
mistakenly backports this change or, for some unknown reason,  hs25 is 
placed in a jdk7.

I also want to call out that by not including a FLAG_IS_DEFAULT check, 
you are assuming that none of these flags are enabled by default. This 
is true for us. No change required - just calling it out.

JohnC

On 12/19/2012 4:40 AM, Bengt Rutisson wrote:
>
> Hi all,
>
> Can I have a couple of reviews for this change to deprecate iCMS?
>
> http://cr.openjdk.java.net/~brutisso/8003822/webrev.00/
>
> This is part of the work for JEP 173:
>
> JEP 173: Retire Some Rarely-Used GC Combinations
> http://openjdk.java.net/jeps/173
>
> The webrev is based on the the earlier webrev that I sent out to 
> deprecate the DefNew + CMS and ParNew + SerialOld GC combinations:
>
> http://cr.openjdk.java.net/~brutisso/8003820/webrev.00/
>
> Thanks,
> Bengt



More information about the hotspot-gc-dev mailing list