Request for review (S): 8003820: Deprecate untested and rarely used GC combinations

Bengt Rutisson bengt.rutisson at oracle.com
Thu Dec 20 06:48:07 PST 2012


Hi Ramki,

Thanks for looking at this!

On 12/20/12 1:59 AM, Srinivas Ramakrishna wrote:
> Hi Bengt --
>
> Looks fine (although -- and this not part of the CR -- 
> Arguments::parse() seems to have grown rather large and wants to
> be refactored into a few distinct pieces -- perhaps by "functional 
> module"; but that's another bug).

You are absolutely right. We need to clean Arguments::parse() up, but we 
should not do it as part of this fix. :)

> What happens when you run CMS on a single-processor. I hope you don't 
> see a deprecation warning.

Ooops. Good point. It took me a long while to find a machine with just 
one cpu that could actually run JDK8. But you are correct. We will print 
a warning in that case.

I think the fix is to not pick DefNew by default for single processor 
machines. I'll see if I can get any performance data for that.

Thanks,
Bengt

>
> -- ramki
>
>
> On Tue, Dec 18, 2012 at 6:02 AM, Bengt Rutisson 
> <bengt.rutisson at oracle.com <mailto:bengt.rutisson at oracle.com>> wrote:
>
>
>     Hi all,
>
>     Can I have a couple of reviews for this change to deprecate the
>     DefNew + CMS and ParNew + SerialOld GC combinations?
>
>     http://cr.openjdk.java.net/~brutisso/8003820/webrev.00/
>     <http://cr.openjdk.java.net/%7Ebrutisso/8003820/webrev.00/>
>
>
>     This is part of the work for JEP 173:
>
>     JEP 173: Retire Some Rarely-Used GC Combinations
>     http://openjdk.java.net/jeps/173
>
>     The work is tracked in this bug:
>
>     8003820 : Deprecate untested and rarely used GC combinations
>     http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8003820
>
>     Thanks,
>     Bengt
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20121220/b0fda15f/attachment.html 


More information about the hotspot-gc-dev mailing list