Request for review (XS): 8003822: Deprecate the incremental mode of CMS
bengt.rutisson at oracle.com
Fri Dec 21 05:50:09 PST 2012
Thanks for looking at this!
On 12/20/12 12:55 AM, John Cuthbertson wrote:
> Hi Bengt,
> Changes look good to me. You may want to add an
> JDK_Version::is_gte_jdk18x_version() check just in case someone
> mistakenly backports this change or, for some unknown reason, hs25 is
> placed in a jdk7.
I'm not sure we have to be this defensive. It would not be good if this
change got backported to JDK7.
> I also want to call out that by not including a FLAG_IS_DEFAULT check,
> you are assuming that none of these flags are enabled by default. This
> is true for us. No change required - just calling it out.
Good point. I'll leave it as it for now, though.
> On 12/19/2012 4:40 AM, Bengt Rutisson wrote:
>> Hi all,
>> Can I have a couple of reviews for this change to deprecate iCMS?
>> This is part of the work for JEP 173:
>> JEP 173: Retire Some Rarely-Used GC Combinations
>> The webrev is based on the the earlier webrev that I sent out to
>> deprecate the DefNew + CMS and ParNew + SerialOld GC combinations:
More information about the hotspot-gc-dev