CRR (S): 7129892: G1: explicit marking cycle initiation might fail to initiate a marking cycle

Tony Printezis tony.printezis at oracle.com
Tue Feb 7 10:38:02 PST 2012



On 02/07/2012 12:38 PM, Tony Printezis wrote:
>
> Actually, we don't need to inline anything. The change becomes this 
> (ignore the 0 lines changed in the .hpp file, this is a side-effect of 
> having two MQ patches stacked):
>
> http://cr.openjdk.java.net/~tonyp/7129892/webrev.2/
>
> (note that only when the GC cause is appropriate and any related 
> arguments are set appropriately we try to initiate a conc cycle, so we 
> don't need to recheck)

Scratch the above, I forgot that the method was also checking whether a 
Full GC was done or not (and I think we should still test for that) and 
the above version ignores that. FWIW, John prefers to leave the new 
method in, even just for the documentation aspect (and I agree). Can you 
think of a better name?

Tony



More information about the hotspot-gc-dev mailing list