review(M): 7144296: PS: Optimize nmethods processing

Igor Veresov igor.veresov at oracle.com
Fri Feb 10 17:11:51 PST 2012


Thanks, John! 
Here the updated webrev: http://cr.openjdk.java.net/~iveresov/7144296/webrev.01/

igor


On Friday, February 10, 2012 at 4:50 PM, John Coomes wrote:

> Igor Veresov (igor.veresov at oracle.com (mailto:igor.veresov at oracle.com)) wrote:
> > This change does two things: 
> > 1. Prunes the "scavenge roots in code" list after each minor GC.
> > 2. Promotes objects pointed by code directly into the old gen, instead of ping-ponging them in the survivor spaces.
> > 
> > Webrev: http://cr.openjdk.java.net/~iveresov/7144296/webrev.00/
> 
> Looks good. Minor suggestion - you could use a typedef and get
> meaningful names for the closures, e.g.,
> 
> typedef PSRootsClosure<true> PSScavengeRootsClosure;
> typedef PSRootsClosure<false> PSPromoteRootsClosure;
> 
> To keep the existing name (PSScavengeRootsClosure) the same at the use
> points, the template class has to be renamed. I used PSRootsClosure,
> but any other name would work.
> 
> -John 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20120210/1a41bb3c/attachment.html 


More information about the hotspot-gc-dev mailing list