RFR(XXS): 7147806: G1: Crash in vm bootstrap when running with -XX:+UseG1GC -XX:-UsePerfData

Tony Printezis tony.printezis at oracle.com
Thu Feb 23 05:59:13 PST 2012


My opinion: for small, low risk fixes like this one it'd be a good idea 
to try to get them into hs23.
On the other hand: given that clearly noone has been testing with 
-UsePerfData maybe it doesn't matter. :-)


On 02/23/2012 02:31 AM, Bengt Rutisson wrote:
> Looks good.
> What is the integration plan for this? The bug is a P4. Will you try 
> to get it into hs23 or is it enough that this makes it into hs24?
> Bengt
> On 2012-02-22 21:10, John Cuthbertson wrote:
>> Hi Everyone,
>> Can I have a couple of volunteers to review the changes for this CR? 
>> The webrev can be found at: 
>> http://cr.openjdk.java.net/~johnc/7147806/webrev.0/
>> The issues here was that some updates to the G1 performance counter 
>> variables were not guarded. In the other collectors, the generation 
>> and collector performance counters are allocated/initialized 
>> unconditionally. The performance counter variables that these 
>> counters contain, however, are allocated and updated only if 
>> UsePerfData is enabled. In G1, some of these updates were not 
>> suitably guarded and so we tried to update some unallocated 
>> performance counter variables.
>> Testing:
>> * Small test case (gcbasher) with the offending command line flag 
>> combination and with just G1.
>> Thanks,
>> JohnC

More information about the hotspot-gc-dev mailing list