Request for review (m) - 8022725:Refactor code in concurrentMarkSweepGeneration.cpp

Bengt Rutisson bengt.rutisson at oracle.com
Wed Aug 14 01:50:28 PDT 2013


Hi Jon,

Thanks for doing this cleanup! I think it is really nice to get this done!

It is a bit hard to review this kind of refactoring, but as far as I can 
tell it looks good. There might be more things that can move, but I 
think this is a good start. I think the concurrentMarkSweepHelper.hpp 
file indicates that we have some more cleanups to do. But let's leave 
that for later.

One minor nit. In cmsConcMarkTask.hpp you have the forward declaration 
of class CMSCollector on line 65. I'm more used to seeing the forward 
declarations collected together at the top of the file.

Thanks,
Bengt


On 8/9/13 7:39 PM, Jon Masamitsu wrote:
> 8022725:Refactor code in concurrentMarkSweepGeneration.cpp
>
> concurrentMarkSweepGeneration.cpp is a rather large file and should be 
> refactored (split into multiple
> files) for easier maintenance.
>
> There are no intended semantic changes. Only reorganization and moving 
> of code.
>
> I've been investigating some issues with compiler optimizations on 
> this file and the refactoring will make that doable.
>
> http://cr.openjdk.java.net/~jmasa/8022725/webrev.00/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130814/25a23a89/attachment.html 


More information about the hotspot-gc-dev mailing list