RFR: 7164841: Improvements to the GC log file rotation

Yumin Qi yumin.qi at oracle.com
Thu Aug 15 08:35:07 PDT 2013


Hi,

   Can I have your review for this small changes?
http://cr.openjdk.java.net/~minqi/7164841/webrev00/ 
<http://cr.openjdk.java.net/%7Eminqi/7164841/webrev00/>

    This is for a enhancement to add head/tail message to the logging 
files to assist reading GC output.
    1. modified prompt message if invalid arguments used for log rotating;
    2. add time and file name message to log file head/tail.
    3. for easily identify which log file is current, use file name like 
<filename>.n.current, after it reaches maximum size, rename it to 
<filename>.n
         On Windows, there is no F_OK (existing test) definition, F_OK 
is defined as "0" and for _access of VC++, it just describes:

modevalue

	

Checks file for

00

	

Existence only

02

	

Write-only

04

	

Read-only

06

	

Read and write


http://msdn.microsoft.com/en-us/library/1w06ktdy.aspx
The definition are consistent with unistd.h.

     Test: JPRT and jtreg.

    Thanks
    Yumin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130815/949828ed/attachment-0001.html 


More information about the hotspot-gc-dev mailing list