RFR: 7164841: Improvements to the GC log file rotation

Yasumasa Suenaga suenaga.yasumasa at lab.ntt.co.jp
Sun Aug 18 17:34:08 PDT 2013


Hi Yumin,

I've posted a RFE and patch for adding timestamp, PID, etc to log filename.

JDK-6950794 : Make the GC log file name parameterized
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6950794
http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/2012-July/004758.html

Your patch writes timestamp into logfile.
Howeverm, in production system, we may want to check log generation through
log filename. (e.g. ls command at Linux)

Could you check my patch?


Thanks,

Yasumasa

On 2013/08/16 0:35, Yumin Qi wrote:
> Hi,
>
>    Can I have your review for this small changes?
> http://cr.openjdk.java.net/~minqi/7164841/webrev00/ <http://cr.openjdk.java.net/%7Eminqi/7164841/webrev00/>
>
>     This is for a enhancement to add head/tail message to the logging files to assist reading GC output.
>     1. modified prompt message if invalid arguments used for log rotating;
>     2. add time and file name message to log file head/tail.
>     3. for easily identify which log file is current, use file name like <filename>.n.current, after it reaches maximum size, rename it to <filename>.n
>          On Windows, there is no F_OK (existing test) definition, F_OK is defined as "0" and for _access of VC++, it just describes:
>
> modevalue
>
> 	
>
> Checks file for
>
> 00
>
> 	
>
> Existence only
>
> 02
>
> 	
>
> Write-only
>
> 04
>
> 	
>
> Read-only
>
> 06
>
> 	
>
> Read and write
>
>
> http://msdn.microsoft.com/en-us/library/1w06ktdy.aspx
> The definition are consistent with unistd.h.
>
>      Test: JPRT and jtreg.
>
>     Thanks
>     Yumin



More information about the hotspot-gc-dev mailing list