RFR: 7164841: Improvements to the GC log file rotation

Srinivas Ramakrishna ysr1729 at gmail.com
Mon Aug 19 15:31:25 PDT 2013


Hi Yumin --

Somewhat orthogonal to the discussion at hand, and certainly not a code
review/discussion (so i
apologize for injecting this into $SUBJ) but I wanted to say that log
rotation is definitely a useful capability in the field.

Have you folks perhaps considered two possible enhancements:
(1) rotate logs at a frequency and time specified. (For example, on a
daily, weekly or monthly basis.)
(2) rotate logs asynchronously upon request. (say via a suitable bean.)

If (1) can be simulated by existing means I am all ears.

thanks!
-- ramki



On Thu, Aug 15, 2013 at 8:35 AM, Yumin Qi <yumin.qi at oracle.com> wrote:

>  Hi,
>
>   Can I have your review for this small changes?
>   http://cr.openjdk.java.net/~minqi/7164841/webrev00/
>
>    This is for a enhancement to add head/tail message to the logging files
> to assist reading GC output.
>    1. modified prompt message if invalid arguments used for log rotating;
>    2. add time and file name message to log file head/tail.
>    3. for easily identify which log file is current, use file name like
> <filename>.n.current, after it reaches maximum size, rename it to
> <filename>.n
>         On Windows, there is no F_OK (existing test) definition, F_OK is
> defined as "0" and for _access of VC++, it just describes:
>
>
> mode value
>
> Checks file for
>
> 00
>
> Existence only
>
> 02
>
> Write-only
>
> 04
>
> Read-only
>
> 06
>
> Read and write
>
> http://msdn.microsoft.com/en-us/library/1w06ktdy.aspx
> The definition are consistent with unistd.h.
>
>     Test: JPRT and jtreg.
>
>    Thanks
>    Yumin
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130819/386dfe93/attachment.html 


More information about the hotspot-gc-dev mailing list