RFR (M): 8008918: Reference statistics events for the tracing framework

Thomas Schatzl thomas.schatzl at oracle.com
Mon Mar 4 00:24:37 PST 2013


Hi,

On Fri, 2013-03-01 at 15:09 +0100, Erik Helin wrote:
> Hi all,
> 
> this change adds the vm/gc/reference/statistics event to all collectors.
> 
> Please note that this change depends on "8009232: Improve stats 
> gathering code for reference processor" which is also out for review on
> hotspot-gc-dev at openjdk.java.net.
> 
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8008918/webrev.00/
> 
> Bug:
> https://jbs.oracle.com/bugs/browse/JDK-8008918

Minor: Maybe, in concurrentMarkSweepGeneration.cpp the declaration of
the stats record could be put inside the block.

Do you think if there is an easy way to put the sequence of allocating
the stats record, calling rp->process_discovered_reference and the
report_gc_reference_processing into a single method that is called
everywhere?

This code sequence, is the same in all collectors, and seems to be a
good target for refactoring.

I.e. what the change basically did is to replace the call to
process_discovered_reference by above sequence of three statements.

Hth,
Thomas




More information about the hotspot-gc-dev mailing list