Request for review: 8007762: Rename a bunch of methods in size policy across collectors

Tao Mao tao.mao at oracle.com
Mon Mar 4 16:46:15 PST 2013


Oops...sent to open list.

Thanks.
Tao

On 3/4/2013 4:38 PM, Tao Mao wrote:
> This is the proposed final webrev, with copyright dated appropriately.
> http://cr.openjdk.java.net/~tamao/8007762/webrev.02/
>
> Jon,
> A patch is rendered below. Please take the patch and help push the 
> changeset.
> http://cr.openjdk.java.net/~tamao/8007762/webrev.02/8007762RenameMethodsInSizePolicy.patch
>
> Thank you.
> Tao
>
> On 2/26/13 8:37 AM, Jon Masamitsu wrote:
>> Thanks.
>>
>> Looks good.
>>
>> Jon
>>
>> On 02/25/13 11:09, Tao Mao wrote:
>>> A new webrev is updated.
>>> Thanks.
>>> Tao
>>>
>>> On 2/18/2013 7:46 AM, Jon Masamitsu wrote:
>>>> Tao,
>>>>
>>>> Why this change from resize_old_gen() to
>>>> resize_tenured_gen()?  There are many
>>>> variable names and comments referring to
>>>> "old gen" still in ParallelScavengeHeap.
>>> Reverted.
>>>>
>>>> http://cr.openjdk.java.net/~tamao/8007762/webrev.00/src/share/vm/gc_implementation/parallelScavenge/parallelScavengeHeap.cpp.udiff.html
>>>>
>>>> Jon
>>>>
>>>> On 02/14/13 11:18, Tao Mao wrote:
>>>>> 8007762: Rename a bunch of methods in size policy across collectors
>>>>> https://jbs.oracle.com/bugs/browse/JDK-8007762
>>>>>
>>>>> webrev:
>>>>> http://cr.openjdk.java.net/~tamao/8007762/webrev.00/
>>>>>
>>>>> changeset:
>>>>> The motivation of this change is associated with CR 7098155 
>>>>> (https://jbs.oracle.com/bugs/browse/JDK-7098155). For this, we 
>>>>> need to split compute_generations_free_space into two routine (one 
>>>>> for compute_eden_space_size and the other for 
>>>>> compute_tenured_generation_free_space) in order to save some 
>>>>> overhead when we want to compute only one of the two. The next 
>>>>> step is to split 
>>>>> PSAdaptiveSizePolicy::compute_generations_free_space(), which will 
>>>>> be resolved in CR 8007763.
>>>>>
>>>>> To unify the naming, a bunch of routines are renamed here.
>>>>> (1) compute_*:
>>>>>       compute_survivor_space_size_and_threshold()
>>>>>       compute_generations_free_space() = compute_eden_space_size() 
>>>>> + compute_tenured_generation_free_space()
>>>>> (2) resize_*_gen:
>>>>>       resize_young_gen()
>>>>>       resize_tenured_gen()
>>>>> (3) rename judging routine resize_geneneration() to need_resize() 
>>>>> to avoid ambiguity
>>>>>
>>>>> testing:
>>>>> purely renaming; passed JPRT
>>>>>
>>>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-gc-dev/attachments/20130304/3868b600/attachment.html 


More information about the hotspot-gc-dev mailing list