Request for review: 8008368: Deprecate MaxGCMinorPauseMillis

John Cuthbertson john.cuthbertson at oracle.com
Mon Mar 4 23:20:02 PST 2013


Hi Tao,

I would change the name of the new routine to 
check_deprecated_gc_flags() and I would move the call to after the 
check_deprecated_gcs().

Other than the above it looks good.

You may want to file an enhancement to move some the other deprecated GC 
flags, for which we emit warnings, into the new routine.

JohnC

On 2/28/2013 11:17 AM, Tao Mao wrote:
> 8008368: Deprecate MaxGCMinorPauseMillis
> https://jbs.oracle.com/bugs/browse/JDK-8008368
>
> webrev:
> http://cr.openjdk.java.net/~tamao/8008368/webrev.00/
>
> changeset:
> We don't need the distinction between MaxGCMinorPauseMillis and 
> MaxGCPauseMillis. The MaxGCMinorPauseMillis flag was introduced as a 
> backup measure in case one pause target for all types collections was 
> not enough. As it has turned out it seems one pause target is enough. 
> Thus, we should deprecate MaxGCMinorPauseMillis and give a warning 
> when set.
>
> testing:
> passed JPRT test(sanity)
>



More information about the hotspot-gc-dev mailing list