Request for review: 7196080: assert(max_heap >= InitialHeapSize) in arguments.cpp

Tao Mao tao.mao at oracle.com
Wed Mar 6 14:33:30 PST 2013


7196080: assert(max_heap >= InitialHeapSize) in arguments.cpp
https://jbs.oracle.com/bugs/browse/JDK-7196080

webrev:
http://cr.openjdk.java.net/~tamao/7196080/webrev.00/

changeset:
1. inequality doesn't transfer here.
X >= align_down(X)
X >= I
altogether, cannot infer that align_down(X) >= I. Simple math!
So, I have removed the original assertion "max_heap >= InitialHeapSize".
2. It's reasonable to check an extra assertion "max_heap > = OldSize", 
following the comment above the assertions.


More information about the hotspot-gc-dev mailing list